| Time |
S |
Nick |
Message |
| 00:07 |
|
|
khall joined #koha |
| 00:23 |
|
|
bdonnahue joined #koha |
| 00:30 |
|
|
lisettelatah joined #koha |
| 00:31 |
|
|
inlibro joined #koha |
| 00:45 |
|
|
khall joined #koha |
| 01:03 |
|
|
lisettelatah joined #koha |
| 01:31 |
|
|
inlibro joined #koha |
| 01:34 |
|
|
lisettelatah joined #koha |
| 02:06 |
|
|
lisettelatah joined #koha |
| 02:17 |
|
mtj |
hey #koha |
| 02:18 |
|
mtj |
about hayley, re: 18.11 release stuff? |
| 02:19 |
|
alexbuckley |
hi mtj hayley is unwell today, would you like me to take a message and pass it onto her tomorrow? |
| 02:19 |
|
mtj |
..is your branch all go for me to roll a pkg? |
| 02:20 |
|
mtj |
np alex, i can email her |
| 02:21 |
|
alexbuckley |
righto :) |
| 02:31 |
|
|
inlibro joined #koha |
| 02:39 |
|
mtj |
rangi: are you about for a quick repo chat? |
| 02:39 |
|
rangi |
yep, whats up? |
| 02:40 |
|
mtj |
hiya, me pm you |
| 02:45 |
|
|
lisettelatah joined #koha |
| 03:16 |
|
|
lisettelatah joined #koha |
| 03:32 |
|
|
inlibro joined #koha |
| 03:46 |
|
|
lisettelatah joined #koha |
| 04:19 |
|
|
lisettelatah joined #koha |
| 04:32 |
|
|
inlibro joined #koha |
| 05:32 |
|
|
inlibro joined #koha |
| 05:49 |
|
|
lisettelatah joined #koha |
| 06:01 |
|
|
enkidu joined #koha |
| 06:06 |
|
|
chriss joined #koha |
| 06:21 |
|
|
lisettelatah joined #koha |
| 06:32 |
|
|
inlibro joined #koha |
| 06:35 |
|
ashimema[m] |
Morning #koha |
| 06:40 |
|
|
davidnind joined #koha |
| 06:41 |
|
|
enkidu joined #koha |
| 06:58 |
|
|
cait joined #koha |
| 07:11 |
|
koha-jenkins |
Yippee, build fixed! |
| 07:11 |
|
koha-jenkins |
Project Koha_Master_D9 build #1178: FIXED in 34 min: https://jenkins.koha-community[…]a_Master_D9/1178/ |
| 07:12 |
|
|
did joined #koha |
| 07:32 |
|
|
inlibro joined #koha |
| 07:37 |
|
|
reiveune joined #koha |
| 07:37 |
|
reiveune |
hello |
| 07:38 |
|
|
paul_p joined #koha |
| 07:44 |
|
ere |
morning! |
| 07:45 |
|
ere |
Yay, this will eventually allow the REST API schema to be validated in about half the time it currently takes: https://github.com/mojolicious[…]11dbfe30a5fa75a68 |
| 07:56 |
|
|
lisettelatah joined #koha |
| 07:59 |
|
magnuse |
ere++ |
| 08:10 |
|
|
andreashm joined #koha |
| 08:10 |
|
|
cait joined #koha |
| 08:11 |
|
|
andreashm joined #koha |
| 08:14 |
|
ashimema[m] |
ere++ |
| 08:14 |
|
ashimema[m] |
I see tinita got involved in the yaml side.. |
| 08:15 |
|
ashimema[m] |
interesting to see a recommendation for YAML::PP.. that's a recent shift of opinion, but she is the authority on all things yaml at the moment |
| 08:16 |
|
|
andreash_ joined #koha |
| 08:18 |
|
ere |
ashimema[m]: Well, I'll just do whatever I can guided by the topic experts :) |
| 08:19 |
|
ashimema[m] |
great work following it through ere.. I've always found batman and gang very friendly and approachable.. hopefully you had a similar positive experience :) |
| 08:20 |
|
ere |
ashimema[m]: I did indeed. There was a bit of back and forth, but that's often how it is when things are not so clear-cut. Anyway, even if YAML:PP was used instead of YAML::XS, the perf improvement favors Sereal::Encoder if available. It's easily the fastest one for serialization. |
| 08:20 |
|
ashimema[m] |
:) |
| 08:20 |
|
ere |
And since Koha needs Sereal, we should be good. |
| 08:21 |
|
ashimema[m] |
I think they plan is to use YAML::PP::LibYAML |
| 08:21 |
|
ashimema[m] |
which is basically YAML::XS with PP for the odd bit that's missing from libyaml for the yaml 1.2 spec |
| 08:22 |
|
ashimema[m] |
I forgot we use Sereal.. can't remember where.. |
| 08:22 |
|
ere |
at least it's in cpanfile |
| 08:22 |
|
ashimema[m] |
Sereal is pretty darn quick |
| 08:22 |
|
ashimema[m] |
school run time.. bbiab |
| 08:22 |
|
Joubu |
we use it for cache |
| 08:22 |
|
ashimema[m] |
aha.. make sense |
| 08:22 |
|
ere |
right |
| 08:23 |
|
Joubu |
we replaced Storable with it, for its perf ;) |
| 08:23 |
|
* ashimema[m] |
would like to properly bump the minimum mojo + opanapi + validator versions soon :) |
| 08:23 |
|
ere |
ashimema[m]: (y) |
| 08:25 |
|
ere |
I see that we use Data::Dumper a lot for logging actions. There'd be a possibility of minor optimization. |
| 08:28 |
|
|
lisettelatah joined #koha |
| 08:32 |
|
|
inlibro joined #koha |
| 08:41 |
|
|
did joined #koha |
| 08:47 |
|
ashimema[m] |
mmm, our use of data dumper is often rather silly.. |
| 08:48 |
|
ashimema[m] |
though doesn't Sereal dump to a binary blob rather than something human readable.. I think that's why we use Dumper.. |
| 08:48 |
|
ashimema[m] |
though I've slowly tried to replace it with YAML or JSON when I spotted such cases.. |
| 08:48 |
|
ashimema[m] |
easier to read, consistent to parse etc |
| 08:49 |
|
* ashimema[m] |
is soooo happy to see D10 as 'unstable' rather than just plain 'failed' or 'aborted' for once :) |
| 08:51 |
|
ashimema[m] |
Joubu around still? |
| 08:51 |
|
Joubu |
yep |
| 08:53 |
|
ashimema[m] |
got a Jenkins proposal.. what do you think to the idea of setting up yet another pipeline that uses cpanm to get all the perl deps, at their latest versions on a D10 so we can start to track failures for newer perl dep versions? |
| 08:53 |
|
ashimema[m] |
should be as simple as adding a `cpanm --installdeps .` line into the Dockerfile and removing the apt koha-perl-deps one I reckon |
| 08:54 |
|
Joubu |
worth a try, we will need to display the installed versions |
| 08:55 |
|
paxed |
doesn't the install process show it? |
| 08:55 |
|
ere |
ashimema[m]: Yes, sereal wouldn't work for logging, but YAML or JSON would. |
| 08:55 |
|
ashimema[m] |
it does.. but we currently don't dump a list to anywhere as part of running the test suit paxed.. |
| 08:55 |
|
ashimema[m] |
I think that's what Joubu was getting at.. |
| 08:56 |
|
ashimema[m] |
? |
| 08:56 |
|
|
andreashm joined #koha |
| 08:56 |
|
cait |
Joubu++ thx |
| 08:57 |
|
paxed |
i'd be interested - my new work laptop is d10, but haven't yet moved to actually installing koha on it |
| 08:57 |
|
kohaputti |
Joubu, I would really like to FQA bug 24727 since the commit message doesn't make any sense after switching the link to use detail.pl page instead of the request-acticle.pl where the typo was. |
| 08:57 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24727 major, P5 - low, ---, jonathan.druart, Signed Off , Typo in circulation.js |
| 08:58 |
|
ashimema[m] |
haha.. fair failure kohaputti |
| 08:58 |
|
ashimema[m] |
but also a super simple thing to fix :) |
| 08:59 |
|
Joubu |
kohaputti: feel free to modify it |
| 08:59 |
|
Joubu |
I forgot to update it when I submitted the second patch |
| 09:00 |
|
kohaputti |
Joubu, I don't know why to use detail.pl page so could you re-submit the patch with correct description? |
| 09:00 |
|
Joubu |
why to use article-request? ;) |
| 09:00 |
|
|
lisettelatah joined #koha |
| 09:01 |
|
ashimema[m] |
I asked Kyle to double check that change.. he authored the original I think.. I reckon it was just a mistake during a rebase or something on his part |
| 09:01 |
|
ashimema[m] |
detail makes more sense to me |
| 09:02 |
|
kohaputti |
bbl |
| 09:02 |
|
Joubu |
kohaputti: done |
| 09:03 |
|
Joubu |
ashimema[m]: first patch on the bug report has the "typo" |
| 09:09 |
|
paxed |
hm. testing master, I can't now even start the install, because I immediately get "Can't locate Email/MessageID.pm in @INC"? |
| 09:12 |
|
paxed |
ah, bug 24588 |
| 09:12 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24588 enhancement, P5 - low, ---, ulrich.kleiber, Pushed to master , Set `Mailer-X` and `MessageID` mail headers to reduce the likelihood of Koha mail being marked as spam |
| 09:14 |
|
ashimema[m] |
yup.. it's a new dependancy |
| 09:14 |
|
ashimema[m] |
we've introduced a few recently |
| 09:14 |
|
ashimema[m] |
I intend to try and drop a few too... I'd really like to see us using one and only one yaml module for example |
| 09:15 |
|
paxed |
ashimema[m]: right, the software error that popped up instead of the install page was a bit of a surprise tho :) |
| 09:16 |
|
ashimema[m] |
yeah.. I intend to take a look at that.. it shouldn't explode as early as it does |
| 09:16 |
|
ashimema[m] |
I should add a bug for that |
| 09:28 |
|
|
greenjimll joined #koha |
| 09:31 |
|
|
davidnind left #koha |
| 09:33 |
|
|
inlibro joined #koha |
| 09:36 |
|
|
vfernandes joined #koha |
| 10:03 |
|
|
magnuse joined #koha |
| 10:07 |
|
paxed |
hmm. can anyone confirm something for me? I'm getting this when i run translate update fi-FI: |
| 10:07 |
|
paxed |
Can't stat /usr/share/koha/intranet/cgi-bin/koha-tmpl/intranet-tmpl/prog/js: No such file or directory at /usr/share/koha/misc/translator/LangInstaller.pm line 715. |
| 10:08 |
|
paxed |
looks like LangInstaller is looking in $intranetdir - it should be looking for $intrahtdocs instead? |
| 10:09 |
|
paxed |
(compare the @js_dirs with @intranet_tt_files) |
| 10:10 |
|
cait |
could be a bug recently reported |
| 10:10 |
|
cait |
sec |
| 10:11 |
|
cait |
bug 24664 |
| 10:11 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24664 enhancement, P5 - low, ---, bgkriegel, Signed Off , Add missing *-messages-js.po |
| 10:11 |
|
cait |
hm error is a bit different, so not sure |
| 10:13 |
|
paxed |
well, once i changed LangInstaller to look in the correct dir, it found the files, but then hits missing po-files, which is fixed by that bug ^ |
| 10:13 |
|
paxed |
well, i'll report it |
| 10:28 |
|
|
magnuse joined #koha |
| 10:28 |
|
|
lisettelatah joined #koha |
| 10:29 |
|
paxed |
also, the parser doesn't seem to like checkouts.js, as it dies on it ... |
| 10:33 |
|
|
inlibro joined #koha |
| 10:36 |
|
Joubu |
paxed: bug 24725 |
| 10:36 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24725 normal, P5 - low, ---, jonathan.druart, Needs Signoff , xgettext does not support (yet) ES template literals |
| 10:36 |
|
paxed |
ah |
| 10:38 |
|
paxed |
backticks and "smart quotes" are from the devil. |
| 11:01 |
|
|
lisettelatah joined #koha |
| 11:02 |
|
|
andreash_ joined #koha |
| 11:06 |
|
|
khall joined #koha |
| 11:09 |
|
mtj |
hey #koha |
| 11:10 |
|
mtj |
ashimema[m]: re buster/mojo... i realised i had added a distro=buster repo, to get the koha tests to pass |
| 11:11 |
|
* mtj |
had forgotten that.. |
| 11:14 |
|
mtj |
there are a few general solutions - i'll put them in an email to the dev list, and see what option people prefer |
| 11:18 |
|
ashimema[m] |
brill |
| 11:19 |
|
ashimema[m] |
we're not in bad shape right now as I've added them to the dockerfile via cpan.. but it would be great to have packaging options to make it as easy as possible for users |
| 11:27 |
|
|
ere_ joined #koha |
| 11:33 |
|
|
inlibro joined #koha |
| 11:35 |
|
|
lisettelatah joined #koha |
| 11:52 |
|
|
magnuse joined #koha |
| 11:58 |
|
|
khall joined #koha |
| 12:05 |
|
|
ere joined #koha |
| 12:07 |
|
|
lisettelatah joined #koha |
| 12:14 |
|
|
khall joined #koha |
| 12:30 |
|
|
oleonard joined #koha |
| 12:33 |
|
|
inlibro joined #koha |
| 12:37 |
|
|
lisettelatah joined #koha |
| 12:38 |
|
oleonard |
Hi #koha |
| 12:44 |
|
Joubu |
bug 24735 |
| 12:44 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24735 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Remove QueryParser-related code |
| 12:48 |
|
* oleonard |
pours one out for poor dead QueryParser |
| 12:48 |
|
|
andreashm joined #koha |
| 12:50 |
|
|
andreashm joined #koha |
| 12:55 |
|
|
khall joined #koha |
| 12:58 |
|
oleonard |
Does anyone have a suggestion for how to diagnose this error with kohadevbox? "The proxy server received an invalid response from an upstream server." |
| 12:59 |
|
oleonard |
...when trying to access Koha from the host. |
| 13:00 |
|
kohaputti |
Joubu, regarding bug 23463, it is yet another massive refactoring meaning QA person has to spend a long chunk of time on it and cannot split it easily. In the future IMHO it would be better to refactor smaller parts at a time |
| 13:00 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23463 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Move C4::Items CRUD subroutines to Koha::Item |
| 13:01 |
|
Joubu |
kohaputti: it's not possible |
| 13:01 |
|
Joubu |
it's split in patches |
| 13:02 |
|
Joubu |
it would be a nightmare to get half of the work pushed, then push debug, then rebase, then wait 6 months for the other patches to be tested |
| 13:02 |
|
Joubu |
it's not that big, it removes more code than it adds |
| 13:03 |
|
kohaputti |
ok, that could be the case but this big patch set is also the reason why finding QA person takes a long time |
| 13:04 |
|
Joubu |
of course, I know |
| 13:06 |
|
* ashimema[m] |
tries really hard to split work into smaller bugs |
| 13:07 |
|
ashimema[m] |
but then gets dissalusioned when only part of the overall piece gets into a release and the end result is actually a worse case than before the work was undertaken |
| 13:07 |
|
ashimema[m] |
so I agree with both side I'm afraid.. |
| 13:08 |
|
ashimema[m] |
Joubu's bugs are a nightmare to QA and I would personally prefer they were split into smaller bugs and I could walk up a tree doing SO and QA.. |
| 13:08 |
|
ashimema[m] |
but I also undertand the annoyance of only half a piece of work going in.. |
| 13:08 |
|
ashimema[m] |
accounts is a prime example |
| 13:10 |
|
kohaputti |
Here alternative approach could have maybe been first to implement fully Koha/Items.pm in one bug report and leave a note in C4/Items.pm and Koha/Items.pm that if you are touching the subs that are in both of the modules update both of them. Then in another bug report move everything to use Koha/Item.pm and remove the unused subs in C4/Items.pm. |
| 13:11 |
|
kohaputti |
just my 2 cents.. I'm not a pro refactorer. |
| 13:11 |
|
kohaputti |
even though I love refactoring :) |
| 13:11 |
|
kohaputti |
This bug Joubu is working on is awesome! |
| 13:11 |
|
kohaputti |
if I find the time I will definitely want to QA this |
| 13:13 |
|
cait |
small things tend to not break as much stuff |
| 13:13 |
|
cait |
in my experience :) |
| 13:14 |
|
cait |
and they stand abetter chance of moving forward - accounts will make more jumps i think before we release *optimistic* |
| 13:14 |
|
ashimema[m] |
that's the approach I took with accounts kohaputti.. |
| 13:15 |
|
* cait |
goes back into XSLT |
| 13:15 |
|
cait |
... |
| 13:15 |
|
cait |
*sighs* |
| 13:15 |
|
kohaputti |
ashimema[m], with accounts did you leave a comment in the other functions or how you made sure both of the functions were up to date during the refacotoring period? |
| 13:15 |
|
ashimema[m] |
add the new code and tests in Koha::.. than add a bug for each place I found to switch C4 calls to use the newer Accounts:: modules |
| 13:16 |
|
ashimema[m] |
I used the Mojo deprecation routine |
| 13:16 |
|
kohaputti |
ok |
| 13:16 |
|
ashimema[m] |
see C4::Accounts::manualinvoice |
| 13:17 |
|
ashimema[m] |
right at the top of the function there's `deprecated "C4::Accounts::manualinvoice is deprecated in favor of Koha::Account->add_debit";` |
| 13:17 |
|
kohaputti |
yeah, saw it now |
| 13:17 |
|
ashimema[m] |
I like that because it allows the routine to still be used but adds a warning to the logs whenever it's called |
| 13:17 |
|
ashimema[m] |
means plugin authors should also start to see the warning before it's entirely removed.. |
| 13:18 |
|
ashimema[m] |
I inteded to leave it there for at least 1 cycle as a polite warning to upgrade.. then remove it |
| 13:18 |
|
ashimema[m] |
though it's lasted a little longer that I had hoped so far |
| 13:18 |
|
ashimema[m] |
there is a bug open with the removal waiting for SO or QA I think. |
| 13:19 |
|
ashimema[m] |
bug 22393 |
| 13:19 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22393 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Remove last remaining manualinvoice use |
| 13:19 |
|
ashimema[m] |
and then bug 22394 |
| 13:19 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22394 enhancement, P5 - low, ---, koha-bugs, NEW , Remove C4::Accounts::manualinvoice |
| 13:19 |
|
ashimema[m] |
refactoring is hard however we do it :( |
| 13:19 |
|
* ashimema[m] |
really needs some lunch before he gets hangry ;) |
| 13:20 |
|
ashimema[m] |
hugs to all.. bbiab |
| 13:20 |
|
Joubu |
kohaputti: it's was not possible to fully implement Koha::Items, without knowing how it should actually behave |
| 13:20 |
|
Joubu |
If you have good idea about how it could have split I am all with getting idea |
| 13:21 |
|
kohaputti |
Joubu, why it was not? |
| 13:21 |
|
Joubu |
because I did not know what it did |
| 13:21 |
|
Joubu |
:D |
| 13:22 |
|
Joubu |
read the awful C4::Items CRUD subs, then try to underestand exhaustively what it does |
| 13:22 |
|
Joubu |
it's almost impossible |
| 13:22 |
|
Joubu |
look at my patches, I removed them 1 by 1, then move what they do to Koha::Item |
| 13:22 |
|
kohaputti |
I would have maybe refactored C4::Items first |
| 13:23 |
|
Joubu |
that's almost what I am doing, but moving them at the same time |
| 13:23 |
|
kohaputti |
yup, and I guess moving them at the same time brings the complexity in the QA process |
| 13:24 |
|
Joubu |
the problematic would have been worst: refactoring + add tests (because a lot was missing IIRC) for C4, then move the code to Koha:: |
| 13:24 |
|
Joubu |
It could split most of the time, not for CRUD |
| 13:24 |
|
Joubu |
It could *be* split |
| 13:25 |
|
kohaputti |
I guess we have also similar Bug 20443 waiting for QA |
| 13:25 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20443 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Move C4::Members::Attributes to Koha namespace |
| 13:25 |
|
kohaputti |
Joubu, any more refactorings happening? :D |
| 13:26 |
|
Joubu |
not until those 2 are pushed |
| 13:26 |
|
kohaputti |
ok |
| 13:27 |
|
kohaputti |
after the refactorings we should probably do also something about the SIP code living its own life |
| 13:27 |
|
Joubu |
bug 20271, on top of bug 23463 |
| 13:27 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20271 major, P1 - high, ---, jonathan.druart, In Discussion , Merge deleted biblio, biblioitems, biblio_metadata, and items tables |
| 13:27 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23463 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Move C4::Items CRUD subroutines to Koha::Item |
| 13:29 |
|
kohaputti |
...also, has anybody thought yet about refactoring .pl scripts? |
| 13:30 |
|
|
Dyrcona joined #koha |
| 13:32 |
|
ashimema[m] |
yes.. I am keen to reduce .pl files where possible.. we felt moving logic into Koha:: was a big part of that as a starting point |
| 13:32 |
|
ashimema[m] |
as for SIP.. hell yes.. I'm onboard with that.. |
| 13:32 |
|
|
khall joined #koha |
| 13:32 |
|
ashimema[m] |
I've actually been trying to pursuade colinc to take that on as an end of year goal.. likely starting next cycle now.. |
| 13:33 |
|
ashimema[m] |
he needs to get a bunch of EDI fixes submitted and through QA though before we can switch to that as a project |
| 13:33 |
|
kohaputti |
work seems to never end! |
| 13:33 |
|
ashimema[m] |
indeed |
| 13:33 |
|
|
inlibro joined #koha |
| 13:41 |
|
magnuse |
we made a script during a marseille hackfest to compare the amount of code in C4:: versus Koha::, but i can't find it anymore... |
| 13:43 |
|
|
oleonard joined #koha |
| 13:48 |
|
|
khall_ joined #koha |
| 13:55 |
|
kohaputti |
"find . -name '*.pm' | xargs wc -l" gives 98082 for Koha and for C4 it gives 74223 |
| 13:56 |
|
|
Margaret joined #koha |
| 14:03 |
|
|
lisettelatah joined #koha |
| 14:04 |
|
Joubu |
you should remove pm from Koha/Schema/Result |
| 14:04 |
|
Joubu |
anyway you will find the number of files, not very relevant |
| 14:05 |
|
Joubu |
well no, I hope it's not the number of files :) |
| 14:07 |
|
Joubu |
so it's ~64k without Koha/Schema/Result |
| 14:07 |
|
Joubu |
which mean we have 30k lines there! outch |
| 14:17 |
|
|
oleonard joined #koha |
| 14:17 |
|
|
andreash_ joined #koha |
| 14:18 |
|
|
andreash_ joined #koha |
| 14:19 |
|
|
andreash_ joined #koha |
| 14:20 |
|
|
andreash_ joined #koha |
| 14:21 |
|
|
andreash_ joined #koha |
| 14:21 |
|
|
andreash_ joined #koha |
| 14:22 |
|
|
andreash_ joined #koha |
| 14:23 |
|
|
andreash_ joined #koha |
| 14:24 |
|
|
andreash_ joined #koha |
| 14:24 |
|
|
andreash_ joined #koha |
| 14:27 |
|
|
khall joined #koha |
| 14:29 |
|
|
andreashm joined #koha |
| 14:33 |
|
|
andreashm joined #koha |
| 14:33 |
|
Joubu |
oleonard: did you have the chance to take a look at bug 24510? |
| 14:33 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24510 enhancement, P5 - low, ---, lucas, Signed Off , When Placing a Hold, cursor doesn't focus on Patron Name |
| 14:33 |
|
|
inlibro joined #koha |
| 14:34 |
|
|
lisettelatah joined #koha |
| 14:34 |
|
ashimema[m] |
joubu |
| 14:34 |
|
ashimema[m] |
FAIL t/db_dependent/Search.t |
| 14:34 |
|
ashimema[m] |
FAIL critic |
| 14:34 |
|
ashimema[m] |
# Variables::ProhibitUnusedVariables: Got 1 violation(s). |
| 14:34 |
|
oleonard |
Joubu: No. I'm trying to get my testing setup working. kohadevbox stopped working again so I'm giving koha-testing-docker another try (and it seems to be working) |
| 14:34 |
|
ashimema[m] |
didn't that used to say which variable is unused |
| 14:34 |
|
Joubu |
perlcritic t/db_dependent/Search.t will tell you |
| 14:35 |
|
Joubu |
is it related to one of my patches? |
| 14:35 |
|
ashimema[m] |
indeed |
| 14:35 |
|
ashimema[m] |
but I could have sworn the error was more helpful fromhe qa scripts |
| 14:35 |
|
ashimema[m] |
maybe it was my imagination. |
| 14:36 |
|
ashimema[m] |
the QueryParser removing |
| 14:36 |
|
Joubu |
not for perl::critic |
| 14:37 |
|
ashimema[m] |
hmm |
| 14:37 |
|
ashimema[m] |
I don't understand the test in question.. but the critic error may be a false catch |
| 14:38 |
|
Joubu |
I do not think so |
| 14:38 |
|
Joubu |
will take a look |
| 14:39 |
|
ashimema[m] |
you remove `_handle_exploding_indexe` in your patch.. the test in question looks to me like it's trying to test something around that. |
| 14:45 |
|
|
wizzyrea joined #koha |
| 14:45 |
|
ashimema[m] |
looks like that codeblock can be plain removed from the test to me.. |
| 14:45 |
|
ashimema[m] |
we mock C4::Search |
| 14:46 |
|
ashimema[m] |
then mock the SimpleSearch routine with a test embeded within it.. |
| 14:46 |
|
ashimema[m] |
but I don't seen anything call the mocked routine thereafter.. |
| 14:46 |
|
ashimema[m] |
maybe I'm missing something |
| 14:47 |
|
ashimema[m] |
oh.. hang on, there are SimpleSearch calls |
| 14:49 |
|
ashimema[m] |
but not in the same scope |
| 14:49 |
|
ashimema[m] |
mock is bound to the scope right... |
| 14:55 |
|
|
magnuse joined #koha |
| 14:55 |
|
ashimema[m] |
jajm around? |
| 14:56 |
|
jajm |
ashimema[m], yes |
| 14:56 |
|
|
talljoy joined #koha |
| 14:56 |
|
ashimema[m] |
got a favour to ask as a translations guru ;) |
| 14:56 |
|
ashimema[m] |
any chance you might have a moment to take a look at bug 20307 ? |
| 14:56 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20307 new feature, P5 - low, ---, jonathan.druart, Signed Off , Language overlay for authorized values |
| 14:57 |
|
ashimema[m] |
I'd count a second signoff from yourself as a QA |
| 14:57 |
|
ashimema[m] |
poor cait is under the kosh and unlikely to get to such a monster.. you're one of the few other people out there I'd trust on a translation bug of it's magnitude ;) |
| 15:00 |
|
jajm |
ashimema[m], ok, i'll try to signoff |
| 15:00 |
|
ashimema[m] |
thanks dude |
| 15:00 |
|
ashimema[m] |
certainly owe you a beer or two at hackfest.. you've been a star of late |
| 15:01 |
|
ashimema[m] |
it's wonderful seeing the translations stuff moving forward |
| 15:03 |
|
jajm |
i'll certainly drink one beer or two ;) |
| 15:04 |
|
* cait |
always feels like not fitting in when talk gets to beer *sighs* |
| 15:04 |
|
ashimema[m] |
beverage of choice cait ;) |
| 15:05 |
|
ashimema[m] |
vino? |
| 15:13 |
|
cait |
not really |
| 15:13 |
|
cait |
maybe a sweet cider |
| 15:19 |
|
Joubu |
ashimema[m], kohaputti: just saying, but, for instance, bug 20728 is doing some super easy and clean refactoring. It has been waiting for almost a year now ;) |
| 15:19 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20728 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Remove subroutines GetLastOrder* |
| 15:22 |
|
enkidu |
we have some similar patch reported on 2018, clean some unneeded lines in a code, bug 21879 |
| 15:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21879 minor, P5 - low, ---, kohadevinim, Needs Signoff , Code cleaning in printinvoice.pl |
| 15:22 |
|
ashimema[m] |
you need someone to help champion your bugs more Joubu |
| 15:22 |
|
Joubu |
cait: one of the Spannish speciality I discover recently is el tinto de verano, which is "summer red winner". It's basically red wine with carbonated water/lemonade. I am sure you would like it. Perfect if you want something light and easy to drink :) |
| 15:22 |
|
ashimema[m] |
there just soooo many bugs it's hard to pick which one's to work through |
| 15:22 |
|
Joubu |
(or if you want to drink a lot but it's too hot for that) |
| 15:23 |
|
cait |
i think we got that here too - with white and red wine |
| 15:23 |
|
Joubu |
ashimema[m]: I can make you a good search if you want, search for author:joubu :D |
| 15:23 |
|
cait |
we just got something like a snowstorm outside... |
| 15:23 |
|
cait |
it looks very impressive, I think i will stare at XSLT a bit longer |
| 15:24 |
|
ashimema[m] |
enkidu, same thing.. you need to a) champion your bugs so people know about them and b) do some SO to build up favour with people |
| 15:25 |
|
Joubu |
b does not work |
| 15:25 |
|
Joubu |
at least for me |
| 15:25 |
|
ashimema[m] |
I am struggling more and more to justify working on doing SO and QA without seeing much of it in return |
| 15:25 |
|
Joubu |
I have spent the last month doing 80% of QA, number is still the same, and my enh did not move |
| 15:25 |
|
enkidu |
yes, we're trying but we do not have much person to work on them |
| 15:26 |
|
ashimema[m] |
if it's the same small group of people doing all the SO and QA it's likely we'll pick each others work first frankly |
| 15:26 |
|
enkidu |
maybe in some orders? |
| 15:26 |
|
* ashimema[m] |
doesn't want to grump at people.. anything and everything people can do helps |
| 15:27 |
|
ashimema[m] |
but the stats present on the dashboard speak a million words |
| 15:27 |
|
ashimema[m] |
it's oh so often the same few people at the top of all the leaderboards |
| 15:29 |
|
ashimema[m] |
in an ideal world we would have lots more people doing SO and QA and we'd just work through in date order |
| 15:30 |
|
enkidu |
yes, i agree. but waiting for SO or QA for a small team, it is very disappointing. maybe some favor for small teams? |
| 15:30 |
|
ashimema[m] |
we're all small teams |
| 15:32 |
|
cait |
enkidu: it's true - we are all rather small teams of devs for each instiution |
| 15:32 |
|
cait |
or company |
| 15:32 |
|
ashimema[m] |
there are 211 bugs awaiting signoff, 103 awating QA, 374 in failed QA and 142 currently not applying.. as hard as we try.. we can't keep up |
| 15:32 |
|
cait |
but that said we try to help people starting out of course |
| 15:33 |
|
ashimema[m] |
certainly.. I don't exclude anyone and I pick out bugs of interest and bugs highlighted to me first.. often trying to start from oldest to newest too.. |
| 15:34 |
|
|
inlibro joined #koha |
| 15:34 |
|
cait |
yeah, i susually do that as wel - start from the older |
| 15:34 |
|
ashimema[m] |
so I'm trying hard to be unbiased |
| 15:35 |
|
enkidu |
thanks I know, we're also reorganizing to do more SO and write more patches. |
| 15:35 |
|
ashimema[m] |
but I do also spot when someone has done an SO or QA on a bug from our company and I go then try hard to make the next bug I look at a repayment one as it were. |
| 15:35 |
|
ashimema[m] |
sorry.. really hope I didn't come accross too mean there.. |
| 15:35 |
|
ashimema[m] |
text is a terrible medium.. I'm a nice person really. |
| 15:36 |
|
ashimema[m] |
just spread a bit too thin |
| 15:37 |
|
enkidu |
no problem, I know that you are nice person . I've to go to home now. Good night everyone! |
| 15:46 |
|
|
irma_ joined #koha |
| 15:59 |
|
ashimema[m] |
another hint for hitting my search criteria |
| 16:00 |
|
ashimema[m] |
I often filter on 'Patch complexit'.. sometime's I know I've got limited time so tackle a small set of 'trivials' and 'smalls' rather than start on a more involved bug |
| 16:00 |
|
ashimema[m] |
if it's a trivial/small.. make sure you mark it as such and I'm more likely to hit it sooner |
| 16:00 |
|
ashimema[m] |
for SO I encourage our customers to start that way too.. helps them get their feet under the table as it were |
| 16:05 |
|
oleonard |
Joubu: I don't know if it's any better in practical terms but perhaps my alternate patch for Bug 24510 is more clear? |
| 16:05 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24510 enhancement, P5 - low, ---, lucas, Signed Off , When Placing a Hold, cursor doesn't focus on Patron Name |
| 16:09 |
|
|
lisettelatah joined #koha |
| 16:10 |
|
reiveune |
bye |
| 16:10 |
|
|
reiveune left #koha |
| 16:20 |
|
|
davidnind joined #koha |
| 16:30 |
|
|
cait left #koha |
| 16:34 |
|
|
inlibro joined #koha |
| 16:41 |
|
Joubu |
oleonard: make sense to me, thanks! |
| 16:44 |
|
oleonard |
does anyone recognize this error from koha-testing-docker, "no such image: koha/koha-testing" |
| 16:49 |
|
oleonard |
Never mind, problem in my .env file |
| 16:57 |
|
|
sophie_m joined #koha |
| 17:02 |
|
|
khall joined #koha |
| 17:05 |
|
|
cait joined #koha |
| 17:07 |
|
oleonard |
Okay, how about this one, also from koha-testing-docker: "warning: bz.default-tracker has multiple values" |
| 17:08 |
|
Joubu |
oleonard: edit your .git/config, search for default-tracker |
| 17:09 |
|
Joubu |
not in your $HOME, but in your Koha root dir |
| 17:09 |
|
Joubu |
s/root/src |
| 17:11 |
|
Joubu |
oleonard: you should see only 1 '[bz]' section with only 1 'default-tracker' value |
| 17:11 |
|
Joubu |
default-tracker = bugs.koha-community.org |
| 17:12 |
|
oleonard |
Thanks Joubu |
| 17:14 |
|
|
edveal joined #koha |
| 17:18 |
|
|
khall joined #koha |
| 17:19 |
|
|
aleisha joined #koha |
| 17:34 |
|
|
inlibro joined #koha |
| 17:40 |
|
|
vfernandes joined #koha |
| 17:53 |
|
|
khall_ joined #koha |
| 17:58 |
|
|
sophie_m joined #koha |
| 18:00 |
|
|
lisettelatah joined #koha |
| 18:01 |
|
|
Margaret joined #koha |
| 18:03 |
|
|
Margaret_ joined #koha |
| 18:31 |
|
|
ere joined #koha |
| 18:34 |
|
|
oleonard joined #koha |
| 18:34 |
|
|
inlibro joined #koha |
| 18:42 |
|
|
kathryn joined #koha |
| 18:44 |
|
|
andreashm joined #koha |
| 18:46 |
|
|
andreashm joined #koha |
| 18:49 |
|
|
Margaret joined #koha |
| 18:55 |
|
|
alexbuckley joined #koha |
| 19:34 |
|
|
inlibro joined #koha |
| 19:37 |
|
|
davidnind left #koha |
| 19:41 |
|
|
kathryn joined #koha |
| 19:50 |
|
|
Dyrcona joined #koha |
| 19:59 |
|
|
edveal joined #koha |
| 20:14 |
|
|
enkidu joined #koha |
| 20:20 |
|
|
andreashm joined #koha |
| 20:21 |
|
|
hayley joined #koha |
| 20:21 |
|
|
andreashm joined #koha |
| 20:25 |
|
|
Dyrcona1 joined #koha |
| 20:28 |
|
|
Dyrcona1 joined #koha |
| 20:29 |
|
|
enkidu left #koha |
| 20:35 |
|
|
inlibro joined #koha |
| 20:40 |
|
|
tosca joined #koha |
| 20:44 |
|
huginn |
News from kohagit: Bug 24733: created_by param should be an arrayref <http://git.koha-community.org/[…]44ff5e4881f706a1c> |
| 20:44 |
|
huginn |
News from kohagit: Bug 24294: (QA follow-up) Add rollback and 008 default test <http://git.koha-community.org/[…]6df2d891b1615c8cc> |
| 20:44 |
|
huginn |
News from kohagit: Bug 24605: (QA follow-up) Fix unencoded series link in staff interface <http://git.koha-community.org/[…]51a2364096f04cda3> |
| 20:44 |
|
huginn |
News from kohagit: Bug 21879: Code cleaning in printinvoice.pl <http://git.koha-community.org/[…]804ad9fe8270001ad> |
| 20:44 |
|
huginn |
News from kohagit: Bug 24680: Fix end_date returned from api/v1/holds/{hold_id}/suspension endpoint <http://git.koha-community.org/[…]ffb9bc121ad842c5d> |
| 20:44 |
|
huginn |
News from kohagit: Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also when priority is not provided <http://git.koha-community.org/[…]99087f1c612ba9b7d> |
| 20:44 |
|
huginn |
News from kohagit: Bug 24605: Fix unencoded series link <http://git.koha-community.org/[…]8984c71b6a1bbeac5> |
| 20:44 |
|
huginn |
News from kohagit: Bug 24294: Add default value support for control fields in ACQ framework <http://git.koha-community.org/[…]2762c3f3f1f79b5ed> |
| 21:07 |
|
|
alexbuckley joined #koha |
| 21:17 |
|
|
andreash_ joined #koha |
| 21:19 |
|
koha-jenkins |
Project Koha_Master_D9 build #1179: SUCCESS in 35 min: https://jenkins.koha-community[…]a_Master_D9/1179/ |
| 21:27 |
|
|
aleisha left #koha |
| 21:30 |
|
|
lukeG joined #koha |
| 21:34 |
|
koha-jenkins |
Project Koha_Master_U18 build #639: UNSTABLE in 49 min: https://jenkins.koha-community[…]a_Master_U18/639/ |
| 21:35 |
|
|
inlibro joined #koha |
| 21:43 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #176: SUCCESS in 56 min: https://jenkins.koha-community[…]aster_D9_My8/176/ |
| 21:53 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #152: SUCCESS in 34 min: https://jenkins.koha-community[…]9_MDB_Latest/152/ |
| 22:03 |
|
koha-jenkins |
Project Koha_Master_D10_Deps build #1: FAILURE in 10 min: https://jenkins.koha-community[…]aster_D10_Deps/1/ |
| 22:04 |
|
|
kathryn_ joined #koha |
| 22:07 |
|
koha-jenkins |
Project Koha_Master_D8 build #718: UNSTABLE in 33 min: https://jenkins.koha-community[…]ha_Master_D8/718/ |
| 22:14 |
|
|
mwr joined #koha |
| 22:16 |
|
|
khall joined #koha |
| 22:20 |
|
|
khall joined #koha |
| 22:22 |
|
mwr |
Hey all. I have a VM running Debian 9, Koha with two libraries. Librarians are seeing occasional "Error Connection Reset" during checkout/checkin. I updated to 19.11.03 last night and performed clean reboots to troubleshoot, but no change. I've been looking around Koha and Apache logs, but I'm not seeing anything jump out to me. Anybody seen this behavior before? |
| 22:35 |
|
|
inlibro joined #koha |
| 22:36 |
|
koha-jenkins |
Project Koha_Master_D10 build #96: STILL UNSTABLE in 52 min: https://jenkins.koha-community[…]ha_Master_D10/96/ |
| 22:41 |
|
|
edveal joined #koha |
| 22:55 |
|
|
khall joined #koha |
| 23:10 |
|
|
edveal joined #koha |
| 23:11 |
|
|
oleonard joined #koha |
| 23:12 |
|
oleonard |
Why would kohadevbox stop working on my PC and my Mac in the same way on the same day? |
| 23:14 |
|
hayley |
updates to vagrant or virtualbox? |
| 23:15 |
|
oleonard |
Not on both machines |
| 23:15 |
|
oleonard |
I did upgrade vagrant and virtualbox on my PC hoping it would help, to no avail |
| 23:15 |
|
oleonard |
I end up with a proxy error, "The proxy server received an invalid response from an upstream server." |
| 23:20 |
|
|
andreashm joined #koha |
| 23:24 |
|
|
edveal joined #koha |
| 23:25 |
|
hayley |
hmm |
| 23:25 |
|
|
khall joined #koha |
| 23:35 |
|
|
inlibro joined #koha |
| 23:48 |
|
|
dcook joined #koha |
