IRC log for #koha, 2020-02-07

All times shown according to UTC.

Time S Nick Message
00:06 koha-jenkins Project Koha_19.11_D9 build #46: SUCCESS in 34 min: https://jenkins.koha-community[…]Koha_19.11_D9/46/
00:11 inlibro joined #koha
00:15 koha-jenkins Yippee, build fixed!
00:15 wahanui Congratulations!
00:15 koha-jenkins Project Koha_19.11_D8 build #48: FIXED in 33 min: https://jenkins.koha-community[…]Koha_19.11_D8/48/
00:30 koha-jenkins Project Koha_19.11_U18 build #44: SUCCESS in 51 min: https://jenkins.koha-community[…]oha_19.11_U18/44/
01:12 inlibro joined #koha
02:09 alexbuckley joined #koha
02:12 inlibro joined #koha
02:22 lukeG joined #koha
02:48 matts joined #koha
02:59 khall joined #koha
03:12 kathryn joined #koha
03:12 inlibro joined #koha
03:21 kathryn joined #koha
04:12 inlibro joined #koha
05:12 inlibro joined #koha
06:00 chriss joined #koha
06:12 inlibro joined #koha
06:17 ere joined #koha
06:25 chriss2 joined #koha
06:26 did joined #koha
06:34 cait joined #koha
07:11 kathryn joined #koha
07:13 inlibro joined #koha
07:23 * magnuse waves
07:30 reiveune joined #koha
07:30 reiveune hello
07:30 wahanui niihau, reiveune
07:49 did joined #koha
07:56 alex_a joined #koha
07:57 alex_a Bonjour
08:12 cait joined #koha
08:13 inlibro joined #koha
08:18 kohaputti joined #koha
08:28 sophie_m joined #koha
09:10 ashimema[m] morning #koha
09:13 inlibro joined #koha
09:18 magnuse kia ora ashimema[m]
09:22 ere Uh oh... While fixing REST API tests for bug 22522 (broken tests not actually testing what they're supposed) I found a little gem: The acquisitions/orders query uses budget_id parameter, but the returned orders use fund_id. Is this something that could still be fixed or are the params frozen?
09:22 huginn Bug[…]_bug.cgi?id=22522 is not accessible.
09:26 andreashm joined #koha
09:38 cait we shoudl fix it
09:39 cait i am not sure if there is not even a patch yet
09:39 cait we had discussed the mappings for acq recently
09:39 cait tcohen: around?
09:46 ere cait: ok, good
10:01 vfernandes joined #koha
10:02 huginn News from kohagit: Bug 13193: (follow-up) Update debian/control file <[…]6e8b8a5a59e8a172a>
10:02 huginn News from kohagit: Bug 13193: Make Memcached usage fork safe <[…]6ec3bc6333a938e50>
10:02 paxed anyone into plugin stuff? comments on bug 24589 ?
10:02 huginn Bug[…]_bug.cgi?id=24589 enhancement, P5 - low, ---, pasi.kallinen, Needs Signoff , Add plugin hook addbiblio_check_record
10:05 khall joined #koha
10:07 magnuse paxed: sounds like a good idea!
10:09 magnuse will the plugins be able to take the record, change it some way and return it? so it can do changes to the record without reporting anything back to the user?
10:09 paxed magnuse: the example plugin does exactly that
10:09 magnuse will the plugins be able to take the record, change it some way and return it? so it can do changes to the record an save it without reporting anything back to the user?
10:09 magnuse cool!
10:10 paxed magnuse: we have a "nagging" code that performs format validation, and i want to make it into a plugin
10:13 inlibro joined #koha
10:14 magnuse sounds good
10:18 * ashimema[m] predicts the next Jenkins run will explode
10:18 * ashimema[m] crosses fingers he's wrong
10:20 ashimema[m] ere, cait.. now we have some clearer guidlines regarding param/field names I think we should probably go back and make all the existing endpoints consistent with them..
10:20 ashimema[m] might be time for a version bump of the api
10:21 ashimema[m] I think so long as such changes are well documented and not backported we're fine to fix things
10:21 cait agreed, - but this one is an obvious error and not in the voted api i think
10:22 ashimema[m] we should certianly fix it
10:22 ashimema[m] hmm
10:22 ashimema[m] Jenkins nodes are all down again :(
10:25 cait oh :(
10:50 cait maybe tired from hte week... i can relate :)
10:57 khall joined #koha
11:01 kohaputti mtj, good job with the packaging!! :)
11:04 khall_ joined #koha
11:13 inlibro joined #koha
11:18 koha-jenkins joined #koha
11:41 vfernandes_ joined #koha
11:43 tcohen joined #koha
11:45 tcohen morning
11:45 tcohen hi paxed, interesting
11:47 tcohen we have 'after_biblio_action'
11:47 tcohen we could have
11:47 tcohen 'before_biblio_action'
11:48 khall joined #koha
11:48 tcohen (more generic than 'check')
11:48 paxed tcohen: well, the name doesn't really matter to me, as long as it's able to return text to the user and prevent saving.
11:49 paxed tcohen: if the patch looks otherwise ok, i can just change the hook name (and redo the example plugin)
11:49 * ashimema[m] thought we had such an action already...
11:51 paxed tcohen: although that name might be a bit too generic?
11:52 paxed "what biblio action?" :)
11:52 ashimema[m] sounds like you want an 'around' hook?
11:52 tcohen well, if it is going to change the data, I would add a pre_biblio_save_hook
11:52 ashimema[m] rather than a simple 'before'
11:52 tcohen hmç
11:55 tcohen I think we should (at least) have 'before' and 'after' hooks
11:57 tcohen for everything
11:57 tcohen haha
11:57 tcohen ashimema[m] what would be the semantics of an around hook?
11:59 tcohen ere good catch!
12:00 ashimema[m] so before and after at object level in my experience always run the function you're hooking.. around literally wraps the function so you have to allow the original code to run, or not.
12:00 koha-jenkins Project Koha_Master_D9_MDB_Latest build #113: UNSTABLE in 41 min: https://jenkins.koha-community[…]9_MDB_Latest/113/
12:00 ashimema[m]
12:00 ere tcohen: Thanks, but I really just fixed a test that surfaced it..
12:01 tcohen that's even better, ere. I love it when tests highlight issues :-D
12:01 ashimema[m] so 'before' tends to let you see and play with the input.. but not prevent execution of the next step..
12:01 ashimema[m] after tends to let you see and play with the output.. but not prevent execution of any further steps..
12:01 ere tcohen: Yeah. And they would have caught the issues early on had they actually worked. :D
12:02 ashimema[m] around lets to grab the data before it hits 'next' step and act on it but also optionally call the next step or pass back a failure or whatever..
12:02 tcohen it is difficult when the libraries we use are outdated
12:02 ashimema[m] that's my understanding anyway
12:02 koha-jenkins Project Koha_Master_D8 build #669: UNSTABLE in 43 min: https://jenkins.koha-community[…]ha_Master_D8/669/
12:02 ashimema[m] brb
12:02 tcohen ashimema[m] yeah, I was just reading how it works on Ruuby
12:02 tcohen he
12:07 ashimema[m] :)
12:07 magnuse bag around?
12:11 Dyrcona joined #koha
12:12 tcohen magnuse too early
12:13 tcohen 4:12 am
12:13 ashimema[m] any qa people fancy making me happy and taking a look at bug 24482 (and possibly bug 23355)
12:13 huginn Bug[…]_bug.cgi?id=24482 major, P5 - low, ---, martin.renvoize, Signed Off , Purchase Items broken by costs containing a comma
12:13 huginn Bug[…]_bug.cgi?id=23355 new feature, P5 - low, ---, martin.renvoize, Signed Off , Add 'cashup' process to the accounts system
12:14 inlibro joined #koha
12:14 magnuse tcohen: oops
12:15 ashimema[m] 101 majors in the queue..
12:15 * ashimema[m] quickly looks through to see if there's one or two he can move
12:15 tcohen are we calling everything 'major'?
12:15 tcohen he
12:16 ashimema[m] nah.. we just exposed all of them on the dashboard instead of only the most recent.
12:16 tcohen oh
12:16 ashimema[m] I've been slowly auditing them..
12:17 ashimema[m] though it's funny.. the moment you de-escalate one that's been sitting there for 5 years someone nearly always pops up and says you're wrong and re-escalates it..
12:17 ashimema[m] but they nearly never actually work on fixing it.
12:18 tcohen hahaha
12:18 koha-jenkins Project Koha_Master_U18 build #597: STILL UNSTABLE in 59 min: https://jenkins.koha-community[…]a_Master_U18/597/
12:20 oleonard joined #koha
12:21 ashimema[m] 100!
12:21 oleonard Hi #koha
12:27 cait ashimema[m]: i reescalatd the reelvance thing... but I really not dare to work on that :(
12:27 cait we could just remove the autotruncate feature instead? :P
12:27 cait or slap a big warning on it....
12:28 ashimema[m] I tried and it got shot down ;)
12:28 cait removing?
12:28 cait i might just really put a warning on the pref text... if this goes on
12:29 cait it's so hard to fiugre out - and it really improves search SO much
12:29 ashimema[m] rebasing the patch and suggesting that ixing relevance was more important than not breaking the other case... though I now can't remember what the breakage was.
12:29 cait if you turn it off
12:29 ashimema[m] indeed
12:29 cait i am not sure there was even a proven breakage case
12:29 ashimema[m] is such a royal mess
12:29 cait just a 'it could break something'
12:29 ashimema[m] there is.. but only with some very specific zebra versions I believe
12:41 tcohen it broke searching dates if Zebra version wasn't 2.0.62
12:42 tcohen searching date ranges
12:42 tcohen we should just pull 2.0.62 into our repo...
12:42 koha-jenkins Project Koha_Master_D9_My8 build #137: STILL UNSTABLE in 41 min: https://jenkins.koha-community[…]aster_D9_My8/137/
12:43 ashimema[m] agreed
12:43 ashimema[m] it's kinda crazy that buster still ships such an old version
12:44 ashimema[m] to be honest.. I've been in the habbit of just adding the zebra repos and using their version for years
12:44 vfernandes joined #koha
12:44 ashimema[m] we should just recommend that and deprecate support for older zebra's.. it's not exactly hard to add an apt repo is it. ;)
12:45 ashimema[m] ls
12:48 tcohen well, there's a problem with ID's Zebra repo: it pull Zebra 2.1, which should probably be fine, but we need to adjust our zoom perl version, etc
12:48 cait tcohen: sounds like a good enough reason to up the minimal version requirement for zebra
12:48 tcohen I tried and we explode
12:49 ashimema[m] ok.. so we grab a copy of the right version and put it in our repo as the 'quick fix'..
12:49 oleonard[…]kgcwAE/source.gif
12:49 ashimema[m] it's only taken us 6 years so far
12:50 tcohen the latest 2.0 version is 2.0.62
12:50 tcohen yeah just grab it
12:51 ashimema[m] @later tell mtj what are the chances of pulling zebra 2.0.62 into our deb repo's?  Bug 12431 would get a whole lot easier with it.
12:51 huginn ashimema[m]: The operation succeeded.
12:52 * ashimema[m] would kinda like to see some progress on cleaning up and really I'd love to see zebra bugs still paid attention to and improved..
12:52 ashimema[m] I don't tihnk zebra is as bad as many make out.. we just use it in a terrible way and butcher the queries so much before we let it do it's thing
12:53 cait i think include in repo would be really ideal
12:53 cait and I agree about not giving up on Zebra totally
12:53 kohaputti I would us to get more to upstreaming things in debian rather than putting things to our repo
12:53 cait i think it's not realisitc that we will be able to deprecate it anytime soon - also for the hardware requirements etc on elastic
12:53 ashimema[m] ES really isn't suitable for small institutions
12:54 cait exactly
12:54 cait kohaputti: it's true, we should do both
12:54 cait kohaputti: put in a working fix and correcting it long term
12:54 ashimema[m] as nice as that would be kohaputti it doesn't really offload the burden as we'd still be the one's trying to maintain them.. only for a broader audience possibly.. and it's not trivial getting things upstreamed into debian.
12:54 cait not sure that made sense... I emant work on both - put in our repo and work in inclusion in Debian proper
12:55 cait hm i thought it had been done with some things... maybe by eythian
12:55 ashimema[m] it's really up to indexdata to get it up to standard for debian packaging..
12:55 ashimema[m] not us.
12:56 * ashimema[m] goes for lunch
12:58 kohaputti the amount of time gets spend everyone doing building their own koha packages would most likely be a lot more than few of these people packaging things in debian. I'm not doing the packaging work yet but when I come to that I have hunch I'm gonna go for the option to maintain packages in debian so in a year or two I don't have to review bunch of code all over again.
13:00 khall joined #koha
13:01 kohaputti I also would like to see koha in debian at some point
13:02 ashimema[m] yup.. that's been the aim for the entire time I've worked on Koha ;)
13:02 tcohen we don't have the resources to have koha-common in Debian
13:03 tcohen and our release cycles are very different
13:03 kohaputti if things stay the same I could work on that in 3 years but I'm not sure about things being the same in 3 years
13:04 tcohen it is cheaper to just containerize Koha and bundle things, be it a Docker image/set of images, LXC/D or Snap
13:04 * ashimema[m] hope he's not coming across too negative
13:05 tcohen I have installed things on Ubuntu using snap, and it is great (for end users)
13:05 kohaputti tcohen, and containers increases the burden for the sysadmins to make sure koha is secure and doesn't work maybe as well during upgrades
13:06 koha-jenkins Project Koha_Master_D9 build #1125: STILL UNSTABLE in 1 hr 3 min: https://jenkins.koha-community[…]a_Master_D9/1125/
13:08 tcohen kohaputti I agree! but I think fixing that it is the best way to invest our (limited) energy
13:08 tcohen packaging and distros support has become one of our biggest barriers
13:09 tcohen in many ways
13:09 khall joined #koha
13:12 kohaputti we could apply for funding for packaging
13:12 ashimema[m] from who?
13:12 ashimema[m] and who would take on the work ;)
13:14 inlibro joined #koha
13:14 tcohen kohaputti I'm not against working on packaging, I'm just acknowledging it is something we are struggling with a long time ago
13:14 kohaputti there are some debian developer for hire ( and some foundations provide funding for free software projects.
13:30 wizzyrea joined #koha
13:35 cait tcohen: pacakges really work well for a lot of people.. maybe hard to do, but makes it easy for the users
13:35 cait containerization adds a new layer
13:36 tcohen don't get me wrong, I'm not against packages at all
13:37 tcohen we should actually have 'more ways to run Koha'
13:37 ashimema[m] we have a pretty terrible grasp of dependancy management at the moment..
13:37 tcohen I'm discussing the value of maintaining Debian dependencies vs. bundling things
13:37 ashimema[m] I think we need to get that sorted before moving onto better packaging ;)
13:38 ashimema[m] ps.. there is work going on in that area.. for example moving us away from our bespoke listing module to the more broadly adopted cpanfile format
13:38 tcohen Mojolicious? outdated. Zebra and friends? outdated, OAuth? outdated library and so on
13:39 tcohen we don't need to nuke down packages, but there's a symptom somethings is not going well, that's all
13:39 ashimema[m] we also need to be able, at the package level, to specify version ranges for our dependancies.. at the moment we only specify minumum versions and then really often break completely when a new version gets installed
13:39 ashimema[m] and..
13:39 ashimema[m] we have no formal process to update deps at all.. like tcohen has just highlighted
13:40 ashimema[m] we should really have something in place to make sure we check and update our dependancies with each cycle in my opinion
13:40 ashimema[m] we always tell people to update to point releases of Koha because we fix things and running an old version is asking for bugs...
13:41 ashimema[m] but we don't head our own advice when it comes to all the dependancies we pull in
13:41 cait good points
13:41 tcohen also, relying entirely on Debian packages for (say) perl dependencies, doesn't allow us to support other platforms
13:41 cait i just don't want to see them gone - the feedback is very good I get from people installing Koha on their own
13:42 tcohen cait the opposite, we need to make packaging easier to maintain, and dependency handling simpler as well
13:42 * ashimema[m] has been tempted for a while to build an arch package for koha :)
13:43 ashimema[m] well.. rather an arch build file.. they don't do packages as such
13:43 tcohen right now the packaging manager needs to take care of zilions of perl dependencies versions, probably incompatible between Debian releases
13:44 tcohen ashimema[m] my first contact with Koha was trying to creage ebuild files for all perl deps so I could install Koha on my Gentoo server :-D
13:45 koha-jenkins Project Koha_Master_D9 build #1126: STILL UNSTABLE in 38 min: https://jenkins.koha-community[…]a_Master_D9/1126/
13:45 ashimema[m] haha.. briliant tcohen
13:46 ashimema[m] grr..
13:47 ashimema[m] I really wish I had a better grasp on packaging dependancies and koha-testing-docker and jenkins interactions :(
13:47 ashimema[m] mtj has packaged and published the memcached dep for us.. and I've not pushed the koha patch and corresponding debian/control file..
13:47 ashimema[m] and forced a build of koha-testing-docker via jenkins
13:48 ashimema[m] should that not mean the dep is now pulled into koha-testing-docker?
13:49 tcohen if the package is built, and koha-testing-docker was rebuilt before the task was launched, then yes
13:50 tcohen I have just approved a merge request from mtj to add the lib
13:51 tcohen to koha-testing-docker manually
13:55 ashimema[m] oh..
13:55 ashimema[m] weird
13:55 ashimema[m] I really don't get why we still have to add them manually so often :(
13:55 vfernandes joined #koha
13:58 mtj hiya ashimema[m], its coz the nightly job that builds a package from master, isnt running
14:01 mtj just updating the deb/control file isnt enough for jenkins to succeed
14:02 mtj jenkins expects a koha-common package to have been recently built, with the new control file (and its newly added deps.)
14:04 mtj the new koha package gets installed at the start of the build, which also installs the newly added deps
14:05 ashimema[m] I see
14:05 ashimema[m] so it's the nightly job not running that's the big issue..
14:05 mtj afaik, yeah
14:06 ashimema[m] and that's dead becuase..?
14:06 ashimema[m] or did we never get to the bottom of tht
14:06 mtj disk was full
14:06 ashimema[m] aha
14:06 ashimema[m] that's mirko's server isn't it
14:07 ashimema[m] which no-one has access to
14:07 mtj yeah
14:07 mtj i could have a go at replicating the nightly build script...
14:08 ashimema[m] no worries.. knowing the reasoning behind stuff is good enough..
14:08 ashimema[m] we can work around it with the koha-testing-docker stuff at the moment
14:08 mtj there might be another way to pull the required deps from the control file, at the start of the build
14:09 ashimema[m] so.. is D10 basically just waiting on merging the mojo bug at this piont..
14:09 ashimema[m] making sure I'm on top of that too
14:09 mtj yep
14:10 mtj control file method would be a bit more reliable.. wouldnt have to wait until the nighly job ran for success
14:12 ashimema[m] not a bad idea..
14:12 ashimema[m] though it become a chicken & egg situation
14:13 ashimema[m] i.e I 'think' the nightly script used to create the control file patches
14:13 mtj ah, yes true
14:13 ashimema[m] but I think we have a handle on that now
14:14 inlibro joined #koha
14:14 mtj ill have a go at it after the mojo stuff is sorted hey
14:14 ashimema[m] :)
14:14 Michael_CKLS joined #koha
14:15 ashimema[m] no marcelr today ?
14:15 ashimema[m] friday is usually a nice busy QA day :)
14:15 ashimema[m] not so much today though :(
14:27 lukeG joined #koha
14:27 vfernandes hi #koha
14:28 lukeG morning all
14:28 vfernandes it's possible to block the email sent to Koha admin by overdue_notices cronjob?
14:28 vfernandes[…]
14:34 koha-jenkins Project Koha_19.11_D10 build #7: STILL FAILING in 7 min 21 sec: https://jenkins.koha-community[…]Koha_19.11_D10/7/
14:34 matts_ joined #koha
14:35 ashimema[m] can we not remove Cache::Memcached::Fast from our PerlDependancies now.. we've replaced it with Cache::Memcached::Fast::Safe (which itself lists Cache::Memcached::Fast as a dependancy so it'll pull that in for itself right?)
14:44 magnuse joined #koha
14:48 sophie_m joined #koha
14:48 kohaputti it's super nice the cache race condition was finally resolved :) Now big libraries can use koha too
14:48 kohaputti though there are some O(n^2) problems left
14:55 reiveune joined #koha
14:58 ashimema[m] mtj still around?
15:01 cait kohaputti: which one was that?
15:02 edveal joined #koha
15:07 kohaputti cait, bug 13193
15:07 huginn Bug[…]_bug.cgi?id=13193 major, P3, ---, joonas.kylmala, Pushed to master , Make Memcached usage fork safe
15:08 ashimema[m] ?
15:08 koha-jenkins Project Koha_19.05_U18 build #123: SUCCESS in 31 min: https://jenkins.koha-community[…]ha_19.05_U18/123/
15:09 cait oh cool!
15:10 ashimema[m] regarding bug 19735 are we comfortable that we're losing a tiny bit of data about our dependancies in the transition?
15:10 huginn Bug[…]_bug.cgi?id=19735 enhancement, P5 - low, ---, julian.maurice, Signed Off , Move Perl deps definitions into a cpanfile
15:11 ashimema[m] i.e. the 'Usage' bit
15:11 ashimema[m] which i think many people have never really populated in the first place properly
15:12 kohaputti ashimema[m], do you know the original reasoning behind it? It sounds like we can just grep the source code to find where it is used.
15:13 ashimema[m] historical as much as anything I reckon
15:13 ashimema[m] no real reason for it..
15:13 ashimema[m] perhaps once upon a time we let people install without all the deps
15:14 ashimema[m] but realistically now we just assume they'll be using everything.
15:14 inlibro joined #koha
15:14 koha-jenkins Yippee, build fixed!
15:14 wahanui Congratulations!
15:14 koha-jenkins Project Koha_19.05_D8 build #121: FIXED in 35 min: https://jenkins.koha-community[…]oha_19.05_D8/121/
15:15 ashimema[m] what might be nice however.. but this can be a new bug down the line.. is if we split out the 'phases'..
15:15 ashimema[m] that would nicely allow us to only install test dependancies for testing..
15:15 ashimema[m]
15:15 kohaputti ashimema[m], I see references to the usage in prog/en/modules/installer/
15:16 ashimema[m] if I'm entirely honest though.. most cpanfiles I've seen in the wild are simply a list and don't bother much with the splitting down..
15:19 huginn News from kohagit: Bug 13193: (RM follow-up) Remove Cache::Memcached::Fast from PerlDependencies <[…]d19b74e683d10520f>
15:19 koha-jenkins Yippee, build fixed!
15:19 wahanui Congratulations!
15:19 koha-jenkins Project Koha_Master_D9 build #1127: FIXED in 1 hr 0 min: https://jenkins.koha-community[…]a_Master_D9/1127/
15:22 andrew joined #koha
15:30 kohaputti ashimema[m], it seems to be just empty now since the usage info is removed but ideally I would get rid of that code too
15:30 ashimema[m] good catch.. I agree
15:31 ashimema[m] we drop some other details from the return of PerlModules->versions_info too
15:31 ashimema[m] I'm just looking to see if that's important too
15:33 ashimema[m] we've dropped the 'upgrade' and 'status' keys as far as I can tell
15:34 ashimema[m] but I 'think' he's caught those by grouping by status instead..
15:34 ashimema[m] but.. I think we could also add in support for reporting on 'max' version here whilst we're at it
15:39 koha-jenkins Project Koha_19.05_D9 build #121: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_19.05_D9/121/
16:04 koha-jenkins Yippee, build fixed!
16:04 wahanui Congratulations!
16:04 koha-jenkins Project Koha_Master_D8 build #670: FIXED in 44 min: https://jenkins.koha-community[…]ha_Master_D8/670/
16:06 reiveune bye
16:06 reiveune left #koha
16:10 koha-jenkins Yippee, build fixed!
16:10 wahanui Congratulations!
16:10 koha-jenkins Project Koha_Master_D9_MDB_Latest build #114: FIXED in 52 min: https://jenkins.koha-community[…]9_MDB_Latest/114/
16:11 edveal joined #koha
16:14 koha-jenkins Project Koha_Master_D9 build #1128: SUCCESS in 35 min: https://jenkins.koha-community[…]a_Master_D9/1128/
16:14 inlibro joined #koha
16:15 wizzyrea objections to adding something to cleanup_database to optionally delete old label batches?
16:34 oleonard wizzyrea: I like this productive strategy of asking for objections to something when no one is listening. I could get approval to all sorts of things.
16:36 Marie-Luce it's the weekend in NZ
16:37 Marie-Luce Can anyone help me to understand the "no renewal before" circulation rule?
16:37 oleonard And also 5:30AM in NZ :)
16:39 Marie-Luce how does Koha calculate the days you have added in this rule?
16:43 edveal joined #koha
16:49 edveal joined #koha
16:49 edveal joined #koha
16:50 edveal joined #koha
16:51 edveal joined #koha
16:57 edveal joined #koha
16:58 koha-jenkins Project Koha_Master_U18 build #598: STILL UNSTABLE in 54 min: https://jenkins.koha-community[…]a_Master_U18/598/
17:05 koha-jenkins Yippee, build fixed!
17:05 wahanui Congratulations!
17:05 koha-jenkins Project Koha_Master_D9_My8 build #138: FIXED in 54 min: https://jenkins.koha-community[…]aster_D9_My8/138/
17:08 wizzyrea are you saying that the nzers are the only ones who would object to such a thing?
17:09 oleonard wizzyrea: I think just that it's not surprising you don't have a quorum
17:14 khall joined #koha
17:14 inlibro joined #koha
17:15 sophie_m joined #koha
17:23 khall_ joined #koha
17:29 cait wizzyrea: if it's optional, wyh would one object? there is also alreay a bug report for that
17:30 cait I wrote one ages ago - because it's potentially relevant in  terms of controlling the work fo your staff and such
17:30 cait Marie-Luce: what's the question? i can help
17:33 cait hm maybe later? got to leave now
17:33 cait :)
17:33 cait left #koha
17:37 Marie-Luce how does Koha calculate the days you have added in this rule?
17:37 Marie-Luce (from the checkout date or the due date? )
18:10 cait joined #koha
18:14 did joined #koha
18:15 inlibro joined #koha
18:26 khall joined #koha
18:37 wizzyrea cait you mean https://bugs.koha-community.or[…]_bug.cgi?id=15563
18:37 huginn Bug 15563: enhancement, P5 - low, ---, cnighswonger, NEW , Cronjob to regularly delete patroncard label batches
18:37 wizzyrea ?
18:37 khall joined #koha
18:38 wizzyrea maybe change that to include regular label batches too :D
18:49 cait yep
18:58 khall joined #koha
19:05 edveal joined #koha
19:05 CrispyBran joined #koha
19:06 CrispyBran Anyone have any ideas?  Can't populate expirationdate in HOLD_SLIP if patron has more than 1 hold on that bib.  Anyone have an idea on work arounds to get that date?
19:08 CrispyBran Using [% hold.expirationdate %] currently, and it works when the patron has a single hold on the bib.
19:09 CrispyBran I'm thinking it is getting information mixed between the two (or more) holds, where the other hold doesn't have an expiration date.  Wondering if there is anyway to point it to the correct hold record.
19:14 CrispyBran I have confirmed by looking at [% hold.reserve_id %], it is indeed looking at the wrong reserve record.
19:15 inlibro joined #koha
19:16 andrew Does it still give you the wrong date if you use <<reserves.expirationdate>> instead?
19:16 andrew (seems like it probably would, but worth checking)
19:21 lisettelatah joined #koha
19:25 caroline_catlady in the same kind of problems, I'm trying to remove the hours from date_due on the issue slip... I added [%- USE Kohadates -%] and changed <<issues.date_due>> to [% checkout.date_due | $KohaDates %] and it gives me an error... any idea what I did wrong?
19:25 caroline_catlady The error is ERROR PROCESSING TEMPLATE: plugin error - Kohadates: plugin not found at /inlibro/git/koha-v1905-dev-inlibro/C4/ line 612.
19:27 CrispyBran andrew: very odd behavior.  Without changing the variable pointing to [% hold.expirationdate %], if I setup another variable pointing to <<reserves.expirationdate>>, [% hold.expirationdate %] suddenly works.
19:27 CrispyBran If I remove that variable, it breaks again.
19:27 CrispyBran Something very wonky is going on.
19:28 andrew interesting! Not good, but interesting. I know very little about TT, but I wonder if it’s doing something sql-y, finding both reserves and sorta collapsing them, only showing you one
19:29 andrew these are the things I would poke khall or lukeG for (same with your question, caroline)
19:35 lukeG caroline_catlady: i think you need to add [% USE $KohaDates %] at the top of your notice or it won't work
19:35 caroline_catlady I did
19:35 caroline_catlady See my message
19:35 lukeG oohh, yes you wrote that…
19:35 caroline_catlady :)
19:36 lukeG make sure it is KohaDates, not Kohadates
19:36 caroline_catlady ah!
19:37 caroline_catlady I copied it from the wiki... I'll have to change it
19:37 caroline_catlady thanks lukeG++ :)
19:37 caroline_catlady Now the date doesn't appear, but at least I don't have an error ^_^;;
19:41 lukeG caroline_catlady: does [% checkout.item.checkout.date_due %] work?
19:41 khall CrispyBran are you using "hold" or "holds"?
19:42 caroline_catlady lukeG: no... :(
19:42 lukeG what notice is it?
19:43 caroline_catlady ISSUESLIP
19:46 lukeG i think you need to loop through each checkout in borrowers checkouts
19:46 lukeG [% FOREACH checkout IN borrower.checkouts %]
19:46 lukeG [% checkout.item.checkout.date_due %]
19:46 lukeG [% END %]
19:47 CrispyBran khall: hold
19:47 lukeG caroline_catlady ^^
19:48 caroline_catlady oh thanks! I'll try that
19:50 khall CrispyBran I think you could try something similar to what lukeG just wrote:
19:50 khall [% FOREACH h IN holds %]
19:50 khall [% h.whatever %]
19:50 khall [% END %]
19:52 caroline_catlady lukeG: do I have to put all the checkout information in the loop? (there's barcode and title just above, but I left those in between the hungry alligators)
19:58 lukeG caroline_catlady: I think yes, you'll have to put all the checkout info in the loop
20:01 caroline_catlady I'll try this by josef_moravec https://wiki.koha-community.or[…]Template_Toolkit_.28ISSUESLIP.29
20:05 lukeG1 joined #koha
20:15 inlibro joined #koha
20:16 cait you could probably also mix...
20:16 cait << ... | dateonly >>
20:17 cait use the old syntax in the TT... ont ideal, but if you don't get it working otherwise
20:17 cait << biblio.timestamp | dateonly >>
20:18 caroline_catlady getting there! I was not looking at the right thing... -_-
20:18 caroline_catlady I mixed and matched from what lukeG1 and josef and Michael and got it working I think
20:19 cait :)
20:20 caroline_catlady oh, no, it's not working... it's giving me all the same date
20:20 cait you are trying to remove the hours?
20:20 caroline_catlady I think it may be the same thing that's happenind as CrispyBran
20:20 caroline_catlady yes
20:20 cait does kohadates give you the date? i think you can add a parameter for hours only there too
20:20 cait should i try and find it?
20:21 caroline_catlady kohadate gives me the date only, but it's all the same date
20:21 cait hm what do you mean?
20:21 cait or can you share what you got so far?
20:21 caroline_catlady yeah one sec...
20:21 * cait likes puzzles
20:22 caroline_catlady :D
20:22 caroline_catlady So these are the checkouts, one regular and two overdues
20:22 cait ok
20:23 pastebot "caroline_catlady" at pasted "ISSUESLIP modified with TT" (36 lines) at
20:23 caroline_catlady this is the ISSUESLIP content ^
20:23 cait and what are we trying to change?
20:23 cait retards are overdues? ;)
20:24 cait [% checkout.date_due | $KohaDates %]</p> [% END %] this shoud be overdue.date_due
20:24 cait because you are looping overdue in overdues
20:24 caroline_catlady lol yes! :) it's the same word as development "retardation" (as in being late)
20:24 caroline_catlady ah, that must be it
20:24 cait are we stlil trying to change the formatting too?
20:25 caroline_catlady works!!
20:26 oleonard happy weekend everyone
20:26 cait he does it on purpose... i swear
20:26 caroline_catlady Here's the new slip  with overdues corrected
20:26 cait not leaving us a chance to say it back :)
20:26 cait do we need something else?
20:27 caroline_catlady nope that was it :) I was just trying to go from 02/28/2020 23:59:00 to 02/28/2020
20:27 cait ah :)
20:27 cait if you wanted them back, i thin kyou could do $KohaDates with_hours=1
20:28 cait with_hours => 1
20:28 cait but we don't want ot... so that's useless
20:28 caroline_catlady I think I will share it on the wiki...
20:28 cait c
20:28 cait caroline_catlady++
20:29 caroline_catlady Thanks lukeG1++ and cait++ :)
20:32 JesseM joined #koha
20:52 lisettelatah joined #koha
20:58 caroline_catlady How would I make something appear only if there are overdues with TT? I tried [% IF overdue %] ... [% END %] and [% IF overdues %] ... [% END %] and it doesn't work
21:01 caroline_catlady ah it was [% IF overdues.count %]
21:01 ashimema[m] [% IF overdues.size
21:01 ashimema[m] Haha.. you beat me.. I cant type fast enough on the phone
21:02 caroline_catlady thanks ashimema[m] :)
21:02 ashimema[m] Count is better than size too 😀
21:04 koha-jenkins Project Koha_19.05_U18 build #124: SUCCESS in 31 min: https://jenkins.koha-community[…]ha_19.05_U18/124/
21:07 koha-jenkins Project Koha_19.05_D8 build #122: SUCCESS in 33 min: https://jenkins.koha-community[…]oha_19.05_D8/122/
21:08 edveal joined #koha
21:15 inlibro joined #koha
21:16 koha-jenkins Project Koha_19.05_D9 build #122: SUCCESS in 40 min: https://jenkins.koha-community[…]oha_19.05_D9/122/
21:20 khall joined #koha
21:21 khall joined #koha
21:30 khall joined #koha
21:35 edveal joined #koha
21:55 edveal joined #koha
22:08 lukeG joined #koha
22:15 inlibro joined #koha
22:19 ere joined #koha
22:22 khall joined #koha
23:01 edveal joined #koha
23:15 inlibro joined #koha
23:48 koha-jenkins Project Koha_19.11_D8 build #49: SUCCESS in 32 min: https://jenkins.koha-community[…]Koha_19.11_D8/49/
23:48 caroline_catlady have a good weekend everyone!
23:49 koha-jenkins Project Koha_19.11_D9 build #47: SUCCESS in 33 min: https://jenkins.koha-community[…]Koha_19.11_D9/47/

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary