| Time |
S |
Nick |
Message |
| 00:07 |
|
|
wizzyrea joined #koha |
| 00:52 |
|
|
inlibro joined #koha |
| 01:52 |
|
|
inlibro joined #koha |
| 02:52 |
|
|
inlibro joined #koha |
| 03:53 |
|
|
inlibro joined #koha |
| 04:35 |
|
|
kathryn joined #koha |
| 04:53 |
|
|
inlibro joined #koha |
| 05:05 |
|
|
chris joined #koha |
| 05:11 |
|
|
cait joined #koha |
| 05:51 |
|
|
marcelr joined #koha |
| 05:53 |
|
|
inlibro joined #koha |
| 06:33 |
|
magnuse |
\o/ |
| 06:34 |
|
|
reiveune joined #koha |
| 06:34 |
|
reiveune |
hello |
| 06:39 |
|
|
laurence joined #koha |
| 06:47 |
|
ashimema |
Yikes, looks like I broke loads of tests.. 😟 |
| 06:47 |
|
ashimema |
But they all passed for me just before push.. grrr |
| 06:48 |
|
marcelr |
hi ashimema |
| 06:48 |
|
marcelr |
having the impression that it was a bit hurried |
| 06:53 |
|
|
inlibro joined #koha |
| 06:54 |
|
ashimema |
q |
| 06:55 |
|
|
andreashm joined #koha |
| 06:56 |
|
ashimema |
well the issue is obvious.. but I can't see why it's suddenly happening |
| 06:56 |
|
ashimema |
neither of the default datasets are getting loaded in install |
| 06:56 |
|
|
andreashm joined #koha |
| 06:58 |
|
* ashimema |
reads misc4dev |
| 06:59 |
|
|
fridolin joined #koha |
| 06:59 |
|
fridolin |
hi |
| 07:00 |
|
ashimema |
found it |
| 07:02 |
|
ashimema |
ok.. so the one change I made after a chat with cait about it was to remove installer/data/mysql/en/mandatory/account_debit_types.sql (because we have /installer/data/mysql/account_debit_types.sql already). Seems although in the patch we have updated C4/Installer.pm to account for that.. misc4dev doesn't use the installer.. it installs the data itself in a slightly different manor |
| 07:04 |
|
marcelr |
ashimema: depending on stuff outside the regular codebase is tricky |
| 07:04 |
|
marcelr |
remember discussion with Jonathan about getting it in the codebase |
| 07:04 |
|
ashimema |
indeed.. I wasn't aware of that little caveat in misc4dev.. I thought it ran the installer and then populated data on top |
| 07:09 |
|
|
alex_a joined #koha |
| 07:10 |
|
alex_a |
Bonjour |
| 07:11 |
|
ashimema |
we need to sit down and help bernardo get these translated sql files into the normal translation workflow.. |
| 07:11 |
|
ashimema |
they're a pain to maintain at the moment |
| 07:13 |
|
|
paul_p joined #koha |
| 07:13 |
|
magnuse |
but it isn't just a question of translating? |
| 07:13 |
|
magnuse |
they set things like the proper dateformat, firstdayoftheweek etc? |
| 07:14 |
|
magnuse |
localized sample libraries and patrons... |
| 07:14 |
|
ashimema |
I don't believe the files in /installer/data/mysql/lang// are picked out by our tools.. so they don't appear on translate.koha-community.org.. |
| 07:15 |
|
ashimema |
they're simple to translate.. but they often become out of sync |
| 07:15 |
|
ashimema |
because they're not obvious ;) |
| 07:15 |
|
ashimema |
indeed |
| 07:15 |
|
ashimema |
they're simple enough.. my point is they're nto obvious and often get missed.. both at QA time and translation time |
| 07:17 |
|
ashimema |
in this case.. they weren't missed.. I made a deliberate decision to hard code descriptions for accounttypes into the templates so they are picked up by the tools.. but that also leads to ambiguity as to where the description strings are coming from (this was done at caits request as she predicted that having them in the database would mean they just never got translated when new codes were added) |
| 07:17 |
|
magnuse |
yeah, but often it is not just a question of translating |
| 07:18 |
|
ashimema |
? |
| 07:18 |
|
marcelr |
we shouldnt have sql files in language folders ! |
| 07:18 |
|
marcelr |
i once tried something but i never got it anywhere |
| 07:19 |
|
ashimema |
ok, wasn't expecting to go into this debate today :) |
| 07:19 |
|
marcelr |
you triggered it ;) |
| 07:19 |
|
ashimema |
I'm interested in alternative options for sure.. I don't know enough in depth about the translation workflows at the moment |
| 07:19 |
|
ashimema |
I'm not sure I see the alternative to sql files |
| 07:20 |
|
ashimema |
these mandatory data are loaded simply by sql |
| 07:20 |
|
magnuse |
some of the sql files are not just translated, they are used for setting sysprefs to appropriate values for a country/language |
| 07:21 |
|
ashimema |
true |
| 07:21 |
|
ashimema |
localised rather than translated |
| 07:21 |
|
magnuse |
yup |
| 07:21 |
|
|
alex_a_ joined #koha |
| 07:23 |
|
ashimema |
got an example magnuse? |
| 07:24 |
|
magnuse |
http://git.koha-community.org/[…]5e9c500d8;hb=HEAD |
| 07:24 |
|
magnuse |
Obligatorisk = mandatory |
| 07:25 |
|
ashimema |
I find the structure in installer/data/mysql confusing |
| 07:25 |
|
marcelr |
you are on the right track |
| 07:25 |
|
ashimema |
oh, interesting.. literally presetting some sysprefs for local requirements |
| 07:27 |
|
magnuse |
yup |
| 07:27 |
|
marcelr |
there is a lot of rubbish in some folders and outdated stuff |
| 07:27 |
|
marcelr |
since nobody is reponsible |
| 07:27 |
|
magnuse |
same for german: http://git.koha-community.org/[…]m_preferences.sql |
| 07:27 |
|
magnuse |
i have not been good at keeping the norwegian files updated, but i should |
| 07:28 |
|
magnuse |
maybe i should try and update for 19.11 |
| 07:28 |
|
magnuse |
well, i should try! |
| 07:28 |
|
marcelr |
i would go for one installer file that only checks if there is a translation available |
| 07:28 |
|
marcelr |
maybe at install time run the english installer file thru some language thing |
| 07:29 |
|
ashimema |
I've always been surprised that the Obligatorisk works actually |
| 07:29 |
|
ashimema |
but now I see it's caught be a slopy regex |
| 07:29 |
|
magnuse |
? |
| 07:30 |
|
ashimema |
`$requirelevel =~ /(mandatory|requi|oblig|necess)/i` |
| 07:30 |
|
ashimema |
so if someone were to introduce a new language and their word for 'mandatory' happened to not begin with one of the above then it wouldn't be picked up by the installer |
| 07:32 |
|
magnuse |
ah, gotcha |
| 07:36 |
|
ashimema |
ooh.. |
| 07:36 |
|
ashimema |
I should move the account_*_types files.. they're all in the wrong place |
| 07:36 |
|
ashimema |
I just copied where account_offset_types had done |
| 07:37 |
|
ashimema |
in fact.. I really don't understand why userflags.sql, userpermissions.sql, audio_alerts.sql are in the top level either.. |
| 07:39 |
|
magnuse |
because they are common to all languages? |
| 07:40 |
|
ashimema |
but so is everything under /installer/data/mysql/mandatory/ |
| 07:40 |
|
wahanui |
Hmm. No matches for that, ashimema. |
| 07:41 |
|
ashimema |
as far as I can tell.. those are all 'global' mandatory data's |
| 07:42 |
|
magnuse |
true |
| 07:42 |
|
|
koha joined #koha |
| 07:44 |
|
magnuse |
"# Paul has cleaned up tables so reduced the count" :-) |
| 07:53 |
|
|
inlibro joined #koha |
| 07:56 |
|
ashimema |
? |
| 07:57 |
|
ashimema |
where did you see that? |
| 08:01 |
|
ashimema |
load_sql_in_order is plain wierd.. the more I look at it the more it makes my eyes hurt :( |
| 08:04 |
|
magnuse |
http://git.koha-community.org/[…]b0d6;hb=HEAD#l413 :-) |
| 08:09 |
|
ashimema |
lol |
| 08:09 |
|
ashimema |
blimey |
| 08:24 |
|
Joubu |
ashimema: what's the problem? |
| 08:24 |
|
wahanui |
the problem is it has several code issues |
| 08:24 |
|
Joubu |
that's possible |
| 08:24 |
|
ashimema |
what problem? |
| 08:24 |
|
wahanui |
i heard problem was it has several code issues |
| 08:24 |
|
Joubu |
about load_sql_in_order |
| 08:25 |
|
ashimema |
Advice on C4::Installer Joubu |
| 08:25 |
|
ashimema |
why are some files placed where they're placed basically ;) |
| 08:26 |
|
ashimema |
like 'audio_alterts' is at installer/data/mysql/ but message_transport_types is under a /mandatory directory.. |
| 08:26 |
|
ashimema |
do you know if there is method to the madness? |
| 08:27 |
|
ashimema |
and.. why we don't just use prefixes on filenames to denote order rather than hard coding an order inside C4::Installer and consequently requireing us to add the filename into the list in there if/when one adds a new file? |
| 08:27 |
|
ashimema |
feels like we should just have /installer/data/mysql/mandatory and then iterate through all files in that directory to me |
| 08:29 |
|
Joubu |
ashimema: consider them at the same level. IIRC the ones under mandatory are the ones we moved from specific (language). The other ones are historical |
| 08:29 |
|
ashimema |
so new ones should probably go into mandatory |
| 08:29 |
|
ashimema |
rather than cluttering the top level further |
| 08:29 |
|
Joubu |
I'd say we should account_offset_types.sql, audio_alerts.sql, userflags.sql and userpermissions.sql to mandatory |
| 08:29 |
|
Joubu |
move* |
| 08:30 |
|
ashimema |
:) |
| 08:30 |
|
ashimema |
glad you agree |
| 08:30 |
|
ashimema |
I just wanted to make sure I wasn't missing sometihng |
| 08:30 |
|
ashimema |
* I just wanted to make sure I wasn't missing something |
| 08:30 |
|
Joubu |
and maybe sysprefs.sql as well actually :) |
| 08:30 |
|
ashimema |
also.. remind me.. |
| 08:30 |
|
Joubu |
but need a good sync with other projects (I have at least misc4dev in mind) |
| 08:30 |
|
ashimema |
how do the .txt files come into it? |
| 08:31 |
|
ashimema |
yeah.. misc4dev caught me out on my last push |
| 08:31 |
|
Joubu |
that's the description we displayed during the install process |
| 08:31 |
|
ashimema |
as you can probably tell by my rushed commit to it this morning |
| 08:31 |
|
Joubu |
display* |
| 08:31 |
|
ashimema |
I see |
| 08:35 |
|
koha-jenkins |
Project Koha_Master_D9 build #942: STILL UNSTABLE in 32 min: https://jenkins.koha-community[…]ha_Master_D9/942/ |
| 08:36 |
|
Joubu |
I think we should move them, then instead of listing them in misc4dev and C4::Installer we could have only a few at the beginning then load all the others (which does not depend on existing data) |
| 08:37 |
|
Joubu |
and we should also get rid of the .txt files |
| 08:37 |
|
ashimema |
+1 |
| 08:37 |
|
huginn |
News from kohagit: Bug 23805: (RM follow-up) Correction to sql installer file <http://git.koha-community.org/[…]2adb20e3ac013be26> |
| 08:39 |
|
ashimema |
that's better.. tests all pass locally again now |
| 08:45 |
|
|
andreash_ joined #koha |
| 08:53 |
|
|
inlibro joined #koha |
| 09:12 |
|
koha-jenkins |
Project Koha_Master_D9 build #943: STILL UNSTABLE in 33 min: https://jenkins.koha-community[…]ha_Master_D9/943/ |
| 09:22 |
|
koha-jenkins |
Project Koha_Master_D8 build #478: STILL UNSTABLE in 43 min: https://jenkins.koha-community[…]ha_Master_D8/478/ |
| 09:26 |
|
koha-jenkins |
Project Koha_Master_D10 build #46: STILL FAILING in 4 min 9 sec: https://jenkins.koha-community[…]ha_Master_D10/46/ |
| 09:26 |
|
ashimema |
just one test now :) |
| 09:41 |
|
Joubu |
ashimema: it's because of the follow-up I asked for yesterday |
| 09:41 |
|
Joubu |
the ->holds that must not returnundef |
| 09:41 |
|
ashimema |
thought it might be |
| 09:42 |
|
ashimema |
I'm just about to start digging.. unless of course you already are? |
| 09:42 |
|
marcelr |
Joubu: stripping the db name wasnt really part of the scope ? |
| 09:43 |
|
Joubu |
ashimema: patch attached |
| 09:44 |
|
Joubu |
marcelr: I do not manage to know if it's a mariadb/mysql or change between 2 versions. If we can fix everything on one bug report I think it's better :) |
| 09:44 |
|
marcelr |
hmm will strip it ;) |
| 09:46 |
|
ashimema |
? |
| 09:46 |
|
huginn |
News from kohagit: Bug 23413: Fix tests <http://git.koha-community.org/[…]7238fc3389a18f88a> |
| 09:46 |
|
koha-jenkins |
Project Koha_Master_U18 build #416: STILL UNSTABLE in 34 min: https://jenkins.koha-community[…]a_Master_U18/416/ |
| 09:48 |
|
|
alex_a joined #koha |
| 09:54 |
|
|
inlibro joined #koha |
| 10:15 |
|
koha-jenkins |
Project Koha_Master_D8 build #479: STILL UNSTABLE in 27 min: https://jenkins.koha-community[…]ha_Master_D8/479/ |
| 10:17 |
|
marcelr |
htg |
| 10:23 |
|
koha-jenkins |
Project Koha_Master_D9 build #944: STILL UNSTABLE in 57 min: https://jenkins.koha-community[…]ha_Master_D9/944/ |
| 10:32 |
|
huginn |
News from kohagit: Bug 23579: Remove default value for MEDIUMTEXT borrower_modifications.changed_fields <http://git.koha-community.org/[…]164b179833f712aeb> |
| 10:39 |
|
koha-jenkins |
Project Koha_Master_D10 build #47: STILL FAILING in 15 min: https://jenkins.koha-community[…]ha_Master_D10/47/ |
| 10:47 |
|
|
fridolin left #koha |
| 10:50 |
|
koha-jenkins |
Yippee, build fixed! |
| 10:50 |
|
wahanui |
Congratulations! |
| 10:50 |
|
koha-jenkins |
Project Koha_Master_U18 build #417: FIXED in 35 min: https://jenkins.koha-community[…]a_Master_U18/417/ |
| 10:54 |
|
|
inlibro joined #koha |
| 10:55 |
|
ashimema_ |
seems my irc client is going funky again today :( |
| 10:58 |
|
|
khall joined #koha |
| 11:01 |
|
magnuse |
kia ora khall |
| 11:01 |
|
khall |
mornin magnuse ! |
| 11:14 |
|
|
Dyrcona joined #koha |
| 11:18 |
|
koha-jenkins |
Project Koha_Master_D8 build #480: STILL UNSTABLE in 27 min: https://jenkins.koha-community[…]ha_Master_D8/480/ |
| 11:21 |
|
koha-jenkins |
Project Koha_Master_D10 build #48: STILL FAILING in 2 min 57 sec: https://jenkins.koha-community[…]ha_Master_D10/48/ |
| 11:35 |
|
|
oleonard joined #koha |
| 11:36 |
|
koha-jenkins |
Project Koha_Master_D9 build #945: STILL UNSTABLE in 57 min: https://jenkins.koha-community[…]ha_Master_D9/945/ |
| 11:37 |
|
oleonard |
Hi #koha |
| 11:39 |
|
|
alex_a joined #koha |
| 11:47 |
|
|
laurence joined #koha |
| 11:54 |
|
|
inlibro joined #koha |
| 11:55 |
|
ashimema |
23234 |
| 11:56 |
|
ashimema |
oops |
| 11:56 |
|
ashimema |
wrong window |
| 11:56 |
|
koha-jenkins |
Project Koha_Master_U18 build #418: UNSTABLE in 35 min: https://jenkins.koha-community[…]a_Master_U18/418/ |
| 12:00 |
|
* oleonard |
empties ashimema's bank account with that PIN number |
| 12:00 |
|
ashimema |
hehe |
| 12:15 |
|
huginn |
News from kohagit: Bug 23579: (RM follow-up) Fix failing tests <http://git.koha-community.org/[…]385804d06740097ad> |
| 12:25 |
|
huginn |
News from kohagit: Bug 23529: (QA follow-up) Fix closing bracket, add label <http://git.koha-community.org/[…]af08ee2126f34947f> |
| 12:25 |
|
huginn |
News from kohagit: Bug 23529: (follow-up) Fix syntax error <http://git.koha-community.org/[…]1775ac4b55d82c874> |
| 12:25 |
|
huginn |
News from kohagit: Bug 18743: Correct number of pending suggestions (acq home page) <http://git.koha-community.org/[…]805036ddbc7f3e4fa> |
| 12:25 |
|
huginn |
News from kohagit: Bug 18743: Fix suggestion listing when organized by library <http://git.koha-community.org/[…]03c6c8dcfb7f6e094> |
| 12:25 |
|
huginn |
News from kohagit: Bug 23529: Narrow scope of changed <http://git.koha-community.org/[…]4b0f2453a3aff4923> |
| 12:25 |
|
huginn |
News from kohagit: Bug 17168: (follow-up) QA concerns and rebase issues <http://git.koha-community.org/[…]e0f380f334a3ddf6f> |
| 12:25 |
|
huginn |
News from kohagit: Bug 17168: Remove j2a.pl <http://git.koha-community.org/[…]0336b4fb63891035b> |
| 12:25 |
|
huginn |
News from kohagit: Bug 17168: Add Koha:Script -cron, remove Dumper <http://git.koha-community.org/[…]7d50a26e7226f0923> |
| 12:25 |
|
huginn |
News from kohagit: Bug 17168: (follow-up) Address QA concerns and update for strict mode <http://git.koha-community.org/[…]1c6de82a08ea878ee> |
| 12:25 |
|
huginn |
News from kohagit: Bug 17168: (follow-up) Clean up QA errors <http://git.koha-community.org/[…]169308d38e99d4d6f> |
| 12:25 |
|
huginn |
News from kohagit: Bug 17168: (follow-up) Tidy, clean params/options, use date tools <http://git.koha-community.org/[…]1439e64d145c66cef> |
| 12:25 |
|
huginn |
News from kohagit: Bug 17168: Add a command line script for updating patron category based on status <http://git.koha-community.org/[…]1a5e8d56153f10dfe> |
| 12:33 |
|
koha-jenkins |
Project Koha_Master_D9 build #946: STILL UNSTABLE in 57 min: https://jenkins.koha-community[…]ha_Master_D9/946/ |
| 12:35 |
|
|
khall joined #koha |
| 12:47 |
|
|
wizzyrea joined #koha |
| 12:49 |
|
koha-jenkins |
Project Koha_Master_U18 build #419: STILL UNSTABLE in 34 min: https://jenkins.koha-community[…]a_Master_U18/419/ |
| 12:54 |
|
koha-jenkins |
Project Koha_Master_D10 build #49: STILL FAILING in 4 min 42 sec: https://jenkins.koha-community[…]ha_Master_D10/49/ |
| 12:54 |
|
|
inlibro joined #koha |
| 13:11 |
|
|
bdonnahue joined #koha |
| 13:12 |
|
|
khall joined #koha |
| 13:18 |
|
koha-jenkins |
Project Koha_Master_D8 build #481: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]ha_Master_D8/481/ |
| 13:20 |
|
|
blou joined #koha |
| 13:23 |
|
|
khall joined #koha |
| 13:26 |
|
|
blou_ joined #koha |
| 13:29 |
|
koha-jenkins |
Project Koha_Master_D9 build #947: STILL UNSTABLE in 34 min: https://jenkins.koha-community[…]ha_Master_D9/947/ |
| 13:29 |
|
|
khall joined #koha |
| 13:33 |
|
|
caroline_catlady joined #koha |
| 13:37 |
|
wizzyrea |
i'm doing some maintenance on the KC website, there may be brief outages. |
| 13:37 |
|
magnuse |
wizzyrea++ |
| 13:42 |
|
magnuse |
have fun #koha! |
| 13:44 |
|
caroline_catlady |
hi all! |
| 13:45 |
|
lari |
wizzyrea: any update on the support companies list issue? |
| 13:50 |
|
oleonard |
wizzyrea++ |
| 13:54 |
|
|
inlibro joined #koha |
| 13:57 |
|
ashimema |
https://bugs.koha-community.or[…]_bug.cgi?id=13897 |
| 13:57 |
|
huginn |
Bug 13897: enhancement, P5 - low, ---, bgkriegel, In Discussion , Use XML files for installer data |
| 13:57 |
|
wizzyrea |
lari: if I'm lucky I'll get to look at it today |
| 13:58 |
|
* ashimema |
wouldn't mind some training on how to do that wizzyrea ;) |
| 13:58 |
|
wizzyrea |
well it's currently kinda broken |
| 13:59 |
|
wizzyrea |
and it'll probably be different when it's fixed |
| 13:59 |
|
wizzyrea |
so let me work out how it's gonna go and then I'll show you :) |
| 13:59 |
|
ashimema |
i see |
| 13:59 |
|
wizzyrea |
today is jessie -> stretch |
| 13:59 |
|
wizzyrea |
i mean that's the maintenance that could cause outages. |
| 14:00 |
|
ashimema |
okies :) |
| 14:11 |
|
|
lukeG joined #koha |
| 14:18 |
|
koha-jenkins |
Project Koha_Master_U18 build #420: STILL UNSTABLE in 1 hr 0 min: https://jenkins.koha-community[…]a_Master_U18/420/ |
| 14:31 |
|
reiveune |
bye |
| 14:31 |
|
|
reiveune left #koha |
| 14:52 |
|
|
khall joined #koha |
| 14:54 |
|
|
inlibro joined #koha |
| 14:59 |
|
|
laurence left #koha |
| 15:03 |
|
wizzyrea |
alright I think I'm done breaking koha-community.org for the moment, it's all shiny and fresh. |
| 15:04 |
|
wizzyrea |
new php and everything! |
| 15:04 |
|
ashimema |
wizzyrea++ |
| 15:05 |
|
|
bdonnahue joined #koha |
| 15:06 |
|
caroline_catlady |
Is https://pasteboard.co/IDCzMQb.gif (excuse the immense lag in the beginning) the same as bug 22269? |
| 15:06 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22269 normal, P5 - low, ---, koha-bugs, NEW , Pay amount - modal confirmation of amount to return to patron should be suppressed if attempting to pay (not collect) more than owed |
| 15:07 |
|
caroline_catlady |
I'm not sure because I just set the amount collected higher that the amount to be paid |
| 15:08 |
|
caroline_catlady |
kidclamp maybe? as you were the one who reported the bug |
| 15:09 |
|
oleonard |
wizzyrea: You're very brave to say "php" in this channel |
| 15:14 |
|
caroline_catlady |
bbl |
| 15:20 |
|
wizzyrea |
what, it's wordpress. |
| 15:20 |
|
wizzyrea |
>.> |
| 15:20 |
|
wizzyrea |
speaking of shiny and new |
| 15:20 |
|
wizzyrea |
has anyone done Koha on Debian Buster? |
| 15:21 |
|
wizzyrea |
(also I've gotten over my 'ew, php' - it works for some stuff, and people like it, and it's pretty accessible. Let people use the tools they like.) |
| 15:21 |
|
* oleonard |
agrees |
| 15:22 |
|
wizzyrea |
just happens that it's not the tool we use for Koha, and no we're not going to rewrite it. |
| 15:22 |
|
oleonard |
Not that the idea has never been proposed. |
| 15:23 |
|
wizzyrea |
not seriously >.> |
| 15:55 |
|
|
inlibro joined #koha |
| 16:34 |
|
wizzyrea |
lari, about? |
| 16:35 |
|
wizzyrea |
never mind I found what I needed :) |
| 16:39 |
|
wizzyrea |
@later tell lari I've added your contact to the directory |
| 16:39 |
|
huginn |
wizzyrea: The operation succeeded. |
| 16:50 |
|
|
cait joined #koha |
| 16:55 |
|
|
inlibro joined #koha |
| 16:55 |
|
|
bdonnahue1 joined #koha |
| 17:04 |
|
oleonard |
anyone have any clever debugging tricks for custom XSLT? |
| 17:07 |
|
oleonard |
I'm currently at blank-screen stage. |
| 17:19 |
|
|
corilynn_ joined #koha |
| 17:21 |
|
|
corilynn_ joined #koha |
| 17:23 |
|
ashimema |
wizzyrea the packages aren't happy on buster at the moment.. perl version and Perl module dependency issues. |
| 17:24 |
|
Nemo_bis |
oleonard: what are you using to execute the XSLT? |
| 17:24 |
|
ashimema |
We've got drojf working on it for us.. and already have (the currently failing) D10 builds going in Jenkins |
| 17:24 |
|
oleonard |
Nemo_bis: ...Koha (staff client detail view) |
| 17:24 |
|
Nemo_bis |
emacs has an XSLT mode to validate XSLT, I used it once but was not super happy |
| 17:25 |
|
ashimema |
My tip for xslt issues is to first rule out screwy XML by copying it into an online validator |
| 17:25 |
|
ashimema |
Yeah, if your have a validator in your effort that's even better |
| 17:25 |
|
Nemo_bis |
oleonard: ah, then I'm not sure; usually I just make sure my local xsltproc has the same version as the server and then try it locally until it seems to work |
| 17:26 |
|
ashimema |
Usually it's XML parsing issues in my experience |
| 17:26 |
|
ashimema |
It's not at all forgiving |
| 17:26 |
|
oleonard |
I know it's xslt problems because I'm testing customizations to the xslt |
| 17:27 |
|
ashimema |
https://www.freeformatter.com/[…]-transformer.html |
| 17:28 |
|
ashimema |
In which case.. pass |
| 17:28 |
|
ashimema |
Good luck.. |
| 17:28 |
|
oleonard |
I wonder if the server where the xsl file is hosted could be sending it with the wrong content type or something |
| 17:28 |
|
ashimema |
Oh, could be |
| 17:28 |
|
ashimema |
Anything in the logs? |
| 17:29 |
|
oleonard |
Not in the error logs |
| 17:37 |
|
oleonard |
A different online testing tool says "Error: Cannot find a matching 2-argument function named {http://exslt.org/strings}encode-uri()" |
| 17:39 |
|
oleonard |
But the only thing different is I've uploaded the XSL files from master to a remote server and pointed the XSLTDetailsDisplay pref to it |
| 17:48 |
|
corilynn_ |
is there anyway to change what information is returned on this page: /cgi-bin/koha/cataloguing/addbooks.pl ? |
| 17:49 |
|
corilynn_ |
https://paste.pics/658e5727b28[…]ea510b908c27faf9a ? |
| 17:51 |
|
oleonard |
Not without hacking the script |
| 17:51 |
|
corilynn_ |
ok |
| 17:55 |
|
|
inlibro joined #koha |
| 18:08 |
|
tcohen |
hi all |
| 18:11 |
|
wizzyrea |
hazard warning, I've decided because I'm feeling motivated to go ahead and take the kc webserver to buster from stretch. |
| 18:11 |
|
wizzyrea |
so there may be brief interruptions. |
| 18:27 |
|
wizzyrea |
ok, that's done \o/ |
| 18:29 |
|
tcohen |
confetti! |
| 18:29 |
|
wahanui |
o/`'`'`'`'`'`'`'`'`'`'`'` |
| 18:29 |
|
tcohen |
wizzyrea++ |
| 18:30 |
|
oleonard |
ฅ^•ﻌ•^ฅ |
| 18:30 |
|
wizzyrea |
it was stressing me out that it was behind! |
| 18:33 |
|
|
Joubu joined #koha |
| 18:33 |
|
|
jajm joined #koha |
| 18:33 |
|
|
paxed joined #koha |
| 18:33 |
|
|
davidnind[m] joined #koha |
| 18:33 |
|
|
koha-jenkins joined #koha |
| 18:33 |
|
|
pizzaguy joined #koha |
| 18:33 |
|
|
tuxayo joined #koha |
| 18:33 |
|
|
janPasi joined #koha |
| 18:33 |
|
|
fraktik_ joined #koha |
| 18:33 |
|
|
fraktik joined #koha |
| 18:33 |
|
|
matts joined #koha |
| 18:33 |
|
|
kohaputti joined #koha |
| 18:33 |
|
|
cait joined #koha |
| 18:33 |
|
|
nage joined #koha |
| 18:33 |
|
|
kivilahtio joined #koha |
| 18:33 |
|
|
KotH joined #koha |
| 18:33 |
|
|
ashimema joined #koha |
| 18:33 |
|
|
sonOfRa joined #koha |
| 18:33 |
|
|
mirkh joined #koha |
| 18:33 |
|
|
AnnaBoten joined #koha |
| 18:33 |
|
|
fredericd joined #koha |
| 18:33 |
|
|
lari joined #koha |
| 18:33 |
|
|
GiuseppeP joined #koha |
| 18:33 |
|
|
valterbarreira[m] joined #koha |
| 18:33 |
|
|
zb joined #koha |
| 18:33 |
|
|
Nemo_bis joined #koha |
| 18:33 |
|
|
killer_bee[m] joined #koha |
| 18:33 |
|
|
skimsk joined #koha |
| 18:33 |
|
|
liliputech_asu joined #koha |
| 18:33 |
|
|
jo joined #koha |
| 18:33 |
|
|
clrh joined #koha |
| 18:33 |
|
|
slef joined #koha |
| 18:41 |
|
wizzyrea |
well that was fun |
| 18:45 |
|
oleonard |
wizzyrea: it's weird that we were all sucked into a parallel dimension where the only difference is there aren't jetpacks |
| 18:53 |
|
oleonard |
It doesn't have a proper test plan yet but if anyone is interested, for Bug 23903: https://gitlab.com/koha-dev/ko[…]/ip-opac-fa-icons |
| 18:53 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23903 enhancement, P5 - low, ---, oleonard, ASSIGNED , Replace OPAC icons with Font Awesome |
| 18:55 |
|
|
inlibro joined #koha |
| 18:55 |
|
oleonard |
Happy weekend everyone |
| 19:02 |
|
|
bdonnahue1 joined #koha |
| 19:10 |
|
|
cait joined #koha |
| 19:10 |
|
|
kohaputti joined #koha |
| 19:10 |
|
|
matts joined #koha |
| 19:10 |
|
|
fraktik joined #koha |
| 19:10 |
|
|
fraktik_ joined #koha |
| 19:10 |
|
|
janPasi joined #koha |
| 19:10 |
|
|
tuxayo joined #koha |
| 19:10 |
|
|
pizzaguy joined #koha |
| 19:10 |
|
|
koha-jenkins joined #koha |
| 19:10 |
|
|
davidnind[m] joined #koha |
| 19:10 |
|
|
paxed joined #koha |
| 19:10 |
|
|
jajm joined #koha |
| 19:10 |
|
|
Joubu joined #koha |
| 19:13 |
|
wizzyrea |
man, oleonard talks about jetpacks and I'm putting out fires and I miss it. |
| 19:16 |
|
|
andreashm joined #koha |
| 19:20 |
|
|
lukeG1 joined #koha |
| 19:39 |
|
|
khall joined #koha |
| 19:50 |
|
lukeG1 |
hey all this is probably worth a look at: https://bugs.koha-community.or[…]_bug.cgi?id=23904 |
| 19:50 |
|
huginn |
Bug 23904: major, P5 - low, ---, koha-bugs, NEW , Chrome 74 update does not allow use of window.open() |
| 19:54 |
|
|
khall joined #koha |
| 19:55 |
|
wizzyrea |
^^^ that's gonna be a Big Deal |
| 19:55 |
|
|
inlibro joined #koha |
| 19:57 |
|
tcohen |
uh oh |
| 20:01 |
|
|
khall joined #koha |
| 20:22 |
|
|
khall joined #koha |
| 20:23 |
|
|
Dyrcona joined #koha |
| 20:46 |
|
|
lukeG joined #koha |
| 20:55 |
|
|
inlibro joined #koha |
| 21:08 |
|
|
khall joined #koha |
| 21:49 |
|
|
khall joined #koha |
| 21:56 |
|
|
inlibro joined #koha |
| 22:06 |
|
|
khall joined #koha |
| 22:07 |
|
|
andreashm joined #koha |
| 22:22 |
|
|
khall joined #koha |
| 22:23 |
|
|
bdonnahue joined #koha |
| 22:56 |
|
|
inlibro joined #koha |
| 23:56 |
|
|
inlibro joined #koha |
