| Time |
S |
Nick |
Message |
| 00:25 |
|
|
caroline_crazycatlady joined #koha |
| 00:49 |
|
|
inlibro joined #koha |
| 01:32 |
|
|
aleisha joined #koha |
| 01:49 |
|
|
inlibro joined #koha |
| 02:50 |
|
|
inlibro joined #koha |
| 03:50 |
|
|
inlibro joined #koha |
| 04:50 |
|
|
inlibro joined #koha |
| 05:12 |
|
|
chris joined #koha |
| 05:33 |
|
|
cait joined #koha |
| 05:41 |
|
|
cait1 joined #koha |
| 05:42 |
|
|
cait1 left #koha |
| 05:50 |
|
|
inlibro joined #koha |
| 06:33 |
|
|
laurence joined #koha |
| 06:50 |
|
|
inlibro joined #koha |
| 07:07 |
|
|
alex_a joined #koha |
| 07:08 |
|
alex_a |
Bonjour |
| 07:15 |
|
|
greenjimll joined #koha |
| 07:25 |
|
|
fridolin joined #koha |
| 07:26 |
|
fridolin |
hi |
| 07:26 |
|
|
alex_a joined #koha |
| 07:32 |
|
|
paul_p joined #koha |
| 07:47 |
|
|
alex_a joined #koha |
| 07:50 |
|
|
inlibro joined #koha |
| 08:05 |
|
|
alexbuckley joined #koha |
| 08:21 |
|
|
alex_a joined #koha |
| 08:23 |
|
|
alex_a_ joined #koha |
| 08:38 |
|
|
paul_p joined #koha |
| 08:51 |
|
|
inlibro joined #koha |
| 09:25 |
|
|
laurence joined #koha |
| 09:51 |
|
|
inlibro joined #koha |
| 09:52 |
|
|
alex_a joined #koha |
| 09:57 |
|
|
khall joined #koha |
| 10:27 |
|
kidclamp |
hi fridolin |
| 10:28 |
|
kidclamp |
aleisha: |
| 10:28 |
|
kidclamp |
alex_a |
| 10:28 |
|
kidclamp |
:-) |
| 10:51 |
|
|
inlibro joined #koha |
| 10:58 |
|
|
laurence left #koha |
| 11:21 |
|
|
oleonard joined #koha |
| 11:21 |
|
oleonard |
Hi all |
| 11:21 |
|
|
andreashm joined #koha |
| 11:30 |
|
kidclamp |
hi oleonard |
| 11:30 |
|
wahanui |
hi oleopard |
| 11:31 |
|
oleonard |
What's up with you today kidclamp? |
| 11:32 |
|
* kidclamp |
read that as a friendly question, but then as an accusation |
| 11:32 |
|
kidclamp |
nothing'sup, I am acting completely normal! |
| 11:32 |
|
kidclamp |
what's up with you oleonard? |
| 11:33 |
|
oleonard |
"What is it with you today??" |
| 11:33 |
|
oleonard |
I'm back on my drag-and-drop grind |
| 11:33 |
|
kidclamp |
What's with today today!? |
| 11:34 |
|
oleonard |
Two out of the three methods we offer for re-ordering holds priority are working in my tests |
| 11:34 |
|
kidclamp |
Just poking bugs and going through my to do list |
| 11:34 |
|
kidclamp |
just remove the third method :-) |
| 11:35 |
|
|
alex_a joined #koha |
| 11:35 |
|
* oleonard |
can't take that kind of heat |
| 11:46 |
|
|
alex_a_ joined #koha |
| 11:51 |
|
|
inlibro joined #koha |
| 11:52 |
|
|
khall joined #koha |
| 11:55 |
|
kidclamp |
bug 19718 needs some styling if you want an easy thing oleonard |
| 11:55 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19718 enhancement, P5 - low, ---, nick, Needs Signoff , Create message for patrons with multiple holds on the same item |
| 11:58 |
|
oleonard |
https://tenor.com/tmOp.gif |
| 12:06 |
|
kidclamp |
"What is with me today?" |
| 12:06 |
|
* kidclamp |
runs away |
| 12:21 |
|
magnuse |
@wunder bodø, norway |
| 12:21 |
|
huginn |
magnuse: Error: I could not find a valid location for: bodø, norway |
| 12:21 |
|
magnuse |
@wunder bodo, norway |
| 12:21 |
|
huginn |
magnuse: Error: Failed to load Wunderground API. Check the logs for more information. |
| 12:21 |
|
oleonard |
The weather is dead. There is no more weather. |
| 12:21 |
|
magnuse |
well i can tell you it's +22C here! |
| 12:22 |
|
oleonard |
! |
| 12:22 |
|
magnuse |
unseasonably warm |
| 12:51 |
|
|
inlibro joined #koha |
| 13:00 |
|
|
andreashm joined #koha |
| 13:06 |
|
|
caroline_catlady joined #koha |
| 13:09 |
|
oleonard |
https://zivotdesign.com/p/view[…]?p=15669977489011 |
| 13:28 |
|
* fridolin |
release is coming ;) |
| 13:47 |
|
|
wizzyrea joined #koha |
| 13:48 |
|
wizzyrea |
hi :) |
| 13:49 |
|
oleonard |
Hi wizzyrea |
| 13:51 |
|
|
inlibro joined #koha |
| 13:55 |
|
|
caroline_catlady joined #koha |
| 13:59 |
|
* kidclamp |
waves |
| 14:00 |
|
|
andreashm joined #koha |
| 14:01 |
|
|
andreashm joined #koha |
| 14:02 |
|
|
andreashm joined #koha |
| 14:02 |
|
koha-jenkins |
Project Koha_19.05_U18 build #29: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_19.05_U18/29/ |
| 14:02 |
|
|
andreashm joined #koha |
| 14:03 |
|
|
andreashm joined #koha |
| 14:04 |
|
|
andreashm joined #koha |
| 14:05 |
|
|
andreashm joined #koha |
| 14:11 |
|
koha-jenkins |
Project Koha_19.05_D9 build #30: SUCCESS in 41 min: https://jenkins.koha-community[…]Koha_19.05_D9/30/ |
| 14:12 |
|
koha-jenkins |
Project Koha_19.05_D8 build #28: SUCCESS in 43 min: https://jenkins.koha-community[…]Koha_19.05_D8/28/ |
| 14:22 |
|
|
lari joined #koha |
| 14:27 |
|
koha-jenkins |
Project Koha_Master_D8 build #370: STILL UNSTABLE in 24 min: https://jenkins.koha-community[…]ha_Master_D8/370/ |
| 14:28 |
|
|
andreashm joined #koha |
| 14:49 |
|
koha-jenkins |
Project Koha_19.05_U18 build #30: SUCCESS in 37 min: https://jenkins.koha-community[…]oha_19.05_U18/30/ |
| 14:50 |
|
|
fridolin left #koha |
| 14:50 |
|
koha-jenkins |
Project Koha_19.05_D8 build #29: SUCCESS in 23 min: https://jenkins.koha-community[…]Koha_19.05_D8/29/ |
| 14:52 |
|
|
inlibro joined #koha |
| 14:53 |
|
|
deb-CSPL joined #koha |
| 14:56 |
|
koha-jenkins |
Project Koha_19.05_D9 build #31: FAILURE in 43 min: https://jenkins.koha-community[…]Koha_19.05_D9/31/ |
| 15:03 |
|
|
andreashm joined #koha |
| 15:17 |
|
koha-jenkins |
Project Koha_18.11_D9 build #152: SUCCESS in 26 min: https://jenkins.koha-community[…]oha_18.11_D9/152/ |
| 15:18 |
|
oleonard |
This holds priority rabbit hole just keeps going |
| 15:21 |
|
koha-jenkins |
Project Koha_18.11_U18 build #145: SUCCESS in 32 min: https://jenkins.koha-community[…]ha_18.11_U18/145/ |
| 15:29 |
|
oleonard |
tcohen around? |
| 15:32 |
|
oleonard |
Anyone else who might be able to help me with the holds API? |
| 15:35 |
|
kidclamp |
I can try |
| 15:35 |
|
koha-jenkins |
Project Koha_18.11_D8 build #153: SUCCESS in 39 min: https://jenkins.koha-community[…]oha_18.11_D8/153/ |
| 15:35 |
|
oleonard |
Thanks kidclamp. The api docs say "DELETE /api/v1/holds/{hold_id}" and "Operation ID: deleteHold" |
| 15:36 |
|
oleonard |
Does the operation id need to be passed in order for it to be recognized as a delete operation? |
| 15:38 |
|
kidclamp |
I don't believe so |
| 15:38 |
|
kidclamp |
It is the method that shoudl matter |
| 15:39 |
|
oleonard |
Ah I get it. I was thinking in terms of "GET/POST" not methods |
| 15:39 |
|
oleonard |
Thanks! |
| 15:40 |
|
kidclamp |
that is what I mean by method though "GET/POST/PUT/DELETE" |
| 15:40 |
|
kidclamp |
we might be argreeing |
| 15:40 |
|
oleonard |
I'm used to there being a GET/POST binary |
| 15:40 |
|
oleonard |
(in the context of forms) |
| 15:41 |
|
kidclamp |
ah, okay, the API recognizes a few more |
| 15:42 |
|
oleonard |
kidclamp++ |
| 15:43 |
|
koha-jenkins |
Project Koha_18.11_D9 build #153: SUCCESS in 25 min: https://jenkins.koha-community[…]oha_18.11_D9/153/ |
| 15:52 |
|
|
inlibro joined #koha |
| 15:54 |
|
koha-jenkins |
Project Koha_18.11_U18 build #146: SUCCESS in 32 min: https://jenkins.koha-community[…]ha_18.11_U18/146/ |
| 15:58 |
|
|
andreashm joined #koha |
| 16:02 |
|
|
deb-CSPL joined #koha |
| 16:02 |
|
|
lukeG joined #koha |
| 16:07 |
|
|
Mandersoon joined #koha |
| 16:09 |
|
koha-jenkins |
Project Koha_18.11_D9 build #154: SUCCESS in 25 min: https://jenkins.koha-community[…]oha_18.11_D9/154/ |
| 16:14 |
|
koha-jenkins |
Project Koha_18.11_D8 build #154: SUCCESS in 38 min: https://jenkins.koha-community[…]oha_18.11_D8/154/ |
| 16:26 |
|
koha-jenkins |
Project Koha_18.11_U18 build #147: SUCCESS in 32 min: https://jenkins.koha-community[…]ha_18.11_U18/147/ |
| 16:29 |
|
|
davidnind joined #koha |
| 16:29 |
|
|
davidnind left #koha |
| 16:34 |
|
|
cait joined #koha |
| 16:34 |
|
koha-jenkins |
Project Koha_18.11_D9 build #155: SUCCESS in 25 min: https://jenkins.koha-community[…]oha_18.11_D9/155/ |
| 16:47 |
|
oleonard |
https://tenor.com/o6ti.gif |
| 16:52 |
|
|
inlibro joined #koha |
| 16:52 |
|
koha-jenkins |
Project Koha_18.11_D8 build #155: SUCCESS in 38 min: https://jenkins.koha-community[…]oha_18.11_D8/155/ |
| 16:53 |
|
oleonard |
holds api doesn't let you update the pickup location if you don't have permission to change priority? |
| 16:54 |
|
cait |
m possibly |
| 16:54 |
|
cait |
oh |
| 16:54 |
|
cait |
but it should work.. right? |
| 16:55 |
|
oleonard |
I get a "forbidden" response from the holds api if I try to delete a hold or change pickup location as a user without permission to modify priority |
| 16:55 |
|
cait |
bug? |
| 16:55 |
|
cait |
maybe a cit too strict |
| 16:55 |
|
cait |
a bit |
| 16:57 |
|
tcohen |
oleonard: |
| 16:57 |
|
tcohen |
I'm here if you need smth |
| 16:58 |
|
oleonard |
Thanks tcohen, I'm trying to figure out whether a user has to have all holds permissions to modify holds via the api |
| 16:59 |
|
koha-jenkins |
Project Koha_18.11_U18 build #148: SUCCESS in 32 min: https://jenkins.koha-community[…]ha_18.11_U18/148/ |
| 17:03 |
|
tcohen |
oleonard: the permissions might be wrong |
| 17:03 |
|
oleonard |
tcohen: It looks to me like you have to have "modify_holds_priority" permission for deletion via the API to work. Same for modifying just the hold pickup location |
| 17:03 |
|
|
cait1 joined #koha |
| 17:04 |
|
tcohen |
DELETE => https://gitlab.com/koha-commun[…]s/holds.json#L385 |
| 17:05 |
|
tcohen |
PUT => https://gitlab.com/koha-commun[…]s/holds.json#L332 |
| 17:05 |
|
tcohen |
reserveforothers |
| 17:05 |
|
tcohen |
is the required permission |
| 17:07 |
|
oleonard |
If the user has only "place_holds" permission they don't have "reserveforothers" |
| 17:08 |
|
oleonard |
...but a user with only "place_holds" permission can delete a hold via the regular interface. |
| 17:08 |
|
oleonard |
Perhaps that is wrong? |
| 17:09 |
|
|
cait2 joined #koha |
| 17:15 |
|
oleonard |
It doesn't make sense for someone to have permission to modify holds priority but not place holds |
| 17:24 |
|
wizzyrea |
https://bugs.koha-community.or[…]_bug.cgi?id=18895 this bug is rather yucky and forgotten |
| 17:24 |
|
huginn |
Bug 18895: major, P5 - low, ---, koha-bugs, NEW , Lost Items Not Removed From Patron's Account When Charge is Paid |
| 17:39 |
|
|
caroline_catlady joined #koha |
| 17:46 |
|
koha-jenkins |
Project Koha_18.11_D9 build #156: SUCCESS in 26 min: https://jenkins.koha-community[…]oha_18.11_D9/156/ |
| 17:49 |
|
andreashm |
wizzyrea: from our recent tests (on 17.11 and 18.11) lost books _are_ removed from the patron account (using write off for example). |
| 17:49 |
|
andreashm |
staff here of course want's them to remain on the user account. =/ |
| 17:52 |
|
|
inlibro joined #koha |
| 17:53 |
|
koha-jenkins |
Project Koha_18.11_U18 build #149: SUCCESS in 32 min: https://jenkins.koha-community[…]ha_18.11_U18/149/ |
| 17:53 |
|
andreashm |
it seems the items status isn't taken into account at all either (it can be changed from lost to available, and the item is still removed from the patron acount when the lost fee is removed) |
| 17:53 |
|
cait2 |
andreashm: did you configure it with the pref? |
| 17:54 |
|
cait2 |
wondering if it makes a difference |
| 17:54 |
|
andreashm |
which pref? |
| 17:54 |
|
andreashm |
marklostasreturned? |
| 17:54 |
|
cait2 |
MarkLostItemsAsReturned |
| 17:54 |
|
cait2 |
yep, sorry, was just looking it up |
| 17:55 |
|
andreashm |
=) |
| 17:55 |
|
|
deb-CSPL joined #koha |
| 17:55 |
|
andreashm |
yeah, no option choosen (books should never be marked as returned). payments doesn't seem to care |
| 17:55 |
|
andreashm |
cait: ^ |
| 17:55 |
|
andreashm |
cait2 even |
| 17:56 |
|
cait2 |
not good |
| 17:56 |
|
cait2 |
ashimema is not around this week - is there a bug? |
| 17:57 |
|
andreashm |
don't know. there is no specific "payments" option in marklostitemsasreturned. perhaps they should be? |
| 17:58 |
|
koha-jenkins |
Project Koha_18.11_D8 build #156: SUCCESS in 38 min: https://jenkins.koha-community[…]oha_18.11_D8/156/ |
| 18:00 |
|
cait2 |
there seem way too many options about lost these days - quite confusing |
| 18:00 |
|
andreashm |
yes. |
| 18:00 |
|
oleonard |
modrequest.pl doesn't check for any holds-related permission :( |
| 18:01 |
|
andreashm |
having it context-based is the problem I think. should be defined by the lost status instead (and being able to configure those, when to return or not) |
| 18:01 |
|
cait2 |
true |
| 18:01 |
|
cait2 |
i would like it to be tied to the status somehow |
| 18:02 |
|
andreashm |
yeah, that would be good |
| 18:02 |
|
andreashm |
didn't I see a bug recently about changing the lost statuses? |
| 18:04 |
|
|
cait joined #koha |
| 18:06 |
|
cait |
andreashm: i think that was only rewriting because of the acounts restructuring |
| 18:06 |
|
andreashm |
ah ok |
| 18:06 |
|
cait |
not a functional change - but might be i just haven't seen it |
| 18:07 |
|
andreashm |
you're probably right |
| 18:25 |
|
oleonard |
Bug 23516 |
| 18:25 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23516 major, P5 - low, ---, koha-bugs, NEW , Incorrect permissions on modrequest.pl could lead to unauthorized hold changes |
| 18:46 |
|
oleonard |
tcohen: Bug 23517 |
| 18:46 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23517 normal, P5 - low, ---, koha-bugs, NEW , Incorrect permission requirements for holds operations via the API |
| 18:47 |
|
oleonard |
That puts a "hold" on my holds drag-and-drop project (har har) |
| 18:48 |
|
tcohen |
oleonard: fair enough, I'll submit a patch if you need it |
| 18:48 |
|
oleonard |
The problem I see is the separate permission for priority changes |
| 18:51 |
|
oleonard |
I would love it if you could take a look |
| 18:52 |
|
|
inlibro joined #koha |
| 18:57 |
|
oleonard |
See y'all later |
| 19:06 |
|
|
magnuse joined #koha |
| 19:52 |
|
|
inlibro joined #koha |
| 20:48 |
|
|
alexbuckley joined #koha |
| 20:53 |
|
|
inlibro joined #koha |
| 21:06 |
|
aleisha |
hello |
| 21:26 |
|
magnuse |
hiya aleisha |
| 21:26 |
|
aleisha |
hi magnuse |
| 21:26 |
|
magnuse |
only 60 days left! you can do it! :-) |
| 21:26 |
|
aleisha |
lol thank you! love the support |
| 21:27 |
|
magnuse |
aleisha++ |
| 21:27 |
|
* magnuse |
wanders off and to sleep |
| 21:27 |
|
aleisha |
night :) |
| 21:53 |
|
|
inlibro joined #koha |
| 21:54 |
|
|
lisettelatah joined #koha |
| 22:43 |
|
|
Mandersoon joined #koha |
| 22:53 |
|
|
inlibro joined #koha |
| 23:10 |
|
|
sonOfRa joined #koha |
| 23:36 |
|
|
kohaputti joined #koha |
| 23:53 |
|
|
inlibro joined #koha |
