| Time |
S |
Nick |
Message |
| 01:29 |
|
mtj |
hey #koha, is anyone running mariadb 10.3 on production? |
| 02:56 |
|
|
cait1 joined #koha |
| 03:50 |
|
|
alexbuckley joined #koha |
| 05:57 |
|
|
chris1 joined #koha |
| 06:00 |
|
|
alexbuckley joined #koha |
| 06:09 |
|
|
fridolin joined #koha |
| 06:09 |
|
fridolin |
hi |
| 06:24 |
|
|
cait joined #koha |
| 06:28 |
|
|
calire joined #koha |
| 06:50 |
|
|
josef_moravec joined #koha |
| 07:36 |
|
|
reiveune joined #koha |
| 07:36 |
|
reiveune |
hello |
| 07:36 |
|
wahanui |
privet, reiveune |
| 07:39 |
|
|
AndrewIsh joined #koha |
| 07:44 |
|
|
marcelr joined #koha |
| 07:44 |
|
marcelr |
hi #koha |
| 07:44 |
|
josef_moravec |
hi marcelr, reiveune, AndrewIsh |
| 07:45 |
|
marcelr |
o/ |
| 07:56 |
|
|
laurence joined #koha |
| 08:04 |
|
paxed |
so... rancor doesn't work with value builder plugins, at all? |
| 08:05 |
|
|
andreashm joined #koha |
| 08:09 |
|
|
paul_p joined #koha |
| 08:10 |
|
|
greenjimll joined #koha |
| 08:12 |
|
|
calire left #koha |
| 08:21 |
|
|
sophie_m joined #koha |
| 08:21 |
|
* AndrewIsh |
waves at josef_moravec |
| 08:23 |
|
josef_moravec |
AndrewIsh: bug 18837 ;) |
| 08:23 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18837 enhancement, P5 - low, ---, andrew.isherwood, Passed QA , Add an unmediated Interlibrary Loans workflow |
| 08:28 |
|
AndrewIsh |
Yay! |
| 08:28 |
|
AndrewIsh |
josef_moravec++ |
| 08:29 |
|
josef_moravec |
AndrewIsh++ |
| 08:38 |
|
|
andreashm joined #koha |
| 08:40 |
|
|
nlegrand joined #koha |
| 08:40 |
|
nlegrand |
A gut yor #Koha |
| 08:45 |
|
tuxayo |
hi nlegrand o/ |
| 08:45 |
|
josef_moravec |
hi nlegrand, tuxayo |
| 08:46 |
|
tuxayo |
hi josef_moravec :) |
| 08:46 |
|
|
paul_p_ joined #koha |
| 08:47 |
|
nlegrand |
o/ tuxayo josef_moravec |
| 08:48 |
|
tuxayo |
(I remember that you had the issue from the hackfest ^^) |
| 08:48 |
|
* andreashm |
waves |
| 08:50 |
|
josef_moravec |
AndrewIsh: Bug 20563 :) |
| 08:50 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20563 enhancement, P5 - low, ---, andrew.isherwood, Passed QA , ILL request list gives no indication of source and/or target |
| 08:50 |
|
|
andreashm joined #koha |
| 08:51 |
|
AndrewIsh |
Woohoo! |
| 08:51 |
|
AndrewIsh |
josef_moravec++ |
| 08:51 |
|
AndrewIsh |
Thanks very much! I'll have to rebase the next one, there's no way that's going to apply :) |
| 08:51 |
|
AndrewIsh |
:-O The next one is the LAST one <feints> |
| 08:52 |
|
josef_moravec |
AndrewIsh: yes, it really need a rebase |
| 08:52 |
|
AndrewIsh |
josef_moravec: I'll get on it :) |
| 08:52 |
|
josef_moravec |
AndrewIsh: thanks! |
| 08:52 |
|
tuxayo |
nlegrand: depending on you version of Koha, bug 18723 might be ready for you. |
| 08:53 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18723 critical, P5 - low, ---, josef.moravec, Pushed to Stable , Dot not recognized as decimal separator on receive |
| 08:53 |
|
josef_moravec |
This is very important one I think ;) |
| 08:53 |
|
AndrewIsh |
josef_moravec: It is :) |
| 08:54 |
|
nlegrand |
tuxayo: ha ha! Thank you! |
| 08:56 |
|
josef_moravec |
AndrewIsh: not sure, but maybe you could use the api objects plugin to get requests in list method |
| 08:56 |
|
josef_moravec |
AndrewIsh: see https://github.com/Koha-Commun[…]V1/Library.pm#L46 |
| 08:57 |
|
josef_moravec |
it take into account all search parameters |
| 08:58 |
|
AndrewIsh |
josef_moravec: Ah, interesting, I've somehow not come across this syntax before, I'll investigate, thanks :) |
| 08:59 |
|
josef_moravec |
or we can leave this update and make it on 22440, it depends how complicated it would be ;) |
| 09:02 |
|
AndrewIsh |
josef_moravec: Just trying to figure out how it works, so it transparently looks at the parameters passed in the URL and if any match the relevant Koha object property names, it applies filters using those parameter values? |
| 09:02 |
|
|
kohaputti_ joined #koha |
| 09:02 |
|
|
cait joined #koha |
| 09:03 |
|
* cait |
waves tiredly |
| 09:04 |
|
* AndrewIsh |
waves at cait energetically whilst simultaneously handing her an extra large coffee |
| 09:04 |
|
* magnuse |
waves energizingly to cait |
| 09:06 |
|
josef_moravec |
AndrewIsh: it uses parameteres defined in openapi specification |
| 09:06 |
|
AndrewIsh |
magnuse: Ah! Nice use of energizingly, wish I'd thought of that, clearly your grasp of English is better than mine! :) |
| 09:06 |
|
cait |
you are the sweetest :) |
| 09:07 |
|
* andreashm |
waves regurarly |
| 09:07 |
|
AndrewIsh |
josef_moravec: Ah, OK, so it's not as arbitrary as I thought, it knows what parameters it's interested in. Nice :) |
| 09:07 |
|
* josef_moravec |
sends cookies and coffee to cait ;) |
| 09:07 |
|
cait |
:) |
| 09:07 |
|
AndrewIsh |
josef_moravec: A chance like that feels a bit out of scope of this bug, adding it to 22400 makes a lot of sense though :) |
| 09:07 |
|
AndrewIsh |
s/chance/change |
| 09:07 |
|
josef_moravec |
AndrewIsh: I agree |
| 09:07 |
|
AndrewIsh |
I'll add it now shall I? |
| 09:08 |
|
magnuse |
AndrewIsh: well i can't force myself to use "wave at", so nah... |
| 09:09 |
|
AndrewIsh |
magnuse: To be honest, I think "waves to" makes more sense than "waves at" |
| 09:10 |
|
josef_moravec |
Andrewish: Leave it to 22440, we will add also to_api and to_model methods there |
| 09:10 |
|
AndrewIsh |
josef_moravec: OK, I'll add a suitable comment to 22440 |
| 09:10 |
|
josef_moravec |
AndrewIsh: thanks |
| 09:14 |
|
josef_moravec |
AndrewIsh: just looking into code of bug 18589, you cant'move all that javascript to ill-list-table.js, if you wan't move it in its own file, use .inc, there are some strings to translate and it is not possible to translate it in this place |
| 09:14 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18589 enhancement, P5 - low, ---, andrew.isherwood, Patch doesn't apply , Show ILLs as part of patron profile |
| 09:15 |
|
AndrewIsh |
So I should define the strings as variables in the main template? |
| 09:15 |
|
josef_moravec |
AndrewIsh: yes, it will work ;) |
| 09:16 |
|
AndrewIsh |
josef_moravec: OK, thanks for the pointer |
| 09:25 |
|
|
dire joined #koha |
| 09:40 |
|
tcohen |
morning |
| 09:42 |
|
andreashm |
hey tcohen |
| 09:42 |
|
cait |
morning tcohen |
| 09:42 |
|
magnuse |
hola tcohen |
| 09:44 |
|
josef_moravec |
hitcoh |
| 09:44 |
|
josef_moravec |
hi tcohen ;) |
| 09:44 |
|
tcohen |
he |
| 10:00 |
|
* kidclamp |
waves |
| 10:00 |
|
tcohen |
isn't it too early, clamps? |
| 10:01 |
|
josef_moravec |
hi kidclamp |
| 10:01 |
|
kidclamp |
this is when I'd like to be up tcohen, but sometimes I am lazy |
| 10:02 |
|
tcohen |
:-D |
| 10:04 |
|
* cait |
waves |
| 10:04 |
|
tcohen |
hi cait |
| 11:03 |
|
AndrewIsh |
josef_moravec: Going back to your earlier comment about not being able to have strings in my .js file. In that file I am using the _() function to expose them as translatable strings. Looking at all the other .js files in koha-tmpl/intranet-tmpl/prog/js , they do the same. Is there something wrong with this approach? |
| 11:04 |
|
tuxayo |
AndrewIsh: _() is fairly new https://wiki.koha-community.or[…]ext,_and_more_RFC |
| 11:05 |
|
josef_moravec |
but bug 21156 is not pushed yet, so should not work here? |
| 11:05 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21156 enhancement, P5 - low, ---, julian.maurice, Patch doesn't apply , Internationalization: plural forms, context, and more for JS files |
| 11:06 |
|
cait |
AndrewIsh: .js files are not picked up by the translation tools |
| 11:06 |
|
cait |
js in .tt works ok |
| 11:06 |
|
AndrewIsh |
Oooh, I'd not appreciated it was so new, and unmerged, I've been advised in the past to use it. OK, fair enough, I'll switch to keeping the strings in the template! :) |
| 11:06 |
|
|
andreash_ joined #koha |
| 11:07 |
|
cait |
_() is the old way, not related to the new feature i think |
| 11:07 |
|
cait |
wow... snow storm outside |
| 11:07 |
|
cait |
if there are other .js using _() there are probably untranslatalbe as well :( |
| 11:07 |
|
AndrewIsh |
I'll have a read of that wiki page and bring myself up to date, thanks all |
| 11:07 |
|
josef_moravec |
AndrewIsh: it is needed to add _() around string in javascript, but this javascript should be in tt file |
| 11:08 |
|
AndrewIsh |
josef_moravec: Ahhh, OK, makes sense, thanks |
| 11:08 |
|
paxed |
afaics, rancor doesn't work with value builder plugins, at all, correct? |
| 11:09 |
|
tuxayo |
cait: _() was already working in the JS? Thanks for noticing the confusion. |
| 11:10 |
|
cait |
specifically in js |
| 11:10 |
|
tuxayo |
AndrewIsh: Indeed! I forgot that this was split and that BZ21156 wasn't yet merged |
| 11:10 |
|
cait |
coding guidelines? |
| 11:10 |
|
cait |
hm |
| 11:11 |
|
cait |
Coding Guidelines is https://wiki.koha-community.or[…]Coding_Guidelines |
| 11:11 |
|
cait |
wahanui? |
| 11:11 |
|
wahanui |
cait? |
| 11:11 |
|
cait |
Coding Guildelines |
| 11:11 |
|
cait |
Coding Guidelines? |
| 11:11 |
|
wahanui |
it has been said that Coding Guidelines is https://wiki.koha-community.or[…]Coding_Guidelines |
| 11:11 |
|
cait |
tuxayo: https://wiki.koha-community.or[…]bedded_JavaScript |
| 11:11 |
|
josef_moravec |
there are 40 strings in js, which are untranslatable |
| 11:12 |
|
tuxayo |
thanks cait, I was searching which was the guideline |
| 11:12 |
|
cait |
josef_moravec: hmpf. |
| 11:12 |
|
cait |
JS5 violation |
| 11:12 |
|
josef_moravec |
i've run simple this: |
| 11:12 |
|
josef_moravec |
git grep "_(" koha-tmpl/intranet-tmpl/prog/js |
| 11:13 |
|
cait |
https://wiki.koha-community.or[…]bedded_JavaScript |
| 11:13 |
|
josef_moravec |
and 17 in opac, all in koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js |
| 11:14 |
|
cait |
josef_moravec: can you file a bug plz? |
| 11:14 |
|
josef_moravec |
cait: sure |
| 11:14 |
|
cait |
josef_moravec++ |
| 11:14 |
|
cait |
everytime i think we finally killed them all they creep back in |
| 11:15 |
|
paxed |
really should put a NB: but see JS5 right under the JS2 title. |
| 11:15 |
|
cait |
NB? |
| 11:16 |
|
paxed |
nota bene |
| 11:16 |
|
cait |
ah |
| 11:16 |
|
cait |
yeah that might be good |
| 11:16 |
|
paxed |
and clarify js5 with "Do not use _() in .js-files" |
| 11:20 |
|
cait |
i've added nots to the guildelines |
| 11:20 |
|
josef_moravec |
bug 22490 |
| 11:20 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22490 major, P5 - low, ---, koha-bugs, NEW , Some strings in javascript files are untranslatable |
| 11:21 |
|
josef_moravec |
it could be probably covered in qa script to |
| 11:36 |
|
cait |
a good idea |
| 11:55 |
|
|
andreashm joined #koha |
| 12:03 |
|
|
kohaputti joined #koha |
| 12:07 |
|
|
oleonard joined #koha |
| 12:07 |
|
oleonard |
Hi #koha |
| 12:07 |
|
cait |
hi oleopard |
| 12:20 |
|
josef_moravec |
hi oleonard |
| 12:20 |
|
wahanui |
hi oleopard |
| 12:24 |
|
oleonard |
Thank you cait and josef_moravec for all your QA work! |
| 12:24 |
|
josef_moravec |
oleonard: not at all ;) |
| 12:29 |
|
magnuse |
@karma josef_moravec |
| 12:29 |
|
huginn` |
magnuse: Karma for "josef_moravec" has been increased 117 times and decreased 0 times for a total karma of 117. |
| 12:29 |
|
magnuse |
cait++ josef_moravec++ |
| 12:29 |
|
magnuse |
@karma josef_moravec |
| 12:29 |
|
huginn` |
magnuse: Karma for "josef_moravec" has been increased 118 times and decreased 0 times for a total karma of 118. |
| 12:29 |
|
oleonard |
josef_moravec++ |
| 12:29 |
|
oleonard |
cait++ |
| 12:29 |
|
magnuse |
sorry, just had to make sure... |
| 12:29 |
|
josef_moravec |
;) |
| 12:29 |
|
magnuse |
@karma cait |
| 12:29 |
|
huginn` |
magnuse: Karma for "cait" has been increased 689 times and decreased 0 times for a total karma of 689. |
| 12:30 |
|
magnuse |
@karma |
| 12:30 |
|
huginn` |
magnuse: Highest karma: "Joubu" (744), "cait" (689), and "oleonard" (396). Lowest karma: "-" (-50), "failed" (-41), and "ie" (-38). You (magnuse) are ranked 14 out of 917. |
| 12:32 |
|
kidclamp |
magnuse++ |
| 12:32 |
|
kidclamp |
josef_moravec++ |
| 12:32 |
|
kidclamp |
cairt++ |
| 12:32 |
|
kidclamp |
oleonard++ |
| 12:33 |
|
kidclamp |
cait++ |
| 12:36 |
|
magnuse |
kidclamp++ |
| 12:36 |
|
kidclamp |
karma party! |
| 12:36 |
|
wahanui |
party! has neutral karma |
| 12:37 |
|
josef_moravec |
party!++ |
| 12:37 |
|
josef_moravec |
karma party! |
| 12:37 |
|
wahanui |
party! has karma of 1 |
| 12:40 |
|
kidclamp |
hah |
| 13:04 |
|
oleonard |
So who's working on something fun today? |
| 13:05 |
|
* oleonard |
is working on resurrecting failed patches, like a sad sad Dr. Frankenstein |
| 13:05 |
|
|
Dyrcona joined #koha |
| 13:06 |
|
cait |
oleonard: staying awakea and not submitting to chaos? |
| 13:06 |
|
cait |
does that count? |
| 13:07 |
|
oleonard |
Some days that's the best we can hope for. |
| 13:09 |
|
huginn` |
News from kohagit: Bug 11375: Compiled CSS <http://git.koha-community.org/[…]5121e7a3af021473c> |
| 13:09 |
|
huginn` |
News from kohagit: Bug 22368: DBRev 18.12.00.024 <http://git.koha-community.org/[…]4cdbacb3d0354da18> |
| 13:09 |
|
huginn` |
News from kohagit: Bug 22368: Make sure the tests will always pass <http://git.koha-community.org/[…]e16220cc6f419022e> |
| 13:09 |
|
huginn` |
News from kohagit: Bug 22368: (QA follow-up) Changed to LEFT JOIN as requested <http://git.koha-community.org/[…]1fbb42d221371a8ee> |
| 13:09 |
|
huginn` |
News from kohagit: Bug 19489: (QA follow-up) Revert changes in printinvoice <http://git.koha-community.org/[…]8ec7f3e6db6e14f57> |
| 13:09 |
|
huginn` |
News from kohagit: Bug 19489: (QA follow-up) Remove passing issue_id in pay form <http://git.koha-community.org/[…]51d93041d8fbc6583> |
| 13:09 |
|
huginn` |
News from kohagit: Bug 19489: (QA follow-up) Update test to use objects and module methods for creating... <http://git.koha-community.org/[…]8574261f7d30b95ac> |
| 13:09 |
|
huginn` |
News from kohagit: Bug 19489: (QA follow-up) Cache checkout object in variable <http://git.koha-community.org/[…]ad9046ebf4b728283> |
| 13:09 |
|
huginn` |
News from kohagit: Bug 11375: (QA follow-up) Remove some more treeview occurences <http://git.koha-community.org/[…]007b2991716174b7d> |
| 13:09 |
|
huginn` |
News from kohagit: Bug 11375: (QA follow-up) Fix typo <http://git.koha-community.org/[…]43bdec78f51f23724> |
| 13:09 |
|
huginn` |
News from kohagit: Bug 22368: (QA follow-up) Switch to using foreign_key_exists <http://git.koha-community.org/[…]0d1db1a6145f88e0a> |
| 13:10 |
|
huginn` |
News from kohagit: Bug 22368: (QA follow-up) Missing comma in kohastructure.sql <http://git.koha-community.org/[…]182e6fd9b520d5ec3> |
| 13:10 |
|
huginn` |
News from kohagit: Bug 22368: (QA follow-up) Mute db errors in test <http://git.koha-community.org/[…]5861469cc82c3cc2f> |
| 13:10 |
|
huginn` |
News from kohagit: Bug 19489: (follow-up) Fix typos in the tests <http://git.koha-community.org/[…]601ed1c097f1e48bd> |
| 13:10 |
|
huginn` |
News from kohagit: Bug 22368: Add tests <http://git.koha-community.org/[…]cd299e37e432b239c> |
| 13:10 |
|
huginn` |
News from kohagit: Bug 22368: Add missing constraints to `suggestions` <http://git.koha-community.org/[…]e59782bb7ef74feba> |
| 13:10 |
|
huginn` |
News from kohagit: Bug 19489: Change method name issue --> checkout <http://git.koha-community.org/[…]c73a36a1ea309de81> |
| 13:10 |
|
huginn` |
News from kohagit: Bug 19489: Detailed Description of charges in Patron accounting <http://git.koha-community.org/[…]b35361760909583ab> |
| 13:10 |
|
huginn` |
News from kohagit: Bug 11375: (follow-up) Add links to show all/hide all <http://git.koha-community.org/[…]6486e580e0f5a5462> |
| 13:10 |
|
huginn` |
News from kohagit: Bug 11375: Improve patrons permissions display <http://git.koha-community.org/[…]b8938a75584df599d> |
| 13:13 |
|
oleonard |
Whaaa.... 11375 pushed? Yay!! |
| 13:15 |
|
oleonard |
Thanks for rebasing that one josef_moravec, it would have been my 57th time. |
| 13:17 |
|
cait |
:) |
| 13:17 |
|
cait |
oleonard++ josef_moravec++ :) |
| 13:17 |
|
cait |
i missed the karma party ealrier |
| 13:18 |
|
cait |
oleonard: i got a little confused because the code for bug 22477 seems to refer the borrower_table |
| 13:18 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22477 normal, P5 - low, ---, oleonard, Signed Off , Missing DataTables configuration when searching patrons for holds |
| 13:18 |
|
cait |
but changing that didn't do anything |
| 13:18 |
|
cait |
columns_settings_borrowers_table = [% ColumnsSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] |
| 13:19 |
|
|
andreash_ joined #koha |
| 13:19 |
|
|
andreash_ joined #koha |
| 13:20 |
|
|
andreash_ joined #koha |
| 13:21 |
|
|
andreash_ joined #koha |
| 13:28 |
|
|
zb joined #koha |
| 13:30 |
|
|
z-b joined #koha |
| 13:40 |
|
magnuse |
oleonard++ for resurrecting failed patches |
| 13:41 |
|
koha-jenkins |
Project Koha_Master_D9 build #679: SUCCESS in 27 min: https://jenkins.koha-community[…]ha_Master_D9/679/ |
| 13:41 |
|
koha-jenkins |
Project Koha_Master_U18 build #172: UNSTABLE in 31 min: https://jenkins.koha-community[…]a_Master_U18/172/ |
| 13:42 |
|
|
Freddy_Enrique joined #koha |
| 13:47 |
|
|
andreashm joined #koha |
| 13:48 |
|
|
andreashm joined #koha |
| 13:49 |
|
koha-jenkins |
Project Koha_Master_D8 build #188: UNSTABLE in 36 min: https://jenkins.koha-community[…]ha_Master_D8/188/ |
| 14:02 |
|
oleonard |
Me deciding which patch to fix: https://www.flickr.com/photos/vinx80x/2378462448 |
| 14:06 |
|
|
wizzyrea joined #koha |
| 14:07 |
|
|
jzairo joined #koha |
| 14:07 |
|
oleonard |
Hi wizzyrea and jzairo |
| 14:07 |
|
jzairo |
morning oleonard |
| 14:08 |
|
wizzyrea |
hi |
| 14:08 |
|
wahanui |
hello, wizzyrea |
| 14:08 |
|
wizzyrea |
cait++ |
| 14:10 |
|
|
talljoy joined #koha |
| 14:10 |
|
|
lukeG joined #koha |
| 14:11 |
|
oleonard |
Good morning to the whole Central time zone |
| 14:13 |
|
eythian |
I'm not far from Central and it's not morning. |
| 14:13 |
|
eythian |
Well, Centraal I guess. Same thing. |
| 14:15 |
|
oleonard |
eythian: Clearly that good morning wasn't for you! |
| 14:15 |
|
eythian |
Good, because as we're approaching evening it'd just be weird |
| 14:21 |
|
wizzyrea |
<3 I've missed your snark eythian |
| 14:23 |
|
eythian |
You must seek it with thimbles, seek it with care. Persue it with forks and hope, and threaten its life with a railway share. |
| 14:24 |
|
wizzyrea |
^.^ |
| 14:43 |
|
|
cait left #koha |
| 14:48 |
|
wizzyrea |
hi cait |
| 14:48 |
|
eythian |
that was way too slow :) |
| 14:49 |
|
wizzyrea |
hehe yes |
| 14:49 |
|
wizzyrea |
reading fail lol |
| 15:31 |
|
|
reiveune left #koha |
| 15:40 |
|
|
remy_prebs joined #koha |
| 16:45 |
|
|
laurence left #koha |
| 17:00 |
|
|
ecs joined #koha |
| 17:36 |
|
|
lukeG1 joined #koha |
| 17:42 |
|
|
koha-jenkins joined #koha |
| 17:55 |
|
|
fridolin left #koha |
| 18:08 |
|
wizzyrea |
so koha-testing-docker |
| 18:08 |
|
wizzyrea |
I can get everything to work but elasticsearch (which of course is the only reason I want to do docker) |
| 18:09 |
|
* oleonard |
looks very interested in his notes so he doesn't get called on |
| 18:09 |
|
wizzyrea |
:) |
| 18:14 |
|
oleonard |
Perhaps tcohen can help? |
| 18:15 |
|
tcohen |
hi |
| 18:15 |
|
tcohen |
wizzyrea: you use Linux, right? |
| 18:15 |
|
tcohen |
did you follow https://gitlab.com/koha-commun[…]elasticsearch-run |
| 18:27 |
|
wizzyrea |
hmm |
| 18:27 |
|
* wizzyrea |
tries all the things |
| 18:29 |
|
wizzyrea |
oh good call tcohen I didn't get all the way to the bottom >.< now I feel dumb thank you |
| 18:31 |
|
* wizzyrea |
tries again |
| 18:31 |
|
tcohen |
hey, it took me a while to figure |
| 18:31 |
|
wizzyrea |
tcohen++ so far so good :) |
| 18:32 |
|
oleonard |
Is this git hook example still valid? https://wiki.koha-community.or[…]i/Tips_and_tricks |
| 18:33 |
|
oleonard |
It isn't working for me in kohadevbox. |
| 18:37 |
|
* oleonard |
was interested in adding a pre-commit hook to stop him from accidentally including staff-global.css |
| 18:39 |
|
wizzyrea |
that sounds like a good thing to do, I don't see a reason why that wouldn't work, do you get an error? |
| 18:39 |
|
wizzyrea |
is your script file executable? |
| 18:40 |
|
oleonard |
I get warnings about when and given being experimental and it doesn't correctly flag errors |
| 18:43 |
|
wizzyrea |
oh, so it works it just doesn't *work* |
| 18:43 |
|
oleonard |
I couldn't have said it better myself |
| 18:44 |
|
wizzyrea |
hehe half the battle is figuring out what exactly isn't working! |
| 18:45 |
|
|
kathryn joined #koha |
| 18:46 |
|
wizzyrea |
hi kathryn :) |
| 18:48 |
|
wizzyrea |
oleonard, I'm going to guess that a newer perl or git has broken that somehow |
| 19:06 |
|
|
cait joined #koha |
| 19:07 |
|
kathryn |
hi wizzyrea :) |
| 19:13 |
|
oleonard |
Bye all |
| 19:13 |
|
kathryn |
hi and seeya |
| 19:13 |
|
kathryn |
too late |
| 19:16 |
|
wizzyrea |
hehe |
| 19:25 |
|
|
alexbuckley joined #koha |
| 19:28 |
|
wizzyrea |
hi alexbuckley |
| 19:28 |
|
alexbuckley |
hey wizzyrea :) |
| 19:39 |
|
* cait |
waves |
| 19:40 |
|
alexbuckley |
hey cait :) |
| 19:42 |
|
wizzyrea |
hey kidclamp, I think this commit breaks the onboarder: 60c51b9bb07de4dea16b0a883ad1881829fe69ed |
| 19:42 |
|
wizzyrea |
or rather, the onboarder for circ rules needs to be fixed to comply with the new table structures |
| 19:42 |
|
wizzyrea |
or something |
| 19:42 |
|
wahanui |
something is broken |
| 19:42 |
|
wizzyrea |
yes, yes it is. |
| 19:42 |
|
cait |
wizzyrea: it's already filed |
| 19:42 |
|
wizzyrea |
yay |
| 19:43 |
|
kidclamp |
phew |
| 19:43 |
|
cait |
bug 22489 |
| 19:43 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22489 major, P5 - low, ---, hayleymapley, ASSIGNED , Onboarding tool fails due to inserting maxissueqty into IssuingRule |
| 19:43 |
|
cait |
not fixed, but reported - hayley assigned it to herself |
| 19:43 |
|
cait |
i had linked it to the bug this morning |
| 19:43 |
|
cait |
brb, unpacking errands |
| 20:05 |
|
|
josef_moravec joined #koha |
| 20:07 |
|
|
hayleymapley joined #koha |
| 21:05 |
|
|
andreashm joined #koha |
| 21:53 |
|
|
lukeG joined #koha |
| 22:09 |
|
|
magnuse joined #koha |
| 22:16 |
|
|
indradg joined #koha |
| 22:25 |
|
|
andreashm joined #koha |
| 22:33 |
|
koha-jenkins |
Project Koha_18.05_D8 build #233: SUCCESS in 22 min: https://jenkins.koha-community[…]oha_18.05_D8/233/ |
| 22:38 |
|
koha-jenkins |
Project Koha_18.05_D9 build #230: SUCCESS in 29 min: https://jenkins.koha-community[…]oha_18.05_D9/230/ |
| 22:53 |
|
koha-jenkins |
Project Koha_18.05_D8 build #234: SUCCESS in 19 min: https://jenkins.koha-community[…]oha_18.05_D8/234/ |
| 22:55 |
|
koha-jenkins |
Project Koha_18.05_U18 build #230: SUCCESS in 43 min: https://jenkins.koha-community[…]ha_18.05_U18/230/ |
| 23:05 |
|
koha-jenkins |
Project Koha_18.05_D9 build #231: SUCCESS in 26 min: https://jenkins.koha-community[…]oha_18.05_D9/231/ |
| 23:26 |
|
|
lukeG1 joined #koha |
| 23:59 |
|
|
papa joined #koha |
