| Time |
S |
Nick |
Message |
| 00:53 |
|
|
caroline1 joined #koha |
| 01:52 |
|
|
andreashm joined #koha |
| 04:51 |
|
|
alexbuckley joined #koha |
| 04:52 |
|
|
lukeg1 joined #koha |
| 05:11 |
|
|
lukeg1 joined #koha |
| 05:23 |
|
|
indradg joined #koha |
| 05:55 |
|
|
josef_moravec joined #koha |
| 06:00 |
|
|
chris1 joined #koha |
| 06:11 |
|
|
krc joined #koha |
| 06:12 |
|
|
krc_ joined #koha |
| 06:34 |
|
|
cait joined #koha |
| 06:48 |
|
|
gveranis joined #koha |
| 07:26 |
|
|
calire joined #koha |
| 07:38 |
|
josef_moravec |
morning #koha |
| 07:41 |
|
calire |
morning josef_moravec |
| 07:41 |
|
josef_moravec |
hi calire |
| 07:42 |
|
magnuse |
\o/ |
| 07:42 |
|
josef_moravec |
hi magnuse |
| 07:43 |
|
magnuse |
hiya josef_moravec |
| 07:43 |
|
calire |
hey magnuse |
| 07:44 |
|
magnuse |
hiya calire |
| 07:49 |
|
gveranis |
hi all ! |
| 07:51 |
|
josef_moravec |
hi gveranis |
| 07:51 |
|
magnuse |
hiya gveranis |
| 07:52 |
|
gveranis |
;) |
| 07:56 |
|
|
reiveune joined #koha |
| 07:56 |
|
|
alex_a joined #koha |
| 07:56 |
|
reiveune |
hello |
| 07:56 |
|
alex_a |
bonjour |
| 07:59 |
|
josef_moravec |
hi reiveune, alex_a |
| 08:00 |
|
reiveune |
salut josef_moravec |
| 08:01 |
|
paxed |
hm. is there a reason for both PrepHostMarcField and prepare_host_field in C4/Biblio.pm? |
| 08:05 |
|
|
AndrewIsh joined #koha |
| 08:14 |
|
|
andreashm joined #koha |
| 08:18 |
|
|
alexbuckley joined #koha |
| 08:19 |
|
|
fridolin joined #koha |
| 08:20 |
|
fridolin |
hi |
| 08:27 |
|
|
sophie_m joined #koha |
| 08:28 |
|
* andreashm |
waves |
| 08:29 |
|
josef_moravec |
hi andreashm |
| 08:32 |
|
andreashm |
hi josef_moravec |
| 08:39 |
|
|
andreash_ joined #koha |
| 08:49 |
|
|
AndrewIsh joined #koha |
| 09:11 |
|
|
andreash_ joined #koha |
| 09:39 |
|
josef_moravec |
AndrewIsh++ |
| 09:39 |
|
josef_moravec |
It's great how are you responsible ;) |
| 09:39 |
|
AndrewIsh |
josef_moravec++ |
| 09:40 |
|
josef_moravec |
https://wiki.koha-community.or[…]ests_endpoint_RFC |
| 09:40 |
|
AndrewIsh |
Well, it's easy to be responsible with such an awesome QA-er :-D |
| 09:40 |
|
josef_moravec |
:-[ |
| 09:41 |
|
AndrewIsh |
Lol, I'm not sure I've ever seen that RFC before, I certainly didn't create it. It seems very arbitrary for us to be randomly renaming object properties |
| 09:42 |
|
josef_moravec |
it's not randomly, it is going to make a consistancy in api, because db tables are not consistant |
| 09:42 |
|
AndrewIsh |
Ah, I understand now, the final column is what you're saying they should be called to be consistent with other routes, gotcha! |
| 09:42 |
|
josef_moravec |
that's it |
| 09:43 |
|
josef_moravec |
look for example to libraries or patrons api for how it shoul look |
| 09:43 |
|
AndrewIsh |
OK, well that makes sense then :) I agree that they should be consistent. I'm wondering if this bug is the place to do that, or whether we'd be better to do it as a separate bug that sits at the top of the QA tree, it would be cleaner and would mean no merge pain further up the QA tree ;-) |
| 09:44 |
|
josef_moravec |
separate bug definitaly |
| 09:44 |
|
AndrewIsh |
OK, cool, I'll create one now and make it depend on 18589 |
| 09:44 |
|
josef_moravec |
ok |
| 09:45 |
|
AndrewIsh |
Thanks for pointing that out, I would never have noticed that :) |
| 09:45 |
|
josef_moravec |
but we need to make the rfc more complete, for example write down endpoint specific parameters |
| 09:45 |
|
josef_moravec |
in fact illrequest is only endpoint which is capable to embed some related data |
| 09:46 |
|
josef_moravec |
so we have to document it and somehow standardize it and then use in more endpoints |
| 09:47 |
|
AndrewIsh |
Right, OK, makes sense. The RFC is also more detailed than it needs to be too, there's currently only a requirement for a GET route, so the specs for the other routes is currently unecessary. Though, that said, we have an imminent requirement for a POST route. |
| 09:48 |
|
josef_moravec |
i really have requirement for updating actions too here! |
| 09:48 |
|
AndrewIsh |
:-) |
| 09:48 |
|
josef_moravec |
we have big plans with ill |
| 09:49 |
|
josef_moravec |
connection national ill system |
| 09:50 |
|
josef_moravec |
implementation of ILS to ILS direct ILL in VuFind using its ILS driver capabilities... there are endless possibilities :D |
| 09:50 |
|
josef_moravec |
But yes, we shold first document what we have, update the specs for consistancy, fix the code and then work on update actions |
| 09:51 |
|
AndrewIsh |
Yes, well our requirement is to create ILL requests on remote Koha systems using the Koha2Koha backend, currently all it does is create a hold on the remote system |
| 09:51 |
|
josef_moravec |
It will be great enhancement! |
| 09:52 |
|
AndrewIsh |
Hopefully! :) |
| 09:53 |
|
magnuse |
josef_moravec++ AndrewIsh++ |
| 09:58 |
|
magnuse |
parts of the swedish/Libris ill backend is being tested in production as we speak :-) |
| 10:00 |
|
AndrewIsh |
Fantastic :) |
| 10:00 |
|
AndrewIsh |
magnuse++ |
| 10:06 |
|
andreashm |
magnuse++ |
| 10:21 |
|
josef_moravec |
magnuse++ |
| 10:31 |
|
|
kohaputti joined #koha |
| 10:34 |
|
|
paul_p joined #koha |
| 10:43 |
|
AndrewIsh |
josef_moravec: Agree with your last comment, that seems most sensible. Thanks for that, I'll get on it shortly :) |
| 10:43 |
|
josef_moravec |
AndrewIsh: great, thanks! |
| 10:54 |
|
|
kohaputti joined #koha |
| 11:29 |
|
|
Dyrcona joined #koha |
| 11:34 |
|
|
Whipsaw joined #koha |
| 12:09 |
|
koha-jenkins |
Project Koha_18.11_D9 build #43: UNSTABLE in 25 min: https://jenkins.koha-community[…]Koha_18.11_D9/43/ |
| 12:15 |
|
|
kohaputti_ joined #koha |
| 12:17 |
|
koha-jenkins |
Project Koha_18.11_U18 build #41: UNSTABLE in 31 min: https://jenkins.koha-community[…]oha_18.11_U18/41/ |
| 12:20 |
|
koha-jenkins |
Project Koha_18.11_D8 build #43: UNSTABLE in 35 min: https://jenkins.koha-community[…]Koha_18.11_D8/43/ |
| 12:34 |
|
|
oleonard joined #koha |
| 12:35 |
|
oleonard |
Hi all |
| 12:36 |
|
calire |
hi oleonard |
| 12:36 |
|
wahanui |
hi oleopard |
| 12:45 |
|
|
alex_a joined #koha |
| 13:34 |
|
|
alex_a_ joined #koha |
| 13:47 |
|
|
Freddy_Enrique joined #koha |
| 14:01 |
|
|
corilynn joined #koha |
| 14:04 |
|
|
lukeg1 joined #koha |
| 14:22 |
|
|
talljoy joined #koha |
| 14:25 |
|
ashimema |
davidnind++ you've just perfectly filled one of the slots I was looking for someone to run a workshop on for KohaCon :) |
| 14:25 |
|
ashimema |
`Documentation Workshop` :) |
| 14:29 |
|
|
alex_a joined #koha |
| 14:36 |
|
|
calire left #koha |
| 14:47 |
|
|
wizzyrea joined #koha |
| 14:48 |
|
wizzyrea |
hi peeps |
| 14:48 |
|
wizzyrea |
ashimema about? |
| 14:48 |
|
oleonard |
Hi wizzyrea |
| 14:50 |
|
wizzyrea |
@later tell ashimema no permissions have changed that I am aware of |
| 14:50 |
|
huginn` |
wizzyrea: The operation succeeded. |
| 14:54 |
|
ashimema |
hi |
| 14:54 |
|
wahanui |
hey, ashimema |
| 14:54 |
|
ashimema |
interesting |
| 14:55 |
|
ashimema |
both I and Lucas had some fun with publishing the release this time around |
| 14:56 |
|
ashimema |
yeah.. in previous releases I'd been categorising as 'version, Koha News, release` |
| 14:56 |
|
ashimema |
this time I couldn't use `Koha News` else it failed to publish wizzyrea |
| 14:57 |
|
ashimema |
ooh.. interesting.. fridolin uses 'Announcements` instead of `Koha News` |
| 14:58 |
|
ashimema |
ah.. but it would seem I can't use 'Announcements' either.. I just get 'Updateing failed' in a red bar at the top |
| 15:01 |
|
fridolin |
ah i also add issues with WP |
| 15:01 |
|
fridolin |
purely random |
| 15:01 |
|
fridolin |
https://wiki.koha-community.or[…]he_community_site |
| 15:01 |
|
fridolin |
it says release, <your branch> and Announcements. |
| 15:02 |
|
fridolin |
:) |
| 15:02 |
|
ashimema |
lol |
| 15:02 |
|
ashimema |
my bad.. I've always used 'Koha News'.. I can't have read that properly the first time |
| 15:02 |
|
wizzyrea |
or it changed |
| 15:03 |
|
ashimema |
doesn't look like it's changed in ages.. oops |
| 15:03 |
|
ashimema |
I think i just copied what the previous person was doing |
| 15:03 |
|
|
jmsantos joined #koha |
| 15:03 |
|
ashimema |
either way.. WP seems to be doing things a little differently.. no worries we managed |
| 15:04 |
|
* ashimema |
does get slightly confused every time that there's `release` and `releases` categories |
| 15:12 |
|
|
lukeG joined #koha |
| 15:14 |
|
|
tallerjoy joined #koha |
| 15:15 |
|
fridolin |
wizzyrea: ashimema just something strange is thant "17.11" is not a child of "releases" |
| 15:17 |
|
fridolin |
wahanui: am i online ? |
| 15:17 |
|
wahanui |
fridolin: i haven't a clue |
| 15:17 |
|
fridolin |
wizzyrea: ashimema just something strange is thant "17.11" is not a child of "releases" |
| 15:17 |
|
wahanui |
i already had it that way, fridolin. |
| 15:26 |
|
ashimema |
yeah, I noticed that.. tried to fix it actually a couple of releases back was discovered I wasn't alowed to play in the categories area.. haha |
| 15:27 |
|
ashimema |
then I promptly forgot to find someone to haras about it ;) |
| 15:27 |
|
* ashimema |
sends hugs to the relevant parties |
| 15:28 |
|
wizzyrea |
i can have a look at that |
| 15:29 |
|
ashimema |
thankyou :) |
| 15:35 |
|
|
alex_a_ joined #koha |
| 15:37 |
|
reiveune |
bye |
| 15:37 |
|
|
reiveune left #koha |
| 15:41 |
|
wizzyrea |
ashimema - there's something funny about that particular category |
| 15:41 |
|
wizzyrea |
but it's ok I'll fix it |
| 15:48 |
|
ashimema |
sorry wizzyrea.. didn't mean to cause you more work |
| 15:48 |
|
ashimema |
but thanks :) |
| 15:55 |
|
jmsantos |
Hi, I'm trying to get the ILL module working and I'm running into some trouble with the API |
| 15:56 |
|
jmsantos |
Namely, when requests are made with parameters, they fail due to pattern->default->{openapi.op_spec} being undefined |
| 15:57 |
|
jmsantos |
Am I missing something ? |
| 15:57 |
|
ashimema |
AndrewIsh: ^ ever seen that |
| 15:58 |
|
AndrewIsh |
No, I never have, that's a weird one. What version of Koha? |
| 15:59 |
|
jmsantos |
18.05.03 |
| 16:00 |
|
AndrewIsh |
jmsantos: Fascinating, I've not come across this before. I'll have a quick dig and see if I can see what might be causing it |
| 16:02 |
|
jmsantos |
Thanks ! If it helps, I've checked what "default" is at that point and what is defined is this : controller, openapi.parameters, action and openapi.path |
| 16:02 |
|
AndrewIsh |
jmsantos: Thanks :) |
| 16:02 |
|
jmsantos |
in the authenticate_api_request subroutine in Auth.pm |
| 16:03 |
|
AndrewIsh |
jmsantos: Indeed, I'm just looking there now |
| 16:08 |
|
AndrewIsh |
jmsantos: Do you have the file "api/v1/swagger/paths/illrequests.json"? If so, can you check the permissions on it? |
| 16:10 |
|
jmsantos |
The file is there, permissions are 664 |
| 16:11 |
|
AndrewIsh |
jmsantos: OK, thanks for checking |
| 16:14 |
|
ashimema |
thanks for picking this up AndrewIss |
| 16:16 |
|
|
caroline1 joined #koha |
| 16:16 |
|
jmsantos |
Yes thanks a lot, I'm kind of new to all this and I'm not sure what is normal and what is not ! |
| 16:16 |
|
AndrewIsh |
jmsantos: So if you make a request without parameters, e.g. GET /api/v1/illrequests - it works? |
| 16:17 |
|
jmsantos |
Yes, it does |
| 16:17 |
|
* caroline1 |
waves |
| 16:17 |
|
AndrewIsh |
jmsantos: That's super weird, bare with me, doing some more digging |
| 16:17 |
|
* AndrewIsh |
waves at caroline1 |
| 16:18 |
|
jmsantos |
It also works if I comment the three lines in the validate_query_parameters subroutine where the "Malformed query string" errors are generated |
| 16:19 |
|
jmsantos |
which is kind of expected since no valid parameters are defined |
| 16:20 |
|
AndrewIsh |
jmsantos: Interesting. Can you go to the "About Koha" page and tell me what versions of Mojolicious and Mojolicious::Plugin::OpenAPI you have |
| 16:21 |
|
caroline1 |
where in the db is it stored when a user has "superlibrarian" access? |
| 16:21 |
|
caroline1 |
trying to make a list of all users who are "superlibrarian" |
| 16:22 |
|
caroline1 |
but it's not in user_permissions |
| 16:22 |
|
jmsantos |
AndrewIsh: of course, Mojolicious is at version 8.02 and the OpenAPI is 2.00 |
| 16:22 |
|
oleonard |
caroline1: Did you check the SQL library for a report for that? |
| 16:23 |
|
AndrewIsh |
jmsantos: That could be it, I'm not sure what the required versions for 18.05 are, but for 18.11 I'm on 7.21 and 1.15, which is substantially differnt |
| 16:24 |
|
AndrewIsh |
I'll just try and find out what versions 18.05 requires |
| 16:24 |
|
caroline1 |
oleonard: heading there now |
| 16:27 |
|
AndrewIsh |
jmsantos: Same, Mojolicious 7.21 and Mojolicious::Plugin::OpenAPI 1.15, though those are minimum versions, so I can see why it's installed what are presumably the latest, but it's conceivable they contain breaking changes |
| 16:27 |
|
AndrewIsh |
jmsantos: Oh, and JSON::Validator 0.97 |
| 16:28 |
|
AndrewIsh |
jmsantos: I'd suggest switching to those versions and seeing if that fixes it, if it's not that, I'm baffled! |
| 16:28 |
|
caroline1 |
There it is (colleagues currently trying to explain it to me) https://wiki.koha-community.or[…]s#Superlibrarians |
| 16:28 |
|
ashimema |
with Mojo and OpenAPI it makes a big difference what versions you're running |
| 16:28 |
|
ashimema |
super fast developing code |
| 16:29 |
|
jmsantos |
AndrewIsh: Alright I'll have a look at those three ! Thank you very much ! |
| 16:29 |
|
AndrewIsh |
jmsantos: No problem, I hope it works! |
| 16:29 |
|
jmsantos |
Me too ;) |
| 16:45 |
|
ashimema |
Joubu around yet? |
| 16:52 |
|
* ashimema |
just spent ages trying to work out what he'd messed up in his branch |
| 16:52 |
|
ashimema |
turns out.. it's not me.. it's a bad test which fails due to leap year issues! |
| 17:02 |
|
wizzyrea |
ashimema, I think the wp thing is fixed |
| 17:03 |
|
ashimema |
awesome, thankyou :) |
| 17:22 |
|
|
fridolin left #koha |
| 17:23 |
|
indradg |
I have a question, is this still relevant? -> https://wiki.koha-community.or[…]ing_and_Shrinking w.r.t l10n |
| 17:23 |
|
wizzyrea |
hm anybody else have a ssl problem with the devbox and bugzilla? |
| 17:24 |
|
wizzyrea |
ssl.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:661) |
| 17:24 |
|
wizzyrea |
it could be just me |
| 17:25 |
|
koha-jenkins |
Project Koha_Master_D8 build #173: UNSTABLE in 35 min: https://jenkins.koha-community[…]ha_Master_D8/173/ |
| 17:52 |
|
wizzyrea |
never mind! for the log, if you are on a laptop and you suspend it a lot, the date on your devbox goes dumb and messes with the certs |
| 17:52 |
|
wizzyrea |
tcohen++ |
| 17:52 |
|
wizzyrea |
a vagrant reload will fix it |
| 17:54 |
|
oleonard |
have a great weekend #koha |
| 20:08 |
|
|
lukeg1 joined #koha |
| 20:19 |
|
ashimema |
kidclamp don't cry about the current failure.. it's another leap year issue |
| 20:19 |
|
ashimema |
Had me well and truly confused this afternoon |
| 20:19 |
|
ashimema |
It'll fix itself tomorrow but I also intend to do another patch for the test file along the same lines as the one I did for Patrons.t |
| 20:20 |
|
ashimema |
Surprised we didn't get hit by this same one last time actually... It's a very similar test case |
| 20:24 |
|
* kidclamp |
just cries because it's his party |
| 20:30 |
|
ashimema |
. . . |
| 20:30 |
|
wizzyrea |
teehee |
| 20:32 |
|
talljoy |
hows that party planning going kidclamp? |
| 20:33 |
|
kidclamp |
Wife usually does this, sausage making ain't pretty |
| 20:35 |
|
magnuse |
wizzyrea! |
| 20:35 |
|
wahanui |
wizzyrea is very glad the git repo is reliably working todya |
| 20:41 |
|
wizzyrea |
hi magnuse |
| 20:41 |
|
* wizzyrea |
perks up for sausage making |
| 20:51 |
|
* magnuse |
too |
| 20:55 |
|
talljoy |
i like sausage. |
| 20:57 |
|
wizzyrea |
*wink wink* |
| 20:57 |
|
wizzyrea |
*nudge nudge* |
| 20:57 |
|
wizzyrea |
I KID |
| 20:57 |
|
talljoy |
hahahah |
| 20:57 |
|
talljoy |
i saw it as soon as i wrote it |
| 20:58 |
|
wizzyrea |
^.^ |
| 20:58 |
|
talljoy |
can't take it back in IRC like you can in slack! |
| 20:58 |
|
wizzyrea |
>.> |
| 20:58 |
|
wizzyrea |
<.< |
| 21:08 |
|
magnuse |
just ask rangi to delete it from the log ;-) |
| 21:19 |
|
ashimema |
Lol |
| 21:24 |
|
talljoy |
off to pick up the purser from the airport. have a good weekend #koha |
| 22:51 |
|
|
HOLA joined #koha |
| 23:01 |
|
|
indradg_ joined #koha |
