IRC log for #koha, 2018-10-25

All times shown according to UTC.

Time S Nick Message
00:00 mtompset oh... a pita-like wrap thing... okay.
00:00 mtompset Those are pretty good.
00:00 dcook Nah not a pita. More like a Mexican wrap.
00:00 dcook But it was grilled. Mmm.
00:00 mtompset soft tortilla.
00:00 dcook Yeah soft tortilla
00:00 dcook That's the term heh
00:01 mtompset Still... I get the idea.
00:01 dcook @later tell joubu sorry for all the words on Bugzilla. I'm happy to discuss background job processing as much as you'd like.
00:01 huginn dcook: The operation succeeded.
00:03 mtompset https://www.timhortons.com/ca/[…]eakfast-wraps.php
00:03 mtompset BTw, I really like Timmies move to 24/7 breakfast. :)
00:08 dcook Yum. I'm a 24/7 breakfast fan as well.
00:38 irma_ joined #koha
01:00 * mtompset frowns, "I hate failing QA things."
01:17 mtompset Well, lost steam. But got some sign offs done, so today was good.
01:18 mtompset @seen marcelr
01:18 huginn mtompset: marcelr was last seen in #koha 6 days, 11 hours, 19 minutes, and 39 seconds ago: <marcelr> np ashimema
01:19 mtompset @later tell marcelr Almost hit #1 for October. Hope those sign offs are good enough. :)
01:19 huginn mtompset: The operation succeeded.
01:19 mtompset Have a great day (24 hour period), #koha dcook
01:33 NewYorkMood joined #koha
02:40 irma_ joined #koha
04:35 cait joined #koha
04:37 cait good morning #koha
04:40 cait1 joined #koha
05:35 cait1 left #koha
05:44 calire joined #koha
05:44 calire morning #koha
05:45 josef_moravec joined #koha
05:53 * dcook waves to the humans
05:54 calire hi dcook
05:56 josef_moravec hi dcook
05:56 josef_moravec hi calire
05:56 dcook hey calire and josef_moravec ^_^
05:56 dcook You're too early >_>
05:56 calire hi josef_moravec
05:56 * dcook wonders how the days pass so quickly
05:56 calire it's nearly 8 ;)
05:57 m23 joined #koha
05:57 josef_moravec dcook: again at work to the evening?
05:58 laurence joined #koha
06:08 cait joined #koha
06:16 cait left #koha
06:19 magnuse \o/
06:21 alexbuckley_ joined #koha
06:28 josef_moravec hi magnuse
06:32 kohaputti joined #koha
06:41 reiveune joined #koha
06:41 reiveune hello
06:42 AndrewIsh joined #koha
06:43 dcook I work until 6 so still my work day :)
06:46 alex_a joined #koha
06:47 alex_a bonjour
06:49 kohaputti_ joined #koha
07:00 marcelr joined #koha
07:00 marcelr hi #koha
07:01 dcook hey marcelr
07:01 marcelr hi dcook
07:01 dcook josef_moravec: And now I'm working into the evening heh
07:01 dcook Even though I kind of want to go buy craft beer... or get a haircut...
07:01 marcelr mtompset++
07:01 * dcook remembers the one time he got a haircut and was served beer by the barber. Best haircut ever.
07:03 laurence joined #koha
07:03 josef_moravec dcook: ;)
07:04 Archie^ joined #koha
07:04 Archie^ Hi all
07:33 ere joined #koha
07:33 andreashm joined #koha
07:37 * andreashm waves
07:41 * dcook waves
07:41 dcook I always know that I've stayed way too long if andreashm gets here and I'm still here ;)
07:45 clrh §3
07:45 clrh oups hello =D
07:46 josef_moravec ;)
07:46 josef_moravec hi clrh
08:22 andreashm joined #koha
08:22 * andreashm waves again
08:22 andreashm dcook: haha!
08:25 ashimema mornin' #koha
08:25 ashimema dcook still here.. agian
08:25 josef_moravec hi ashimema, andreashm
08:26 ashimema hi josef :)
08:26 Archie^ so does koha has a separate table for all marc21 mapings?
08:26 andreashm hi ashimema josef_moravec
09:13 dcook joined #koha
09:35 marcelr joined #koha
09:36 marcelr thx josef_moravec
09:36 josef_moravec marcelr: not at all ;)
09:36 marcelr maybe i should just rename it now
10:10 kidclamp back
10:10 marcelr wb kidclamp confetti
10:11 calire left #koha
10:48 calire joined #koha
11:12 Joubu Hi #koha, marcelr
11:12 Joubu marcelr: for once, I am here at the same time as you! :) What's your feelings about bug 21610?
11:12 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21610 major, P5 - low, ---, jonathan.druart, In Discussion , Koha::Object->store needs to handle incorrect values
11:13 marcelr hi Joubu please look at 21337
11:13 marcelr Joubu: i think we need to continue there perhaps with the strict flag
11:14 Joubu so globally you think it's a good move?
11:14 marcelr yeah we have to
11:14 marcelr we cannot let Koha explode everywhere
11:15 marcelr but I understand the theoretical complaints
11:17 Joubu haha yes, "theoretical"
11:18 marcelr your strict flag might satisfy these
11:19 marcelr Joubu: did you mean the nested transaction stuff on Patrons->delete or did you have somehting else in mind?
11:19 marcelr bug 21337
11:19 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21337 enhancement, P5 - low, ---, m.de.rooy, RESOLVED FIXED, Add Koha::Patrons->delete (trivial wrapper)
11:21 Joubu yes, I think I got what I meant, I was not precise enough
11:22 marcelr can we live with that difference? it is in a few more places too..
11:27 Joubu I let a comment, hope it clarifies what I meant
11:28 marcelr i will be studying this for the rest of the day :)
11:28 marcelr feels like a new report..
11:32 oleonard joined #koha
11:32 oleonard Hi all
11:36 magnuse hi oleonard
11:36 wahanui hi oleopard
11:40 calire hi oleonard
11:40 wahanui hi oleopard
12:02 eythian hi oleopard
12:03 oleonard Hi eythian, what are you working on these days?
12:04 Joubu @later tell dcook about 17600 I let you checking out the branch locally to investigate if you want. No need to work with an up-to-date branch.
12:04 huginn Joubu: The operation succeeded.
12:04 marcelr hi eythian oleonard
12:04 eythian right now, doing back-end dev on infrastructure stuff at booking.com
12:06 * oleonard "accidentally" books himself a hiking trip in Bavaria
12:07 eythian gotta do what you gotta do :)
12:20 kmlussier joined #koha
12:22 magnuse oleonard: if you booked it at booking.com, maybe eythian can undo it for you?
12:22 eythian why would you cancel something like that?
12:22 oleonard See magnuse: It's impossible.
12:22 eythian https://nltimes.nl/2018/10/25/[…]ading-netherlands <-- gee thanks magnuse
12:24 oleonard eythian: Maybe it was Sweden
12:24 magnuse yeah, it's always the swedes!
12:25 magnuse first day of -1C here this morning
12:25 magnuse @wunder bodo, norway
12:25 huginn magnuse: Bodo, Norway :: Clear :: 36F/2C | Wind Chill: 26F/-3C | Thursday: Lots of sunshine. Temps nearly steady in the mid 30s. Winds ESE at 10 to 20 mph. Thursday Night: A clear sky. Widespread frost likely. Low 28F. Winds ESE at 10 to 15 mph.
12:25 oleonard @wunder 45701
12:25 huginn oleonard: Athens, OH :: Clear :: 30F/-1C | Thursday: A mix of clouds and sun during the morning will give way to cloudy skies this afternoon. High 53F. Winds light and variable. Thursday Night: Cloudy skies. Slight chance of a rain shower. Low 38F. Winds light and variable.
12:25 magnuse lots_of_sunshine++
12:25 magnuse feels like we had rain and heavy clouds since forever
12:26 caroline joined #koha
12:26 oleonard @wunder caroline's house
12:26 huginn oleonard: Error: I could not find a valid location for: caroline's house
12:27 oleonard Sneaky
12:27 oleonard caroline is off the grid
12:27 caroline hi #koha!
12:28 kidclamp @winder 05001
12:28 huginn kidclamp: downloading the Perl source
12:28 kidclamp @wunder 05001
12:28 huginn kidclamp: White River Junction, VT :: Overcast :: 37F/3C | Wind Chill: 31F/-1C | Thursday: Partly cloudy. High 42F. Winds NW at 10 to 15 mph. Thursday Night: Partly cloudy skies. Low near 30F. Winds light and variable.
12:28 calire that's a nice name
12:31 eythian @wunder amsterdam
12:31 huginn eythian: Amsterdam, Netherlands :: Overcast :: 55F/13C | Thursday: Generally cloudy. High 58F. Winds WNW at 10 to 15 mph. Thursday Night: Overcast with rain showers at times. Low 51F. Winds WSW at 5 to 10 mph. Chance of rain 60%.
12:31 eythian positively tropical here
12:31 eythian (for now)
12:33 mtompset joined #koha
12:35 tcohen morning
12:36 oleonard Hi tcohen and mtompset
12:38 huginn News from kohagit: Bug 15486: Fix failing test in GetHardDueDate.t <http://git.koha-community.org/[…]d21c4d3813eab9754>
12:38 huginn News from kohagit: Bug 15766: Update tests <http://git.koha-community.org/[…]fc1275a8c6eed9122>
12:38 huginn News from kohagit: Bug 21596: Handle updated_on <http://git.koha-community.org/[…]c8072895fa360eaa4>
12:40 tcohen thanks for the folow-wup, Joubu
12:40 Dyrcona joined #koha
12:42 mtompset Greetings, #koha tcohen oleonard
12:46 mtompset @seen AndrewIsh
12:46 huginn mtompset: AndrewIsh was last seen in #koha 1 week, 5 days, 22 hours, 16 minutes, and 56 seconds ago: <AndrewIsh> josef_moravec++
12:46 mtompset @seen alex_buckley
12:46 huginn mtompset: I have not seen alex_buckley.
12:46 mtompset @seen alexbuckley
12:46 huginn mtompset: alexbuckley was last seen in #koha 1 day, 11 hours, 32 minutes, and 52 seconds ago: <alexbuckley> hi kathryn :)
12:47 oleonard Wrong time of day for alexbuckley, mtompset
12:48 ashimema someone want AndrewIsh
12:48 ashimema I can grab him
12:50 * mtompset nods, "I figured, oleonard."
12:50 mtompset No worries, ashimema. I just commented on but 21641, changing it to in discussion.
12:50 mtompset bug 21641
12:50 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21641 major, P5 - low, ---, alexbuckley, In Discussion , Software error when checking out an item with a charge associated with it
12:50 ashimema think he just went to lunch
12:51 mtompset He'll probably notice an email when he gets back.
12:52 AndrewIsh \o/
12:54 AndrewIsh mtompset:  Interesting question. A bit above my head though I'm afraid, possibly more for alexbuckley to answer?
12:54 Joubu mtompset: 21641 should deal with the missing calls, nothing else
12:56 mtompset Joubu, but wouldn't you agree that a refactor/move might be in order?
12:56 AnnaBoten joined #koha
12:57 Joubu Are you asking me if ugly code from C4 must be moved to Koha?
12:57 mtompset No, I'm asking if the functionality of getnextacctno should be moved to something refactored and nice in Koha.
12:57 mtompset Not just cut-and-paste move. YUCK!
12:58 mtompset Because it really seems to be more of an internal function necessary for saving a new line.
13:00 Joubu by "moved" I meant "rewritten" ofc
13:01 Joubu I guess it will be done with bug 14825
13:01 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=14825 enhancement, P5 - low, ---, kyle.m.hall, NEW , Accounts Rewrite Omnibus
13:01 mtompset Good point.
13:01 mtompset Adding that as a see also. ;)
13:02 mtompset Greetings, AndrewIsh.
13:03 mtompset Sorry, but I failed qa'd it. :(
13:03 AndrewIsh Good day mtompset
13:03 jzairo joined #koha
13:04 AndrewIsh mtompset:  No worries. I'll take a look, though I suspect alexbuckley will want to address your feedback since it's his bug. I was just trying to sign it off for him :)
13:04 mtompset True, but your patch has the same problem. ;)
13:05 AndrewIsh Well, that's true :)
13:12 mtompset @seen marcelr
13:12 huginn mtompset: marcelr was last seen in #koha 1 hour, 7 minutes, and 35 seconds ago: <marcelr> hi eythian oleonard
13:12 * mtompset smiles.
13:19 AndrewIsh mtompset:  Fixed. (I think) :)
13:20 mtompset Eyeballs much better now. Thanks.
13:21 mtompset I'll let alex sign it off. :)
13:22 AnnaBoten joined #koha
13:22 Freddy_Enrique joined #koha
13:22 mtompset oleonard, just curious what the class="validated" stuff did, since you removed it in bug 20689. Just tested the new and edit stuffs, and it works as expected. :)
13:22 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=20689 enhancement, P5 - low, ---, katrin.fischer, Signed Off , Make it possible to add capital letter subfields to item search fields
13:23 AndrewIsh Thanks mtompset
13:23 oleonard mtompset: If a form has the "validated" class, the validation script looks for attributes in the form which act as validation rules. "required=required"
13:24 oleonard If it doesn't have that class one must define a specific validation definition for the form if you want it checked.
13:24 mtompset P.S. QA people -- I see an ugly "ARRAY(hex number)" in the drop downs on master when I tested bug 20689, so this might be nice to get into 18.11 ;)
13:26 caroline joined #koha
13:26 Joubu kidclamp: AAaaaannnnndddd! new patch attached to bug 21596, keep your fingers crossed! :)
13:26 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21596 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Handle default values when storing Koha::Patron
13:28 mtompset And now I'll be waiting for 18.11.01. ;)
13:29 mtompset ashimema, what WAS the TT syntax error in bug 21656?
13:29 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21656 critical, P5 - low, ---, martin.renvoize, Needs Signoff , Syntax Error in Stock Rotation Default Notice Template
13:29 mtompset It's hard to "just see" the change. It looks like a space difference at the end.
13:30 oleonard mtompset: What do you mean about "ARRAY(hex number)" ? Where?
13:30 Joubu mtompset: "ne" vs "!="
13:32 mtompset cgi-bin/koha/admin/items_search_fields.pl
13:33 mtompset when I tried running it on master first.
13:34 oleonard which dropdown?
13:34 mtompset click "New"... and you get ARRAY in the MARC subfield.
13:35 mtompset Thanks, Joubu.
13:35 oleonard Thanks mtompset I see it now
13:35 oleonard Bug 21663
13:35 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21663 major, P5 - low, ---, oleonard, Needs Signoff , Incorrect filter prevents predefined notes from being added to patron acccounts
13:36 AndrewIsh Joubu:  Your message yesterday asking me to update my qa-test-tools repo. It's update to date, what was the issue?
13:37 AndrewIsh s/update/up/
13:37 Joubu Did I ask you that? :)
13:37 Joubu what was the context?
13:38 AndrewIsh I don't know, I got this from huginn: "Sent 13 hours and 26 minutes ago: <Joubu> please read https://wiki.koha-community.or[…]messages#Examples and update your qa-test-tools repo"
13:43 alex_a joined #koha
13:44 Joubu AndrewIsh: no idea when I sent that :-/ I guess it was "Bug 12345 - " vs "Bug 12345: "
13:44 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=12345 enhancement, P5 - low, ---, oleonard, NEW , Can't Clear Reading History for Anonymous patron
13:45 AndrewIsh Arghh, am I still doing that?! You mentioned it once before, I thought I'd fixed myself!
13:45 AndrewIsh Joubu:  ^^
13:45 oleonard qa-test-tools++
13:46 alex_a joined #koha
13:48 AnnaBoten joined #koha
13:48 alex_a_ joined #koha
13:49 matts joined #koha
13:50 Archie^ Hey guys, does koha has a separate table for all marc21 mapings?
13:52 AndrewIsh Joubu:  Just trying to sign off bug 21603
13:52 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21603 major, P5 - low, ---, jonathan.druart, Needs Signoff , Incorrect GROUP BY clause in SearchCourses
13:53 AndrewIsh Joubu:  the test plan says "Prove that the test fail without this patch" which test? Proving t/db_dependent/CourseReserves.t passes
13:53 Joubu AndrewIsh: strict_sql_modes?
13:53 AndrewIsh Joubu:  Arghhh, I just spotted that! Sorry
13:53 Joubu or apply 21613
13:53 Joubu bug 21613
13:53 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21613 normal, P5 - low, ---, jonathan.druart, Signed Off , Turn strict SQL modes on for tests
13:54 AndrewIsh Aha, thanks
13:57 oleonard Anyone else used this before? I'm finding it very useful for looking at diffs. https://github.com/git/git/tre[…]ib/diff-highlight
13:58 ashimema new one on me
13:58 ashimema looks interesting
14:01 oleonard mtompset: I bring this up in part because it makes it much easier to diff bugs like Bug 21656
14:01 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21656 critical, P5 - low, ---, martin.renvoize, Needs Signoff , Syntax Error in Stock Rotation Default Notice Template
14:01 AndrewIsh Sorry Joubu - with 21613 applied, and <strict_sql_modes>1</strict_sql_modes> in the config, prove t/db_dependent/CourseReserves.t still passes without the patch in 21603. I'm clearly being dim somehow, I'm just not sure how ;-)
14:03 tcohen AndrewIsh: did you restart memcached?
14:04 AndrewIsh Joubu:  I'm not running it, or plack for that matter
14:05 Joubu AndrewIsh: ha yes. It should have been split actually.
14:05 Joubu The test adds a new test which fails without the GROUP BY change
14:05 Joubu but both are in the same patch
14:06 Joubu AndrewIsh: so the test plan is: 1. Manually add the test to CourseReserves.t, prove it fails, 2. git reset --hard origin/master, 3. apply the patch, prove the test passes
14:07 matts joined #koha
14:07 AnnaBoten joined #koha
14:07 AndrewIsh Joubu:  Riiiiiiight, I'm completely misunderstood. I'll try again, thanks!
14:07 Joubu my bad, I should have provided 2 patches
14:07 AndrewIsh Joubu:  No worries :)
14:20 Freddy_Enrique Greetings Koha hackers :3
14:20 Freddy_Enrique Quick question... is this info accurate? https://snag.gy/0iU6aM.jpg
14:21 oleonard SourcePawn? PHP? CoffeeScript?
14:21 oleonard :?
14:22 Joubu perl6??
14:22 Freddy_Enrique I was studying the gitlab repo....
14:22 Freddy_Enrique I this section got my attention
14:23 Joubu Pascal? lol
14:25 Freddy_Enrique ok... Not so sure what to say XD. it is not accurate I guess
14:27 mtompset It kind of bugs me that you can't drill down to figure out what it thinks is a particular language.
14:30 Joubu you can read gitlab's code :)
14:34 tuxayo What there is no assembly in Koha?! :(
14:34 Freddy_Enrique Sorry for my asking, wasn't trying to annoy
14:34 calire left #koha
14:35 oleonard Not at all Freddy_Enrique
14:35 eythian Oh, I wrote a lot of my Koha code in assembly, just disguised as Perl.
14:35 oleonard Joubu will be entertained for hours trying to find the PHP in Koha so he can excise it.
14:35 Freddy_Enrique WHat we know here is that is a sin to consider html a programming language
14:35 tuxayo eythian (IRC):  That's why! :D
14:35 AndrewIsh Anyone got a moment to confirm if I've just found a bug in master?
14:35 Joubu oleonard: heh found it, I guess it's:
14:35 Joubu t/Scrubber.t:<?php  echo(" EVIL EVIL EVIL "); ?>    <!-- COMMENT -->
14:36 corilynn ha!
14:36 Joubu AndrewIsh: shoot
14:37 AndrewIsh Joubu:  It was actually as I was trying to sign off your bug 21612. I was trying to create a few new shelves in the OPAC, and whenever I try I get "DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: '' for column 'allow_change_from_others' at row 1 at /usr/share/koha/Koha/Object.pm line 125"
14:37 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21612 major, P5 - low, ---, jonathan.druart, Needs Signoff , Incorrect GROUP BY in Koha::Virtualshelves
14:37 tuxayo OMG it's real https://gitlab.com/koha-commun[…]/t/Scrubber.t#L29
14:38 tuxayo <A HREF="javascript:alert('OMG YOO R HACKED');">I am a link firing javascript.</A>
14:38 Joubu 36 <span style="background-image: url(http://hackersite.cn/porno.jpg);"> I am a span w/ style.  Bad style.</span>
14:38 Joubu git blame that
14:38 AndrewIsh Joubu:  The select that provides 'allow_change_from_others' appears to be correctly populated, so I'm puzzled..
14:39 mtompset no no...
14:39 mtompset https://www.youtube.com/watch?v=BI5IA8assfk
14:39 mtompset blame it on the rain. ;)
14:42 Joubu AndrewIsh: indeed
14:43 AndrewIsh Joubu:  So you're seeing it too, that's reassuring. I can create a bug if you like and do some digging...
14:43 tuxayo https://gitlab.com/koha-commun[…]ster/t/Scrubber.t
14:43 tuxayo Anyway, it still don't get what is this test doing?
14:43 Joubu AndrewIsh: I use a local branch "sql_modes" with all the patches I have submitted, and it works when I am using i
14:43 kidclamp oleonard: can you take a look at 21664
14:43 Joubu it
14:44 oleonard Sure kidclamp
14:44 Joubu AndrewIsh: ha, it's bug 21610
14:44 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21610 major, P5 - low, ---, jonathan.druart, In Discussion , Koha::Object->store needs to handle incorrect values
14:44 Joubu I will let a note
14:45 AndrewIsh OK, cool
14:48 CrispyBran joined #koha
14:49 * CrispyBran waves
14:49 caroline joined #koha
14:49 mtompset Greetings, tuxayo oleonard eythian Joubu Freddy_Enrique corilynn AndrewIsh kidclamp CrispyBran -- just in case I missed people before. :)
14:49 CrispyBran :)
14:49 kidclamp hiya mtompset
14:49 * AndrewIsh nods respectfully at mtompset
14:50 corilynn hi mtompset
14:50 mtompset Greetings, caroline
14:50 caroline hi mtompset :)
14:51 * Freddy_Enrique waves
14:52 Freddy_Enrique wish I could share a cup of colombian coffe with you guys
14:53 mtompset I'm more of a tea-drinker, but sharing caffeinated beverages can certainly be put on the TODO list. :)
14:54 caroline yeah I'm not much for coffee either, except in tiramisu and other cakes
14:54 mtompset tiramisu++
14:54 AndrewIsh Freddy_Enrique:  I wish you could too, I could do with a Columbian coffee right about now...
14:55 Freddy_Enrique what... is that?
14:55 * Freddy_Enrique searching
14:55 mtompset multi-tiered dessert. very delicious.
14:55 caroline Freddy_Enrique: what is what? tiramisu?
14:56 caroline Freddy_Enrique: with coffee and mascarpone (cheese)... delish!
14:56 Freddy_Enrique it looks yummi
14:56 Freddy_Enrique ZOMG, like in the dev manual XD
14:56 CrispyBran No food talk.  I am fasting for a blood test today.  :(
14:57 mtompset How many hours?
14:57 caroline :( sorry CrispyBran!
14:57 CrispyBran 12
14:57 CrispyBran :O
14:57 mtompset That's why you finish supper at 6pm, and then don't have breakfast, and get a 9am appointment!
14:57 * oleonard googles mascarpone
14:57 CrispyBran We can talk about water.
14:57 CrispyBran Wouldn't that be convenient.
14:58 mtompset You mean you can't schedule your life like that?
14:58 kidclamp yes it is CrispyBran  - returns.pl
15:00 CrispyBran kidclamp...can I put a depends on 21346, since I am already cleaning up some of the interface/modals.  I won't correct it in my patch, but there is another modal conversion there.  Might be best to take care of it after.
15:00 alex_a_ joined #koha
15:01 CrispyBran Unless there is a blanket fix that doesn't touch each modal.
15:02 kidclamp I suspect this canbe a light change, just removing the focus when the modal is present, or something, I would add as a see also unless the fix is determined to conflict
15:02 CrispyBran okay
15:06 alex_a joined #koha
15:06 Infra_3600 joined #koha
15:06 jzairo_ joined #koha
15:10 oleonard TFW git first blames you, but then you find out it was only a whitespace change. 👊
15:10 ashimema Lol
15:11 tcohen @seen josef_moravec
15:11 huginn tcohen: josef_moravec was last seen in #koha 5 hours, 34 minutes, and 29 seconds ago: <josef_moravec> marcelr: not at all ;)
15:12 CrispyBran @seen khall
15:12 huginn CrispyBran: khall was last seen in #koha 1 day, 1 hour, 7 minutes, and 2 seconds ago: <khall> #info Kyle M Hall, ByWater Solutions
15:16 jzairo @CrispyBran khall had to leave for the day, can I help with anything?
15:16 huginn jzairo: I'll give you the answer just as soon as RDA is ready
15:16 wahanui i already had it that way, huginn.
15:16 Joubu oleonard: `git blame -w` :)
15:16 reiveune bye
15:16 reiveune left #koha
15:16 Joubu I'll give you the answer just as soon as RDA?
15:16 Joubu wahanui: I'll give you the answer just as soon as RDA?
15:16 wahanui joubu: i haven't a clue
15:17 Joubu huh
15:17 Joubu you should better search... for something
15:18 eythian that sounds like the worst threat ever, Joubu
15:18 Joubu wahanui will never replace google
15:18 wahanui Joubu: sorry...
15:19 alex_a joined #koha
15:19 oleonard Don't be sorry wahanui, we don't need you building secret profiles on each of us and targeting us with ads
15:19 huginn News from kohagit: Bug 21596: (follow-up) Handle updated_on <http://git.koha-community.org/[…]2a601d71de09b1d56>
15:20 Joubu I am sure he does, ads will come soon
15:21 Joubu they will be ads for ILS or cookies
15:21 Freddy_Enrique wanahui just...APOLOGIZED???
15:22 caroline Joubu: we do talk a lot about cookies in here
15:22 corilynn mmm cookies
15:24 alex_a joined #koha
15:26 CrispyBran jzairo: nope.  Just wanted to bounce something off him and get some ideas.
15:26 jzairo ok
15:28 Joubu oleonard:   22 koha-tmpl/intranet-tmpl/prog/en/includ​es/admin-items-search-field-form.inc:      [% codes = codes.merge([0..9], ['a'..'z']) | html %]
15:29 Joubu this looks wrong as well
15:29 Joubu 85 koha-tmpl/intranet-tmpl/prog/en/​includes/branch-selector.inc:[% selectall = 1 | html %]
15:29 oleonard Yup
15:29 Joubu 86 koha-tmpl/intranet-tmpl/prog/en​/includes/branch-selector.inc:        [% selectall = 0 | html %]
15:30 Joubu 611 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:              [% timezone_env_class    = (time_zone.env_invalid)    ? 'status_warn' : '' | html %]
15:30 Joubu 610 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:              [% timezone_config_class = (time_zone.config_invalid) ? 'status_warn' : '' | html %]
15:31 Joubu and many others
15:31 * Joubu stops spamming #koha
15:32 oleonard So does that mean you're going to fail Bug 21663? :P
15:32 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21663 major, P5 - low, ---, oleonard, Passed QA , Incorrect filter prevents predefined notes from being added to patron acccounts
15:32 mtompset ashimema, you still here?
15:33 Joubu oleonard: sure not, I am going to open a new one
15:34 mtompset @later tell ashimema could you tell me what you think of my patch on your bug 21656? :)
15:34 huginn mtompset: The operation succeeded.
15:38 corilynn does anyone have a pet bug (that has test steps) for me to sign off? I'm interested in developing some karma
15:38 oleonard Good timing corilynn! Bug 21186?
15:38 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21186 normal, P5 - low, ---, oleonard, Needs Signoff , Incorrect Bootstrap modal event name in multiple templates
15:39 corilynn excellent
15:39 wahanui darn tootin' it is.
15:39 mtompset corilynn++ # because you asked for karma. ;)
15:39 mtompset @karma corilynn
15:39 huginn mtompset: Karma for "corilynn" has been increased 4 times and decreased 0 times for a total karma of 4.
15:40 oleonard corilynn++
15:40 mtompset WHAT?!
15:40 corilynn I'm new
15:40 corilynn like less than a month new
15:40 mtompset Yes, but it still seems low to me.
15:40 mtompset @karma oleonard
15:40 huginn mtompset: Karma for "oleonard" has been increased 349 times and decreased 0 times for a total karma of 349.
15:40 mtompset @karma mtompset
15:40 huginn mtompset: Karma for "mtompset" has been increased 64 times and decreased 0 times for a total karma of 64.
15:41 oleonard mtompset++
15:41 Freddy_Enrique O.o?
15:41 mtompset @karma Freddy_Enrique
15:41 huginn mtompset: Karma for "Freddy_Enrique" has been increased 5 times and decreased 0 times for a total karma of 5.
15:41 mtompset @karma microsoft
15:41 huginn mtompset: Karma for "microsoft" has been increased 0 times and decreased 1 time for a total karma of -1.
15:41 caroline lol!
15:41 Freddy_Enrique I am a baby in this place
15:41 mtompset @karma ubuntu
15:41 huginn mtompset: ubuntu has neutral karma.
15:41 mtompset @karma debian
15:41 huginn mtompset: debian has neutral karma.
15:42 Freddy_Enrique so many Tech Putin people here
15:42 mtompset @karma windows
15:42 huginn mtompset: Karma for "windows" has been increased 0 times and decreased 2 times for a total karma of -2.
15:42 CrispyBran @karma CrispyBran
15:42 huginn CrispyBran: Karma for "CrispyBran" has been increased 6 times and decreased 0 times for a total karma of 6.
15:43 mtompset We reset the karma annually, right?
15:43 Freddy_Enrique @Joubu
15:43 huginn Freddy_Enrique: I'll give you the answer as soon as RDA is ready
15:43 wahanui i already had it that way, huginn.
15:43 barton brainstorm: could we add a "low hanging fruit" section to https://dashboard.koha-community.org/?
15:43 Freddy_Enrique what the.... Joubu must be on the sky
15:43 barton ... easy sign-offs, easy developments...
15:44 oleonard barton: Could be built off the "academy" keyword if folks used it consistently.
15:44 barton yeah.
15:44 oleonard The trouble is, one person's low-hanging fruit may not be another's.
15:46 barton I'm not *too* worried about that, folks can look at patches and judge for themselves. Might also count "complexity: trivial" and "string patch" in there as well.
15:53 laurence left #koha
15:53 oleonard I'm resisting the urge to say "patches welcome" which seems like the "RTFM" of this kind of conversation :)
15:53 * oleonard wonders how hard it is to install koha-dashboard in kohadevbox
15:55 mtompset oleonard++ # for accurate assessment of "patches welcome". :)
15:57 corilynn yo, olenard, I'm not seeing a difference with step 1 of test plan
15:58 oleonard Sorry corilynn I'm stepping out for a bit. I'll check in when I get back in case you're still around
15:58 corilynn k
16:02 Joubu oleonard: the problem is the lack of data in the DB
16:03 Joubu otherwise it's a git clone, perl bin/stuff.pl iirc
16:03 Joubu ha, and the config :)
16:04 Joubu kidclamp: back to stable! (almost)
16:09 corilynn I just made a cori currency and my library has a budget of %6,000,000 CORIS
16:09 Joubu kidclamp: follow-up on 13618 for 'LAST'
16:09 corilynn isn't koha grand :)
16:09 tcohen =D
16:10 tcohen Joubu: 18.05 images upgraded and fixed. I'm sorry I missed that
16:11 Joubu tcohen: Have you seen the weird failure on U18?
16:11 mtompset link?
16:15 tcohen https://jenkins.koha-community[…]18/72/consoleFull
16:15 tcohen Ctrl+f Could not unlink /tmp/xRRc7ht
16:15 tcohen Joubu: I have no clue sorry
16:30 ashimema That's systemd I reckon tcohen
16:36 Joubu ashimema: why was not it failing before?
16:37 ashimema Just trying to figure that out
16:37 * cbrannon[A] is now away - Reason : Delivery
16:38 ashimema Cant work out how to see what's changed..
16:38 * ashimema isn't very good with docker yet
16:39 ashimema But that certainly the sort of error I started getting on the sandboxes when we upgraded to systemd
16:42 Joubu nothing has changed, I will request another run...
16:58 mtompset This /tmp thing got me thinking of bug 20428
16:58 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=20428 major, P5 - low, ---, tomascohen, RESOLVED FIXED, MARC import fails on Debian Stretch
16:59 mtompset perhaps the tempdir()'s should have a DIR=> in them?
17:09 Joubu bug 21670 weeeirdo
17:09 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21670 minor, P5 - low, ---, chris, NEW , t/db_dependent/Plugins.t is failing randomly on Jenkins (U18)
17:23 * CrispyBran is no longer away : Gone for 46 minutes 1 second
17:27 oleonard corilynn: Thanks for the notes on that bug
17:27 corilynn yeah, I was able to reproduce the issue on a master installation. If you want me to do those last few, just give me some hints on how
17:31 oleonard In my opinion you've done enough for a signoff. I was only able to test EDIFACT messages by manually inserting data into the database, and testing invoices requires some acquisitions data
17:33 oleonard But if you'd like a walkthrough, corilynn, I'm happy to give it
17:33 corilynn ok, i'm cool
17:40 oleonard Joubu: Bug 21669 doesn't apply for me. "fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en​/modules/catalogue/results.tt)"
17:40 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21669 major, P5 - low, ---, jonathan.druart, Needs Signoff , TT assignement statements must not be html filtered
17:42 Joubu oleonard: could you try and apply these 2 patches first:
17:42 Joubu 5642ad034c Bug 21669: Do not html filter TT assignement statements
17:42 Joubu 027b0f7274 Bug 13618: Remove html filter for LAST
17:42 Joubu 5c1d2c64e2 Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts
17:42 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=13618 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Add additional template filter methods and a filter presence test to Koha
17:42 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21663 major, P5 - low, ---, oleonard, Passed QA , Incorrect filter prevents predefined notes from being added to patron acccounts
17:42 Joubu last one on 13618 is not pushed yet
17:42 oleonard Oh
18:58 Joubu kidclamp: bug 21584 is marked as PQA but is actually pushed
18:58 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21584 normal, P5 - low, ---, tomascohen, Passed QA , Wrong offset type for Lost Item
18:58 Joubu kidclamp: hum, same as bug 21625, maybe you forgot to switched the statuses after your last push session
18:58 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=21625 trivial, P5 - low, ---, katrin.fischer, Passed QA , Fix wording and typo in SMSSendDriver system preference description
18:59 kidclamp seems possible lemme review in a bit
19:09 oleonard Bye #koha
19:20 tcohen anyone with experience in message queues?
19:23 Joubu it depends on the question :D
19:28 Infra_3600 joined #koha
19:31 jo joined #koha
19:38 ashimema Mm, what's the question
19:39 tcohen I need to develop a plugin that would require hooks in Addbiblio, ModBiblio and DelBiblio
19:39 tcohen it would be great if (instead of the hooks)
19:39 tcohen it would send a broadcast message
19:39 tcohen to anyone (daemon) listening
19:39 tcohen for async work
19:41 tcohen this would be cool for pushing changes to a remote server for instance, through an API
19:41 * ashimema likes minion
19:41 tcohen I was looking at zeromq
19:42 tcohen ashimema: can you write Mojo::MySQL ?
19:42 ashimema The questions you need to ask yourself are about asynchronousity.. i.e can these events over lap.. do they need to execute in order
19:42 ashimema Haha.. yeah, that what stops us using minion 😉
19:43 tcohen Joubu: there's one month provisions of IPA for someone implementing Mojo::MySQL
19:43 ashimema It works best with postgres
19:43 tcohen I wonder...
19:44 ashimema There's some good reasons why there isn't a Mojo::Mysql
19:44 ashimema In fact.  I think there is but it's recommended against
19:44 ashimema Basically myself doesn't support async
19:44 tcohen I bet is because of the lack of row locks
19:44 ashimema That too 😉
19:45 ashimema https://metacpan.org/pod/Mojo::mysql
19:45 ashimema Batman maintains it
19:46 tcohen I wonder how hard it would be to dockerize minion with pg in
19:48 ashimema Nice idea
20:00 alexbuckley joined #koha
20:01 PinupDiva joined #koha
20:16 Margaret joined #koha
20:22 hkh joined #koha
20:24 hkh is koha-restore prepared for restoring a koha-dump done with an older version?
20:36 Joubu hkh: I think so yes
20:41 caroline bye y'all!
20:44 alexbuckley hi all
20:55 Margaret_ joined #koha
20:57 hkh left #koha
21:19 Freddy_Enrique left #koha
21:32 cait joined #koha
21:42 Moxie joined #koha
22:13 aleisha hello
22:14 aleisha if anyone's been keeping up with bug 15326 you'll know that i'm having some trouble making navigation for the pages - does anyone have any experience with this/tips to offer?
22:14 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=15326 new feature, P5 - low, ---, aleisha, Needs Signoff , Add CMS feature
23:12 tcohen ashimema: I'm not sure how it would work with minion
23:15 Margaret joined #koha
23:34 dcook joined #koha
23:34 dcook First time looking at the Advanced Editor... and first time looking at RequireJS O_O
23:35 dcook @later tell joubu Ok. I'll put it on my to do list.
23:35 huginn dcook: The operation succeeded.
23:56 dcook I don't suppose anyone has seen this when using git-bz?
23:56 dcook UnicodeEncodeError: 'ascii' codec can't encode character u'\u201c' in position 71: ordinal not in range(128)
23:57 dcook I mean 20 is a space and 1c is a control character but I don't know how a control character would have snuck in...

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary