Time |
S |
Nick |
Message |
00:02 |
|
jenkins |
Yippee, build fixed! |
00:02 |
|
jenkins |
Project Koha_Master_D9 build #555: FIXED in 33 min: https://jenkins.koha-community[…]ha_Master_D9/555/ |
00:05 |
|
jenkins |
Project Koha_Master_D8 build #49: STILL UNSTABLE in 36 min: https://jenkins.koha-community[…]oha_Master_D8/49/ |
00:17 |
|
|
edveal joined #koha |
00:32 |
|
|
cait joined #koha |
00:34 |
|
* cait |
waves |
00:36 |
|
|
cait2 joined #koha |
00:48 |
|
|
lukeG joined #koha |
03:06 |
|
|
hjb3 joined #koha |
04:05 |
|
|
irma_ joined #koha |
04:09 |
|
|
irma__ joined #koha |
10:40 |
|
magnuse |
hfk19 is "we'll have a hackfest in Marseille in 2019, sept 30-oct 4" http://irc.koha-community.org/[…]8-09-15#i_2070724 |
10:40 |
|
magnuse |
hfk19? |
10:40 |
|
wahanui |
hfk19 is "we'll have a hackfest in Marseille in 2019, sept 30-oct 4" http://irc.koha-community.org/[…]8-09-15#i_2070724 |
15:54 |
|
|
lukeG joined #koha |
15:57 |
|
|
lukeG_ joined #koha |
16:00 |
|
|
lukeG__ joined #koha |
16:02 |
|
|
caroline_ joined #koha |
16:03 |
|
|
lukeG joined #koha |
16:05 |
|
|
lukeG_ joined #koha |
16:08 |
|
|
cait joined #koha |
16:10 |
|
|
cait2 joined #koha |
16:10 |
|
|
irma_ joined #koha |
16:12 |
|
|
fridolin joined #koha |
16:13 |
|
fridolin |
hi there |
16:13 |
|
* fridolin |
dreamed of pizza ;) |
16:14 |
|
matts |
hi ! |
16:14 |
|
|
davidnind joined #koha |
16:18 |
|
|
hjb3 joined #koha |
16:18 |
|
|
kohaputti joined #koha |
16:18 |
|
|
ClassyDancer joined #koha |
16:18 |
|
|
fredericdem joined #koha |
16:18 |
|
|
killer_bee[m] joined #koha |
16:18 |
|
|
valterbarreira[m] joined #koha |
16:18 |
|
|
clrh joined #koha |
16:27 |
|
|
kidclamp joined #koha |
16:37 |
|
Joubu |
kidclamp: I am on the D8 failure |
16:50 |
|
|
dcook joined #koha |
16:51 |
|
|
calire joined #koha |
16:52 |
|
Joubu |
kidclamp: bug 21360 |
16:52 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21360 minor, P5 - low, ---, jonathan.druart, Needs Signoff , IssueSlip.t is failing if run at 23:59 |
16:57 |
|
kidclamp |
Joubu bug 21262 |
16:57 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21262 minor, P5 - low, ---, nick, Signed Off , Do not format numbers for editing if too big |
17:06 |
|
Joubu |
kidclamp: PQAed |
17:07 |
|
Joubu |
Did you, QA people, that 21281 is SO and "blo" which means "blocker"? |
17:12 |
|
|
lukeG joined #koha |
17:14 |
|
|
lukeG_ joined #koha |
17:16 |
|
Joubu |
*know* |
17:19 |
|
|
MostWanted joined #koha |
17:19 |
|
|
lukeG__ joined #koha |
17:20 |
|
bag |
good morning |
17:25 |
|
|
lukeG_ joined #koha |
17:27 |
|
Joubu |
kidclamp: you messed with bug 19817, see last patch I have just attached, the whole koha-tmpl/intranet-tmpl/prog/en/modules/help/ should have been removed by the main patch |
17:27 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19817 new feature, P5 - low, ---, jonathan.druart, RESOLVED FIXED, Merge local and online documentations |
17:30 |
|
|
lukeG__ joined #koha |
17:32 |
|
|
calire joined #koha |
17:33 |
|
|
calire1 joined #koha |
17:41 |
|
|
lukeG_ joined #koha |
17:42 |
|
|
CrispyBran joined #koha |
17:42 |
|
|
oleonard joined #koha |
17:42 |
|
* CrispyBran |
is a slacker. Hello #koha! |
17:42 |
|
* oleonard |
spent the morning shopping, so... |
17:43 |
|
* CrispyBran |
is trying to look somewhat entelyjint next to kidclamp |
17:46 |
|
|
lukeG_ joined #koha |
17:49 |
|
|
lukeG__ joined #koha |
17:52 |
|
|
lukeG joined #koha |
17:55 |
|
|
lukeG_ joined #koha |
18:00 |
|
|
lukeG joined #koha |
18:03 |
|
|
lukeG__ joined #koha |
18:06 |
|
|
lukeG_ joined #koha |
18:18 |
|
huginn` |
News from kohagit: Bug 19817: (follow-up) Remove local help files + edit help feature <http://git.koha-community.org/[…]888359eae4a6c4906> |
18:18 |
|
huginn` |
News from kohagit: Bug 21360: Prevent IssueSlip.t to fail when run at 23:59 <http://git.koha-community.org/[…]0cf76d4c764efcba0> |
18:18 |
|
huginn` |
News from kohagit: Bug 20217: Compiled CSS <http://git.koha-community.org/[…]3c9ce5768c14cb735> |
18:18 |
|
huginn` |
News from kohagit: Bug 21356: Add Missing space in parcel.tt <http://git.koha-community.org/[…]a65c92469bf6fd12c> |
18:18 |
|
huginn` |
News from kohagit: Bug 21347: Escaped fields that should be in addorderiso2709 <http://git.koha-community.org/[…]c2751be1ef4b394e1> |
18:18 |
|
huginn` |
News from kohagit: Bug 21262: Do not format numbers for editing if too big <http://git.koha-community.org/[…]d01def71eb924d4fa> |
18:18 |
|
huginn` |
News from kohagit: Bug 20217: Make header's catalog search menu into a split button <http://git.koha-community.org/[…]dcedefaf67b774a4e> |
18:18 |
|
huginn` |
News from kohagit: Bug 13692: series link is taking you to just 800a instead of whole 800 <http://git.koha-community.org/[…]6c98bcfbf909dfdc8> |
18:18 |
|
huginn` |
News from kohagit: Bug 21306: Update two-column templates with Bootstrap grid: Tags <http://git.koha-community.org/[…]ff43c2d2333a78879> |
18:18 |
|
huginn` |
News from kohagit: Bug 21305: Update two-column templates with Bootstrap grid: Patron clubs <http://git.koha-community.org/[…]392818bc808ae42d0> |
18:42 |
|
ere |
kidclamp: Bug 16424 now has a patch for framework support in advanced MARC editor |
18:42 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16424 major, P5 - low, ---, ere.maijala, Needs Signoff , Advanced editor reverts records back to Default framework |
18:44 |
|
jenkins |
Project Koha_Master_D9 build #556: SUCCESS in 25 min: https://jenkins.koha-community[…]ha_Master_D9/556/ |
18:48 |
|
|
lukeG joined #koha |
18:49 |
|
|
oleonard joined #koha |
18:50 |
|
oleonard |
Bug 21257 |
18:50 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21257 major, P5 - low, ---, jonathan.druart, Signed Off , Patrons checkout table throws JS error when location/collection not defined |
18:50 |
|
rangi |
ta |
18:50 |
|
jenkins |
Project Koha_Master_U18 build #44: SUCCESS in 30 min: https://jenkins.koha-community[…]ha_Master_U18/44/ |
18:52 |
|
jenkins |
Yippee, build fixed! |
18:52 |
|
jenkins |
Project Koha_Master_D8 build #50: FIXED in 34 min: https://jenkins.koha-community[…]oha_Master_D8/50/ |
18:53 |
|
|
lukeG_ joined #koha |
18:55 |
|
|
lukeG__ joined #koha |
19:00 |
|
|
lukeG__ joined #koha |
19:03 |
|
|
lukeG_ joined #koha |
19:06 |
|
|
lukeG___ joined #koha |
19:09 |
|
|
lukeG__ joined #koha |
19:12 |
|
|
lukeG_ joined #koha |
19:17 |
|
|
lukeG_ joined #koha |
20:04 |
|
|
alexbuckley joined #koha |
20:10 |
|
|
oleonard joined #koha |
20:20 |
|
|
dcook_ joined #koha |
20:36 |
|
|
edveal joined #koha |
20:43 |
|
|
oleonard joined #koha |
20:50 |
|
|
paul_p joined #koha |
20:50 |
|
paul_p |
bag https://twitter.com/OM_Grand_E[…]418493444/video/1 |
20:57 |
|
|
edveal joined #koha |
20:58 |
|
|
fridolin joined #koha |
21:19 |
|
|
cait joined #koha |
21:37 |
|
oleonard |
alexbuckley around? |
21:37 |
|
alexbuckley |
hi oleonard |
21:37 |
|
wahanui |
hi oleopard |
21:38 |
|
oleonard |
Hi, I'm just looking at Bug 20678 |
21:38 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20678 enhancement, P5 - low, ---, alexbuckley, Needs Signoff , Save draft records without committing them to the catalogue |
21:38 |
|
alexbuckley |
ah yup |
21:38 |
|
oleonard |
I like the feature and I agree that it doesn't need to wait for the right terminology |
21:38 |
|
oleonard |
I am seeing some buggy stuff though |
21:39 |
|
oleonard |
It looks like it makes the current split button menu items disappear from the "Save" button on the cataloging page |
21:39 |
|
alexbuckley |
oh ok what buggy behaviour? |
21:39 |
|
oleonard |
No more "Save and view record," etc. |
21:40 |
|
oleonard |
Since it's rare we're here at the same time I thought I'd ask about it here instead of comment on the bug :) |
21:40 |
|
oleonard |
Do you see the same? |
21:40 |
|
alexbuckley |
i'll take a look one sec |
21:49 |
|
oleonard |
Oh wait, maybe because my user account doesn't have the new permission |
21:49 |
|
alexbuckley |
ah yes that might be it |
21:50 |
|
oleonard |
no... superlibrarian |
21:54 |
|
oleonard |
I've got it now. I think maybe the db update didn't run correctly |
21:58 |
|
alexbuckley |
I think that might be because you may have already imported a batch into Koha and so when the atomicupdate tries to create a batch with id of 1 it fails due to duplicate ids |
21:59 |
|
oleonard |
Yeah that's not going to work on anything but brand new systems |
22:00 |
|
oleonard |
What is the purpose of inserting that batch? |
22:02 |
|
alexbuckley |
draft records are stored in the import_biblios table and belong to the batch file (with id of 1) |
22:02 |
|
alexbuckley |
then when draft records are saved to catalog they are moved to the biblio table |
22:02 |
|
alexbuckley |
so yes as you say it will work for new systems only |
22:03 |
|
oleonard |
Could you re-do it so that it goes based on the batch file name instead? |
22:11 |
|
alexbuckley |
yes we have thought about this, the limitations of retrieving the batch file based on the file name is if another batch file with the name 'Draft record' is created by a user. One way around it is to prevent users from entering a batch file with the name 'Draft record', does this user limitation seem fair and usable to you? If not can you suggest another workaround? |
22:22 |
|
oleonard |
alexbuckley: Off the top of my head, what about a longer more unique name? |
22:23 |
|
oleonard |
alexbuckley: We could even add some checking to the Staged MARC record management page to recognize the "internal" name (a_long_complicated_file_name_XJ-7) and give it a human-readable, translatable name ("Draft records, do not delete!") |
22:26 |
|
alexbuckley |
hmm yes that is certainly a good workaround. |
22:27 |
|
oleonard |
Get a second opinion... a sanity check on me :) |
22:27 |
|
alexbuckley |
I will have a think about it for the next couple of hours and then try to make the changes for that patch this afternoon ready for testing again, would you be keen to test this again after this change is made? |
22:28 |
|
oleonard |
Absolutely, but my day is about to end so it would be later in the week. |
22:29 |
|
oleonard |
I'm going to add a couple of other notes to the bug report. Could I set the bug back to "Assigned" to keep it out of the needs signoff queue? |
22:30 |
|
alexbuckley |
yeah I had a quick discussion with aleisha and wizzyrea and suggestions were setting the batchfile id to 0 which is not a id which will not have been used on existing systems, or a longer unique name like you suggested only making it something like 'Batch draft record - <random string>' then check if there is a batch file name with the name starting with 'Batch draft record' and then a random string |
22:30 |
|
alexbuckley |
so several ideas to think about and consider |
22:30 |
|
alexbuckley |
and yes please set it back to assigned |
22:30 |
|
alexbuckley |
thanks |
22:41 |
|
|
fridolin left #koha |
23:07 |
|
oleonard |
CrispyBran: https://wiki.koha-community.or[…]staff_client_SCSS |
23:09 |
|
huginn` |
News from kohagit: Bug 21317: Compiled CSS <http://git.koha-community.org/[…]28dd4f9cb9a1f2458> |
23:09 |
|
huginn` |
News from kohagit: Bug 21317: Format long lists under Koha Team tab as columns <http://git.koha-community.org/[…]1941de6244f810f2b> |
23:09 |
|
huginn` |
News from kohagit: Bug 21257: (bug 13618 follow-up) Handle undef values in JS before escapeHtml call <http://git.koha-community.org/[…]81da6cb83802a9699> |
23:23 |
|
|
cait left #koha |
23:35 |
|
jenkins |
Project Koha_Master_D9 build #557: SUCCESS in 26 min: https://jenkins.koha-community[…]ha_Master_D9/557/ |
23:36 |
|
|
davidnind left #koha |
23:36 |
|
jenkins |
Project Koha_Master_U18 build #45: SUCCESS in 26 min: https://jenkins.koha-community[…]ha_Master_U18/45/ |
23:42 |
|
jenkins |
Project Koha_Master_D8 build #51: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_Master_D8/51/ |