Time |
S |
Nick |
Message |
00:11 |
|
tcohen |
wizzyrea++ # love the new circ page |
00:12 |
|
wizzyrea |
naw, thank you |
00:12 |
|
wizzyrea |
it was a team effort :) |
00:12 |
|
wizzyrea |
I was working on the reports page too but owen beat me to something there and now I have to rejig all my work |
00:13 |
|
wizzyrea |
maybe I'll do tools instead |
00:13 |
|
wizzyrea |
or both. |
00:13 |
|
wizzyrea |
I don't have a lot of time atm |
00:13 |
|
tcohen |
Been there, Owen's enhancements are always worth, though |
00:13 |
|
wizzyrea |
rather I can't prioritise community stuff :( |
00:14 |
|
tcohen |
I would love to see something solved: plugins |
00:14 |
|
wizzyrea |
i'm obviously in the minority on that one |
00:14 |
|
tcohen |
We shouldn't show a link to the plugins page, but list them instead! |
00:14 |
|
tcohen |
(in both reports and tools) |
00:15 |
|
wizzyrea |
ah yeah I had another idea for reports |
00:15 |
|
wizzyrea |
which was the ability to mark a report to show it on the home page |
00:15 |
|
wizzyrea |
the reports* home page |
00:15 |
|
tcohen |
That's interesting too! |
00:15 |
|
wizzyrea |
under the same heading as the report category you can pick for the saved reports view |
00:16 |
|
tcohen |
Yeah |
00:16 |
|
tcohen |
Maybe some icon to distinguish it is custom vs. Shipped |
00:17 |
|
wizzyrea |
could be, or a separate section |
00:17 |
|
tcohen |
CC me if you file that bug! |
00:19 |
|
wizzyrea |
i may have done it already... but I will :) |
00:19 |
|
tcohen |
Ha |
00:20 |
|
* tcohen |
goes back cooking for the wife |
00:20 |
|
tcohen |
Have a good night/day! |
01:49 |
|
|
JoshB joined #koha |
05:34 |
|
|
cait joined #koha |
06:09 |
|
|
irma joined #koha |
06:13 |
|
|
laurence joined #koha |
06:19 |
|
|
calire joined #koha |
06:27 |
|
|
reiveune joined #koha |
06:27 |
|
reiveune |
hello |
06:39 |
|
|
alex_a joined #koha |
06:39 |
|
alex_a |
bonjour |
06:45 |
|
|
fridolin joined #koha |
06:51 |
|
|
ashimema joined #koha |
06:52 |
|
|
saa joined #koha |
06:52 |
|
saa |
is it possible to display price of the book on patrons page when checkedout books are displayed |
06:53 |
|
saa |
price column is already there but it doesnot show up the cost |
06:56 |
|
ashimema |
SIlly question.. should the names in docs/history.txt match the names in koha-tmpl/intranet-tmpl/prog/en/modules/about.tt exactly? Is there a reason why one might appear in history but not on about? |
06:59 |
|
ashimema |
@later tell Joubu I'm on bug 20402 this morning.. not been well the last few days so I'm a bit behind what I wanted to be :( |
06:59 |
|
huginn |
ashimema: The operation succeeded. |
07:06 |
|
|
paul_p joined #koha |
07:07 |
|
|
AndrewIsh joined #koha |
07:14 |
|
|
cait joined #koha |
07:15 |
|
tuxayo |
hola #koha o/ |
07:15 |
|
|
raimundklein joined #koha |
07:16 |
|
|
sophie_m joined #koha |
07:26 |
|
* cait |
waves |
07:29 |
|
|
gaetan_B joined #koha |
07:29 |
|
gaetan_B |
hello |
07:30 |
|
saa |
how to display price of the book when total checksout is listed |
07:43 |
|
nlegrand |
Bonjour Koha |
07:46 |
|
|
andreashm joined #koha |
07:50 |
|
andreashm |
salu |
07:50 |
|
andreashm |
salut ^ |
08:09 |
|
ashimema |
reviewed bug 20402 @Joubu |
08:09 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20402 new feature, P5 - low, ---, julian.maurice, Passed QA , Implement OAuth2 authentication for REST API |
08:09 |
|
ashimema |
there's a few minor niggles and some slight confusions |
08:10 |
|
ashimema |
I would have done it differently.. but that can happen as followups.. main reason I would have stuck with the plugin is that it handles multiple grant types nicely.. |
08:11 |
|
ashimema |
but.. I need to go back and work on the plugin again some more.. I was helping nail down some bugs in it a number of months ago but got pulled into other things |
08:13 |
|
cait |
too early for Joubu - not sure it highlights with the @ |
08:22 |
|
|
severine_q joined #koha |
08:23 |
|
severine_q |
hello #koha :) |
08:23 |
|
cait |
hi severine_q :) |
08:23 |
|
|
raimundklein joined #koha |
08:23 |
|
severine_q |
hi cait ! |
08:26 |
|
|
gerundio joined #koha |
08:28 |
|
|
snorri joined #koha |
08:37 |
|
|
dersmon joined #koha |
08:38 |
|
dersmon |
hi everyone |
08:38 |
|
dersmon |
when trying to export my data using export_records.pl i get the following error: |
08:38 |
|
dersmon |
Unrecognized switch: --record-type=bibs (-h will show valid options). |
08:39 |
|
dersmon |
i dont get it, what am i supposed to use? :D |
08:40 |
|
cait |
what does -h tell you? |
08:42 |
|
dersmon |
--record-type --record-type=TYPE TYPE is 'bibs' or 'auths'. |
08:45 |
|
dersmon |
hm, the command works when i run the script directly instead of inside of a shell script |
08:59 |
|
|
marcelr joined #koha |
08:59 |
|
marcelr |
hi #koha |
09:02 |
|
cait |
dersmon: id you install with packages? |
09:02 |
|
dersmon |
yep |
09:02 |
|
cait |
running inside koha-shell? |
09:02 |
|
cait |
hi marcelr |
09:03 |
|
marcelr |
o/ |
09:03 |
|
cait |
thx for your qa work |
09:06 |
|
dersmon |
yes |
09:06 |
|
* ashimema |
uses slack too much now.. @ comes automatically to my fingers :( |
09:07 |
|
ashimema |
@later tell Joubu reviewed bug 20402 for you |
09:07 |
|
huginn |
ashimema: The operation succeeded. |
09:07 |
|
magnuse |
\o/ |
09:09 |
|
|
alexbuckley joined #koha |
09:20 |
|
nlegrand |
Joubu: yes |
09:20 |
|
nlegrand |
oups sorry |
09:20 |
|
nlegrand |
I just had a context problem. |
09:27 |
|
|
AndrewIsh joined #koha |
09:39 |
|
|
raimundklein joined #koha |
09:44 |
|
|
ashimema_laptop joined #koha |
10:13 |
|
* ashimema |
I do wish splinter review had a 'review all patches' option rather than having to go through each attachment |
10:20 |
|
|
raimundklein joined #koha |
10:38 |
|
cait |
ashimema: easier to apply them and check them together, it's waht i do |
10:40 |
|
ashimema |
githubs review system is so much lighter weight ;) |
10:40 |
|
ashimema |
I would like to be able to do basic code review without even applying the patches (which is what I did in this case) ;) |
10:41 |
|
ashimema |
github allows that with pull request reviews... I can see (and more importantly comment on inline) the whole set of commits in one view. |
10:41 |
|
ashimema |
that's what I'd love to be able to do in splinter |
10:42 |
|
ashimema |
review board or gerrit look like good contenders ;) |
10:42 |
|
|
dcook_ joined #koha |
11:06 |
|
* ashimema |
is doing a review of the set in a github pull request on local branches and will link to it in the bugzilla that tcohen three at me ;) |
11:10 |
|
jajm |
tcohen, debian/control.in is generated too ? |
11:12 |
|
tcohen |
I think it is a template |
11:12 |
|
tcohen |
I'm on the phone |
11:13 |
|
tcohen |
debian/update-control |
11:16 |
|
jajm |
tcohen, i believe debian/update-control is only for Perl dependencies, i'm talking about the memcached server |
11:24 |
|
AndrewIsh |
Does anyone know if there is any way to get at the actual date format indicated by the, seemingly, arbitrary strings stored as the dateformat syspref (such as dmydot)? |
11:25 |
|
AndrewIsh |
I need it to be able to pass to the JS datepicker |
11:26 |
|
|
nitc_admin joined #koha |
11:26 |
|
ashimema |
tcohen.. sorry but I'm really not at all happy with using Client Credential Grant they way we are.. it's totally the wrong grant type for what we appear to be trying to achieve |
11:28 |
|
tcohen |
What are we trying to achieve? |
11:29 |
|
ashimema |
well, it looks to me like your trying to allow patrons to create api keys and doing that using a mislead understanding of OAuth grant types |
11:29 |
|
tcohen |
Because as far as I'm concerned, we want to implement the client credentials grant. Even if we also want other grants |
11:29 |
|
ashimema |
Client Credentials Grant really isn't meant for patrons |
11:29 |
|
ashimema |
it's only meant to identify a Client and not tie that client to a Patron |
11:30 |
|
ashimema |
that's what the other grants are all about.. it's the other grants to tie users to clients |
11:30 |
|
ashimema |
`The "Client Credentials Grant" can request an access token using only its client credentials (or other supported means of authentication) when the client is requesting access to the protected resources under its control, or those of another resource owner that have been previously arranged with the authorization server.` |
11:30 |
|
ashimema |
'previously arranged with the server' |
11:30 |
|
ashimema |
so for the other grant types you often in effect do a client grant check followed by a user grant check |
11:31 |
|
|
calire left #koha |
11:31 |
|
ashimema |
`You should not use the "Password Grant" or "Client Credentials Grant" unless your client/server apps are non-public facing or you really know what you are doing.` |
11:32 |
|
ashimema |
those are quotes from the RFC and Net::OAuth2::AuthorizationServer documents ;) |
11:33 |
|
ashimema |
we're actually really not that far off 'Authorization Code Grant' here in the end.. we should really support that as the first grant type instead in my opinion |
11:33 |
|
* ashimema |
will try to get some time to add a patch on top of those to do that. |
11:33 |
|
cait |
patron= staff users for now, right? |
11:34 |
|
ashimema |
no. |
11:34 |
|
ashimema |
there;'s OPAC code in here |
11:34 |
|
ashimema |
that's what worries me cait |
11:34 |
|
ashimema |
https://github.com/PTFS-Europe[…]treview-113933459 is the start of my review of the whole patchset |
11:34 |
|
ashimema |
I'm still working through it |
11:34 |
|
nitc_admin |
Hi, I'm having an issue while checking in certain books. While checking in it is showing that the book is not checked out but when i look at the circulation history of the patron who took the book it is shown that the book is checked out. Anyone faced the same issue ? |
11:35 |
|
nitc_admin |
We are running koha 16.05 |
11:36 |
|
nitc_admin |
For the mentioned books, when i look at the status field in the catalog the status is shown as empty. |
11:41 |
|
jajm |
ashimema, the authorization code grant requires a browser, right ? or at least some sort of human interaction ? i think having this grant type in Koha would be very nice, but client credentials grant is also needed |
11:42 |
|
ashimema |
code grant doesn't always require a browser.. github have a 'create your token' workflow that doesn't require the other end to be browser intiated from memory |
11:44 |
|
|
severine_q joined #koha |
11:46 |
|
ashimema |
hmm.. you could use a client credentials grant the way you are.. but there should be a step somewhere for the user to specify which permissions to give.. rather than it being tied directly to their user account. |
11:46 |
|
ashimema |
jwt tokens would make this much easier |
11:47 |
|
|
oleonard joined #koha |
11:47 |
|
oleonard |
Hi all |
11:50 |
|
|
alex_a joined #koha |
11:53 |
|
ashimema |
what you're thinking of are 'Personal access tokens' in github speak.. not 'Client Access Tokens'. In effect you're creating the token that results from a code grant flow, but without implementing all the redirections.. |
11:53 |
|
ashimema |
I'll try and throw something together to get the framework working more correctly |
11:54 |
|
ashimema |
it's the `that have been previously arranged with the authorization server` step that's critically missing in my opinion |
11:54 |
|
* ashimema |
goes to lunch |
12:00 |
|
|
raimundklein joined #koha |
12:03 |
|
|
ncbaratta joined #koha |
12:08 |
|
tcohen |
We want the client credentials grant, that's requested by several this party consumers. |
12:10 |
|
|
DonnaB joined #koha |
12:12 |
|
khall |
@seen joubu |
12:12 |
|
huginn |
khall: joubu was last seen in #koha 16 hours, 48 minutes, and 2 seconds ago: <Joubu> @later tell khall Thanks for the follow-up. However I have changed a bit the tests to make sense more clear. It did not make sense to add the fee added by AddIssue several lines after |
12:12 |
|
khall |
@later tell joubu fix https://bugs.koha-community.or[…]g.cgi?id=20287#c8 and I can PQA it |
12:12 |
|
huginn |
khall: The operation succeeded. |
12:12 |
|
huginn |
Bug 20287: enhancement, P5 - low, ---, jonathan.druart, Signed Off , Move AddMember and ModMember to Koha::Patron |
12:13 |
|
cait |
khall: did you see my lats comment on the payment receipt bug? |
12:14 |
|
cait |
i think we need a last small change to not push it as a behaviour change into new installations |
12:14 |
|
cait |
functionally it's all ok, could you look at my comment and work something out plz? |
12:14 |
|
khall |
nope! I'll take a look! |
12:14 |
|
cait |
thx |
12:14 |
|
cait |
i'd really like to have that |
12:14 |
|
cait |
we've been asked for it since 3.2 ) |
12:14 |
|
cait |
:) |
12:14 |
|
khall |
cait: which do you prefer? Wiki or syspref? |
12:15 |
|
cait |
i tend to syspref |
12:15 |
|
cait |
because then we can have the sample |
12:15 |
|
khall |
that's what I was thinking too |
12:15 |
|
khall |
can do! |
12:15 |
|
cait |
and leave it off by default maybe? I think all other emails to patrons need to be activated |
12:15 |
|
cait |
so that woud be consistent |
12:15 |
|
khall |
kk |
12:27 |
|
|
sophie_m left #koha |
12:40 |
|
|
Dyrcona joined #koha |
12:45 |
|
khall |
cait: followup posted! |
12:46 |
|
Joubu |
ashimema: code review outside of bugzilla is counter productive... |
12:48 |
|
Joubu |
thanks khall, I am going to fix the test failure asap |
12:48 |
|
ashimema |
ack |
12:49 |
|
ashimema |
what is your suggetsed approach then Joubu? |
12:49 |
|
Joubu |
ashimema: what is the about/history shift? |
12:49 |
|
cait |
khall: will look at it tonight, thx! |
12:49 |
|
ashimema |
if being asked to review a series of bugzilla bugs as one then how do you review that inside bugzilla |
12:49 |
|
Joubu |
approach for what? |
12:49 |
|
ashimema |
David Roberts spotted that he's in history.txt from way back but not on the about page.. I wondered if there were others missing? |
12:50 |
|
ashimema |
approach for doing a code review when asked to do so over multiple bugs spanning one feature |
12:50 |
|
cait |
khall: follow-up looks good at first glance, thank you |
12:51 |
|
khall |
cait: np! |
12:51 |
|
ashimema |
I tried reviewing the first bug in the sequence and annoyingly reviewing the first patch there already yielded area's where followups had already fixed issues.. thn going on and continueing to review it revealed where entirely new bugs had fixes issues.. so i went outside of bugzilla and reviews the hole code change as a single set.. |
12:51 |
|
ashimema |
I don't understand how else I could do it? |
12:52 |
|
Joubu |
ashimema: should be reported on bug 7143 |
12:52 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7143 trivial, P5 - low, ---, koha-bugs, Pushed to Master , Bug for tracking changes to the about page |
12:52 |
|
ashimema |
ok, thaks |
12:53 |
|
Joubu |
indeed, we cannot do that with bugzilla |
12:58 |
|
ashimema |
exactly.. hence my reviewing it using github as a temporary measure so people could refer to the comments somewhere as a whole |
12:58 |
|
ashimema |
tcohen has been commenting back already |
12:58 |
|
ashimema |
if there's a better alternative I'm all ears though |
12:58 |
|
Joubu |
ok perfect, that was not very important |
12:59 |
|
ashimema |
lol. ok |
12:59 |
|
|
andrew joined #koha |
13:01 |
|
Joubu |
ashimema: please do not clone bug reports |
13:01 |
|
Joubu |
ashimema: bug 20627 - are the deps correct? |
13:01 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20627 new feature, P5 - low, ---, koha-bugs, NEW , Prevent leakages of user permissions to api access tokens |
13:02 |
|
ashimema |
was just about to work that out and clean up |
13:02 |
|
ashimema |
have we stopped using the clone bug option in bugzilla then |
13:02 |
|
ashimema |
ok |
13:08 |
|
Joubu |
ashimema: use the clone option when it makes sense |
13:08 |
|
Joubu |
usually you clone (and so CC all the people), keep the "release notes" and the deps list |
13:08 |
|
Joubu |
then remove the notes, the deps list |
13:08 |
|
Joubu |
and it emails all the guys from the original bug |
13:09 |
|
ashimema |
ok |
13:09 |
|
ashimema |
very annoying that you can't change more during the actual clone |
13:09 |
|
|
andreashm joined #koha |
13:10 |
|
ashimema |
i'm finding my way again with bugzilla and our other tooling.. they're all feeling rather painful at the moment I must admit |
13:10 |
|
* andreashm |
waves |
13:18 |
|
huginn |
News from kohagit: Bug 20590: Fix Members.t <http://git.koha-community.org/[…]4c10ace50d31adfdf> |
13:26 |
|
|
papa joined #koha |
13:29 |
|
cait |
kidclamp++ thx! |
13:34 |
|
|
ashimema joined #koha |
13:37 |
|
|
roch joined #koha |
13:38 |
|
|
ashimema joined #koha |
13:39 |
|
andreashm |
cait: I looked over the gdpr documentation earlier. I'll try to help out with testing, when there are patches available, if I can get the time. Let me know! |
13:40 |
|
cait |
andreashm: maybe note on the wiki somewhere? |
13:42 |
|
andreashm |
cait: yeah, I can do that. Just figure out were. =) |
13:43 |
|
andreashm |
Maybe at the bottom or something. |
13:44 |
|
andreashm |
Saw that there was a patch to add age to statistics. I would love to see bug 7021 added to. Very important for every academic library (at least in Sweden). |
13:44 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7021 enhancement, P5 - low, ---, mathsabypro, ASSIGNED , patron category in the statistics table |
13:47 |
|
|
JoshB joined #koha |
13:47 |
|
Joubu |
cait: ? |
13:48 |
|
cait |
andreashm: add it to the table with a note like TBD? |
13:48 |
|
cait |
we can talk about it next meeting |
13:48 |
|
cait |
Joubu what did I do? |
13:48 |
|
andreashm |
cait: ok |
13:48 |
|
Joubu |
cait: I sent you a PM ;) |
13:49 |
|
|
sen joined #koha |
13:52 |
|
andreashm |
cait: updated the wiki, look ok? |
13:53 |
|
andreashm |
when is the next gdpr meeting? |
13:56 |
|
jenkins |
Yippee, build fixed! |
13:56 |
|
wahanui |
o/ '`'`'`'`'`'`'`'`'` |
13:56 |
|
jenkins |
Project Koha_Master_D8 build #441: FIXED in 33 min: https://jenkins.koha-community[…]ha_Master_D8/441/ |
13:56 |
|
jenkins |
Jonathan Druart: Bug 20590: Fix Members.t |
13:56 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20590 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Koha::Exceptions does not stringify the exceptions |
14:01 |
|
|
NateC joined #koha |
14:03 |
|
|
ashimema joined #koha |
14:09 |
|
|
cait left #koha |
14:11 |
|
|
vfernandes joined #koha |
14:11 |
|
vfernandes |
hi guys |
14:11 |
|
vfernandes |
last week I was here to report some memory problems with one Koha installation |
14:12 |
|
vfernandes |
after some debugging, I realize that the problem was with Koha background index in ElasticSearch |
14:12 |
|
vfernandes |
I'm using Koha + Plack + ElasticSearch |
14:13 |
|
Joubu |
during the full reindex? |
14:13 |
|
vfernandes |
Joubu: during adding mutiple items, merging records, etc. |
14:14 |
|
vfernandes |
any method that creates/moves multiple items |
14:14 |
|
Joubu |
what are the symptoms? |
14:15 |
|
vfernandes |
high memory percentage on Starman worker, starts using swap and then starts killing some SO processes |
14:17 |
|
nlegrand |
Note: I switch to zebra to import notices, I also have memory issues. Didn't report, because I was importing more than 1 million notices so I felt it was out of scope :). |
14:18 |
|
vfernandes |
with Zebra everything works fine because Zebra is indexed by a cronjob |
14:20 |
|
kidclamp |
importing notices? or importing records? |
14:21 |
|
kidclamp |
I think you mean we need an ES queue like zebraqueue instead of reindex directly, it is true |
14:22 |
|
vfernandes |
update: I think my problem is solved... removing -E development from plack |
14:23 |
|
severine_q |
kidclamp : I think he means 'records' - 'notice' is the french word for 'record' so might be confusing sometimes :) |
14:23 |
|
nlegrand |
kidclamp: records, sorry, notice is french for record :) |
14:23 |
|
kidclamp |
hehe, no worries, blame me for being monolingual |
14:25 |
|
nlegrand |
kidclamp: thou art speaking Czech, art thou not? |
14:26 |
|
* kidclamp |
knows a very few words, nowhere near 'speaking' |
14:28 |
|
oleonard |
Does anyone here use the call number browser plugin for editing items? |
14:29 |
|
oleonard |
It doesn't appear to be working, but I may not know what it's supposed to do. |
14:33 |
|
vfernandes |
well my indexing problem is solved... :) |
14:33 |
|
vfernandes |
removing -E development from plack script solved the problem |
14:47 |
|
severine_q |
tuxayo : i plan to test bz 20623 on biblibre's sandbox #8, but can't reproduce initial bug, do you have a few time ? |
14:48 |
|
reiveune |
bye |
14:48 |
|
|
reiveune left #koha |
14:49 |
|
Joubu |
tuxayo: we had this discussion on koha-devel last year: it is more a migration issue than a bug I'd say |
14:49 |
|
Joubu |
one suggested to add warnings on the about page about data inconsistencies |
14:50 |
|
Joubu |
tuxayo: it's the same as bug 20509 |
14:50 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20509 enhancement, P5 - low, ---, koha-bugs, NEW , Data consistency - authority types |
14:51 |
|
tuxayo |
bug 20623 |
14:51 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20623 minor, P5 - low, ---, victor.grousset, Needs Signoff , PDF export of a basket group fails when an item has an itemtype that is not in the itemtype table |
14:56 |
|
|
talljoy joined #koha |
14:56 |
|
|
TGoat joined #koha |
15:00 |
|
Joubu |
khall: seen the last comment on bug 9302? |
15:00 |
|
wahanui |
I haven't seen 'the', Joubu |
15:00 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9302 new feature, P5 - low, ---, kyle, Passed QA , Add ability to merge patron records |
15:05 |
|
khall |
Joubu: thanks! I hadn't thought of that! |
15:05 |
|
khall |
I'll try to get that patched asap |
15:09 |
|
|
laurence left #koha |
15:17 |
|
|
fridolin left #koha |
15:18 |
|
|
tcohen left #koha |
15:26 |
|
|
dbs joined #koha |
15:28 |
|
|
tcohen1 joined #koha |
15:38 |
|
tcohen |
morning |
15:43 |
|
|
jbeno joined #koha |
15:46 |
|
huginn |
News from kohagit: Bug 19974: (QA follow-up) Do not use bar separator in atomic update <http://git.koha-community.org/[…]5fe5a6da6d02fcb0c> |
15:46 |
|
huginn |
News from kohagit: Bug 20603: Remove ModNote, getcredits and getrefunds from C4::Accounts <http://git.koha-community.org/[…]81feb03e23e270aac> |
15:46 |
|
huginn |
News from kohagit: Bug 19030: Preserve link between order and subscription when editing an order <http://git.koha-community.org/[…]c784afbcbd470e4a0> |
15:46 |
|
huginn |
News from kohagit: Bug 20580: Make create_superlibrarian.pl accept parameters <http://git.koha-community.org/[…]e2cac3d2308cc0a3e> |
15:46 |
|
huginn |
News from kohagit: Bug 20556: Marking ILL request as complete.. <http://git.koha-community.org/[…]8fe5f0aecb320f357> |
15:46 |
|
huginn |
News from kohagit: Bug 19974: Make MarkLostItemsAsReturned multiple <http://git.koha-community.org/[…]c9e10e8663883598f> |
15:46 |
|
huginn |
News from kohagit: Bug 20489: Remove warnings from the interface <http://git.koha-community.org/[…]f317b3ba24a2f64c4> |
15:46 |
|
huginn |
News from kohagit: Bug 20489: Prevent DB user login <http://git.koha-community.org/[…]ddf0e63dee41055bb> |
15:46 |
|
huginn |
News from kohagit: Bug 19974: (QA follow-up) Move lost logic to else branch <http://git.koha-community.org/[…]cfc524382e76d971c> |
15:47 |
|
huginn |
News from kohagit: Bug 19974: Marking an item as 'lost' in additem.pl will not modify the current item <http://git.koha-community.org/[…]b52aabf58afd70a9f> |
15:47 |
|
huginn |
News from kohagit: Bug 18799: XSLTresultsdisplay hides the icons <http://git.koha-community.org/[…]b8be7556b51730631> |
15:47 |
|
huginn |
News from kohagit: Bug 15922: Show authorized value description in staff client search results for lost... <http://git.koha-community.org/[…]1a7fe600c765c4ad9> |
15:57 |
|
tuxayo |
bug 20623 |
15:57 |
|
tuxayo |
Joubu «we had this discussion on koha-devel last year: it is more a migration issue than a bug I'd say one suggested to add warnings on the about page about data inconsistencies» |
15:57 |
|
tuxayo |
Isn't the following totally normal case? |
15:57 |
|
tuxayo |
«using authorized values like ccode to populate the itemtypes of the biblioitems (instead of the itemtype table) can lead to such data.» |
15:57 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20623 minor, P5 - low, ---, victor.grousset, Needs Signoff , PDF export of a basket group fails when an item has an itemtype that is not in the itemtype table |
16:00 |
|
Joubu |
ha, the CCODE stuf... maybe then |
16:02 |
|
tuxayo |
Joubu: So the patch is still functionally (better wording?) acceptable right? |
16:03 |
|
Joubu |
no idea, I do not remember |
16:03 |
|
Joubu |
I though CCODE was for items.ccode |
16:03 |
|
Joubu |
I have trained my brain to forget all the weird things going on around itemtypes |
16:04 |
|
Joubu |
tuxayo: the patch would be acceptable if you can provide a valid test plan :) |
16:05 |
|
Joubu |
deleting the row from the itemtypes table simulates a data migration issue, not a bug |
16:06 |
|
tuxayo |
«I have trained my brain to forget all the weird things going on around itemtypes» |
16:06 |
|
tuxayo |
XD |
16:07 |
|
tuxayo |
Joubu: okay, I'll try. (I have to learn how use Koha then ^^") |
16:08 |
|
khall |
!nick khall_away |
16:08 |
|
AnnaBoten |
Error: You don't have the admin capability. If you think that you should have this capability, be sure that you are identified before trying again. The 'whoami' command can tell you if you're identified. |
16:09 |
|
jajm |
Joubu, just to be sure you have not missed it : installer/data/mysql/atomicupdate/bug_19974.perl still exists in master |
16:11 |
|
Joubu |
erk |
16:11 |
|
Joubu |
I disabled my pre-push hook yesterday... |
16:11 |
|
jajm |
:) |
16:14 |
|
huginn |
News from kohagit: Bug 19974: DBRev 17.12.00.034 <http://git.koha-community.org/[…]97d8a64a6482fd194> |
16:14 |
|
Joubu |
well, it was 035.. |
16:15 |
|
|
dcook_ joined #koha |
16:17 |
|
tcohen |
hi dcook |
16:21 |
|
jenkins |
Project Koha_Master_D8 build #442: SUCCESS in 33 min: https://jenkins.koha-community[…]ha_Master_D8/442/ |
16:21 |
|
jenkins |
* andrew.isherwood: Bug 20556: Marking ILL request as complete.. |
16:21 |
|
jenkins |
* charles: Bug 19974: Marking an item as 'lost' in additem.pl will not modify the |
16:21 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20556 major, P2, ---, andrew.isherwood, Pushed to Master , Marking ILL request as complete results in "Internal server error" |
16:21 |
|
jenkins |
* m.de.rooy: Bug 19974: (QA follow-up) Move lost logic to else branch |
16:21 |
|
jenkins |
* Jonathan Druart: Bug 19974: Make MarkLostItemsAsReturned multiple |
16:21 |
|
jenkins |
* m.de.rooy: Bug 19974: (QA follow-up) Do not use bar separator in atomic update |
16:21 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19974 major, P5 - low, ---, charles.farmer, Pushed to Master , Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) |
16:21 |
|
jenkins |
* Jonathan Druart: Bug 19030: Preserve link between order and subscription when editing an |
16:21 |
|
jenkins |
* Jonathan Druart: Bug 20580: Make create_superlibrarian.pl accept parameters |
16:21 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19030 major, P5 - low, ---, jonathan.druart, Pushed to Master , Link order <-> subscription is lost when an order is edited |
16:21 |
|
jenkins |
* Jonathan Druart: Bug 20489: Prevent DB user login |
16:21 |
|
jenkins |
* Jonathan Druart: Bug 20489: Remove warnings from the interface |
16:21 |
|
jenkins |
* josef.moravec: Bug 20603: Remove ModNote, getcredits and getrefunds from C4::Accounts |
16:21 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20580 normal, P5 - low, ---, jonathan.druart, Pushed to Master , create_superlibrarian.pl should accept parameters |
16:21 |
|
jenkins |
* oleonard: Bug 18799: XSLTresultsdisplay hides the icons |
16:21 |
|
jenkins |
* oleonard: Bug 15922: Show authorized value description in staff client search |
16:21 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20489 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Prevent DB user login |
16:21 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20603 normal, P5 - low, ---, josef.moravec, Pushed to Master , Remove unused subs from C4::Accounts |
16:21 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18799 minor, P5 - low, ---, victor.grousset, Pushed to Master , XSLTresultsdisplay hides the icons |
16:21 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=15922 enhancement, P5 - low, ---, oleonard, Pushed to Master , Show authorized value description in staff client search results for lost, withdrawn, and damaged |
16:27 |
|
|
ashimema_laptop joined #koha |
16:35 |
|
|
DonnaB joined #koha |
16:44 |
|
huginn |
News from kohagit: Bug 9302: Add error message if keeper patron is invalid <http://git.koha-community.org/[…]8333c26be4b57e1ac> |
16:45 |
|
huginn |
News from kohagit: Bug 19873: (QA follow-up) Prevent warnings <http://git.koha-community.org/[…]77d5641f007550ad2> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: Add error messages, correct number of unit tests in subtest 'Test Koha... <http://git.koha-community.org/[…]6840c590ae641769a> |
16:45 |
|
huginn |
News from kohagit: Bug 20619: Remove last occurrences of long gone syspref (opacsmallimage) <http://git.koha-community.org/[…]a4509cef4d8ea5afc> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: Update div classes <http://git.koha-community.org/[…]e5aa2fe843f0689a0> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: Wrap display_names block line with a span tag <http://git.koha-community.org/[…]138c7d9ddcafa48fa> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: Use patron-title.inc <http://git.koha-community.org/[…]05d37de4a7809ea39> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: Add button directing use to keeper's patron record <http://git.koha-community.org/[…]d91daebf9afca44ab> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: Make the patron search show/hide more links work <http://git.koha-community.org/[…]b15a7338ccedab4ac> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: Use new 'edit borrowers' permission <http://git.koha-community.org/[…]d2ed61287d2739156> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: Add aq tables to mapping <http://git.koha-community.org/[…]d0e3b05862ac8833a> |
16:45 |
|
huginn |
News from kohagit: Bug 20047: (follow-up) Retrieve only biblio/authority servers as appropriate <http://git.koha-community.org/[…]30256bbacf77b5a0b> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: (QA follow-up) Consistency follow-up <http://git.koha-community.org/[…]afd4429224fedc859> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: (QA follow-up) Dumper plugin isn't used <http://git.koha-community.org/[…]91b29157567a775dc> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: (QA follow-up) Merge should be a transaction <http://git.koha-community.org/[…]33cb8e091f06766d9> |
16:45 |
|
huginn |
News from kohagit: Bug 20400: Add routing list tab in OPAC <http://git.koha-community.org/[…]098568a864f3fcdfd> |
16:45 |
|
huginn |
News from kohagit: Bug 19873: Add unit tests <http://git.koha-community.org/[…]8df7eee54e1b7d901> |
16:45 |
|
huginn |
News from kohagit: Bug 20047: Add Koha::Z3950Server Oject and use it to get server count <http://git.koha-community.org/[…]d2ca7718502189c87> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: (QA follow-up) Copy merged patrons to deletedborrowers table <http://git.koha-community.org/[…]f6a14d51bc1285680> |
16:45 |
|
huginn |
News from kohagit: Bug 9302: Add ability to merge patron records <http://git.koha-community.org/[…]2ec162405878b0c95> |
16:45 |
|
|
mtompset joined #koha |
16:45 |
|
mtompset |
Greetings, #koha. |
16:47 |
|
Joubu |
oops |
16:47 |
|
Joubu |
not my day... |
16:49 |
|
Joubu |
@later tell cait I am sorry, I completely messed up your patches for bug 20400, I have just pushed them by mistake... |
16:49 |
|
huginn |
Joubu: The operation succeeded. |
16:49 |
|
* Joubu |
hides |
16:54 |
|
jenkins |
Project Koha_Master_D8 build #443: SUCCESS in 33 min: https://jenkins.koha-community[…]ha_Master_D8/443/ |
16:54 |
|
jenkins |
Jonathan Druart: Bug 19974: DBRev 17.12.00.034 |
16:54 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19974 major, P5 - low, ---, charles.farmer, Pushed to Master , Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) |
16:58 |
|
|
severine_q joined #koha |
17:02 |
|
kidclamp |
that's just motivation for quick follow ups |
17:03 |
|
mtompset |
kidclamp, want an easy sign off that will make Joubu happier? bug 20482 :) |
17:03 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20482 trivial, P5 - low, ---, mtompset, Needs Signoff , language_rfc4646_to_iso639: Terminology codes instead of Bibliographic code |
17:08 |
|
huginn |
News from kohagit: Bug 20400: Fix number of tests <http://git.koha-community.org/[…]81c27ebbc1b6dc4bc> |
17:20 |
|
vfernandes |
bye #koha |
17:23 |
|
|
davidnind joined #koha |
17:28 |
|
jenkins |
Project Koha_Master_D8 build #444: UNSTABLE in 33 min: https://jenkins.koha-community[…]ha_Master_D8/444/ |
17:28 |
|
jenkins |
* alex.arnaud: Bug 19873: Ability to search on 0 value |
17:28 |
|
jenkins |
* alex.arnaud: Bug 19873: Add unit tests |
17:28 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19873 normal, P5 - low, ---, alex.arnaud, Pushed to Master , Make it possible to search on value 0 |
17:28 |
|
jenkins |
* julian.maurice: Bug 19873: (QA follow-up) Prevent warnings |
17:28 |
|
jenkins |
* julian.maurice: Bug 20619: Remove last occurrences of long gone syspref (opacsmallimage) |
17:28 |
|
jenkins |
* Nick Clemens: Bug 20047: Add Koha::Z3950Server Oject and use it to get server count |
17:28 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20619 trivial, P5 - low, ---, julian.maurice, Pushed to Master , Remove last occurrences of long gone syspref (opacsmallimage) |
17:28 |
|
jenkins |
* Nick Clemens: Bug 20047: (follow-up) Retrieve only biblio/authority servers as |
17:28 |
|
jenkins |
* kyle: Bug 9302: Add ability to merge patron records |
17:28 |
|
jenkins |
* kyle: Bug 9302: (QA follow-up) Copy merged patrons to deletedborrowers table |
17:28 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20047 enhancement, P5 - low, ---, nick, Pushed to Master , Add Z3950Server Object and use it for getting server count |
17:28 |
|
jenkins |
* kyle: Bug 9302: (QA follow-up) Merge should be a transaction |
17:28 |
|
jenkins |
* kyle: Bug 9302: (QA follow-up) Dumper plugin isn't used |
17:28 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9302 new feature, P5 - low, ---, kyle, Pushed to Master , Add ability to merge patron records |
17:28 |
|
jenkins |
* Tomás Cohen Arazi: Bug 9302: (QA follow-up) Consistency follow-up |
17:28 |
|
jenkins |
* kyle: Bug 9302: Add aq tables to mapping |
17:28 |
|
jenkins |
* kyle: Bug 9302: Use new 'edit borrowers' permission |
17:28 |
|
jenkins |
* kyle: Bug 9302: Make the patron search show/hide more links work |
17:28 |
|
jenkins |
* kyle: Bug 9302: Add button directing use to keeper's patron record |
17:28 |
|
jenkins |
* kyle: Bug 9302: Use patron-title.inc |
17:28 |
|
jenkins |
* kyle: Bug 9302: Wrap display_names block line with a span tag |
17:28 |
|
jenkins |
* kyle: Bug 9302: Update div classes |
17:28 |
|
jenkins |
* kyle: Bug 9302: Add error messages, correct number of unit tests in subtest |
17:28 |
|
jenkins |
* kyle: Bug 9302: Add error message if keeper patron is invalid |
17:28 |
|
jenkins |
* katrin.fischer: Bug 20400: Add routing list tab in OPAC |
17:28 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20400 enhancement, P5 - low, ---, katrin.fischer, Failed QA , Add routing list tab to the patron account in OPAC |
17:30 |
|
|
tcohen joined #koha |
17:47 |
|
tcohen |
Joubu: 'error' vs. 'message' |
17:56 |
|
|
kmlussier joined #koha |
17:57 |
|
Joubu |
tcohen: yes? |
17:59 |
|
tcohen |
Koha::Exceptions::Exception seems to expect ->message |
17:59 |
|
tcohen |
and the exceptions thrown in Koha::Object::Store |
17:59 |
|
tcohen |
pass error => 'blah' |
18:00 |
|
tcohen |
nevermind, I got distracted, will resume my dbugging |
18:01 |
|
jenkins |
Project Koha_Master_D8 build #445: STILL UNSTABLE in 33 min: https://jenkins.koha-community[…]ha_Master_D8/445/ |
18:01 |
|
jenkins |
Jonathan Druart: Bug 20400: Fix number of tests |
18:01 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20400 enhancement, P5 - low, ---, katrin.fischer, Failed QA , Add routing list tab to the patron account in OPAC |
18:12 |
|
Joubu |
liar jenkins |
18:30 |
|
|
cait joined #koha |
18:39 |
|
tcohen |
don't blame poor jenkins |
18:44 |
|
tcohen |
they just do what we ask for |
18:44 |
|
jenkins |
Yippee, build fixed! |
18:44 |
|
wahanui |
o/ '`'`'`'`'`'`'`'`'` |
18:44 |
|
jenkins |
Project Koha_Master_D8 build #446: FIXED in 33 min: https://jenkins.koha-community[…]ha_Master_D8/446/ |
18:51 |
|
tcohen |
Joubu: are you sure we don't need to overload as_string instead of full_message? |
18:51 |
|
Joubu |
tcohen: read the pod |
18:51 |
|
Joubu |
:D |
18:54 |
|
Joubu |
hum, I remember to read "to not overload as_string directly", but I do not find where.. |
18:59 |
|
oleonard |
Bye everyone, happy weekends |
19:06 |
|
* cait |
waves |
19:09 |
|
cait |
anybode still here? |
19:09 |
|
davidnind |
waves back |
19:11 |
|
magnuse |
nope |
19:17 |
|
tcohen |
no |
19:21 |
|
tcohen |
hi cait |
19:23 |
|
cait |
hi tcohen :) |
19:23 |
|
cait |
i got failed! |
19:23 |
|
cait |
and accidentally pushed! |
19:23 |
|
cait |
so confusing :P |
19:25 |
|
tcohen |
cait: it can happen :-D |
19:25 |
|
cait |
hm my devbox has an issue again |
19:25 |
|
cait |
hs that happened to you before? |
19:25 |
|
cait |
it stops responding |
19:30 |
|
Joubu |
halt it? |
19:30 |
|
cait |
trying, but i think it doesn't manage to |
19:31 |
|
cait |
it's been attempting for quite a while onw |
19:31 |
|
cait |
==> jessie: Attempting graceful shutdown of VM... |
19:32 |
|
Joubu |
--force |
19:35 |
|
tcohen |
open the VirtualBox UI |
19:36 |
|
cait |
it finished now |
19:36 |
|
cait |
but it took long |
19:36 |
|
cait |
upping it |
19:37 |
|
cait |
should I throw in a --reload? |
19:37 |
|
cait |
second time it hapepend |
19:40 |
|
cait |
hm not looking good, same happened yesterday |
19:40 |
|
cait |
http://paste.koha-community.org/244 |
19:40 |
|
cait |
i might try a restart |
19:40 |
|
|
kmlussier joined #koha |
19:43 |
|
cait |
virtualbox wants to install an update... letting it do that |
19:46 |
|
cait |
reboot, brb |
19:48 |
|
|
cait joined #koha |
19:48 |
|
cait |
back |
19:48 |
|
cait |
looking better, maybe an ubuntu problem |
19:50 |
|
tcohen |
ubuntu / virtualbox / hardware |
19:50 |
|
tcohen |
it is complicated |
19:50 |
|
tcohen |
:-D |
19:51 |
|
tcohen |
have a nice weekend everyone |
19:52 |
|
cait |
you too |
20:07 |
|
|
DonnaB joined #koha |
21:05 |
|
huginn |
News from kohagit: Bug 20400: (follow-up) Several fixes from RM review <http://git.koha-community.org/[…]696bb097bc06c26f6> |
21:07 |
|
cait |
:) |
21:07 |
|
cait |
confetti° |
21:07 |
|
cait |
confetti! |
21:07 |
|
wahanui |
it has been said that confetti is https://31.media.tumblr.com/f5[…]1tt9lrzo6_250.gif |
21:09 |
|
Joubu |
bye #koha! |
21:10 |
|
cait |
bye Joubu! |
21:10 |
|
cait |
Joubu++ |
21:10 |
|
cait |
#explaining all the things :) |
21:41 |
|
jenkins |
Project Koha_Master_D8 build #447: UNSTABLE in 33 min: https://jenkins.koha-community[…]ha_Master_D8/447/ |
21:41 |
|
jenkins |
katrin.fischer: Bug 20400: (follow-up) Several fixes from RM review |
21:41 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20400 enhancement, P5 - low, ---, katrin.fischer, Pushed to Master , Add routing list tab to the patron account in OPAC |
22:01 |
|
huginn |
News from kohagit: Bug 20400: Fix get_routing_lists tests <http://git.koha-community.org/[…]040eb685ae005606c> |
22:16 |
|
bag |
bug 17047 |
22:16 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17047 new feature, P5 - low, ---, alex.arnaud, Signed Off , Mana Knowledge Base : share data |
22:16 |
|
bag |
:( no PQA on that :( |
22:36 |
|
jenkins |
Yippee, build fixed! |
22:36 |
|
wahanui |
o/ '`'`'`'`'`'`'`'`'` |
22:36 |
|
jenkins |
Project Koha_Master_D8 build #448: FIXED in 33 min: https://jenkins.koha-community[…]ha_Master_D8/448/ |
22:36 |
|
jenkins |
Jonathan Druart: Bug 20400: Fix get_routing_lists tests |
22:36 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20400 enhancement, P5 - low, ---, katrin.fischer, Pushed to Master , Add routing list tab to the patron account in OPAC |
22:46 |
|
|
davidnind joined #koha |
23:19 |
|
|
irma joined #koha |
23:20 |
|
|
BobB joined #koha |
23:20 |
|
|
irma__ joined #koha |