Time |
S |
Nick |
Message |
00:00 |
|
Shane-S |
Anything someone can suggest to confirm a good migration? I am not noticing anything at the moment missing. |
00:00 |
|
|
deb-CSPL joined #koha |
00:00 |
|
wizzyrea |
count of items, count of bibs, count of borrowers |
00:00 |
|
wizzyrea |
on both systems |
00:00 |
|
wizzyrea |
if they match |
00:00 |
|
wizzyrea |
probs ok |
00:02 |
|
Shane-S |
wizzyrea: sounds good thank you and thanks to others earlier |
00:02 |
|
Shane-S |
no I just have to do one more instance. |
00:03 |
|
Shane-S |
if my toddler will go to sleep and let me after her little spill. |
00:03 |
|
|
misilot_ joined #koha |
00:11 |
|
tcohen |
dcook: please read the RFC :-) |
00:35 |
|
|
irma joined #koha |
00:45 |
|
|
irma__ joined #koha |
01:07 |
|
|
misilot_ joined #koha |
01:21 |
|
|
emucla joined #koha |
01:39 |
|
|
misilot_ joined #koha |
01:51 |
|
mtompset |
@seen tcohen |
01:51 |
|
huginn |
mtompset: tcohen was last seen in #koha 1 hour, 39 minutes, and 32 seconds ago: <tcohen> dcook: please read the RFC :-) |
01:51 |
|
mtompset |
I just noticed you comment on bug 20525, tcohen. |
01:51 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20525 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Add --timezone switch to koha-create |
01:51 |
|
mtompset |
^you^your^ |
01:51 |
|
mtompset |
Is that a separate bug or the same one? |
01:53 |
|
|
kellym joined #koha |
01:58 |
|
bag |
hi |
01:58 |
|
mtompset |
Greetings, bag |
01:58 |
|
bag |
heya |
01:58 |
|
bag |
!start |
01:58 |
|
AnnaBoten |
There is already a hunt right now! |
01:58 |
|
bag |
ooh |
01:58 |
|
bag |
!bang |
01:58 |
|
AnnaBoten |
\_x< bag: 1 (642568.51 seconds) |
01:59 |
|
bag |
hahaha |
01:59 |
|
bag |
!stop |
01:59 |
|
AnnaBoten |
[('bag', 1)] |
01:59 |
|
AnnaBoten |
Best time: bag with 642568.51 seconds |
01:59 |
|
AnnaBoten |
Longest time: bag with 642568.51 seconds. This is the new longest time for this channel! (previous longest time was held by nlegrand with 472.17 seconds) |
01:59 |
|
AnnaBoten |
Nothing to stop: there's no hunt right now. |
02:10 |
|
mtompset |
bag, do you know the default passwords for the default patrons in the kohadevbox? |
02:12 |
|
|
misilot_ joined #koha |
02:13 |
|
mtj |
hi mtompset, do you have a bit more info about the plack 'memory leak', you mentioned on ML? |
02:15 |
|
mtompset |
no... it isn't plack memory leak... it's running NOT plack. |
02:16 |
|
mtompset |
It's an Apache memory leak. |
02:17 |
|
mtompset |
I've noticed about 1MB leak per page hit. |
02:17 |
|
mtompset |
Now, given enough time, sometimes it is less. |
02:17 |
|
mtompset |
But unless garbage collection is done, apache generally leaks 1MB per page hit. |
02:17 |
|
mtompset |
default configuration no optimization tweaks. |
02:18 |
|
mtj |
ah, ok .. not plack :) |
02:21 |
|
mtompset |
So 1MB*60*24 ~= 1.4GB leakage, if you hit once every minute. So, you run a 2GB system with no swap, and that's likely to day daily. |
02:21 |
|
mtompset |
^day^die^ |
02:22 |
|
mtompset |
Given the cachey nature of plack, I don't believe the problem is leaking, but rather growing and growing cache. |
02:23 |
|
mtompset |
If you load EVERY page in koha... |
02:23 |
|
mtj |
hmm, i havent spotted that on a prod system i am monitoring |
02:23 |
|
mtompset |
master is 1.1G |
02:24 |
|
mtompset |
I think at that point you would be looking at nastiness with a 2GB system. |
02:25 |
|
mtompset |
I'm sure plack probably does some garbage collection. |
02:25 |
|
tcohen |
mtompset: under plack the are two cache, the same without plack. The l1 cache is cleaned up on each request. And memcached has low memory constraints (64mb is the default). |
02:26 |
|
mtompset |
Was memcache turned on by default in 3.20.x? |
02:26 |
|
mtompset |
(yes, I know, I know) |
02:28 |
|
tcohen |
in cgi mode, I would blame apache, but then, you can control the amount of workers and their life span, so raise the others processes, and lower the amount of requests they live |
02:30 |
|
tcohen |
others == preforked according to Google's keyboard |
02:31 |
|
mtj |
mtompset: curious... how are you measuring the increase? |
02:31 |
|
tcohen |
Silly company, 13 years collecting information about me, and still doesn't know the words I use |
02:32 |
|
tcohen |
Have a good day/night! |
02:39 |
|
mtj |
fwiw, i have a prod system who's apache VmPeak size has increased 450kb in the last 7 days |
02:40 |
|
mtj |
..so it seems apache's size does not grow so much |
02:42 |
|
mtj |
..and it was restarted during that time |
02:43 |
|
wizzyrea |
mtompset: we have *never* seen that problem |
02:43 |
|
wizzyrea |
what OS? |
02:46 |
|
mtj |
if there was a problem where apache grew at 1.4 gig per day, it would be obvious to spot using a tool like munin |
02:53 |
|
mtj |
144760 requests in 60 hours... with 450kb VmPeak increase |
02:55 |
|
mtj |
..with 9 non-plack instances |
03:46 |
|
|
misilot_ joined #koha |
04:21 |
|
|
misilot_ joined #koha |
04:28 |
|
|
indradg_ joined #koha |
05:09 |
|
mtompset |
Jessie. Default apache settings (minimal tweaks). No swap. 2GB ram. half of which is used just too boot and run MySQL and apache initially. |
05:09 |
|
mtompset |
Have a great day (24 hour period)./ |
05:20 |
|
|
phasefx_ joined #koha |
05:21 |
|
|
cait joined #koha |
05:25 |
|
|
misilot_ joined #koha |
05:31 |
|
|
kidclamp_away joined #koha |
05:33 |
|
|
fridolin joined #koha |
05:34 |
|
|
Shane-S joined #koha |
05:36 |
|
|
josef_moravec joined #koha |
05:51 |
|
|
calire joined #koha |
05:57 |
|
|
misilot_ joined #koha |
05:58 |
|
* cait |
waves |
05:59 |
|
josef_moravec |
hi cait |
06:09 |
|
* paxed |
squares |
06:19 |
|
magnuse |
\o/ |
06:25 |
|
cait |
could someone check if they can still specifc a due date in the past? |
06:26 |
|
cait |
hm i think the problem was that the item was withdrawn |
06:26 |
|
cait |
something to check later, works with another item |
06:32 |
|
|
misilot_ joined #koha |
06:34 |
|
cait |
bbiab :) |
06:36 |
|
cait |
GDPR meeting time survey: https://doodle.com/poll/q7s88vqnc5xtf9ev |
06:36 |
|
|
reiveune joined #koha |
06:36 |
|
reiveune |
hello |
06:36 |
|
wahanui |
what's up, reiveune |
06:37 |
|
|
calire1 joined #koha |
06:37 |
|
|
chris_n joined #koha |
06:37 |
|
|
Jesse_ joined #koha |
06:37 |
|
|
Matt[OD] joined #koha |
06:37 |
|
|
irma_ joined #koha |
06:38 |
|
|
paul_p joined #koha |
06:38 |
|
fridolin |
hello |
06:40 |
|
fridolin |
Joubu: hi |
06:40 |
|
fridolin |
you pinged me about Bug 17373 |
06:40 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17373 normal, P5 - low, ---, claire.hernandez, Pushed to Master , Elasticsearch - Authority mappings for UNIMARC |
06:40 |
|
fridolin |
i did write the first patch |
06:41 |
|
|
alex_a joined #koha |
06:41 |
|
alex_a |
bonjour |
06:41 |
|
wahanui |
hello, alex_a |
06:44 |
|
|
pastebot joined #koha |
06:49 |
|
|
laurence joined #koha |
06:57 |
|
|
sophie_m joined #koha |
07:04 |
|
|
misilot_ joined #koha |
07:09 |
|
tuxayo |
hi #koha o/ |
07:12 |
|
tuxayo |
cait: I wonder if Doodle respects user privacy. That would be ironic when using it for a GDPR meeting ^^ |
07:14 |
|
tuxayo |
@tell later clrh Meeting you might want to attend: https://doodle.com/poll/q7s88vqnc5xtf9ev |
07:14 |
|
huginn |
tuxayo: Error: I haven't seen later, I'll let you do the telling. |
07:14 |
|
tuxayo |
Oh |
07:15 |
|
tuxayo |
@tell clrh later Meeting you might want to attend: https://doodle.com/poll/q7s88vqnc5xtf9ev |
07:15 |
|
huginn |
tuxayo: The operation succeeded. |
07:15 |
|
tuxayo |
:D |
07:16 |
|
|
drojf joined #koha |
07:16 |
|
drojf |
hi #koha |
07:19 |
|
clrh |
Thanks tuxayo |
07:20 |
|
tuxayo |
np |
07:20 |
|
tuxayo |
hi drojf |
07:21 |
|
|
cait joined #koha |
07:27 |
|
* cait |
waves |
07:34 |
|
|
gaetan_B joined #koha |
07:34 |
|
gaetan_B |
hello |
07:34 |
|
wahanui |
hi, gaetan_B |
07:36 |
|
|
misilot_ joined #koha |
07:57 |
|
|
alexbuckley joined #koha |
08:10 |
|
|
misilot_ joined #koha |
08:15 |
|
|
alex_a joined #koha |
08:42 |
|
|
misilot_ joined #koha |
08:57 |
|
|
alex_a joined #koha |
08:57 |
|
|
alex_a joined #koha |
09:04 |
|
|
alex_a_ joined #koha |
09:14 |
|
|
misilot_ joined #koha |
09:23 |
|
|
Shane-S joined #koha |
09:28 |
|
|
alex_a joined #koha |
09:44 |
|
|
marcelr joined #koha |
09:44 |
|
|
reiveune left #koha |
09:44 |
|
marcelr |
hi #koha |
09:46 |
|
|
reiveune joined #koha |
09:48 |
|
alex_a |
hello marcelr |
09:51 |
|
marcelr |
o/ |
10:21 |
|
cait |
ashimema: are you back yet? |
10:29 |
|
ashimema |
I am indeed |
10:30 |
|
ashimema |
my dev env is back up and running and I'm furiously working through a pile of ILL related issues I have. |
10:30 |
|
ashimema |
Intending on getting back on board with QA again next week.. though I might grab someone to catch me up fast on what we're looking out for now.. make sure I'm not missing anything obvious that's changed during my little sabatical |
10:31 |
|
ashimema |
How are you cait? |
10:31 |
|
cait |
busy :) |
10:31 |
|
cait |
but otherwise fine :) |
10:31 |
|
ashimema |
haha |
10:31 |
|
ashimema |
that's just the norm isn't it? Busy! |
10:31 |
|
cait |
glad to have you back |
10:31 |
|
cait |
yep, victims of Koha's success ;) |
10:32 |
|
cait |
maybe get in touch with tcohen about state of REST API? they are working on the auth part right now |
10:32 |
|
ashimema |
I have busy, really busy, ** busy and overwhelmed in my 'state of being' repertoire ;) |
10:32 |
|
ashimema |
indeed.. tcohens been mostly keeping me in the loop on the Rest stuff. :) |
10:32 |
|
ashimema |
be nice to properly get back into it though |
10:33 |
|
cait |
cool :) |
10:33 |
|
|
alexbuckley joined #koha |
10:39 |
|
cait |
next meetings? |
10:39 |
|
wahanui |
rumour has it next meetings is https://wiki.koha-community.or[…]Next_IRC_meetings |
10:49 |
|
|
misilot_ joined #koha |
11:00 |
|
|
calire joined #koha |
11:21 |
|
|
misilot_ joined #koha |
11:24 |
|
|
Shane-S joined #koha |
11:27 |
|
|
meliss joined #koha |
11:50 |
|
|
ncbaratta joined #koha |
11:54 |
|
|
misilot_ joined #koha |
11:57 |
|
|
andreashm joined #koha |
11:57 |
|
* andreashm |
waves |
11:59 |
|
|
oleonard joined #koha |
12:00 |
|
* cait |
waves |
12:00 |
|
oleonard |
Hi all |
12:07 |
|
|
kellym joined #koha |
12:15 |
|
|
DonnaB joined #koha |
12:18 |
|
|
Dyrcona joined #koha |
12:27 |
|
|
misilot_ joined #koha |
12:29 |
|
|
gaetan_B joined #koha |
12:29 |
|
|
gaetan_B1 joined #koha |
12:41 |
|
|
kmlussier joined #koha |
12:48 |
|
|
alex_a_ joined #koha |
12:48 |
|
|
andrew joined #koha |
12:54 |
|
tcohen |
morning |
12:59 |
|
* oleonard |
slaps Bug 20534 onto the table |
12:59 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20534 enhancement, P5 - low, ---, oleonard, Needs Signoff , Floating toolbar when editing vendors |
13:06 |
|
Joubu |
Hi #koha |
13:06 |
|
Joubu |
Does anyone remember the state of this support company list? |
13:07 |
|
oleonard |
I don't think any decision has been made about changing the way it works, if that's what you mean Joubu. I think wizzyrea is the one who updates it. |
13:11 |
|
oleonard |
It doesn't look like that latest request conforms to our rules. No real mention of Koha, and a "Koha Academic" logo? |
13:12 |
|
* cait |
cheers for oleonard |
13:13 |
|
cait |
oleonard: eek about the logo |
13:13 |
|
cait |
but thx for the patch :) |
13:13 |
|
Joubu |
that's exactly what I have just replied :) |
13:21 |
|
|
Margaret joined #koha |
13:29 |
|
|
misilot_ joined #koha |
13:35 |
|
|
roch joined #koha |
13:47 |
|
|
mtompset joined #koha |
13:47 |
|
mtompset |
#koha. |
13:47 |
|
roch |
hi |
13:47 |
|
mtompset |
Greetings, #koha roch |
13:48 |
|
mtompset |
Does anyone know the difference between ./etc/koha-conf.xml and ./debian/templates/koha-conf-site.xml.in? |
13:49 |
|
Joubu |
package install vs dev install |
13:49 |
|
mtompset |
So the etc/koha-conf.xml shouldn't be in git then, should it? |
13:50 |
|
Joubu |
why not? |
13:52 |
|
|
Freddy_Enrique joined #koha |
13:52 |
|
Freddy_Enrique |
Good morning people :) |
13:52 |
|
mtompset |
Because you might end up having people only modify one and not the other. |
13:53 |
|
Joubu |
they are not exactly the same |
13:53 |
|
mtompset |
True, but shouldn't the content in terms of tag structure be the same? |
13:55 |
|
Joubu |
I think so, yes |
13:56 |
|
mtompset |
So for example, bug 18909, should it not also add the same thing to the etc one? |
13:56 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18909 minor, P5 - low, ---, kyle, Needs Signoff , Enable the maximum zebra records size to be specified per instance |
14:01 |
|
|
fridolin left #koha |
14:02 |
|
|
misilot_ joined #koha |
14:03 |
|
mtompset |
@seen khall |
14:03 |
|
huginn |
mtompset: khall was last seen in #koha 6 days, 22 hours, 55 minutes, and 19 seconds ago: <khall> Good plan joubu! |
14:04 |
|
mtompset |
Rather quiet, khall. :) |
14:04 |
|
khall |
what's up? |
14:04 |
|
khall |
too true : ) |
14:17 |
|
|
Morohashi joined #koha |
14:18 |
|
Joubu |
@later tell marcelr no need to specify "ES" in bug report titles, there is component "Searching - ES" |
14:18 |
|
huginn |
Joubu: The operation succeeded. |
14:28 |
|
cait |
Joubu: the problem i that the component in the list is cut off |
14:28 |
|
cait |
bugzilla only shows the first few letters there |
14:28 |
|
oleonard |
khall I still can't reproduce Bug 20122, although I find that the "empty" link doesn't actually empty the cart. |
14:28 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20122 normal, P5 - low, ---, oleonard, NEW , Empty and close link on cart page not working (js security) |
14:32 |
|
mtompset |
khall, it was the bug I referenced 18909. You only modified the template koha-conf, not the etc one too. |
14:32 |
|
cait |
bye all, have a nice weekend |
14:32 |
|
|
cait left #koha |
14:32 |
|
Freddy_Enrique |
kidclamp, got a second? :) |
14:34 |
|
|
indradg_ joined #koha |
14:37 |
|
|
rocio joined #koha |
14:38 |
|
Joubu |
oleonard: if you have time, could you take a look at bug 20388 and see if we could improve it or if in your opinion it's enough? |
14:38 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20388 enhancement, P5 - low, ---, alex.arnaud, Signed Off , Elasticsearch - Ability to add search fields from UI |
14:38 |
|
oleonard |
Joubu: Do I need Elasticsearch to be set up in order to test? |
14:39 |
|
Joubu |
oleonard: nope |
14:40 |
|
* oleonard |
looks |
14:47 |
|
Joubu |
kidclamp_lunch:"Also included recompiled version of opac.css that we forgot." |
14:48 |
|
Joubu |
kidclamp_lunch: keep in mind that this kind of changes should be on their own patch, it eases git manips |
14:48 |
|
Joubu |
kidclamp_lunch: git rebase --skip and you regenerate it later, much easier than reset --hard HEAD~1, checkout, rebase |
14:51 |
|
|
calire left #koha |
14:51 |
|
tuxayo |
mtompset: Is this really the output you expected? https://screenshots.firefox.co[…]mOuJL/koha-master |
14:51 |
|
tuxayo |
Step 6 of https://bugs.koha-community.or[…].cgi?id=12310#c62 |
14:51 |
|
tuxayo |
With the default syspref value. |
14:51 |
|
huginn |
Bug 12310: critical, P5 - low, ---, victor.grousset, Needs Signoff , Accept different monetary formats as input |
14:52 |
|
mtompset |
If that is what you have as your syspref, yes. |
14:52 |
|
mtompset |
Frankly, I don't like Free. |
14:53 |
|
mtompset |
The syspref should probably be choice. |
14:53 |
|
tuxayo |
Entering 5,.1 results in 5..1 and the server interprets its as 5.0 |
14:54 |
|
mtompset |
tuxayo, but what is your syspref set to? |
14:54 |
|
tuxayo |
Free? |
14:54 |
|
Joubu |
could be multiple |
14:54 |
|
tuxayo |
Fix proposal: only display the first char of the syspref. I'll amend the patch if you agree. |
14:54 |
|
tuxayo |
Oh, free text in the syspref |
14:54 |
|
mtompset |
Right. |
14:54 |
|
Joubu |
try multiple :) |
14:54 |
|
tuxayo |
anyway, we want to support such a value. Dot and comma |
14:55 |
|
tuxayo |
Dot and comma, the default value. |
14:55 |
|
mtompset |
Multiple? Okay, but then we'd just grab the first one as an example placeholder. |
14:56 |
|
|
misilot_ joined #koha |
14:56 |
|
tuxayo |
+1 for "Multiple?" |
14:56 |
|
tuxayo |
mtompset: okay, I'll amend the patch |
14:56 |
|
Joubu |
git grep multiple **/*.pref |
14:56 |
|
Joubu |
it's a select multiple |
14:57 |
|
Joubu |
search for "OpacAdvSearchMoreOptions" |
14:57 |
|
|
wahanui joined #koha |
14:57 |
|
tuxayo |
okay it was a syspref type |
14:57 |
|
tuxayo |
Will look into that. |
14:58 |
|
mtompset |
My patch was merely to demonstrate I wasn't forcing a hard coded string in what I was talking about, so feel free. :) |
15:00 |
|
reiveune |
bye |
15:00 |
|
|
reiveune left #koha |
15:01 |
|
tuxayo |
mtompset: thanks, indeed having a placeholder is nice :) |
15:01 |
|
Joubu |
tuxayo: I am going to lower the severity of this bug report. Do not take it bad but I do not think it's critical |
15:02 |
|
mtompset |
Though, thinking about it from a translation perspective... |
15:02 |
|
Joubu |
it's more about user education |
15:02 |
|
mtompset |
probably don't need the word Example, just a sample number. |
15:03 |
|
mtompset |
I was tempted to put all my bugs on critical, just to get them looked at. :) |
15:03 |
|
Joubu |
mtompset: nope, sample number will confuse users |
15:03 |
|
mtompset |
So leave Example? |
15:03 |
|
Joubu |
some people are not used of the placehold and will think the value is entered |
15:04 |
|
Joubu |
placeholder* |
15:04 |
|
Joubu |
personally I think it's better, but may be wrong |
15:04 |
|
mtompset |
Valid point. |
15:04 |
|
mtompset |
But it does display greyed out, not as solid as an entered number. |
15:05 |
|
Joubu |
I told you that because I had this problem with a friend few weeks ago ;) |
15:06 |
|
mtompset |
I don't know whether to laugh or cry. Sorry to hear about your experience. :) |
15:09 |
|
tuxayo |
Joubu: truncations or x100 of money values not fixable without leaving traces and the number of our customers having this issue lead to marking this as critical. So critical must be really really bad ^^ |
15:09 |
|
tuxayo |
I'll try to adjust my scale. |
15:10 |
|
tuxayo |
Joubu: as I'm editing the patch. Should I put back a text next to the field instead of the placeholder? |
15:12 |
|
Joubu |
it has been reported in 2014 and it always behaves as it, so does not sound that critical |
15:17 |
|
Joubu |
Can someone confirm git-bz is working correctly? |
15:19 |
|
mtompset |
What do you mean, Joubu? |
15:19 |
|
mtompset |
working correctly how? |
15:19 |
|
tuxayo |
Joubu: indeed, user can tolerate that ^^" |
15:19 |
|
tuxayo |
«as I'm editing the patch. Should I put back a text next to the field instead of the placeholder?» |
15:19 |
|
Joubu |
git bz apply 14242? |
15:19 |
|
tuxayo |
Joubu: yes, I used it less that 20 min ago to apply patches |
15:19 |
|
Joubu |
ok thanks |
15:19 |
|
Joubu |
does not work for me :-/ |
15:19 |
|
mtompset |
which branch? |
15:19 |
|
wahanui |
which branch is HEAD in this statement? |
15:20 |
|
Joubu |
git bz apply does not apply |
15:20 |
|
mtompset |
I had my git bz on apply_on_cascade. |
15:20 |
|
Joubu |
I guess it's the rain... |
15:23 |
|
Joubu |
mtompset: do you have jajm's patches? |
15:26 |
|
|
Shane-S joined #koha |
15:26 |
|
|
laurence left #koha |
15:28 |
|
|
jbeno joined #koha |
15:28 |
|
Freddy_Enrique |
Yo guys |
15:28 |
|
Freddy_Enrique |
yesterday I managed this: https://snag.gy/OBi0DK.jpg |
15:29 |
|
Freddy_Enrique |
thats a good start :). I want get something like this https://snag.gy/4YUlCJ.jpg |
15:30 |
|
Freddy_Enrique |
what file should I concern myself with to accomplish that? |
15:31 |
|
Freddy_Enrique |
also...the right navigation is still there how could I erase it in that pag? |
15:31 |
|
Joubu |
why do not you contact these guys to ask them how they did? |
15:31 |
|
mtompset |
jajm's patches for what? |
15:32 |
|
Freddy_Enrique |
I tried :( |
15:32 |
|
tuxayo |
mtompset: I'm not sure, do we keep the placeholder or a text next to the field. (like the current master but dynamic with the syspref) |
15:32 |
|
mtompset |
tuxayo, throw my patch away, Joubu made a decent case for user confusion. |
15:35 |
|
|
barton|laptop joined #koha |
15:35 |
|
Joubu |
mtompset: I am ok with placeholders, using "Example: 12.34" makes sense |
15:36 |
|
mtompset |
Oh,okay... Then make sure to have "Example: " as a translatable constant somewhere instead of hard coding into the attribute. |
15:38 |
|
tuxayo |
mtompset: Which attribute? It's juste text like that https://gitlab.com/tuxayo/Koha[…]/mancredit.tt#L43 |
15:38 |
|
tuxayo |
With your change to make the separator dynamic |
15:40 |
|
mtompset |
GAH! I hate gitlab. |
15:42 |
|
mtompset |
when I say attribute I mean attribute of the HTML tag. |
15:42 |
|
mtompset |
in this case placeholder. |
15:43 |
|
mtompset |
var MSG_EXAMPLE=_("Example: "); |
15:43 |
|
mtompset |
placeholder=... something that uses MSG_EXAMPLE |
15:43 |
|
mtompset |
I don't know. |
15:43 |
|
mtompset |
So the "Example: " will get translated. |
15:45 |
|
oleonard |
khall: If you can provide any more details about how to reproduce Bug 20122 I would appreciate it. |
15:45 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20122 normal, P5 - low, ---, oleonard, NEW , Empty and close link on cart page not working (js security) |
15:49 |
|
mtompset |
oleonard, easy. |
15:49 |
|
mtompset |
search |
15:49 |
|
mtompset |
add multiple things to cart |
15:49 |
|
tuxayo |
mtompset: «when I say attribute I mean attribute of the HTML tag. in this case placeholder.» |
15:49 |
|
Joubu |
what's wrong with gitlab? |
15:49 |
|
tuxayo |
Oh so we are back to using the placeholder. Until now I mentioned a text next to the field to be corrected in case I was wrong. |
15:49 |
|
mtompset |
Joubu, I have nothing but problems understanding the UI. |
15:49 |
|
tuxayo |
Okay so I need to use JS to make something in an attribute translatable? |
15:50 |
|
mtompset |
tuxayo, maybe. |
15:50 |
|
mtompset |
oleonard, open cart |
15:50 |
|
Joubu |
mtompset: use it and you will understand it quickly :) |
15:50 |
|
mtompset |
see list |
15:50 |
|
mtompset |
empty and close |
15:50 |
|
mtompset |
yes,of course empty. |
15:50 |
|
tuxayo |
So inject it with jQuery on pageload? |
15:50 |
|
mtompset |
looks empty. |
15:50 |
|
mtompset |
is it? click it... just click the 0 items. |
15:50 |
|
mtompset |
list comes back. |
15:51 |
|
mtompset |
my bib_list cookie isn't deleting. |
15:51 |
|
Joubu |
tuxayo: do not make things complicates for (just) a placeholder, nobody really cares I think |
15:52 |
|
mtompset |
Joubu, come on... let's make it beautiful. :) |
15:52 |
|
oleonard |
mtompset: I see that, but I thought from the bug report that some kind of error was being reported. I guess it's just that it doesn't work. |
15:52 |
|
oleonard |
(being reported by the browser that is) |
15:52 |
|
mtompset |
I can't find any errors in my chromium, but I swear there are. |
15:53 |
|
mtompset |
And I tinkered it so the else always ran on the updatebasket... |
15:53 |
|
kidclamp |
oleonard, it looks like on bug 20111 we try to delete the cookie by setting the expiration to before now - it seems to simply then set it to expire with session |
15:53 |
|
mtompset |
And I've had flakiness still. |
15:53 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20111 minor, P5 - low, ---, victor.grousset, Pushed to Master , Patron card creator - some strings are not translatable |
15:53 |
|
kidclamp |
it doesn't delete |
15:53 |
|
kidclamp |
so no error, but view the storage and see that the bib_list cookie doesn't get dleted |
15:54 |
|
oleonard |
Okay I was just confused that I didn't see an error message |
15:54 |
|
tuxayo |
Joubu: Thanks, that's what I was hopping for ^^ |
15:54 |
|
tuxayo |
I'll go with moving the example outside the field. Like the current code. |
15:54 |
|
oleonard |
I have a fix, but it'll have to wait until Monday for the patch |
15:54 |
|
|
talljoy joined #koha |
15:54 |
|
mtompset |
what's the fix? |
15:54 |
|
wahanui |
the fix is usually chocolate. Try that first. |
15:55 |
|
mtompset |
chocolate++ |
15:55 |
|
|
talljoy joined #koha |
15:56 |
|
oleonard |
specify "path=/" and a time in the past for the expiration |
15:57 |
|
oleonard |
Bye all, happy weekend |
15:58 |
|
mtompset |
$.removeCookie works... YAY! |
16:01 |
|
mtompset |
oh... specifying the path explicitly also works. |
16:01 |
|
mtompset |
Less code changes... me like. |
16:08 |
|
kidclamp |
oleonard++ |
16:12 |
|
mtompset |
oops... |
16:13 |
|
mtompset |
forgot to squash. |
16:14 |
|
tuxayo |
mtompset: Can I remove the «run koha qa test tools» step from the test plan of your patch? It will limit who can sign off the bug. And the QAer will do that anyway. |
16:14 |
|
mtompset |
Which bug? |
16:16 |
|
mtompset |
bug 20122 ala oleonard is ready for sign off. |
16:16 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20122 normal, P5 - low, ---, oleonard, Needs Signoff , Empty and close link on cart page not working (js security) |
16:17 |
|
tuxayo |
mtompset: this patch https://bugs.koha-community.or[…].cgi?id=12310#c62 |
16:17 |
|
huginn |
Bug 12310: major, P5 - low, ---, victor.grousset, Needs Signoff , Accept different monetary formats as input |
16:17 |
|
mtompset |
tuxayo, if you are using the kohadevbox, it's easy to do. |
16:17 |
|
mtompset |
kshell |
16:18 |
|
tuxayo |
What about the sandboxes? |
16:18 |
|
mtompset |
/home/vagrant/qa-test-tools/koha-qa.pl -v 2 -c {# of commits} |
16:19 |
|
mtompset |
tuxayo, why use a sandbox, when a kohadevbox is pretty easy to setup (though quite time consuming the first time) |
16:19 |
|
tuxayo |
On this bug I'm counting on some librarians that I met a the hackfest to sign it off ^^ |
16:19 |
|
tuxayo |
And the first patch it already quite long to test. |
16:20 |
|
mtompset |
Oh... well, yes you can skip that last step, but I put it there to make sure people who know better remember to do better. :) |
16:21 |
|
Joubu |
QA tests must not be part of the test plan, it's for the QA step |
16:21 |
|
mtompset |
Joubu, yes, but developers who are not QA should get into the habit of doing it too. |
16:22 |
|
mtompset |
Plus, I only include that step on things which the qa-test-tools checks: TT and perl scripts. |
16:24 |
|
tuxayo |
thanks, I'll will write it as optional |
16:39 |
|
tuxayo |
Thanks mtompset and Joubu for the help! |
16:39 |
|
tuxayo |
bye #koha o/ |
16:44 |
|
|
misilot_ joined #koha |
17:17 |
|
|
misilot_ joined #koha |
17:48 |
|
|
misilot_ joined #koha |
17:53 |
|
huginn |
News from kohagit: Bug 20298: (follow-up) fix labels' for attributes <http://git.koha-community.org/[…]c4ba738fa5c3510d2> |
17:53 |
|
huginn |
News from kohagit: Bug 18816: (QA follow-up) Fix Circulation.t <http://git.koha-community.org/[…]2ab025034a05ecc4b> |
17:53 |
|
huginn |
News from kohagit: Bug 18816: (QA follow-up) Framework parameter is not needed <http://git.koha-community.org/[…]da60be088330f0136> |
17:53 |
|
huginn |
News from kohagit: Bug 20526: Show and sort by date of request in pending discharges table <http://git.koha-community.org/[…]55882a1e4d34c732d> |
17:53 |
|
huginn |
News from kohagit: Bug 20524: Make columns of pending discharges table sortable <http://git.koha-community.org/[…]17aa04a67c1996ac2> |
17:53 |
|
huginn |
News from kohagit: Bug 20446: Fix Edifact quotes processing <http://git.koha-community.org/[…]7f88681c86c7d11b1> |
17:53 |
|
huginn |
News from kohagit: Bug 20181: (QA follow-up) Remove double check <http://git.koha-community.org/[…]b4a33a0d679ee6a6e> |
17:53 |
|
huginn |
News from kohagit: Bug 11512: Update syspref description <http://git.koha-community.org/[…]a9c44a57fde629655> |
17:53 |
|
huginn |
News from kohagit: Bug 18816: (QA follow-up) Add rarely used params to hashref, remove param <http://git.koha-community.org/[…]98bbbcc30deebd8bc> |
17:53 |
|
huginn |
News from kohagit: Bug 18816: (QA follow-up) Convert param to hashref, fix typo <http://git.koha-community.org/[…]b31f60426e086570c> |
17:53 |
|
huginn |
News from kohagit: Bug 20181: Add POD for new plugin <http://git.koha-community.org/[…]458821064412c5f01> |
17:53 |
|
huginn |
News from kohagit: Bug 20181: (follow-up) Ensure test runs <http://git.koha-community.org/[…]897af7335eca6bc13> |
17:53 |
|
huginn |
News from kohagit: Bug 20181: Unit tests <http://git.koha-community.org/[…]3f2ee8f0ff7491a35> |
17:53 |
|
huginn |
News from kohagit: Bug 20181: Allow plugins to add css and javascript to OPAC <http://git.koha-community.org/[…]44047229be9e9f1a8> |
17:53 |
|
huginn |
News from kohagit: Bug 19712: (follow-up) Add missing use Pod::Usage <http://git.koha-community.org/[…]44095b8b845cff7f3> |
17:53 |
|
huginn |
News from kohagit: Bug 19712: Fix test mode for delete_records_via_leader.pl <http://git.koha-community.org/[…]be04eadfd409714b3> |
17:53 |
|
huginn |
News from kohagit: Bug 11512: Forced holds that violate issuing rules will never be filled <http://git.koha-community.org/[…]09811539897647f8f> |
17:53 |
|
huginn |
News from kohagit: Bug 18816: Make CataloguingLog work in production by preventing circulation from... <http://git.koha-community.org/[…]50e0d58d11f7e962b> |
17:56 |
|
|
MauR joined #koha |
17:57 |
|
MauR |
Hello Koha friends. Our institution is going to install a new firewll and i need to specify the port that Koha use to stay active. Please could someone tell me wich port uses koha for z39 client? no as server, that use to be 210... |
17:59 |
|
MauR |
at he momento i kno the ports for mail 587, ssh 22, ldap, web 80 and others, but i do not know wich one for z39 as client |
18:00 |
|
|
ashimema_laptop joined #koha |
18:03 |
|
|
andrew joined #koha |
18:12 |
|
|
ashimema_laptop joined #koha |
18:18 |
|
mtompset |
I believe the port numbers depend on your Z39.50 servers, check out their configurations in the staff client. And if you are running the Z39.50 service for others, that port information should be in your koha-conf.xml file. |
18:18 |
|
jenkins |
Project Koha_17.11_D8 build #36: SUCCESS in 35 min: https://jenkins.koha-community[…]Koha_17.11_D8/36/ |
18:18 |
|
jenkins |
* Jonathan Druart: Bug 20229: Explicitly list the SQL modes we support |
18:18 |
|
jenkins |
* oleonard: Bug 20239: Fix spelling on authority linker plugin |
18:18 |
|
jenkins |
* oleonard: Bug 20240: Remove space before : when searching for a vendor in serials |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20229 major, P5 - low, ---, jonathan.druart, Pushed to Stable , Remove problematic SQL modes |
18:18 |
|
jenkins |
* Nick Clemens: Bug 20140: Allow translating more of OAI sets |
18:18 |
|
jenkins |
* pasi.kallinen: Bug 20147: Allow translating prompt in label edit batch |
18:18 |
|
jenkins |
* pasi.kallinen: Bug 20142: Allow translating offline circ message |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20239 trivial, P5 - low, ---, oleonard, Pushed to Master , Fix spelling on authority linker plugin |
18:18 |
|
jenkins |
* katrin.fischer: Bug 20290: Fix capitalization of "Routling List" |
18:18 |
|
jenkins |
* pasi.kallinen: Bug 20295: Allow translating link title in ILL module |
18:18 |
|
jenkins |
* pasi.kallinen: Bug 20296: Untranslatable "All" in patrons table filter |
18:18 |
|
jenkins |
* pasi.kallinen: Bug 20141: Untranslatable string in transport cost matrix |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20240 trivial, P5 - low, ---, oleonard, Pushed to Stable , Remove space before : when searching for a vendor in serials (Vendor name :) |
18:18 |
|
jenkins |
* pasi.kallinen: Bug 20301: Allow translating "View" in manage MARC import |
18:18 |
|
jenkins |
* pasi.kallinen: Bug 20302: Allow translating Delete button in Patron batch mod tool |
18:18 |
|
jenkins |
* Tomás Cohen Arazi: Bug 20234: Make maintenance scripts use koha-zebra instead of |
18:18 |
|
jenkins |
* Tomás Cohen Arazi: Bug 20234: Update service description in koha-common.init |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20140 trivial, P5 - low, ---, pasi.kallinen, Pushed to Stable , Allow translating more of OAI sets |
18:18 |
|
jenkins |
* Jonathan Druart: Bug 20311: Prevent get_age tests to fail on Feb 28th |
18:18 |
|
jenkins |
* Jonathan Druart: Bug 20286: Correctly escape URI characters in OPAC RSS template |
18:18 |
|
jenkins |
* Jonathan Druart: Bug 20286: Fix filter for BakerTaylor* prefs |
18:18 |
|
jenkins |
* Tomás Cohen Arazi: Bug 17717: Add a --chdir option switch for koha-foreach |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20147 trivial, P5 - low, ---, pasi.kallinen, Pushed to Stable , Allow translating prompt in label edit batch |
18:18 |
|
jenkins |
* Tomás Cohen Arazi: Bug 17717: Make cronjobs using koha-foreach use --chdir |
18:18 |
|
jenkins |
* m.de.rooy: Bug 17717: (QA follow-up) Fix typo chdir |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20142 trivial, P5 - low, ---, pasi.kallinen, Pushed to Stable , Allow translating offline circ message |
18:18 |
|
jenkins |
* kyle: Bug 12812: Longoverdue.pl --mark-returned doesn't return items |
18:18 |
|
jenkins |
* josef.moravec: Bug 12812: (Follow-up) Fix use of C4::Circulation |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20290 trivial, P5 - low, ---, katrin.fischer, Pushed to Stable , Fix capitalization: Routing List |
18:18 |
|
jenkins |
* victor.grousset: Bug 19953: Record page: acquisition details: add column for invoice |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20295 enhancement, P5 - low, ---, pasi.kallinen, Pushed to Stable , Allow translating link title in ILL module |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20296 enhancement, P5 - low, ---, pasi.kallinen, Pushed to Stable , Untranslatable "All" in patrons table filter |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20141 trivial, P5 - low, ---, pasi.kallinen, Pushed to Stable , Untranslatable string in Transport cost matrix |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20301 trivial, P5 - low, ---, pasi.kallinen, Pushed to Stable , Allow translating "View" in manage MARC import |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20302 trivial, P5 - low, ---, pasi.kallinen, Pushed to Stable , Allow translating Delete button in Patron batch mod tool |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20234 normal, P5 - low, ---, tomascohen, Pushed to Stable , Make maintenance scripts use koha-zebra instead of koha-*-zebra |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20311 minor, P5 - low, ---, jonathan.druart, Pushed to Stable , get_age tests can fail on February 28th |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20286 major, P5 - low, ---, jonathan.druart, Pushed to Stable , Subscribing to a search via rss goes to an empty page |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17717 critical, P4, ---, tomascohen, Pushed to Stable , Fix broken cronjobs due to permissions of the current directory |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=12812 major, P5 - low, ---, kyle, Pushed to Stable , Longoverdue.pl --mark-returned doesn't return items |
18:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19953 enhancement, P5 - low, ---, victor.grousset, Pushed to Master , Add column for invoice in acquisition details tab |
18:19 |
|
|
DemolitionQueen joined #koha |
18:20 |
|
|
misilot_ joined #koha |
18:23 |
|
|
Loot joined #koha |
18:30 |
|
jenkins |
Project Koha_Master_D8 build #424: SUCCESS in 37 min: https://jenkins.koha-community[…]ha_Master_D8/424/ |
18:30 |
|
jenkins |
* Jonathan Druart: Bug 20446: Fix Edifact quotes processing |
18:30 |
|
jenkins |
* Jonathan Druart: Bug 19712: Fix test mode for delete_records_via_leader.pl |
18:30 |
|
jenkins |
* mtompset: Bug 19712: (follow-up) Add missing use Pod::Usage |
18:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20446 critical, P5 - low, ---, jonathan.druart, Pushed to Master , QUOTES processing broken by run time error |
18:30 |
|
jenkins |
* kyle: Bug 11512: Forced holds that violate issuing rules will never be filled |
18:30 |
|
jenkins |
* kyle: Bug 11512: Update syspref description |
18:30 |
|
jenkins |
* julian.maurice: Bug 20524: Make columns of pending discharges table sortable |
18:30 |
|
jenkins |
* oleonard: Bug 20526: Show and sort by date of request in pending discharges table |
18:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19712 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Fix command line options of delete_records_via_leader.pl |
18:30 |
|
jenkins |
* kyle: Bug 18816: Make CataloguingLog work in production by preventing |
18:30 |
|
jenkins |
* kyle: Bug 18816: (QA follow-up) Convert param to hashref, fix typo |
18:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11512 normal, P5 - low, ---, kyle, Pushed to Master , Forced holds that violate issuing rules will never be filled |
18:30 |
|
jenkins |
* kyle: Bug 18816: (QA follow-up) Add rarely used params to hashref, remove |
18:30 |
|
jenkins |
* m.de.rooy: Bug 18816: (QA follow-up) Framework parameter is not needed |
18:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20524 enhancement, P5 - low, ---, julian.maurice, Pushed to Master , Make columns of pending discharges table sortable |
18:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20526 enhancement, P5 - low, ---, oleonard, Pushed to Master , Show and sort by date of request in pending discharges table |
18:30 |
|
jenkins |
* m.de.rooy: Bug 18816: (QA follow-up) Fix Circulation.t |
18:30 |
|
jenkins |
* kyle: Bug 20181: Allow plugins to add css and javascript to OPAC |
18:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18816 enhancement, P5 - low, ---, kyle, Pushed to Master , Make CataloguingLog work in production by preventing circulation from spamming the log |
18:30 |
|
jenkins |
* kyle: Bug 20181: Unit tests |
18:30 |
|
jenkins |
* mtompset: Bug 20181: (follow-up) Ensure test runs |
18:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20181 enhancement, P5 - low, ---, kyle, Pushed to Master , Allow plugins to add CSS and Javascript to OPAC |
18:30 |
|
jenkins |
* kyle: Bug 20181: Add POD for new plugin |
18:30 |
|
jenkins |
* kyle: Bug 20181: (QA follow-up) Remove double check |
18:30 |
|
jenkins |
* Jonathan Druart: Bug 20298: (follow-up) fix labels' for attributes |
18:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20298 minor, P5 - low, ---, jonathan.druart, Pushed to Master , Notices template uses same html id for each language |
18:47 |
|
|
Margaret joined #koha |
18:59 |
|
|
jbeno joined #koha |
18:59 |
|
|
jbeno left #koha |
18:59 |
|
|
jbeno joined #koha |
19:15 |
|
|
andrew joined #koha |
19:24 |
|
|
misilot_ joined #koha |
19:32 |
|
|
Shane-S joined #koha |
19:39 |
|
|
Dyrcona joined #koha |
19:39 |
|
|
Stompro joined #koha |
19:39 |
|
tcohen |
@later tell cait do you remember when we voted the orders endpoint RFC we wrote? |
19:39 |
|
huginn |
tcohen: The operation succeeded. |
19:39 |
|
tcohen |
next meetings? |
19:39 |
|
wahanui |
hmmm... next meetings is https://wiki.koha-community.or[…]Next_IRC_meetings |
19:48 |
|
|
CallBackQueen joined #koha |
19:59 |
|
|
misilot_ joined #koha |
21:01 |
|
|
misilot_ joined #koha |
21:12 |
|
|
cait joined #koha |
21:33 |
|
|
misilot_ joined #koha |
22:05 |
|
|
misilot_ joined #koha |
22:37 |
|
|
misilot_ joined #koha |
22:45 |
|
|
irma joined #koha |
23:10 |
|
|
misilot_ joined #koha |
23:34 |
|
|
Shane-S joined #koha |
23:43 |
|
|
misilot_ joined #koha |