| Time |
S |
Nick |
Message |
| 00:03 |
|
|
Francesca joined #koha |
| 00:18 |
|
|
khall joined #koha |
| 00:29 |
|
|
Francesca joined #koha |
| 00:41 |
|
|
irma joined #koha |
| 00:52 |
|
|
Francesca joined #koha |
| 01:20 |
|
|
irmab joined #koha |
| 01:35 |
|
|
Francesca joined #koha |
| 01:51 |
|
|
Francesca joined #koha |
| 03:05 |
|
|
alexbuckley joined #koha |
| 03:05 |
|
|
alexbuckley_ joined #koha |
| 03:26 |
|
|
Francesca joined #koha |
| 03:44 |
|
|
JoshB joined #koha |
| 05:26 |
|
|
talljoy joined #koha |
| 06:26 |
|
|
rocio joined #koha |
| 09:32 |
|
|
Francesca joined #koha |
| 09:36 |
|
|
Francesca joined #koha |
| 10:13 |
|
|
Francesca joined #koha |
| 10:20 |
|
|
deb-CSPL joined #koha |
| 10:44 |
|
|
talljoy joined #koha |
| 11:24 |
|
|
cait joined #koha |
| 12:13 |
|
|
cait1 joined #koha |
| 14:07 |
|
|
cait joined #koha |
| 14:18 |
|
|
dac joined #koha |
| 14:20 |
|
|
Scott-CSPL joined #koha |
| 15:00 |
|
|
NateC joined #koha |
| 15:05 |
|
|
Dyrcona joined #koha |
| 15:55 |
|
|
JoshB joined #koha |
| 16:51 |
|
|
ashimema joined #koha |
| 17:22 |
|
|
JoshB joined #koha |
| 18:24 |
|
|
alexbuckley joined #koha |
| 18:25 |
|
|
alexbuckley_ joined #koha |
| 18:33 |
|
|
CrispyBran joined #koha |
| 19:30 |
|
|
kholt joined #koha |
| 19:35 |
|
CrispyBran |
joubu, are you in? |
| 19:36 |
|
CrispyBran |
cait, are you there? |
| 19:36 |
|
CrispyBran |
Is there anyone here that has written a patch for Koha? |
| 19:52 |
|
cait |
only partially here |
| 19:59 |
|
CrispyBran |
cait, I am trying to figure out how to create a patch. I know how to start a new branch in my kohadevbox, but I don't know what to do next to make changes. |
| 19:59 |
|
CrispyBran |
I can't seem to find any documentation on this particular step. |
| 20:00 |
|
CrispyBran |
Can you point me to anything? |
| 20:02 |
|
cait |
you create the branch |
| 20:02 |
|
cait |
then you start changing the files |
| 20:02 |
|
cait |
git status will show which files you have changed |
| 20:02 |
|
cait |
once you get everything working |
| 20:02 |
|
cait |
you do git add <filename> |
| 20:03 |
|
cait |
git status - they show in green |
| 20:03 |
|
|
alexbuckley joined #koha |
| 20:03 |
|
cait |
then next is a git commit |
| 20:03 |
|
|
alexbuckley_ joined #koha |
| 20:04 |
|
CrispyBran |
where exactly do I go to get to the files? |
| 20:05 |
|
CrispyBran |
Just in the branch itself? |
| 20:14 |
|
CrispyBran |
I think that might be enough to help me make some trouble. Thanks for the push. :) |
| 20:21 |
|
cait |
just the files you se there |
| 20:21 |
|
cait |
nothing special :) |
| 20:22 |
|
CrispyBran |
cait, thank you. I'm anxious about doing this. |
| 20:23 |
|
cait |
the good thing about git is |
| 20:23 |
|
cait |
that it's really hard to break stuff |
| 20:23 |
|
cait |
:) |
| 20:26 |
|
alexbuckley |
Hi cait!. I've sent an email to you about further implementation of onboarding functionality |
| 20:33 |
|
|
JoshB joined #koha |
| 20:34 |
|
|
JoshB joined #koha |
| 20:35 |
|
|
JoshB joined #koha |
| 20:36 |
|
|
JoshB joined #koha |
| 20:37 |
|
|
JoshB joined #koha |
| 20:42 |
|
CrispyBran |
cait, where are the template files (tt) stored? |
| 20:43 |
|
cait |
koha-tmpl |
| 20:47 |
|
CrispyBran |
Found it. Thanks again. |
| 20:53 |
|
|
JoshB joined #koha |
| 21:30 |
|
|
JoshB joined #koha |
| 21:31 |
|
|
JoshB joined #koha |
| 21:32 |
|
|
JoshB joined #koha |
| 21:33 |
|
|
JoshB joined #koha |
| 21:34 |
|
|
JoshB joined #koha |
| 21:34 |
|
|
JoshB joined #koha |
| 21:49 |
|
|
cait joined #koha |
| 22:05 |
|
|
JoshB joined #koha |
| 23:06 |
|
CrispyBran |
wizzyrea, are you online? |
| 23:08 |
|
CrispyBran |
cait, looking at bug 11703, I see modifications to koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js, but when I look in the git tree, the file isn't there. Any ideas? |
| 23:08 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11703 enhancement, P5 - low, ---, kyle, Pushed to Stable , Convert checkouts table to ajax datatable |
| 23:10 |
|
cait |
hm what do you mean by looking in the git tree? |
| 23:11 |
|
cait |
it's an old patch |
| 23:11 |
|
cait |
i don't have the file either - maybe it lives somewhere else now |
| 23:11 |
|
cait |
moved since the initial development you are looking at |
| 23:11 |
|
CrispyBran |
http://git.koha-community.org/[…]36062b60f;hb=HEAD |
| 23:11 |
|
cait |
what are you trying to do? |
| 23:12 |
|
CrispyBran |
I'm looking for the code building the tr under the table header. I found an oddity with the ID for the row. See bug 18211 |
| 23:12 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18211 minor, P5 - low, ---, koha-bugs, NEW , Circulation.pl / Moremember.pl has errors in table row id |
| 23:13 |
|
CrispyBran |
I'm trying to hunt it down and see if there is really an issue |
| 23:14 |
|
CrispyBran |
Any ideas how to find the moved file? I searched bz but didn't see any references to its move. |
| 23:17 |
|
cait |
i'd do it the other way around |
| 23:17 |
|
cait |
start from the file in koha now |
| 23:17 |
|
cait |
the .pl in hte url is usually the template name |
| 23:17 |
|
cait |
look for the includes in the template |
| 23:20 |
|
CrispyBran |
This is what I find: <script type="text/javascript" src="[% interface %]/[% theme %]/js/checkouts.js"></script> |
| 23:20 |
|
CrispyBran |
I'm just not seeing it in the koha.git |
| 23:21 |
|
cait |
hm i see it |
| 23:21 |
|
cait |
are you looking at master? |
| 23:21 |
|
CrispyBran |
ah, wait |
| 23:21 |
|
cait |
ls -l koha-tmpl/intranet-tmpl/prog/js/ |
| 23:21 |
|
CrispyBran |
I found it. This file structure has my head spinning. |
| 23:22 |
|
CrispyBran |
I was looking under en, which was what the patch referred to in the bug. Okay. Thank you. :) |
| 23:26 |
|
CrispyBran |
Hmmm....checked checkouts.js, but apparently the id for the row is not applied there. |
| 23:54 |
|
|
rocio joined #koha |
