| Time |
S |
Nick |
Message |
| 00:08 |
|
wizzycray |
mtompset something about the order of the tests? |
| 00:13 |
|
mtompset |
Perhaps, but what? |
| 00:14 |
|
|
tcohen joined #koha |
| 00:25 |
|
mtompset |
Greetings tcohen |
| 00:27 |
|
* mtompset |
sniffs, "I wish bug 17836 was in master." |
| 00:27 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17836 normal, P5 - low, ---, koha-bugs, Passed QA , (ILSDI) 'charges' always '1' |
| 00:40 |
|
|
aleisha joined #koha |
| 00:47 |
|
|
Gracie joined #koha |
| 00:48 |
|
|
karen_ joined #koha |
| 01:07 |
|
mtompset |
Could someone please look into bug 13113 |
| 01:07 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=13113 enhancement, P5 - low, ---, olli-antti.kivilahti, CLOSED FIXED, Prevent juvenile/children from reserving ageRestricted material |
| 01:07 |
|
mtompset |
the follow up patch from Kyle is not pushed. |
| 01:23 |
|
|
wizzycray joined #koha |
| 01:35 |
|
Gracie |
mtompset, I am trying to reproduce the failures in the bug 17917 and 10 out of the 12 tests pass before the patch is applied |
| 01:35 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17917 major, P5 - low, ---, mtompset, In Discussion , Jenkins tests failing because test suite not logged in user |
| 01:35 |
|
mtompset |
which two fail? |
| 01:36 |
|
mtompset |
because the only two I am aware of are check_sysprefs.t and Reserves.t |
| 01:36 |
|
Gracie |
the IssueSlip.t and Reserves.t |
| 01:36 |
|
mtompset |
IssueSlip? |
| 01:36 |
|
mtompset |
Hmmm.... |
| 01:36 |
|
Gracie |
Members/IssueSlip.t |
| 01:37 |
|
Gracie |
The rest pass before the patch is applied and aren't they supposed to fail? |
| 01:38 |
|
pastebot |
"rangi" at 127.0.0.1 pasted "bug 13113" (8 lines) at http://paste.koha-community.org/272 |
| 01:38 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=13113 enhancement, P5 - low, ---, olli-antti.kivilahti, CLOSED FIXED, Prevent juvenile/children from reserving ageRestricted material |
| 01:39 |
|
rangi |
mtompset: ^^ the followup is in master |
| 01:39 |
|
mtompset |
Let me recheck... |
| 01:40 |
|
rangi |
git show 4f4eb9852387a016d8a04f9c5b37f7ffc711da2e |
| 01:40 |
|
rangi |
there it is |
| 01:41 |
|
mtompset |
So it is... then why is the tag empty when it fails? :( |
| 01:41 |
|
mtompset |
Back to the debugging board. |
| 01:42 |
|
mtompset |
I must need more sleep. |
| 01:42 |
|
rangi |
you might want to just quickly reply your email :) |
| 01:45 |
|
mtompset |
Did that. |
| 01:46 |
|
mtompset |
Gracie: 17917 -- all patched files may or may not fail before this patch, most likely fail. |
| 01:46 |
|
mtompset |
All patched files should pass after. |
| 01:46 |
|
mtompset |
granted I'm doing it as a prove t/db_dependent run generally, and it seems like that seems to make a difference in some cases. |
| 01:46 |
|
|
Francesca joined #koha |
| 01:47 |
|
Gracie |
So the fact that most have passed before the patch is ok? |
| 01:47 |
|
mtompset |
Yes, because the problem which was part of the trigger was patched by Joubu for bug 6782. |
| 01:47 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=6782 enhancement, P5 - low, ---, meenakshi.r, Pushed to Master , Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) |
| 01:47 |
|
Gracie |
Ok |
| 01:47 |
|
Gracie |
Thank you |
| 01:48 |
|
mtompset |
Now, let's see if I replied on that bug... |
| 01:50 |
|
mtompset |
bug 19720 |
| 01:50 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19720 could not be retrieved: InvalidBugId |
| 01:50 |
|
mtompset |
bug 17920 |
| 01:50 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17920 normal, P5 - low, ---, mtompset, Passed QA , t/db_dependent/Sitemapper.t fails because of permissions |
| 01:51 |
|
mtompset |
Gracie: if you do: $ sudo koha-shell -c "prove t/db_dependent" kohadev |
| 01:52 |
|
Gracie |
I've done that |
| 01:52 |
|
mtompset |
and note the one's that fail, you may find that specifying the individual test passes. |
| 01:52 |
|
mtompset |
that's what I meant by a t/db_dependent run. |
| 01:52 |
|
mtompset |
I'm tired. I'm going to stop coding, lest more harm than benefit happen. |
| 01:53 |
|
mtompset |
bug 17934 |
| 01:53 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17934 enhancement, P5 - low, ---, mtompset, Needs Signoff , Various issues with auth_values_input_www.t |
| 01:53 |
|
mtompset |
Have a good day (24 hour period), #koha. |
| 01:54 |
|
rangi |
caitling: https://cards-dev.twitter.com/validator |
| 02:49 |
|
|
Francesca joined #koha |
| 02:52 |
|
|
jamesb_ joined #koha |
| 02:55 |
|
BobB |
rangi +1 |
| 02:57 |
|
wizzycray |
rangi++ |
| 02:58 |
|
wizzycray |
what is it with the entitled eggs on the list lately |
| 02:59 |
|
rangi |
heh dunno, but it would be nice if they stoppped :) |
| 03:08 |
|
wizzycray |
sure would |
| 06:59 |
|
* magnuse |
waves |
| 07:03 |
|
magnuse |
@wunder enbo |
| 07:03 |
|
huginn |
magnuse: The current temperature in Bodo, Norway is 2.0°C (7:50 AM CET on January 19, 2017). Conditions: Light Rain Showers. Humidity: 87%. Dew Point: 0.0°C. Windchill: -6.0°C. Pressure: 29.42 in 996 hPa (Steady). |
| 07:03 |
|
|
LibraryClaire joined #koha |
| 07:04 |
|
LibraryClaire |
morning #koha |
| 07:05 |
|
|
laurence joined #koha |
| 07:17 |
|
|
cait joined #koha |
| 07:30 |
|
magnuse |
guten morgen BüchereiKlara! |
| 07:32 |
|
LibraryClaire |
guten morgen magnuse |
| 07:33 |
|
LibraryClaire |
@wunder konstanz |
| 07:33 |
|
huginn |
LibraryClaire: The current temperature in Mainaustraße, Konstanz, Germany is -3.3°C (8:30 AM CET on January 19, 2017). Conditions: Overcast. Humidity: 78%. Dew Point: -7.0°C. Windchill: -3.0°C. Pressure: 30.45 in 1031 hPa (Steady). |
| 07:41 |
|
|
reiveune joined #koha |
| 07:42 |
|
reiveune |
hello |
| 07:42 |
|
wahanui |
hey, reiveune |
| 07:42 |
|
LibraryClaire |
hi reiveune |
| 07:49 |
|
|
alex_a joined #koha |
| 07:50 |
|
alex_a |
bonjour |
| 07:50 |
|
|
AndrewIsh joined #koha |
| 07:53 |
|
|
fridolin joined #koha |
| 07:56 |
|
fridolin |
hie there |
| 07:56 |
|
LibraryClaire |
bonjour alex_a |
| 07:56 |
|
LibraryClaire |
hi fridolin |
| 07:58 |
|
Joubu |
This David on the ML is quite funny |
| 07:59 |
|
Joubu |
I think he reached my short "do no longer reply to this guys" list |
| 07:59 |
|
|
gaetan_B joined #koha |
| 08:00 |
|
gaetan_B |
hello |
| 08:00 |
|
fridolin |
hie tehre |
| 08:02 |
|
Joubu |
gaetan_B: seen bug 17762? It may interest you :) |
| 08:02 |
|
wahanui |
I haven't seen 'bug', Joubu |
| 08:02 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17762 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Ability to translate notices |
| 08:03 |
|
|
marcelr joined #koha |
| 08:03 |
|
marcelr |
hi #koha |
| 08:03 |
|
gaetan_B |
ah nice :) |
| 08:04 |
|
Joubu |
nice? Awesome you meant? |
| 08:05 |
|
gaetan_B |
yes indeed :D |
| 08:05 |
|
gaetan_B |
now |
| 08:05 |
|
gaetan_B |
to do this on authorised values and everywhere :D |
| 08:15 |
|
|
Francesca joined #koha |
| 08:22 |
|
|
d_antonakis joined #koha |
| 08:23 |
|
magnuse |
Joubu++ |
| 08:36 |
|
|
paul_p joined #koha |
| 08:48 |
|
Joubu |
alex_a: will you be able to rebase bug 17615 quickly? |
| 08:48 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17615 critical, P5 - low, ---, alex.arnaud, Patch doesn't apply , LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data |
| 08:50 |
|
alex_a |
Joubu: Yes i can |
| 08:50 |
|
alex_a |
going to do that today |
| 08:52 |
|
Joubu |
thx |
| 08:57 |
|
|
sameeenz joined #koha |
| 08:57 |
|
AndrewIsh |
goood morning #koha |
| 08:57 |
|
marcelr |
hi AndrewIsh |
| 08:58 |
|
sameeenz |
Sup fam? |
| 08:58 |
|
AndrewIsh |
hi marcelr |
| 08:58 |
|
* AndrewIsh |
realised he's been lurking for too long and should say "hi" once in a while... |
| 08:58 |
|
sameeenz |
hi! |
| 08:58 |
|
AndrewIsh |
hi sameeenz |
| 08:58 |
|
sameeenz |
Irc is all about the lurking. |
| 08:58 |
|
AndrewIsh |
indeed |
| 08:59 |
|
sameeenz |
mmm, quite. |
| 08:59 |
|
AndrewIsh |
@wunder machynlleth |
| 08:59 |
|
huginn |
AndrewIsh: The current temperature in Machynlleth, Machynlleth, United Kingdom is 7.0°C (8:59 AM GMT on January 19, 2017). Conditions: . Humidity: 94%. Dew Point: 6.0°C. Windchill: 7.0°C. Pressure: 30.63 in 1037.1 hPa (Steady). |
| 08:59 |
|
sameeenz |
#just1996things |
| 08:59 |
|
sameeenz |
take me back to a time when disappointment moved slower. |
| 09:00 |
|
sameeenz |
mind you, I was 9 - so probably not the best gauge of human expectation at that stage in life. |
| 09:03 |
|
sameeenz |
I have made a faustian bargain with apple cider to get me through this Children's lit paper. Wish me luck. |
| 09:03 |
|
|
d_antonakis joined #koha |
| 09:03 |
|
|
reiveune joined #koha |
| 09:03 |
|
|
LibraryClaire joined #koha |
| 09:03 |
|
|
liw joined #koha |
| 09:03 |
|
|
Joubu joined #koha |
| 09:03 |
|
|
jajm joined #koha |
| 09:05 |
|
* LibraryClaire |
feels dizzy |
| 09:06 |
|
fridolin |
Joubu: hie, yesterday we found a dirty bug corrected in Bug 10612 |
| 09:06 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10612 enhancement, P5 - low, ---, nick, Pushed to Master , Add ability to delete patrons with batch patron deletion tool |
| 09:06 |
|
fridolin |
its the patch (QA followup) that corrects this bug, independantly from the other patches |
| 09:07 |
|
fridolin |
thing is I think it should be corrected in stable branches |
| 09:07 |
|
fridolin |
Joubu: could I have you opinion on that if you have time |
| 09:07 |
|
fridolin |
with this bug one can erase all borrowers ;D |
| 09:08 |
|
Joubu |
which one? |
| 09:08 |
|
wahanui |
which one is t? |
| 09:08 |
|
Joubu |
Rename not_borrowered_since to not_borrowed_sinceJ |
| 09:08 |
|
Joubu |
? |
| 09:09 |
|
|
cait joined #koha |
| 09:12 |
|
Joubu |
fridolin: ? |
| 09:13 |
|
Joubu |
anyway, if you want it in previous branch yes, it's better to open a new bug report, move the patch and inform that it's for branches <= ?? |
| 09:14 |
|
fridolin |
Joubu: yep ok. in fact Rename not_borrowered_since to not_borrowed_since |
| 09:15 |
|
fridolin |
in clearborrowers.pl the TT has "not_borrowed_since" but pl reads from "not_borrowered_since" |
| 09:15 |
|
fridolin |
so if you set a date it is not used, and page proposes to delete nearly all borrowers :D |
| 09:15 |
|
fridolin |
dirty hein ? |
| 09:17 |
|
fridolin |
Joubu: aahhh but its in 16.11 and 16.05 so in stable and oldstable |
| 09:17 |
|
fridolin |
I think its anought |
| 09:17 |
|
fridolin |
thanks for your help |
| 09:18 |
|
Joubu |
3.22.x is still maintained |
| 09:28 |
|
|
alex_a joined #koha |
| 09:30 |
|
Joubu |
fridolin: if you do not plan to move the patch to its own bug report, you should at least ping the 3.22 Rmaint |
| 09:31 |
|
fridolin |
Joubu: yep indeeded |
| 09:32 |
|
fridolin |
Joubu: do you think he can integrate only the QA followup ? |
| 09:32 |
|
Joubu |
if he is confident with it |
| 09:34 |
|
fridolin |
k |
| 10:00 |
|
|
laurence left #koha |
| 10:09 |
|
kidclamp_away |
Joubu let me know if you want me to retest the IP restriction |
| 10:10 |
|
Joubu |
kidclamp: I will |
| 10:31 |
|
Joubu |
kidclamp: haha yes indeed! |
| 10:34 |
|
* Joubu |
wonders if this has ever worked.. |
| 10:35 |
|
kidclamp |
heh, no one ever complained though |
| 10:43 |
|
Joubu |
Should not we remove the feature? |
| 10:43 |
|
* Joubu |
is lost in C4::Auth |
| 10:45 |
|
kidclamp |
22 listed as enabling it on hea |
| 10:45 |
|
kidclamp |
I think we need to fix it if we can |
| 10:48 |
|
Joubu |
sounds like nobody should use this feature |
| 10:49 |
|
Joubu |
kidclamp: the pref on does not mean that branches.branchip is filled ;) |
| 10:49 |
|
kidclamp |
true, but is a good hint maybe? |
| 10:52 |
|
Joubu |
I am worried about patching C4::Auth and introducing regressions... |
| 10:52 |
|
Joubu |
but I have a patch |
| 10:56 |
|
kidclamp |
yeah, we can only do our best to avoid them - tests and testing |
| 10:59 |
|
|
drojf joined #koha |
| 10:59 |
|
drojf |
hi #koha |
| 10:59 |
|
kidclamp |
hi drojf |
| 10:59 |
|
drojf |
hi kidclamp |
| 11:00 |
|
drojf |
@wunder berlin, germany |
| 11:00 |
|
huginn |
drojf: The current temperature in Aprikosensteig, Berlin, Germany is -1.8°C (11:58 AM CET on January 19, 2017). Conditions: Mostly Cloudy. Humidity: 88%. Dew Point: -3.0°C. Windchill: -2.0°C. Pressure: 30.69 in 1039 hPa (Steady). |
| 11:02 |
|
LibraryClaire |
hi drojf |
| 11:02 |
|
drojf |
hi LibraryClaire |
| 11:19 |
|
huginn |
New commit(s) kohagit: Bug 17894 - Remove and replace WriteOffFee <http://git.koha-community.org/[…]01872999a70628585> / Bug 17894 - Add unit tests <http://git.koha-community.org/[…]6e184202214cd0809> / Bug 17894 - Update pay() and use it internally for WriteOffFee <http://git.koha-community.org/[…]iff;h=c718ad63752 |
| 11:21 |
|
marcelr |
Joubu: I can apply bug 17487 to master, you QAed it in October; it is still in PQA, probably because the version is set to 16.05. Could you confirm ? |
| 11:21 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17487 trivial, P5 - low, ---, rbit, Passed QA , Improper placement of select/clear all in Z39.50/SRU search dialog |
| 11:22 |
|
cait |
Joubu, kidclamp: could you do a bit of QA today to help get one patch for each academy student pushed? https://wiki.koha-community.or[…]t_Academy#Summary |
| 11:22 |
|
Joubu |
marcelr: Confirm what? :) |
| 11:22 |
|
marcelr |
if it should be in master too |
| 11:23 |
|
Joubu |
yes looks like it should |
| 11:23 |
|
marcelr |
ok will change it |
| 11:23 |
|
kidclamp |
will do cait |
| 11:24 |
|
cait |
ah, marcelr, you too maybe? they are mostly small ones |
| 11:24 |
|
cait |
it would be cool if they could finish with a patch in Koha tonight |
| 11:24 |
|
marcelr |
cait: tomorrow morning |
| 11:24 |
|
cait |
it's the last day |
| 11:24 |
|
marcelr |
oh sorry |
| 11:24 |
|
|
alex_a_ joined #koha |
| 11:25 |
|
Joubu |
yes will do |
| 11:25 |
|
cait |
I mean academy ends tonight - so it woudl be nice if we could make it happen today, maybe one for each at least |
| 11:26 |
|
kidclamp |
I will start on Zoe's |
| 11:28 |
|
Joubu |
cannot attach patches to bz :-( |
| 11:29 |
|
huginn |
New commit(s) kohagit: Bug 17777: koha-remove should deal with temporary uploads <http://git.koha-community.org/[…]e6ecdb749235456a4> |
| 11:29 |
|
cait |
Joubu: broken git bz? |
| 11:29 |
|
Joubu |
no idea what's happening |
| 11:30 |
|
Joubu |
I guess it's just me, but everything else is working ok |
| 11:39 |
|
Joubu |
ashimema: Hi! I'd like you to have a look at the last patch of bug 9569 |
| 11:39 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9569 is not accessible. |
| 11:47 |
|
|
andreashm joined #koha |
| 11:48 |
|
* andreashm |
waves |
| 11:50 |
|
|
jzairo joined #koha |
| 11:50 |
|
huginn |
New commit(s) kohagit: Bug 17771 [QA Followup] - Tidy table html <http://git.koha-community.org/[…]72ad808940968f81a> / Bug 17771: Add link to bibliographic record on spent/ordered lists in acquisitions <http://git.koha-community.org/[…]3c214777672dbcb74> / Bug 17784 Ability to see funds with an amount of 0.00 when doing a new <http://git.k |
| 11:51 |
|
drojf |
hi andreashm |
| 11:51 |
|
andreashm |
hi drojf |
| 11:51 |
|
Joubu |
khall: erk, just QAed the same as you |
| 11:51 |
|
khall |
yep ; ) |
| 11:51 |
|
Joubu |
khall: I had also a followup |
| 11:51 |
|
khall |
all fixed up, I caught your followup |
| 11:52 |
|
Joubu |
resending it |
| 11:52 |
|
khall |
Joubu: I'll be looking at 17771, 5784, 17823, 17886, and 17731 |
| 11:52 |
|
khall |
Joubu: ping me for any academy work you pqa on so I can push it asap |
| 11:52 |
|
Joubu |
ok, starting from the bottom |
| 11:53 |
|
Joubu |
and removed yours |
| 12:01 |
|
huginn |
New commit(s) kohagit: Bug 17771: aqorders.biblionumber was already part of the query <http://git.koha-community.org/[…]c63c366dc7294816e> |
| 12:11 |
|
huginn |
New commit(s) kohagit: Bug 17823: Add label for MARC 583 - Action note <http://git.koha-community.org/[…]3a3e6dd60470b06b1> / Bug 17924 - Fix error in password recovery <http://git.koha-community.org/[…]6f0bf0b3d39b4af7d> / Bug 5784 [QA Followup] - Move link to breadcrumbs <http://git.koha-community.org/[…]=commitdiff;h=17d |
| 12:11 |
|
cait |
khall++ Joubu++ |
| 12:11 |
|
marcelr |
khall++ Joubu++ cait++ |
| 12:13 |
|
cait |
marcelr++ too :) |
| 12:13 |
|
cait |
have to leave soon, thx all! |
| 12:17 |
|
Joubu |
khall: bug 17931 and bug 17891 are ready |
| 12:17 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17931 trivial, P5 - low, ---, m.de.rooy, Passed QA , Remove unused vars from reserves_stats.pl |
| 12:17 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17891 trivial, P5 - low, ---, crazy.mental.onion, Passed QA , typo in housebound.tt div tag |
| 12:17 |
|
Joubu |
I failed 2 :-/ |
| 12:20 |
|
cait |
hm it happens |
| 12:20 |
|
cait |
i notice the name is wrong in bug 17891 |
| 12:20 |
|
cait |
but we could fix that |
| 12:20 |
|
cait |
maybe khall can? |
| 12:21 |
|
cait |
why was https://bugs.koha-community.or[…]ment.cgi?id=59184 wrong? |
| 12:21 |
|
cait |
maybe we could push 17886 and fix the opac separately? |
| 12:22 |
|
cait |
have to run, good luck - hope there is a good patch for all |
| 12:22 |
|
Joubu |
cait: because it should have removed the div |
| 12:22 |
|
Joubu |
no need to have 2 commits to remove 1 line |
| 12:23 |
|
|
josef_moravec joined #koha |
| 12:24 |
|
Joubu |
cait: will fix the commit msg |
| 12:42 |
|
|
oleonard joined #koha |
| 12:42 |
|
magnuse |
what's that debian package that is nice to have when you want to install perl xs modules? it gives you make, gcc etc |
| 12:44 |
|
magnuse |
ah build-essential |
| 12:48 |
|
|
meliss joined #koha |
| 12:50 |
|
oleonard |
Hi all |
| 12:50 |
|
marcelr |
hi oleonard |
| 12:50 |
|
wahanui |
hi oleopard |
| 12:51 |
|
huginn |
New commit(s) kohagit: Bug 17931: Remove unused vars from reserves_stats <http://git.koha-community.org/[…]b8e991719edf45af4> / Bug 17891: Remove extra div tag in the housebound module <http://git.koha-community.org/[…]616c3b8cf5fa7e4c9> |
| 13:07 |
|
|
alex_a joined #koha |
| 13:07 |
|
jenkins |
Project Koha_Master_D8 build #94: STILL UNSTABLE in 1 hr 39 min: https://jenkins.koha-community[…]oha_Master_D8/94/ |
| 13:07 |
|
jenkins |
* kyle: Bug 17894 - Update pay() and use it internally for WriteOffFee |
| 13:07 |
|
jenkins |
* kyle: Bug 17894 - Add unit tests |
| 13:07 |
|
jenkins |
* kyle: Bug 17894 - Remove and replace WriteOffFee |
| 13:07 |
|
jenkins |
* kyle: Bug 17777: koha-remove should deal with temporary uploads |
| 13:07 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17894 enhancement, P5 - low, ---, kyle, RESOLVED FIXED, Remove and Replace WriteOffFee |
| 13:07 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17777 normal, P5 - low, ---, m.de.rooy, Pushed to Master , koha-remove should deal with temporary uploads |
| 13:08 |
|
drojf |
so facet links break if there is a "/" inside? :( |
| 13:11 |
|
|
kmlussier joined #koha |
| 13:13 |
|
huginn |
New commit(s) kohagit: Bug 17731: Remove noxml option from rebuild_zebra.pl <http://git.koha-community.org/[…]7654ff0d7de939aa6> |
| 13:24 |
|
edveal |
Good morning |
| 13:24 |
|
wahanui |
the only good morning is a dead one |
| 13:24 |
|
Joubu |
oleonard: I need your advise on https://bugs.koha-community.or[…]ment.cgi?id=59178 |
| 13:25 |
|
marcelr |
hi edveal , wahanui is always so nice |
| 13:25 |
|
Joubu |
I'd suggest not to display "subscription[s]", we already have "Number of subscriptions:" |
| 13:25 |
|
Joubu |
Number of subscriptions: 5 subscriptions # does not sound correct |
| 13:25 |
|
oleonard |
I agree |
| 13:25 |
|
Joubu |
ok thx |
| 13:29 |
|
Joubu |
khall: bug 17691 is ready as well |
| 13:29 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17691 enhancement, P5 - low, ---, grace.mcky, Passed QA , Add serial subscriptions info on vendor profile page |
| 13:30 |
|
khall |
thanks! |
| 13:31 |
|
|
edveal1 joined #koha |
| 13:32 |
|
|
josef_moravec left #koha |
| 13:34 |
|
Joubu |
khall: same for bug 17469 |
| 13:34 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17469 normal, P5 - low, ---, caitlingoodger.student, Passed QA , fr-CA web installer is missing some sample notices |
| 13:35 |
|
khall |
excellent! |
| 13:36 |
|
Joubu |
"Koha does not want to start"? # ML |
| 13:37 |
|
|
mtompset joined #koha |
| 13:37 |
|
mtompset |
Greetings, @koha |
| 13:37 |
|
mtompset |
@seen Joubu |
| 13:37 |
|
huginn |
mtompset: Joubu was last seen in #koha 1 minute and 34 seconds ago: <Joubu> "Koha does not want to start"? # ML |
| 13:37 |
|
marcelr |
hello mtompset |
| 13:38 |
|
mtompset |
Greetings, marcelr Joubu |
| 13:38 |
|
Joubu |
hi |
| 13:39 |
|
mtompset |
Joubu: regarding bug 17469, I notice that there are IGNOREs missing. Did you empty the table first? |
| 13:39 |
|
Joubu |
khall: It seems that they all have at least 1 patch pushed \o/ |
| 13:39 |
|
Joubu |
mtompset: I fixed it few minutes ago |
| 13:39 |
|
Joubu |
it was a syntax issue |
| 13:40 |
|
marcelr |
khall: we also have a new developer on bug 7143 (Rebecca ..) |
| 13:40 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7143 trivial, P5 - low, ---, koha-bugs, Passed QA , Bug for tracking changes to the about page |
| 13:40 |
|
mtompset |
Okay great. |
| 13:40 |
|
mtompset |
Now to slothfully move to the next... |
| 13:40 |
|
drojf |
so making the db upgrade to remove marcxml obviously breaks the db for all things pre master. would have been bright to think about that before i did it |
| 13:41 |
|
marcelr |
drojf: but you always backup, do you :) |
| 13:41 |
|
mtompset |
Did you backup? ;) |
| 13:41 |
|
* mtompset |
grins at marcelr |
| 13:41 |
|
drojf |
the dev thing? nope |
| 13:42 |
|
drojf |
well yes, its in the allthings backup, but not the db itself |
| 13:42 |
|
drojf |
but then its easier to create a new instance |
| 13:42 |
|
marcelr |
drojf: it makes sense to regularly cleanup data in master |
| 13:42 |
|
marcelr |
this is a good refresh :) |
| 13:42 |
|
drojf |
marcelr: then i guess today is the day :P |
| 13:43 |
|
huginn |
New commit(s) kohagit: Bug 7143: [QA Follow-up] Handling tabs <http://git.koha-community.org/[…]394c2ff1dae0113c5> / Bug 7143: [QA Follow-up] Correcting dates for first patch pushed <http://git.koha-community.org/[…]397d04fde0d8e37e2> / Bug 7143: Update about.tt with new devs <http://git.koha-community.org/[…]t;a=commitdiff;h= |
| 13:44 |
|
marcelr |
khall: the new developers are already out of date again ;) |
| 13:44 |
|
Joubu |
for dev install, I use the do_all_what_you_can_do.pl script from the koha-misc4dev repo |
| 13:44 |
|
marcelr |
great name Joubu |
| 13:44 |
|
khall |
heh |
| 13:44 |
|
Joubu |
it explodes and recreate everything with data |
| 13:45 |
|
Joubu |
which is good is that it takes care of the schema changes |
| 13:45 |
|
Joubu |
so git checkout master; reset_my_db (which is an alias) |
| 13:45 |
|
Joubu |
and git checkout 3.22; reset_my_db |
| 13:45 |
|
Joubu |
and it will work in both case, with the same data |
| 13:46 |
|
Joubu |
of course you lost everything from the DB. But the goal is to insert more data, with specific cases |
| 13:46 |
|
Joubu |
#TODO LATER |
| 13:46 |
|
|
nengard joined #koha |
| 13:46 |
|
Joubu |
really, it's just awesome :) |
| 13:46 |
|
drojf |
yes i don't care about the old data, just about the workiung db ;) |
| 13:46 |
|
marcelr |
Joubu: still i would be nice to upstream (some of) these scripts from misc4dev |
| 13:47 |
|
marcelr |
i => it |
| 13:47 |
|
Joubu |
nope :) |
| 13:47 |
|
drojf |
will look at misc4dev when i have more koha playtime again. which i hope is soon |
| 13:47 |
|
Joubu |
to hard to maintain, they will stick on this repo |
| 13:47 |
|
marcelr |
no is an answer too |
| 13:47 |
|
Joubu |
unless you volunteer |
| 13:47 |
|
marcelr |
heh |
| 13:48 |
|
Joubu |
I first tried, with the populate_db and create_superlibrarian script, but they always need to be adapted |
| 13:48 |
|
Joubu |
and I do not want to wait for people to care about my dev workflow |
| 13:48 |
|
Joubu |
so I maintain them on my own |
| 13:48 |
|
drojf |
when i run rebuild_zebra.pl in master i get "Base class package "Koha::Object" is empty.". is that expected? |
| 13:48 |
|
Joubu |
I accept pull requests ;) |
| 13:48 |
|
marcelr |
koha-conf.xml |
| 13:48 |
|
wahanui |
i think koha-conf.xml is a config file, not a port |
| 13:48 |
|
marcelr |
perl5lib |
| 13:48 |
|
wahanui |
hmmm... perl5lib is set to /home/koha/kohaclone |
| 13:48 |
|
Joubu |
drojf: wrong user |
| 13:50 |
|
oleonard |
mtompset: Adding the |html filter to a template variable is only useful if the template is outputting that variable. I don't think any of those templates actually do. |
| 13:51 |
|
oleonard |
That's something I'm looking at as I do the style overhaul of those templates. |
| 13:51 |
|
|
rhamby joined #koha |
| 13:52 |
|
mtompset |
drojf: Yes, sudo koha-shell -c "..." {user} |
| 13:52 |
|
mtompset |
well isn't the value attribute displayed? |
| 13:52 |
|
mtompset |
well isn't the value attribute displayed, oleonard? |
| 13:53 |
|
mtompset |
(re bug 17855) |
| 13:53 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17855 enhancement, P5 - low, ---, alexbuckley, Needs Signoff , Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha |
| 13:53 |
|
oleonard |
I'm trying to figure out if there is a situation where those value attributes contain any data |
| 13:54 |
|
mtompset |
if there was a service side refresh of the page, there mght be. i.e. submit bad data, server goes blah, and returns page. |
| 13:54 |
|
mtompset |
But I'm not sure that happens in any case. |
| 13:54 |
|
oleonard |
Maybe. I'm going to test. |
| 13:57 |
|
Joubu |
I guess it is a c/p from memberentry |
| 13:57 |
|
Joubu |
there value attributes should always be empty |
| 13:57 |
|
Joubu |
these* |
| 14:01 |
|
oleonard |
mtompset: Can I suggest that you hold off on your examination of the bug 17855 templates until after you've seen it with my patch for Bug 17942? |
| 14:01 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17855 enhancement, P5 - low, ---, alexbuckley, Needs Signoff , Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha |
| 14:01 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17942 enhancement, P5 - low, ---, oleonard, ASSIGNED , Update style of the web installer with Bootstrap 3 |
| 14:02 |
|
mtompset |
I'm not looking at it right now. |
| 14:02 |
|
oleonard |
I do think, however, that onboarding.pl needs some careful examination |
| 14:02 |
|
mtompset |
But I'll keep that in mind (unless the screen door opens and I forget) |
| 14:03 |
|
oleonard |
Okay, I didn't see anything in the bug comments which suggested you were done testing the templates, so I thought it was worthwhile to mention it. |
| 14:03 |
|
mtompset |
I've paused on that to work on bug 17809 and bug 17837 merging and cleaning |
| 14:03 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17809 minor, P5 - low, ---, fridolin.somers, ASSIGNED , ER country twice in fr-FR database files |
| 14:03 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17837 minor, P5 - low, ---, mtompset, Signed Off , Correct some authorised values in fr-FR |
| 14:04 |
|
mtompset |
I'm setting up the pretty red's, Joubu |
| 14:06 |
|
|
tcohen joined #koha |
| 14:07 |
|
oleonard |
Hi tcohen |
| 14:07 |
|
fridolin |
thanks a lot Joubu and mtompset |
| 14:08 |
|
fridolin |
realy odd because some people from Erythrée move to Germany, in Koha they are already there ;) |
| 14:09 |
|
tcohen |
hi #koha |
| 14:09 |
|
marcelr |
hola tcohen |
| 14:11 |
|
|
NateC joined #koha |
| 14:17 |
|
tcohen |
hi marcelr |
| 14:20 |
|
mtompset |
ha ha, fridolin :) |
| 14:24 |
|
|
kholt joined #koha |
| 14:27 |
|
|
kchris joined #koha |
| 14:27 |
|
|
kellym joined #koha |
| 14:30 |
|
drojf |
thanks everyone, upgrading the system and koha to the latest nightly solved it |
| 14:33 |
|
drojf |
but i can't reproduce what i actually wanted to test. lol |
| 14:41 |
|
ashimema |
hi tcohen |
| 14:41 |
|
ashimema |
sounds like you have a fun little adventrue into mysql last night :( |
| 14:44 |
|
jenkins |
Project Koha_Master_D8 build #95: STILL UNSTABLE in 1 hr 37 min: https://jenkins.koha-community[…]oha_Master_D8/95/ |
| 14:44 |
|
jenkins |
* kyle: Bug 17784 Ability to see funds with an amount of 0.00 when doing a new |
| 14:44 |
|
jenkins |
* kyle: Bug 17771: Add link to bibliographic record on spent/ordered lists in |
| 14:44 |
|
jenkins |
* kyle: Bug 17771 [QA Followup] - Tidy table html |
| 14:44 |
|
jenkins |
* kyle: Bug 17771: aqorders.biblionumber was already part of the query |
| 14:45 |
|
jenkins |
* kyle: Bug 5784 - link to aq from budgets & funds |
| 14:45 |
|
jenkins |
* kyle: Bug 5784 [QA Followup] - Move link to breadcrumbs |
| 14:45 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17784 enhancement, P5 - low, ---, crazy.mental.onion, Pushed to Master , Ability to see funds with an amount of 0.00 when doing a new order |
| 14:45 |
|
jenkins |
* kyle: Bug 17924 - Fix error in password recovery |
| 14:45 |
|
jenkins |
* kyle: Bug 17823: Add label for MARC 583 - Action note |
| 14:45 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17771 enhancement, P5 - low, ---, luke.honiss, Pushed to Master , Add link to bibliographic record on spent/ordered lists in acquisitions |
| 14:45 |
|
jenkins |
* kyle: Bug 17891: Remove extra div tag in the housebound module |
| 14:45 |
|
jenkins |
* kyle: Bug 17931: Remove unused vars from reserves_stats |
| 14:45 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=5784 enhancement, P5 - low, ---, oleonard, Pushed to Master , link to acq from budgets & funds |
| 14:45 |
|
jenkins |
* kyle: Bug 17731: Remove noxml option from rebuild_zebra.pl |
| 14:45 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17924 critical, P5 - low, ---, oleonard, Pushed to Master , Fix error in password recovery |
| 14:45 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17823 normal, P5 - low, ---, karenliang.student, Pushed to Master , XSLT: Add label for MARC 583 - Action note |
| 14:45 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17891 trivial, P5 - low, ---, crazy.mental.onion, Pushed to Master , typo in housebound.tt div tag |
| 14:45 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17931 trivial, P5 - low, ---, m.de.rooy, Pushed to Master , Remove unused vars from reserves_stats.pl |
| 14:45 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17731 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Remove the noxml option from rebuild_zebra.pl |
| 14:46 |
|
|
tcohen1 joined #koha |
| 14:47 |
|
tcohen1 |
marcelr: 2017-01-10 15:53 Patricio Marrone o Bug 17817: Fix cloning subfields using select2 |
| 14:47 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17817 critical, P5 - low, ---, marrone.patricio, Pushed to Stable , Repeat this Tag (cloning) not working |
| 14:48 |
|
marcelr |
? |
| 14:48 |
|
tcohen1 |
history.txt missed Patricio |
| 14:48 |
|
marcelr |
ok; add a comment on 7143 |
| 14:48 |
|
marcelr |
will probably be more? |
| 14:51 |
|
mtompset |
fridolin: Care to retest/sign off bug 17809? I think I've got it to do what Joubu asked. |
| 14:51 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17809 minor, P5 - low, ---, fridolin.somers, Needs Signoff , ER country twice in fr-FR database files |
| 14:53 |
|
fridolin |
mtompset: signoff only first patch rigth ? |
| 14:54 |
|
mtompset |
Right, that's the thig stopping the status from being signed off, in my mind. :) |
| 14:54 |
|
|
talljoy joined #koha |
| 14:55 |
|
mtompset |
Now we just need to get luke to submit two things and we'll each take one to make it happy signoff mess. :) |
| 14:56 |
|
tcohen1 |
ashimema: indeed :-( |
| 14:56 |
|
tcohen1 |
I'll workaround it |
| 14:57 |
|
tcohen1 |
until is fixed in the mysql driver |
| 14:57 |
|
mtompset |
mysql driver? what fun did you have, tcohen? |
| 14:59 |
|
marcelr |
bye all |
| 15:03 |
|
tcohen |
mtompset: if you encode_json on a row you fetched from MySQL, which includes integer values (for example borrowernumber), the JSON library identifies it as a string |
| 15:03 |
|
tcohen |
this is due to a bug we discovered on DBD::mysql |
| 15:03 |
|
mtompset |
OH. YUCK! |
| 15:03 |
|
tcohen |
there are of course ways of dealing with it (workarounds) |
| 15:03 |
|
tcohen |
but it was a long way to get it sorted (the root cause of the problem) |
| 15:04 |
|
tcohen |
it started as looking for a bug in JSON, then in DBIx::Class, etc.. |
| 15:04 |
|
tcohen |
down the rabiit hole |
| 15:05 |
|
Joubu |
Is the workaround to deprecate mysql and support psql instead? |
| 15:05 |
|
|
jac joined #koha |
| 15:05 |
|
tcohen |
that's a possibility |
| 15:05 |
|
tcohen |
hahaha |
| 15:05 |
|
tcohen |
it is not MySQL's problem |
| 15:05 |
|
tcohen |
DBD::mysql has enough information to know it is a number |
| 15:06 |
|
tcohen |
it is just not DTRT |
| 15:10 |
|
mtompset |
Silly me thought you would attempt a bogus acronym on DRUART = Doing Really Unbelievably Awesome Radical Things |
| 15:10 |
|
tcohen |
ha, do the right thing |
| 15:11 |
|
|
meliss joined #koha |
| 15:11 |
|
mtompset |
I'm tired. Had to look it up, after I misread it. ;) |
| 15:13 |
|
* Joubu |
is going to write down that somewhere |
| 15:13 |
|
Joubu |
just in case |
| 15:14 |
|
tcohen |
Joubu: so your surname is an acronym? |
| 15:16 |
|
oleonard |
All French people's surnames are acronyms. That's why they print them in all upper case. |
| 15:17 |
|
drojf |
yes, acronyms for english words. obviously |
| 15:17 |
|
Joubu |
I do not :) |
| 15:18 |
|
|
akilsdonk joined #koha |
| 15:19 |
|
Joubu |
khall: fyi: I have a completely messy branch with dozens of commits dealing with TT syntax for notices |
| 15:19 |
|
Joubu |
Luckily I will submit clean stuffs before the end of the week |
| 15:19 |
|
|
rhamby joined #koha |
| 15:19 |
|
Joubu |
Ha, end of the week is tomorrow... |
| 15:20 |
|
Joubu |
maybe beginning of next week then :) |
| 15:20 |
|
|
sallyf joined #koha |
| 15:21 |
|
|
barbara joined #koha |
| 15:22 |
|
|
phasefx_ joined #koha |
| 15:24 |
|
khall |
Joubu: that's awesome to hear! |
| 15:24 |
|
tcohen |
Joubu++ |
| 15:25 |
|
paul_p |
!seen bag |
| 15:25 |
|
paul_p |
@seen bag |
| 15:25 |
|
huginn |
paul_p: bag was last seen in #koha 1 week, 0 days, 7 hours, 15 minutes, and 21 seconds ago: <bag> night night all |
| 15:33 |
|
|
joe_hanover joined #koha |
| 15:40 |
|
* oleonard |
burns a printed copy of the jQuery documentation in offering to the form validation gods |
| 15:40 |
|
* oleonard |
hopes that helps |
| 15:41 |
|
|
JoshB joined #koha |
| 15:43 |
|
drojf |
bye #koha |
| 15:43 |
|
LibraryClaire |
o/ |
| 15:45 |
|
* oleonard |
should have made a sacrifice to the use-your-own-damn-eyes gods 20 minutes ago |
| 15:48 |
|
jajm |
Joubu, i just pushed patches of bug 17234 to 3.22.x, and then i saw your 2 last comments, should i care about it now ? :) |
| 15:48 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17234 major, P5 - low, ---, philippe.blouin, Pushed to Stable , ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl |
| 15:50 |
|
Joubu |
jajm: nope, if you have the others, you do not need it |
| 15:50 |
|
jajm |
ok thanks |
| 15:50 |
|
Joubu |
it will be useful for branches which do not have the 3 new subroutines |
| 15:52 |
|
mtompset |
YAY! 17234 is in master? |
| 15:52 |
|
mtompset |
YAY! |
| 15:55 |
|
|
fridolin left #koha |
| 15:57 |
|
LibraryClaire |
laters #koha |
| 15:57 |
|
|
LibraryClaire left #koha |
| 15:57 |
|
|
jbeno joined #koha |
| 16:03 |
|
|
rocio joined #koha |
| 16:04 |
|
|
randomnews joined #koha |
| 16:05 |
|
randomnews |
stupid question of the day: the logout button, on Koha, passed a logout.x param to the opac-main.pl script. However, I can see it getting picked up there and used. Anyone know how the logout works, js? |
| 16:14 |
|
reiveune |
bye |
| 16:14 |
|
|
reiveune left #koha |
| 16:21 |
|
jenkins |
Project Koha_Master_D8 build #96: STILL UNSTABLE in 1 hr 36 min: https://jenkins.koha-community[…]oha_Master_D8/96/ |
| 16:22 |
|
jenkins |
* kyle: Bug 15460 Adding spaces after subfields c and h of 245 |
| 16:22 |
|
jenkins |
* kyle: Bug 17691 - add serial subscription |
| 16:22 |
|
jenkins |
* kyle: Bug 17691: Does not repeat "subscriptions" |
| 16:22 |
|
jenkins |
* kyle: Bug 8266 - remove location from pulldown |
| 16:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=15460 minor, P5 - low, ---, caitlingoodger.student, Pushed to Master , Bug 13381 accidentally removed spaces after subfields c and h of 245 |
| 16:22 |
|
jenkins |
* kyle: Bug 17469: Add missing sample notices fr-CA test |
| 16:22 |
|
jenkins |
* kyle: Bug 17469: Add missing sample notices to fr-CA web installer |
| 16:22 |
|
jenkins |
* kyle: Bug 17469: Follow-up adding hold print notice |
| 16:22 |
|
jenkins |
* kyle: Bug 17469: Fix number of values |
| 16:22 |
|
jenkins |
* kyle: Bug 7143: Update history file |
| 16:22 |
|
jenkins |
* kyle: Bug 7143: Update about.tt with new devs |
| 16:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17691 enhancement, P5 - low, ---, grace.mcky, Pushed to Master , Add serial subscriptions info on vendor profile page |
| 16:22 |
|
jenkins |
* kyle: Bug 7143: [QA Follow-up] Correcting dates for first patch pushed |
| 16:22 |
|
jenkins |
* kyle: Bug 7143: [QA Follow-up] Handling tabs |
| 16:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8266 enhancement, P5 - low, ---, gmcharlt, Pushed to Master , remove location from pull down on search |
| 16:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17469 normal, P5 - low, ---, caitlingoodger.student, Pushed to Master , fr-CA web installer is missing some sample notices |
| 16:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7143 trivial, P5 - low, ---, koha-bugs, ASSIGNED , Bug for tracking changes to the about page |
| 16:43 |
|
|
tcohen joined #koha |
| 16:59 |
|
|
LibraryClaire joined #koha |
| 17:07 |
|
|
TGoat joined #koha |
| 17:26 |
|
|
cait joined #koha |
| 17:33 |
|
|
tcohen1 joined #koha |
| 17:39 |
|
|
wilfrid joined #koha |
| 17:46 |
|
oleonard |
I think my patch for Bug 17942 is almost ready, apart from the fact that the installer gets stuck in an endless loop :| |
| 17:46 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17942 enhancement, P5 - low, ---, oleonard, ASSIGNED , Update style of the web installer with Bootstrap 3 |
| 17:46 |
|
* oleonard |
messed up a form field somewhere |
| 17:47 |
|
oleonard |
details, details |
| 18:09 |
|
|
jls joined #koha |
| 18:17 |
|
mtompset |
okay accounts.t fails now, sitemapper (bug 17920), and check_sysprefs (bug 17917)... just final testing |
| 18:17 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17920 normal, P5 - low, ---, mtompset, Passed QA , t/db_dependent/Sitemapper.t fails because of permissions |
| 18:17 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17917 major, P5 - low, ---, mtompset, In Discussion , t/db_dependent/check_sysprefs.t fails on kohadev strangely |
| 18:27 |
|
|
SWITCH_Staff joined #koha |
| 18:33 |
|
|
NateC joined #koha |
| 18:34 |
|
mtompset |
There! 17917 tested and up. |
| 18:37 |
|
chris_n |
does anyone know if it is intended that if the ip of the client matches the ip of the library, that logons from that client are defaulted to the library associated with that subnet overriding the logon account's default library? |
| 18:38 |
|
* chris_n |
wonders if that makes sense |
| 18:40 |
|
oleonard |
Hi chris_n, ever lurking. |
| 18:41 |
|
oleonard |
chris_n: My first thought was the AutoLocation system preference, but I'm not sure that does what you're describing. |
| 18:46 |
|
chris_n |
heya oleonard: I've been wrapping my brain around a little c++ of late :) |
| 18:46 |
|
Joubu |
AutoLocation is completely broken, patch is in the queue |
| 18:46 |
|
chris_n |
I'll have a look |
| 18:46 |
|
Joubu |
bug 9569 |
| 18:46 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9569 is not accessible. |
| 18:46 |
|
oleonard |
Hey everyone I heard chris_n is rewriting Koha in C++. |
| 18:47 |
|
chris_n |
LOL |
| 18:47 |
|
chris_n |
AutoLocation is off on this installation |
| 18:48 |
|
chris_n |
what I'm seeing here is that if a subnet is assigned to a library under branches.pl, when a patron logs in from a client on that subnet, their library is changed from the patron's home library to the library assigned to that subnet |
| 18:50 |
|
oleonard |
chris_n: What is the purpose of having a subnet defined in branches? |
| 18:50 |
|
chris_n |
easy fix is to remove any ip assignment from the various libraries, but if it this is not the intended behavior, I will file a bug |
| 18:51 |
|
chris_n |
oleonard: none that I can see |
| 18:51 |
|
chris_n |
I removed them to make the confusion disappear |
| 18:51 |
|
oleonard |
I thought that it was only used for AutoLocation |
| 18:51 |
|
oleonard |
But since I don't use it I could be wrong |
| 18:51 |
|
chris_n |
if that is true, this behavior is a bug I suspect |
| 18:52 |
|
rangi |
community++ #thanks for all the testing/qa and pushing |
| 18:53 |
|
Joubu |
chris_n: From C4::Auth, it seems that the code is intented to do |
| 18:53 |
|
rangi |
chris_n !!! long time no see |
| 18:53 |
|
Joubu |
1067 my $domain = $branches->{$br}->{'branchip'}; |
| 18:53 |
|
Joubu |
1068 if ( $domain && $ip =~ /^$domain/ ) { |
| 18:53 |
|
Joubu |
1069 $branchcode = $branches->{$br}->{'branchcode'}; |
| 18:53 |
|
chris_n |
hey rangi |
| 18:53 |
|
chris_n |
hope things are going well for you |
| 18:54 |
|
rangi |
cant complain |
| 18:54 |
|
chris_n |
Joubu: cool; I'll just leave it alone then since removing the ips fixed it for me |
| 18:54 |
|
oleonard |
rangi: chris_n just volunteered to be RM for the next release |
| 18:54 |
|
rangi |
nice! |
| 18:55 |
|
* chris_n |
appreciates the vote of confidence :) |
| 18:55 |
|
oleonard |
...but I was kidding, so :( |
| 18:57 |
|
* oleonard |
is all fake news these days |
| 18:57 |
|
rangi |
heh |
| 18:57 |
|
chris_n |
hehe |
| 19:04 |
|
kidclamp |
tcohen++ |
| 19:08 |
|
tcohen1 |
kidclamp: :-P |
| 19:08 |
|
tcohen |
Joubu: around? |
| 19:09 |
|
Joubu |
yep |
| 19:09 |
|
tcohen |
I'm trying to make sure |
| 19:09 |
|
tcohen |
txn_do(sub{ }); |
| 19:09 |
|
tcohen |
short-circuits if we raise an exception |
| 19:10 |
|
tcohen |
have you faced that situation? |
| 19:10 |
|
Joubu |
That sounds weird |
| 19:10 |
|
tcohen |
rolls-back |
| 19:10 |
|
tcohen |
? |
| 19:11 |
|
tcohen |
txn_do(sub{ $self->delete_all_something ; $self->add_new_something(@list) }); |
| 19:11 |
|
tcohen |
so, if add fails somehow and raises an exception |
| 19:11 |
|
tcohen |
it should rollback, right? |
| 19:12 |
|
Joubu |
yes |
| 19:12 |
|
tcohen |
i'm making bug 17755 return Koha::Libraries |
| 19:12 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17755 enhancement, P5 - low, ---, tomascohen, Signed Off , Introduce Koha::Patron::Attribute::Type(s) |
| 19:13 |
|
Joubu |
I think I did not understand your short-circuits things, but yes if you are starting a transaction which is not finished, it should rollback |
| 19:13 |
|
tcohen |
and noticed that the tests didn't check that on an exception condition, things remained unchanged |
| 19:13 |
|
Joubu |
last sentence was gramatically incorrect, as always |
| 19:13 |
|
tcohen |
question is do you remember some code that does something similar? |
| 19:14 |
|
tcohen |
Joubu: mine too, we are even |
| 19:14 |
|
tcohen |
he |
| 19:14 |
|
Joubu |
sorry, late and need to eat something :) |
| 19:15 |
|
tcohen |
I guess it was just a matter of git grep txn_do |
| 19:15 |
|
tcohen |
sorry to bother you! go eat something! |
| 19:15 |
|
* tcohen |
already has Grimbergen supplies |
| 19:15 |
|
tcohen |
:-P |
| 19:15 |
|
* oleonard |
jealous |
| 19:16 |
|
* LibraryClaire |
wants Grimbergen |
| 19:16 |
|
cait |
Grimbergen? |
| 19:17 |
|
* cait |
reads back and waves at chris_n |
| 19:19 |
|
chris_n |
hi cait |
| 19:21 |
|
cait |
:) |
| 19:22 |
|
oleonard |
Okay, patch for Bug 17942 posted. |
| 19:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17942 enhancement, P5 - low, ---, oleonard, Needs Signoff , Update style of the web installer with Bootstrap 3 |
| 19:24 |
|
tcohen |
oleonard: are we close to Bootstrap 3 for OPAC? |
| 19:25 |
|
oleonard |
Not from me tcohen :( |
| 19:25 |
|
tcohen |
also: do you think we could benefit from a OPACbootstrapCSS syspref? |
| 19:25 |
|
mtompset |
So I can test bug 17492 now? |
| 19:25 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17492 enhancement, P5 - low, ---, rbit, Patch doesn't apply , Show warning if patron's age is out of category limits |
| 19:26 |
|
mtompset |
I mean 942 |
| 19:27 |
|
oleonard |
If you'd like to mtompset that would be great. It depends on 17855 |
| 19:28 |
|
oleonard |
tcohen: What would OPACbootstrapCSS do? |
| 19:29 |
|
LibraryClaire |
oleonard++ |
| 19:29 |
|
mtompset |
first feeling... |
| 19:29 |
|
mtompset |
"ooooo nice!" |
| 19:34 |
|
tcohen |
oleonard: we tweaked an OPAC inteface, recompiling the bootstrap.min.css file |
| 19:35 |
|
tcohen |
instead of adding overlay CSS on top of the shipped one |
| 19:36 |
|
alexbuckley_ |
I have written a bug report (17944) which depends on 17855 and it requires me to go through multiple administrative perl scripts all of which have sql in them and moving that sql. Thereby fixing multiple scripts in one go |
| 19:37 |
|
alexbuckley_ |
which I can complete if we can get 17855 signed off soon |
| 19:39 |
|
mtompset |
What what?! |
| 19:40 |
|
mtompset |
oh... I just ran through an install advanced and very minimal data forcing onboarding steps. |
| 19:40 |
|
mtompset |
I must say, oleonard, it's beautiful. Tears of joy beautiful. |
| 19:40 |
|
oleonard |
Thanks mtompset that's definitely what I was going for. |
| 19:41 |
|
mtompset |
And it is consistent through out each step. It's nice. |
| 19:41 |
|
mtompset |
Okay, let me do another test run or two. |
| 19:41 |
|
mtompset |
that was advanced marc21 |
| 19:42 |
|
mtompset |
let's try basic unimarc this run. :) |
| 19:42 |
|
alexbuckley_ |
When making the onboarding tool I noticed that smart-rules.pl and itemtypes.pl both had sql code in them, thereby violating the coding guidelines. I would like to go through all the administration perl scripts as well as onboarding.pl moving the sql code thereby killing 2 birds with one stone as it were |
| 19:43 |
|
alexbuckley_ |
Thats what bug 17944 which relies on bug 17855 entails |
| 19:43 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17944 minor, P5 - low, ---, alexbuckley, ASSIGNED , Remove the sql code from onboarding and administrative perl scripts, and remove unnecessary use pragmas from onboarding.pl |
| 19:43 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17855 enhancement, P5 - low, ---, alexbuckley, Needs Signoff , Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha |
| 19:43 |
|
oleonard |
alexbuckley_: I recommend trying to do that process in as small bugs as possible to make it easier to get through QA |
| 19:44 |
|
oleonard |
Is anyone else getting a DataTables error when loading the holds tab on the circulation page? |
| 19:44 |
|
|
Gracie joined #koha |
| 19:45 |
|
rangi |
Gracie: https://www.flickr.com/photos/[…]72157678884274246 |
| 19:46 |
|
alexbuckley_ |
I could tidy up one script per bug. i.e. at least three bugs after 17855. One to tidy up itemtypes.pl, smart-rules.pl and onboarding.pl |
| 19:47 |
|
mtompset |
Yes, alexbuckley_, oleonard is right. small bugs QA faster. |
| 19:48 |
|
mtompset |
Is anyone opposed to me squashing 17855 into a single patch? |
| 19:48 |
|
oleonard |
rangi: I like your "how not to ask for help" slide :) |
| 19:49 |
|
|
kmlussier joined #koha |
| 19:50 |
|
mtompset |
Indeed. Nice slide, rangi. :) |
| 19:50 |
|
alexbuckley_ |
I am not asking for help I am simply saying that the onboarding.pl script is not the only one with sql in it and I would be keen to go through and fix several other scripts up, at the same time |
| 19:51 |
|
|
lukeh joined #koha |
| 19:51 |
|
mtompset |
alexbuckley_: That's a completely separate thread. Don't context bleed. ;) |
| 19:51 |
|
alexbuckley_ |
oops sorry I misread |
| 19:51 |
|
alexbuckley_ |
:) |
| 19:52 |
|
oleonard |
Sorry for the confusion alexbuckley_ I was reacting to rangi's Flickr link |
| 19:52 |
|
alexbuckley_ |
no worries sorry I misread |
| 19:53 |
|
mtompset |
Happens to the best of us sometimes. No worries. :) |
| 19:54 |
|
mtompset |
okay, quick question... what is that wonderful script to reset the database to a nice blank one and make sure I don't get an "Internal Server Error"? :) |
| 19:55 |
|
mtompset |
I have to cycle my VM to fix it, which is the long hard way. |
| 19:56 |
|
oleonard |
mtompset: You mean a nice clean one as opposed to an empty database, right? |
| 19:58 |
|
mtompset |
no empty one to force webinstaller |
| 19:58 |
|
oleonard |
mtompset: Drop the db and recreate it? |
| 19:58 |
|
* mtompset |
grumbles "stupid caching issues." |
| 19:59 |
|
mtompset |
do you have kohadevbox? start jessie, drop and create, then webinstall. all is good right? |
| 19:59 |
|
mtompset |
then drop and create and try to webinstall. |
| 19:59 |
|
mtompset |
Internal Server Error. |
| 19:59 |
|
oleonard |
sudo koha-plack --disable kohadev;sudo service memcached restart;sudo service apache2 restart;sudo koha-plack --enable kohadev |
| 20:00 |
|
mtompset |
memcache! |
| 20:00 |
|
wahanui |
memcache is easy |
| 20:00 |
|
mtompset |
No it isn't, wahanui. |
| 20:00 |
|
wahanui |
mtompset: excuse me? |
| 20:00 |
|
oleonard |
Bye all |
| 20:00 |
|
mtompset |
oleonard: wait... |
| 20:01 |
|
mtompset |
Oh well, I'm going to sign off on 17855, but comment on 17942. |
| 20:02 |
|
mtompset |
alexbuckley_: Are you kosher with my squashing 17855 to 3 patches? wizzyrea wizzycray wrote one patch in the middle. |
| 20:02 |
|
alexbuckley_ |
yup thats fine mtompset |
| 20:20 |
|
|
medo joined #koha |
| 20:26 |
|
|
kellym joined #koha |
| 20:32 |
|
|
karen_ joined #koha |
| 20:47 |
|
|
kellym joined #koha |
| 20:48 |
|
wizzycray |
ya I'm ok with that |
| 20:48 |
|
* wizzycray |
doesn't care about attribution here |
| 20:48 |
|
wizzycray |
i care that it makes koha better. ;) |
| 20:58 |
|
|
bshum joined #koha |
| 21:21 |
|
|
andreashm joined #koha |
| 21:26 |
|
|
alexbuckley joined #koha |
| 21:27 |
|
|
alexbuckley__ joined #koha |
| 21:30 |
|
|
irma joined #koha |
| 21:41 |
|
|
barton joined #koha |
| 21:42 |
|
|
kholt joined #koha |
| 22:07 |
|
|
emma_ joined #koha |
| 22:09 |
|
|
aleisha joined #koha |
| 22:10 |
|
aleisha |
https://twitter.com/ranginui/s[…]22203995879927808 |
| 22:18 |
|
|
JoshB left #koha |
| 22:28 |
|
|
edveal left #koha |
| 22:30 |
|
|
Francesca joined #koha |
| 22:49 |
|
|
Francesca joined #koha |
| 22:53 |
|
|
Francesca joined #koha |
| 22:56 |
|
eythian |
He better have spun it into a lesson on multithreading or something. |
| 22:57 |
|
ibeardslee |
no, I just think he was looking at how far from the desk he needs to sit ;) |
| 23:10 |
|
aleisha |
https://twitter.com/aleishaamo[…]22219525273702400 |
| 23:10 |
|
|
kholt joined #koha |
| 23:18 |
|
|
talljoy joined #koha |
| 23:27 |
|
|
aleisha joined #koha |
| 23:33 |
|
|
kholt left #koha |
| 23:46 |
|
|
irma joined #koha |
| 23:48 |
|
mtompset |
wizzyrea++ # altruistic selflessness :) |
| 23:51 |
|
|
kmlussier joined #koha |
| 23:56 |
|
|
sameeenz joined #koha |
