| Time |
S |
Nick |
Message |
| 00:00 |
|
|
jamesb joined #koha |
| 00:15 |
|
|
dcook joined #koha |
| 01:09 |
|
|
JoshB joined #koha |
| 01:27 |
|
|
BobB joined #koha |
| 01:50 |
|
* Francesca |
waves |
| 02:09 |
|
|
Francesca joined #koha |
| 02:26 |
|
|
Francesca joined #koha |
| 02:31 |
|
|
Francesca joined #koha |
| 03:11 |
|
|
jamesb_ joined #koha |
| 03:24 |
|
|
thd-away joined #koha |
| 03:39 |
|
|
Francesca joined #koha |
| 03:44 |
|
|
mario joined #koha |
| 05:01 |
|
|
cait joined #koha |
| 05:11 |
|
|
SamEEE joined #koha |
| 06:06 |
|
cait |
@later tell bag hm, there is still an atomicupdate in master - shouldn't that be gone? |
| 06:06 |
|
huginn |
cait: The operation succeeded. |
| 06:07 |
|
cait |
@later tell bag forget it... i am not awake yet :) |
| 06:07 |
|
huginn |
cait: The operation succeeded. |
| 06:19 |
|
|
jamesb joined #koha |
| 06:21 |
|
|
magnuse joined #koha |
| 06:21 |
|
* magnuse |
waves |
| 06:23 |
|
|
marcelr joined #koha |
| 06:23 |
|
* cait |
waves too |
| 06:24 |
|
marcelr |
hi #koha |
| 06:24 |
|
marcelr |
hi cait++ |
| 06:24 |
|
cait |
morning marcelr! |
| 06:24 |
|
cait |
have to run... back to work today |
| 06:30 |
|
|
Francesca joined #koha |
| 06:33 |
|
|
Francesca joined #koha |
| 06:52 |
|
|
reiveune joined #koha |
| 06:53 |
|
reiveune |
hello |
| 06:54 |
|
magnuse |
bonjour reiveune |
| 06:54 |
|
magnuse |
@wunder boo |
| 06:54 |
|
huginn |
magnuse: The current temperature in Bodo, Norway is 9.0°C (8:20 AM CEST on May 02, 2016). Conditions: Clear. Humidity: 54%. Dew Point: 0.0°C. Pressure: 30.04 in 1017 hPa (Steady). |
| 06:54 |
|
magnuse |
summery! |
| 06:54 |
|
wahanui |
summery is probably rather wonderful |
| 06:55 |
|
|
alex_a joined #koha |
| 06:57 |
|
reiveune |
salut magnuse |
| 06:59 |
|
alex_a |
bonjour |
| 07:01 |
|
marcelr |
hi reiveune magnuse and alex_a |
| 07:01 |
|
marcelr |
bgkriegel++ |
| 07:01 |
|
alex_a |
hi marcelr |
| 07:02 |
|
reiveune |
salut marcelr |
| 07:03 |
|
|
wilfrid joined #koha |
| 07:16 |
|
|
sophie_m joined #koha |
| 07:18 |
|
|
gaetan_B joined #koha |
| 07:18 |
|
|
sophie_m joined #koha |
| 07:18 |
|
gaetan_B |
hello |
| 07:21 |
|
|
cdickinson joined #koha |
| 07:28 |
|
|
cait joined #koha |
| 07:34 |
|
|
marcelr joined #koha |
| 07:37 |
|
|
wilfrid joined #koha |
| 07:50 |
|
|
magnuse joined #koha |
| 08:09 |
|
|
paul_p joined #koha |
| 08:39 |
|
|
alex_a_ joined #koha |
| 08:54 |
|
* cait |
waves |
| 08:59 |
|
|
Francesca joined #koha |
| 09:26 |
|
* magnuse |
waves then wanders off to lunch |
| 09:26 |
|
magnuse |
@wunder boo |
| 09:26 |
|
huginn |
magnuse: The current temperature in Bodo, Norway is 12.0°C (11:20 AM CEST on May 02, 2016). Conditions: Clear. Humidity: 41%. Dew Point: -1.0°C. Pressure: 30.01 in 1016 hPa (Steady). |
| 09:26 |
|
magnuse |
double digits! |
| 09:27 |
|
liw |
@wunder helsinki |
| 09:27 |
|
huginn |
liw: The current temperature in Helsinki, Finland is 16.0°C (12:20 PM EEST on May 02, 2016). Conditions: Clear. Humidity: 31%. Dew Point: -1.0°C. Pressure: 30.27 in 1025 hPa (Steady). |
| 09:27 |
|
magnuse |
you win, liw! |
| 09:27 |
|
* magnuse |
is gone for real now |
| 09:27 |
|
liw |
I have to be awake. I don't win. |
| 09:56 |
|
Joubu |
@later tell bag please have a loot at bug 16104 comment 10&11 |
| 09:56 |
|
huginn |
Joubu: The operation succeeded. |
| 09:56 |
|
Joubu |
@later tell jajm please have a loot at bug 16104 comment 10&11 |
| 09:56 |
|
huginn |
Joubu: The operation succeeded. |
| 10:00 |
|
marcelr |
Joubu: a cache question: if you cache undef to some key, would it be sufficient to keep it in L1 cache? |
| 10:01 |
|
marcelr |
e.g. memcached does not like caching undefs |
| 10:02 |
|
Joubu |
marcelr: it should, but I don't think I have even tried |
| 10:02 |
|
Joubu |
ever |
| 10:02 |
|
marcelr |
i see such things in the sysprefs.t test |
| 10:02 |
|
marcelr |
and some warnings coming with it |
| 10:04 |
|
jajm |
Joubu, thx |
| 10:04 |
|
Joubu |
marcelr: let me check something |
| 10:05 |
|
marcelr |
bug 16104 and bug 16407 |
| 10:05 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16104 normal, P5 - low, ---, jonathan.druart, Pushed to Stable , Warnings "used only once: possible typo" should be removed |
| 10:05 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16407 normal, P5 - low, ---, m.de.rooy, Passed QA , Fix Koha_borrower_modifications.t |
| 10:05 |
|
marcelr |
no bug 14606 |
| 10:05 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=14606 enhancement, P5 - low, ---, wizzyrea, Needs Signoff , Donate to the Koha International Fund |
| 10:06 |
|
marcelr |
no bug 16406 |
| 10:06 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16406 minor, P5 - low, ---, chris, NEW , Fix Context.t tests 27, 37 and sysprefs.t |
| 10:06 |
|
Joubu |
marcelr: that's what I am checking |
| 10:06 |
|
marcelr |
ok |
| 10:06 |
|
Joubu |
16104 fails t/db_deps/Context.t and sysprefs.t |
| 10:07 |
|
marcelr |
same bug |
| 10:09 |
|
marcelr |
The warning Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284 really bugs me.. |
| 10:11 |
|
Joubu |
I don't understand why sysprefs.t fails, git bisect told me it's because of 16104, but if I revert it, the test still fails |
| 10:15 |
|
Joubu |
hum forget that, I have not correctly fixed the revert conflict |
| 10:16 |
|
marcelr |
Joubu: it failed with me if i have no cache |
| 10:16 |
|
Joubu |
Reverting 16104 makes the test passes |
| 10:16 |
|
Joubu |
marcelr: please define "no cache" |
| 10:16 |
|
marcelr |
no cache at all |
| 10:16 |
|
marcelr |
self->cache = undef |
| 10:16 |
|
Joubu |
I have stopped memcached and it still passes |
| 10:17 |
|
marcelr |
not the same i guess |
| 10:18 |
|
Joubu |
so MEMCACHED_SERVERS not defined? |
| 10:18 |
|
marcelr |
yes |
| 10:21 |
|
Joubu |
hum, still passes |
| 10:22 |
|
Joubu |
marcelr: I have reverted 16104 with |
| 10:22 |
|
Joubu |
- if ( can_load( modules => { 'Cache::Memory' => undef, nocache => 1 } ) |
| 10:22 |
|
Joubu |
+ if ( can_load( modules => { 'Cache::Memory' => undef } ) |
| 10:22 |
|
Joubu |
then |
| 10:22 |
|
Joubu |
warn $self->{cache}; before the return in Koha::Cache->new |
| 10:23 |
|
Joubu |
and get Cache::Memory=HASH(0x8b2d32c) |
| 10:23 |
|
marcelr |
so we should always have a cache now? |
| 10:24 |
|
marcelr |
that will probably resolve the two failing tests of bug 16406 |
| 10:24 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16406 minor, P5 - low, ---, chris, NEW , Fix Context.t tests 27, 37 and sysprefs.t |
| 10:31 |
|
marcelr |
Joubu: could you have a look at bug 16412 |
| 10:31 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16412 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Cache undef in L1 only |
| 10:32 |
|
marcelr |
just few lines |
| 10:32 |
|
marcelr |
including typo fix :) |
| 10:39 |
|
marcelr |
Joubu++ #qa |
| 11:08 |
|
Joubu |
marcelr: Does t/Cache.t pass for you? |
| 11:09 |
|
marcelr |
yes it did |
| 11:09 |
|
marcelr |
when enabled i mean |
| 11:09 |
|
marcelr |
i will try without now |
| 11:09 |
|
marcelr |
# Looks like you planned 40 tests but ran 37. |
| 11:09 |
|
marcelr |
so no |
| 11:10 |
|
Joubu |
that's weird |
| 11:11 |
|
marcelr |
Joubu: can you add your revert patch on bug 16104 |
| 11:11 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16104 normal, P5 - low, ---, jonathan.druart, Pushed to Stable , Warnings "used only once: possible typo" should be removed |
| 11:12 |
|
marcelr |
Joubu : when i remove nocache =>1 it passes |
| 11:13 |
|
Joubu |
arf yes, forgot that again |
| 11:13 |
|
Joubu |
I will attach the revert patch |
| 11:13 |
|
marcelr |
and Context.t also as well as sysprefs.t |
| 11:13 |
|
marcelr |
greast |
| 11:13 |
|
marcelr |
great |
| 11:15 |
|
marcelr |
Joubu: can you change its status to PQA or shall I do it? |
| 11:15 |
|
marcelr |
to get it into RM attention |
| 11:16 |
|
Joubu |
marcelr: I may be good to add your signoff on it and change the status accordingly |
| 11:16 |
|
marcelr |
will do it |
| 11:43 |
|
|
meliss joined #koha |
| 11:48 |
|
|
oleonard joined #koha |
| 11:51 |
|
oleonard |
Hi #koha |
| 11:52 |
|
|
ericar joined #koha |
| 12:00 |
|
marcelr |
hi oleonard |
| 12:02 |
|
* cait |
waves |
| 12:12 |
|
druthb |
cait++ |
| 12:13 |
|
Joubu |
oleonard: did you have time to take a look at bug 16400? |
| 12:13 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16400 enhancement, P5 - low, ---, jonathan.druart, In Discussion , Proposal to uniform the placement of submit buttons |
| 12:13 |
|
oleonard |
Not yet Joubu. I'll try to get to it today though |
| 12:13 |
|
Joubu |
oleonard: ok thanks |
| 12:14 |
|
cait |
druthb: i didn't do anything! |
| 12:15 |
|
druthb |
Sure you did. |
| 12:15 |
|
marcelr |
mveron++ |
| 12:23 |
|
cait |
mveron++ marcelr++ Joubu++ |
| 12:23 |
|
marcelr |
cait++ |
| 12:23 |
|
druthb |
see? |
| 12:23 |
|
cait |
everyone backto work now! :) |
| 12:23 |
|
marcelr |
join the + party |
| 12:23 |
|
marcelr |
oops |
| 12:24 |
|
druthb |
mean cait! |
| 12:24 |
|
marcelr |
she is |
| 12:24 |
|
druthb |
@karma |
| 12:24 |
|
huginn |
druthb: Highest karma: "cait" (358), "Joubu" (321), and "tcohen" (245). Lowest karma: "ie" (-28), "failed" (-26), and "<-" (-26). You (druthb) are ranked 48 out of 584. |
| 12:25 |
|
druthb |
@karma druthb |
| 12:25 |
|
huginn |
druthb: Karma for "druthb" has been increased 8 times and decreased 0 times for a total karma of 8. |
| 12:25 |
|
marcelr |
khall: if you name them all like updated_on, you may have the same ambigous column problems like before |
| 12:26 |
|
marcelr |
of course, it looks nicer than bortimestamp :) |
| 12:26 |
|
khall |
marcelr: yes, I think we had different goals in mind ; ) I don't think we should be forcing unique column names across tables, I just think 'timestamp' is too ambigous and is a keyword |
| 12:27 |
|
|
kidclamp joined #koha |
| 12:27 |
|
marcelr |
yes, we are climbing at least |
| 12:27 |
|
khall |
with the move away from direct SQL use, having duplicate column names becomes a non-issue |
| 12:28 |
|
* cait |
issa not mean! |
| 12:29 |
|
druthb |
:P |
| 12:35 |
|
|
tcohen joined #koha |
| 12:35 |
|
tcohen |
morning! |
| 12:36 |
|
magnuse |
afternoon! |
| 12:36 |
|
wahanui |
afternoon is good |
| 12:37 |
|
marcelr |
hola tcohen |
| 12:39 |
|
|
nengard joined #koha |
| 12:40 |
|
tcohen |
hi magnuse marcelr |
| 12:40 |
|
oleonard |
Joubu: Looking at 16400, where did the update to the plugin come from? |
| 12:40 |
|
tcohen |
what needs to be fixed for 16.05? I saw there was lots of action since friday |
| 12:40 |
|
Joubu |
from the jsfiddle in the header |
| 12:41 |
|
marcelr |
tcohen: if possible, fix everything |
| 12:41 |
|
cait |
khall: can you add to the dev meeting agenda? |
| 12:41 |
|
khall |
nope, will do! |
| 12:41 |
|
oleonard |
Joubu: Oh, so the jsfiddle at that link was updated |
| 12:42 |
|
Joubu |
oleonard: yep |
| 12:42 |
|
cait |
i think this week is general meeting and next week is dev meeting |
| 12:46 |
|
marcelr |
cait: fortunately we have a qa manager in 16.05 ! |
| 12:53 |
|
marcelr |
thx khall++ |
| 12:53 |
|
khall |
np! |
| 12:58 |
|
|
chrisvella_ joined #koha |
| 12:58 |
|
|
edveal joined #koha |
| 13:01 |
|
|
JoshB joined #koha |
| 13:16 |
|
|
geek_cl joined #koha |
| 13:20 |
|
|
Dyrcona joined #koha |
| 13:24 |
|
|
meliss joined #koha |
| 13:27 |
|
|
alex_a joined #koha |
| 13:30 |
|
|
cma joined #koha |
| 13:32 |
|
|
mario joined #koha |
| 13:39 |
|
|
amyk joined #koha |
| 13:43 |
|
|
NateC joined #koha |
| 13:44 |
|
tcohen |
hi Joubu khall |
| 13:44 |
|
khall |
mornin! |
| 13:44 |
|
Joubu |
tcohen: hi! |
| 13:50 |
|
|
drojf joined #koha |
| 13:50 |
|
drojf |
hi #koha |
| 14:07 |
|
drojf |
@wunder berlin, germany |
| 14:07 |
|
huginn |
drojf: The current temperature in Berlin Tegel, Germany is 19.0°C (3:50 PM CEST on May 02, 2016). Conditions: Clear. Humidity: 28%. Dew Point: 0.0°C. Pressure: 30.18 in 1022 hPa (Falling). |
| 14:07 |
|
drojf |
may++ |
| 14:07 |
|
oleonard |
@wunder 45701 |
| 14:08 |
|
huginn |
oleonard: The current temperature in Longview Hts, Athens, Ohio is 18.2°C (10:01 AM EDT on May 02, 2016). Conditions: Mostly Cloudy. Humidity: 93%. Dew Point: 17.0°C. Pressure: 29.95 in 1014 hPa (Falling). |
| 14:10 |
|
|
qianyao joined #koha |
| 14:16 |
|
druthb |
drojf! |
| 14:16 |
|
* druthb |
waves |
| 14:16 |
|
drojf |
druthb! |
| 14:16 |
|
druthb |
@wunder 77447 |
| 14:16 |
|
huginn |
druthb: The current temperature in Blueberry Farm, Hockley, Texas is 16.3°C (9:16 AM CDT on May 02, 2016). Conditions: Overcast. Humidity: 85%. Dew Point: 14.0°C. Pressure: 30.02 in 1016 hPa (Rising). Coastal Flood Advisory in effect until 3 PM CDT this afternoon... |
| 14:17 |
|
oleonard |
Oh no, the blueberry farm is in danger! |
| 14:17 |
|
* oleonard |
sends sandbags |
| 14:17 |
|
druthb |
not much--we're about 50 miles inland... |
| 14:17 |
|
druthb |
It's just that the county I live in is larger than a couple of US states. |
| 14:19 |
|
drojf |
ubuntu has a package format called snap? |
| 14:20 |
|
|
Karl_H joined #koha |
| 14:21 |
|
drojf |
and it includes all dependencies? that would be a lot of fun packing a gazillion perl deps for koha ;) |
| 14:30 |
|
Joubu |
khall: EnhancedMessagingPreferencesOPAC appears twice in sysprefs.sql |
| 14:30 |
|
khall |
we'll have to take care of that! Is there a bug report yet? |
| 14:31 |
|
Joubu |
khall: no, just noticed that while trying to insert the sql file |
| 14:31 |
|
khall |
ah, gotcha |
| 14:32 |
|
Joubu |
khall: do you want me to open one? |
| 14:32 |
|
khall |
yes plz |
| 14:34 |
|
Joubu |
bug 16418 |
| 14:34 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16418 major, P5 - low, ---, jonathan.druart, ASSIGNED , EnhancedMessagingPreferencesOPAC appears twice in sysprefs.sql |
| 14:34 |
|
Joubu |
patch attached |
| 14:36 |
|
Joubu |
and bug 11371 added lines after the rollback! |
| 14:36 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11371 enhancement, P5 - low, ---, bouzid.fergani, Pushed to Master , Add a new report : Orders by budget |
| 14:39 |
|
tcohen |
@wunder cordoba, argentina |
| 14:39 |
|
huginn |
tcohen: The current temperature in Bo Altos de San Martin - NW, Cordoba city, Cordoba City, Argentina is 17.1°C (11:35 AM ART on May 02, 2016). Conditions: Scattered Clouds. Humidity: 55%. Dew Point: 8.0°C. Pressure: 30.27 in 1025 hPa (Rising). |
| 14:43 |
|
Joubu |
both bug 16418 and bug 16419 are waiting for love |
| 14:43 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16418 major, P5 - low, ---, jonathan.druart, Needs Signoff , EnhancedMessagingPreferencesOPAC appears twice in sysprefs.sql |
| 14:43 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16419 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Tests of t/db_dependent/Acquisition.t do not pass |
| 14:44 |
|
oleonard |
What is the current status of T:T tags inside HTML and translatability? Is it still an issue? |
| 14:44 |
|
Joubu |
yes |
| 14:44 |
|
oleonard |
I'm surprised to find this: <input value="[% IF ( reserveloo.suspend ) %]Unsuspend[% ELSE %]Suspend[% END %]" |
| 14:45 |
|
tcohen |
oleonard: that s*ks |
| 14:45 |
|
Joubu |
yes |
| 14:45 |
|
Joubu |
some tests should fail |
| 14:45 |
|
tcohen |
the qa ones |
| 14:45 |
|
Joubu |
also |
| 14:45 |
|
oleonard |
Okay, I'm changing that line anyway so I'll fix that one at least. |
| 14:46 |
|
|
talljoy joined #koha |
| 14:52 |
|
Joubu |
khall: I do not know why, but Koha/Schema/Result/OldReserve.pm is not up to date with the structure |
| 14:52 |
|
tcohen |
khall: are you pushing 16155? |
| 14:52 |
|
Joubu |
itemtype has a on delete cascade (vs set null) |
| 14:52 |
|
khall |
tcohen: I can if you think it should be |
| 14:53 |
|
khall |
JoshB: that's odd, I'll have to run a schema rebuild against kohastructure |
| 14:54 |
|
|
drojf joined #koha |
| 14:54 |
|
tcohen |
khall: I passed it :-D |
| 14:54 |
|
khall |
excellent! will do! |
| 14:56 |
|
Joubu |
tcohen: did you pass all the tests? |
| 14:57 |
|
tcohen |
which tests¡? |
| 14:58 |
|
tcohen |
ah, I didn't re-test |
| 14:59 |
|
tcohen |
i worked on some of the failing ones |
| 14:59 |
|
|
rocio joined #koha |
| 14:59 |
|
Joubu |
tcohen: all the tests in t :) |
| 14:59 |
|
cait |
oleonard: it might work becaue it's 'value' but hard to tell without checking the po file |
| 15:00 |
|
cait |
bettr to avoid anyway |
| 15:01 |
|
khall |
Joubu: do you have any idea what bug that is related to? |
| 15:01 |
|
Joubu |
khall: commit fc81ee50040076ba6417cd047ea72c9ced7a1414 from bug 15533 |
| 15:01 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=15533 enhancement, P5 - low, ---, kyle, Pushed to Master , Allow patrons and librarians to select itemtype when placing hold |
| 15:01 |
|
|
TGoat joined #koha |
| 15:01 |
|
khall |
thanks! |
| 15:02 |
|
tcohen |
khall: let me check what Joubu mentions about 16155 before pushing |
| 15:02 |
|
khall |
tcohen: sounds good |
| 15:03 |
|
Joubu |
kidclamp: around? |
| 15:05 |
|
tcohen |
khall: there's a problem with dependencies |
| 15:05 |
|
tcohen |
edifact deps are not pulled by the packages |
| 15:06 |
|
khall |
ooh, that's no good |
| 15:06 |
|
tcohen |
are you addressing that with gmcharlt ? |
| 15:06 |
|
gmcharlt |
I'm working on the master package today and tomorrow |
| 15:06 |
|
huginn |
New commit(s) kohagit: Bug 15533 - DBRev - Update OldReserve schema file to match database schema <http://git.koha-community.org/[…]d42271a6f1f412b62> |
| 15:06 |
|
tcohen |
gmcharlt++ |
| 15:07 |
|
gmcharlt |
and consequently will be updating deps as needed |
| 15:07 |
|
tcohen |
gmcharlt: it seems that the ES patches missed to add to PerlDependencies.pm |
| 15:07 |
|
tcohen |
do u need a patch from us for that? |
| 15:16 |
|
Joubu |
Thanks tcohen for the love you gave to these 2 patches ;) |
| 15:16 |
|
tcohen |
you are welcome |
| 15:16 |
|
bag |
morning |
| 15:16 |
|
bag |
bug 16104 |
| 15:16 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16104 normal, P5 - low, ---, jonathan.druart, Passed QA , Warnings "used only once: possible typo" should be removed |
| 15:17 |
|
Joubu |
bag: the patch from this bug was wrong, I have submitted a revert patch (second on the bug report). |
| 15:17 |
|
|
pianohacker joined #koha |
| 15:17 |
|
Joubu |
I will get back the warnings, and no idea how to remove them |
| 15:18 |
|
bag |
cool I’m busy at the moment - but I’ve got khall looking at it for me |
| 15:18 |
|
Joubu |
bag: k, no worries |
| 15:19 |
|
Joubu |
pianohacker: morning! :) |
| 15:19 |
|
Joubu |
pianohacker: I was going to let you a later |
| 15:19 |
|
tcohen |
Joubu: several tests failing on master at t/db_dependent! |
| 15:19 |
|
Joubu |
pianohacker: but it might be a bit too early for the question :) |
| 15:19 |
|
Joubu |
tcohen: yes, several fixes are in the PQA queue |
| 15:20 |
|
tcohen |
notably t/db_dependent/www/search_utf8.t |
| 15:20 |
|
tcohen |
Joubu: really? you all rock! |
| 15:20 |
|
Joubu |
no fix for this one |
| 15:20 |
|
* tcohen |
is trying to figure what tests are broken by 16155 |
| 15:20 |
|
pianohacker |
hi |
| 15:20 |
|
wahanui |
kia ora, pianohacker |
| 15:20 |
|
pianohacker |
Joubu: what's up? |
| 15:21 |
|
Joubu |
tcohen: Marcel sent an email about the failures, I have signed them off |
| 15:21 |
|
Joubu |
pianohacker: I wanted to know if we had a plan for the cache patches |
| 15:22 |
|
tcohen |
Joubu: I'll try to do something about search_utf8.t |
| 15:22 |
|
Joubu |
pianohacker: specifically bug 16166 and bug 16140 |
| 15:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16166 enhancement, P2, ---, abl, Needs Signoff , Improve L1 cache performance and safety |
| 15:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16140 enhancement, P2, ---, jweaver, In Discussion , Only clear L1 cache when needed |
| 15:23 |
|
Joubu |
pianohacker: and Jacek submited a patch on a new one: bug 16365 |
| 15:23 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16365 enhancement, P2, ---, abl, Needs Signoff , Selectively introduce GetMarcStructure() "unsafe" variant for better performance |
| 15:25 |
|
pianohacker |
Joubu: not a plan, at this moment, purely because we're still debating competing approaches |
| 15:25 |
|
Joubu |
pianohacker: how can we unlock the situation? |
| 15:26 |
|
Joubu |
it would be great to have something in the next release |
| 15:26 |
|
Joubu |
well, we already have something, but something more :) |
| 15:27 |
|
pianohacker |
I'm not really sure... |
| 15:27 |
|
reiveune |
bye |
| 15:27 |
|
|
reiveune left #koha |
| 15:28 |
|
pianohacker |
we have a lot of things we can do to improve performance, all of which come with some amount of safety/code-complexity costs |
| 15:28 |
|
Joubu |
we do not have lot of areas where we can improve perfs easily, Koha::Cache is one |
| 15:29 |
|
pianohacker |
yeah |
| 15:29 |
|
Joubu |
the thing is that I have proved that bug 16140 is almost wrong |
| 15:29 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16140 enhancement, P2, ---, jweaver, In Discussion , Only clear L1 cache when needed |
| 15:29 |
|
pianohacker |
oh? |
| 15:30 |
|
Joubu |
the time consumed to calculated the "invalidation" is important |
| 15:30 |
|
Joubu |
-d |
| 15:30 |
|
pianohacker |
agreed, but based on the benchmarks we've done, it's still a net win |
| 15:30 |
|
pianohacker |
https://bugs.koha-community.or[…].cgi?id=16140#c17 |
| 15:30 |
|
huginn |
Bug 16140: enhancement, P2, ---, jweaver, In Discussion , Only clear L1 cache when needed |
| 15:31 |
|
Joubu |
yes but less than 16166 |
| 15:31 |
|
Joubu |
see the different numbers from Jacek and me on 16140 |
| 15:33 |
|
Joubu |
pianohacker: I also think that 16088 is really important as it will avoid to flush the L1 cache unecessary |
| 15:33 |
|
Joubu |
:q |
| 15:33 |
|
pianohacker |
agreed! |
| 15:33 |
|
pianohacker |
but I'm confused, those numbers aren't actually testing the cache invalidation code |
| 15:34 |
|
|
cait left #koha |
| 15:35 |
|
Joubu |
see comment 12 |
| 15:36 |
|
Joubu |
11&12 |
| 15:36 |
|
pianohacker |
Joubu: right, right, but we already talked about that; that's why I said "there's something oddly system-dependent going on here" |
| 15:36 |
|
pianohacker |
Joubu: because in my numbers, it helped; thus the confusion |
| 15:37 |
|
huginn |
New commit(s) kohagit: Revert "Bug 16104: Remove warnings "used only once: possible typo"" <http://git.koha-community.org/[…]b7086357c2e5521d0> |
| 15:38 |
|
Joubu |
yep |
| 15:38 |
|
Joubu |
that makes things complicated if it is the case :D |
| 15:38 |
|
pianohacker |
all of this stuff is complicated |
| 15:38 |
|
Joubu |
I will need to rerun a bench of tests, to get numbers with the new patches |
| 15:39 |
|
pianohacker |
I think that is a good idea |
| 15:39 |
|
Joubu |
pianohacker: what do you think about 16166? Are you against the idea? |
| 15:39 |
|
pianohacker |
I quite like it |
| 15:39 |
|
Joubu |
but...? |
| 15:39 |
|
wahanui |
well, but is it right? -a -b -x should abort because -a and -x are not mixable? |
| 15:39 |
|
pianohacker |
no buts :) I just think we should put in as much of this as we can |
| 15:40 |
|
pianohacker |
I think 16140 (with or without the "make everything unsafe!" patch) + 16088 + 16166 would be a great boon |
| 15:41 |
|
Joubu |
pianohacker: ok, I will try to have another look at all of them |
| 15:46 |
|
oleonard |
The icons aren't perfect, but I wonder if this would be useful? http://zivotdesign.com/p/#1/14622039078214 |
| 15:48 |
|
nengard |
i like it |
| 15:49 |
|
oleonard |
It adds a click, but makes the table more compact |
| 15:50 |
|
Joubu |
bye #koha |
| 15:57 |
|
tcohen |
bye Joubu |
| 16:29 |
|
|
mario joined #koha |
| 16:41 |
|
gaetan_B |
bye |
| 16:52 |
|
|
edveal joined #koha |
| 17:27 |
|
|
rocio joined #koha |
| 17:28 |
|
|
rocio joined #koha |
| 17:38 |
|
|
geek_cl joined #koha |
| 17:45 |
|
|
geek_cl joined #koha |
| 17:56 |
|
|
oleonard_ joined #koha |
| 18:00 |
|
|
cait joined #koha |
| 18:40 |
|
|
drojf joined #koha |
| 18:40 |
|
oleonard |
Bug 16421 |
| 18:40 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16421 enhancement, P5 - low, ---, oleonard, ASSIGNED , Move hold edit actions into dropdown menu |
| 18:40 |
|
oleonard |
A revised screenshot of my proposal is attached to that bug. |
| 18:42 |
|
pianohacker |
oleonard: I had an idle thought about drag-and-drop reordering; what are your thoughts on that? |
| 18:44 |
|
oleonard |
I'm torn. It's a non-obvious interaction to most, I'd guess. But if you knew how it worked it would be superior for lists up to a certain size. |
| 18:44 |
|
oleonard |
If the list is too long I think drag and drop would become unwieldy |
| 18:46 |
|
|
oleonard_ joined #koha |
| 18:46 |
|
pianohacker |
oleonard_: agreed |
| 18:51 |
|
* cait |
waves |
| 19:16 |
|
|
ccordova joined #koha |
| 19:16 |
|
ccordova |
wizzyrea : Server version: 5.5.49-0+deb8u1 (Debian) |
| 19:28 |
|
|
magnuse joined #koha |
| 19:42 |
|
eythian |
well that was good. So, when I first booked my kohacon hotel last week, I couldn't get the 28th and 29th. I decided to try again. Was able to adjust the booking for that time, and get a room at a lower per-night rate for the whole time. |
| 19:42 |
|
eythian |
Excellent :) |
| 19:42 |
|
eythian |
*try again tonight |
| 20:04 |
|
cait |
oh |
| 20:04 |
|
cait |
interesting |
| 20:04 |
|
wahanui |
i think interesting is sometimes good and sometimes bad |
| 20:04 |
|
cait |
via booking.com? |
| 20:05 |
|
eythian |
yeah |
| 20:07 |
|
eythian |
I guess someone had cancelled and so I caught whatever opened up. |
| 20:08 |
|
|
meliss joined #koha |
| 20:11 |
|
cait |
cool |
| 20:12 |
|
* eythian |
thinks it's perhaps a pity they won't see my work email address as part of this and upgrade me or something ;) |
| 20:23 |
|
|
cdickinson joined #koha |
| 20:30 |
|
eythian |
I have an excessive amount of photos from the electrische museumtramlijn |
| 20:30 |
|
eythian |
I think I'll have to do the actual writing part tomorrow. |
| 20:32 |
|
cait |
:) |
| 20:45 |
|
tcohen |
bye Koha |
| 20:45 |
|
eythian |
tcohen: you coming to kohacon? |
| 20:45 |
|
tcohen |
nope :-( |
| 20:45 |
|
eythian |
aw pity |
| 20:46 |
|
tcohen |
yeah |
| 20:46 |
|
tcohen |
i'm missing the chance to meet you! |
| 20:46 |
|
tcohen |
i will follow it live if possible! |
| 20:46 |
|
tcohen |
bye! |
| 20:46 |
|
eythian |
that is definitely the worst part of not attending ;) |
| 20:46 |
|
eythian |
later! |
| 20:52 |
|
|
cait left #koha |
| 21:21 |
|
|
Francesca joined #koha |
| 21:22 |
|
|
JoshB left #koha |
| 21:41 |
|
|
florent joined #koha |
| 21:51 |
|
wizzyrea |
florent: https://wiki.koha-community.or[…]h=namespace&go=Go < the first two here |
| 21:53 |
|
|
Francesca joined #koha |
| 21:53 |
|
wizzyrea |
https://wiki.koha-community.or[…]_Koha::_namespace |
| 22:31 |
|
kidclamp |
@later tell Joubu - can you take a look at bug 15840? |
| 22:31 |
|
huginn |
kidclamp: The operation succeeded. |
| 22:31 |
|
wizzyrea |
bug 15840 |
| 22:31 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=15840 major, P3, ---, jonathan.druart, Pushed to Stable , Import borrowers tool explodes if userid already exists |
| 22:31 |
|
wizzyrea |
heh yeah |
| 22:31 |
|
wizzyrea |
that's a bug |
| 22:31 |
|
wizzyrea |
and it's an annoying one |
| 22:31 |
|
wizzyrea |
florent and I were just talking about that |
| 22:32 |
|
kidclamp |
very rarely do you hear "I love that bug!" |
| 22:33 |
|
kidclamp |
Though woe to the man who views a bug as a feature, squashing comes for us all in the end |
| 22:34 |
|
wizzyrea |
https://xkcd.com/1172/ |
| 22:35 |
|
wizzyrea |
kidclamp ^ |
| 22:36 |
|
wizzyrea |
kidclamp: I think we should file a separate bug, if one doesn't exist |
| 22:36 |
|
wizzyrea |
because it's totally a thing, and an annoying one at that |
| 22:36 |
|
wizzyrea |
if there is no userid, we should ignore it. |
| 22:37 |
|
wizzyrea |
or optionally create one |
| 22:42 |
|
kidclamp |
I can do that in a bit wizzyrea - I put the comment there meaning to follow up and then forgot |
| 22:42 |
|
wizzyrea |
sok it happens :) |
| 22:42 |
|
kidclamp |
lol xkcd |
| 22:43 |
|
wizzyrea |
the day I found it, I said exactly the same thing but I was under a bit of pressure to finish a thing |
| 22:43 |
|
wizzyrea |
and didn't >.< |
| 22:44 |
|
wizzyrea |
that xkcd is the best. |
| 23:11 |
|
* Francesca |
waves |
| 23:14 |
|
wizzyrea |
heya |
| 23:17 |
|
|
Francesca joined #koha |
| 23:27 |
|
florent |
yep, yep, I will backport this fix to bug 12598 ... and create a new bug today for the ignored/overwritten import dates. |
| 23:27 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=12598 enhancement, P5 - low, ---, kyle, Patch doesn't apply , New misc/import_borrowers.pl command line tool |
| 23:31 |
|
wizzyrea |
florent++ |
| 23:33 |
|
|
dcook joined #koha |
| 23:37 |
|
|
papa joined #koha |
| 23:47 |
|
|
martin_ joined #koha |
| 23:48 |
|
|
cait joined #koha |
| 23:48 |
|
|
Francesca joined #koha |
