| Time |
S |
Nick |
Message |
| 02:50 |
|
|
cdickinson joined #koha |
| 05:17 |
|
|
mario joined #koha |
| 06:03 |
|
|
irma joined #koha |
| 06:14 |
|
|
dbs joined #koha |
| 06:16 |
|
|
huginn joined #koha |
| 07:47 |
|
|
huginn joined #koha |
| 07:48 |
|
|
dbs joined #koha |
| 09:26 |
|
|
huginn joined #koha |
| 09:37 |
|
|
huginn joined #koha |
| 11:07 |
|
mveron |
Hi everybody |
| 11:08 |
|
mveron |
@wunder Allschwil |
| 11:10 |
|
mveron |
Oh, the Koha statistics website shows one library with Koha version 4.08 ... http://hea.koha-community.org/systempreferences |
| 11:49 |
|
|
dbs joined #koha |
| 11:49 |
|
|
huginn joined #koha |
| 14:12 |
|
|
Joubu joined #koha |
| 14:56 |
|
xarragon |
So when writing unit tests for stuff that fetches things via SQL I use TestBuilder. But how do I write concise tests for things like joins and when stuff is manually added to the stuff? |
| 14:57 |
|
xarragon |
"when stuff is added to the stuff" |
| 14:57 |
|
xarragon |
Yeah, very descriptive question, xarragon. |
| 14:59 |
|
xarragon |
In short, my problem is that tests themselves grows so large and complex that they dwarf the code that they test. |
| 14:59 |
|
xarragon |
And I am not sure that is a good thing. |
| 15:34 |
|
liw |
complex test code is certainly not good |
| 15:34 |
|
liw |
"Test code should be your best code" as I like to say |
| 15:34 |
|
liw |
(no practical advice, though, sorry) |
| 15:36 |
|
|
mario joined #koha |
| 15:42 |
|
xarragon |
liw: Still good to know it should be expected to be simple, thanks. |
| 15:44 |
|
xarragon |
I think the problem is that I check too much, essentially a is_deeply on the DB input/output. I should probably focus on the parts that actually gets touuched by code and modified and change my tests accordingly. |
| 15:45 |
|
xarragon |
Because the SQL that just loads stuff is unlikely to fail. |
| 15:45 |
|
xarragon |
What i need to test is rather that the statement itself filters/selects the right item for given input parameters. |
| 15:48 |
|
|
dbs joined #koha |
| 15:51 |
|
|
huginn joined #koha |
| 17:29 |
|
|
huginn joined #koha |
| 17:46 |
|
xarragon |
Here is an example of the trouble I had with writing concise tests: http://5dbd5b6b75026f20.paste.se/ |
| 18:24 |
|
|
z0k joined #koha |
| 18:24 |
|
xarragon |
Whopsie, that code is actually a bit out-of-date, missing the dateformatting calls. |
| 18:31 |
|
|
nuentoter joined #koha |
| 18:33 |
|
nuentoter |
anyone on here have any experience with running koha on a virtualbox? or at least know-how of how to get it to communicate outside the localhost? |
| 19:02 |
|
xarragon |
Hmm, are all unit tests supposed to work? My current master fails at DateUtils |
| 19:03 |
|
xarragon |
nuentoter: Not running it in a VM, but the network stuff should be easy to help you with. |
| 19:04 |
|
xarragon |
nuentoter: At least the Koha parts. I am a bit rusty on VirtualBox's networking, but just bridging it should be enough. NAT probably requires aport forwarding to the Koha web port. |
| 19:14 |
|
|
cdickinson joined #koha |
| 21:30 |
|
|
huginn joined #koha |
| 22:36 |
|
|
huginn joined #koha |
| 22:47 |
|
|
Francesca joined #koha |
| 22:47 |
|
Francesca |
hi |
| 22:54 |
|
|
Francesca_ joined #koha |
| 23:04 |
|
|
Francesca joined #koha |
| 23:10 |
|
|
tgoatley joined #koha |
| 23:22 |
|
|
dbs joined #koha |
| 23:34 |
|
|
dbs joined #koha |
| 23:39 |
|
|
mario joined #koha |
