Time |
S |
Nick |
Message |
00:00 |
|
|
papa joined #koha |
00:00 |
|
|
papa1 joined #koha |
00:13 |
|
eythian |
looks like the koha list just got unstuck |
00:15 |
|
bag |
oh yeah |
00:25 |
|
* eythian |
adds more cruft to C4::Auth, feels bad. |
00:28 |
|
dcook |
O_O |
00:29 |
|
eythian |
just Yet Another Authentication Method |
00:30 |
|
dcook |
Yeah, I feel that |
00:30 |
|
eythian |
it really needs for checkauth to be broken into modules, then you can just list the modules in koha_conf.xml |
00:30 |
|
dcook |
That would be nice |
00:32 |
|
dcook |
I wonder what could spur changes for Auth |
00:33 |
|
eythian |
how...is there no 'get borrower from userid' ? |
00:33 |
|
eythian |
madness |
00:33 |
|
dcook |
^ |
00:33 |
|
dcook |
That's pretty much what I think when I think C4::Auth |
00:33 |
|
eythian |
oh, C4::Members::GetMember can do it |
00:33 |
|
eythian |
that's ok then |
00:38 |
|
|
papa joined #koha |
01:25 |
|
eythian |
hrm, enabling a new authentication method disables using the database user to log in. |
01:25 |
|
eythian |
that's really really annoying |
01:31 |
|
wizzyrea |
that is annoying. |
01:32 |
|
* eythian |
just puts a password check in, in lieu of refactoring all of C4::Auth to be sane. |
01:39 |
|
dcook |
Yeah, I suppose a person needs to know which auth method to use? |
01:39 |
|
dcook |
Or perhaps I'm not understanding correctly |
01:39 |
|
dcook |
It is C4::Auth after all.. |
02:39 |
|
mtj |
hey koha, does anyone know the steps to populate a koha db, to run the ./t/db_dependant/*.t tests? |
02:42 |
|
wizzyrea |
usually it involves grabbing one of the test db's then running it and see where it dies :/ |
02:44 |
|
mtj |
hmm, how do i grab a test db? |
02:45 |
|
wizzyrea |
I used to have one but it would be ~3.10 era |
02:45 |
|
wizzyrea |
usually it's just requiring the sample data |
02:45 |
|
wizzyrea |
or at least that's an excellent place to start |
02:45 |
|
wizzyrea |
so install -> tick all the boxes |
02:45 |
|
wizzyrea |
but I kinda remember there was other data in there too... |
02:46 |
|
wizzyrea |
but it's fuzzy and way back. I've slept since then. |
02:46 |
|
mtj |
yep :) |
02:47 |
|
mtj |
i think the only way is to manually create yourself a test db |
02:47 |
|
mtj |
seems like something we are missing |
02:56 |
|
wizzyrea |
the jenkins installs should have them |
02:56 |
|
wizzyrea |
idek, I feel like this is a solved problem |
02:56 |
|
wizzyrea |
I just don't properly know the solution |
03:08 |
|
wizzyrea |
get the popcorn is also https://lh4.googleusercontent.[…]ment%2Bstarts.gif |
03:08 |
|
wahanui |
okay, wizzyrea. |
03:08 |
|
wizzyrea |
get the popcorn |
03:08 |
|
wahanui |
I'm a bot, wizzyrea. Not a popcorn transfer technician. |
03:08 |
|
wizzyrea |
tee hee |
03:11 |
|
mtj |
nope, not solved |
03:14 |
|
mtj |
i have a repo thats failling a bunch of db_dependant tests |
03:15 |
|
mtj |
.. i dont know if they are legitimate errors, or if i just have a db thats 'not correct' |
03:16 |
|
eythian |
dcook: well, at the moment you can only have one option, and the "standard" way of doing it bypasses the koha internal password option. |
03:16 |
|
eythian |
which isn't an option in most cases. |
03:17 |
|
eythian |
But if you could say "auth by certificate, if that fails, auth by ldap, if that fails, auth by local password", then that would be great |
03:22 |
|
dcook |
Yeah, that could be handy |
03:23 |
|
dcook |
I just hid the login form for one site that doesn't want local password as an option |
03:23 |
|
dcook |
So that wouldn't really apply there |
03:24 |
|
dcook |
Having a choice of auth options could be handy as well |
03:24 |
|
dcook |
configurable choice* |
03:25 |
|
eythian |
tbh in this case it'll never get to a login prompt on the OPAC |
03:26 |
|
eythian |
but this was also affecting the staff client |
03:28 |
|
mtj |
rangi: any clue re: my Q.. ? ^ |
03:28 |
|
mtj |
..how does someone build a db, to pass the koha db tests? |
03:29 |
|
eythian |
mtj: he's not here |
03:29 |
|
dcook |
Hehe: |
03:29 |
|
dcook |
External Dimensions: 300 (w) x 200 (d) x 200 (h) mm |
03:29 |
|
dcook |
Internal Dimensions: 305(W) x 132 (D) x 195 (H) mm |
03:29 |
|
eythian |
hmm |
03:29 |
|
dcook |
Bigger on the inside? |
03:29 |
|
dcook |
eythian: It'll never get to a login prompt, eh? |
03:29 |
|
mtj |
ta eythian |
03:30 |
|
eythian |
dcook: it has an SSO layer on top |
03:30 |
|
eythian |
so I'm trying to push the SSO creds into koha |
03:30 |
|
dcook |
Mmm, right |
03:37 |
|
eythian |
oh, if I pretend this is basic auth, things should get easier. |
03:38 |
|
eythian |
yay, that seems to work |
03:39 |
|
* eythian |
makes note to self where to pick up next time, proceeds to beer. |
03:39 |
|
dcook |
beer! |
03:40 |
|
dcook |
That reminds me I should have lunch.. |
03:40 |
|
eythian |
I do find it weird that we don't have a session for basic auth. I wonder how that works. |
03:40 |
|
eythian |
Or I'm just reading it wrong. |
03:41 |
|
dcook |
I think maybe you're reading it wrong? |
03:41 |
|
dcook |
Although I think there is something weird with sessions and auth in general |
03:41 |
|
dcook |
I think I filed a bug a little while back |
03:41 |
|
dcook |
Or maybe that was just a local thing |
03:41 |
|
eythian |
hmm, I don't think I am |
03:41 |
|
eythian |
oh well |
03:42 |
|
dcook |
That's future eythian's problem |
03:42 |
|
* eythian |
still wants to get that pile of poo rewritten |
03:42 |
|
dcook |
^ |
03:42 |
|
eythian |
exactly :) |
03:43 |
|
dcook |
Oh... I'd never taken a look at Chrome's SSL settings before |
03:47 |
|
* eythian |
-> beer o'clock |
03:47 |
|
eythian |
later |
03:49 |
|
dcook |
ta |
05:01 |
|
|
chrisvella joined #koha |
05:14 |
|
dcook |
Interesting... the Koha installer appears to be in French.. |
05:14 |
|
dcook |
Must be picking up a past cookie |
05:15 |
|
* dcook |
wonders why we have checkboxes next to the "Mandatory data" items |
05:28 |
|
|
rocio left #koha |
05:33 |
|
|
chrisvella joined #koha |
05:38 |
|
dcook |
@later tell eythian bug 13779 might be relevant for you? |
05:38 |
|
huginn |
dcook: The operation succeeded. |
06:04 |
|
|
cait joined #koha |
06:11 |
|
eythian |
hi cait |
06:11 |
|
eythian |
bye cait |
06:11 |
|
cait |
bye eythian |
06:19 |
|
|
chrisvella_ joined #koha |
06:51 |
|
|
laurence joined #koha |
06:55 |
|
|
magnuse joined #koha |
07:00 |
|
magnuse |
me waves |
07:03 |
|
bag |
me knuckles magnuse |
07:04 |
|
* magnuse |
knuckles bag |
07:05 |
|
bag |
sounds like something you’d buy in a supermarket store - “bags knuckles bag†|
07:20 |
|
magnuse |
hehe |
07:21 |
|
magnuse |
something for the dog to chew on, perhaps? |
07:33 |
|
|
drojf joined #koha |
07:33 |
|
drojf |
moring #koha |
07:34 |
|
drojf |
morning even |
07:34 |
|
drojf |
did the mailing list not work for a few days and just give me a lot of email or is that a problem on my side? |
07:36 |
|
drojf |
according to the log it's not me :) |
07:39 |
|
cait |
nope not you |
07:52 |
|
|
fridolin joined #koha |
07:53 |
|
|
cait left #koha |
07:53 |
|
fridolin |
hie |
07:59 |
|
|
alex_a joined #koha |
07:59 |
|
alex_a |
salut |
08:02 |
|
|
fridolin joined #koha |
08:06 |
|
|
Jul joined #koha |
08:11 |
|
|
codavid joined #koha |
08:12 |
|
|
codavid left #koha |
08:25 |
|
|
Viktor joined #koha |
08:26 |
|
|
mveron joined #koha |
08:26 |
|
mveron |
Good daytime #koha |
08:34 |
|
kivilahtio |
good daytme mveron |
08:36 |
|
Joubu |
o/ |
08:38 |
|
|
paul_p joined #koha |
08:39 |
|
mveron |
Hi kivilahtio and Joubu :-) |
08:41 |
|
|
gaetan_B joined #koha |
08:42 |
|
gaetan_B |
hello |
09:07 |
|
nlegrand |
oyo #koha |
09:09 |
|
|
gerundio joined #koha |
09:10 |
|
kivilahtio |
yoyo |
09:12 |
|
* magnuse |
switches mental context from admin to migration |
09:15 |
|
* nlegrand |
sends good vibes to magnuse |
09:16 |
|
magnuse |
thanks! |
09:38 |
|
|
andreashm joined #koha |
09:39 |
|
|
andreashm_test joined #koha |
09:40 |
|
* mveron |
rebased Bug 4041 - Is signed off by drojf, would be great to see move it forward. |
09:40 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=4041 enhancement, P5 - low, ---, veron, Signed Off , Address Format as a I18N/L10N system preference |
09:42 |
|
|
Viktor joined #koha |
10:01 |
|
|
khall joined #koha |
10:01 |
|
ashimema |
morning |
10:03 |
|
nlegrand |
o/ ashimema |
10:06 |
|
* magnuse |
waves |
10:29 |
|
|
Viktor joined #koha |
10:31 |
|
Joubu |
khall: around? |
10:31 |
|
khall |
yep, what's up? |
10:32 |
|
|
ashimema joined #koha |
10:32 |
|
Joubu |
khall: Hi! I found a major bug. Bug 13713 breaks the "holds" tab of the checkout page |
10:32 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=13713 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Remove useless constraint in Koha::Schema::Result::Biblio |
10:32 |
|
Joubu |
khall: The error is DBIx::Class::ResultSource::_resolve_join(): No such relationship biblionumber on Item at /home/koha/src/svc/holds line 72 |
10:33 |
|
Joubu |
13713 removes the belongs_to biblio in K::S::R::Item |
10:33 |
|
Joubu |
and svc/holds does a search prefetching item => biblio (l.65) |
10:34 |
|
khall |
hmm |
10:34 |
|
Joubu |
khall: the questions are: 1/ Is the prefetch useful? (I don't see any diff on removing it) |
10:34 |
|
Joubu |
and 2/ Is prefetch => { 'item' => 'biblioitemnumber' }, correct? |
10:35 |
|
khall |
the prefetch may make it marginally faster |
10:35 |
|
Joubu |
khall: maybe it's too early for biblioitems related questions :) |
10:35 |
|
khall |
but probably not enough to make any real difference |
10:36 |
|
Joubu |
ha yes you're right (read it 5min ago in the doc but already forgot...) |
10:36 |
|
Joubu |
so we should keep it |
10:37 |
|
Joubu |
it's used indeed |
10:37 |
|
khall |
maybe a benchmark with and without to see if it's worth keeping? |
10:38 |
|
Joubu |
khall: I think it's worth keeping it |
10:38 |
|
khall |
that's good by me |
10:39 |
|
Joubu |
khall: So does the prefetch =>{item => 'biblioitemnumber'} makes sense to you? |
10:39 |
|
drojf |
is there some kind of free software printer access control thingy for libraries? maybe something like libki for printers |
10:39 |
|
khall |
drojf: pykota |
10:39 |
|
drojf |
thanks khall |
10:39 |
|
khall |
np |
10:40 |
|
khall |
Joubu: to replace the current prefetch line? |
10:40 |
|
khall |
or in addition? |
10:40 |
|
Joubu |
khall: yes to replace it |
10:41 |
|
khall |
well, won't that prefetch the biblioitem table, not the biblio table? |
10:42 |
|
Joubu |
yes, but didn't read all the svc/holds script |
10:42 |
|
Joubu |
I have seen my $biblionumber = $h->biblio()->biblionumber(); |
10:43 |
|
Joubu |
but the join is done for the biblio author and title... |
10:44 |
|
Joubu |
so we need to access to the biblio with $h->biblioitem->biblio, not directly $h->biblio |
10:45 |
|
khall |
hmm, that seems even less efficient than dropping the prefetch |
10:45 |
|
Joubu |
Actually I think I need to refresh my mind with the ****** biblioitems table |
10:45 |
|
khall |
lol |
10:46 |
|
khall |
I've been working on a patch series that adds a decent Koha::Hold object, maybe I would just convert the script to using that? |
10:46 |
|
khall |
I can do that now if you would like me to |
10:46 |
|
Joubu |
Is the patches submited somewhere? |
10:46 |
|
Joubu |
are* |
10:46 |
|
khall |
yes, this is the last in the series: http://bugs.koha-community.org[…]_bug.cgi?id=13030 |
10:46 |
|
huginn |
Bug 13030: enhancement, P5 - low, ---, kyle, Signed Off , Show waiting hold expiration date for waiting holds on circulation.pl |
10:48 |
|
khall |
my bad, *this* is the last in the series: http://bugs.koha-community.org[…]_bug.cgi?id=13918 |
10:48 |
|
huginn |
Bug 13918: enhancement, P5 - low, ---, kyle, Needs Signoff , Add waiting expiration date to opac list of holds for user |
11:02 |
|
|
viktorsarge_ joined #koha |
11:52 |
|
|
meliss joined #koha |
11:54 |
|
meliss |
good morning/afternoon/evening |
12:03 |
|
magnuse |
kia ora meliss |
12:03 |
|
magnuse |
and yes, that would be afternoon :-) |
12:04 |
|
meliss |
how are you doing magnuse? |
12:05 |
|
magnuse |
good |
12:06 |
|
magnuse |
in the middle of a migration, looking forward to a bit of easter holiday |
12:06 |
|
magnuse |
and yerself? |
12:06 |
|
meliss |
I am hoping that the snow will melt before easter so that we can have an easter egg hunt outside. |
12:07 |
|
magnuse |
heh, (almost) no snow here :-) |
12:10 |
|
meliss |
:) |
12:15 |
|
|
Dyrcona joined #koha |
12:17 |
|
|
viktorsarge_ joined #koha |
12:24 |
|
|
tcohen joined #koha |
12:24 |
|
tcohen |
morning! |
12:28 |
|
|
drojf1 joined #koha |
12:29 |
|
magnuse |
kia ora tcohen |
12:33 |
|
|
mveron joined #koha |
12:43 |
|
kivilahtio |
tcohen: When you asked if I could setup a Cucumber test stuff for Koha, what did you mean? What I am doing is just another perl script which can be ran from Jenkins no problem. |
12:43 |
|
kivilahtio |
tcohen: So I assume you just tell jenkins to run this script and report errors. |
12:43 |
|
tcohen |
i thought it would be a good idea to have a cucumber server? |
12:43 |
|
|
NateC joined #koha |
12:43 |
|
tcohen |
:q |
12:44 |
|
kivilahtio |
hmmm... a separate Cucumber server? |
12:44 |
|
kivilahtio |
whhhhhhyyy? |
12:44 |
|
drojf |
think like a cucumber, serve like a cucumber |
12:44 |
|
kivilahtio |
is Jenkins going to die? |
12:45 |
|
kivilahtio |
I think we can provide a server for that |
12:45 |
|
tcohen |
nope, but maybe we could benefit from a cucumber server |
12:45 |
|
|
p_vdk joined #koha |
12:45 |
|
tcohen |
i haven't used it |
12:45 |
|
kivilahtio |
we have spare capacity, but I don't have time to learn Jenkins |
12:46 |
|
tcohen |
we have a jenkins server already (thanks biblibre) |
12:49 |
|
kivilahtio |
tcohen: I understood that you don't want to have Cucumbers in the same Jenkins server? |
12:50 |
|
tcohen |
kivilahtio: i didn't know it was integrated inside jenkins |
12:50 |
|
kivilahtio |
tcohen: I havent got a clue. |
12:51 |
|
kivilahtio |
tcohen: I ASSUME that Jenkins just runs a script and gets the script exit value to determine whether or not there was an error. Then it sends the script output to email if errors hapened |
12:52 |
|
tcohen |
kivilahtio: that's what jenkins do right now |
12:52 |
|
kivilahtio |
tcohen: So then just add another scipt to Jenkins to run the Cucumber test harness |
12:52 |
|
tcohen |
i expected cucumber to provide a nicer UI |
12:52 |
|
tcohen |
:-D |
12:52 |
|
kivilahtio |
tcohen: too bad. It is not nice |
12:53 |
|
kivilahtio |
tcohen: but it is so awesome to be able to write in natural language the tests. Then start working on them. IT is just so awesome |
12:53 |
|
kivilahtio |
too bad the Perl implementation is somewhat difficult to use, and I would like to improve the cpan module a bit |
12:53 |
|
kivilahtio |
I havent got a reply fomr the author yet regarding my questions |
12:54 |
|
tcohen |
hmpf |
12:57 |
|
|
JoshB joined #koha |
12:57 |
|
|
andreashm joined #koha |
13:07 |
|
|
mario joined #koha |
13:20 |
|
|
cma joined #koha |
13:59 |
|
fridolin |
tcohen: hie, do you have a moment for us today ? |
14:00 |
|
|
amyjeankearns joined #koha |
14:34 |
|
|
nengard joined #koha |
14:39 |
|
tcohen |
hi fridolin |
14:39 |
|
tcohen |
i do |
14:39 |
|
tcohen |
just finished my presentation |
14:48 |
|
* magnuse |
calls it a week - have fun #koha! |
14:48 |
|
magnuse |
friday? |
14:48 |
|
wahanui |
friday is pizzaday |
14:48 |
|
magnuse |
woohoo! |
14:49 |
|
JesseM |
pizzaday!!! sounds great |
14:50 |
|
amyk |
pizza!? yes please |
15:29 |
|
nlegrand |
now I want a pizza :) |
15:41 |
|
|
rocio joined #koha |
16:10 |
|
|
fridolin left #koha |
16:57 |
|
gaetan_B |
bye |
17:02 |
|
|
hanthana joined #koha |
17:35 |
|
tcohen |
Joubu: any clues about the problem introduced by 5786? |
17:38 |
|
|
amyk_afk joined #koha |
17:49 |
|
mveron |
bye #koha |
17:50 |
|
|
laurence left #koha |
18:05 |
|
* tcohen |
just realized the beauty of vagrant |
18:21 |
|
|
wnickc joined #koha |
18:44 |
|
|
p_vdk joined #koha |
19:02 |
|
|
p_vdk joined #koha |
19:20 |
|
tcohen |
bye #koha |
19:30 |
|
|
wnickc joined #koha |
19:42 |
|
|
nengard left #koha |
21:18 |
|
|
mario left #koha |
21:35 |
|
|
NateC joined #koha |
22:03 |
|
|
NateC joined #koha |