| Time |
S |
Nick |
Message |
| 01:08 |
|
mtompset |
Greetings, #koha. |
| 01:08 |
|
mtompset |
Okay. Best place to read for figuring out how to sign off? |
| 01:08 |
|
jcamins |
sign off? |
| 01:08 |
|
mtompset |
I have a bug report that I'd like to sign off, having done extensive testing on it. :) |
| 01:08 |
|
jcamins |
git? |
| 01:08 |
|
wahanui |
git is, like, http://wiki.koha-community.org[…]Control_Using_Git |
| 01:09 |
|
bgkriegel |
Hi mtompset, that link and http://wiki.koha-community.org[…]gn_off_on_patches |
| 01:09 |
|
jcamins |
That's the one I was looking for. |
| 01:11 |
|
mtompset |
okay, so how would I sign off a multipatch bug? I'm a sign-off virgin. |
| 01:11 |
|
bgkriegel |
that's in http://wiki.koha-community.org[…]_bz_configuration |
| 01:12 |
|
mtompset |
how do I know the commit ids of the patches? |
| 01:12 |
|
bgkriegel |
git log --online | head |
| 01:13 |
|
bgkriegel |
*--oneline |
| 01:15 |
|
mtompset |
okay... I'm not sure how to do this... |
| 01:15 |
|
mtompset |
I clone up an origin/master branch. |
| 01:15 |
|
mtompset |
I git bz apply 10733 |
| 01:16 |
|
mtompset |
^clone^checkout^ |
| 01:16 |
|
mtompset |
then what? |
| 01:16 |
|
mtompset |
I got the ids using the git log command, bgkriegel. |
| 01:17 |
|
mtompset |
The git bz sign off section says to git rebase?! |
| 01:17 |
|
bgkriegel |
yes |
| 01:17 |
|
mtompset |
When I try, it tells me I have changes which aren't commited. |
| 01:18 |
|
bgkriegel |
what gives git status? |
| 01:18 |
|
mtompset |
Let's do this from a brand new branch.... |
| 01:18 |
|
mtompset |
git reset --hard origin/master |
| 01:18 |
|
mtompset |
git bz apply 10733 |
| 01:19 |
|
mtompset |
okay, now what?! |
| 01:19 |
|
bgkriegel |
if you tested and all is ok, the you need to sign |
| 01:19 |
|
mtompset |
HOW?! |
| 01:19 |
|
bgkriegel |
do a git rebase -i |
| 01:20 |
|
mtompset |
The page says, "git rebase 1stcommitid^ --interactive" |
| 01:20 |
|
bgkriegel |
change pick for edit, then git commit --amend -s |
| 01:20 |
|
wahanui |
bgkriegel: that doesn't look right |
| 01:20 |
|
mtompset |
So, I look up the 1stcommitid. |
| 01:20 |
|
|
wahanui joined #koha |
| 01:20 |
|
bgkriegel |
yes |
| 01:20 |
|
bgkriegel |
you do git commit --amend -s for each patch |
| 01:21 |
|
bgkriegel |
and git rebase --continue |
| 01:21 |
|
bgkriegel |
until finish |
| 01:21 |
|
mtompset |
so, now I know the id is 75f1e80. |
| 01:21 |
|
mtompset |
So then I type: |
| 01:22 |
|
mtompset |
okay, weird... it worked. |
| 01:22 |
|
bgkriegel |
heh |
| 01:22 |
|
mtompset |
So, now I'm in an editor. What do I do? |
| 01:23 |
|
bgkriegel |
foreach patch change pick for edit and save |
| 01:23 |
|
mtompset |
Save it, because they are all "pick ... the things I am expecting"? |
| 01:23 |
|
bgkriegel |
from the wiki "Some lines will start with "pick" and you should replace that with "edit" and then save." |
| 01:24 |
|
bgkriegel |
(git bz page) |
| 01:24 |
|
mtompset |
okay, changed to edit, save it now? |
| 01:24 |
|
bgkriegel |
yep |
| 01:27 |
|
mtompset |
God help me... I'm fearful of this process. I don't want to bust or lose any of tcohen's work. |
| 01:28 |
|
bgkriegel |
heh |
| 01:29 |
|
bgkriegel |
do it carefully, as described on the wiki. It's scary but you can't do nothing that can't be undone |
| 01:29 |
|
bgkriegel |
:) |
| 01:31 |
|
mtompset |
I think it I did it correctly. Could you check for me, bgkriegel? |
| 01:31 |
|
mtompset |
It's 10733. |
| 01:31 |
|
bgkriegel |
looking |
| 01:32 |
|
bgkriegel |
seems A-Ok! |
| 01:34 |
|
bgkriegel |
It helps QA team if you comment your tests and if you checked for errrors |
| 01:36 |
|
mtompset |
That's in comment 16. |
| 01:36 |
|
mtompset |
http://bugs.koha-community.org[…].cgi?id=10733#c16 |
| 01:36 |
|
huginn` |
Bug 10733: enhancement, P5 - low, ---, tomascohen, Signed Off , Memcached on package installs |
| 01:37 |
|
bgkriegel |
Oh, right :) |
| 01:38 |
|
mtompset |
I'm sure tcohen was wishing I'd just sign the thing off and let QA catch everything. |
| 01:38 |
|
bgkriegel |
heh |
| 01:38 |
|
mtompset |
I figure more thorough testing makes QA's life easier. |
| 01:39 |
|
jcamins |
Yes, that is the entire point of having people sign off on patches. |
| 01:41 |
|
mtompset |
not to mention. I know he wants this in before feature slush. |
| 01:42 |
|
mtompset |
If I do really good testing, QA is more likely to sign off quickly. |
| 01:44 |
|
bgkriegel |
Well, they have their time and priorities :) |
| 03:16 |
|
mtompset |
Well, I'm calling it quits. |
| 03:16 |
|
mtompset |
Have a great day, #koha. |
| 05:41 |
|
|
cait joined #koha |
| 05:47 |
|
|
cait1 joined #koha |
| 06:05 |
|
cait1 |
@wunder dortmund |
| 06:05 |
|
huginn` |
cait1: The current temperature in Dortmund, Germany is 15.0°C (7:50 AM CEST on September 14, 2013). Conditions: Light Rain. Humidity: 88%. Dew Point: 13.0°C. Pressure: 29.89 in 1012 hPa (Steady). |
| 06:33 |
|
|
kmkale joined #koha |
| 06:34 |
|
kmkale |
hello #koha |
| 07:02 |
|
|
cait1 left #koha |
| 07:21 |
|
|
sophie_m joined #koha |
| 07:30 |
|
|
paul_p joined #koha |
| 07:53 |
|
|
sophie_m left #koha |
| 08:12 |
|
|
amnot joined #koha |
| 08:12 |
|
amnot |
hello |
| 08:13 |
|
amnot |
anyone help me to add some wording i.e NYLS above barcode while printing |
| 12:08 |
|
|
cait joined #koha |
| 12:08 |
|
cait |
jcamins: around? |
| 12:36 |
|
|
cait joined #koha |
| 12:52 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10869 major, P5 - low, ---, mathieu.saby, Needs Signoff , can't delete order line if title deleted |
| 13:37 |
|
cait |
@wunder Konstanz |
| 13:37 |
|
huginn` |
cait: The current temperature in Taegerwilen, Taegerwilen, Germany is 18.4°C (3:15 PM CEST on September 14, 2013). Conditions: Scattered Clouds. Humidity: 75%. Dew Point: 14.0°C. Pressure: 30.04 in 1017 hPa (Falling). |
| 13:42 |
|
|
drnoe left #koha |
| 13:44 |
|
|
talljoy joined #koha |
| 14:55 |
|
|
cait joined #koha |
| 14:55 |
|
cait |
hi #koha |
| 15:01 |
|
talljoy |
hi cait |
| 15:01 |
|
cait |
hi talljoy |
| 15:01 |
|
cait |
:) |
| 15:02 |
|
talljoy |
working saturday? |
| 15:12 |
|
|
tcohen joined #koha |
| 15:13 |
|
|
tcohen joined #koha |
| 15:47 |
|
|
cait joined #koha |
| 15:58 |
|
|
tcohen joined #koha |
| 17:42 |
|
druthb |
@later tell cait Yes, indeed. You read that right. The correct word is "fiancée." |
| 17:42 |
|
huginn` |
druthb: The operation succeeded. |
| 18:33 |
|
|
bgkriegel joined #koha |
| 18:49 |
|
|
Callender joined #koha |
| 19:02 |
|
|
cait joined #koha |
| 19:02 |
|
jenkins_koha |
Starting build #180 for job Koha_3.10.x (previous build: SUCCESS) |
| 19:03 |
|
cait |
:) |
| 19:04 |
|
* druthb |
wriggles happily. |
| 19:06 |
|
cait |
bgkriegel++ |
| 19:06 |
|
bgkriegel |
Hi cait :) |
| 19:06 |
|
cait |
hi bgkriegel :) |
| 19:06 |
|
cait |
super fast translation manager and release maintainer :) |
| 19:06 |
|
cait |
and sign offer! |
| 19:06 |
|
bgkriegel |
heh |
| 19:06 |
|
cait |
bgkriegel++ |
| 19:07 |
|
cait |
:) |
| 19:43 |
|
jenkins_koha |
Project Koha_3.10.x build #180: SUCCESS in 40 min: http://jenkins.koha-community.[…]/Koha_3.10.x/180/ |
| 19:43 |
|
jenkins_koha |
* Fridolyn SOMERS: Bug 10362: ensure that all messages and alerts are shown upon checkin |
| 19:43 |
|
jenkins_koha |
* Sophie Meynieux: Bug 10664: fix error in overdue_notices.pl if there is no active currency |
| 19:43 |
|
jenkins_koha |
* Kyle M Hall: Bug 10664 [QA Followup] - fix error in overdue_notices.pl if there is no active currency |
| 19:43 |
|
jenkins_koha |
* Bernardo Gonzalez Kriegel: Bug 10745: remove more ambiguity for translators for XSLT subfieldSelect parameters |
| 19:43 |
|
jenkins_koha |
* Fridolyn SOMERS: Bug 10543: fix false warnings from checks of mandatory item fields |
| 19:43 |
|
jenkins_koha |
* Fridolyn SOMERS: Bug 10543 - Unify item mandatory subfields check |
| 19:43 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10362 normal, P5 - low, ---, fridolyn.somers, Pushed to Stable , on return with reserve or transfer the alerts are not shown |
| 19:43 |
|
jenkins_koha |
* Fridolyn SOMERS: Bug 10543 - add mandatory subfield check to addorderiso2709.pl |
| 19:43 |
|
jenkins_koha |
* Owen Leonard: Bug 7257: Add a link to remove an individual title from a list in the OPAC |
| 19:43 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10664 normal, P4, ---, sophie.meynieux, Pushed to Stable , Software error in overdue_notices.pl if there is no active currency |
| 19:43 |
|
jenkins_koha |
* Kyle M Hall: Bug 10511: fix message preference form glitch concerning phone notifications |
| 19:43 |
|
jenkins_koha |
* Kyle M Hall: Bug 10511: (follow-up) jQuery .removeAttr() has only one parameter |
| 19:43 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10745 normal, P5 - low, ---, bgkriegel, Pushed to Stable , More fun on translation bug with XSLT subfieldSelect parameters |
| 19:43 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10543 normal, P5 - low, ---, fridolyn.somers, Pushed to Stable , false mandatory warning in additem |
| 19:43 |
|
jenkins_koha |
* Janusz Kaczmarek: Bug 5262: make authority plugin copy indicators to bib record |
| 19:43 |
|
jenkins_koha |
* Fridolyn SOMERS: Bug 10483: fix item uniqueness check on order form |
| 19:43 |
|
huginn` |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7257 enhancement, P5 - low, ---, oleonard, Pushed to Stable , Add a link to remove an individual title from a list |
| 19:43 |
|
jenkins_koha |
* David Cook: Bug 10715 - MARC21 007 Plugin Editor doesn't load position 01 |
| 19:43 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10511 minor, P5 - low, ---, kyle, Pushed to Stable , Odd behavior for messaging preferences with Talking Tech enabled |
| 19:43 |
|
huginn` |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=5262 enhancement, P5 - low, ---, januszop, Pushed to Stable , authority plugin doesn't copy indicators |
| 19:43 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10483 normal, P5 - low, ---, fridolyn.somers, Pushed to Stable , check_uniqueness.pl does not work |
| 19:43 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10715 trivial, P5 - low, ---, dcook, Pushed to Stable , MARC21 007 Plugin Editor doesn't load position 01 |
| 19:44 |
|
|
scom08 joined #koha |
| 19:46 |
|
|
scom08 joined #koha |
| 19:48 |
|
scom08 |
what is ODBC? |
| 19:49 |
|
jcamins |
A database interface, used on Windows. You should not be using ODBC with Koha at all. |
| 19:54 |
|
* cait |
waves |
| 20:00 |
|
|
tcohen joined #koha |
| 20:07 |
|
|
cait joined #koha |
| 21:46 |
|
|
bgkriegel joined #koha |
| 22:13 |
|
|
cait joined #koha |
| 22:47 |
|
jenkins_koha |
Starting build #181 for job Koha_3.10.x (previous build: SUCCESS) |
| 23:27 |
|
jenkins_koha |
Project Koha_3.10.x build #181: SUCCESS in 40 min: http://jenkins.koha-community.[…]/Koha_3.10.x/181/ |
| 23:27 |
|
jenkins_koha |
* Nicole C. Engard: Bug 10703: Add db documentation for biblioimages table |
| 23:27 |
|
jenkins_koha |
* Nicole C. Engard: Bug 10703: Document quotes table |
| 23:27 |
|
jenkins_koha |
* Nicole C. Engard: Bug 10703: Document borrower_files table |
| 23:27 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10703 normal, P5 - low, ---, nengard, ASSIGNED , add/update database documentation |
| 23:27 |
|
jenkins_koha |
* Jonathan Druart: Bug 10481: FIX No enrollment fee when changing patron category. |
| 23:27 |
|
jenkins_koha |
* Jonathan Druart: Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded |
| 23:27 |
|
jenkins_koha |
* Galen Charlton: Bug 10481: (follow-up) fix typo in POD |
| 23:27 |
|
jenkins_koha |
* Owen Leonard: Bug 9238 - make fund pull down say 'select fund', not 'select budget' |
| 23:27 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10481 normal, P5 - low, ---, jonathan.druart, Pushed to Stable , No enrollment fee when changing patron category |
| 23:27 |
|
jenkins_koha |
* Marc Veron: Bug 8887: only display desired result when doing exact syspref search |
| 23:27 |
|
jenkins_koha |
* Kenza Zaki: Bug 10653: add unit tests for C4::RotatingCollections.pm |
| 23:27 |
|
huginn` |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9238 normal, P5 - low, ---, koha-bugs, Pushed to Stable , fund pull down says 'select budget' |
| 23:27 |
|
jenkins_koha |
* Galen Charlton: Bug 10653: (follow-up) minor tweaks to RotatingCollections tests |
| 23:27 |
|
jenkins_koha |
* root: Bug 10642: fix inappropriate uses of $sth->finish() in C4::RotatingCollections.pm |
| 23:27 |
|
huginn` |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8887 normal, P5 - low, ---, koha-bugs, Pushed to Stable , Search preferences: Strange behaviour with exact matches (default instead of custom favicon used, displays to much results) |
| 23:27 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10653 normal, P5 - low, ---, kenza.zaki, Pushed to Stable , UT : C4::RotatingCollections.pm needs unit tests. |
| 23:27 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 10686: Remove fields from searches for highlighting |
| 23:27 |
|
jenkins_koha |
* Jonathan Druart: Bug 10028: fix how ModReceiveOrder() calls NewOrder() |
| 23:27 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10642 normal, P5 - low, ---, kenza.zaki, Pushed to Stable , Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm |
| 23:27 |
|
jenkins_koha |
* Christophe Croullebois: Bug 10573: French translation for printing a basketgroup |
| 23:27 |
|
jenkins_koha |
* Bernardo Gonzalez Kriegel: Bug 10573: (followup) French translation for printing a basketgroup |
| 23:27 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10686 minor, P5 - low, ---, jcamins, Pushed to Stable , Fielded searches confuse highlighter |
| 23:27 |
|
jenkins_koha |
* Galen Charlton: Bug 10573: (follow-up) update license and copyright statement |
| 23:27 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10028 normal, P5 - low, ---, jonathan.druart, Pushed to Stable , ModReceiveOrder works unexpectedly |
| 23:27 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10573 normal, P5 - low, ---, christophe.croullebois, Pushed to Stable , French translation for printing a basketgroup |
| 23:30 |
|
|
mtompset joined #koha |
