| Time |
S |
Nick |
Message |
| 01:07 |
|
|
fredericd joined #koha |
| 01:51 |
|
|
dpk joined #koha |
| 07:27 |
|
magnuse |
\o/ |
| 07:34 |
|
|
reiveune joined #koha |
| 07:35 |
|
reiveune |
hello |
| 08:12 |
|
paulderscheid[m] |
morning #koha |
| 08:19 |
|
|
fridolin joined #koha |
| 08:19 |
|
fridolin |
le bonjour |
| 08:21 |
|
paulderscheid[m] |
bonne soirée |
| 11:12 |
|
|
cait joined #koha |
| 11:16 |
|
* cait |
waves |
| 11:17 |
|
cait |
paulderscheid[m]: I am making my first steps with VSCode and I saw you wrote the instructions on the wiki - I put some notes about setting the RemoteUser to avoid permission issues int he git repository - maybe you could take a look? |
| 11:17 |
|
paulderscheid[m] |
Looking.. |
| 11:17 |
|
cait |
it appears to work nicely afaikt but I am not sure if there is another way/easier way or some other trick I have been missing |
| 11:21 |
|
paulderscheid[m] |
No, you did it exactly right, I think. |
| 11:22 |
|
cait |
maybe we could merge it in with the other instructions |
| 11:23 |
|
cait |
I was not sure about the right sequence, since I did the other steps first |
| 11:25 |
|
|
oleonard joined #koha |
| 11:27 |
|
oleonard |
Hi #koha |
| 11:28 |
|
cait |
hi oleonard |
| 11:29 |
|
cait |
paulderscheid[m]: I am a bit stuck on how to merge things together |
| 11:29 |
|
paulderscheid[m] |
I'm on it. |
| 11:30 |
|
cait |
thank you :) |
| 11:57 |
|
|
oleonard_ joined #koha |
| 12:05 |
|
tcohen |
cait: aren't you on vacation :-P |
| 12:06 |
|
tcohen |
Joubu++ |
| 12:13 |
|
cait |
tcohen: VSCode is a vacation project |
| 12:13 |
|
cait |
but aren't you on vacation as well? |
| 12:16 |
|
tcohen |
we have the carnival holiday, but I'll be working today and tomorrow, then leave |
| 12:17 |
|
cait |
carnival here ends on Wednesday... i am hiding |
| 12:17 |
|
tcohen |
I'm looking at the failed 23.05 tasks on jenkins. |
| 12:18 |
|
tcohen |
I'm not sure why, but jenkins stopped cleaning up after runs, and |
| 12:18 |
|
tcohen |
that's causing us some hard disk issues |
| 12:43 |
|
|
fridolin joined #koha |
| 12:50 |
|
ashimema |
Silly Jenkins |
| 12:52 |
|
cait |
... sounds like it's oerworked and also needs a vacation |
| 12:52 |
|
cait |
stopped cleaning up sounds like burn out |
| 12:57 |
|
magnuse |
lulz |
| 12:57 |
|
cait |
thx magnuse, was starting to get nervous :) |
| 13:22 |
|
tcohen |
LOL |
| 13:25 |
|
ashimema |
LOL |
| 13:25 |
|
ashimema |
how do we feel about input type="time" ? |
| 13:26 |
|
ashimema |
I'm not sure how accessible it is.. and it doesn't really appear to support setting to 12h vs 24h to me |
| 13:26 |
|
cait |
hm I tihnk those could be issues |
| 13:27 |
|
cait |
we have system preferences to set these things |
| 13:27 |
|
ashimema |
yeah.. I thought so too |
| 13:27 |
|
cait |
usually the browser settings interfering is not what we are fond of |
| 13:27 |
|
ashimema |
exactly |
| 13:27 |
|
ashimema |
OK.. I'll continue to convert Aleisha's work from time pickers to text inputs then |
| 13:43 |
|
cait |
paulderscheid++ |
| 13:43 |
|
cait |
ashimema++ |
| 13:45 |
|
paulderscheid[m] |
I think a11y of type="time" is ok. |
| 13:46 |
|
paulderscheid[m] |
At least in chromium. |
| 13:46 |
|
cait |
a11y? |
| 13:46 |
|
paulderscheid[m] |
accessibility |
| 13:46 |
|
cait |
I tihnk the problem is that it follows your language settings in the browser |
| 13:46 |
|
ashimema |
from what I was reading it's really variable between browsers still |
| 13:47 |
|
cait |
if you have set ht epreferences in Koha differently we create inconsistency |
| 13:47 |
|
ashimema |
great for mobile... not so much for desktops |
| 13:47 |
|
paulderscheid[m] |
Yeah firefox not so much. |
| 13:47 |
|
ashimema |
apparently |
| 13:47 |
|
paulderscheid[m] |
What js lib are we using again. |
| 13:47 |
|
paulderscheid[m] |
? |
| 13:47 |
|
ashimema |
we're not for time pickers |
| 13:47 |
|
ashimema |
yet |
| 13:47 |
|
ashimema |
flatpickr for datepickers |
| 13:47 |
|
paulderscheid[m] |
Ah yes, exactly. |
| 13:47 |
|
paulderscheid[m] |
Does it not have a time "mode"? |
| 13:48 |
|
ashimema |
LOL |
| 13:48 |
|
ashimema |
why the **** did I not think to look for that |
| 13:49 |
|
ashimema |
you can stet noCalendar! |
| 13:49 |
|
cait |
i thik it must have something |
| 13:49 |
|
paulderscheid[m] |
https://flatpickr.js.org/examples#time-picker |
| 13:49 |
|
ashimema |
and thus turn it into timepicker only |
| 13:49 |
|
ashimema |
nice one |
| 13:49 |
|
cait |
because we need to set time for checkouts? |
| 13:49 |
|
paulderscheid[m] |
Don't beat yourself up about it, I have these *** moments 10x a day. |
| 13:49 |
|
cait |
paulderscheid++ again heh |
| 13:49 |
|
ashimema |
this is the bug that adds opening/clsing times to branches |
| 13:49 |
|
ashimema |
lol |
| 13:50 |
|
cait |
i know |
| 13:50 |
|
cait |
i meant when checking out, we use the time thing already |
| 13:50 |
|
cait |
becouse hourly loans |
| 13:51 |
|
ashimema |
excellent |
| 13:51 |
|
ashimema |
thanks cait |
| 13:53 |
|
Joubu |
data-flatpickr-enable-time="true" |
| 13:54 |
|
cait |
I'll be around some.... but I have a book shelf in need of reorganizing |
| 13:55 |
|
|
Dyrcona joined #koha |
| 13:56 |
|
ashimema |
I need to also disable date Joubu |
| 13:56 |
|
* ashimema |
is just checking if we have such an option in our wrapper |
| 13:57 |
|
ashimema |
nope |
| 13:57 |
|
ashimema |
we don't have a passthrough for that yet |
| 14:02 |
|
ashimema |
grr |
| 14:02 |
|
paulderscheid[m] |
I merged the content of the wiki cait. Would you take a look and decide whether it's clear enough? |
| 14:02 |
|
ashimema |
our wrapper means that I get dates output even if I select noCalendar |
| 14:07 |
|
ashimema |
Joubu is there a way to disable the 'Yesyerday', Today, Tomorrow buttons we add to flatpickr easily? |
| 14:10 |
|
cait |
will do in a few minutes |
| 14:11 |
|
|
dpk_ joined #koha |
| 14:11 |
|
oleonard-away |
ashimema: Maybe you could modify flatpickr_defaults before calling flatpickr? |
| 14:11 |
|
cait |
ashimema: i believe they don't show in some settings - at least the yesterday doesn't when past dates aren't allowed IIRC |
| 14:12 |
|
ashimema |
mm |
| 14:12 |
|
ashimema |
I was hoping it was a case we already had |
| 14:12 |
|
ashimema |
adding patches to allow for that functionality inline to this patchset feels a bit wrong.. |
| 14:15 |
|
Joubu |
ashimema: search for "flatpickr-pastdate" in calendar.inc |
| 14:15 |
|
Joubu |
if block from line 142 |
| 14:16 |
|
Joubu |
I don't think you can disable the 3 of them, but why would you? |
| 14:16 |
|
ashimema |
I've added options['plugins'] = [] to just drop the plugin outright |
| 14:16 |
|
ashimema |
we won't want the buttons to appear at all for time only pickers.. they don't make sense.. even if 'disabled' |
| 14:16 |
|
ashimema |
because it's TIME only |
| 14:16 |
|
ashimema |
I don't want a full on date picker |
| 14:17 |
|
ashimema |
I've sorted it |
| 14:17 |
|
Joubu |
ok, I didn't have the context |
| 14:17 |
|
Joubu |
I think you need a new data-flatpickr-time-only attribute and deal with it in calendar.inc |
| 14:18 |
|
ashimema |
yup |
| 14:18 |
|
ashimema |
that's exactly what I've done 🙂 |
| 14:30 |
|
tcohen |
are those options documented somewhere? |
| 14:30 |
|
tcohen |
I only see data-flatpickr-enable-time right now |
| 14:31 |
|
ashimema |
they don't exist |
| 14:31 |
|
ashimema |
I've just added one |
| 14:31 |
|
ashimema |
and no.. I don't think they're well documented |
| 14:31 |
|
tcohen |
data-flatpickr-futureinclusive |
| 14:32 |
|
tcohen |
good job for those involved on calendar.inc though. I like it when we are taht consistent |
| 14:32 |
|
tcohen |
:-D |
| 14:33 |
|
ashimema |
as usual, I'm having to do a lot more than I indended to get this up to QA level ☹️ |
| 14:37 |
|
* cait |
sends cookies |
| 14:38 |
|
cait |
paulderscheid[m]: you used footnotes, I am impressed |
| 14:39 |
|
paulderscheid[m] |
Thought it made sense there. |
| 14:44 |
|
cait |
I think i got it |
| 14:44 |
|
cait |
and changed the more global file now |
| 14:46 |
|
cait |
and I broke all the things :D |
| 14:47 |
|
cait |
I have added something else to the conf file and now it doesn't want to open the file to fix it |
| 14:52 |
|
cait |
ok, forgot a comma, fixed |
| 14:54 |
|
paulderscheid[m] |
So it works? :D |
| 14:56 |
|
cait |
I think so? |
| 14:57 |
|
ashimema |
grr |
| 14:57 |
|
tcohen |
Joubu: around? |
| 14:57 |
|
ashimema |
of course.. we don't have the other end either.. i.e. time formatting on output 😐️ |
| 14:57 |
|
ashimema |
for either tt or js ☹️ |
| 14:57 |
|
ashimema |
always expect to be handling full datetimes |
| 14:57 |
|
Joubu |
tcohen: yes |
| 15:07 |
|
cait |
tcohen: the VSCode + Dev Containers now works with all the right permissions, you should try it sometime :) |
| 15:11 |
|
|
kidclamp joined #koha |
| 15:12 |
|
oleonard |
Well well well look who decided to drag themselves out of bed, it's kidclamp! |
| 15:12 |
|
tcohen |
cait: I saw we could add a .devcontainers/config.xml file somewhere <.< |
| 15:12 |
|
kidclamp |
:-) |
| 15:12 |
|
tcohen |
:-D |
| 15:12 |
|
cait |
tcohen: have a look at the solution Paul found - maybe it can still be improved, but for now things seem to be good |
| 15:13 |
|
tcohen |
where should I look at? |
| 15:13 |
|
cait |
https://wiki.koha-community.or[…]ha-testing-docker |
| 15:15 |
|
paulderscheid[m] |
Thanks for proofreading and adjusting the content cait++ |
| 15:15 |
|
cait |
you are welcome - team work :) |
| 15:17 |
|
tcohen |
paulderscheid[m]: why Perlnavigator? |
| 15:17 |
|
tcohen |
I mean, I can switch to it, but wondering what made you choose it |
| 15:18 |
|
paulderscheid[m] |
It just works™️ |
| 15:18 |
|
cait |
from what I have seen it does more than the extensoin you use |
| 15:18 |
|
paulderscheid[m] |
And in neovim + vscode |
| 15:18 |
|
paulderscheid[m] |
Which is a big plus for me. |
| 15:18 |
|
cait |
and I also have symbols for methods now working with only perl navigator |
| 15:19 |
|
paulderscheid[m] |
The only caveat is performance rn. |
| 15:19 |
|
tcohen |
ok, I love this move to language server implementations |
| 15:19 |
|
cait |
it highlighted missing modules, which the Perl one didn't for example |
| 15:19 |
|
tcohen |
but the main advantage would be to make it trigger plack or tests, etc and so being able to set breakpoints, etc |
| 15:19 |
|
cait |
the expert and the noob explaining heh |
| 15:20 |
|
|
khall joined #koha |
| 15:20 |
|
paulderscheid[m] |
Ok, I get what you mean. Maybe not perlnavigator's strong suit. |
| 15:21 |
|
tcohen |
I'll give it a try for sure |
| 15:21 |
|
ashimema |
I like it |
| 15:22 |
|
tcohen |
I like us to use the same toolset as well, more team work dealing with the little annoying details |
| 15:22 |
|
paulderscheid[m] |
perlnavigator is definitely here to stay. At least that's what I think. |
| 15:23 |
|
ashimema |
bscan is active and open to suggestions |
| 15:23 |
|
ashimema |
which is a good sign for perlnavigator |
| 15:23 |
|
ashimema |
I'm liking it in nvim |
| 15:23 |
|
paulderscheid[m] |
That is very true. |
| 15:23 |
|
ashimema |
though there isn't the same sort of container handling yet available for nvim.. which is a shame |
| 15:24 |
|
ashimema |
so to get the best out to pn I had to install all the koha dependancies outside ktd again |
| 15:24 |
|
tcohen |
we could just have nvim in KTD |
| 15:24 |
|
ashimema |
which was shame |
| 15:24 |
|
paulderscheid[m] |
Yeah, that's also true. Though you could try this if you find the time ashimema. https://neovim.io/doc/user/remote.html |
| 15:24 |
|
paulderscheid[m] |
And then tell me how to get it to work :P |
| 15:24 |
|
ashimema |
I went Lazy in the end btw.. It was too much work narrowing down nvim issues.. one fix just lead to another issue each time |
| 15:25 |
|
paulderscheid[m] |
Haven't invested much time yet. |
| 15:26 |
|
paulderscheid[m] |
Would be cool to have nvim in all images and then just pull in your config. |
| 15:27 |
|
tcohen |
we could add `ktd --nvim` |
| 15:27 |
|
ashimema |
🙂 |
| 15:28 |
|
paulderscheid[m] |
I like where this is going. |
| 15:28 |
|
Joubu |
kidclamp: I've pushed a new commit for memberentry, to better fix 'opadd'. Let me know if you agree |
| 15:29 |
|
paulderscheid[m] |
If you consider it, please use v0.8 or higher. |
| 15:29 |
|
Joubu |
kidclamp: And... I had a hard time with reports/guided_reports. Just pushed an other commit to fix it, but a second look (at least testing) would be good. |
| 15:30 |
|
paulderscheid[m] |
Or better yet v0.9 or higher. |
| 15:37 |
|
kidclamp |
will test Joubu |
| 15:51 |
|
|
khall joined #koha |
| 15:59 |
|
tcohen |
bye all |
| 16:00 |
|
|
bag joined #koha |
| 16:16 |
|
fridolin |
bye |
| 16:16 |
|
|
fridolin left #koha |
| 16:21 |
|
kidclamp |
Joubu: Are we okay with using links for the get requests? Do we not want forms just for consistency and being able to identify in the future? I don't mind, just checking |
| 16:24 |
|
Joubu |
what do you want to identify? |
| 16:24 |
|
Joubu |
if you are talking about guided_reports, I have replaced the add_form/list op with links, which is more inline with what we have in other places I think |
| 16:28 |
|
kidclamp |
I guess it doesn't matter - we are reviewing all form submissions, but if they are just links we assume they are stateless |
| 16:30 |
|
Joubu |
if they are links they must be stateless, yes |
| 16:54 |
|
caroline |
I somehow only now discovered the "timeline" tab in About Koha, and went in search of my first ever patch, it was "Add Missing space in parcel.tt (5 years ago) heh! |
| 16:55 |
|
oleonard |
gotta start somewhere! |
| 17:06 |
|
|
khall joined #koha |
| 17:10 |
|
|
khall joined #koha |
| 17:17 |
|
cait |
caroline++ |
| 17:31 |
|
|
khall joined #koha |
| 18:07 |
|
|
khall joined #koha |
| 18:18 |
|
Southpaw1496[m] |
<ashimema> "Like marcedit.. from memory that..." <- I tried setting this up but I couldn't get the z309.50 part to work (it requires installing the z309.50 library externally for some reason), which sort of defeats the purpose. Is there any other software that does this? The only other one I found was [Bibdata](https://bibdata.com) which is Windows-only, so I can't use it easily. |
| 18:20 |
|
ashimema |
Pass I'm afraid |
| 18:20 |
|
ashimema |
It's not something I've personally tried to do in nearly a decade |
| 18:50 |
|
|
khall joined #koha |
| 19:05 |
|
reiveune |
bye |
| 19:05 |
|
|
reiveune left #koha |
| 19:17 |
|
|
khall joined #koha |
| 21:20 |
|
JasonGreene[m] |
on this page, https://www.loc.gov/marc/bibli[…]ic/bdsummary.html what should be used for "editor" |
| 21:21 |
|
caroline |
260$b or 264$b |
| 21:21 |
|
caroline |
that's for publisher |
| 21:22 |
|
caroline |
if it's in the sense of "intellectual editor" like for an anthology or soemthing like that, it would be 700$a |
| 21:22 |
|
JasonGreene[m] |
ok,, my old system has Hard Cover or paperback |
| 21:23 |
|
JasonGreene[m] |
in that field |
| 21:23 |
|
caroline |
ah, then probably 020$q (qualifier for the isbn) or 250$a (edition, like "First edition") |
| 21:24 |
|
JasonGreene[m] |
thanks |
| 21:24 |
|
caroline |
+1 |
