| Time |
S |
Nick |
Message |
| 01:29 |
|
tuxayo |
Where is it possible to find if a hold cancellation reason taken into account? Without setting up emails to check the notification sent to the patron. |
| 01:41 |
|
|
matts_ joined #koha |
| 02:10 |
|
|
cait joined #koha |
| 06:38 |
|
Joubu |
@later tell fridolin please release now! |
| 06:38 |
|
huginn` |
Joubu: The operation succeeded. |
| 06:41 |
|
Joubu |
mtj: around? |
| 07:13 |
|
|
Oak joined #koha |
| 07:18 |
|
|
ammarspv[m] joined #koha |
| 07:20 |
|
ammarspv[m] |
Respected Koha Community,... (full message at <https://matrix.org/_matrix/med[…]gBRPdHmDPVPJboNwB>) |
| 07:29 |
|
ashimema |
We currently don't have any webhooks supported I'm afraid. I'd be interested in what webhooks your keen to have so please submit a bug to bugzilla with a request. |
| 07:29 |
|
ashimema |
API wise, the REST api is comprehensive, but you also have access to bibliographic records via Z39.50/SRU should you be more familiar with those protocols. |
| 07:29 |
|
ashimema |
https://api.koha-community.org[…].html#tag/biblios |
| 07:29 |
|
|
reiveune joined #koha |
| 07:29 |
|
ashimema |
The gotcha in the biblios endpoint on the REST api is that you need to send an Accept header to get back the format of your choosing. |
| 07:29 |
|
reiveune |
hello |
| 07:30 |
|
ashimema |
To use the REST API simply add a user to your Koha and then create an API key for them via the staff client. |
| 07:49 |
|
|
lds joined #koha |
| 07:50 |
|
|
thibaud_g joined #koha |
| 07:53 |
|
ammarspv[m] |
Fantastic - I am building an interesting case backed by Koha - I will be more than happy to share the case study and results once it is ready for testing. In the meantime to bypass the webhook situation, we have created Python script as additional layer that is connected to the Koha DB, and it will triger webhook update to our other system based on the end-points that we define 😁 |
| 07:59 |
|
|
cait1 joined #koha |
| 08:02 |
|
|
cait2 joined #koha |
| 08:09 |
|
mtj |
hi Joubu, about |
| 08:30 |
|
|
alohabot joined #koha |
| 09:08 |
|
|
cait1 joined #koha |
| 09:16 |
|
|
magnuse joined #koha |
| 09:16 |
|
krimsonkharne[m] |
<tuxayo> "Where is it possible to find..." <- I'm not sure, but you might still find the messages in the patron's account on the left side in the tab "Messages" - even if email isn't set up? |
| 09:18 |
|
krimsonkharne[m] |
<tuxayo> "Anyone else to tell if the..." <- > <@tuxayo:matrix.org> Anyone else to tell if the bottom on that UI is good enough despite the buttons going on two lines? https://pic.infini.fr/rTRO8lJI/mLFEXEiQ.png |
| 09:18 |
|
krimsonkharne[m] |
> After the addition of hold cancellation reason when checking out an item that has a waiting hold. (that's a proposed patch I'm reviewing) |
| 09:18 |
|
krimsonkharne[m] |
the text above being left-aligned and the buttons right-aligned is triggering my OCD.. maybe out of scope for that bug |
| 09:18 |
|
krimsonkharne[m] |
also morning #koha :) |
| 09:18 |
|
krimsonkharne[m] |
krimsonkharne[m]: Eh, meant "Notices" tab, not "Messages" |
| 09:18 |
|
* krimsonkharne[m] |
uploaded an image: (25KiB) < https://matrix.org/_matrix/med[…]UTpNPzx/image.png > |
| 09:42 |
|
Joubu |
kidclamp: bug 35284 |
| 09:42 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=35284 major, P5 - low, ---, koha-bugs, NEW , No more delay between 2 DT requests |
| 09:46 |
|
magnuse |
is the weblate system available to everyone yet? i can't seem to find a url |
| 09:51 |
|
Joubu |
magnuse: I sent you the link |
| 10:55 |
|
|
khall joined #koha |
| 11:01 |
|
paulderscheid[m] |
hi #koha |
| 11:01 |
|
paulderscheid[m] |
Anyone every try to write unit tests for plugin modules? |
| 11:12 |
|
paulderscheid[m] |
To be more precise: using transactions. |
| 11:34 |
|
|
khall_ joined #koha |
| 11:40 |
|
paulderscheid[m] |
khall? |
| 11:41 |
|
paulderscheid[m] |
Or rather khall_? |
| 11:41 |
|
khall_ |
paulderscheid[m] sounds doable, have you seen my plugin unit tests? |
| 11:41 |
|
paulderscheid[m] |
:D |
| 11:42 |
|
khall_ |
you could start by copying those and then using built-in plugin related tests as a foundation |
| 11:42 |
|
paulderscheid[m] |
Yeah, but you dont' have transactions in there, right? |
| 11:43 |
|
|
oleonard joined #koha |
| 11:43 |
|
khall_ |
paulderscheid[m] that is correct, but you should be able to use the tests in Koha as a basis, those should have transactions iirc |
| 11:44 |
|
paulderscheid[m] |
Well, I have the most interesting bug then. If you got the time try to install a plugin that uses the api hook and then try to run the tests in koha. Everything with a transaction will fail, even though the spec will be valid. |
| 11:47 |
|
Joubu |
paulderscheid[m]: which error do you get? |
| 11:47 |
|
paulderscheid[m] |
One sec |
| 11:48 |
|
Joubu |
git grep "FIXME: CGI::Session::Driver::DBI" t/db_dependent/api/ |
| 11:48 |
|
Joubu |
seen that? |
| 11:50 |
|
tcohen[m] |
hola #koha o/ |
| 11:51 |
|
paulderscheid[m] |
Don't know whether this is related but the problem I encounter is that after you begin a transaction, the $builder->build_object will only return undef. If you don't wrap it in a transaction it works. |
| 11:51 |
|
paulderscheid[m] |
That's why all tests fail that use transactions. |
| 11:51 |
|
paulderscheid[m] |
And obviously if you remove the plugin it starts working again as well. |
| 11:55 |
|
tcohen[m] |
paulderscheid: I'm late in the conversation, but what you're trying to do? |
| 11:55 |
|
paulderscheid[m] |
Running unit tests for plugin modules w/ an installed plugin. |
| 11:56 |
|
tcohen[m] |
do you install the plugin before running the tests? |
| 11:56 |
|
paulderscheid[m] |
Yes |
| 11:56 |
|
tcohen[m] |
or inside the tests |
| 11:56 |
|
paulderscheid[m] |
Beforehand |
| 11:57 |
|
paulderscheid[m] |
What I'm trying to do is: |
| 11:57 |
|
paulderscheid[m] |
- Install the plugin. |
| 11:57 |
|
paulderscheid[m] |
- Run the tests that ship w/ the plugin inside ktd. |
| 11:57 |
|
tcohen[m] |
nice |
| 11:58 |
|
tcohen[m] |
if you have it somewhere, I would like to take a look |
| 11:58 |
|
tcohen[m] |
because I've been meaning to add tests for the plugins I maintain for a while |
| 12:00 |
|
ashimema |
add me to the interested parties list 😜 |
| 12:01 |
|
paulderscheid[m] |
Here's is the one test file I wrote so far: https://github.com/LMSCloud/LM[…]t/target_groups.t |
| 12:02 |
|
paulderscheid[m] |
What I did is to install the plugin and then copy the test inside of the container and try to prove it. |
| 12:03 |
|
paulderscheid[m] |
But just installing the plugin causes every $builder->build_object call to return undef when wrapped in a transaction. |
| 12:03 |
|
paulderscheid[m] |
Also for everything under t/db_dependent/api/v1/ |
| 12:09 |
|
paulderscheid[m] |
And it would be great to get this working in pipelines as well :P |
| 12:09 |
|
paulderscheid[m] |
Not related though. |
| 12:10 |
|
tcohen[m] |
you should mount the plugin as we do with the ktd command |
| 12:10 |
|
tcohen[m] |
but that's unrelated as well |
| 12:14 |
|
paulderscheid[m] |
Yeah, I will move it into the kpz as I already use ktd --plugin up. Thanks again for adding that by the way tcohen++. Just wanted to test it out before committing to writing tests for everything. |
| 12:22 |
|
tcohen[m] |
you use github, right? |
| 12:22 |
|
paulderscheid[m] |
Yes |
| 12:22 |
|
tcohen[m] |
talk to khall |
| 12:23 |
|
tcohen[m] |
he's got a nice pipeline already |
| 12:23 |
|
tcohen[m] |
I do, but for gitlab |
| 12:23 |
|
paulderscheid[m] |
I'm already copying his work :D |
| 12:23 |
|
tcohen[m] |
he's already running some tests |
| 12:23 |
|
tcohen[m] |
inside KTD |
| 12:23 |
|
tcohen[m] |
barely compilation tests |
| 12:23 |
|
tcohen[m] |
but all the boilerplate is done |
| 12:24 |
|
tcohen[m] |
he also checks in different Koha versions to see where it fails |
| 12:24 |
|
paulderscheid[m] |
Yep, I already got the 00-load.t on my plugins. |
| 12:25 |
|
paulderscheid[m] |
Works great. |
| 12:34 |
|
|
cait joined #koha |
| 12:35 |
|
|
oleonard joined #koha |
| 12:36 |
|
|
cait joined #koha |
| 12:40 |
|
|
lds joined #koha |
| 12:42 |
|
* cait1 |
waves |
| 12:47 |
|
|
cait joined #koha |
| 12:56 |
|
|
cait1 joined #koha |
| 13:05 |
|
|
blou joined #koha |
| 13:07 |
|
|
cait joined #koha |
| 13:35 |
|
|
khall joined #koha |
| 13:42 |
|
magnuse |
got a problem with elastic indexing. background jobs are stuck at "new". nothing in the logs. koha-indexer says it is running. koha-worker --queue elastic_index has been restarted. anyone else seen that? i'm running out of ideas... |
| 13:43 |
|
magnuse |
koha 22.11.10, elasticsearch 7.16.2 |
| 13:44 |
|
magnuse |
tried stopping koha-worker, stopping rabbit and starting koha-worker (and all its queues) again, but that didn't help |
| 13:45 |
|
Joubu |
something maybe in background_jobs.data? |
| 13:47 |
|
magnuse |
Joubu: for example: {"record_ids":["7166"],"record_server":"biblioserver"} |
| 13:50 |
|
magnuse |
jobs like batch_item_record_modification run as they should, just not the update_elastic_index ones |
| 13:50 |
|
Joubu |
it's a separate worker |
| 13:51 |
|
Joubu |
maybe not in 22.11 |
| 13:51 |
|
Joubu |
bug 32594 |
| 13:51 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32594 critical, P5 - low, ---, nick, RESOLVED FIXED, Add a dedicated ES indexing background worker |
| 13:53 |
|
Joubu |
koha-es-indexer |
| 13:55 |
|
magnuse |
"* ES indexing daemon not running for <instance>" |
| 13:55 |
|
magnuse |
that would do it... |
| 13:58 |
|
magnuse |
Joubu++ thanks a ton! |
| 14:06 |
|
Joubu |
danyon nick? |
| 14:06 |
|
Joubu |
@later tell danyon commit 4945422d322bc40bfd90a60231367e45fd734b03 is wrong |
| 14:06 |
|
huginn` |
Joubu: The operation succeeded. |
| 14:06 |
|
Joubu |
@later tell aleisha please tell Danyon that commit 4945422d322bc40bfd90a60231367e45fd734b03 is wrong |
| 14:06 |
|
huginn` |
Joubu: The operation succeeded. |
| 14:07 |
|
|
cait1 joined #koha |
| 14:07 |
|
Joubu |
@later tell wainuiwitikapark please tell Danyon that commit 4945422d322bc40bfd90a60231367e45fd734b03 is wrong |
| 14:07 |
|
huginn` |
Joubu: The operation succeeded. |
| 14:07 |
|
Joubu |
but, really really wrong... |
| 14:08 |
|
Joubu |
how-to.pl | 1 + |
| 14:08 |
|
Joubu |
installer/data/mysql/atomicupdate/bug_22188_-_add_pubdatepatternformat_column_serial.perl | 8 + |
| 14:08 |
|
Joubu |
koha-tmpl/intranet-tmpl/prog/en/modules/how-to.tt | 1 + |
| 14:08 |
|
Joubu |
koha-tmpl/intranet-tmpl/prog/js/vue/dist/erm.js |
| 14:08 |
|
|
Dyrcona joined #koha |
| 14:11 |
|
kidclamp |
joubu - I saw that, I have played around in the past and was unable to get things working |
| 14:13 |
|
Joubu |
We can easily add a 500ms delay, but it's not exactly what we want |
| 14:13 |
|
Joubu |
The examples in the DT forum should work |
| 14:19 |
|
ashimema |
magnuse around still |
| 14:20 |
|
tcohen[m] |
@later tell aleisha please look at commit 4945422d322bc40bfd90a60231367e45fd734b03 and ping me, or better email |
| 14:20 |
|
huginn` |
tcohen[m]: The operation succeeded. |
| 14:20 |
|
ashimema |
how well is Libris backend maintained? Have you considered migrating from YAML::Syck to YAML::XS? |
| 14:21 |
|
ashimema |
we're getting ''' is empty or non-existent at /usr/lib/x86_64-linux-gnu/perl5/5.36/YAML/Syck.pm line 114.' errors trying to use it with 22.11 |
| 14:22 |
|
magnuse |
ashimema: here |
| 14:23 |
|
magnuse |
it is used by quite a number of libraries, at least. also some that have upgraded to 22.11 recently |
| 14:24 |
|
ashimema |
coolios |
| 14:24 |
|
ashimema |
I think it might be some ILL backports we have in our .11 branch.. we run slightly ahead |
| 14:25 |
|
magnuse |
and it's not that the config file is empty or missing or broken? |
| 14:26 |
|
ashimema |
I'll take a look, thanks |
| 14:50 |
|
kidclamp |
Joubu there was a later example where they caught anything less than 3 characters, but that also isn't really what we want |
| 14:53 |
|
Joubu |
kidclamp: https://datatables.net/forums/[…]8/#Comment_149688 |
| 14:53 |
|
Joubu |
this one looks good |
| 14:53 |
|
Joubu |
it needs to test if serverside is true however |
| 15:03 |
|
|
alohabot` joined #koha |
| 15:45 |
|
|
matts joined #koha |
| 15:50 |
|
|
alohabot joined #koha |
| 16:00 |
|
|
bag joined #koha |
| 16:02 |
|
|
lukeg joined #koha |
| 16:30 |
|
kidclamp |
I'll test if you submit a patch Joubu |
| 17:32 |
|
|
caroline joined #koha |
| 17:59 |
|
|
jzairo joined #koha |
| 18:30 |
|
|
cait1 left #koha |
| 18:49 |
|
reiveune |
bye |
| 18:49 |
|
|
reiveune left #koha |
| 18:54 |
|
|
bag joined #koha |
| 18:56 |
|
|
blou joined #koha |
| 19:07 |
|
|
cait joined #koha |
| 19:33 |
|
oleonard |
The amount of time I just lost to debugging because I didn't realize my HTML customization wouldn't be "published" until tomorrow :( |
| 19:45 |
|
|
blou joined #koha |
| 19:54 |
|
|
alohabot joined #koha |
| 19:54 |
|
tuxayo |
krimsonkharne: «but you might still find the messages in the patron's account on the left side in the tab "Messages" - even if email isn't set up» Nope :( |
| 20:08 |
|
|
fridolin joined #koha |
| 20:08 |
|
|
fridolin joined #koha |
| 20:08 |
|
fridolin |
yllow |
| 20:16 |
|
tuxayo |
fridolin: 🟡 |
| 20:21 |
|
tuxayo |
huh, testing a hold patch between yesterday and today: checking in an item on hold doesn't trigger anything related to a hold existing >_< |
| 20:21 |
|
tuxayo |
Still works on yesterday's main/master |
| 20:22 |
|
tuxayo |
(bisecting in progress) |
| 20:24 |
|
tuxayo |
Seems not already reported. |
| 20:38 |
|
tcohen[m] |
maybe 17617? |
| 20:53 |
|
tcohen[m] |
tuxayo: did you find the culprit commit? |
| 20:54 |
|
tuxayo |
bug 31041 |
| 20:54 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=31041 normal, P5 - low, ---, lucas, Pushed to master , Cashup summary modal printing issue |
| 20:54 |
|
tuxayo |
ef880e349f (HEAD) Bug 31041: (follow-up) Clean up and generalise |
| 20:54 |
|
tuxayo |
Opening a ticket and adding a comment in 31041 |
| 20:54 |
|
tuxayo |
blocker, right? |
| 20:54 |
|
tcohen[m] |
@later tell ashimema bug 31041 broke the item trapped for hold modal |
| 20:54 |
|
huginn` |
tcohen[m]: The operation succeeded. |
| 20:55 |
|
tcohen[m] |
yes, please |
| 20:55 |
|
tcohen[m] |
blocker and rel_23_11_candidate |
| 20:55 |
|
tuxayo |
ok :) |
| 20:55 |
|
tcohen[m] |
tuxayo++ |
| 20:59 |
|
tuxayo |
Bug 35295 |
| 20:59 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=35295 blocker, P5 - low, ---, koha-bugs, NEW , No hold modal when checking in an item of a held record |
| 21:09 |
|
|
dolf joined #koha |
| 21:21 |
|
lukeg |
tuxayo: I think that is an easy fix, I put a patch up if you want to test! |
| 21:34 |
|
|
blou joined #koha |
| 21:57 |
|
davidnind |
lukeg: testing now for you... |
| 22:00 |
|
davidnind |
testing complete - now signed off |
| 22:00 |
|
|
khall joined #koha |
| 22:01 |
|
ashimema |
<oleonard> "The amount of time I just lost..." <- Haha, I've done this soo many times |
| 22:05 |
|
ashimema |
Wow, I'm confused by that |
| 22:05 |
|
ashimema |
Thanks for the patch there lukeg |
| 22:06 |
|
|
fridolin left #koha |
| 22:09 |
|
lukeg |
Thanks davidnind! |
| 22:10 |
|
ashimema |
So was the modal just not triggering at all |
| 22:11 |
|
* ashimema |
is reading code on his phone.. probably not great for trying to understand how I broke stuff there |
| 22:14 |
|
lukeg |
ashimema: the asset was just misplaced |
| 22:14 |
|
lukeg |
it was inside a <script> tag |
| 22:15 |
|
lukeg |
so it caused a JS error: unexpected < |
| 22:15 |
|
ashimema |
Ah, I see |
| 22:15 |
|
ashimema |
Thanks |
| 22:16 |
|
ashimema |
The js error gives it away I suppose |
| 22:17 |
|
ashimema |
I spent too much time refining bug 30287 the last few days. |
| 22:17 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30287 normal, P5 - low, ---, martin.renvoize, Needs Signoff , Notices using HTML render differently in notices.pl |
| 22:18 |
|
ashimema |
Silly little fixes around notices enticed me too much. Lol |
| 22:18 |
|
ashimema |
Back to EDI tomorrow.. far less fun |
| 22:18 |
|
lukeg |
ashimema: I'll try to have a look at that one now |
| 22:19 |
|
ashimema |
No worries.. it's a minor bug really.. just one I kinda liked in the end. |
| 22:22 |
|
ashimema |
I removed the 'pre' wrapping on that one in the end.. it didn't look as nice though was theoretically more accurate... But I found a nicer CSS style based alternative I use in the follow-up bug. |
| 22:22 |
|
ashimema |
Anywho . Time for bed here |
| 22:23 |
|
ashimema |
Have a good one #koha |
| 22:23 |
|
davidnind |
ashimema++ |
| 23:09 |
|
dcook |
lukeg You always seeem to be up at the moment but I guess it is still just afternoon in the US! |
