| Time |
S |
Nick |
Message |
| 00:03 |
|
tcohen[m] |
dcook: glorious |
| 00:09 |
|
dcook |
Of course I can't reproduce the problem on master :p |
| 00:09 |
|
dcook |
Just older versions haha |
| 00:43 |
|
dcook |
Ah perhaps not just older versions. Looks like it's probably related to MariaDB/MySQL client libraries |
| 00:43 |
|
dcook |
<-- nerd |
| 01:38 |
|
dcook |
You still around tcohen[m]? |
| 04:09 |
|
|
dcook_ joined #koha |
| 06:08 |
|
|
marcelr joined #koha |
| 06:08 |
|
marcelr |
o/ |
| 06:16 |
|
TriveniChandriki[m] |
Good morning all |
| 06:17 |
|
TriveniChandriki[m] |
Can we generate QR code in koha. We need barcode for QR code |
| 06:38 |
|
davidnind |
Can you explain your question a bit more? |
| 06:43 |
|
davidnind |
You can use the barcode image generator tool to generate a QR code (Cataloguing > Tools > Barcode image generator) |
| 06:45 |
|
davidnind |
You can use the OPACDetailQRCode system preference to show a QR Code on the OPAC bibliographic detail page (for more detail see https://bywatersolutions.com/e[…]odes-on-the-opac) |
| 06:45 |
|
|
reiveune joined #koha |
| 06:46 |
|
reiveune |
hello |
| 06:54 |
|
TriveniChandriki[m] |
<davidnind> "You can use the barcode image..." <- 21. 05 version I am using. Can do this version |
| 06:54 |
|
krimsonkharne[m] |
morning #koha |
| 06:56 |
|
davidnind |
Triveni Chandriki: I was using master - check under Tools (it was moved to under Cataloguing in a later version than you are using) |
| 06:57 |
|
TriveniChandriki[m] |
Ok |
| 06:59 |
|
|
thibaud_g joined #koha |
| 07:14 |
|
|
dpk_ joined #koha |
| 07:14 |
|
davidnind |
Triveni Chandriki: The barcode image generator tool was added in 22.05 8-( - see bug 29821 |
| 07:14 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29821 enhancement, P5 - low, ---, oleonard, CLOSED FIXED, Add interface for generating barcodes using svc/barcode |
| 07:22 |
|
|
fridolin joined #koha |
| 08:10 |
|
TriveniChandriki[m] |
<davidnind> "Triveni Chandriki: The barcode..." <- Single barcode we can take new version. But old version not available |
| 08:11 |
|
TriveniChandriki[m] |
QR code barcode |
| 08:17 |
|
ashimema |
morning |
| 08:18 |
|
marcelr |
hi ashimema |
| 08:18 |
|
marcelr |
i will add a few questions on 29523 for you |
| 08:18 |
|
ashimema |
just starting to go through bug 32305 as promised marcelr |
| 08:18 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32305 major, P5 - low, ---, m.de.rooy, Signed Off , Background worker doesn't check job status when received from rabbitmq |
| 08:19 |
|
ashimema |
okies.. will take a look at questions next 🙂 |
| 08:19 |
|
ashimema |
thanks |
| 08:27 |
|
Joubu |
"wrong queue", how is that possible? |
| 08:27 |
|
Joubu |
Are we trying to catch all the impossible? |
| 08:30 |
|
ashimema |
? Joubu |
| 08:31 |
|
ashimema |
what's that in relation to? |
| 08:35 |
|
marcelr |
Joubu you are exaggerating a bit ? |
| 08:35 |
|
marcelr |
We do this in the DB branch: my $jobs = Koha::BackgroundJobs->search({ status => 'new', queue => \@queues }); |
| 08:35 |
|
marcelr |
so we should do it consistently |
| 08:36 |
|
marcelr |
note that i did not spend just 5 minutes on it |
| 08:59 |
|
Joubu |
marcelr: that's not the same. For the DB you don't have the ID of the job |
| 08:59 |
|
Joubu |
so you are fetching all the jobs from a given queue |
| 09:00 |
|
Joubu |
if the worker is getting an ID from the MQ it's not possible that the ID is from another queue. |
| 09:08 |
|
|
dcook__ joined #koha |
| 09:09 |
|
ashimema |
is bug 33537 back to ready for qa? |
| 09:09 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33537 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Move domain limits from koha-conf to staff SMTP configuration |
| 09:09 |
|
ashimema |
is that one you wanted to finish up qa on Joubu? |
| 09:10 |
|
ashimema |
I will admit I asked myself the same question regarding do we need queue + id in that query.. but I also came to the conclusion that is doesn't hurt.. hence my passing.. do you disagree and think it will hurt on bug 32305 Joubu? |
| 09:10 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32305 major, P5 - low, ---, m.de.rooy, Passed QA , Background worker doesn't check job status when received from rabbitmq |
| 09:11 |
|
Joubu |
it won't hurt, but it's useless |
| 09:11 |
|
Joubu |
so why having it if it's not needed? :) |
| 09:11 |
|
Joubu |
it adds confusion IMO |
| 09:12 |
|
marcelr |
well, we can remove the queue off course but status is the clouy |
| 09:12 |
|
marcelr |
clou |
| 09:12 |
|
marcelr |
crux |
| 09:12 |
|
marcelr |
if there is consensus about that, i will do an edit |
| 09:13 |
|
marcelr |
ashimema: 33537 needs qa by someone before 30th |
| 09:17 |
|
Joubu |
ashimema: I didn't manage to do what I wanted with bug 33537 (ie. make some Vue stuffs available from outside), I will need more time for that. So please QA if you can. |
| 09:17 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33537 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Move domain limits from koha-conf to staff SMTP configuration |
| 09:17 |
|
Joubu |
as said earlier this week, I don't think we should go this way. We have simplified all this in Vue app, and now we will have yet another ways to request the REST API from Koha |
| 09:18 |
|
Joubu |
we need either to make Vue/fetch available from outside, or write a generic fetch for non-Vue code |
| 09:18 |
|
Joubu |
but I won't block 33537 for that, I don't have time to do it right now |
| 09:19 |
|
Joubu |
nor during the next month.. |
| 09:19 |
|
Joubu |
paulderscheid[m]: where are you with Cities/Vue? |
| 09:20 |
|
paulderscheid[m] |
I'll commit something til sunday, where did you say this should go again? |
| 09:22 |
|
ashimema |
I see.. I've not dug into the code deeply yet.. I stopped as soon as I saw you were on it before Joubu 🙂 |
| 09:22 |
|
ashimema |
I'll have a little look now, see if I understand what you mean. |
| 09:23 |
|
marcelr |
Joubu, ashimema : reverting this to vue is something for a new report and in the new cycle; this should go now on its own |
| 09:23 |
|
ashimema |
yup.. |
| 09:24 |
|
ashimema |
I certainly need to have a look at the code and give it a test though before a PQA outright 😜 |
| 09:24 |
|
marcelr |
sure |
| 09:24 |
|
marcelr |
Pedro did a good job at signoff btw |
| 09:24 |
|
Joubu |
paulderscheid[m]: didactic example of how move an existing module to Vue, or create a whole new (simple) module |
| 09:25 |
|
ashimema |
yeah, Pedro is great |
| 09:25 |
|
ashimema |
I'm proud to have him on the team |
| 09:25 |
|
marcelr |
PedroAmorim[m]++ |
| 09:26 |
|
marcelr |
ashimema: the follow-up was there before you posted :) |
| 09:27 |
|
marcelr |
ashimema: the term unredact is just a bit unknown for me as non-native speaker, i wont suggest a new name here |
| 09:28 |
|
ashimema |
awesome |
| 09:28 |
|
ashimema |
I'm not actually sure it's a real word if I'm 100% honest |
| 09:29 |
|
marcelr |
yes i found it |
| 09:29 |
|
ashimema |
approved_list |
| 09:29 |
|
ashimema |
though I'm not sure that's as obvious as to it's function in terms of being the oposite of redact |
| 09:29 |
|
marcelr |
it is somehting like uncensored or un-edited |
| 09:30 |
|
ashimema |
we already have 'public' list, which is really similar in function but slight different in end result |
| 09:30 |
|
ashimema |
uncensored |
| 09:30 |
|
ashimema |
that's nice |
| 09:30 |
|
ashimema |
yeah.. it's exactly that |
| 09:30 |
|
marcelr |
after looking it up, it was fine |
| 09:31 |
|
ashimema |
names are hard 😧 |
| 09:32 |
|
marcelr |
not saying anything about libraries_where_can_see_things can_see_things_from libraries_where_can_see_patrons |
| 09:32 |
|
ashimema |
yeah.. those are confusing as! |
| 09:32 |
|
marcelr |
just nothing from me about those names |
| 09:32 |
|
ashimema |
though every time I've tried to come up with clearer names I've come unstuck |
| 09:42 |
|
ashimema |
silly question |
| 09:42 |
|
ashimema |
couldn't we use input type="number" for your 'Message limit' field? |
| 09:44 |
|
marcelr |
no not silly, it sounds ok to me now, not sure why i chose something complicated there |
| 09:44 |
|
marcelr |
regex or so ? |
| 09:44 |
|
marcelr |
or could you add 2.3 then ? |
| 09:44 |
|
ashimema |
the regex and stuff isn't a bad idea for belt and braces |
| 09:44 |
|
marcelr |
maybe thats it |
| 09:44 |
|
marcelr |
no decimals? |
| 09:44 |
|
ashimema |
but giving it the correct type would help things semantically |
| 09:44 |
|
ashimema |
decimals work in number types I believe |
| 09:45 |
|
* ashimema |
tried |
| 09:45 |
|
marcelr |
i dont remember anymore but i guess that was the reason.. |
| 09:45 |
|
ashimema |
Units would also be number right? |
| 09:45 |
|
marcelr |
you want an integer |
| 09:45 |
|
marcelr |
same for units, yes |
| 09:45 |
|
paulderscheid[m] |
Just to chime in, input type="number is now discouraged for a11y reasons. |
| 09:46 |
|
ashimema |
I'd also be tempted to switch 'Units' for 'Period' to denote it's a period of time.. once you spot the 'Unit type' is 'days, hours, minutes' it becomes obvious.. but at first glance it missed me |
| 09:46 |
|
ashimema |
ah.. OK paulderscheid |
| 09:46 |
|
ashimema |
I have a vague recollection of that now to say it. |
| 09:47 |
|
paulderscheid[m] |
There's input type="text" pattern="[0-9]*" inputmode="numeric" |
| 09:47 |
|
ashimema |
doh |
| 09:47 |
|
ashimema |
I even wrote the guidelines! https://wiki.koha-community.or[…]ACC2:_Input_type_.22number.22_should_be_avoided |
| 09:47 |
|
marcelr |
fun |
| 09:47 |
|
paulderscheid[m] |
And you can adjust the pattern for decimals too I believe |
| 09:48 |
|
ashimema |
slightly annoying my go to form filler doesn't spot the pattern or inputmode though 😛 |
| 09:48 |
|
paulderscheid[m] |
That sucks |
| 09:48 |
|
paulderscheid[m] |
Ah it's even in the guidelines :D |
| 09:49 |
|
paulderscheid[m] |
Great stuff! |
| 09:49 |
|
paulderscheid[m] |
Also just recently learned about it. Like a couple months ago (after the a11y talk at kohaCon I believe) |
| 09:50 |
|
ashimema |
anyone got any better filler extentions than FakeFiller 😜 |
| 09:52 |
|
ashimema |
next question.. what made you opt for on click functions and things.. as apposed to going with the bootstrap 'on('shown.bs.modal' type approach we have elsewhere marcelr? |
| 09:53 |
|
ashimema |
I agree with Joubu around introducing another different pattern |
| 09:53 |
|
ashimema |
if the intention is to switch to vue eventually anyway I'm fine with it.. but wondered why you chose to write it differently to the existing patterns? |
| 09:56 |
|
marcelr |
hmm good question, dont have the details in my mind anymore must admit |
| 09:56 |
|
ashimema |
okies |
| 09:56 |
|
ashimema |
ooh.. I have a meeting to head into |
| 09:56 |
|
ashimema |
will come back |
| 09:56 |
|
marcelr |
i think Pedro did some edits for that |
| 09:56 |
|
marcelr |
btw |
| 09:56 |
|
marcelr |
ok |
| 09:58 |
|
marcelr |
cu l8r |
| 10:26 |
|
paulderscheid[m] |
Got a question if someone feels lucky: Why does C4::Reserves::CanBookBeReserved return { status => 'OK' } for biblionumber 161 in ktd's test data even though it's 'not for loan'? |
| 10:27 |
|
paulderscheid[m] |
Ah, sorry now that I type it out I got a supicion, I used a superlibrarian as the borrower.. |
| 10:56 |
|
oleonard |
ashimema: I just recently discovered FakeFiller so I'm still just happy to have it! |
| 11:00 |
|
tcohen[m] |
hola #koha o/ |
| 11:00 |
|
tcohen[m] |
happy fruday |
| 11:00 |
|
tcohen[m] |
friday |
| 11:01 |
|
oleonard |
And happy fruday to those who celebrate |
| 11:02 |
|
tcohen[m] |
LOL |
| 11:02 |
|
ashimema |
hehe.. I learnt about it from you |
| 11:02 |
|
ashimema |
it's cool |
| 11:03 |
|
ashimema |
but yes.. I'd love to see it capture inputmode |
| 11:04 |
|
oleonard |
ashimema: I didn't realize I'd already mentioned it XD |
| 11:13 |
|
ashimema |
have you looked at bug 33537 at all oleonard |
| 11:13 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33537 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Move domain limits from koha-conf to staff SMTP configuration |
| 11:13 |
|
oleonard |
No, why? |
| 11:13 |
|
ashimema |
something doesn't quite sit right with me regarding UX consistency.. |
| 11:14 |
|
Joubu |
oleonard: I think I've found a problem with bug 34913 |
| 11:14 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=34913 is not accessible. |
| 11:14 |
|
ashimema |
the styling all seems good.. but the navigation feels a little off.. |
| 11:14 |
|
Joubu |
oleonard: turn on EnableItemGroups, go to detail.pl, click "Item groups" tab |
| 11:14 |
|
Joubu |
=> the table does not display |
| 11:14 |
|
Joubu |
nothing in the JS console |
| 11:15 |
|
ashimema |
it introduced a new switch between views within the top bar rather than following the existing patterns |
| 11:15 |
|
ashimema |
wondered if you had any thoughts on whether I'm being OTT or whether it's a valid point |
| 11:17 |
|
* ashimema |
contemplates the admin home page a little.. shouldn't "z39.50/SRU servers" live under 'Catalog' rather than 'Additional parameters |
| 11:17 |
|
oleonard |
I'll take a look at both, ashimema and Joubu |
| 11:17 |
|
ashimema |
I also feel like 'Additional fields' and 'Table settings' could fit in 'Basic parameters' |
| 11:17 |
|
ashimema |
and we could have 'Messaging settings' as a new section to contain 'SMTP servers' and 'Domain limits' |
| 11:18 |
|
ashimema |
as apposed to the need to go to SMTP settings first to then switch to 'Domain limits' after |
| 11:18 |
|
* ashimema |
take the dog for a quick walk whilst there's a break in the rain |
| 11:18 |
|
ashimema |
thanks |
| 11:19 |
|
Joubu |
how are supposed to be ordered the items on the catalogue detail page? |
| 11:20 |
|
Joubu |
ok nevermind, there is a search_ordered method |
| 11:24 |
|
Joubu |
oleonard: also something wrong with the sort icons - https://snipboard.io/z5MIWd.jpg |
| 11:37 |
|
oleonard |
Joubu: It looks like any DataTable that uses "fnServerData" is broken :( |
| 11:38 |
|
oleonard |
I thought I tested those cases because I was concerned about whether that option could be left alone, but I guess I missed it. |
| 11:48 |
|
Joubu |
why is it not using the usual way? |
| 11:50 |
|
oleonard |
Joubu: the usual way? |
| 11:50 |
|
tcohen[m] |
Joubu: I've added some follow-ups for the preservation module bug |
| 11:50 |
|
tcohen[m] |
can you take care of the missing failures? |
| 11:51 |
|
tcohen[m] |
xt/api.t |
| 11:51 |
|
tcohen[m] |
specifically |
| 11:51 |
|
Joubu |
tcohen[m]: yes, sure! |
| 11:51 |
|
tcohen[m] |
it seems the body params are highly under specced |
| 11:51 |
|
Joubu |
oleonard: using kohaTable |
| 11:51 |
|
tcohen[m] |
Joubu: thanks |
| 11:52 |
|
Joubu |
if it's using the Koha REST API I don't understand why it's not using the DT wrapper (kohaTable) |
| 11:52 |
|
oleonard |
Some of the affected pages predate KohaTable |
| 11:53 |
|
oleonard |
Or don't use the API at least: item search, lists, manage marc import |
| 12:30 |
|
Joubu |
tcohen[m]: done - 30708 |
| 12:30 |
|
tcohen[m] |
do you have time to look at the jenkins failure? |
| 12:30 |
|
tcohen[m] |
XD |
| 12:31 |
|
Joubu |
you fixed most of them |
| 12:31 |
|
tcohen[m] |
sorry |
| 12:31 |
|
tcohen[m] |
I meant 'selenium' not 'jenkins' |
| 12:31 |
|
Joubu |
the selenium failure is from the volume stuff |
| 12:31 |
|
Joubu |
there is a patch |
| 12:32 |
|
tcohen[m] |
where?? |
| 12:32 |
|
Joubu |
bug 35099 ( |
| 12:32 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=35099 normal, P5 - low, ---, martin.renvoize, Failed QA , Cannot load records with invalid marcxml |
| 12:33 |
|
pastebot |
"tcohen" at 127.0.0.1 pasted "Joubu" (42 lines) at https://paste.koha-community.org/28074 |
| 12:34 |
|
Joubu |
this test is buggy |
| 12:34 |
|
Joubu |
it was passing for me |
| 12:35 |
|
tcohen[m] |
ok, let me check |
| 12:35 |
|
Joubu |
and it is still passing... |
| 12:36 |
|
tcohen[m] |
ok, I'll take a look |
| 12:40 |
|
Joubu |
oleonard: any progress? |
| 12:46 |
|
oleonard |
Joubu: No I've had to move on to something else for now, I can try to make some time later |
| 12:53 |
|
Joubu |
oleonard: I fixed the item groups by moving it to kohaTable, I've attached the patch to the bug |
| 12:53 |
|
oleonard |
Joubu++ |
| 12:54 |
|
oleonard |
thank you! |
| 12:55 |
|
ashimema |
sorry Joubu.. it as on my list to look at your alternative patch |
| 12:55 |
|
ashimema |
I'd still like to get those methods looking consistent with each other.. I'll do that on another bug though. |
| 12:56 |
|
ashimema |
We need to check that the OPAC doesn't 500 on that bad record.. I feel it will with just your patch |
| 12:56 |
|
Joubu |
ashimema: it does already |
| 12:56 |
|
ashimema |
how |
| 12:56 |
|
Joubu |
prior to volume |
| 12:57 |
|
Joubu |
bad records break everything |
| 12:57 |
|
ashimema |
already 500's |
| 12:57 |
|
ashimema |
yeah |
| 12:57 |
|
Joubu |
and we deal with them on the catalogue detail apge |
| 12:57 |
|
Joubu |
that's all |
| 12:57 |
|
ashimema |
I think we should resolve that |
| 12:57 |
|
Joubu |
OPAC crashes, all other views crash |
| 12:57 |
|
ashimema |
ok.. I'll submit another bug then |
| 12:57 |
|
Joubu |
I think we should not |
| 12:57 |
|
ashimema |
OK. |
| 12:57 |
|
Joubu |
fix your records and Koha will behave correctly :D |
| 12:57 |
|
ashimema |
fair enough |
| 12:57 |
|
Joubu |
we have a script to catch inconsistencies |
| 12:58 |
|
Joubu |
and now we will let librarians fix them |
| 12:58 |
|
Joubu |
better would be to make sure we never insert bad records ;) |
| 12:58 |
|
oleonard |
librarians can't run the inconsistencies script themselves |
| 12:59 |
|
Joubu |
that's not a librarian job |
| 12:59 |
|
Joubu |
must be sysop or migration/support teams |
| 12:59 |
|
ashimema |
well.. we're trying to get there |
| 12:59 |
|
Joubu |
they should fix their migration scripts |
| 13:00 |
|
Joubu |
we can make sure it's not possible to insert bad records from Koha |
| 13:00 |
|
Joubu |
that's all we should do |
| 13:00 |
|
ashimema |
the recent patches do some autofixing for the editor |
| 13:01 |
|
ashimema |
which sorta bugs me |
| 13:01 |
|
oleonard |
I think if we have a known case where we can do some error-handling to prevent a 500 error to the user we should try to handle it. |
| 13:01 |
|
Joubu |
it will need to be done everywhere, that's my point, we cannot and should not |
| 13:01 |
|
ashimema |
we have a number scattered around now |
| 13:02 |
|
Joubu |
We have this discussion every 2 months :D |
| 13:02 |
|
ashimema |
yup |
| 13:02 |
|
|
caroline joined #koha |
| 13:02 |
|
ashimema |
it's hurting libraries right now |
| 13:02 |
|
Joubu |
fix the records then |
| 13:03 |
|
Joubu |
or understand where the broken records are coming from? |
| 13:03 |
|
ashimema |
meeting time |
| 13:03 |
|
ashimema |
bbiab |
| 13:04 |
|
matts |
Hi ! Is it normal that I'm under root user after ktd --shell in koha testing docker ? Shouldn't I be under koha user ? |
| 13:05 |
|
tcohen[m] |
you have an old ktd clone |
| 13:05 |
|
ashimema |
also depends on KOHA_IMAGE |
| 13:05 |
|
ashimema |
we never backported some of the changes to the 22.11 branch for instance.. so that drops you in in a somewhat different environment |
| 13:06 |
|
tcohen[m] |
but the ktd command is the one that uses --user |
| 13:06 |
|
|
Dyrcona joined #koha |
| 13:06 |
|
tcohen[m] |
the difference is the instance user doesn't have many things set |
| 13:06 |
|
ashimema |
indeed |
| 13:07 |
|
* ashimema |
is in the habbit of using ktd --shell --root if I'm using KOHA_IMAGE=22.11 |
| 13:07 |
|
ashimema |
and ktd --shell otherwise |
| 13:07 |
|
tcohen[m] |
right |
| 13:07 |
|
tcohen[m] |
we should (maybe) at least backport adding the instance user to sudoers to ease things |
| 13:07 |
|
ashimema |
that woudl be nice |
| 13:08 |
|
ashimema |
I've just never found a moment and instead worked around it. |
| 13:10 |
|
oleonard |
ashimema: I agree about the SMTP domain limits thing, we can do better |
| 13:10 |
|
matts |
thanks tcohen[m], thanks ashimema, updating the koha-testing-docker clone did the trick ! |
| 13:11 |
|
ashimema |
Thanks oleonard.. |
| 13:11 |
|
ashimema |
I might do a follow-up to get it through closer to QA |
| 13:12 |
|
oleonard |
ashimema: Looking at it I want there to be some kind of relationship between the SMTP server list and the domain limits... Like a way to click on a server to see/set the domain limits |
| 13:13 |
|
ashimema |
I must admit.. I've not got my head around the actually feature 100% at the minute.. (I did understand it fully once upon a time.. but somethings squeezed it back out of my brain) |
| 13:13 |
|
ashimema |
right now, the UI feels like it isn't closely coupled with servers |
| 13:14 |
|
oleonard |
Right |
| 13:15 |
|
oleonard |
And yeah, it doesn't help that I don't have a good understanding of what the feature is for XD |
| 14:01 |
|
ashimema |
any chance you could QA bug 34497 for use Joubu ? |
| 14:01 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=34497 enhancement, P5 - low, ---, pedro.amorim, Signed Off , Vue - Dialog component should allow for confirmation input options |
| 14:02 |
|
Joubu |
"Currently missing cypress tests for this." |
| 14:02 |
|
Joubu |
followed by "tests will come later"... |
| 14:04 |
|
ashimema |
ack |
| 14:04 |
|
ashimema |
yes |
| 14:04 |
|
ashimema |
I thought those had been added in the usage stats submission.. double checking now |
| 14:05 |
|
Joubu |
it does not work for me |
| 14:06 |
|
Joubu |
PedroAmorim[m]: 34497 - https://snipboard.io/auk5Ft.jpg |
| 14:07 |
|
PedroAmorim[m] |
the "tests will come later" stems from the fact that the implementation that makes use of it only comes in 34587 |
| 14:07 |
|
PedroAmorim[m] |
I'll take a second look @Joubu |
| 14:07 |
|
Joubu |
yes, but that means you fail to write a proper "unit test" |
| 14:08 |
|
PedroAmorim[m] |
no, the comment is about cypress tests |
| 14:08 |
|
PedroAmorim[m] |
can't test integration if functionality isn't there |
| 14:08 |
|
Joubu |
(and I know why) |
| 14:09 |
|
Joubu |
PedroAmorim[m]: wait, I am seeing it now... |
| 14:10 |
|
PedroAmorim[m] |
cool! let me know if something else is missing please |
| 14:10 |
|
Joubu |
PedroAmorim[m]: the "required" does not seem to work however |
| 14:10 |
|
PedroAmorim[m] |
looking |
| 14:11 |
|
Joubu |
what is refs.confirmationform.reportValidity? |
| 14:12 |
|
PedroAmorim[m] |
https://developer.mozilla.org/[…]nt/reportValidity |
| 14:14 |
|
Joubu |
input.value == null: I guess it's that, it's "" |
| 14:14 |
|
|
marie-luce joined #koha |
| 14:14 |
|
caroline |
https://koha-community.org/man[…]eyboard-shortcuts has the shortcuts for 4 of the 5 tabs in the main search bar. Does anyone know if the Patron search tab has a shortcut? |
| 14:16 |
|
Joubu |
PedroAmorim[m]: |
| 14:16 |
|
Joubu |
- input => input.required && input.value == null |
| 14:16 |
|
Joubu |
+ input => input.required && input.value == "" |
| 14:16 |
|
Joubu |
this fixes the problem |
| 14:17 |
|
Joubu |
but the validation is not showing where the problem comes from |
| 14:17 |
|
PedroAmorim[m] |
I was thinking... (full message at <https://matrix.org/_matrix/med[…]RAslacabjsKtLmyEq>) |
| 14:17 |
|
PedroAmorim[m] |
I think this length of '0' is returning truthly because string |
| 14:18 |
|
PedroAmorim[m] |
and because javascript |
| 14:18 |
|
PedroAmorim[m] |
but I'll try your approach as well |
| 14:18 |
|
Joubu |
PedroAmorim[m]: with "" it works. BUT it stills does not work for dates |
| 14:19 |
|
PedroAmorim[m] |
interesting, it works for dates on my end |
| 14:19 |
|
PedroAmorim[m] |
I'll try firefox as well |
| 14:20 |
|
Joubu |
PedroAmorim[m]: If both are empty, the form is showing "please fill this fields" on the date. But if the input is not empty, then the form is submitted |
| 14:21 |
|
PedroAmorim[m] |
https://snipboard.io/ljkvA5.jpg |
| 14:21 |
|
PedroAmorim[m] |
that doesn't happen for me |
| 14:22 |
|
PedroAmorim[m] |
this is why I'll also test firefox |
| 14:23 |
|
Joubu |
not working for me on chromium either (input filled but date empty => form is submitted) |
| 14:28 |
|
PedroAmorim[m] |
I think this is because the date field will come up as null if empty, and the text field will come up as '' if empty |
| 14:28 |
|
PedroAmorim[m] |
I have a patch coming up |
| 14:34 |
|
oleonard |
caroline: Patron search tab doesn't have a shortcut |
| 14:34 |
|
caroline |
thanks oleonard! |
| 14:36 |
|
PedroAmorim[m] |
Joubu: tyvm for testing, I've submitted a patch |
| 14:36 |
|
PedroAmorim[m] |
I think it was a 2 part issue, 2 small fixes in the follow-up patch |
| 14:37 |
|
Joubu |
PedroAmorim[m]: what about 0 ? :) |
| 14:37 |
|
Joubu |
if you have a dropdown list with value="0", it will fail |
| 14:38 |
|
PedroAmorim[m] |
well, I had |
| 14:38 |
|
PedroAmorim[m] |
input => input.required && (input.value == null || input.value == '') |
| 14:38 |
|
Joubu |
if you require an integer, "0" might be a valid value |
| 14:38 |
|
PedroAmorim[m] |
but decided to make it simpler, but I think you're right |
| 14:38 |
|
Joubu |
yes, I think it's better |
| 14:38 |
|
PedroAmorim[m] |
solid point |
| 14:38 |
|
* ashimema |
uploaded an image: (78KiB) < https://matrix.org/_matrix/med[…]puppGVY/image.png > |
| 14:38 |
|
ashimema |
bug 35119 |
| 14:38 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=35119 enhancement, P5 - low, ---, koha-bugs, NEW , Make bibliographic errors more prominent and match current styling |
| 14:41 |
|
PedroAmorim[m] |
thank you |
| 14:41 |
|
PedroAmorim[m] |
new patch is up |
| 14:41 |
|
PedroAmorim[m] |
works as intended on my end from my testing |
| 14:41 |
|
caroline |
nice ashimema! hard to miss now |
| 14:41 |
|
ashimema |
I thought so 😜 |
| 14:42 |
|
ashimema |
and a little more in keeping with our new style |
| 14:44 |
|
ashimema |
though.. we do have a bit of a mix of 'dialog' and 'page-section' for things |
| 14:45 |
|
ashimema |
looking at bug 34014 now and considering that it displays almost the same message but on the editor page.. but it uses 'dialog alert' to format it |
| 14:45 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=34014 major, P5 - low, ---, nick, Pushed to master , There is no way to fix records with broken MARCXML |
| 14:45 |
|
* ashimema |
uploaded an image: (120KiB) < https://matrix.org/_matrix/med[…]OqksxNb/image.png > |
| 14:46 |
|
ashimema |
Not sure which I prefer.. I think I like the full-width nature of the page-section approach |
| 14:46 |
|
ashimema |
but the yellow with red.. vs red with black/grey/red I'm less sure on |
| 14:46 |
|
ashimema |
and this is why I'm still pushing for a clearer style guide |
| 14:46 |
|
ashimema |
oleonard ^ |
| 14:47 |
|
Joubu |
PedroAmorim[m]: nice one ;)429;9u |
| 14:47 |
|
Joubu |
keyboard doing crazy things |
| 14:47 |
|
PedroAmorim[m] |
insane testing ty |
| 14:55 |
|
reiveune |
bye |
| 14:55 |
|
|
reiveune left #koha |
| 15:03 |
|
|
alohabot` joined #koha |
| 15:05 |
|
* ashimema |
uploaded an image: (132KiB) < https://matrix.org/_matrix/med[…]dYximfg/image.png > |
| 15:13 |
|
davidnind |
ashimema++ |
| 15:16 |
|
davidnind |
Should something be done on the OPAC side, so that if there is an error (such as encoding or invalid MARC records) that a proper message is displayed in the UI, rather than an error or error trace? Or is this really hard? (There is probably a bug for this somewhere...) |
| 15:38 |
|
oleonard |
Looks good ashimema |
| 16:37 |
|
|
bag joined #koha |
| 17:34 |
|
ashimema |
It's not hard.. but Joubu doesn't like the idea |
| 17:34 |
|
ashimema |
I'd encourage staff to fix things.. but I personally feel we should be outright breaking the OPAC either |
| 17:35 |
|
ashimema |
He is right that we should be working as a team to prevent bad data ever getting in in the first place |
| 17:35 |
|
ashimema |
But there years of Koha's 9ut there that will have such data in already as we've been much more forgiving in the past |
| 17:36 |
|
davidnind |
I totally agree that we should be doing all that can be done to avoid bad data getting into Koha |
| 17:37 |
|
ashimema |
It all comes down to getting better as a team at working on targets together rather than all working so much in our own little silos |
| 17:37 |
|
davidnind |
However, I think ideally we shouldn't be inflicting error traces or other errors on patrons - from a user experience point of view |
| 17:37 |
|
davidnind |
Agree! |
| 17:37 |
|
ashimema |
I totally agree davdnind |
| 17:38 |
|
ashimema |
Just a bit close after I got told off for fixing a few such errors earlier today ;) |
| 17:38 |
|
davidnind |
ashimema++ |
| 17:39 |
|
ashimema |
I'll have another go at a submission for such on Monday. |
| 17:40 |
|
ashimema |
I'm also a bit wary about a recent bug that's gone in that silently "fixes" records as they're being saved. To me that feels like a potential data loss bug |
| 17:41 |
|
ashimema |
I intend to work on something that instead catches errors and passes back to the cataloguer to fix (or in the case where that often happens, guides them to fix their configuration for z3950 copy cataloguing) |
| 17:41 |
|
davidnind |
at a generic level, if we change something we should indicate that we will do so and get a yes or no, or at least show what was changed - otherwise there will be confusion |
| 17:42 |
|
davidnind |
that would be great! include me in the bug for sign offs and I'll do my best |
| 17:43 |
|
ashimema |
Cheers David 🙂 |
| 17:49 |
|
davidnind |
as a minimum, in the OPAC, I think we should display the normal user interface and 1) Have a message to say something like "There is a problem displaying information about this item (record?). We've let the library staff know so it can be fixed up. 2) For staff there should be something - either a report or something like suggestions - which says "OPAC record display errors - and list records that need fixing. Maybe I should create a bug, if one |
| 17:49 |
|
davidnind |
doesn't exist already... |
| 18:00 |
|
|
emlam joined #koha |
| 18:01 |
|
ashimema |
A bug would be good |
| 18:05 |
|
|
caroline joined #koha |
| 18:21 |
|
ashimema |
I just added a follow-up to bug 35119 I'm afraid davidnind |
| 18:21 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=35119 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Make bibliographic errors more prominent and match current styling |
| 18:22 |
|
ashimema |
master moved rather quick 😜 |
| 18:43 |
|
oleonard |
tcohen[m]: Every time you push one of my patches that touches additional-contents.tt it will make the rest of them not apply. I probably should have made them a big dependency chain just because of that |
| 18:43 |
|
oleonard |
It's just this big list that never merges: [% SET opac_available_options = [ 'OpacNavRight', 'opacheader', 'OpacCustomSearch', ... |
| 18:56 |
|
tcohen[m] |
oleonard: ok, I just need to choose between rebasing it myself, or pushing other people's stuffs |
| 18:56 |
|
tcohen[m] |
and I chose the latter |
| 18:56 |
|
tcohen[m] |
can try to adjust some |
| 18:56 |
|
oleonard |
tcohen[m]: I'm happy to keep rebasing too, I understand |
| 20:32 |
|
|
cait joined #koha |
| 20:45 |
|
tuxayo |
cait++ tcohen++ the crazy speed for QAing and merging bug 34946! 🤯 |
| 20:45 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=34946 minor, P5 - low, ---, oleonard, Pushed to master , Remove the use of event attributes from self checkout and check-in |
| 21:27 |
|
nikkom |
@later tell tuxayo: Thank you :) |
| 21:27 |
|
huginn |
nikkom: The operation succeeded. |
| 21:27 |
|
|
angelic_ joined #koha |
| 21:28 |
|
tuxayo |
yw, I hope you got around what I wanted to do with templates :) |
| 21:42 |
|
|
Shane-NP[m] joined #koha |
| 21:48 |
|
|
rhen976 joined #koha |
