| Time |
S |
Nick |
Message |
| 00:00 |
|
aleisha |
:( sorry y'all had to deal with that |
| 00:07 |
|
|
khall joined #koha |
| 00:58 |
|
|
khall joined #koha |
| 02:02 |
|
|
cait1 joined #koha |
| 02:20 |
|
|
alohabot joined #koha |
| 02:55 |
|
|
bag joined #koha |
| 03:21 |
|
Joubu |
oleonard: I'd say maintenance.pl does not need the user and check permissions, so it just get the template's info |
| 03:57 |
|
Joubu |
MatthewBlenkinsop[m]: 22.11 jobs failing because of xt_find_misplaced_executables_t - this should be caught by the QA script! |
| 04:16 |
|
|
blueblue02[m] joined #koha |
| 04:16 |
|
|
MartinWitjens[m] joined #koha |
| 04:16 |
|
|
lauraesca[m] joined #koha |
| 04:16 |
|
|
NikolayGospodinov[m] joined #koha |
| 04:16 |
|
|
lisette[m] joined #koha |
| 04:16 |
|
|
domm[m] joined #koha |
| 04:16 |
|
|
scorpaust[m] joined #koha |
| 04:16 |
|
|
simonetteskii[m] joined #koha |
| 04:16 |
|
|
anke_b[m] joined #koha |
| 04:16 |
|
|
JacobOMara[m] joined #koha |
| 04:16 |
|
|
MintesinotBirru[m] joined #koha |
| 04:16 |
|
|
lucyvh[m] joined #koha |
| 04:16 |
|
|
ITMLJS[m] joined #koha |
| 04:16 |
|
|
SergioMassa[m] joined #koha |
| 04:16 |
|
|
edveal[m] joined #koha |
| 04:16 |
|
|
anpu26[m] joined #koha |
| 04:16 |
|
|
puphaus[m] joined #koha |
| 04:16 |
|
|
cabillman[m] joined #koha |
| 04:16 |
|
|
krimsonkharne[m] joined #koha |
| 04:16 |
|
|
NarayananNarayanan[m] joined #koha |
| 04:16 |
|
|
steve-p-d[m] joined #koha |
| 04:16 |
|
|
arkibus[m] joined #koha |
| 04:16 |
|
|
artez_zwolle[m] joined #koha |
| 04:16 |
|
|
RafaelFernandes[m] joined #koha |
| 04:16 |
|
|
sandeepkumar[m] joined #koha |
| 04:16 |
|
|
MaratDallin[m] joined #koha |
| 04:16 |
|
|
hkat_23[m] joined #koha |
| 04:16 |
|
|
ProfDrOsmanBarre[m] joined #koha |
| 04:16 |
|
|
aw-bib[m] joined #koha |
| 04:16 |
|
|
DrNaseeraliMK[m] joined #koha |
| 04:16 |
|
|
bill-k[m] joined #koha |
| 04:16 |
|
|
tuxayo joined #koha |
| 04:16 |
|
|
sonOfRa joined #koha |
| 04:16 |
|
|
tcohen joined #koha |
| 04:16 |
|
|
jajm joined #koha |
| 04:16 |
|
|
fredericd joined #koha |
| 04:16 |
|
|
jo joined #koha |
| 04:16 |
|
|
void09 joined #koha |
| 04:16 |
|
|
paxed joined #koha |
| 05:36 |
|
|
alohabot joined #koha |
| 05:42 |
|
Joubu |
aude_c[m]: just found that https://www.sphinx-doc.org/en/[…]ons/ifconfig.html - I don't think we should use it (hard to maintain) but good to know it exists |
| 05:50 |
|
|
alohabot joined #koha |
| 05:51 |
|
|
dcook joined #koha |
| 05:52 |
|
dcook |
@later tell ashimema Bugzilla is punishing me but I think I've figured out that background task in plugin thing. Somehow missed part of a patch for the last year... |
| 05:52 |
|
huginn |
dcook: The operation succeeded. |
| 05:52 |
|
dcook |
@later tell paulderscheid[m] Email me about it :p. I figured no one was interested in the Keycloak stuff when I didn't get any responses to my email |
| 05:52 |
|
huginn |
dcook: The operation succeeded. |
| 06:06 |
|
|
marcelr joined #koha |
| 06:07 |
|
marcelr |
o/ |
| 06:08 |
|
ashimema |
Morning |
| 06:09 |
|
ashimema |
I can't remember how that background task in a plugin stuff works either dcook. Can't really interpret the code from my phone.. did you say you managed to work it out? We should certainly clearly document it. |
| 06:11 |
|
|
reiveune joined #koha |
| 06:11 |
|
reiveune |
hello |
| 06:11 |
|
wahanui |
hello, reiveune |
| 06:11 |
|
dcook |
ashimema: Ehhhhhh haha |
| 06:12 |
|
dcook |
Work in progress |
| 06:12 |
|
dcook |
I found some code I hadn't noticed before which helped me move it along |
| 06:12 |
|
dcook |
But there's a lot of counterintuitive/undocumented stuff here.. |
| 06:12 |
|
|
lds joined #koha |
| 06:12 |
|
dcook |
Oh yippy. "Unknown job type". :| |
| 06:13 |
|
Joubu |
what are you talking about? :) |
| 06:13 |
|
dcook |
bug 30410 |
| 06:13 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30410 enhancement, P5 - low, ---, tomascohen, CLOSED FIXED, Add a way for plugins to register background tasks |
| 06:13 |
|
* dcook |
wants to burn it with fire... |
| 06:13 |
|
dcook |
In theory, very useful |
| 06:13 |
|
dcook |
In practice, I haven't been able to ever get it to work |
| 06:13 |
|
dcook |
Managed to get myself banned from Bugzilla while talking about it too haha |
| 06:13 |
|
* dcook |
didn't even say any bad words... |
| 06:14 |
|
Joubu |
I forgot that |
| 06:14 |
|
dcook |
The more I look at it... the more it looks like it could never work? |
| 06:14 |
|
dcook |
Template process failed: file error - background_jobs/plugin_blahblah.inc: not found at /kohadevbox/koha/C4/Templates.pm line 127 |
| 06:15 |
|
dcook |
http://localhost:8081/cgi-bin/[…]s.pl?op=view&id=1 |
| 06:15 |
|
dcook |
:| |
| 06:15 |
|
Joubu |
those things we force push... |
| 06:15 |
|
dcook |
^ |
| 06:15 |
|
dcook |
This one would've been easy to test with just 1 example plugin too... |
| 06:15 |
|
Joubu |
ask tcohen about an example, I guess he is using it somewhere |
| 06:16 |
|
dcook |
You'd expect so... |
| 06:16 |
|
dcook |
I think I've asked in the past but haven't heard back |
| 06:16 |
|
Joubu |
it must be a requirement |
| 06:16 |
|
dcook |
But I'm too frustrated to think rationally right now... |
| 06:16 |
|
Joubu |
I thought we asked for a kitchensink's modification before pushing those kind of changes |
| 06:16 |
|
dcook |
That would be awesome too |
| 06:18 |
|
ashimema |
I'm sure I had it working in a plugin at the time |
| 06:19 |
|
ashimema |
I'll have a proper look after breakfast |
| 06:19 |
|
Joubu |
dcook: do you have published the code of what you tried? |
| 06:21 |
|
dcook |
Joubu: Not yet. It's part of an in development plugin at the moment. (It's actually for running MarcEdit on the CLI using mono in the background funny enough.) |
| 06:21 |
|
dcook |
I've got to run anyway unfortunately.. |
| 06:21 |
|
dcook |
Already running late :( |
| 06:22 |
|
dcook |
I know that would make it a lot easier of course |
| 06:22 |
|
dcook |
Debating whether to give up and just run the code synchronously or have another try next week... |
| 06:22 |
|
dcook |
Just every time I give up it means that this doesn't get resolved... |
| 06:22 |
|
dcook |
Just pushes the problem along.. |
| 06:22 |
|
Joubu |
well try to provide a very simple version to start :) |
| 06:23 |
|
dcook |
Unless I give up hehe |
| 06:23 |
|
Joubu |
I can have a look if you isolate the code |
| 06:23 |
|
dcook |
<3 |
| 06:23 |
|
dcook |
Ok I'll make a note to do a simple plugin next week and share it with you |
| 06:23 |
|
Joubu |
the inc can be a problem indeed |
| 06:23 |
|
Joubu |
it that the only thing that does not work? |
| 06:23 |
|
Joubu |
is* |
| 06:24 |
|
dcook |
No it also says unknown job type |
| 06:24 |
|
Joubu |
is the job enqueued and on the job list? |
| 06:24 |
|
dcook |
Even though it shows up in the mapping |
| 06:24 |
|
dcook |
I really need to run unfortunately |
| 06:24 |
|
dcook |
It is listed as Failed "Unknown job type 'plugin_blah_blah'" |
| 06:24 |
|
Joubu |
yes it cannot work |
| 06:24 |
|
dcook |
It should be a known job type though :/ |
| 06:25 |
|
Joubu |
235 let job_type_lib = job_types.find( t => t._id == job_type ); |
| 06:25 |
|
Joubu |
239 return _("Unknown job type '%s'").format(job_type); |
| 06:25 |
|
dcook |
Oh wait's that now.. |
| 06:25 |
|
Joubu |
and job_types only contains jobs defined in Koha |
| 06:25 |
|
dcook |
Innnnteresting |
| 06:25 |
|
dcook |
Nice catch |
| 06:26 |
|
dcook |
me thinks this functionality will never work after all haha |
| 06:26 |
|
dcook |
Well not without changes |
| 06:26 |
|
dcook |
But that means unusable for now... |
| 06:26 |
|
dcook |
Thanks so much for looking Joubu |
| 06:26 |
|
Joubu |
it cannot work now |
| 06:26 |
|
Joubu |
you should open a bug and link it to the plugin one |
| 06:27 |
|
dcook |
I've been kicked off Bugzilla haha |
| 06:27 |
|
dcook |
So can't do that until my access is restored |
| 06:27 |
|
dcook |
Friday problems... |
| 06:27 |
|
dcook |
Thanks again, Joubu. You've saved my sanity. |
| 06:27 |
|
dcook |
I've got to run, so happy Friday everyone! |
| 06:27 |
|
dcook |
(poet and i didn't know it) |
| 06:28 |
|
marcelr |
ashimema you won |
| 06:28 |
|
marcelr |
i just have to give up |
| 06:28 |
|
Joubu |
dcook: account unlocked |
| 06:47 |
|
ashimema |
marcelr I didn't mean to beat you.. I just wanted to understand, |
| 06:48 |
|
ashimema |
I'm happy to pass it, but I think I'd end up adding another Param to the script to allow skipping if that code to use the user defined list |
| 06:48 |
|
ashimema |
Assuming your talking activity |
| 06:49 |
|
marcelr |
yes see the 35001 report |
| 06:49 |
|
marcelr |
i am updating the code right now |
| 06:51 |
|
marcelr |
2 files changed, 22 insertions(+), 95 deletions(-) |
| 06:52 |
|
ashimema |
Oh, didn't we add holds and issues in already.. I'm happy to add those as triggers if I didn't already.. my brain is addled |
| 06:52 |
|
ashimema |
I'm sorry dude, I really didn't mean to get so hung up |
| 06:52 |
|
ashimema |
Please throw me a bug or two I can help progress for you. |
| 06:53 |
|
marcelr |
I passed qa on them yesterday ashimema |
| 06:55 |
|
marcelr |
you wrote them yesterday :) |
| 07:01 |
|
|
cait joined #koha |
| 07:04 |
|
|
cait2 joined #koha |
| 07:16 |
|
marcelr |
ashimema: please signoff on 35001 |
| 07:17 |
|
ashimema |
Thanks marcelr |
| 07:17 |
|
marcelr |
still mixed feelings :) |
| 07:17 |
|
ashimema |
I was going to take a look at bug 33537 next.. seems I got half way through a QA on that one already |
| 07:17 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33537 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Move domain limits from koha-conf to staff SMTP configuration |
| 07:18 |
|
ashimema |
looks like it no longer applies though. |
| 07:18 |
|
marcelr |
removing your own code is never a happy experience |
| 07:18 |
|
marcelr |
i will have a look at 33537 |
| 07:18 |
|
ashimema |
I like removing my own code sometimes |
| 07:18 |
|
marcelr |
sorry no qa today ;) |
| 07:18 |
|
ashimema |
but yes.. it's certainly a sometimes |
| 07:18 |
|
ashimema |
My plan is to QA what I can with your name on in the queue |
| 07:18 |
|
marcelr |
maybe my code from 2010 |
| 07:18 |
|
* ashimema |
feels bad and childish |
| 07:19 |
|
marcelr |
no |
| 07:20 |
|
marcelr |
you will see that i do not even look at the pref anymore in is_active; i just look at lastseen |
| 07:20 |
|
ashimema |
We just need a better way to communicate what we're all up to |
| 07:20 |
|
marcelr |
no offense, but this was in the roadmap and 15504 was not |
| 07:20 |
|
ashimema |
Usual problem |
| 07:21 |
|
ashimema |
Yes, my mistake there.. I had hit a point of disillusionment with the roadmap and not really looked at it this cycle |
| 07:21 |
|
ashimema |
Which is bad.. I'm part of the problem not the solution right now 😔 |
| 07:21 |
|
marcelr |
we need roadmap in BZ |
| 07:21 |
|
marcelr |
it just dont work if it is somewhere else |
| 07:22 |
|
marcelr |
wanna see it rightaway |
| 07:22 |
|
marcelr |
and as soon as it is in BZ, anyone marks it and it will be devaluated , aaaarg |
| 07:23 |
|
marcelr |
sorry to disappoint tomas |
| 07:23 |
|
|
Adarsh joined #koha |
| 07:24 |
|
ashimema |
I don't know the solution.. think we really need to somehow work on discussing things more up front and getting commitment with timeslots up front |
| 07:25 |
|
marcelr |
it is hard, we are talking about such things since 1.0 |
| 07:25 |
|
ashimema |
before something is allowed to be listed on the roadmap it should require a "sponsor" from each of the steps in the process.. i.e. a dev, a tester, a qa person |
| 07:25 |
|
ashimema |
but I have no idea how to actually orchestrate that.. it's a full time job managing it |
| 07:26 |
|
marcelr |
right and thats what we dont have ;) |
| 07:26 |
|
* ashimema |
job is slowly working towards that though.. less coding and more managing.. so maybe I keep folding that further |
| 07:26 |
|
Joubu |
ashimema: I will be on 33537 |
| 07:26 |
|
ashimema |
oh, OK.. |
| 07:26 |
|
Joubu |
but do as well, better 2 than 0 ;) |
| 07:27 |
|
ashimema |
okies |
| 07:27 |
|
Joubu |
my plan was to see if we cannot reuse (and so make reusable) from of the things we added for Vue components |
| 07:27 |
|
ashimema |
did you say you were rebasing that marcelr? |
| 07:27 |
|
Joubu |
I have at least the "fetch" in mind |
| 07:27 |
|
marcelr |
it needs a trivial rebase |
| 07:27 |
|
ashimema |
cool |
| 07:27 |
|
Joubu |
s/from/some |
| 07:27 |
|
marcelr |
Joubu should i rebase ? |
| 07:27 |
|
Joubu |
yes |
| 07:28 |
|
marcelr |
ok doing it now |
| 07:28 |
|
ashimema |
yes please |
| 07:29 |
|
Joubu |
bugzilla cannot do everything, it's not a good tool, especially if you want to do everything with it |
| 07:30 |
|
Joubu |
I had full time on the roadmap when I was RM, it's not enough. |
| 07:30 |
|
Joubu |
even people committing at the beginning of the cycle disappear at some point |
| 07:31 |
|
Joubu |
hum... better stop here now :D... |
| 07:31 |
|
marcelr |
? |
| 07:31 |
|
marcelr |
motivate us please |
| 07:32 |
|
ashimema |
school run, brb |
| 07:33 |
|
marcelr |
Joubu rebased 33537 |
| 07:34 |
|
Joubu |
yes sorry, I really should have #koha in read only mode |
| 07:34 |
|
Joubu |
thx |
| 07:43 |
|
cait2 |
i think the roadmap idea as it's now needs revisitng, i like the idea to flag on bugzilla, tiw ould help a lot with prioritizing |
| 07:43 |
|
Joubu |
marcelr: it does not work, I cannot add a new domain |
| 07:43 |
|
marcelr |
js error ? |
| 07:43 |
|
cait |
but it also needs to be more transparent somewhoe, we can not only focus on stuff from a few core devs |
| 07:44 |
|
marcelr |
I tested it thoroughly but thats 3 months ago |
| 07:44 |
|
Joubu |
marcelr: no error, nowhere |
| 07:45 |
|
marcelr |
just fqa on it Joubu, after all it ends up there aaarggg |
| 07:45 |
|
marcelr |
i will have a look later, just abandon it |
| 07:47 |
|
Joubu |
29 if ( !$('#domain_limits_modal form').get(0).checkValidity() ) return; // Do not return false here to allow validation. |
| 07:47 |
|
Joubu |
this is wrong |
| 07:47 |
|
Joubu |
the check is ignored |
| 07:49 |
|
marcelr |
hmm i will check it but later please; just post it on the report and fqa |
| 07:49 |
|
marcelr |
i dont understand it but thats another thing |
| 07:52 |
|
marcelr |
i really tested this in and out, but ok |
| 07:53 |
|
|
Karter[m] joined #koha |
| 07:59 |
|
Karter[m] |
Hello, I am looking for technical support with Koha translation files. We already have our Netherlands language pack installed and working correctly on our server staff interface. We are wanting to update the nl-NL-staff-prog.po file with the newer updated version ( as provided by the translation server ). We have replaced the files from old to new with straight copy and replace, but no the file changes are not being made. Can anyone help, is |
| 07:59 |
|
Karter[m] |
there is more that needs to be done for this file change? If not I was going to remove the language pack completely and re-install. |
| 08:02 |
|
Joubu |
why do you want the version from the translation server? Are you running master? |
| 08:03 |
|
Joubu |
if you are on a stable branch (and use a tag that is released) you should have up-to-date PO files embeded |
| 08:03 |
|
Joubu |
do you have a fork? |
| 08:05 |
|
krimsonkharne[m] |
morning #koha |
| 08:25 |
|
|
alohabot joined #koha |
| 08:28 |
|
Karter[m] |
<Joubu> "why do you want the version from..." <- sorry, We are currently running the latest stable version of Koha, so we are using the 'master' branch. We received an updated nl-NL-staff-prog.po file with additional translations, and we want to incorporate these translations into our system. We do not have a custom fork of Koha; our installation is based on the official, stable release. On our test server, we're using version 22.11.03. Does |
| 08:28 |
|
Karter[m] |
this answer your question? |
| 08:29 |
|
ashimema |
master is the development branch |
| 08:29 |
|
ashimema |
not the stable |
| 08:30 |
|
ashimema |
with each release we package the latest translations at the time of release.. the translations file's need to match up exactly with your version else weird things can happen with strings coming in out of order and things (not always immediately noticable) |
| 08:30 |
|
ashimema |
your best bet is to do minor point releases shortly after they come out.. and they come with the improved translations each time. |
| 08:31 |
|
Joubu |
Karter[m]: "we received an updated": Does it mean you have the .po from Koha AND another one you would like to merge? |
| 08:33 |
|
marcelr |
ashimema: added follow-up on 35001, maybe the best of both worlds? hopefully |
| 08:34 |
|
marcelr |
obsoleting your patch. didnt see it before |
| 08:34 |
|
Karter[m] |
Thankyou I will go make sure all the versions are correctly matched as mentioned ^. |
| 08:40 |
|
marcelr |
Joubu: yes the checks are gone now, but they definitely worked -- so back to restoring that somehow |
| 08:42 |
|
ashimema |
your patch is way nicer than mine, thanks marcelr 🙂 |
| 08:42 |
|
ashimema |
I like |
| 08:44 |
|
marcelr |
ok |
| 08:45 |
|
marcelr |
so nice to have a tidy patch just in between stuff ;) |
| 08:45 |
|
Joubu |
ashimema: please don't forget 29523 |
| 08:46 |
|
Joubu |
marcelr: drop it if not pushe |
| 08:46 |
|
ashimema |
:tick: |
| 08:46 |
|
Joubu |
pushed |
| 08:46 |
|
marcelr |
sure |
| 08:47 |
|
marcelr |
it represent a waste of time imo |
| 08:49 |
|
ashimema |
must admit I'm struggling with the perltidy stuff.. |
| 08:49 |
|
ashimema |
as much as I'd love to see things tidy as a whole.. we seem to hit problems with almost every patch and sometimes it aint half a challenge to work out how to unpick them. |
| 08:49 |
|
ashimema |
anywho.. I'm not going to fall into that hole today 😜 |
| 08:51 |
|
marcelr |
top |
| 08:56 |
|
Joubu |
with --line-range-tidy (see Zeno's email) and the "keep my changes" flag you can pass to git checkout we could actually script that |
| 08:56 |
|
Joubu |
ie. apply patch by patch, keep author's version, run the perltidy on the modified lines, commit, continue |
| 08:57 |
|
Joubu |
that will also avoir the "tidy" patch people add at the top of a set (that was not the intention of the tidy check...) |
| 08:57 |
|
marcelr |
sounds good |
| 08:57 |
|
Joubu |
avoid* |
| 08:57 |
|
Joubu |
I am waiting for you to write it, marcelr ;) |
| 08:58 |
|
marcelr |
lol |
| 08:58 |
|
marcelr |
my patches are tidy by definition |
| 08:58 |
|
Joubu |
I told you everything! All the thinking is done already! |
| 09:02 |
|
* ashimema |
grabs a coffee in preparation for diving back into 29523 |
| 09:03 |
|
ashimema |
I agree.. the #### placeholder is nasty.. wasn't sure what to put in to represent "this field isn't necessarily empty.. it's just your not allowed to see the data" |
| 09:07 |
|
Joubu |
ashimema: don't you think my version is finally better? At least in the first step? |
| 09:07 |
|
Joubu |
if the attribute does not exist it means it has been redacted |
| 09:07 |
|
Joubu |
otherwise we are going to hit datatype issues, and null/empty problems |
| 09:11 |
|
ashimema |
mm, starting to look that way |
| 09:11 |
|
aude_c[m] |
<Joubu> "aude_c: just found that https..." <- Joubu Thanks. So we need something else to solve the manual search issues? 😅 |
| 09:11 |
|
marcelr |
thx ashimema for signoff |
| 09:11 |
|
ashimema |
then we get 'undefined', 'null' and 'stuff' as our values effectively |
| 09:12 |
|
ashimema |
null/empty I suppose |
| 09:22 |
|
cait |
if it's only one patch i have amended the original for perltidy... but it adds extra work |
| 09:23 |
|
cait |
but if it's many patches it doesn't make as much sense to fold it in... in case it makes thing sless readable somehow |
| 09:24 |
|
* ashimema |
tends to check splitter for whether other patches affect the affected file.. if none do I like to add a full tidy of the file at the end of the patchset |
| 09:24 |
|
ashimema |
that way we improve as we go.. and hopefully don't cause conflicts |
| 09:24 |
|
ashimema |
having said that.. it feels rare that splitter comes up empty.. |
| 09:25 |
|
ashimema |
I thought I might be able to do that with misc/cronjobs/membership_expiry.pl.. but it has three bugs outstanding on it right now |
| 09:25 |
|
cait |
wow |
| 09:25 |
|
ashimema |
Koha's has stuff open all over the place |
| 09:25 |
|
cait |
my QA Friday got a little derailed thi smornign I am afraid (or this week) |
| 09:25 |
|
marcelr |
same for me cait |
| 09:36 |
|
cait |
need to finish some other things first, hope there will be some Friday left |
| 09:36 |
|
ashimema |
my brain hurts |
| 09:36 |
|
* cait |
sends you cookies |
| 09:37 |
|
cait |
... hm probably not good to increase the blood sugar |
| 09:37 |
|
* cait |
takes the cookies away and sends you fresh water and veggie sticks |
| 09:37 |
|
ashimema |
I'm trying to remember how to actually trigger the whole patron redaction stuff |
| 09:37 |
|
ashimema |
lol |
| 09:50 |
|
cait |
patron redaction? |
| 09:50 |
|
marcelr |
@later tell tcohen 35041? |
| 09:50 |
|
huginn |
marcelr: The operation succeeded. |
| 09:50 |
|
ashimema |
bug 29523 cait |
| 09:50 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29523 major, P5 - low, ---, martin.renvoize, In Discussion , Add a way to prevent embedding objects that should not be allowed |
| 09:50 |
|
cait |
um ok |
| 09:51 |
|
ashimema |
hiding rather than outright removing |
| 09:51 |
|
ashimema |
thus.. redacting |
| 09:52 |
|
cait |
is that the pseudonymization in separate tables ... the anynomization from Marcel... or something completely else? |
| 09:53 |
|
marcelr |
no two things |
| 09:55 |
|
ashimema |
completely different |
| 09:55 |
|
ashimema |
it's all about the API |
| 09:55 |
|
ashimema |
and the existing functionality in Koha around hiding patron details from different libraries |
| 09:56 |
|
ashimema |
so staff may be attached to library X and not allowed to see the patrons in library Y.. but we still display 'Checkout out to patron from Library Y' in some places |
| 09:57 |
|
ashimema |
with the switch to using API's for that sort of display.. we need a way of returning those users still.. but redacting their details apart from a small number of fields that are required to maintain the existing functionality. |
| 09:57 |
|
marcelr |
Joubu 33537 is back but no tidy yet; wiling to do it later of course |
| 09:58 |
|
ashimema |
that's the clearest way to think about it.. but the original bug predates Joubu's work by a long way.. I spotted data leaks basically.. but we didn't have them in use.. with Joubu's work they become a lot more apparent.. so this bug is getting attention again 🙂 |
| 09:58 |
|
marcelr |
Joubu not sure if we should starting adding vue stuff on that same report now ? |
| 09:58 |
|
marcelr |
or open a new one.. |
| 10:01 |
|
ashimema |
Joubu.. I have a follow-up for bug 33568 for you: https://gitlab.com/mrenvoize/K[…]cd0cfc2c3b0368460 |
| 10:01 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33568 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Use the REST API to display items on the biblio detail view |
| 10:02 |
|
Joubu |
marcelr: it will be on a new one, if I find a way... |
| 10:03 |
|
Joubu |
ashimema: thanks. This StaffDetailItemSelection is silly, we should remove it... |
| 10:03 |
|
Joubu |
I should have done it before the big move |
| 10:04 |
|
ashimema |
Yeah.. it caught me by surprise |
| 10:04 |
|
ashimema |
I've replaced my final patch on bug 29523 |
| 10:04 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29523 major, P5 - low, ---, martin.renvoize, In Discussion , Add a way to prevent embedding objects that should not be allowed |
| 10:04 |
|
ashimema |
it sets to 'null' as apposed to an empty string or random string |
| 10:04 |
|
Joubu |
ashimema: cherry-picked and branch pushed |
| 10:04 |
|
ashimema |
seems to work well in your case |
| 10:05 |
|
ashimema |
just about to run the api tests to see how they fair |
| 10:05 |
|
|
alohabot joined #koha |
| 10:05 |
|
ashimema |
cheers |
| 10:09 |
|
marcelr |
htg |
| 10:15 |
|
|
khall joined #koha |
| 10:20 |
|
aude_c[m] |
Joubu++ for work on translations and manual |
| 10:25 |
|
oleonard |
Hi #koha |
| 10:47 |
|
tcohen[m] |
Hola |
| 10:47 |
|
ashimema |
morning tcohen |
| 10:54 |
|
tcohen[m] |
cait: having a roadmap doesn't mean only focusing on that. In Koha-land it means the opposite LOL |
| 10:54 |
|
tcohen[m] |
dcook do you have a sample plugin background job? |
| 10:59 |
|
Joubu |
tcohen[m]: see his email, he will work on it next week |
| 10:59 |
|
Joubu |
but he is right, it cannot work |
| 10:59 |
|
Joubu |
template-side is buggy |
| 11:07 |
|
tcohen[m] |
Ok, I'll take a look. A lot moved forward in the area since we introduced it |
| 11:08 |
|
Joubu |
what I thought, but apparently it was introduced before.. |
| 11:15 |
|
* cait |
waves |
| 11:16 |
|
cait |
Joubu++ |
| 11:16 |
|
angelic |
hi koha :) I want to put a link on one of the MARC subfield. I think I found the place but I couldnt make any change because "Koha link" combobox is readonly. Here is the screenshot of the page https://snipboard.io/MbKc9v.jpg Is it the right place? How can I do this? Thanks. |
| 11:16 |
|
cait |
a link would normally go in 856$u |
| 11:16 |
|
oleonard |
angelic: "Koha link" refers to the connection between the MARC data and Koha database |
| 11:17 |
|
oleonard |
angelic: Not an HTML link |
| 11:17 |
|
cait |
yes, it doesn't have to do with linking it |
| 11:17 |
|
cait |
it defines where it might be additionally stored outside of the MARC record in your database - I would not change the existing defaults there for now |
| 11:18 |
|
angelic |
One of our libraries wants this link |
| 11:18 |
|
cait |
what do they ask for specifically? because as we said it might not be hte right place to configure what you want |
| 11:18 |
|
cait |
changing the Koha link has a deep impact on your system and existing data, that's why I said not to touch it is better |
| 11:20 |
|
angelic |
They are using tag 260 for some materials and on this tag publisher place,year and name all has links. But they are also using 264 tag for some materials. In that case publisher year and place has no link |
| 11:20 |
|
cait |
ok |
| 11:20 |
|
cait |
that makes sense |
| 11:20 |
|
cait |
you can add links for both fields |
| 11:21 |
|
cait |
go to Koha-to-MARC-Mapping |
| 11:21 |
|
cait |
in administration |
| 11:21 |
|
cait |
there you can change the mappings - it will apply to all frameworks |
| 11:21 |
|
|
khall_ joined #koha |
| 11:21 |
|
cait |
i would recommend to make sure you map always both and that it displays correctly when you are done |
| 11:22 |
|
cait |
260a / 264a , etc. |
| 11:22 |
|
cait |
the display in the frameworks shoudl also change then |
| 11:23 |
|
angelic |
cait : Thank you cait. ı'll try it now |
| 11:34 |
|
tcohen[m] |
@later tell dcook look at t/lib/plugins/Koha/Plugin/Test.pm . It is not the Kitchensink but it implements what's needed: the 'background_tasks' method returning { code => class, ... } and the 'namespace' key in the our $metadata; I did it when I wrote the tests about the funcionality. I overlooked the template part of the matter, most probably |
| 11:34 |
|
huginn |
tcohen[m]: The operation succeeded. |
| 11:38 |
|
* Karter[m] |
uploaded an image: (140KiB) < https://matrix.org/_matrix/med[…]0-13%20133119.png > |
| 11:38 |
|
Karter[m] |
I have a question regarding our translation files. We've installed the nl_NL language pack, and it's been working well for us. However, we've noticed some discrepancies in the text and terminology displayed on our staff interface.... (full message at <https://matrix.org/_matrix/med[…]VnzrwQZopbvnRtIsU>) |
| 11:42 |
|
Adarsh |
Hello Everyone, I am getting one common error from ku and ktd up commands while preparing koha docker server from koha-testing-docker repo which is " Error: EACCES: permission denied, open '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/css/calendar.css' " during yarn build phase of koha-koha-1 container. Please kindly give me your suggestion for resolution. |
| 11:45 |
|
|
khall joined #koha |
| 11:52 |
|
Adarsh |
These are the full output of ku and ktd up commands. https://file.io/Ij26jUYiCa5d |
| 11:53 |
|
|
lds joined #koha |
| 12:04 |
|
|
khall_ joined #koha |
| 12:07 |
|
Joubu |
Karter[m]: the location (filepath+line number) is only for information |
| 12:08 |
|
Joubu |
Karter[m]: if you are using the debian package there is a script named koha-translate that can help you to regenerate the templates |
| 12:09 |
|
Joubu |
Karter[m]: koha-translate --update nl-NL # will update the PO files with the new strings found in the template |
| 12:09 |
|
Joubu |
Karter[m]: koha-translate --install nl-NL will update the translated version of the template |
| 12:11 |
|
Karter[m] |
Joubu: thankyou for the info will get into it |
| 12:13 |
|
Joubu |
Adarsh: permission denied, chmod your $SYNC_REPO |
| 12:14 |
|
|
khall joined #koha |
| 12:24 |
|
|
khall joined #koha |
| 12:45 |
|
paulderscheid[m] |
Just noticed that we get an uncatched error if you set your privacy to never if no 'AnonymousPatron' is selected. Are we aware of that? |
| 12:46 |
|
paulderscheid[m] |
Or rather if the patron sets it. |
| 12:47 |
|
|
khall joined #koha |
| 12:50 |
|
oleonard |
That sounds familiar paulderscheid[m], but I'm not aware of a bug report off the top of my head |
| 12:59 |
|
oleonard |
sco-main.pl doesn't know about the logged-in user's library or the default library, so library-specific HTML customizations won't work... |
| 13:02 |
|
cait |
paulderscheid[m]: i thought we had fixed that :) but maybe not |
| 13:10 |
|
|
emlam joined #koha |
| 13:31 |
|
cait |
hello emlam :) |
| 13:31 |
|
emlam |
hi cait! |
| 13:35 |
|
|
Dyrcona joined #koha |
| 14:00 |
|
paulderscheid[m] |
cait when do you think this was fixed, my checkout is myabe 2 weeks behind |
| 14:01 |
|
cait |
longer ago |
| 14:01 |
|
cait |
i think we maybe missed that one and fixed other spots |
| 14:03 |
|
paulderscheid[m] |
Ok |
| 14:04 |
|
cait |
I don't see an open bug |
| 14:22 |
|
|
cait3 joined #koha |
| 14:25 |
|
|
cait4 joined #koha |
| 14:43 |
|
aude_c[m] |
caroline++ for being such a thorough and helpful documenter! |
| 14:44 |
|
caroline |
:) |
| 14:55 |
|
cait4 |
caroline++ aude_c++ # for being awesome in general |
| 14:56 |
|
reiveune |
bye |
| 14:56 |
|
|
reiveune left #koha |
| 15:01 |
|
aude_c[m] |
😊 Right back at you cait4 ! |
| 15:01 |
|
aude_c[m] |
(or whichever cait is currently around 😉) |
| 15:01 |
|
caroline |
lol! |
| 15:02 |
|
cait4 |
yeah, i dplicate with every disconnect... |
| 15:02 |
|
cait |
that feels better, but might not last long :) |
| 15:02 |
|
aude_c[m] |
I don't think I'd even seen you reach that high a number |
| 15:02 |
|
aude_c[m] |
lol |
| 15:03 |
|
|
alohabot joined #koha |
| 15:03 |
|
cait |
yeah, an especially irritating week |
| 15:04 |
|
* caroline |
sends cookies |
| 15:21 |
|
cait |
thanks :) |
| 15:33 |
|
|
khall joined #koha |
| 15:33 |
|
cait |
bye all! |
| 15:34 |
|
|
cait left #koha |
| 17:03 |
|
cait1 |
@later tell fridolin please remember to close the bugs resolved fixed or Needs documenting that you decide not to push. |
| 17:03 |
|
huginn |
cait1: The operation succeeded. |
| 18:01 |
|
|
caroline_catlady joined #koha |
| 18:55 |
|
|
caroline joined #koha |
| 19:31 |
|
|
khall joined #koha |
| 21:01 |
|
|
khall joined #koha |
| 22:29 |
|
|
khall joined #koha |
