| Time |
S |
Nick |
Message |
| 01:12 |
|
aleisha |
hi |
| 06:43 |
|
|
reiveune joined #koha |
| 06:45 |
|
reiveune |
hello |
| 06:56 |
|
Joubu |
@later tell tcohen "There is no minutes for this meeting - Development_IRC_meeting_5_July_2023" |
| 06:56 |
|
huginn |
Joubu: The operation succeeded. |
| 06:58 |
|
|
thibaud_g joined #koha |
| 07:10 |
|
|
alex__ joined #koha |
| 07:20 |
|
|
cait joined #koha |
| 07:22 |
|
cait |
hello #koha |
| 08:03 |
|
krimsonkharne[m] |
morning #koha |
| 09:02 |
|
paulderscheid[m] |
morning #koha |
| 09:15 |
|
* cait |
waves |
| 09:17 |
|
oleonard |
o/ |
| 09:19 |
|
cait |
hi oleonard |
| 09:19 |
|
wahanui |
hi oleopard |
| 09:32 |
|
ashimema |
anyone fancy QAing bug 34269 ? |
| 09:32 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=34269 major, P5 - low, ---, martin.renvoize, Signed Off , Regression in circulation rules for 'similar' patron categories |
| 09:33 |
|
* ashimema |
is having a QA morning so happy to return the favour |
| 09:43 |
|
ashimema |
with the new tidying practice |
| 09:43 |
|
ashimema |
how thorough are we being about only tidying the relevant lines vs tidying a nearly tidy file as the whole file? |
| 09:50 |
|
ashimema |
cait around? |
| 09:50 |
|
wahanui |
cait around is cait cait1 cait2 cait3 cait4 cait5 |
| 09:51 |
|
cait |
yes |
| 09:51 |
|
ashimema |
the failing test on 33028 |
| 09:51 |
|
cait |
yes? |
| 09:51 |
|
cait |
I couldn't look yesterday, it was too late when I saw it |
| 09:51 |
|
ashimema |
I'm trying to work out if the test highlights an issue or if the test needs fixing |
| 09:51 |
|
cait |
and pretty much booked today |
| 09:52 |
|
cait |
one idea i had: |
| 09:52 |
|
cait |
can you verify if the test still fails with Kyle's linked bugs for fixing overduefindescap behavior? |
| 09:52 |
|
ashimema |
the core question is.. |
| 09:53 |
|
ashimema |
should we allow an empty string for 'fine' |
| 09:53 |
|
cait |
yes |
| 09:53 |
|
cait |
hm, well |
| 09:53 |
|
ashimema |
emptry string vs undef vs 0 vs 0.00 |
| 09:53 |
|
ashimema |
which should be valid |
| 09:53 |
|
cait |
we have the same iissue for overduefinescap |
| 09:53 |
|
ashimema |
that's what this test is catching on |
| 09:53 |
|
cait |
because empty = unlimited |
| 09:53 |
|
cait |
similar discussion |
| 09:54 |
|
cait |
maybe a similar fix too |
| 09:54 |
|
cait |
you can now enter 0 and it will update it to show as empty voer the overdue fines cap |
| 09:55 |
|
cait |
I don't have a strong opinion for the fine one |
| 09:55 |
|
cait |
or not sure what is best, do you have a feeling? |
| 09:56 |
|
ashimema |
I really don't know |
| 09:56 |
|
cait |
I am leaning towards we don't need to allow fine to be 0 |
| 09:56 |
|
ashimema |
I'll look at Kyles bugs |
| 09:57 |
|
ashimema |
it was looking at those that reminded me I needed to come back and fix this test 😜 |
| 09:57 |
|
cait |
I wonder how it wroked before the move... and it probably stored 0.000 when the field was still decimal in the db (issuingrules table) |
| 09:57 |
|
ashimema |
it's not just about fine really |
| 09:57 |
|
cait |
so we might be safer with 0 than with empty/undefined |
| 09:57 |
|
ashimema |
it just happens to be what this test picks as a test against |
| 09:57 |
|
cait |
for the overduefinescamp we needed to bring back the empty/0 behavior, because you ened to be able to not limit |
| 09:57 |
|
cait |
and it also caused issues because it reset existing empties to zero, breaking the fine rules |
| 09:58 |
|
ashimema |
yikes |
| 09:58 |
|
cait |
so as we had empty before, you edited a rule, ti would save as 0 and no more fines accruing |
| 09:59 |
|
ashimema |
is there an order to Kyles two bugs |
| 09:59 |
|
cait |
it came up ont he mailing list a lot, I want his fix finally |
| 09:59 |
|
ashimema |
should I look at one before the other? |
| 09:59 |
|
cait |
let me see |
| 09:59 |
|
MatthewBlenkinsop[m] |
o/ |
| 09:59 |
|
ashimema |
sorry Matthew Blenkinsop, I'm filling up your queue again 😜 |
| 10:01 |
|
cait |
ashimema: i think bug 32271 and bug 34279 can be tested indepently, but I probably tested as: 33028 - 32271 - 34279 |
| 10:01 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32271 major, P5 - low, ---, geraud.frappier, Signed Off , Overdue fines cap (amount) set to 0.00 when editing rule |
| 10:01 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=34279 major, P5 - low, ---, kyle, Signed Off , overduefinescap of 0 is ignored, but overduefinescap of 0.00 is enforced |
| 10:01 |
|
ashimema |
ta |
| 10:02 |
|
cait |
I'd realyl love the see the circulation fixes make it, it's a najor udpate headache |
| 10:02 |
|
ashimema |
hmm.. so we drop the price formatting in bug 32271 I see |
| 10:02 |
|
ashimema |
yup |
| 10:02 |
|
ashimema |
that's why I'm devoting time to them now |
| 10:02 |
|
ashimema |
one last push to get them over the line |
| 10:03 |
|
ashimema |
aha, I see |
| 10:03 |
|
ashimema |
he adds 'can_be_blank', which is nice and what I was thinking |
| 10:03 |
|
ashimema |
cool, that works for me |
| 10:03 |
|
ashimema |
I think for 'fines' though, blank is wrong |
| 10:04 |
|
ashimema |
we don't need to distinguish between 0 and blank/undefined |
| 10:04 |
|
ashimema |
0 means "don't charge anything", blank wouldn't have any meaningful use |
| 10:05 |
|
ashimema |
what does bug me though.. I never wrote unit tests for this module change |
| 10:05 |
|
ashimema |
and no-one caught that! |
| 10:05 |
|
ashimema |
my mistake originally of course.. it got lost in all the work we did |
| 10:05 |
|
ashimema |
but still.. |
| 10:16 |
|
oleonard |
cait: Do you remember how to reproduce the problem described in Bug 34072? |
| 10:16 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=34072 normal, P5 - low, ---, lucas, Pushed to oldstable , Holds queue search interface hidden on small screens |
| 10:16 |
|
oleonard |
The bug describes "search controls." Does that mean the sidebar filter? |
| 10:36 |
|
cait |
all I did was to squash teh browser window |
| 10:36 |
|
cait |
yes the filters disappeared I think |
| 10:40 |
|
oleonard |
For me the filters just bump down to below the table, which is to be expected |
| 10:40 |
|
Annelisterman[m] |
oleonard: same here with Firefox |
| 10:40 |
|
|
khall joined #koha |
| 10:41 |
|
oleonard |
...and I don't see any difference before and after the patch |
| 10:51 |
|
|
khall_ joined #koha |
| 11:14 |
|
|
marcelr joined #koha |
| 11:15 |
|
marcelr |
o/ |
| 11:16 |
|
marcelr |
ashimema: you are welcome to qa 33608 ? |
| 11:18 |
|
ashimema |
I'll add it to the list 😛 |
| 11:18 |
|
ashimema |
just wrapping my head around this circ rules money bug still at the minute |
| 11:20 |
|
marcelr |
ok no worries just trying |
| 11:21 |
|
ashimema |
I will certainly take a look |
| 11:21 |
|
ashimema |
🙂 |
| 11:21 |
|
marcelr |
great |
| 11:22 |
|
|
alex__ joined #koha |
| 11:42 |
|
ashimema |
how close to circ rules and money and ... are you marcelr |
| 11:43 |
|
marcelr |
i could have a look |
| 11:44 |
|
ashimema |
I wouldn't mind a second pair of QA eyes on bug 32271 |
| 11:44 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32271 major, P5 - low, ---, geraud.frappier, Signed Off , Overdue fines cap (amount) set to 0.00 when editing rule |
| 11:44 |
|
marcelr |
i try to have a look today |
| 11:45 |
|
ashimema |
I'm pretty confident in it now.. but I've ended up with three follow-ups.. so I feel like a final run would be beneficial |
| 11:45 |
|
marcelr |
the more follow-ups the more fun :) |
| 11:45 |
|
ashimema |
Unit tests for the win 😜 |
| 11:45 |
|
cait |
at leat if it still works i the end ;) |
| 11:48 |
|
cait |
ashimema++ marcelr++ |
| 11:51 |
|
marcelr |
dont forget cait++ |
| 11:51 |
|
marcelr |
anyone else ? |
| 11:52 |
|
cait |
possibly, I'll think about it in my next meeting |
| 11:52 |
|
marcelr |
thinking and meetings |
| 11:57 |
|
cait |
ok, yes... maybe not a good idea :) |
| 12:04 |
|
tcohen |
hola #koha o/ |
| 12:04 |
|
tcohen |
hi marcelr |
| 12:05 |
|
tcohen |
marcelr, ashimema should we allow passing 1.1 ? or do we enforce 1.10? |
| 12:06 |
|
tcohen |
/^\d+(\.\d{2})?$/ |
| 12:06 |
|
tcohen |
-> /^\d+(\.\d{2})?$/ |
| 12:09 |
|
marcelr |
hi tcohen |
| 12:09 |
|
marcelr |
i should first have a closer look there |
| 12:09 |
|
marcelr |
but i would tend to 1.10 or something configured for it |
| 12:10 |
|
tcohen |
-> /^\d*(\.\d+)?$/ |
| 12:10 |
|
tcohen |
^^ that one would cover any number |
| 12:10 |
|
tcohen |
with the dot conditional to a decimal |
| 12:10 |
|
marcelr |
yes it covers empty too |
| 12:11 |
|
tcohen |
and the regex is trying to avoid 1,10 if I understand correctly |
| 12:11 |
|
tcohen |
i.e. using an invalid (db-wise) separator |
| 12:11 |
|
tcohen |
ashimema? |
| 12:11 |
|
wahanui |
i guess ashimema is back on security bugs today.. sorry, it's been a bit of a crazy week |
| 12:12 |
|
tcohen |
Koha::Exceptions::CirculationRule::NotDecimal->throw( name => $rule_name, value => $rule_value ) |
| 12:12 |
|
tcohen |
- if ( $is_monetary && defined($rule_value) && $rule_value !~ /^\d+(\.\d{2})?$/ ); |
| 12:12 |
|
tcohen |
+ if ( $is_monetary && defined($rule_value) && $rule_value !~ /^\d*(\.\d+)?$/ ); |
| 12:15 |
|
tcohen |
Maybe we should use |
| 12:15 |
|
marcelr |
allowing .3 instead of 0.30 ? |
| 12:15 |
|
tcohen |
perl -MScalar::Util -e 'print "yes\n" if Scalar::Util::looks_like_number("1.10");'; |
| 12:15 |
|
tcohen |
perl -MScalar::Util -e 'print "yes\n" if Scalar::Util::looks_like_number("1,10");'; |
| 12:15 |
|
marcelr |
looks_like_monetary ? |
| 12:16 |
|
tcohen |
if we force two decimals, then we need to do some trick on the controller (like +0.00 or similar) |
| 12:16 |
|
marcelr |
yeah we should probably not need to do it |
| 12:16 |
|
marcelr |
only in display |
| 12:22 |
|
tcohen |
this is an extra check |
| 12:23 |
|
tcohen |
so any bug in the controller doesn't make the bad value reach the DB |
| 12:23 |
|
marcelr |
do we currently have currencies with more decimals than 2 in Koha ? |
| 12:24 |
|
tcohen |
I don't think so |
| 12:24 |
|
tcohen |
the (tiny) problem as I see it, is that the regex forbids one decimal |
| 12:24 |
|
marcelr |
yes |
| 12:25 |
|
Joubu |
cannot pay fines in bitcoin, too bad |
| 12:25 |
|
marcelr |
but if we do not have monetary > 2, why allow 4 ? |
| 12:25 |
|
tcohen |
Joubu: exactly :-P |
| 12:26 |
|
marcelr |
and the trend is stop with fines altogether |
| 12:30 |
|
marcelr |
we should first define the number of decimals per currency if anyone wants to go there |
| 12:30 |
|
marcelr |
now we dont know |
| 12:30 |
|
marcelr |
just assume 2 |
| 12:32 |
|
Joubu |
we always assumed 2 |
| 12:32 |
|
Joubu |
git grep decimal_fill Koha/Number/Price.pm |
| 12:33 |
|
marcelr |
yeah no problem for me, but we try to allow .3 and 1.1 too now |
| 12:33 |
|
ashimema |
sorry, was grabbing lunch |
| 12:33 |
|
marcelr |
couldnt we catch missing decimals at the client side ? |
| 12:34 |
|
marcelr |
but we need at server too obviously |
| 12:34 |
|
marcelr |
ashimema: just read what tomas said ^^ |
| 12:35 |
|
ashimema |
at some point I think we allowed 3 decimals |
| 12:35 |
|
ashimema |
though I can't remember which currency it was that used that |
| 12:36 |
|
marcelr |
we do not registrate the number of decimals per currency |
| 12:36 |
|
ashimema |
inded |
| 12:36 |
|
ashimema |
indeed.. even |
| 12:36 |
|
ashimema |
as for the regex.. I think I just stuck with the same one we've been introducing on the UI everywhere |
| 12:36 |
|
ashimema |
I didn't come up with it. |
| 12:36 |
|
ashimema |
cait ^ |
| 12:37 |
|
ashimema |
where did the pattern match you've been using all over the place come from in the first place? |
| 12:37 |
|
marcelr |
lol |
| 12:37 |
|
ashimema |
Iraqi Dinar has 3 decimals |
| 12:37 |
|
Joubu |
are you aware of bug 34169? |
| 12:37 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=34169 enhancement, P5 - low, ---, katrin.fischer, Signed Off , Add validation for monetary input fields in acquisition module |
| 12:37 |
|
marcelr |
they are probably flattened all over |
| 12:37 |
|
ashimema |
as does Jordanian Dinar |
| 12:38 |
|
marcelr |
+ number: _("Please add amount in valid format: 0.00"), |
| 12:38 |
|
ashimema |
she's done it differently there |
| 12:38 |
|
Joubu |
this is the correct way |
| 12:39 |
|
Joubu |
it's client-side only however |
| 12:39 |
|
ashimema |
type="text" inputmode="decimal" pattern="^\d+(\.\d{2})?$" |
| 12:39 |
|
ashimema |
that's what's been getting added all over the place |
| 12:39 |
|
ashimema |
I was worried it would block more than it should |
| 12:40 |
|
marcelr |
we shouldnt add them like that |
| 12:40 |
|
marcelr |
we will be mad when the Dinar comes in |
| 12:40 |
|
Joubu |
I am entering into a discussion I don't want to be involved, I am disapearing right now :D |
| 12:40 |
|
marcelr |
same for us all Joubu |
| 12:41 |
|
marcelr |
i sense an In Discussion coming |
| 12:41 |
|
ashimema |
grr.. this is a major bug |
| 12:41 |
|
ashimema |
again |
| 12:41 |
|
Joubu |
you are too many already anyway. Just saying I've talked with cait last week and what is on 34169 seems correct for me. |
| 12:41 |
|
ashimema |
it can't go in discussion.. again |
| 12:41 |
|
|
emlam joined #koha |
| 12:42 |
|
marcelr |
i think we could go with it; if you entered .1 and 2.2 twice you will learn it at some point |
| 12:43 |
|
marcelr |
just postponing the whole 3 decimals stuff to the future |
| 12:43 |
|
marcelr |
can we squash those patches ashimema |
| 12:43 |
|
marcelr |
it is like add remove and add etc |
| 12:46 |
|
ashimema |
`/^(?:-?\d+|-?\d{1,3}(?:,\d{3})+)?(?:.\d+)?$/ |
| 12:46 |
|
ashimema |
* `/^(?:-?\d+|-?\d{1,3}(?:,\d{3})+)?(?:.\d+)?$/` |
| 12:46 |
|
ashimema |
that's what jQuery validator is using internally |
| 12:46 |
|
ashimema |
yup.. I was leaving that with the RM |
| 12:46 |
|
Joubu |
if we have centralise the checks and the logic, the format will not be difficult to modify later |
| 12:46 |
|
ashimema |
33028 was a fecking nightmare to work through |
| 12:46 |
|
ashimema |
indeed |
| 12:47 |
|
tcohen |
so, in 330.28, I'll just update the value in Circulation.t so it doens't fail, and we leave it as-is |
| 12:49 |
|
marcelr |
so you can go ahead, ashimema, and pass qa on the 32271 then ? |
| 12:50 |
|
tcohen |
what a twist ROTFL |
| 12:50 |
|
marcelr |
seeing some timethis stuff btw |
| 12:51 |
|
ashimema |
thanks marcelr 🙂 |
| 12:51 |
|
marcelr |
tcohen: Koha bends like no other |
| 12:52 |
|
marcelr |
next problem please :) |
| 12:58 |
|
tcohen |
marcelr: show we disable FK checks when changing column names for fks? |
| 12:58 |
|
tcohen |
should |
| 12:59 |
|
marcelr |
i think we should; at some sql versions it could somehow crash |
| 12:59 |
|
tcohen |
mariadb 10.4 => 211200048.pl fails |
| 12:59 |
|
marcelr |
i looked for a report but didnt find it |
| 13:00 |
|
tcohen |
mentioning it on an unrelated bug doesn't generate a new bug report? |
| 13:00 |
|
tcohen |
where's the AI when we need it? |
| 13:01 |
|
marcelr |
right |
| 13:01 |
|
marcelr |
we need a bot here to create bugzilla reports |
| 13:04 |
|
Joubu |
as you are (almost) all around, I would like to know how I could get your attention on those 3 bugs: bug 33568, bug 33940 and bug 30825 |
| 13:04 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33568 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Use the REST API to display items on the biblio detail view |
| 13:04 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33940 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Move get_cardnumber_length and checkcardnumber to Koha |
| 13:04 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30825 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Get rid of GetReservesControlBranch |
| 13:04 |
|
ashimema |
those bugs excite me |
| 13:04 |
|
Joubu |
I am willing to trade SO or QA for them |
| 13:04 |
|
ashimema |
I just haven't had a moment ☹️ |
| 13:04 |
|
Joubu |
they are awesome, really |
| 13:04 |
|
Joubu |
there is as well bug 33940 |
| 13:05 |
|
Joubu |
I gave it already |
| 13:05 |
|
marcelr |
33940 sounds intriguing |
| 13:05 |
|
Joubu |
I meant bug 33947 |
| 13:05 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33947 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Move GetAllIssues to Koha |
| 13:05 |
|
Joubu |
really, please help them, they are big and it won't be easy to rebase endlessly |
| 13:06 |
|
Joubu |
and I am lacking energy for rebases nowadays... |
| 13:07 |
|
Joubu |
33940 is introducing a concept of a Koha::Policy namespace |
| 13:07 |
|
marcelr |
i should go to that SO and QA trade market one day |
| 13:07 |
|
Joubu |
that I am using in bug 30825 too |
| 13:07 |
|
marcelr |
code related to 33940 is a nightmare iirc |
| 13:07 |
|
Joubu |
make your list! :D |
| 13:08 |
|
marcelr |
just look for my name in NSO and SO :) |
| 13:08 |
|
Joubu |
*was* a nightmare, it's now nice and friendly |
| 13:08 |
|
marcelr |
Joubu++ |
| 13:08 |
|
Joubu |
it's using Koha::Result::Boolean and Koha::Object::Messages |
| 13:09 |
|
Joubu |
and Bug 33947: Remove GetAllIssues, did you read that? REMOVE **GetAllIssues**! |
| 13:09 |
|
* ashimema |
looks at bug 33608 as promised now.. then will come to Joubu's list |
| 13:10 |
|
Joubu |
you all should be excited by that! :D |
| 13:10 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33608 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Allow to get statistics about found/recovered books |
| 13:10 |
|
tcohen |
I am, Joubu :-D |
| 13:10 |
|
Joubu |
AND! **Use the REST API to display items on the biblio detail view** |
| 13:11 |
|
Joubu |
really, they are great, lot of code and changes, but there going where we want to go |
| 13:16 |
|
* ashimema |
contemplate |
| 13:16 |
|
ashimema |
is `!$updated_columns{itemlost} && $pre_mod_item->itemlost` |
| 13:16 |
|
ashimema |
really the same as |
| 13:17 |
|
ashimema |
`$updated_columns{itemlost} <= 0 && $pre_mod_item->itemlost > 0` |
| 13:17 |
|
ashimema |
don't we have functionality tied to negative, 0, positive integers there? |
| 13:19 |
|
marcelr |
which patch exactly ashimema |
| 13:19 |
|
ashimema |
https://bugs.koha-community.or[…]attachment=151916 |
| 13:19 |
|
ashimema |
Bug 33608: Add UpdateStats to item->store |
| 13:19 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33608 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Allow to get statistics about found/recovered books |
| 13:20 |
|
marcelr |
this is just rewriting what was there already |
| 13:20 |
|
ashimema |
yes.. except I think the logic is changed |
| 13:20 |
|
marcelr |
adding the other situation |
| 13:20 |
|
* ashimema |
wonders if there's good test coverage here |
| 13:22 |
|
marcelr |
the other patches are moving tests |
| 13:22 |
|
* ashimema |
is currently looking at the docs to understand if there's any logical reason for the numerical comparison vs just truthyness |
| 13:22 |
|
ashimema |
the docs feel like we're safe |
| 13:23 |
|
ashimema |
they only talk about 0,1,2,3,4 as values |
| 13:23 |
|
ashimema |
though of course people can add their own |
| 13:23 |
|
ashimema |
I can't see why you'd want to treat -1 differently |
| 13:24 |
|
ashimema |
one question I do have though.. |
| 13:24 |
|
ashimema |
did you want to record the itemlost value in your stats.. or just the fact it was lost or found |
| 13:24 |
|
marcelr |
need to get that code back in my mind |
| 13:25 |
|
ashimema |
right now you just add 'item_lost' or 'item_found' |
| 13:25 |
|
marcelr |
the purpose is the lost and found |
| 13:25 |
|
marcelr |
mainly |
| 13:25 |
|
marcelr |
not the value specifically |
| 13:25 |
|
ashimema |
but of course.. itemlost can take various options |
| 13:25 |
|
ashimema |
okies |
| 13:25 |
|
ashimema |
thanks |
| 13:28 |
|
Joubu |
I would not change the logic if it's not the goal of the patch |
| 13:30 |
|
marcelr |
i need to add an else branch there |
| 13:31 |
|
marcelr |
to differentiate lost and found again |
| 13:32 |
|
ashimema |
I think the logic change is sound based on the community manual |
| 13:32 |
|
ashimema |
but I may be missing something behind the scenes.. some hidden functionality |
| 13:32 |
|
ashimema |
i.e. around when we trigger the trigger |
| 13:32 |
|
ashimema |
we will trigger it more often now than before |
| 13:32 |
|
ashimema |
any lost value other than zero will trigger it now |
| 13:32 |
|
ashimema |
before it was only a change to positive integer |
| 13:33 |
|
marcelr |
we ignored the found again situation |
| 13:33 |
|
ashimema |
oop, other way around |
| 13:33 |
|
ashimema |
we ignored negative lost to unlost changes |
| 13:33 |
|
ashimema |
not we catch those as well as positive lost to unlost values |
| 13:34 |
|
marcelr |
i see your point about >0; i am catching <>0 but is just theory we dont have negative values |
| 13:34 |
|
marcelr |
and i think if we have we should catch them too |
| 13:35 |
|
marcelr |
that was the reason |
| 13:35 |
|
ashimema |
I dunno.. was there a use case for it at some point |
| 13:35 |
|
ashimema |
as I said.. I can't see any from the docs right now.. but I'm not a Koha historian and the docs have been known to miss things 😜 |
| 13:35 |
|
marcelr |
negative lost not that i know of |
| 13:36 |
|
marcelr |
negative notforloan is something else |
| 13:36 |
|
marcelr |
if you still miss a test, let me know |
| 13:36 |
|
marcelr |
unit test |
| 13:39 |
|
Joubu |
this is one for cait or kidclamp, I think they know what to do with negative values |
| 13:39 |
|
marcelr |
cant find any other examples so quickly now that test for >0 on itemlost btw normally we just test <>0 |
| 13:39 |
|
marcelr |
truthy |
| 13:49 |
|
|
Kolvir joined #koha |
| 13:51 |
|
Kolvir |
I’ve been trying to connect to koha via a ssh tunnel and get the koha maintenance page. I've confirmed that the server is running correctly locally. ssh -L 8080:localhost:80 -N -f -l <user> <ip address> . |
| 13:55 |
|
Kolvir |
Would appreciate any help that would let me connect to the remote server. So close, must be something simple. |
| 13:58 |
|
tcohen |
Feliz cumpleaños, gmcharlt |
| 14:02 |
|
ashimema |
hmm |
| 14:02 |
|
marcelr |
? |
| 14:02 |
|
ashimema |
is the tidy check in the qa scripts working well for everyone else? |
| 14:03 |
|
marcelr |
yeah it is not tidy yet probably.. |
| 14:03 |
|
marcelr |
written before |
| 14:03 |
|
ashimema |
indeed |
| 14:03 |
|
marcelr |
had no problem with qa tools |
| 14:03 |
|
ashimema |
but I just added a follow-up that should have fixed the tidy issues |
| 14:03 |
|
ashimema |
yet it still fails |
| 14:03 |
|
ashimema |
which is a bit odd |
| 14:03 |
|
ashimema |
second patchset like it for me too |
| 14:04 |
|
ashimema |
I kind of wish you'd split this bug.. cleanup and feature distinctly |
| 14:05 |
|
marcelr |
strange |
| 14:05 |
|
ashimema |
the new + insert methods feel inconsistent with elsewhere in Koha to me |
| 14:05 |
|
ashimema |
not outright wrong.. they work |
| 14:05 |
|
ashimema |
but the inconsistency feels strange |
| 14:05 |
|
marcelr |
the insert is a way to prevent changing lost of calls |
| 14:05 |
|
marcelr |
lots |
| 14:05 |
|
ashimema |
mm |
| 14:06 |
|
marcelr |
it is pragmatic |
| 14:06 |
|
ashimema |
yeah, I see |
| 14:07 |
|
marcelr |
touching code everywhere isnt nice either with backporting etc etx |
| 14:07 |
|
Joubu |
the test is not perfect, and don't do magic. It simply count the number of lines not tidy before and after, then compare. So you can easily cheat it by removing more lines and add some lines that are not tidy, the test won't catch them |
| 14:07 |
|
* ashimema |
is just running the QA tests again but hopefulyl it's all good now |
| 14:07 |
|
ashimema |
then I need a swim |
| 14:07 |
|
marcelr |
qaers fooling qa tools, how bad is that ? |
| 14:07 |
|
Joubu |
and, again, it's a WARN, not FAIL. And it has been pushed to get feedback ;) |
| 14:08 |
|
marcelr |
well there you have it :) |
| 14:09 |
|
marcelr |
you should read it as "we like it " :) |
| 14:17 |
|
marcelr |
perltidy++ |
| 14:18 |
|
marcelr |
ashimema++ |
| 14:18 |
|
marcelr |
ashimema: i already opened bug 33636 |
| 14:18 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33636 enhancement, P5 - low, ---, m.de.rooy, ASSIGNED , Move C4::Stats to Koha namespace |
| 14:19 |
|
Kolvir |
Does anyone know if it is an issue with the tunnel, or is is a setting in koha or apache that is redirecting me to the maintenance page? |
| 14:19 |
|
Joubu |
ashimema, marcelr: why keeping the logic change? |
| 14:20 |
|
mtj |
hi Kolvir: your problem is probably caused by apache |
| 14:20 |
|
marcelr |
why keep it if it is not used in Koha elsewhere Joubu? |
| 14:20 |
|
Joubu |
Kolvir: go to the staff interface and run the update process, on 8081 |
| 14:20 |
|
mtj |
hi Joubu :) |
| 14:21 |
|
Joubu |
marcelr: we are talking about Koha::Item->store, be careful there.. |
| 14:21 |
|
Joubu |
mtj: hi! |
| 14:21 |
|
marcelr |
a nonzero lost means that it is lost in some way |
| 14:21 |
|
marcelr |
probably negative losts are not very common either |
| 14:21 |
|
Joubu |
you are introducing a behaviour change in a patch that is doing something else |
| 14:22 |
|
Joubu |
*probably*... |
| 14:22 |
|
Joubu |
Are you new in Koha? |
| 14:22 |
|
mtj |
Kolvir: your ssh tunneling is easier if you set koha opac and staff to different port numbers (8080 and 8081) |
| 14:22 |
|
marcelr |
yes i could revert that tiny change if you insist |
| 14:22 |
|
ashimema |
I PQA'd and mentioned for the RM 😜 |
| 14:22 |
|
marcelr |
i will change it and add another test |
| 14:23 |
|
marcelr |
will block it and put it back to pqa |
| 14:23 |
|
ashimema |
okies |
| 14:23 |
|
ashimema |
school run time for me.. bbiab |
| 14:24 |
|
marcelr |
the second concern is harder ashimema |
| 14:24 |
|
marcelr |
move it to the followup |
| 14:24 |
|
Joubu |
commit dd1eec2715b465 |
| 14:24 |
|
Kolvir |
I can get to the staff interface via ssh and x11 forwarding, but performance is really bad |
| 14:27 |
|
mtj |
Kolvir: quick fix is to set your staff to port 8081, to access it |
| 14:27 |
|
Kolvir |
what file is that setting in? |
| 14:27 |
|
mtj |
...or add some entries to your local pc's /etc/host files |
| 14:28 |
|
|
khall joined #koha |
| 14:28 |
|
Joubu |
marcelr: and initially coming from commit 0005f6bad36319e11a1b0c561403e75758a803af, so yes, it does not make a lot of sense |
| 14:28 |
|
Kolvir |
looking in /etc/koha/ |
| 14:29 |
|
mtj |
Kolvir: vi /etc/apache2/sites-available/mykoha123.conf |
| 14:29 |
|
Kolvir |
ty |
| 14:31 |
|
mtj |
$ sudo /etc/init.d/apache2 restart |
| 14:31 |
|
Kolvir |
# OPAC 4 <VirtualHost *:80> here or # Intranet 22 <VirtualHost *:80> |
| 14:32 |
|
|
Dyrcona joined #koha |
| 14:32 |
|
Kolvir |
4 and 22 are line numbers |
| 14:34 |
|
mtj |
22 |
| 14:36 |
|
mtj |
Kolvir: you need to add 'Listen 8080' to /etc/apache2/ports.conf |
| 14:38 |
|
Kolvir |
leave listen 80 in there? |
| 14:38 |
|
mtj |
hmm, sure :) |
| 14:39 |
|
Kolvir |
I'm not a network guy, if it hasn't been made clear by my ignorance ;). Am, however a programmer. |
| 14:39 |
|
mtj |
aah, we are setting staff to 8081 yes? |
| 14:39 |
|
Kolvir |
yes |
| 14:39 |
|
Kolvir |
listen 8081 then? |
| 14:39 |
|
mtj |
yeah |
| 14:40 |
|
mtj |
$ ssh -L 9999:localhost:8081 -N -f -l <user> <ip address> |
| 14:40 |
|
mtj |
$ lynx http://localhost:9999 |
| 14:41 |
|
mtj |
^ you should tunnel to staff interface on 8081 |
| 14:41 |
|
Kolvir |
there an eaiser way to kill a tunnel than netstat and kill the PID? |
| 14:42 |
|
mtj |
i would kill with pid :) |
| 14:42 |
|
Kolvir |
just seemed clunky... |
| 14:44 |
|
Kolvir |
That did it! Thank you so much. I have been trying to get remote access to this machine for over a year. Volunteer for a church library that I'm setting up with koha. about 6,000 items and not even a manual card catalog. Been a 'process' to say the least. |
| 14:45 |
|
Kolvir |
Thank you so much. Koha community has been great. |
| 14:45 |
|
mtj |
Kolvir: congrats |
| 14:45 |
|
Kolvir |
I started the project with evergreen and community support was silent. |
| 14:46 |
|
ashimema |
everygreen is big and scary for the project your size |
| 14:46 |
|
Kolvir |
So glad I found koha. I know it is overkill for our needs, but we don't have the budget for $600+/year license the commercial offerings |
| 14:46 |
|
ashimema |
I used to support evergreen.. we decided pretty much no-one was big enough to require everygreen here at the time so we dropped support and went Koha only |
| 14:47 |
|
mtj |
Kolvir: if you really need to access many sites on a single port, you can add your hostnames to your local /etc/hosts file |
| 14:47 |
|
Kolvir |
Now if I can find a way to modify the Quick spine label to support my zebra printer, I'd be really rolling. |
| 14:49 |
|
mtj |
echo '127.0.0.1 staff1.mykoha.com' >> /etc/hosts |
| 14:49 |
|
mtj |
echo '127.0.0.1 staff2.mykoha.com' >> /etc/hosts |
| 14:49 |
|
mtj |
lynx http://staff1.mykoha.com:9999 |
| 14:49 |
|
mtj |
lynx http://staff2.mykoha.com:9999 |
| 14:50 |
|
Kolvir |
It has been a huge project for me. Been really hard to figure out the workflow and organize volunteers. Having no card catalog at all has made it rough, especially as I'm a tech guy, not a librarian. |
| 14:50 |
|
Kolvir |
That for my remote system or the library server? |
| 14:52 |
|
mtj |
Kolvir: add your hostnames to your local /etc/hosts file |
| 14:52 |
|
|
abf joined #koha |
| 14:54 |
|
Kolvir |
Does Koha have any python code ? I'd like to contribute at somnepoint, but perl makes my eyes bleed and I don't know JS yet. I'm an old midrange developer, but my SQL is very rusty. |
| 14:59 |
|
Kolvir |
Again, thank you. This has made my life much easier. I live about 40 min from the library, so this will allow me to get so much more done. |
| 14:59 |
|
Joubu |
no python, but if you are a python developer you will manage to read our code |
| 14:59 |
|
Joubu |
we are trying to make it readable ;) |
| 15:00 |
|
Kolvir |
Not your perl I was referring to but perl in general! |
| 15:00 |
|
Kolvir |
I used to program RPG/ILE, and even, Lord help me, COBOL. |
| 15:03 |
|
marcelr |
cobol++ |
| 15:03 |
|
marcelr |
you are in the right channel Kolvir lol |
| 15:04 |
|
|
khall_ joined #koha |
| 15:05 |
|
Kolvir |
I may have to pick up Java Script soon for a job, between that and SQL I'll see what I can do down the road. Thanks again, I have to head out soon. |
| 15:09 |
|
Joubu |
oleonard++ thanks!! |
| 15:10 |
|
oleonard |
👍🏻 |
| 15:14 |
|
|
thibaud_g joined #koha |
| 15:18 |
|
Joubu |
tcohen: we broke ktd startup, see jenkins |
| 15:18 |
|
Joubu |
17:16:40 koha_1 | Exception 'Koha::Exceptions::CirculationRule::NotDecimal' thrown 'The circulation rule expected a decimal value' with name => overduefinescap, value => |
| 15:18 |
|
Joubu |
we need to fix misc4dev |
| 15:18 |
|
Joubu |
I think it's this one: |
| 15:19 |
|
Joubu |
./insert_data.pl |
| 15:19 |
|
Joubu |
141 overduefinescap => "", |
| 15:19 |
|
Joubu |
sorry I have to run right now! I will fix it tomorrow if it's not done yet (but it must be done before :D) |
| 15:20 |
|
tcohen |
oook |
| 15:20 |
|
tcohen |
thanks Joubu |
| 15:23 |
|
ashimema |
yowsers.. I didn't even consider that side effect at all |
| 15:23 |
|
tcohen |
I'm wondering... |
| 15:23 |
|
tcohen |
why a reset_all is not failing |
| 15:24 |
|
tcohen |
as it is wiping the DB and loading it all again |
| 15:31 |
|
oleonard |
Idea for Bug 26258: https://snipboard.io/G9fFmo.jpg |
| 15:31 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=26258 enhancement, P5 - low, ---, koha-bugs, NEW , Circulation tabs inconsistent with counters |
| 15:33 |
|
caroline |
oleonard, what does the blue and yellow mean? |
| 15:34 |
|
caroline |
I like that if it's 0, there is nothing |
| 15:34 |
|
oleonard |
Blue is neutral, yellow indicates that something might need action (unresolved return claims) |
| 15:35 |
|
oleonard |
I can see using red for the restrictions count |
| 15:36 |
|
caroline |
And were losing the number of resolved claims, is that intentional? Or is it because it's currently 0? |
| 15:37 |
|
caroline |
I definitely like this more that what it was. The inconsistency was bugging me |
| 15:37 |
|
oleonard |
It's intentional because I don't think the count of resolved claims is high-priority information |
| 15:37 |
|
caroline |
+1 |
| 15:38 |
|
oleonard |
I was undecided about the count of clubs |
| 15:38 |
|
caroline |
Unless its higher that ClaimReturnedWarningThreshold maybe? |
| 15:39 |
|
caroline |
Yes I'm not sure about the clubs either... is it really useful to know there are 14 clubs going on? There is not limit on patron categories or age for the clubs, so it will always show the total number of clubs |
| 15:40 |
|
oleonard |
I wasn't aware of the ClaimReturnedWarningThreshold preference. That counts both resolved and unresolved? |
| 15:41 |
|
caroline |
I'm not sure... let me check the manual, maybe the info is there |
| 15:44 |
|
caroline |
The manual says nothing, but the patron_messages.inc has |
| 15:44 |
|
caroline |
[% IF return_claims.count > ClaimReturnedWarningThreshold %] |
| 15:44 |
|
caroline |
I think it's all claims no matter the status |
| 15:45 |
|
caroline |
And it would be all claims within a certain time period only, since we can use clean-up database to delete old ones |
| 16:32 |
|
oleonard |
caroline: It could work like this: https://snipboard.io/mJN3rj.jpg |
| 16:33 |
|
caroline |
So did you find out if it was only resolved claims? |
| 16:34 |
|
|
thibaud_g joined #koha |
| 16:36 |
|
emlam |
ClaimReturnedWarningTheshold is indeed all claims no matter the status |
| 16:36 |
|
oleonard |
Where does it get used? |
| 16:37 |
|
emlam |
as far as I know, the only thing it does is post a warning message on the patron account page that they have too many claims (but doesn't restrict their account in any way) |
| 16:37 |
|
caroline |
it's meant to show a message. patron_messages.inc |
| 16:37 |
|
ashimema |
i tried to remove that 0 from claims before |
| 16:37 |
|
ashimema |
and got told off |
| 16:37 |
|
ashimema |
can't remember the bug |
| 16:37 |
|
ashimema |
but I tried hard to clean that area once before |
| 16:38 |
|
oleonard |
Yeah I think I remember ashimema |
| 16:38 |
|
ashimema |
I do like your move towards all being labels though.. that's nice |
| 16:49 |
|
|
khall joined #koha |
| 16:50 |
|
ashimema |
can't find the bug though |
| 16:50 |
|
ashimema |
oh well.. I'm sure someone will pipe up |
| 16:50 |
|
ashimema |
anywho.. it's dinner time here.. |
| 16:50 |
|
ashimema |
have a good evening all |
| 16:55 |
|
caroline |
ashimema, maybe bug 26264 ? |
| 16:55 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=26264 enhancement, P5 - low, ---, oleonard, RESOLVED DUPLICATE, Styling of 'counts' on patron details tabs is inconsistent |
| 17:09 |
|
reiveune |
bye |
| 17:09 |
|
|
reiveune left #koha |
| 17:10 |
|
ashimema |
I'm sure there was a fair bit of discussion on whatever bug it was |
| 17:10 |
|
|
emlam joined #koha |
| 17:10 |
|
ashimema |
Some that explained why people weren't keen to drop the two numbers |
| 17:19 |
|
ashimema |
Found the discussion |
| 17:19 |
|
ashimema |
https://irc.koha-community.org[…]0-08-21#i_2280071 |
| 17:19 |
|
ashimema |
From there onwards |
| 17:19 |
|
ashimema |
I think I just gave up |
| 17:31 |
|
|
Dyrcona joined #koha |
| 17:43 |
|
tcohen |
@later tell Joubu the jenkins problem was highlighting an issue bug 34279 solves. So not a misc4dev bug |
| 17:43 |
|
huginn |
tcohen: The operation succeeded. |
| 17:43 |
|
tcohen |
tests++ |
| 17:54 |
|
|
thibaud_g joined #koha |
| 18:03 |
|
|
bag joined #koha |
| 18:16 |
|
|
michelle joined #koha |
| 19:14 |
|
|
thibaud_g joined #koha |
| 19:15 |
|
|
cait joined #koha |
| 19:44 |
|
caroline |
Does CustomCoverImages work with two placeholders? I'm trying to get PG images to test and the URL has the control number twice (1736 in the example) https://www.gutenberg.org/cach[…].cover.medium.jpg |
| 19:45 |
|
caroline |
So CustomCoverImages should be https://www.gutenberg.org/cache/epub/{001}/pg{001}.cover.medium.jpg |
| 19:45 |
|
caroline |
But I can't get it to work.... I'm wondering if the problem is me or the pref |
| 19:46 |
|
caroline |
oleonard's URL in bug 28235 only has one substitution |
| 19:46 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28235 normal, P5 - low, ---, oleonard, RESOLVED FIXED, Custom cover images are very large in staff search results and OPAC details |
| 20:02 |
|
|
DarusSalamSeminaryLibrary[m] joined #koha |
| 20:03 |
|
DarusSalamSeminaryLibrary[m] |
hello |
| 20:06 |
|
DarusSalamSeminaryLibrary[m] |
first time setting up Koha at our library, we are having some trouble with automating the email notification system for patrons. any assistance would be much appreciated |
| 20:19 |
|
caroline |
DarusSalamSeminaryLibrary[m], could you be more specific on what the problem is? |
| 20:24 |
|
|
khall joined #koha |
| 20:28 |
|
|
khall_ joined #koha |
| 20:34 |
|
|
thibaud_g joined #koha |
| 21:50 |
|
aleisha |
hello |
| 21:54 |
|
|
thibaud_g joined #koha |
| 22:03 |
|
DarusSalamSeminaryLibrary[m] |
<caroline> "3muskateers, could you be more..." <- For some reason, patrons are not receiving any emails whenever books are checked out or in, even though under "patron messaging preferences" it is set to receive all notices. The "notices" tab also shows that the notice is pending but it remains that way indefinitely. There is no error or failure to send message warning. Hope this clarifies the issue and any help is |
| 22:03 |
|
DarusSalamSeminaryLibrary[m] |
appreciated |
| 23:12 |
|
|
khall joined #koha |
| 23:14 |
|
|
thibaud_g joined #koha |
