| Time |
S |
Nick |
Message |
| 00:41 |
|
dcook |
I should've taken a screenshot when I was briefly king of Passed QA in June... hehe |
| 00:52 |
|
|
lukeg joined #koha |
| 00:54 |
|
|
lukeg1 joined #koha |
| 02:16 |
|
|
cait1 joined #koha |
| 04:22 |
|
dcook |
bug 33967 |
| 04:22 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33967 normal, P5 - low, ---, dcook, Needs Signoff , REMOTE_ADDR incorrect in plack.log when run behind a proxy |
| 04:23 |
|
dcook |
I'm not proud of how long that took to solve, but I'm so happy to fix it ^_^ |
| 05:18 |
|
|
Oak joined #koha |
| 05:44 |
|
ashimema |
I'm going to upset you now dcook... Any chance of a unit test for that? I can envisage people not realising how it works and re-breaking it 😉 |
| 05:56 |
|
dcook |
ashimema: You know how to ruin a Friday afternoon eh? :p |
| 06:00 |
|
dcook |
I might be able to craft a very specific unit test for this one, but someone could still break it with a different middleware |
| 06:04 |
|
dcook |
Ohh brain juices are starting to flow.. |
| 06:10 |
|
ashimema |
Hugs |
| 06:23 |
|
magnuse |
\o/ |
| 06:24 |
|
magnuse |
dcook: is that a good thing or a bad thing? |
| 06:28 |
|
dcook |
magnuse: brain juices flowing is good hehe |
| 06:28 |
|
dcook |
I think i've nearly got the test |
| 06:29 |
|
dcook |
I'm able to create a one-shot bespoke PSGI app without a server, which is pretty awesome |
| 06:29 |
|
dcook |
The unit test will just be for the SetEnv middleware but we could potentially use the same unit test for other middlewares to test things out |
| 06:32 |
|
|
reiveune joined #koha |
| 06:33 |
|
reiveune |
hello |
| 06:33 |
|
wahanui |
hey, reiveune |
| 06:36 |
|
dcook |
Yass think I've worked out the test |
| 06:36 |
|
dcook |
Nice try ashimema :P |
| 06:36 |
|
dcook |
Friday afternoon not ruined hehe |
| 06:46 |
|
dcook |
Annnnd unit test done. Man i'm good haha |
| 06:48 |
|
ashimema |
Nice one |
| 06:50 |
|
dcook |
Thanks. I was holding out for some praise haha. |
| 06:51 |
|
dcook |
Pretty proud of that bit of work really. I ended up adding debugging code into all kinds of Plack modules to try to figure out exactly what was going on behind the scenes... |
| 06:52 |
|
dcook |
Figured it would've been one of the other modules playing up. Didn't even think to look at SetEnv.pm until Static.pm was returning the wrong info... |
| 06:54 |
|
Joubu |
@later tell tcohen Koha_Master/2551/ finally run correctly with COVERAGE :) Flagged as "keep forever"! |
| 06:54 |
|
huginn |
Joubu: The operation succeeded. |
| 06:55 |
|
dcook |
davidnind the real MVP for testing though :3 |
| 06:55 |
|
dcook |
davidnind++ |
| 06:55 |
|
|
alex_ joined #koha |
| 06:56 |
|
davidnind |
I don't really understand what is going on, but the test plan was easy to follow... |
| 06:56 |
|
davidnind |
dcook++ |
| 06:56 |
|
dcook |
<3 |
| 06:57 |
|
dcook |
I'm just so pumped to be able to get the client IP address in plack.log hehe |
| 06:57 |
|
dcook |
Drives me a little crazy when I see my local proxy address in there instead |
| 06:58 |
|
dcook |
And yeah the way the Plack::Middleware works.. it is a bit mind-bending |
| 06:58 |
|
dcook |
Callbacks wrapped around callbacks wrapped around callbacks... |
| 06:59 |
|
|
thibaud_g joined #koha |
| 07:00 |
|
|
thibaud_glt joined #koha |
| 09:01 |
|
magnuse |
dcook++ |
| 09:02 |
|
magnuse |
davidnind++ |
| 09:31 |
|
* cait1 |
waves |
| 09:56 |
|
|
khall joined #koha |
| 09:57 |
|
|
alex_ joined #koha |
| 10:18 |
|
|
khall_ joined #koha |
| 10:22 |
|
oleonard |
Joubu++ |
| 10:22 |
|
oleonard |
Yes please to killing the "built in" offline circ |
| 10:28 |
|
cait1 |
oleonard: want to so? :) |
| 10:28 |
|
cait1 |
SO I mean, I could QA it |
| 10:28 |
|
cait1 |
bug 33961 |
| 10:28 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33961 normal, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Offline circulation tool no longer working and should be removed |
| 10:28 |
|
oleonard |
Working on it now! |
| 10:32 |
|
cait1 |
:) |
| 10:40 |
|
|
khall joined #koha |
| 10:41 |
|
oleonard |
Looks good to me cait1 |
| 10:45 |
|
cait1 |
ok :) will work on it next |
| 11:00 |
|
oleonard |
cait1: How did you test the serialcollection tab with Bug 33897? |
| 11:00 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33897 minor, P5 - low, ---, oleonard, Failed QA , Use template wrapper for tabs: OPAC bibliographic detail page |
| 11:15 |
|
cait1 |
you add a subscription to the record |
| 11:15 |
|
cait1 |
then set the preference to subscrpition being hte first tab |
| 11:15 |
|
cait1 |
when you load the detail page, the subscription tab should be selected as active |
| 11:17 |
|
oleonard |
Oh for some reason I misread and thought you had a problem with the serialcollection tab in particular |
| 11:18 |
|
cait1 |
ah, i think with MARC21 you can only test the one setting |
| 11:19 |
|
|
alex_ joined #koha |
| 11:22 |
|
tcohen |
hola #koha, happy friday |
| 11:23 |
|
cait1 |
hi tcohen |
| 11:29 |
|
tcohen |
thanks Joubu |
| 11:29 |
|
tcohen |
hi cait1 |
| 12:06 |
|
magnuse |
¡hola tcohen! |
| 12:14 |
|
|
khall joined #koha |
| 12:22 |
|
|
khall_ joined #koha |
| 12:30 |
|
cait1 |
someone for QA on bug 33790? |
| 12:30 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33790 normal, P5 - low, ---, koha-bugs, Signed Off , Fix and add various links to the manual |
| 12:30 |
|
cait1 |
would make a nice addition to the .01 |
| 12:36 |
|
cait1 |
it looks like registrations are open https://perlkohacon.fi/ :) |
| 12:46 |
|
Joubu |
did we contact nugged? |
| 12:47 |
|
Joubu |
at least to tell him he forgot to tell us the info was there! :D |
| 12:53 |
|
cait1 |
I didn't |
| 13:05 |
|
magnuse |
huh? trying to go through the we installer on 22.11.05, i have to log in again after each step? |
| 13:05 |
|
cait1 |
sounds odd |
| 13:05 |
|
cait1 |
something wrong with the cookies? |
| 13:07 |
|
magnuse |
the only cookie i can see is KohaOpacLanguage |
| 13:09 |
|
magnuse |
in the console, when i click in the username field: caught (in promise) TypeError: Cannot read properties of undefined (reading 'icons') |
| 13:11 |
|
Joubu |
tcohen: did you see the follow-up to fix cypress tests? additional_work kw |
| 13:12 |
|
tcohen |
not yet |
| 13:12 |
|
tcohen |
was distracted with other things :-| |
| 13:19 |
|
magnuse |
...and i can't add an admin-account, because i get logged out and when i log in it says the passwords don't match, even if i pasted the same password into the fields |
| 13:20 |
|
magnuse |
another instance on the same server gives me a CGISESSID cookie, and works as expected |
| 13:21 |
|
|
nikkom joined #koha |
| 13:21 |
|
nikkom |
I want to ask a question about changing date format in perl |
| 13:22 |
|
magnuse |
huh, closed the browser and when i log in it works |
| 13:22 |
|
|
khall joined #koha |
| 13:23 |
|
|
khall_ joined #koha |
| 13:33 |
|
tcohen |
@seen fridolin |
| 13:33 |
|
huginn |
tcohen: fridolin was last seen in #koha 1 week, 1 day, 5 hours, 13 minutes, and 31 seconds ago: <fridolin> Joubu: Bug 22802 comment 10, wrong bug maybe |
| 13:33 |
|
* ashimema |
wonders if he's on vacation |
| 13:34 |
|
tcohen |
@later tell fridolin I will push some stuffs to 23.05 while you come back, we are approaching string freeze pretty fast |
| 13:34 |
|
huginn |
tcohen: The operation succeeded. |
| 13:36 |
|
nikkom |
I have date format 2006-06-01 but I want to convert it 01/06/2006 how can I do it? |
| 13:36 |
|
cait1 |
maybe take a step back |
| 13:36 |
|
cait1 |
what are you trying to do and how? |
| 13:42 |
|
nikkom |
In version 22.11 I am using flatpickr class and the value I get from datepicker is of format 2006-06-01 . In pl part I am composing an SQL in which I need date format as 01/06/2006 |
| 13:44 |
|
cait1 |
are you developing a plugin? |
| 13:44 |
|
ashimema |
dt_from_string should handle this stuff transparently for you |
| 13:44 |
|
nikkom |
cait1 : I am trying to prepare a statistic page |
| 13:45 |
|
nikkom |
ashimema : thanks, I didnt use it before and I will try this |
| 13:57 |
|
|
lukeg joined #koha |
| 14:09 |
|
Joubu |
@later tell nikkom if you are adjusting code to 22.11 you may want to have a look at bug 30718, which change how we fundamentally deal with date in Koha. |
| 14:09 |
|
huginn |
Joubu: The operation succeeded. |
| 14:40 |
|
Joubu |
PedroAmorim[m]: I think bug 33973 is quite bad |
| 14:40 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33973 normal, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Sorting broken on ERM tables |
| 14:47 |
|
PedroAmorim[m] |
that sounds like fun! |
| 14:48 |
|
PedroAmorim[m] |
won't be able to look at it today and I'm off next week unfortunately! |
| 14:59 |
|
nugged |
(oh, I see someone summoned me!) |
| 15:00 |
|
|
bag joined #koha |
| 15:00 |
|
nugged |
joubu cait1: we're finalizing a few pages on site for registration and filling some pages, so I planned to send a mail about this in a day when this will be done because a few from that list "Transport and Travel. Hotels and Appartments. |
| 15:00 |
|
nugged |
Location and Venue. Social Programme and special events. |
| 15:00 |
|
nugged |
Tips: 101, food, weather, time, language. What to See and Do in Helsinki." being published right now |
| 15:00 |
|
nugged |
but anyway yes, please - https://perlkohacon.fi/Registration.html |
| 15:02 |
|
cait1 |
I was just noticing the registration is open and mentioned it here :) |
| 15:14 |
|
nugged |
cait1: yeah! 🤗 |
| 15:19 |
|
nugged |
(and "please" means: it is required! :) ) |
| 15:21 |
|
Joubu |
nugged: "I have proposal or idea for ogranizers, please contact me" |
| 15:21 |
|
Joubu |
typo ogranizers |
| 15:21 |
|
nugged |
oh, now I need to chase those who manage that tool |
| 15:21 |
|
nugged |
ok, thanks :) |
| 15:25 |
|
Joubu |
tcohen: 33491 - last patch is missing |
| 15:25 |
|
Joubu |
that's why there was the kw |
| 15:43 |
|
reiveune |
bye |
| 15:43 |
|
|
reiveune left #koha |
| 16:04 |
|
tcohen |
Joubu: I forgot to push? |
| 16:08 |
|
pastebot |
"tcohen" at 127.0.0.1 pasted "Joubu:" (16 lines) at https://paste.koha-community.org/16807 |
| 16:12 |
|
tcohen |
Joubu: 1e231653ca10768b019ac616bc115fd5afbdb955 |
| 17:10 |
|
|
lukeg joined #koha |
| 18:14 |
|
tcohen |
anyone from catalyst? |
| 18:14 |
|
tcohen |
mtj: around? |
| 18:18 |
|
cait1 |
weekend for Catalyst |
| 18:18 |
|
tcohen |
21.11 is broken |
| 18:19 |
|
tcohen |
cait1: do you have access to any 21.11.21 ? |
| 18:19 |
|
tcohen |
to validate my assertion? |
| 18:20 |
|
tcohen |
OPAC search results show empty records for those records with on loan items |
| 18:21 |
|
tcohen |
anyone?? |
| 18:21 |
|
wahanui |
anyone is free to give it a shot :-) |
| 18:22 |
|
|
khall joined #koha |
| 18:22 |
|
tcohen |
I'm sorry |
| 18:24 |
|
tcohen |
@later tell mtj please package 21.11.22 so we announce a mini fix... |
| 18:24 |
|
huginn |
tcohen: The operation succeeded. |
| 18:42 |
|
|
khall_ joined #koha |
| 19:33 |
|
|
khall joined #koha |
| 20:16 |
|
|
lukeg joined #koha |
| 21:55 |
|
|
khall joined #koha |
| 22:04 |
|
|
khall joined #koha |
