| Time |
S |
Nick |
Message |
| 00:23 |
|
|
lavamind joined #koha |
| 00:27 |
|
|
lavamind joined #koha |
| 00:29 |
|
|
lavamind left #koha |
| 01:21 |
|
dcook |
tuxayo: Nicely done |
| 05:15 |
|
|
chriss joined #koha |
| 05:22 |
|
|
did joined #koha |
| 05:47 |
|
|
fridolin joined #koha |
| 05:50 |
|
|
reiveune joined #koha |
| 05:51 |
|
reiveune |
hello |
| 06:19 |
|
dcook |
salut reiveune |
| 06:19 |
|
dcook |
That time of the day already O_O |
| 06:51 |
|
magnuse |
\o/ |
| 06:54 |
|
|
paul_p joined #koha |
| 07:01 |
|
|
cait joined #koha |
| 07:02 |
|
|
cait1 joined #koha |
| 07:03 |
|
|
lds joined #koha |
| 07:05 |
|
|
TimothyAlexis joined #koha |
| 07:06 |
|
TimothyAlexis |
I'm wondering if anyone has any idea how to solve this? bug 28388 |
| 07:06 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28388 enhancement, P5 - low, ---, oleonard, NEW , Search result set is lost when viewing the MARC plain view (opac-showmarc.pl) |
| 07:10 |
|
|
fridolin joined #koha |
| 07:11 |
|
|
fridolin1 joined #koha |
| 07:30 |
|
Joubu |
TimothyAlexis: yes, let me remember how it works |
| 07:31 |
|
Joubu |
there is something stored in the session |
| 07:32 |
|
Joubu |
ha, it's the "busc" stuff |
| 07:34 |
|
Joubu |
TimothyAlexis: do you want a patch or guidance to fix it? |
| 07:35 |
|
Joubu |
\o/ |
| 08:18 |
|
|
did joined #koha |
| 08:33 |
|
|
TimothyAlexis joined #koha |
| 08:34 |
|
TimothyAlexis |
Hi Joubu, well either way is fine. |
| 08:35 |
|
TimothyAlexis |
We have modifications on the opac-details.pl page, so if it would be a patch, I'd still have to understand it to implement it. |
| 08:36 |
|
TimothyAlexis |
If it's easy for someone to make the patch, that would be great. Otherwise, I'm asking for some guidance so that I can make it. |
| 08:37 |
|
|
did joined #koha |
| 08:51 |
|
|
MarkHofstetter1 joined #koha |
| 08:52 |
|
|
TimothyAlexis_ joined #koha |
| 08:54 |
|
MarkHofstetter1 |
hi, I am trying to use koha-gitify (I want to test some bugs/fixes) but after "gitification" I'm looping endlessly through the upgrade routine - thank in advance |
| 08:54 |
|
Joubu |
fridolin1: don't forget the follow-up on bug 28302 |
| 08:54 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28302 major, P5 - low, ---, julian.maurice, Pushed to stable , Koha does not work with CGI::Compile 0.24 |
| 08:55 |
|
Joubu |
MarkHofstetter1: did you restart memcached, apache and plack? |
| 08:56 |
|
magnuse |
MarkHofstetter1: have you considered koha-testing-docker? :-) |
| 08:56 |
|
Joubu |
Are you aware of the koha-testing-docker project? It's what Koha developers are using |
| 08:56 |
|
MarkHofstetter1 |
I really don't like docker in that context |
| 09:00 |
|
MarkHofstetter1 |
me <= stupid memcache restart did it |
| 09:04 |
|
MarkHofstetter1 |
thx |
| 09:09 |
|
fridolin1 |
Joubu: ok thnaks |
| 09:10 |
|
TimothyAlexis_ |
Regarding bug 28388 would it perhaps be so easy as to add [% USE Koha %] to opac-showmarc.tt ? |
| 09:10 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28388 enhancement, P5 - low, ---, oleonard, NEW , Search result set is lost when viewing the MARC plain view (opac-showmarc.pl) |
| 09:11 |
|
TimothyAlexis_ |
Something about opac-MARCdetail.pl / .tt allows for the search result to be kept, while when loading opac-showmarc.pl / .tt it is dropped. |
| 09:15 |
|
Joubu |
TimothyAlexis_: did you see I attached a patch there 2 hours ago? |
| 09:16 |
|
TimothyAlexis_ |
Haha, thank you |
| 09:16 |
|
TimothyAlexis_ |
Joubu++ |
| 10:05 |
|
|
cait joined #koha |
| 10:20 |
|
|
davidnind joined #koha |
| 10:24 |
|
TimothyAlexis_ |
Joubu, I want to sign off the patch, but on the machine where I have koha, I'm getting "NameError: global name 'host' is not defined" when trying to do git-bz apply |
| 10:24 |
|
TimothyAlexis_ |
where I have koha master* |
| 10:37 |
|
TimothyAlexis_ |
I have the correct settings for bz-tracker in ~/.gitconfig and the settings are correct for git_config = {... in /usr/local/git-bz/git-bz |
| 10:38 |
|
TimothyAlexis_ |
I've also pulled the latest git-bz |
| 10:45 |
|
Joubu |
TimothyAlexis_: http://paste.koha-community.org/553 |
| 10:45 |
|
Joubu |
you need that in your gitconfig |
| 10:46 |
|
|
fridolin joined #koha |
| 10:58 |
|
TimothyAlexis_ |
Joubu: I have that |
| 10:58 |
|
TimothyAlexis_ |
If I remember correctly, you helped me fix this on that specific machine some weeks ago. :\ |
| 11:02 |
|
magnuse |
search the logs, if you discussed it here? |
| 11:04 |
|
|
khall joined #koha |
| 11:04 |
|
TimothyAlexis_ |
http://irc.koha-community.org/[…]hyAlexis&q=git-bz |
| 11:05 |
|
TimothyAlexis_ |
I'm not getting any results |
| 11:06 |
|
magnuse |
it doesn't seem to give *any* results, must be something wrong with it |
| 11:06 |
|
TimothyAlexis_ |
I found it when I removed &q and searched the page for git-bz instead... |
| 11:07 |
|
TimothyAlexis_ |
It was 2021-04-28 and you helped me fix the .gitconfig file Joubu. Those settings are the same since then. |
| 11:07 |
|
TimothyAlexis_ |
It was the same error. |
| 11:23 |
|
Joubu |
TimothyAlexis_: sorry I can't help much, this error means that you have something wrong in your config. Double-check it. Maybe you have another entry that is conflicting with that one |
| 11:24 |
|
oleonard |
Weird, irc log search does seem to be broken |
| 11:25 |
|
oleonard |
The irc log Google search returns results though |
| 11:35 |
|
TimothyAlexis_ |
This is my whole .gitconfig: http://paste.koha-community.org/554 |
| 11:41 |
|
tcohen |
morning |
| 11:45 |
|
oleonard |
Joubu: Bug 28388 is needs signoff, right? |
| 11:45 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28388 enhancement, P5 - low, ---, oleonard, NEW , Search result set is lost when viewing the MARC plain view (opac-showmarc.pl) |
| 11:46 |
|
TimothyAlexis_ |
Yes, I have tested it and it works |
| 11:49 |
|
Joubu |
yes, a test plan is missing however |
| 12:26 |
|
magnuse |
hooray for bug 28410 |
| 12:26 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28410 enhancement, P5 - low, ---, koha-bugs, NEW , Reduce memory footprint |
| 12:30 |
|
Joubu |
bug 28306, bug 28411, bug 28413, bug 28415, bug 28416, bug 28417 |
| 12:30 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28306 enhancement, P5 - low, ---, julian.maurice, Signed Off , Allow to query database with minimal memory footprint |
| 12:30 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28411 enhancement, P5 - low, ---, koha-bugs, In Discussion , Investigate memory footprint of the different dependencies |
| 12:31 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28413 enhancement, P5 - low, ---, jonathan.druart+koha, In Discussion , background job worker is running with all the modules in RAM |
| 12:31 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28415 enhancement, P5 - low, ---, koha-bugs, In Discussion , z3950_responder.pl is running with all the modules in RAM |
| 12:31 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28416 enhancement, P5 - low, ---, koha-bugs, In Discussion , Email::Sender::Transport::SMTP is using 10Mo of RAM |
| 12:31 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28417 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Authen::CAS::Client always loaded even in CAS in not in used |
| 12:31 |
|
Joubu |
and those related ones |
| 12:41 |
|
|
davidnind left #koha |
| 12:43 |
|
ashimema |
ooh |
| 12:43 |
|
ashimema |
that reminds me. |
| 12:43 |
|
ashimema |
have you seen https://metacpan.org/pod/distr[…]cript/perlimports Joubu ? |
| 12:44 |
|
ashimema |
it's meant to help clean up such imports.. I wondered about running it against Koha |
| 12:44 |
|
Joubu |
I wrote a patch for that |
| 12:44 |
|
Joubu |
already, years ago |
| 12:45 |
|
ashimema |
I seem to remember helping to QA it ;) |
| 12:45 |
|
ashimema |
but it's an ongoing battle |
| 12:45 |
|
Joubu |
IIRC there were issues I didn't manage to fix |
| 12:45 |
|
ashimema |
I was thinking perlimports might help maintain a cleaner base |
| 12:45 |
|
Joubu |
worth trying this module |
| 12:45 |
|
Joubu |
yep |
| 12:46 |
|
ashimema |
Olaf has a pretty good repuation,, knows perl guts pretty well if memory serves |
| 12:46 |
|
ashimema |
it's a pretty new thing, but certainly worth a little look |
| 12:46 |
|
Joubu |
bug 17600 |
| 12:46 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=17600 enhancement, P5 - low, ---, jonathan.druart+koha, In Discussion , Standardize the EXPORT |
| 12:55 |
|
|
Dyrcona joined #koha |
| 13:14 |
|
|
lukeG1 joined #koha |
| 13:25 |
|
magnuse |
on 20.11.05 i am missing the little box for filtering/searching ILL requests in the row of "table controls" right above the main table of ill requests. was that by design, or is it a bug? |
| 13:27 |
|
oleonard-away |
magnuse: OPAC or staff interface? |
| 13:28 |
|
ashimema |
results are interesting using perlimports Joubu. |
| 13:28 |
|
magnuse |
oleonard: staff |
| 13:29 |
|
magnuse |
i know i can use the form on the left to search, but that little js-search is so much more responsive... |
| 13:30 |
|
magnuse |
i see it on other tables, like on pendingreserves.pl |
| 13:32 |
|
oleonard |
magnuse: I see it in 20.11.05 so I'm not sure what's going on |
| 13:33 |
|
Joubu |
ashimema: it's more or less what 17600 did actually :) |
| 13:33 |
|
magnuse |
oleonard: lucky you :-) |
| 13:33 |
|
Joubu |
the script is still running here, I ran on top of 17600 |
| 13:33 |
|
ashimema |
haha.. |
| 13:33 |
|
ashimema |
oh really.. interesting |
| 13:33 |
|
ashimema |
I ran against master |
| 13:33 |
|
Joubu |
17600 also dealt with with EXPORT |
| 13:34 |
|
ashimema |
yeah, would be nice to have both |
| 13:34 |
|
magnuse |
oleonard: it is missing when i choose english langauge too, so not a translation problem. nothing in the js console... |
| 13:34 |
|
ashimema |
I like the idea of tieing it to the QA script ;) |
| 13:35 |
|
Joubu |
ashimema: yes but we need to reach a stable state first |
| 13:35 |
|
magnuse |
oleonard: i see it on a 20.05.07 install |
| 13:35 |
|
Joubu |
the script decides to chmod...755 to 644 |
| 13:36 |
|
Joubu |
ashimema: +use Encode (); |
| 13:36 |
|
Joubu |
which means Encode should be removed it seems |
| 13:36 |
|
Joubu |
README says that it does not remove useless import but an option would be nice actually :) |
| 13:36 |
|
ashimema |
agreed |
| 13:41 |
|
ashimema |
--[no-]preserve-unused |
| 13:41 |
|
ashimema |
When enabled, unused modules will be removed. Defaults to preserving unused modules. |
| 13:41 |
|
ashimema |
Enabling this may remove modules which are only present for the purposes of preloading or which aren't being detected for other reasons, so use this setting with care. |
| 13:46 |
|
|
khall joined #koha |
| 14:04 |
|
|
fridolin left #koha |
| 14:16 |
|
magnuse |
nah, too tired to fix anything now, see y'all on tuesday! |
| 14:38 |
|
tuxayo |
hi koha o/ |
| 14:46 |
|
reiveune |
bye |
| 14:46 |
|
|
reiveune left #koha |
| 14:51 |
|
|
lukeG joined #koha |
| 14:59 |
|
tuxayo |
ashimema: Hi :) It seems you did the analysis of bug 28385, not sure if all the questions have been resolved. If so, since I signed it off, you might be able to QA it. |
| 14:59 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28385 critical, P5 - low, ---, dpavlin, Signed Off , ldap server configuration broken since migration from XML::Simple |
| 15:11 |
|
|
cait1 left #koha |
| 15:14 |
|
|
khall joined #koha |
| 15:31 |
|
|
cait joined #koha |
| 16:20 |
|
philor |
could somebody just quickly entirely refactor AddReturn for me? kthx |
| 17:10 |
|
oleonard-away |
philor: Somebody must be done by now, eh? |
| 17:13 |
|
philor |
changed my mind, once I saw that the current state where comments are below the line they refer to, or have no relationship to any line of code, is actually from the last refactor |
| 17:32 |
|
|
lukeG joined #koha |
| 17:43 |
|
* tuxayo |
checks AddReturn |
| 17:44 |
|
tuxayo |
lol nope |
| 18:11 |
|
tcohen |
philor what do you want? |
| 18:15 |
|
philor |
tcohen: I want all the side-effects to be clear, and to have it be clear what things should and should not happen when $doreturn = 0 |
| 18:16 |
|
philor |
I'm currently fixing the unobvious way that if you block return of withdrawn items, and block return of lost items, and AddReturn a lost and withdrawn item, it'll stay lost and withdrawn but the charge for replacementprice will be removed |
| 18:16 |
|
philor |
then next I'll be fixing the way that if you block return of lost items, we'll still fill a hold with your lost item while leaving it lost |
| 18:18 |
|
philor |
and because of where we check $doreturn, for a while I thought I'd then be fixing sending a message to the patron saying the item was checked in when it's blocked by being lost or withdrawn, but we don't do that, we just start to do it and then stop |
| 18:26 |
|
philor |
or maybe what I want it for it not to set $doreturn = 0 for the not-checked-out case, so that $doreturn = 0 only means withdrawn && blockreturnofwithdrawn || lost && blockreturnoflost, so things can just all be if( $doreturn ) |
| 18:31 |
|
philor |
but more immediately, I want a unit test that checks on a lost item charge, so I can copy-paste it without having to figure out how to do it on my own |
| 19:33 |
|
pastebot |
"philor" at 127.0.0.1 pasted "Why won't this bloody test fail?" (55 lines) at http://paste.koha-community.org/558 |
| 19:40 |
|
* philor |
considers playing the Dumb Librarian Fixing Obvious Bustage In Totally Untested Code card, and just skipping the test entirely |
| 19:43 |
|
|
lukeG joined #koha |
| 20:31 |
|
|
khall joined #koha |
| 20:57 |
|
ashimema |
AddReturn is a scary place... Let's call it organic growth... One day I'd love to have a solid reason/funding/excuse to work through cleaning it up like you say.. |
| 20:58 |
|
ashimema |
Starting with a metric tonne more tests... |
| 21:02 |
|
|
khall joined #koha |
| 21:04 |
|
tuxayo |
> organic growth |
| 21:04 |
|
tuxayo |
I'll remember this term to complement another one: «historical reasons» |
| 21:21 |
|
koha-jenkins |
Yippee, build fixed! |
| 21:21 |
|
koha-jenkins |
Project Koha_Master_U20 build #113: FIXED in 46 min: https://jenkins.koha-community[…]a_Master_U20/113/ |
| 21:36 |
|
|
davidnind joined #koha |
| 21:54 |
|
|
lukeG1 joined #koha |
| 22:46 |
|
|
bdonnahue1 joined #koha |
| 23:01 |
|
koha-jenkins |
Project Koha_Master_U20 build #114: SUCCESS in 46 min: https://jenkins.koha-community[…]a_Master_U20/114/ |
| 23:10 |
|
|
lukeG joined #koha |
| 23:11 |
|
|
lukeG joined #koha |
| 23:35 |
|
|
khall joined #koha |
