Time Nick Message 02:30 mtj hi ashimema, prod packages are released using tags pushed by the rmaints 05:17 ArvindNaikwadi[m] Koha How to Print Extended Patron Attributes on a Patron Card? 06:12 reiveune hello 06:15 ArvindNaikwadi[m] Koha How to Print Extended Patron Attributes on a Patron Card? 06:46 Joubu mtj: did you see the 2 upgrade errors on the ML? 06:46 Joubu https://lists.katipo.co.nz/pipermail/koha/2023-April/059282.html 06:47 Joubu https://lists.katipo.co.nz/pipermail/koha/2023-April/059285.html 06:47 Joubu ha, just noticed the error now 06:47 Joubu Undefined subroutine &main::DropAllForeignKeys called at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 86. 06:48 Joubu no that's not the error 06:49 Joubu it's a weird one, looks like the DB is empty... 06:56 magnuse did anything come out of the discussion about "limit duration of queries in stat requests" in marseille? 06:58 cait1 hm I think that one was a small group, I didn't hear about the results 07:00 Joubu If you are trying to reclaim disk space with docker prune, and notice that some volumes are not deleted, you should use "docker volume prune --filter all=1" (since docker 23) see https://github.com/docker/cli/issues/4028 07:01 Joubu magnuse: it happens on bug 33116 07:01 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33116 enhancement, P5 - low, ---, koha-bugs, NEW , Limit reports execution time with sql variables 07:12 dcook After my Docker Desktop Hyper-V crashed today with a corrupt virtual disk, I finally switched over to Docker Desktop WSL 2 heh 07:12 dcook Good thing that I schedule regular backups of my Docker volumes, so could restore from last night's backups :D 07:12 dcook The perils of developing on Windows... 07:13 * dcook waves goodnight 07:13 paulderscheid[m] Morning #koha 07:13 paulderscheid[m] Good night dcook 07:13 dcook paulderscheid[m] I took a look at your wiki instructions again. Interesting idea! 07:13 paulderscheid[m] Did you use the guide or did you DIY? 07:13 dcook I was curious why you didn't go the Docker Desktop route 07:13 Joubu is git fetch working for someone? 07:14 dcook Joubu: I did one fairly recently 07:14 dcook I'll try again 07:14 dcook Hmm I'm too up-to-date perhaps 07:14 Joubu hum ok, it works now. It got stuck for a couple of minutes 07:14 paulderscheid[m] I thought it was a much more complicated setup with Docker Desktop and wanted to simplify things. 07:14 dcook I think it's working 07:14 dcook Joubu: It often seems to get stuck for me. I often run "git fetch" and then go away and do something else 07:15 dcook paulderscheid[m]: Fair enough! 07:15 paulderscheid[m] I wish I could finally get rid of Docker Desktop on macOS :P 07:15 dcook I use Docker for a lot of other projects, so I suppose I like the deep integrations 07:16 dcook Faair 07:16 paulderscheid[m] Me too, but they are not nearly as complicated as Koha :D 07:16 dcook I haven't tried the WSL 2 bind mounts yet.. 07:16 dcook Koha certainly has some baggage... 07:17 paulderscheid[m] Haha ^^ 07:17 dcook The funny thing is that it's the Hyper-V VDHX that got corrupted... 07:17 dcook And WSL 2 is just using a VDHX under the hood as well so in theory the same thing could happen again... 07:17 paulderscheid[m] If you run into roadblocks on WSL2, let me know. I'm interested. 07:17 dcook WSL 2 just hides the virtual machine a lot more than Hyper-V... 07:17 dcook Will do. So far so good though. 07:18 dcook I suppose there was the elasticsearch issue.. 07:18 dcook Had to add a .wslconfig file to my ~ in Windows 07:18 dcook Anyway, I really better be running 07:18 paulderscheid[m] Good Night ๐ 07:18 dcook Ciao ciao 07:27 magnuse Joubu: thanks! 07:43 magnuse perhaps something we could try and keep in mind for future hackfests: to write something down about the discussions we have, so others can have an idea of what direction the discussions took etc? 07:52 ashimema I was going to write a blog post from my notes magnuse 07:53 ashimema though I don't have a blog anymore so not sure where to stick it.. the ptfs-e website perhaps 07:53 ashimema I know Aude and I both took copious notes ๐ 07:53 ashimema so that covers two angles 07:53 magnuse that would be awesome! 07:59 magnuse is https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface up to date? i changed a .scss file and tried to run "yarn build" in ktd, but get "gulp not found" 08:01 magnuse ah maybe i missed "yarn install" 08:03 mtj hi magnuse, gulp should already be installed in ktd 08:05 mtj magnuse: hmm, that wiki page might be out-of-date now 08:06 mtj take a look at ./build-resources.PL (and run it too?) 08:06 mtj yarn install --frozen-lockfile 08:06 mtj yarn build:prod 08:08 magnuse "yarn install" + "yarn build" ran ok 08:08 magnuse error Command "build:prod" not found. 08:09 Joubu yarn css:build:prod 08:09 Joubu edit package.json and search for "scripts" to see the options you have 08:10 Joubu `yarn build:prod` should indeed work, sorry for the noise.. 08:11 magnuse "$ KOHA_IMAGE=22.05 ktd up" if that is relevant 08:14 Joubu the new yarn commands are for >= 22.11.04 08:51 mtj @later tell liliputech: hiya, can you push bug 32668 please 08:51 huginn mtj: The operation succeeded. 09:04 mtj hi Joubu, regarding https://lists.katipo.co.nz/pipermail/koha/2023-April/059285.html 09:04 mtj "Undefined subroutine &main::DropAllForeignKeys called at 09:04 mtj /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl" 09:06 mtj we need to call DropAllForeignKeys explicitly - or export sub from C4::Installer.pm 09:07 mtj (looks like an actual bug) 09:07 Joubu we should not reach that line 09:07 Joubu it's too early in updatedatabase 09:07 Joubu it's not a compilation error 09:10 mtj ah yes, good point :) 09:10 mtj i think its a common error.. if the database does not exist? 09:11 Joubu they are saying they are upgrading, so I assume the DB exists 09:12 mtj mysql is not running. etc? 09:14 mtj a db without a syspref table, or no 'Version' row/value? 09:15 Joubu maybe, but weird that it happens twice in a few days 09:21 cait just a thought I had... 09:21 cait could it be they have multiple instances and for one instance the web isntaller hasn't been run / db not created? 09:23 krimsonkharne[m] Hi #koha! 09:23 krimsonkharne[m] anybody getting an error after trying to start ktd? 09:23 krimsonkharne[m] I get the following: 09:24 * krimsonkharne[m] sent a koha code block: https://matrix.org/_matrix/media/v3/download/matrix.org/ISPTuJjJRhkNDaHXrecOfchb 09:24 krimsonkharne[m] oops, too many backticks 09:25 * krimsonkharne[m] sent a koha code block: https://matrix.org/_matrix/media/v3/download/matrix.org/msNIlxVbKPWxgXDIrJiqFpgu 09:27 Joubu krimsonkharne[m]: two solutions, either you remove the node_modules directory from your Koha src root dir 09:27 Joubu or you run `yarn install` to update it 09:28 cait Joubu: but if you can't get into koha-shell? 09:28 Joubu ? 09:28 cait he said he can't start ktd 09:28 Joubu it's there because you run yarn install outside of ktd 09:28 Joubu so yarn install outside of ktd 09:29 cait ah ok, I never tried that (probably good?) 09:29 Joubu remove node_modules :D 09:30 Joubu node_modules is there because you run yarn install at some point, within ktd or outside. But you should not (unless you are testing patches that require it), ktd is dealing with that and embed the up-to-date node_modules 09:30 Joubu in /kohadevbox/node_modules 09:30 Joubu BUT /kohadevbox/koha/node_modules has priority over the ktd's shipped one 09:31 Joubu and this one is created if you MANUALLY run yarn install at some point 09:31 Joubu I have no idea how to make that clear, and put it in a useful place 09:31 Joubu (but I am not gonna repeat it again and again every day :D) 09:35 mtj hi cait, re: multiple instances - i get those errors in the same situation :) 09:36 mtj i make a bunch of temp instances when testing 'koha-create' tool - upgrading always generates errors 09:41 cait Joubu: some kind of FAQ entry maybe on the Readme? 09:42 cait mtj: i was just wondering when reading the mailing list email, but maybe more than one issue there 09:43 cait he debug site (although I really need to put more keywords on that one) for API has proven really helpful 09:45 Joubu reported at https://gitlab.com/koha-community/koha-testing-docker/-/issues/371 09:53 magnuse restart_all in ktd should restart/reload the api too, right? there is no special command? 09:54 Joubu restart_all should be enough 09:54 Joubu `koha-plack --reload kohadev` is actually enough 09:55 magnuse thanks 09:56 magnuse (--restart, not --reload, i think) 09:56 mtj perhaps the 2 'Upgrade Schema Issue' ML emails are from the same people, as they both use 'library' as instance name 09:58 Joubu magnuse: it's --reload, newly added, not sure it's in stable already 09:58 cait it's common, but I had the same ide 09:58 cait a 09:59 magnuse Joubu: ah, ok thanks, i'm on 22.05 here anyway 10:02 Joubu bug 21366 that is in 22.11 10:02 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 enhancement, P5 - low, ---, dcook, RESOLVED FIXED, Add Plack reload 10:19 ashimema do we not set userenv for ils-di loging? 10:19 ashimema s/loging/login/ 10:28 ashimema wow.. 10:28 ashimema is ils-di entirely unauthenticated? 10:31 cait yes 10:31 cait all you can do is limit by IP 10:32 cait which... you really shoudl do 10:32 cait I think that API is internal/trusted use only - supposed to connect to your own discovery or similar 10:33 ashimema mmm 10:33 ashimema bug 33504 is unfixable as far as I can tell 10:33 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 enhancement, P5 - low, ---, koha-bugs, NEW , ILS-DI does not record renewer_id for renewals 10:40 cait yeah 10:40 cait there is no way to tell.... and no borrower representing the API user 10:41 ashimema indeed 10:41 cait well, the modal needs to deal with non-existing data then... I guess? 10:41 ashimema mm 10:41 ashimema that's the conclusion I'm coming to 10:41 ashimema but I hate it ๐ 10:41 cait might also make sense in general, in case of migrated data 10:41 cait hate is such a strong word :) 10:41 ashimema honestly.. I'm actually surprised I let the field be nullable at all 10:41 cait the renewer could be deleted 10:42 cait staff user leaving 10:42 ashimema mm 10:42 cait i think nullable makes sense 10:42 cait or you can<'t have a FK, that's worse 10:42 cait i gues 10:44 paxed HEA lists countries by number of libraries - is there stats for countries by biblios/auths/items/patrons/issues? 10:45 cait if it's not on the website it could maybe be drawn from the database but hasn#t been done 10:46 ashimema merge requests welcome ๐ 10:53 Joubu paxed: https://paste.koha-community.org/4510 10:54 Joubu sum items by coutry 10:56 Joubu sorted - https://paste.koha-community.org/4511 10:56 paxed Joubu: ohh, thanks! 10:57 mtj hi rangi[m], gmcharlt_, can you sort this -> https://www.mail-archive.com/koha-devel@lists.koha-community.org/msg13784.html 11:02 paulderscheid[m] Hi quick question: What do I have to setup for _order_by, _page and _per_page params to work with Koha::Objects within plugins. 11:05 Joubu paulderscheid[m]: the swagger spec 11:06 Joubu search "parameters/order_by" in api/**/*.yaml 11:06 Joubu then you need to use $c->objects->search( $your_rs ) 11:07 Joubu see Koha/REST/V1/ERM/Agreements.pm sub list 11:09 paulderscheid[m] Thanks 11:15 paulderscheid[m] Wow! That was so easy :D 11:16 paxed Joubu: is that HEA query really right? 300 million items for finland doesn't sound correct 11:20 paxed maybe it counts items multiple times (per consortium? branch?) - 30 million would be more believable number 11:22 krimsonkharne[m] Thanks Joubu ! Maybe I'm looking in the wrong place, but in my Koha directory there doesn't seem to be a node_modules directory.. 11:23 krimsonkharne[m] also yarn install gives "bash: yarn: command not found" 11:33 paxed krimsonkharne[m]: are you on debian? 11:33 krimsonkharne[m] yes 11:33 paxed on debian yarn is yarnpkg; easiest way is to symlink that to yarn 11:34 krimsonkharne[m] ah :) 11:34 * paxed got bitten by that recently 11:34 krimsonkharne[m] Thanks! :) 11:37 Joubu krimsonkharne[m]: did you pull new ktd images? 11:38 marcelr hi #koha 11:40 krimsonkharne[m] Joubu: I don't know. Sorry for stupid questions, I've never done anything with ktd or git before :( 11:40 krimsonkharne[m] yesterday I ran git pull, switched to my own branch and then ran restart_all and updatedatabase if that helps? 11:41 Joubu are you inside ktd now? 11:42 krimsonkharne[m] nope, still won't start 11:42 Joubu go to your ktd directory 11:42 Joubu and run `docker-compose pull` 11:42 Joubu go grab a coffee, then try again to start it up 11:43 krimsonkharne[m] OK, Thanks! :) 11:51 Joubu paxed: maybe this one then? https://paste.koha-community.org/4520 11:52 Joubu 11M for Finland? 11:54 Joubu paxed: https://paste.koha-community.org/4526 the different infos, items, biblios, borrowers, old_issues, old_reserves 11:56 cait kidclamp++ 12:04 tcohen hola #koha o/ 12:04 tcohen kidclamp++ 12:04 marcelr hola recovered tcohen 12:04 tcohen hola marcelr! 12:04 tcohen yes! 12:04 marcelr great 12:04 marcelr ready to go again? 12:05 tcohen sure 12:05 tcohen I'll just stick to Pastis this time, no mixing 12:05 marcelr and other viruses 12:08 tcohen yeap 12:08 tcohen Joubu: do you think a WARNING about the existence of node_modules would be enough? 12:09 Joubu yes, a warning and how to fix it 12:09 tcohen has anyone checked the cypress failures? 12:09 tcohen #koha 12:09 Joubu tcohen: I told you yesterday, wait for the other patch 12:10 Joubu https://irc.koha-community.org/koha/2023-04-11#i_2481090 12:10 tcohen sureok, I missed that message 12:25 tcohen Joubu: please later me next time, I think I'm missing messages too often when using znc 12:32 ashimema hmm 12:33 ashimema I thought we'd decided js template literals were OK now? 12:33 magnuse shouldn't this work? "git checkout v22.05.07" in my local koha repo, then "KOHA_IMAGE=22.05 ktd up". the api isn't working and i get this in the logs: Could not load REST API spec bundle: Unable to load schema "file:///kohadevbox/koha/api/v1/swagger/definitions.yaml". at /usr/share/perl5/JSON/Validator/Store.pm line 53. 12:33 ashimema hmm 12:33 ashimema it should work like that yet magnuse 12:33 ashimema sounds like a suspect openapi version or something to me 12:34 magnuse it shouldn't be looking for api/v1/swagger/definitions.yaml i think? because of bug 30194 12:34 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 enhancement, P5 - low, ---, tomascohen, CLOSED FIXED, Update required JSON::Validator version 12:35 krimsonkharne[m] Joubu: Hooray, it worked! Thanks again! 12:36 krimsonkharne[m] btw for me "docker compose pull" worked, "docker-compose pull" didn't 12:36 Joubu yes it's now part of docker, it depends on your version of docker I guess 12:37 krimsonkharne[m] ok 12:37 mtj magnuse: make sure your ktd git repo is on 22.05 branch 12:38 magnuse mtj: it is 12:39 magnuse ah, the stuff i'm testing is doing something icky 12:41 mtj magnuse: try setting koha repo to latest 22.05 tag, and retest 12:41 mtj git checkout v22.05.11 12:43 magnuse sorry, the problem was in our local code (and me not being familiar enough with swagger) 12:44 cait my personal laptop has insomnia :( keeps waking up when suspend it 12:44 cait Joubu: are we still cleaning up old entries in Hea automatically? I know we did it once 12:44 ashimema swagger-cli validate 12:44 ashimema that's a great command to use to check your specs magnuse 12:45 magnuse cool, i'll check that out! 12:46 Joubu cait: IIRC there is a cronjob 12:49 cait ok, so the numbers are just rising and rising :) 12:51 ashimema Joubu 12:51 ashimema changes like bug 33490 12:51 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 normal, P5 - low, ---, jonathan.druart+koha, Signed Off , Agreements - Filter by expired results in error 12:51 ashimema should I be seeing corresponding Cyprus tests for them? 12:51 * ashimema really needs to get closer to more of this 12:51 ashimema the code looks fine to me and works exactly as I expect.. was about to PQA as I have with a bunch of other Vue one's recently.. then wondered about tests 12:52 Joubu tcohen: 33402 - one is left behind 12:53 Joubu tcohen: git mv t/cypress/integration/Searchbar_spec.ts t/cypress/integration/ERM/Searchbar_spec.ts 13:16 caroline Good morning! 13:20 cait hi caroline :) 13:21 caroline cait, did you get an answer from bernardo? 13:24 cait not yet... 13:25 caroline :/ 13:25 cait I'll forward to you, but you are CC too, so I hope he would reply to us both 13:25 cait I am preparing for training and we have manual links everywhere that lead to untranslated manual :( 13:27 caroline That is my life... I don't have time to translate the manual, so all the links are in english. I put more time in our knowledge base 13:28 cait we were at a pretty good state with 18.11... but now with 22.11 ... not 13:35 caroline If anyone is interested in clubs, hammat did a development to see and change answer to enrolment questions bug 25079 13:35 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 enhancement, P5 - low, ---, hammat.wele, Needs Signoff , Show club enrollment question answers in staff client 13:46 marcelr if someone could have a look at bug 33360, how nice would that be :) 13:46 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , SendQueuedMessages: Improve limit behavior and add domain limits 14:04 paulderscheid[m] next meeting? 14:05 cait1 oh right 14:05 cait1 in an hour I think 14:05 cait1 next meetings? 14:05 cait1 no wahanui 14:05 paulderscheid[m] why is this broken? 14:05 paulderscheid[m] Ah 14:05 caroline I was gonna say wahanui is on vacation 14:06 caroline I feel like it's been a while since I've seen them (it? him? her?), are they broken for good? 14:06 tcohen who hosts it? 14:06 thd I had also thought that it was in an hour but the meeting may be set to now. 14:07 caroline In the calendar, it's in a hour 14:08 tcohen can we do it one hour earlier next time? 14:08 tcohen https://wiki.koha-community.org/wiki/Next_IRC_meetings 14:10 thd The time and date converter link is not working correctly for me just now. 14:10 caroline https://wiki.koha-community.org/wiki/Website_Administration I don't see wahaui here, but it says irc is hosted on bugs.k-c.org 14:10 thd It is in an hour as I had expected, the converter link is giving me now. 14:37 caroline probably due to daylight savings nonsense 14:39 Dyrcona I had a look. The converters says EST for me. My current timezone is EDT. So the time zone converter is ignoring daylight savings time. 14:42 caroline Daylight savings time, confusing the heck out of everyone since 1908! 14:42 tcohen we should abolish timezones as well 14:43 Dyrcona I'd rather stay on standard time, but most surveys indicate that people prefer going to daylight savings time in the USA. 14:43 Dyrcona UTC FTW! 14:45 tcohen we could also change the meaning of a second of time to avoid the leap year non-sense 14:45 marcelr got a nice daylight saving time test thing on 33360 btw 14:45 caroline In that case, could we go to a base-10 system? 14:46 tcohen bug 33360 14:46 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , SendQueuedMessages: Improve limit behavior and add domain limits 14:46 tcohen huginn: ? 14:46 huginn tcohen: I'll give you the answer as soon as RDA is ready 14:46 caroline lol marcelr! 14:46 marcelr when doing a search back and i hit an unexisting hour 14:46 marcelr in my timezone 14:46 caroline here's a better one with DST bug 32232 14:46 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 enhancement, P5 - low, ---, koha-bugs, NEW , Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 14:47 marcelr nice 14:47 tcohen nice one 14:47 Joubu this was a bug in DateTime, that I think was fixed... 14:48 Joubu it was Sao Paulo at the time.. 14:48 Joubu bug 23079 14:48 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 major, P5 - low, ---, jonathan.druart+koha, CLOSED FIXED, Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) 14:48 marcelr cool 14:49 Joubu we fixed it koha-side, see the floating calculation from 23079 14:49 caroline Joubu, are you talking about mine or marcelr's? Mine broke between 21.05 and 22.05 (21.05 was fine, 22.05 error) 14:50 Joubu caroline: yours, it's a DateTime issue, not really us. 14:51 Joubu The solution is on 23079 (at least the way of fixing it, that needs to be adjusted for the method playing with datetime calculation n 32232) 14:51 caroline ok thanks, I will pass on the info 14:51 caroline I knew it was something outside of Koha, but I thought we could maybe not use the time in dateofbirth or something 14:52 Joubu the "floating" calculation is basically telling to not care about tz, what we want here 14:54 caroline Joubu++ 14:56 marcelr yeah, these things can popup anywhere when adding to dates in searches etc. (just like I had on 33360) 14:58 marcelr cu 15:01 Joubu tcohen: 33408 did you see the previous comment? 15:03 Joubu @later tell tcohen 33408 did you see the previous comment? 15:03 huginn Joubu: The operation succeeded. 15:03 tcohen Joubu: are they ok now? 15:03 Joubu I think so, we discussed it recently but I don't remember when/where 15:04 tcohen so no one got assigned the task of removing the QA check? 15:04 Joubu I didn't find an issue either 15:10 ashimema I was going to raise that 15:10 ashimema whenever the meeting it 15:11 emlam I think it's supposed to be now, actually... 15:11 emlam https://wiki.koha-community.org/wiki/Development_IRC_meeting_12_April_2023 15:12 tcohen hi, I cannot host it 15:13 emlam tuxayo around? 15:13 reiveune bye 15:40 thd tuxayo: Are you chairing the meeting? Does the meeting need to be set to an hour earlier for local time changes? 15:43 cait1 hm so now I missed the meeting? 15:43 thd cait1: No 15:44 thd cait1: Perhaps you could call the meeting and chair. 15:44 cait1 not too keen on it tbh, I need to finish something here and the day is almost over 15:45 thd The change in local time may not be working well. It may be better to have meetings set an hour earlier for the change in local time. 16:00 cait1 does someone have a moment to test isbn search in item search? 16:00 cait1 this puzzles me 16:01 cait1 we are searching for an existing isbn that is stored in biblioitems truncated (there are 2 isbn on the record) %isbn% 16:01 cait1 nothing comes up 16:04 cait1 callnumber works 16:04 cait1 and it works in 22.11.03 but not in 22.11.04 16:04 caroline I don't have a problem with ISBN in Item search 16:04 caroline (in master) 16:04 caroline Oh wait, two isbn, let me edit my record 16:06 caroline No I still get the search result with two ISBN in the record 16:06 cait1 I wonder if it could somehow be configuration specific 16:06 cait1 but they map 020$a to biblioitems.isbn... and the field is filled in the db too 16:06 cait1 and it worked pre-update 16:07 caroline In the db, my isbn field is 9781903436950 | 111222333 16:07 caroline when I search for %9781903436950% in item search it's found 16:08 caroline do I do something different? 16:08 cait1 no :( 16:08 cait1 that's exactly what I expect, but it's nto working here 16:09 cait1 the record isin the catalog, it has items 16:10 cait1 thx for trying to help caroline 16:10 caroline does it find anything at all or just not the one you're looking for? 16:11 cait1 nothing 16:11 caroline and with other fields? 16:11 cait1 callnumber works 16:12 caroline something not in items? 16:12 caroline Like author or something? 16:12 cait1 yes, had the same idea, sec 16:14 caroline exact search when there is only one isbn? 16:14 cait1 sutck with processing and no response from server 16:14 caroline oops 16:14 cait1 for a title search in a specificlibrary 16:15 caroline do the logs give you any clue? 16:16 cait1 no access to the logs on this machine 16:17 cait1 I just called, they are looking into it 16:17 tcohen is anyone available for the dev meeting? 16:17 cait1 I'd be here I guess - waiting for the server to come back (we shoudl be able to do bad things with item search) 16:21 paulderscheid[m] I'm here 16:50 paulderscheid[m] Should we at least postpone the meeting? 16:51 paulderscheid[m] Or do we have the permissions issue again? 17:01 paulderscheid[m] Can I ask you a quick question @tcohen> 17:02 paulderscheid[m] * Can I ask you something real quick tcohen 17:02 cait i don't know how to runt he script yet 17:02 cait maybe we need to resolve that tomorrow 17:05 paulderscheid[m] You there Pedro Amorim ? 17:06 PedroAmorim[m] yes 17:08 paulderscheid[m] I have a Koha::Object where I want to filter the resultset and then pass to $c->objects->search. 17:08 paulderscheid[m] How do I have to format the conditions? 17:08 paulderscheid[m] Like... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/gDhKRfCKeLTaqGwUPVBrZjZn>) 17:09 paulderscheid[m] Before you ask: I want the $c->objects->search mainly for support of _page, _per_page but the handling of the query params within the second call seems to make a mess. 17:18 PedroAmorim[m] when you say "how to format the conditions" you're asking how $search_params should look like? 17:18 PedroAmorim[m] this may be a good reference: 17:18 PedroAmorim[m] https://metacpan.org/pod/SQL::Abstract::Classic#Specific-comparison-operators 17:18 PedroAmorim[m] what query exactly are you trying to do 17:19 paulderscheid[m] Yeah, I was looking at these docs.... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/mkPrchoiAISCAQyytaINkRfZ>) 17:20 paulderscheid[m] They are added conditionally based on whether they're actually passed. 17:23 paulderscheid[m] And I wanted to reuse that because my frontend components are geared towards plain query params atm 17:25 PedroAmorim[m] this is how I built a query with ternary: 17:25 PedroAmorim[m] https://github.com/Koha-Community/Koha/blob/master/Koha/REST/V1/Illrequests.pm#L65 17:25 PedroAmorim[m] does that help? there are other examples in the code but this is the one on top of my head 17:27 PedroAmorim[m] more cool examples here: 17:27 PedroAmorim[m] https://github.com/Koha-Community/Koha/blob/master/Koha/ERM/Documents.pm 17:28 PedroAmorim[m] sorry if I didn't understand your question fully, others may be of much better help than me! (i have no idea what I'm doing really) and it's been a long day! :D 17:29 paulderscheid[m] Thanks so much! Sorry for sneaking up on you ^^ 17:29 paulderscheid[m] I'm looking at them right now. Maybe I'll find something in there. 17:36 paulderscheid[m] I think the problem is actually the $c->objects->search call 17:36 paulderscheid[m] Without it everything works as expected. 17:37 tcohen paulderscheid[m]: $c->objects->search does more than pagination 17:37 paulderscheid[m] Yeah, I know 17:37 tcohen it also sets some headers that are required for the datatables wrapper 17:37 paulderscheid[m] I'm trying to grasp what it does 17:37 tcohen so, what you might want to do 17:37 tcohen is fill the missing request params 17:38 tcohen what is the query you're trying to build? 17:38 paulderscheid[m] > <@paulderscheid:matrix.org> Yeah, I was looking at these docs.... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/TDlWfWhXLYeyaoMPbgnOzxmC>) 17:39 tcohen Here you can find the helper definition: Koha::REST::Plugin::Objects 17:39 tcohen It basically uses the helpers from Koha::REST::Plugin::Query 17:39 paulderscheid[m] I already read it, but I think I misunderstood how it works 17:39 tcohen to extract reserved stuffs from the original request query params 17:40 tcohen we can have a call whenever you want 17:40 tcohen and we talk about it 17:40 tcohen do you know what a 'resultset' is? 17:40 paulderscheid[m] Yeah, I read the docs 17:40 tcohen so it is not the results from a DB query 17:41 tcohen but an object representing a query, sort of 17:41 tcohen and every time you call ->search 17:41 tcohen it generates a new resultset object 17:41 tcohen stacking queries one on top of the other 17:41 tcohen so $thing->search(รง) 17:42 tcohen $things->search({ param => [1,2] })->search({ param => 2 }) will return a new resultset 17:43 tcohen so what I think Pedro was saying is 17:43 tcohen that you can 'build a resultset' in the controller, and pass it to $c->objects->search 17:43 tcohen but in order for things to work for your case, you might need to actually 17:44 tcohen do things like $c->req->param( 'q', encode_json({ param => [1,2] }) ) 17:45 paulderscheid[m] Ah, that's a new angle 17:45 tcohen I'm not saying it is required 17:45 tcohen but it is a POV 17:45 paulderscheid[m] Thanks for clearing that up for me 17:45 paulderscheid[m] I kind of understood how it works before but that really helped 17:45 tcohen excellent 17:46 tcohen hope I didn't mess your understanding heh 17:46 paulderscheid[m] Nah 17:47 tcohen another example 17:47 tcohen https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/REST/V1/Checkouts.pm#L53 17:49 paulderscheid[m] Wait, I think I just got something important!... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/JsxqaRIeGGriCIlNcWjdkmEh>) 17:49 paulderscheid[m] Or is this unrelated? 17:50 tcohen that's important 17:51 paulderscheid[m] The search call on $c->objects->search uses the query params itself, does it? 17:51 tcohen what we do there, is assess the fact not-reserved query parameters will be passed as 'filters' to the query 17:51 tcohen so GET /patrons?patron_id=123 17:51 tcohen will imply a Koha::Patrons->search({ patron_id => 123 }) 17:52 paulderscheid[m] That's exactly the problem that I have! 17:52 tcohen so the trick there, is to pick the 'know-by-the-controller' parameter, remove it from the query, use it to prepare the resultset, and continue 17:53 paulderscheid[m] Thank you so much! That's it! 17:53 paulderscheid[m] That was the behaviour I encountered, but I didn't fully understand why it was occuring. 17:54 paulderscheid[m] I owe you one. tcohen++ 18:05 paulderscheid[m] Works like a charm now! :D Thanks again Pedro Amorim & tcohen 18:11 paulderscheid[m] Maybe we can have a call when I advanced a little on my scaffolding thing tcohen. I have so many things to ask ^^ 18:11 paulderscheid[m] Have a nice evening y'all o/ 18:33 tcohen \o 18:39 cait hm my ktd won't start :( 18:39 cait koha-db-1 | 2023-04-12 18:39:18+00:00 [Note] [Entrypoint]: Entrypoint script for MariaDB Server 1:10.5.19+maria~ubu2004 started. 18:39 cait Error response from daemon: network 925aa9f4d6d5c79a156c691fa8f9389569111ac0fa87fe8de4fd1c4b3f59f7aa not found 18:47 davidnz my KTD starts (but I had done git pulls for koha and ktd, and a ktd pull) - maybe disk space issue? 18:51 tcohen cait: it must be something local 18:51 tcohen ktd down a couple times 18:51 tcohen maybe a ktd pull too? 19:51 cait tcohen: i just did a git pull and a ktd pull before running into that... 19:52 cait looking better without --selenium 19:54 cait ... so not me looking into the test failures tonight 20:03 * cait patches bug 33509 instead 20:03 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 minor, P5 - low, ---, katrin.fischer, Needs Signoff , Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings 21:17 cait woudl be really nice if someone could take a look at bug 33506 and 33506 21:17 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 normal, P5 - low, ---, katrin.fischer, Needs Signoff , Series has wrong index name on scan index page and search option selection is not retained 21:17 cait bug 33506 21:18 cait bug 33505 21:18 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 minor, P5 - low, ---, katrin.fischer, Needs Signoff , Improve styling of scan index page 22:01 caroline Does someone know what I have to activate in order to see the item_priority column in the holdings table of the OPAC? 22:01 caroline I tried choosing priority in OPACShowHoldQueueDetails, but it just shows in the item_holds column with the number of holds, not in the item_priority column 22:02 caroline https://snipboard.io/8LDr5R.jpg 22:03 caroline this is the column I'm looking for https://snipboard.io/5cF39K.jpg 22:04 cait hm 22:04 cait i think the priority might only show in the patron account 22:04 cait not in the opac 22:04 cait oh 22:05 caroline It does show if you're logged in, but in the same column as the holds 22:05 cait trying something 22:07 cait [% IF holds_count.defined %] 22:07 cait <th id="item_holds" data-colname="item_holds">Item holds</th> 22:07 cait [% ELSIF show_priority %] 22:08 cait <th id="item_priority" data-colname="item_priority">Item hold queue priority</th> 22:08 cait [% END %] 22:08 cait I am not sure if that makes sense 22:09 caroline I tried reading that part, but don't know TT well enough to understand if I understand ;) 22:09 cait when there are holds... the column never shows? but if there are no holds... hter eis no need for priority.. 22:09 cait I thin it never gets into the ELSE 22:09 cait becuase holds_count is always defined 22:10 caroline I can file a bug tomorrow. I just wanted to make sure that it was not something completely unrelated to holds that I was missing 22:11 cait yeah i think there is a bug 22:11 cait defined should be count 22:12 cait it's always defined, but not always more than 1 22:20 cait i think i have osmething like a patch if you file now 22:22 cait hm but maybe better to check that in daylight :) 22:22 cait bye all 23:39 aleisha hello all, does anyone do sso and user provisioning with shibboleth for multiple IDPs? weve found some stuff on an embedded discovery service, just want to check we're on the right track