Time Nick Message 05:47 dcook bug 33189 05:47 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33189 enhancement, P5 - low, ---, dcook, Needs Signoff , Plugin upload should prompt for .kpz files 05:47 dcook For anyone wanting the easiest signoff around :D 08:36 ashimema AutoEmailPrimaryAddress is such a messy and confusing preference 08:45 cait hm you are possibly right about that 09:18 ashimema I've just submitted a bug for the preference options not matching the patron field labels 09:18 ashimema which is confusing 09:19 ashimema but I also find the overall functionality of the pref odd.. 09:19 cait I think there is also a bundle of bugs saying that the pref is not taken into account 09:19 ashimema it's very easy to shoot yourself in the foot and set it to an often not filled field and then that just disables emails 09:19 ashimema and it's confusing what it applies to.. 09:19 ashimema and also confusing how it may or may not interact with patron messaging preferences. 09:19 ashimema it's a mess 09:20 ashimema well.. to me.. it should ONLY work against the AutoEmailOpacUser driven notices 09:20 ashimema not all the others.. for all the other notices I think it should be the patron messaging preferences 09:20 ashimema anywho.. 09:25 ashimema I just solved a really old support call where it wasn't code at all.. it was the customer shooting themselves in the foot by changing that pref to a field they never set 09:25 cait I don't think that#s the same thing 09:25 cait the patron messaging preferences say what notice shoudl be sent and how (email) 09:25 cait but nto whichemail to use 09:25 cait there isa need for defining which email Koha shoudl use from the many we have 09:26 cait and I think it should be degrouped from AutoEmailNewUser 09:26 cait it never only applied to this one or hasn't for years at least 09:36 ashimema hmm, ok 09:36 ashimema well.. whatever.. it certainly needs clarifying 09:46 cait agreed 10:14 davidnind @later tell thd Could you please look at the Wiki account for user Emlam - they requested an account in October and we think it was confirmed, but they can't log in or do a password reset (see IRC discussion from about https://irc.koha-community.org/koha/2023-03-09#i_2476891). I don't have permissions for doing that. Thanks! 10:14 huginn davidnind: The operation succeeded. 10:55 ashimema bug 29046 would be nice cait 10:55 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Allow libraries to specify email order for "AutoEmailPrimaryAddress" 11:02 ashimema bug 33191 would alos be nice for someone looking for a simple patch to write 11:02 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 enhancement, P5 - low, ---, koha-bugs, NEW , AutoEmailPrimaryAddress options don't match labels in memberentry 11:03 ashimema or bug 33192 11:03 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 enhancement, P5 - low, ---, koha-bugs, NEW , We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification 11:44 tcohen should wehola #koha o/ 13:58 caroline good morning! 13:58 cait good morning caroline :) 14:02 cait hm i need to reinstall gulp-cssnano it looks like, to be able to update translation scripts in 22.11 14:04 cait gulp po:update - is this something to report or just something that is depending on versions? 14:07 cait any ideas welcome... i need to refresh po files so we can update 14:08 cait ok, sorry - it needed a yarn install - looking good now. phew. 14:22 caroline cait, so we have to do yarn install before gulp po update now? 14:51 cait i am not completely sure yet if it's only my setup or general... 14:52 cait but if you get an error when you try... maybe first try that to fix? 15:19 caroline ashimema, re bug 33191, did you want me to specify which option is which field? 15:19 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 enhancement, P5 - low, ---, koha-bugs, NEW , AutoEmailPrimaryAddress options don't match labels in memberentry 16:49 ashimema well.. 16:50 ashimema the issue I have is that the options given don't match anything else in koha as far as I'm aware 16:50 ashimema they're not the db field names 16:50 ashimema but they're also not matched to the form labels in the memberentry forms 16:51 ashimema so it's hard to know 'work' => emailpro => Secondary email 16:51 ashimema for example 16:51 ashimema so some clarity somehow would be good.. 16:51 ashimema of course... I'm not sure how that would play into translations? 17:01 caroline ashimema, the sysprefs options are translated by themselves, so I think translators would just have to be consistent 17:03 cait maybe we could/should use the same terms than the modal for borrowers fields has? 17:03 cait if we make the strings match, only one translation too :) 17:41 ashimema Agreed 19:29 caroline Not sure there will be only one translation even if the strings match... in prefs the msgid contains the pref name, so each value is translated separately 20:16 astyles Hi Everyone, I am having issues submitting a patch, I am at the stage where I use git bz command to add patch via 'git bz attach 33190 HEAD' when doing so I get error ...'-bash: /usr/local/bin/git-bz: /usr/bin/python2: bad interpreter: No such file or directory' any thoughts? thanks so much. 8-) 20:21 astyles for some context, I am attempting to add patch this feature I am introducting for review https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 8-) 20:21 huginn 04Bug 33190: enhancement, P5 - low, ---, adam.styles, NEW , Add search history button to advance search form if EnableSearchHistory keep 20:24 emlam astyles - Do you have Python 2 installed and up to date on your machine? 20:27 emlam alternatively, what operating system are you working in, and are you trying to submit from inside a koha testing docker shell? 20:28 astyles Hi, I have default python 3 installed on docker linux box, I am ssh into linux vm with docker installed. 20:29 astyles I am using koha-testing-docker 20:30 astyles ran command again " $ git bz attach 33190 HEAD 20:30 astyles fatal: 'bz' appears to be a git command, but we were not 20:30 astyles able to execute it. Maybe git-bz is broken? 20:30 astyles " 20:32 caroline I just attached a patch less than 5 minutes ago, so git bz works... 20:33 astyles I suspect my issue is a clear case of user error lol 20:33 caroline is the git bz configuration ok? 20:33 caroline https://wiki.koha-community.org/wiki/Git_bz_configuration#Configure_git-bz 20:33 astyles I based it off commands in docs https://wiki.koha-community.org/wiki/Git_bz_configuration 20:35 caroline In the "known problems" section of that page, I see your same error (in French "mauvais interpreteur") 20:39 astyles Hi all, it was user error, I did not have python 2 installed. thanks for all the help. my first patch attached! 20:39 caroline woot! 20:39 caroline astyles++ 20:39 astyles I will make a note of this in local docs 20:39 astyles woop woop 20:39 ashimema Hi 20:40 caroline Now you need to change the bug status 20:40 ashimema astyles, there's also a python 3 branch in testing, you could try that if you didn't want to use python 2 20:40 ashimema I've been using the python 3 branch for months without issue personally 20:41 caroline its good to know 20:41 ashimema https://gitlab.com/koha-community/git-bz/-/tree/git-bz-python3_adaptation 20:42 caroline is it in the "Download git bz" part that we should change it? 20:42 ashimema That one 20:42 astyles Hi Caroline, which status do I now switch to? 20:42 caroline https://wiki.koha-community.org/wiki/Git_bz_configuration#Download_git-bz 20:42 caroline astyles, Needs Signoff 20:42 ashimema It should be as simple as following the usual instructions but check out that branch instead of the default apply_on_cascade 20:42 astyles awesome thanks 20:42 ashimema Cascade still works too btw 20:42 caroline you can also do it while attaching git bz attach -e xxxxx HEAD 20:42 caroline the -e will bring you to the editor 20:43 caroline and you uncomment the Status: Needs Signoff line 20:44 astyles ah cool, good to know, I will do so for my next one from command line. 8-) 20:45 ashimema Welcome aboard astyles :-) 20:46 astyles 8-) 20:46 caroline astyles, if you have access to the wiki, you could maybe change the error in the wiki page to the english one? Maybe that would make it easier to find if someone searches for the error message 20:48 astyles 8-) 20:53 astyles Thanks for all the help, I am now super pumped to find things to patch and test. thanks 8-) 20:53 astyles ltr 20:53 ashimema We should certainly clean up that page a bit.. I can't see any reason someone would want to use the fishsoup branch now.. I think we should just drop mention of that as it's misleading/confusing 20:53 * ashimema gets his editing hat on 20:53 ashimema Though it's hard from mobile 📱 20:54 ashimema Awesome 20:54 ashimema Do you know about the academy keyword in bugzilla.. we use it to highlight good starter bugs.. some very easy some slightly more involved, but nothing too hard 21:04 emlam Ooh, I didn't know about the academy keyword...it would be awesome if that was in one of the "getting started" wiki pages 21:52 caroline lucyvh++