Time Nick Message 23:00 oleonard-away cait: I am technically still around :) 21:59 caroline tcohen, I'm sure we can volunteer hammat to work on either of those if you need help and can delegate 21:56 cait i just relaized we need the changes for the send shelf also for the send cart... 21:55 huginn caroline: The operation succeeded. 21:55 caroline @later tell tcohen any news on the API front for the list endpoint and ccl query? 21:53 cait ooh i see 21:53 cait oleonard-away: still around? 20:00 oleonard-away Patch sent 19:33 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 normal, P5 - low, ---, koha-bugs, ASSIGNED , Error in package.json's definition of css:build vs css:build:prod 19:33 davidnind tcohen: bug 32975 19:30 tcohen oleonard-away: have you filed a bug for that? 19:29 tcohen khall++ 18:11 oleonard should be "css:build:prod": "gulp build && gulp build --view opac", 18:11 oleonard "css:build:prod": "gulp build && gulp css --view opac", 18:11 oleonard tcohen: I was confused about how it worked because there's a bug in package.json 17:58 tcohen yeah, sorry 17:55 oleonard Oh I get it, it's passing the --view option "in the background" 17:51 oleonard tcohen: But we build rtl versions of the OPAC CSS but not the staff interface's. 17:47 tcohen https://git.koha-community.org/Koha-community/Koha/src/branch/master/package.json#L43-L50 17:45 tcohen so you always need to build both 17:45 tcohen and it makes sense, because the source code now doesn't ship compiled assets 17:45 tcohen there's no opac-specific task in yarn 17:33 oleonard I don't understand how the build process handles the opac-specific parts of gulpfile.js now 17:21 oleonard Joubu still around? 17:21 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 enhancement, P5 - low, ---, nick, CLOSED FIXED, C4::Auth->haspermission should allow checking for more than one subpermission 17:21 PedroAmorim[m] is bug 22031 the one? 17:18 tcohen \o/ 17:18 PedroAmorim[m] aye that's the plan tyvm 17:17 tcohen so it might be a matter of defining the new permissions schema (32968) and then tweaking the API spec 17:17 tcohen exactly 17:17 ashimema I vaguely remember making it accept an SQL::abstract like sybtax 17:17 ashimema Oh yeah, I did 17:15 tcohen ashimema is responsible for a change in the permissions check logic, I think, that allows to pass some structure, that accepts an OR 17:14 tcohen acquisitions_X or ERM_create_Y 17:14 tcohen something along the lines of 17:14 tcohen in the spec 17:14 tcohen PedroAmorim[m]: I'm pretty sure... we could come up with a more complex permission schema 17:13 PedroAmorim[m] problem is ERM is requesting acquisitions/vendor endpoint, which requires a different set of permissions (acquisition) 17:11 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 enhancement, P5 - low, ---, jonathan.druart+koha, NEW , Create granular permissions for ERM 17:11 PedroAmorim[m] I am working on that, bug 32968 17:10 tcohen I cannot read it right now, but my first guess would be we need ERM-specific permissions 17:07 PedroAmorim[m] tl;dr ERM requires a sub-permission from acquisition in order to be properly accessible 17:06 PedroAmorim[m] discussed 32971 with Joubu but he sent me your way! any ideas on how to best approach this? 17:05 tcohen PedroAmorim[m]: yes 16:58 ashimema did we document anywhere the new command to run all tests in ktd? 16:43 cait time to cook dinner - bye all 16:42 PedroAmorim[m] tcohen: around? 16:02 reiveune bye 15:49 paulderscheid[m] Maybe :D 15:48 cait paulderscheid[m]: are you going to say that every day now? :) 15:38 oleonard I'm not stopping anyone ;) 15:32 paulderscheid[m] Friendly reminder that we have to get rid of node-sass :D 15:18 cait it looks like the fix was to change the plugin .js file, but not sure if we can do it like that? 15:17 caroline In any case, I will add the warning to the manual 15:17 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32447 minor, P5 - low, ---, a.roussos, ASSIGNED , In items table barcode column can not be filtered 15:17 cait oleonard: coudl you have al ook at bug 32447 maybe? 15:17 cait i think there is a bug about the publication date 15:16 caroline maybe we could add a warning that if the publication date is left empty, the content will not be displayed? 15:16 caroline I guess it can be useful to not have something displayed if you're still working on it, but don't want to set a definitive date in the future 15:03 caroline So is this something that we want? If we don't put a date, the thing is not published at all. Might be confusing for existing users 15:01 caroline that might be the difference 15:01 caroline I purposely left it empty, and they are all set to today (in 22.05) 15:01 caroline it fills it out for you 15:01 caroline oh wait no 15:00 oleonard :/ 15:00 caroline In 22.05, you can leave the date empty and it considers it published, but it seems that changed 15:00 caroline mine didn't (one did and the other no) 14:59 oleonard yes 14:59 caroline I think I found it, oleonard do yours have publication dates? 14:58 caroline that's good if it's just me then 14:57 oleonard-away it seems to be working for me in master 14:56 caroline no, I selected "All libraries" 14:55 oleonard-away caroline: Is it only with library-specific content? 14:44 caroline I just tried it in 22.05 and it works... I tried with OpacMainUserBlock and OpacNavRight so far 14:43 cait is there a specific one where you want to do mulitple? 14:43 cait not sure if it was possible before - we used to only have one system preference 14:38 caroline Is this deliberate or a regression? 14:36 caroline Is it not possible anymore to have more than one html customization per location? 14:19 cait davidnind++ caroline++ oleonard++ 14:16 caroline davidnind++ 14:03 cait oleonard-away: the QA manager forgot to runt he QA script... I think you are save today :) 13:48 oleonard Sometimes I'm just sure that someone is going to point out that I've had a very dumb idea, even late in the QA process. 13:46 ashimema π 13:39 oleonard Oh yay, multiple breadcrumb wrapper patches will be on the way 13:37 tcohen mtj: please look at https://gitlab.com/koha-community/koha-dpkg-docker 13:31 cait a mostly positive stare then.. ok 13:29 tcohen cait: I really value those who care about translatability, a lot 13:29 * cait feels uncomfortable with tcohen staring at her 13:27 cait2 tcohen: was that a compliment even tho I made the QA tools fail? 13:27 Joubu mtj: I am seeing this weird apache error "Syntax error on line 115". I added some debug in the same output, you can see the content of /etc/apache2/apache2.conf and /etc/apache2/envvars that seem correct 13:26 Joubu mtj: any ideas about what's hapenning there? - https://gitlab.com/joubu/test/-/jobs/3729566750 The context is: I am trying to have a gitlab-ci that would be in Koha src, that would run the test suite when something is pushed. 13:13 Joubu maybe not course-details.t 13:13 tcohen thanks JOubu 13:12 Joubu there are very few occurrences, it's easy to notice 13:12 tcohen yeah, this deserves a cleanup 13:12 Joubu looks like the parameter we pass is always a Koha::Item 13:11 tcohen you mean rewriting that bits 13:11 Joubu well, should be adjust to new requirements then :D 13:11 tcohen I'll approach khall and ask for fixing it 13:11 tcohen ok, thanks for letting me know 13:10 Joubu the failure is because of can_edit_item that raise false and "not_same_branch" is blocking the deletion of the item when the order is cancelled 13:10 tcohen well, code written a lot of time ago and pushed recently 13:10 tcohen the Acquisitions/Order.t 13:10 Joubu it's not old code, it's new code 13:10 tcohen are you saying the tests failure is because of that? 13:10 tcohen but 13:09 tcohen Joubu: I see that you don't like the old code that pretends to be backwards compatible to avoid breakages 12:58 wahanui really is, like, out of date on how our jenkins workflow all fits together these days 12:58 Joubu really?! 12:58 Joubu 1534 : undef; 12:58 Joubu 1533 : $ref eq q{} ? $item 12:58 Joubu 1532 : $ref eq 'HASH' ? $item->{homebranch} 12:58 Joubu 1531 $ref eq 'Koha::Item' ? $item->homebranch 12:57 Joubu tcohen: 1530 my $branchcode = 12:56 oleonard Specifically, if we pull Fontawesome SCSS from node_modules... 12:56 Joubu safe_to_delete: 299 and !Koha::Patrons->find( C4::Context->userenv->{number} )->can_edit_item( $self ); 12:56 Joubu it's because of the can_edit_item feature 12:54 Joubu is it a new failure? 12:54 oleonard So even if we pull Fontawesome SCSS in for the CSS build, we still need a copy of the font files in a web-accessible directory, eh? 12:40 tcohen https://jenkins.koha-community.org/job/Koha_Master_D10/lastCompletedBuild/testReport/(root)/t_db_dependent_Koha_Acquisition_Order_t/cancel___tests__265_/ 12:39 Joubu it's not in master 12:39 wahanui i heard that was me or mtj and I. 12:39 Joubu where that? 12:35 tcohen can anyone help with the random failure on t/db_dependent/Koha/Acquisitions/Order.t cancel() tests 12:30 tcohen Yes, it is the QA script highlighting it 12:29 Joubu The QA test and jenkins will catch it if you forget it ;) 12:28 tcohen yeah, I felt the same when looking at this. Better set it explicitly 12:27 Joubu the idea is: always have a filter. If you don't want one, use $raw explicitely. There is no specific rule for KohaSpan in t/lib/QA/TemplateFilters.pm and so [% var | $KohaSpan %] is not allowed 12:26 tcohen doing 12:26 tcohen ok thanks 12:26 Joubu yes 12:26 tcohen should we explicitly add $raw? 12:26 wahanui darn tootin' it is. 12:26 ashimema excellent 12:26 Joubu it's caught already if you don't add another filter 12:26 tcohen <span>Add values to the [% av_UPLOAD_link | $KohaSpan %] 12:26 tcohen [% av_UPLOAD_link = BLOCK %]<a href='/cgi-bin/koha/admin/authorised_values.pl?searchfield=UPLOAD'>UPLOAD</a>[% END %] 12:26 Joubu missing_filter at line 18 ([% variable | $KohaSpan %]) 12:25 tcohen shuold this case use | $raw | $KohaSpan? 12:24 ashimema a quick grep suggests we're using it correctly so far 12:24 ashimema do we have a qa script test for that 12:24 Joubu where filter is raw or html, etc. 12:24 Joubu the usage is [% variable | filter | KohaSpan %] 12:23 Joubu koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_hold_cancel.inc for instance 12:23 Joubu this is expected, you are supposed to filter before. Or you won't be able to use it correcty in the different places we are using it 12:20 oleonard If you reverse the filters ($KohaSpan, then html) it encodes things badly? 12:20 tcohen this case doesn't need it, as we are actually passing a hardcoded structure in a variable 12:20 oleonard Doing it implicitly seems logical 12:19 ashimema yeah.. that's a solid question 12:19 ashimema ho.. it's not one I was deeply involved in 12:19 tcohen I'm not sure it is shouldn't do it implicitly 12:19 tcohen oleonard, ashimema I don't like that the $KohaSpan filter actually puts the passed variable as-is inside a span... so no HTML escaping 12:18 tcohen khall++ 12:16 ashimema oleonard++ 12:16 oleonard in library_groups.tt 12:16 ashimema there's lots of examples now I look a bit harder 12:16 oleonard [% added.library.branchname | html | $KohaSpan class = 'name' %] 12:15 oleonard holds_table.inc 12:15 ashimema ha, thanks oleonard 12:15 oleonard <td>[% hold.notes | html | html_line_break %]</td> 12:14 * ashimema tries to find an example 12:14 tcohen ok 12:13 tcohen [% av_UPLOAD_link | $KohaSpan %] 12:13 ashimema I believe that can 12:13 tcohen ashimema: do you know if several filters can be passed in TT? 12:12 tcohen Joubu: around? 12:10 tcohen cait++ 12:09 tcohen you've been excelling on finding the little issues so far 12:09 * tcohen stares at cait 12:08 ashimema π 12:08 * tcohen looks at backportable fixes 12:08 ashimema indeed.. my chaps will likely announce later today 12:08 ashimema πΏ 12:08 tcohen almost string freeze 12:07 tcohen haha 12:07 tcohen hey ashimema, do I know you? 12:06 * ashimema smiles 12:05 tcohen hi oleonard cait cait2 Joubu 12:02 * cait waves 12:01 oleonard_ Hi all 11:41 JobTroubleChris Too much computer for me today, so going to head out. Thanks again! 11:38 tcohen hola #koha 11:38 perplexedtheta No trouble - glad to have been of assistance! 11:26 JobTroubleChris Thanks so much for your help, you've saved me countless hours of stress and headaches. 11:26 JobTroubleChris And worked... 11:26 JobTroubleChris And after a trip to Africa to rebuild a zebra, it looks like it's working! 11:21 JobTroubleChris Oh, it looks like it did something! 11:20 JobTroubleChris Will let you know if it worked momentarily. 11:19 JobTroubleChris Alright, I worked through all that and am restarting now... 11:18 * perplexedtheta agrees. It works much better now in 22.1102 11:17 Joubu we fixed several problems with the worker, some more fixes are coming 11:15 perplexedtheta Once you've done that dance, the job should run. If it en't playing nice, a reboot of the server could be a good idea (assuming this system isn't production yet) 11:15 perplexedtheta Then, restart memcached.service & (sudo koha-plack --restart <sitecode), if you've got Plack running. Lastly, restart the worker (sudo koha-worker --stop <sitecode> && sleep 1s && sudo koha-worker --start <sitecode>) 11:14 JobTroubleChris Thank you for that, let's see what happens! 11:13 perplexedtheta sudo systemctl disable --now rabbitmq-server.service && sudo systemctl stop rabbitmq-server.service 11:12 perplexedtheta Ubuntu 22.04 works nicely. The MARC import process is a bit troublesome, RabbitMQ is a sort of "optional but recommended" dependency. It runs jobs asynchronously rather than polling the DB all the time - but if your usage is small, stopping RabbitMQ will make your life easier. 11:11 JobTroubleChris Ubuntu 22.04.1 - I was able to install, get in, and start setting things up, but when it came time to convert and import an Excel file, I ended up here 11:09 perplexedtheta Are you using a Debian machine? If so, you can use the Koha APT repositories for an easy installation route 11:08 JobTroubleChris I'm hardly literate with terminal/console commands, but I can, apparently, follow instructions better than the guy who was supposed to set it up, haha. 11:07 JobTroubleChris Oh, okay. Let me see what version I have. I struggled through the install last night, so I hope it's recent! 11:07 perplexedtheta RabbitMQ seems to cause more trouble than its worth - stopping it helps a lot 11:07 perplexedtheta No - upgrading Koha. 11:07 JobTroubleChris upgrading RabbitMQ? 11:06 perplexedtheta I just had this issue on a 22.1101 system. I found disabling and stopping RabbitMQ, then upgrading to 22.1102 resolved the issue. 11:05 JobTroubleChris Hello! I'm having some troubles with trying to import marc records... I've gone through the process, but it does not seem to actually queue the job? And saying the Job Progress is null/0? I also can't seem to cancel them... 09:15 ashimema morning 09:14 wahanui salut, PedroAmorim[m] 09:14 PedroAmorim[m] hi 09:00 wahanui bidet, lds 09:00 lds hi 08:04 cait1 good morning #koha 07:52 ChrisisImpatien Good morning/afternoon/evening! 07:44 alex_ Bonjour 07:35 wahanui que tal, reiveune 07:35 reiveune hello 07:17 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809 normal, P5 - low, ---, koha-bugs, Passed QA , Automatic debian/control updates (dev/unstable) 07:17 mtj ..and bug 32809 too πΏπ€πΊ 05:42 mtj ^ Joubu or ashimema perhaps? 05:23 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 major, P3, ---, dcook, Signed Off , Fix OAI breakage when using HTTP::OAI 4.03+ 05:23 mtj hi all, could someone QA bug 17704 pweese