Time Nick Message
22:16 dcook tcohen: Still around?
21:42 mtj if we have a future situation that requires customisation of a/some dockerfiles, we can add an IF block to the template
21:33 mtj i made a nice discovery, that all builds work on a single dockerfile template
21:26 mtj would also fix a user problem, of errors when ktd branch is not set correctly :/
21:25 mtj using this would reduce KTD mantainance to a single branch
21:22 mtj uses a TT file, as a template
21:22 mtj https://gitlab.com/mjames/ktd-arm64/-/blob/master/.gitlab-ci.yml.tt
21:22 mtj https://gitlab.com/mjames/ktd-arm64/-/blob/master/Dockerfile.tt
21:21 mtj https://gitlab.com/mjames/ktd-arm64/-/blob/master/gen-dockerfiles.pl
21:21 mtj i have experimented with a perl script to build all Dockerfiles and .gitlab.yml for KTD
21:20 mtj tcohen: im not sure if i mentioned this before...
21:16 mtj ^ or something else?
21:15 mtj dists/bullseye-arm64/Docker
21:15 mtj dists/bullseye/Docker.arm64 ?
21:12 mtj specifically around files under ./dists dir
21:11 mtj hi tcohen, do you have any ideas about how to add arm64 images to ktd, for apple and aws systems?
18:39 ashimema ?
18:30 davidnind Probably a bit early for dcook - 5:30am in Sydney. 7:30am here in New Zealand.
18:26 tcohen dcook: around?
18:24 tcohen anyone from catalyst?
17:24 ashimema my brain is mush at this point today 😜
17:24 ashimema will have a look first thing in the morning
16:47 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 normal, P5 - low, ---, jonathan.druart+koha, Needs Signoff , x-koha-embed must be an enum
16:47 Joubu ashimema, tcohen: could you have a look at bug 32923 comment 7, I am stuck there
15:59 emlam tcohen++
15:59 emlam Just brought up the KTD readme and saw how much has been added to it recently!!
15:39 Joubu the git grep output didn't show that
15:38 Joubu right
15:38 ashimema but it wasn't as simple as it first appeared
15:38 ashimema we could probably still clean it up a bit and DRY out the code..
15:38 ashimema then what we actually pass to the template is a filtered list of attributes.. i.e. the 'staff_searchable' set
15:37 ashimema so the pref turns it on/off
15:37 ashimema they're actually filtering the lists
15:37 ashimema I had a quick look at the controllers themselves
15:36 Joubu I can have a deeper look if you want me to
15:36 Joubu that seems identical, unless I am missing something
15:36 Joubu [% IF Koha.Preference('ExtendedPatronAttributes') %]
15:36 Joubu I would remove occurrences of attribute_type_codes in pl, extended_attribute_types in tt, and replace the line in .inc with
15:35 Joubu koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: [% IF Koha.Preference('ExtendedPatronAttributes') && extended_attribute_types %]
15:35 Joubu then finally, in the include:
15:35 Joubu default_sort_column => 'name-address', display_search_description => 1, remember_selections => 1 %]
15:35 Joubu koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt: [% PROCESS patron_search_js table_id => 'memberresultst', categories => categories, libraries => libraries, extended_attribute_types => attribute_type_codes, columns => columns,actions => ['edit', 'checkout'], redirect_if_one_result => 1, redirect_url => redirect_url, sticky_header => "searchheader", sticky_to => "searchresults",
15:35 Joubu members/member.pl: attribute_type_codes => ( C4::Context->preference('ExtendedPatronAttributes')
15:35 Joubu ashimema: I don't understand that:
15:34 Joubu It's like it could be removed from controllers and .tt and only fetched from the include
15:34 ashimema how/where what is usefull?
15:34 ashimema sorry Joubu.. I didn't follow that last comment
15:33 ashimema it really is.
15:33 ashimema yup
15:33 Joubu I don't see how/where it is useful
15:33 Joubu ashimema: attribute_type_codes vs ExtendedPatronAttributes - yes I confirm that is confusing
15:30 cait sorry if it was confusing, my main point was about not having another way to do that modal
15:29 cait but separate
15:29 cait That's a very valid point: (16:13:39) ashimema: but I don't think it should limit the 'Search field' select box in patron search.. that one should allow selecting a larger list of fields.. either hard coded or from another pref
15:28 cait I thought your selection made sense - but on the other hand... even if it's not useful, maybe we don't need t block it, if it doesn't brak things
15:28 cait 2) reusing the same code we use everywhere
15:28 cait my goal was 1) not accidentally braking some hidden feature
15:27 cait sorry, slow reading back..
15:27 cait no I didn't mean it's wrong we exclude things
15:27 ashimema some controllers filter it
15:27 ashimema ah, interesting
15:26 ashimema why the double check.. feels like the controller don't really need to ever pass it to be honest.
15:25 ashimema patron-search.inc seems to check that the pref has something in it.. and check that the controller script has passed the content of the pref to us.. before converting it to json
15:24 ashimema I'm confused by our passing around of ExtendedPatronAttributes
15:24 ashimema ermmm
15:23 ashimema hehe
15:22 Joubu ha... timezones...
15:22 Joubu I am going to push it on Friday night when everybody will be asleep
15:20 ashimema I think that's also good to go
15:20 ashimema I commented on https://gitlab.com/koha-community/koha-misc4dev/-/merge_requests/58
15:19 ashimema agreed
15:19 Joubu This is becoming a real pain!
15:18 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Remove compiled files from src
15:18 Joubu Can we push bug 32609 please?
15:13 ashimema but I don't think it should limit the 'Search field' select box in patron search.. that one should allow selecting a larger list of fields.. either hard coded or from another pref
15:12 ashimema I think it should apply to autocomplete and default searches..
15:12 ashimema must admit however.. i think the 'defaultPatronSearchFields' pref is used a little too widely now..
15:09 ashimema my bad.. I will attempt to fix that bit as it's my doing.
15:09 ashimema and when I added binding of the pref for autocomplete I neglected the same fix you added for the otehr patron search stuff.
15:08 ashimema cait is saying it's wrong we exclude some things
15:08 ashimema yeah.. and your code works
15:08 ashimema cait has valid point.. but I can't write code to fix all the things on that one bug
15:08 ashimema it's mingled with some other things
15:08 Joubu I've wrote a patch to exclude stuffs from there
15:07 Joubu hum wait
15:03 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 enhancement, P5 - low, ---, martin.renvoize, In Discussion , Use table column selection modal for DefaultPatronSearchFields preference
15:03 ashimema bug 29822
15:01 Joubu what are you talking about?
15:00 ashimema I think I'm going to just unassign myself and it'll be another ptfs-e only dev I maintain.
15:00 ashimema anyways
15:00 ashimema to prevent you from catastrophically breaking your own system
15:00 ashimema it's the whole point of this development
15:00 ashimema that's what I've been saying
15:00 ashimema I have varified.. if you add a patron attribute you break search cait
14:59 ashimema lol
14:58 cait today is the 4th Monday in a row this week...
14:49 paulderscheid[m] Init with the lovely: re.pl
14:49 paulderscheid[m] You can install it and then run the logic you want to test in your shell
14:49 paulderscheid[m] I just had to debug datetime stuff
14:49 ashimema mmm
14:48 cait ashimema: not quite here - but commented again
14:48 cait paulderscheid[m]: what does it do?
14:38 paulderscheid[m] Not sure who needs to hear this but Devel::REPL is awesome.
14:21 ashimema cait about
13:31 PedroAmorim[m] yes
13:31 tcohen PedroAmorim[m]: around?
12:40 ashimema it was well worthwhile
12:40 ashimema yeah
12:30 tcohen and the complexities (multi-tennancy, etc)
12:29 tcohen so you know all the pieces
12:29 tcohen I think you need to do it
12:29 ashimema though it's nice to know we took very similar directions
12:29 ashimema as I said.. all good learning.. but a bit of repeated effort
12:29 ashimema we've been finding that
12:29 ashimema totally
12:29 ashimema yeah
12:28 tcohen but things were hardcoded at some levels that made us just wait until it was easier
12:27 tcohen if you look at the history of the commits, the first version we had was just php, and we used an external solr, etc
12:25 ashimema but perhaps it hasn't yet
12:25 ashimema I thought the equinox merge had happened actually and that was already the case
12:25 ashimema like swapping adduser for useradd..
12:25 ashimema so of the "hacks" in your dockerfile should really just be upstreamed into aspen 😜
12:22 ashimema thanks
12:22 tcohen so the 'latest' is 23.01....
12:22 tcohen BTW: they don't use a 'main' repo for development <.<
12:21 ashimema cheers
12:21 tcohen they assumed it was in the repo
12:21 tcohen asking Lucas or Gabriel to push it
12:19 ashimema 😜
12:19 ashimema nope
12:18 tcohen isn't it on the repo?
12:18 tcohen ashimema: of course it is public
12:13 ashimema assume that also sets up some of the external connections?
12:12 ashimema is the compose file you have public?
12:11 tcohen was based only on the official php image
12:11 tcohen the first version which I wrote and Gabriel enhanced
12:10 tcohen in PTFS-ish way :-D
12:10 tcohen as we develop remotely
12:10 tcohen we do a shallow clone on build, but the compose will overwrite it with the mounted clone
12:10 tcohen we just upgraded it to v8
12:09 ashimema we're also working with php7 still as php8 has a few issues with the SSO stuff still I believe
12:09 ashimema that's almost exactly how Jacob was doing it before I stepped in and dropped the early clone
12:08 * ashimema should just read it.
12:08 ashimema so you clone inside the container.. use it to run the installer and stuff.. then mount over the top?
12:08 ashimema I see
12:08 tcohen I really don't like the approach
12:07 tcohen with the docker-compose
12:07 tcohen ah, yeah, but we mount the clone too
12:07 ashimema take it you're looking at prodcution
12:07 ashimema main difference I'm seeing so far is we're mounting a clone from outside as aposed to shallow cloneing inside
12:06 ashimema our Dockerfiles are really similar
12:05 ashimema 🙂
12:05 tcohen https://gitlab.com/thekesolutions/aspen/base
12:05 tcohen sorry, flavour
12:05 tcohen and with your own flavor
12:05 ashimema interested to see how you've done it though
12:04 tcohen of course
12:04 ashimema fair enough.. it's been a good learning process regardless
12:04 ashimema not koha etc
12:04 tcohen ah, we already have that
12:04 ashimema well..
12:04 ashimema the whole lot
12:04 tcohen or just the PHP portion of it?
12:04 ashimema and it'll auto-connect to a ktd instance if ktd is found to be running 🙂
12:04 tcohen is it a full Aspen in a Dockerfile
12:04 ashimema but it basically all works..
12:04 ashimema I'm just working on some permissions issues we had and fixing up the order we call stuff in dockerfile
12:03 tcohen Joubu: what about a --force option for translate --install ?
12:03 tcohen ashimema: I'm interested on that
12:02 ashimema lol
12:02 oleonard Is docker land like Tron ashimema ?
11:57 * ashimema has been in docker land himself the last couple of days.. we're building aspen-dev-docker 🙂
11:56 ashimema did I somehow completely miss ktd being broekn
11:55 oleonard As long as I don't have to go back to downloading Virtualbox like some kind of cave man.
11:53 oleonard tcohen++
11:53 oleonard Joubu++
11:52 Joubu oleonard: tcohen fixed it ;)
11:52 tcohen awesome
11:52 oleonard Joubu waved his magic wand
11:51 oleonard I did
11:51 tcohen oleonard: you got ktd working, rihgt?
11:43 tcohen Joubu++
11:42 tcohen hola #koha o/
11:41 oleonard o/
09:51 Joubu Thanks!
09:51 mtj great work everyone
09:51 mtj all looks good :)
09:07 mtj just testing ...
08:46 mtj hmm, i might use the version from yarnpkg.com
08:46 mtj sure
08:39 Joubu can you comment on the bug please?
08:39 mtj lets assume its ok :)
08:39 Joubu looks like I have 1.22.19 in bullseye
08:37 mtj Joubu: is that version ok?
08:37 mtj 1.22.10
08:37 mtj https://packages.debian.org/bullseye/yarnpkg
08:37 mtj yes
08:34 Joubu mtj: does it mean you installed it?
08:32 mtj Joubu: looks good!
08:31 mtj hi all
08:19 cait good morning #koha
08:03 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Remove compiled files from src
08:03 Joubu mtj: did you see bug 32609 comment 55?
07:37 alex_ Bonjour
07:33 reiveune helo
02:06 tuxayo then you retry to connect, you should see more info about the internal server error
02:06 tuxayo Then run the command tail -f * to see all new output to all log files
02:05 tuxayo You should find the logs here: /var/log/koha/NAME_OF_YOUR_KOHA_INSTANCE/
02:04 tuxayo Chrishaserrors: hi :)
01:09 Chrishaserrors I'm hoping someone can help me out... my 'tech' guy and I have both gotten through the install instructions listed on the website, apparently have a Koha instance running, but are getting 'Internal Server Errors' when we try and connect. Can anyone point me in the right direction?
01:07 Guest4235 Good morning/afternoon/evening!