Time  Nick             Message
06:24 reiveune         hello
06:39 cait1            good morning #koha
06:39 ashimema         morning cait1
06:39 ashimema         morning koha
06:39 cait1            morning ashimema :)
06:39 cait1            QA mail will be around lunch today
06:41 ashimema         🙂
06:52 alex_            Bonjour
07:28 magnuse          \o/
08:10 paulderscheid[m] morning #koha
08:13 cait1            morning paulderscheid[m]
08:23 ashimema         wow the basket template is messy.... the indentation is sooooo confusing
08:24 ashimema         and the nested IF's.. wow
08:24 ashimema         >  79         [% IF !confirm_close && !edi_confirm %]... (full message at <https://matrix.org/_matrix/media/r0/download/matrix.org/xwJDTxoQgGylfYFsktUziFvo>)
08:24 ashimema         wha....
09:05 cait1            if with !... always take me a bit
09:05 cait1            and then 3 unless ...
09:57 cait1            bug 31936 - we lost a feature
09:57 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 blocker, P5 - low, ---, koha-bugs, NEW , Link to advanced search form in acquisitions is missing
10:20 oleonard         Hi #koha
10:20 ashimema         hi oleonard
10:20 wahanui          hi oleopard
10:45 oleonard         ashimema your comment on Bug 31754 makes it look like you're not getting the updated CSS when you test
10:45 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 normal, P5 - low, ---, oleonard, Failed QA , Improve appearance of behavior of DataTables controls
10:48 ashimema         ok, testing again
10:49 ashimema         hmm.. ok.. looks rather different today
10:50 ashimema         we now have highlighting on the current page and things..
10:50 ashimema         maybe I wasn't getting it..
10:54 oleonard         Thanks for all the QA ashimema
10:56 ashimema         OK.. I've worked it out
10:57 ashimema         it's the combination of bug 31754 and 31861 I think
10:57 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 normal, P5 - low, ---, oleonard, Passed QA , Improve appearance of behavior of DataTables controls
10:57 ashimema         with 31861 at least the 'clear filters' becomes a 'button' again
10:59 ashimema         ack.. now I'm confused ☹️
11:00 ashimema         whats the most strongest way to do a hard refresh in firefox ?
11:00 * ashimema       has recently switch from chrome where you had right click options on the refresh button to do various forms of cache nuking refresh
11:01 Joubu            ctrl+shift+p :D
11:01 ashimema         lol
11:01 ashimema         private window.. fair
11:03 ashimema         those two bugs definitely conflict somehow oleonard
11:11 oleonard         Ah, good catch ashimema
11:12 ashimema         sorry for being the pita today 😜
11:13 oleonard         I'm pretty sure that's just part of the QA job ashimema
11:14 ashimema         maybe.. but I never like being the bearer of bad news 😜
11:15 oleonard         I'd much rather get bad news than have my mistake make it into master
11:22 * ashimema       finds our 'rows' class confusing.. never really taken notice of it before
11:25 magnuse          @quote add oleonard> I'd much rather get bad news than have my mistake make it into master
11:25 huginn`          magnuse: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command).
11:25 magnuse          @quote add oleonard> I'd much rather get bad news than have my mistake make it into master
11:25 huginn`          magnuse: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command).
11:25 magnuse          \o/
11:26 oleonard         Is that you throwing up your hands in despair magnuse ?
11:27 magnuse          yup. usually it's me waving to people, but this time i give up ;-)
11:28 cait1            oh :(
11:28 cait1            @quote add oleonard> I'd much rather get bad news than have my mistake make it into master
11:28 huginn`          cait1: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command).
11:28 magnuse          i did identify with huginn` but still...
11:30 cait1            @quote add oleonard> I'd much rather get bad news than have my mistake make it into master
11:30 huginn`          cait1: The operation succeeded.  Quote #356 added.
11:30 cait1            hah
11:30 cait1            magnuse: it worked for me after huginn accepted me
11:31 oleonard         cait1 must have done the secret handshake
11:37 magnuse          werid, i get "-NickServ- You are successfully identified as magnuse" after doing "/IDENTIFY <my password>"
11:37 magnuse          quote get random
11:37 magnuse          @quote get random
11:37 huginn`          magnuse: Error: 'random' is not a valid id.
11:37 wahanui          i already had it that way, huginn`.
11:38 magnuse          @quote random
11:38 huginn`          magnuse: Quote #252: "<@jcamins> Really the issues is that Anglo-American libraries have settled on a profoundly stupid format that utterly fails to express anything that patrons care about, while going on at great length about things patrons don't care about." (added by chris at 10:42 PM, May 26, 2013)
11:47 tcohen           hola #koha o/
11:47 oleonard         Hi tcohen
11:49 tcohen           busy week everyone
11:49 tcohen           please keep me posted on your interests or if you find something important to take care about
11:50 tcohen           I will try to focus most of my working (and after) hours on the release
11:52 ashimema         grr.. pretty much every page I look at needs these page-section containers/classes adding somewhere ☹️
11:53 tcohen           ashimema: please QA patches implementing them
11:55 ashimema         I have been
11:55 ashimema         🙂
11:59 Joubu            https://snipboard.io/03cGy7.jpg date inputs being wider than other inputs. Feel like we fixed that dozens of times :-/
12:02 Joubu            Toolbar is not correctly aligned - https://snipboard.io/AG96la.jpg
12:02 ashimema         that's another one I find weird..
12:02 Joubu            .btn-toolbar has a margin-left: -5px coming from bootstrap css
12:03 ashimema         why do we have that 'save|cancel' at the top when most other places it's down the bottom
12:03 ashimema         in fact.. we have it in both places but styled differently
12:03 Joubu            it's floating
12:03 ashimema         also don't know why that one has icons when most others don't
12:03 * ashimema       likes icons..
12:04 Joubu            Should I report those 2?
12:04 ashimema         yes please
12:04 ashimema         report all the things
12:04 Joubu            yes but I never know if it has been reported already
12:04 * ashimema       is running around like a blue ass fly trying to help get all this stuff polished
12:04 Joubu            or if it's... not a bug
12:04 ashimema         it's a bug
12:04 ashimema         and I've not reported it yet
12:05 ashimema         the collector for these bugs now has grown so huge it's hard to spot the wood for the tree's though..
12:05 ashimema         wish there was an easy way to hide 'Pushed' from the graph and tree views..
12:05 ashimema         in tree you can hide Resolved.. but not Pushed
12:06 Joubu            bug 31943, bug 31944
12:06 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943 normal, P5 - low, ---, koha-bugs, NEW , date inputs wider than other inputs
12:06 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31944 normal, P5 - low, ---, koha-bugs, NEW , Toolbar is not correctly aligned
12:10 marcelr          o/
12:11 Joubu            https://snipboard.io/AfHwtQ.jpg - dialog message has now a background-color: white, expected?
12:11 ashimema         I don't actually remember what that one used to be
12:12 ashimema         were they action colored.. i.e. green if good, red if bad, yellow if warning, blue if just info ?
12:12 ashimema         something like that?
12:12 ashimema         I feel like they should be..
12:12 Joubu            IIRC blue
12:13 * ashimema       actually updated the card _mixin recently to allow overloading bg-color using the bootstrap bg-* classes.. it made the notes section on the patron imports page much clearer to me having it as an 'info' block
12:13 ashimema         I have a feeling the blue to white was a deliberate thing.. oleonard ?
12:14 * ashimema       would love to see them banded as 'success', 'failure', etc
12:14 oleonard         I assume it was a choice made by Solène or jajm, I don't know why
12:15 ashimema         i assumed it was to reduce the overall color pallet
12:16 oleonard         I think white is a little too invisible but I haven't had time to play around with alternatives
12:17 ashimema         did you see that cait and I have started a bunch of questions in a frama to work towards a style guide oleonard?
12:17 ashimema         https://annuel.framapad.org/p/koha-styleguide-draft
12:18 oleonard         No I hadn't seen. That's great.
12:18 ashimema         at the moment it's mostly open questions.. but with the hope we can decide on some things to put forward as proposals
12:20 tcohen           show we have new omnibus bugs?
12:20 ashimema         ?
12:20 Joubu            https://github.com/jajm/koha-staff-interface-redesign/issues/9
12:20 Joubu            div.dialog.message should have a background/borders hum...
12:20 tcohen           like 'New staff interface - page-section'
12:21 tcohen           it's got complex to track things atm
12:21 ashimema         I've tried to create some collectors at the other end..
12:21 ashimema         so for page-section every bug should be 'depends on' the staff client refresh one.. and 'blocks' the page-section collector
12:22 ashimema         so you can look at the tree for the page-section collector to filter out all the other staff client fixes
12:22 ashimema         ha.. well he improved it.. which is why I let it through.. but we didn't discuss further colouring options..  Joubu
12:23 ashimema         so we can happily open a new bug.. though perhaps discuss it on our style guide start instead to get a consensus on it.
12:27 ashimema         oleonard still around?
12:27 oleonard         Yes
12:27 ashimema         it's really subtle.. but aren't the dt buttons mis-aligned vertically?
12:29 ashimema         grr.. I can't see how they are.. but to me they look like the ones on the right of 'search' are all a bit lower than the labels and buttons on the left of search
12:30 ashimema         sod it.. I've decided I don't care.. there are more important things
12:32 Joubu            What's the correct way to separate a text and an icon, or a button?
12:33 Joubu            &nbsp; or &#160; or margin?
12:33 oleonard         In what context Joubu
12:34 oleonard         ashimema: They are a little off
12:34 Joubu            erm/vue/compiled css
12:34 ashimema         hmm.. I thought I added a collector for cait's yellow buttons bugs.. but I can't find it now
12:34 ashimema         be good to group those again to allow easy filtering on that class of bug
12:35 ashimema         walk time.. bbiab
12:35 Joubu            in Koha we usually add a whitespace in the code, but when whitespaces are removed it get complicated :)
12:35 oleonard         Joubu: I would say usually a CSS margin is best. With FA icons and HTML buttons it's just a regular space.
12:35 Joubu            s/compiled css/minified js
13:21 tuxayo           yay, someone from a library of a 3500 ihabitants village attends to the patch testing session :D
13:21 oleonard         \o/
14:06 cait1            tuxayo++
14:06 cait1            did you get some replies from the koha-de mail?
14:13 oleonard         I'm frustrated by the removal of catalog tools from the tools page.
14:14 oleonard         I know I'll get used to it in time, but I also think it's not illogical to have them in both places.
14:15 cait1            oleonard: it kinda gets messy with breadcrumbs and navigation
14:15 ashimema         haha.. I know exactly what you mean oleonard.. my apologies for that..
14:15 cait1            if you add them back on tools that is... I am also getting used to it right now
14:15 cait1            slowly I admit :)
14:15 ashimema         people were keen.. but I also have the muscle memory trained
14:16 ashimema         perhaps even just a link to cat home from tools so it's only one click away instead of back and clikc
14:16 ashimema         that could work as an interim
14:16 cait1            yah
14:16 oleonard         I have a hard enough time remembering whether certain things are in tools or admin XD
14:16 ashimema         haha
14:16 ashimema         hugs
14:17 ashimema         that's kinda the whole point.. try to make things clearer.... but by doing so we make things harder in the short term
14:17 ashimema         if it makes you feel any better.. so far the three customers of our that have seen it so far absolutely love it.
14:19 oleonard         It's not clearer with the breadcrumbs still pointing back to Tools for all the cataloging tools pages
14:19 oleonard         Is there an open bug for that?
14:23 cait1            i think that's in queue already
14:23 cait1            in pqa, i checked that one
14:23 cait1            I think the bug for changing the page titles still needed a patch tho
14:24 ashimema         oh.. is that not pushed yet
14:24 ashimema         darn
14:25 cait1            maybe I only signed? but definitely remember testing it and it was good
14:29 ashimema         ho.. Lucas took it over..
14:29 ashimema         I see.. he finished the job.. well... did it all without using my original
14:29 ashimema         which is fine
14:31 cait1            I didn't see there was another patch
14:35 lukeg            hi
14:38 lukeg            ashimema: Sorry, I never saw your patches on Bug 31556
14:38 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 enhancement, P5 - low, ---, martin.renvoize, RESOLVED DUPLICATE, Correct breadcrumb for Cataloging module
14:38 ashimema         no worries at all
14:38 ashimema         you did a great job finishing up where I failed
14:38 ashimema         thanks
14:38 ashimema         I'm working on the titles now btw
14:38 lukeg            OK, good to know!
14:41 cait1            lukeg++
14:41 cait1            jajm: around?
14:42 cait1            is someone close to the recent holds_queue updates? i think we do more on the fly now... but not quite sure yet what we do exactly
14:42 cait1            opposed to the old 'cronjob way' of things
14:46 ashimema         the scary one is still left to go
14:46 ashimema         fixing the urls
14:46 cait1            found the bug
14:46 cait1            (holdsqueue)
14:46 ashimema         that entails moving cataloguing to cataloging and then moving all the bits out of tools and labels as appropriate
14:46 ashimema         and then fixing up all the links
14:46 ashimema         for both templates and controllers..
14:46 ashimema         big scary job
14:47 ashimema         tcohen is likely your man for that cait1
14:48 cait1            yeah, but reading through 29346 already helps to get a clearer idea
14:48 ashimema         bug 29346
14:48 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 enhancement, P5 - low, ---, tomascohen, RESOLVED FIXED, Real-time holds queue update
14:48 ashimema         good good
14:50 cait1            and filed bug 31948
14:50 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 enhancement, P5 - low, ---, koha-bugs, NEW , Add timestamp to tmp_holdsqueue
14:57 tcohen           hola cait1
14:57 tcohen           rmaints
14:57 tcohen           rmaints?
14:57 wahanui          rmaints are lukeg, liliputech and tuxayo
14:58 lukeg            Hi tcohen
14:58 tcohen           hey, can the last one remove the additional_work_needed whe nwe close things? e.g. 29325
14:58 lukeg            22.05.06 is incoming today
14:59 tcohen           there's a security bug
14:59 ashimema         woop, woop.. lots of pushes again 🙂
15:03 cait1            hola tcohen :)
15:03 reiveune         bye
15:08 cait1            now that we have the white everywhere... our start pages look odd to me with the grey background
15:08 tuxayo           tcohen: ok, looking at it. Note, liliputech already released 21.11.x I think
15:08 tuxayo           yes, there did
15:08 tuxayo           *they
15:15 ashimema         Lol
15:18 cait1            ashimema: oleonard: maybe one of you for bug 31950? might be a follow up to 31939 but filed separately
15:18 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31950 minor, P5 - low, ---, koha-bugs, NEW , Page section on library view is too wide / not aligned with toolbar
15:21 ashimema         ho.. I only worked on that this morning
15:21 ashimema         in fact.. I'm confused..
15:21 ashimema         I just pulled and can't see this mornings work.. is it in master nwo
15:21 cait1            i made it depends on your bug
15:22 cait1            hm found another: empty system preference search breaks layout
15:22 ashimema         aha.. so it's no in master.. it's PQA
15:22 cait1            ah ok
15:23 cait1            tcohen: we need you to push faster heh :)
15:23 ashimema         lol
15:24 ashimema         ah.. I see
15:24 ashimema         the section goes all the way to the ight
15:24 ashimema         right
15:25 ashimema         not sure what you mean by 'aligned with toolbar above' though..
15:25 ashimema         the toolbars have no background yet so I can't see how they look mis-aligned
15:25 ashimema         that page was a bugger to style though... we have some interesting 'rows' class thing that gets it' all confused
15:28 oleonard         The problem is that toolbar buttons still have padding like they are styled as buttons with borders, so it doesn't *look* like they're left-aligned with the page content but they are.
15:28 oleonard         If you hover your mouse over the "New library" button you can see it.
15:29 ashimema         there is also an issue with adding 'page-section' to a 'row' div
15:29 ashimema         but I can't add it to the col-X div's here either because there's a nested 'rows' div inside which makes things go really weird and screwy in other ways
15:29 ashimema         it's confusing
15:31 cait1            ashimema: my toolsbars have... because of my bad screen I added a darker background color
15:31 * ashimema       steps away from that one and leaves it in more expert hands
15:31 cait1            so they appear in grey
15:31 ashimema         lol
15:31 ashimema         I see cait1
15:31 cait1            I needed to up the contrast to see table stripings and such
15:31 ashimema         there is still a bug open to improve those toolbars..
15:32 cait1            yes
15:32 cait1            I am still vey much in favor of making them proper link colored or so
15:32 cait1            the grey really looks not like something to click
15:32 * ashimema       added a bunch of questions about toolbars to our style guide start
15:32 ashimema         we're hugely inconsistent again
15:33 cait1            Added my CSS change to the bug
15:33 ashimema         okies
15:34 cait1            it does work ok on other pages, so the "library view" stood out negatively
15:34 ashimema         there is certainly some funk on the libraries page..
15:34 ashimema         not the only place though..
15:34 ashimema         the 'rows' thing is really weird and confusing
15:35 ashimema         i.e we have 'row' from bootstrap and then 'rows' as another class of our own..
15:35 oleonard         lukeg: Are you aware of patron search issues in 22.05.05? I don't know what's in your queue for .06.
15:36 oleonard         I wish the redesign hadn't touched styling of forms because I think forms needed a more focused overhaul.
15:42 cait1            I am not sure about this one, woud love another opinion: 31917
15:42 cait1            bug 31917
15:42 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Headings don't seem quite right for system preference search
15:45 tuxayo           cait1: «did you get some replies from the koha-de mail?» Nothing via email and no new responder to the poll.
15:46 cait1            oh
15:55 cait1            tuxayo: I'll advertise if I see a chance to
15:55 tuxayo           cait++
15:59 tuxayo           cait1: Ah yes every support organization can relay this to librarians they know might be keen to getting there hands dirty.
16:01 tcohen           cait1: I cannot push faster, sorry
16:01 ashimema         hehe
16:02 ashimema         hugs tcohen.. you're doing awesome
16:02 tcohen           thanks
16:02 tcohen           question about tmp_holdsqueue, should it be timestamp, created_on, updated_on?
16:02 tcohen           heh
16:02 tcohen           the queue is actually rebuilt so...
16:06 cait1            tcohen: but it's nto rebuilt if you sue Real time, isn't it?
16:07 tcohen           it is rebuilt per-biblio
16:07 tcohen           i.e. the queue for the biblio is rebuilt
16:07 tcohen           before that, all table was wiped
16:10 tcohen           ashimema: should we think of a qa test for the page-section class?
16:12 ashimema         pass..
16:12 ashimema         we need to get the style guide written first really
16:13 tcohen           oleonard: would 31879 conflict with other staff revamp patches?
16:14 oleonard         Not that I know of, unless you have patches in the queue that touch that page specifically
16:14 cait1            sorry, had a phone call interrupt, reading now
16:15 cait1            tcohen: i think timestamp would make most sense to me, unless it#s always a created_on?
16:15 cait1            there is no PK i guess
16:15 cait1            tcohen: background to this was working on a solution for printing
16:16 cait1            print only the new entries or automate printing
16:16 cait1            if you have ideas about this, I am all ears :)
16:21 cait1            i am (almost) sorry for filing so many bugs today
16:21 oleonard         I like to be kept busy
16:22 tcohen           :-D
16:22 cait1            oleonard++ thx :)
16:23 tcohen           I could use some help fixing the selenium tests
16:29 cait1            are there specific ones? i could send a follow-up to qA mail later
16:29 cait1            or you could email them - might work better :)
16:32 tuxayo           It seems to be these builds
16:32 tuxayo           https://jenkins.koha-community.org/view/master/job/Koha_Master/2234/consoleText
16:32 tuxayo           https://jenkins.koha-community.org/view/master/job/Koha_Master_D11_SEL/100/consoleText
16:40 cait1            I'll finish my bug and then switch computers to send
16:45 cait1            oleonard: shoudl we have fieldsets within field sets?
16:46 oleonard         cait1: Nesting fieldsets is sometimes the correct thing to do, so our CSS should accommodate it.
16:46 cait1            hm ok
16:46 * oleonard       off to a meeting
16:46 cait1            the problem is... i feel like it woudl be nice to have the additional fields a bit separate, as they come with their own heading
16:46 cait1            aah, bad tming
16:46 cait1            but the save button applies to both
16:47 cait1            ... ok, will ponder this on my own some more :)
17:06 cait             oleonard++
17:29 tcohen           wow
17:29 tcohen           DBRev... 70
17:36 tcohen           who can add keywords to bz?
17:36 tcohen           ashimema, cait, Joubu
17:37 fridolin         hi there
17:39 ashimema         What keyword do you want tcohen?
17:40 * ashimema       has just finished tea and will turn laptop back in shortly
17:42 tcohen           didn't we have a technical_notes thing?
17:43 tcohen           there are bugs that require 'reindex all the things', for instance
17:43 cait             i am back now too, just need some fresh tea maybe
17:53 cait             hm the sorting in the git repository is really odd: https://git.koha-community.org/Koha-community/Koha/commits/branch/master
18:03 * cait           feels like QA team needs a theme song
18:04 ashimema         haha
18:05 cait             it's true!
18:06 cait             ::)
18:12 * cait           runs behind lukeg :)
18:17 tcohen           should I stop pushing things? the release is scary already
18:17 tcohen           haha
18:17 cait             nah
18:17 cait             this is just polishing
18:18 ashimema         lol
18:19 cait             lots of soap and foam and stuff
18:19 cait             glitter.
19:50 cait             someone still around? :)
20:14 lukeg            I'm someone, I'm around :)
20:17 cait             awesome :)
21:18 tuxayo           cait «hm the sorting in the git repository is really odd» Because of the dates? That the original author date of the commit. Not the date they have been QAed or pushed to master.
21:18 cait             yeah, i think so, but it's really not helpful like that
21:19 cait             thx caroline++
21:21 caroline         cait++ :D
21:42 cait             those have bugged me for a while too, thx for writing up test plans :)
21:50 cait             lukeg: thx :) spotted it, but didn't get to it yet
21:52 ashimema         evening
21:52 cait             hey stranger :)
21:52 ashimema         what are you talking about git order?
21:53 cait             only 9 more changes... to 500
21:53 ashimema         oh.. i see
21:53 ashimema         weird
22:41 davidnind[m]     thd++
22:42 ashimema         and I think it's time for bed for me
22:42 ashimema         see ya #koha 🙂
22:42 ashimema         great day of fixing, testing and pushing.. lots of little fixes and tweaks today.
22:43 davidnind[m]     the GitLab clone of Koha has the commits in the "correct" order I think...
22:44 cait             caroline: i gave your bug 31694 a go - maybe you could have a look?
22:44 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 normal, P5 - low, ---, koha-bugs, Needs Signoff , MARC overlay rules presets don't change anything if presets are translated