Time  Nick             Message
06:10 marcelr          hi #koha
06:44 reiveune         hello
06:51 alex_            Bonjour
08:15 * cait           waves
08:18 paulderscheid[m] good morning #koha
08:22 marcelr          o/
08:22 paulderscheid[m] \o
08:28 * cait           waves
08:28 ashimema         morning
08:32 marcelr          hi ashimema
09:26 ashimema         hmm...
09:26 ashimema         the more I look at all these staff client UI fixes.. the more little things I uncover that bug me..
09:27 ashimema         it's wack-a-mole.. I SO/QA one bug and open another two in it's place.
09:28 cait             your senses are sharpened now
09:28 cait             hope to join you soon
09:28 cait             2 more mails or so :(
09:28 ashimema         indeed
09:28 ashimema         woop, woop
09:33 marcelr          ashimema: it is the Koha game: solve one bug, find two new ones :)
09:34 cait             it's true
09:34 Joubu            nav menu on the left, syspref page, I am seeing: https://snipboard.io/Q3wHt6.jpg
09:35 Joubu            Is that expected that the "subitems" are not indented to the right?
09:35 marcelr          Joubu probably not
09:35 Joubu            they are actually more towards the left
09:36 cait             file it :)
09:36 Joubu            rebasing the erm branch, and it looks very bad: https://snipboard.io/zL7mMO.jpg
09:36 marcelr          Joubu++
09:37 Joubu            what is "page-section"?
09:37 cait             hm yes, that looks very odd
09:37 cait             page-section class gives a white background
09:37 Joubu            is that supposed to replace the fieldset borders?
09:37 cait             a card-kinda layout? Ashimema can explain
09:37 cait             but yours looks like there might also be a markup error
09:37 Joubu            yes, but that's for something else
09:38 Joubu            https://snipboard.io/nTBRAh.jpg
09:38 cait             i think the white background der is right
09:38 cait             der = there
09:38 Joubu            vs https://snipboard.io/MNZkpT.jpg
09:38 marcelr          deero
09:39 cait             but there are small glitches for the File.: and the buttons at the bottom are stuck together
09:39 Joubu            before there were too many border, now there are no more
09:39 cait             yes
09:39 cait             but the contrast between background and the white is more visible for me usually than on your screenshot now
09:39 cait             might be my bad screen again
09:40 ashimema         sorry.. was reading back
09:40 ashimema         hmm.. nested form fieldsets.. I've not really come across one of those yet in the new UI..
09:41 Joubu            yes, that's my problem I think
09:41 ashimema         as for your left nav stuff I think that's a different thing.. it should probably take the same form as the other sidebar-menu stuff..
09:41 ashimema         like circ-menu.inc
09:41 ashimema         page-section is basically a very minimal white box to denote a content section of a page
09:42 ashimema         but it does not look incredibly similar to fieldset too
09:42 Joubu            left bar: I don't think it's like circ. All the 'li' are links.
09:42 ashimema         I was just considering this actually.. for me one of the big difference's between the current fieldset and the previous one (and the page-section of now).. is that the 'legend' is inside the box
09:42 Joubu            on circ, entries are grouped
09:43 ashimema         before it was part of the border.. and for page section we are a bit inconsistent.. but the main heading certainly started outside the box
09:44 * ashimema       might be thinking of tools or cataloging
09:52 ashimema         oh.. I missed your first screenshot Joubu.. I see what you mean
09:53 ashimema         subitems indentation is wrong.. another bug
11:01 cait             the acq order form needs some serious work too - broken item form
11:02 cait             inc ase noone got to that one yet :)
11:06 * ashimema       has decided picking colors is bloody hard ;P
11:07 ashimema         bug 31753
11:07 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 enhancement, P5 - low, ---, oleonard, Passed QA , Dialog boxes inside of modals don't seem wide enough
11:19 cait             oook, got 40 minutes for QA now... *dives in*
11:19 cait             someon a suggestion?
11:28 cait             marcelr++ thx
11:30 * ashimema       has just been working down https://bugs.koha-community.org/bugzilla3/showdependencygraph.cgi?id=30952&showsummary=on&display=tree&rankdir=LR
11:31 cait             I picked one, set the QA contact
11:39 tcohen           hola #koha
11:42 ashimema         I'm off for a swim.. see you soon KOha
11:43 tcohen           enjoy ashimema !
11:44 cait             oooh
11:44 tcohen           ashimema: I'm afraid you cannot leave, is QA day
11:49 cait             ah no lukeg either
11:50 Joubu            is it then correct to use page-section for forms?
11:50 Joubu            I am getting this layout: https://snipboard.io/vPyegC.jpg
11:52 cait             i think so
11:52 tcohen           cait: lukeg gets in later (in 2 hours)
11:52 cait             we have it on the patron form too
11:53 cait             ah ok
11:53 tcohen           that looks correct Joubu
11:54 Joubu            cait: I don't see page-section on memberentry
11:54 cait             hm maybe some other element has the same effect then?
11:54 cait             i was going by the looks
11:54 Joubu            https://snipboard.io/5UpWCR.jpg - buttons are misplaced btw
11:55 ashimema         Filedset has very similar styling
11:56 ashimema         Swim time, bbiab
11:57 Joubu            then should I pick fieldset? :)
11:57 cait             we need to start a document tow rite all this up
11:58 cait             I have another one: page sub-headings: inside page-section or above?
11:59 cait             ok, looks like outside for h1... but h2 inside?
12:00 cait             shoudl we just start a frama and take notes as we go?
12:42 ashimema         and this is why I was really keen to have a style guide front and centre for this work.. butt that went down like a lead baloon
12:55 cait             well, we can moan... or we can start one :)
12:55 ashimema         yes
12:55 ashimema         we should start one
12:56 ashimema         should we use the Wiki?
12:56 ashimema         along similar lines to the codeing guidelines?
12:56 cait             I was thining maybe use a framapad to have a quick start and move wiki as a second step?
12:56 cait             but yes, i think siilar to guidelines, but spearate page for sure
12:56 ashimema         draft it out between us then vote it in at a meeting?
12:56 ashimema         sure.. if frama is easier for you 🙂
12:56 cait             coding guidelines and style guidelines maybe?
12:56 ashimema         lets go with that
12:57 ashimema         perfect.. only reason I suggested wiki was it lends itself to easily formatted code snippets
12:57 ashimema         but we can do that as a second step.. first step really is to get a bunch of questions listed and then answer them between us..
12:57 cait             hm it's a valid point
12:57 cait             let's try wiki then
12:57 ashimema         like where different heading levels should be used, inside/outside page-section.. when page-section should be used vs fieldset..
12:57 ashimema         etc, etc
12:58 cait             but we can not name it draft nwo and rename later... right?
12:58 * ashimema       is actually a massive fan of markdown for this sort of stuff.. but hey ;)
12:59 ashimema         lets stick to a frama for now.. wiki is just about to move too so it makes sense to push it into the wiki as soon as that move has happened rather than risk delaying that move because we're suddently making te wiki very activ
12:59 cait             ok, because I don't remember how to start a ne page on the wiki right now
12:59 cait             https://annuel.framapad.org/p/koha-styleguide-draft
13:01 tcohen           ashimema: it should happen next week
13:01 ashimema         awesome
13:04 cait             you got to start writing too :)
13:05 ashimema         Will do momentarily.. just rebasing something 😜
13:19 cait             new bug incoming: Bug 31910        - Article request form is misaligned/misformatted
13:20 magnuse_         cait++ ashimema++
13:51 ashimema         talking alerts cait.. I've seen the at the top, I've seen them between the toolbar and the heading.. I've seen them below the heading
13:52 cait             yeah
13:52 cait             since we have toolbar h1 now
13:52 cait             i believe right under is teh spot i prefer
13:52 cait             so it sits in a good view point right above the form/main content
13:54 cait             I am suggesting... we just need to agree on something consistent, that woudl be nice
13:55 ashimema         agreed
13:55 * ashimema       is trying to visualise..
13:55 ashimema         I think I was in the 'above everything' camp.. so it's the first thing your drawn to
13:55 ashimema         but I'm now wondering
13:56 cait             I usually like it better if the alert and what it applies to are closer together
13:58 cait             question: item search result list
13:59 cait             select visible roews and Edit search button
13:59 cait             shoudl they be within page-section or outside?
13:59 cait             my feeling is that select visible... belongs to the table... so inside, edit search not sure
14:05 * cait           summons oleonard
14:20 lukeg            cait++
14:26 cait             lukeg: did you see my question about item search?
14:26 cait             on here - not on bug yet
14:34 lukeg            cait: I did not
14:35 cait             I was wondering if on item searrch the select visible rows links and Edit search shoudl not be inside the page-section
14:35 cait             we ar trying to figure out some guidelines too: https://annuel.framapad.org/p/koha-styleguide-draft
14:36 cait             lukeg: ^^
14:38 lukeg            Hmm, good question, Maybe everything except the h1 should be in the page section?
14:38 ashimema         yuk
14:39 lukeg            Now I have to go look at some other pages
14:39 cait             been doing that yes
14:39 ashimema         that page is in need of cleanup in general I feel
14:39 cait             i thk the h1 outside is consistent now, so stuck that on the guidelines
14:39 lukeg            ashimema: item search page?
14:39 cait             ... and should edit search be yelllow?
14:40 ashimema         I would say it should be more similar to the catalog search results page..
14:40 cait             it's a quite different technique used there compared to other pages i think
14:41 cait             i sometimes bugs me I can't link to a search, I'd love that
14:41 ashimema         select stuff should be in a, preferably floating, toolbar
14:41 ashimema         for example
14:41 cait             oh right
14:41 cait             I'll file that - it came up last week at our wrkshop too (floating tool bar for item search)
14:41 lukeg            +1 floating toolbar
14:42 ashimema         there should also be a results count and we should display the search terms somewhere
14:42 cait             I feel after this redesign work I'll never look at Koha the same
14:43 cait             Bug 31915        - Add floating toolbar to item search
14:43 ashimema         doesn't appear to be paging either...
14:44 ashimema         in fact.. it's generally just really inconsistent with everywhere else.. lol
14:44 lukeg            It does
14:44 ashimema         nice one cait
14:44 cait             it might be the oldest implementation for server side stuff
14:44 ashimema         could be
14:44 cait             so it just might need to catch up
14:44 cait             and it does paging for me?
14:44 cait             the usual datatables stuff at the top of the table
14:45 ashimema         oh.. so it does
14:45 ashimema         ah.. yes..
14:45 cait             I think that<#s the issue right?
14:45 ashimema         it's dt style rather than search results style..
14:45 cait             it's a datatable...
14:45 cait             yeah
14:45 ashimema         wonder if we aught to make the cat search results look more consistent with dt style.. or the other way around..
14:45 cait             they both work vrey differently
14:45 ashimema         they're both really just big tables of stuff.. so paging that's consistent looking would be good
14:46 cait             one being search engine based and the other not... maybe some differences are ok
14:46 cait             but for now... inside our outside page section?
14:46 cait             i know we want a floating header ultimately.. but?
14:46 ashimema         they might work differently behind the scenes.. but they'd be trivial to style the same 😜
14:47 ashimema         outside if my opinion..
14:47 cait             heh I was inside
14:47 ashimema         leaving the door open for the toolbar next
14:47 cait             lukeg: you are tie breaker
14:48 lukeg            oh jeeze :)
14:48 cait             if it's too stressful I can switch sides
14:48 cait             i think ashimema kinda persuaded me
14:48 lukeg            Comparing it to catalog search, it seems like it should be outside of page-section
14:49 cait             PQA then :) moving onto next
14:50 cait             hm that seems to have been the last page-section one in QA queue
14:50 ashimema         🙂
14:50 cait             ashimema: are you actively working on 31886?
14:51 cait             ah, waiting for a follow-up
14:51 lukeg            I was working on 31886
14:51 ashimema         oh...
14:51 ashimema         I didn't mean to set myself for QA there.. I signed it off 🙂
14:51 ashimema         lukeg is doing a small followup though..
14:51 ashimema         but onces that's there I reckon it's a PQA if you want it 😛
14:52 lukeg            So should it be:
14:52 cait             yeah, i moved to fqa for now - nothing personal :)
14:52 cait             just so i don't keep running into that one until it's ready
14:52 lukeg            Serials - Features
14:52 lukeg            I18N - Global
14:52 lukeg            ?
14:52 cait             hm?
14:53 ashimema         works for me
14:53 lukeg            cool, revised patch incoming
14:53 ashimema         they're sorta meaningless at the moment really.. the prefs don't really lend themselves to being groups.. hence the loose suggestions.. but it looks better than having the same thing twice 😜
14:54 lukeg            agreed
14:54 ashimema         shall I open another bug for converting the 'You search for' away from being a heading?
14:54 cait             yes?
14:54 ashimema         okies
14:54 cait             if you wonder about filing a bug... isn't the answer always yes?
14:54 cait             :)
14:55 ashimema         it is unless someone decides to just do it inline 😛
14:55 cait             btw... this is slightly upsetting me: cataloguing/cataloging-home
14:56 cait             but... it makes sense as we agreed to use AE for new stuff ... and gah.
14:58 cait             inconsistencies now, whereever we look! :)
14:59 lukeg            Bug 31886 back in the NQA queue, I think tcohen can push it straight away if one of y'all can QA
14:59 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 normal, P5 - low, ---, lucas, Signed Off , No side menu when searching for syspref
15:00 cait             already applied here :)
15:02 cait             did we file about the wrong sidebar indentation on sstem preferences?
15:04 cait             ashimema: I am sticking your sign-off line to bug 31886
15:04 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 normal, P5 - low, ---, lucas, Signed Off , No side menu when searching for syspref
15:06 ShaneSammons[m]  Is there a character limit or something for the DAMAGED authorized values? I added some, but when I apply them on edit item, they don't save
15:07 reiveune         bye
15:08 Joubu            tcohen: 31154 - only the last 2 patches are needed
15:08 ShaneSammons[m]  Is this still IRC on the backend? I am using the website for now, going thorugh element and matrix
15:10 Joubu            ERM sandbox updated with the rebased branch and a couple of new enhancements ;)
15:11 ashimema         thanks cait
15:11 ashimema         and yes cait.. it bugs me having the mix of AE and BE.. i was going to handle it with the migration of controllers serverside.. it's a big job though ☹️
15:12 ashimema         and Shame Sammons we are indeed on a bridged matrix channel..
15:12 ashimema         you can use matrix features and other element/web users will see them.. but they get down converted for the IRC folk I believe...
15:12 ashimema         ShaneS: ^
15:12 ashimema         nice one Joubu!
15:13 ashimema         nice one Pedro (whose perhaps not on here right now?)
15:13 ShaneS[m]        Okay, I just see the same list of "People" I am used to from IRC, and just wanted to check that IRC still existed :)
15:14 ashimema         yup
15:14 Joubu            PedroAmorimpamorim[m]++
15:14 ashimema         🙂
15:15 cait             ShaneS[m]: it's limited to numbers
15:15 cait             for the codes
15:15 cait             same for Not for loan and some others, if you stick to numbers, it will work
15:16 Joubu            vendors list: https://snipboard.io/FzH759.jpg
15:16 Joubu            this looks bad, right?
15:16 ShaneS[m]        Thank you...I used letters...and didn't see a note here: https://koha-community.org/manual/20.11/en/html/administration.html#authorized-values I guess I could have checked the DB schema but I can't remember where that lovely field listing / mind mapping type view is/was
15:17 ashimema         terrible Joubu
15:17 ShaneS[m]        Let me switch to #
15:18 cait             ShaneS[m]: schema.koha-community.org
15:18 ashimema         it's stuff like that I requested the page-section stuff for Joubu..
15:18 ashimema         hence the huge number of bugs now adding page-section classes or divs
15:18 Joubu            bug 31918 - not really inspired for suggestions..
15:19 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31918 enhancement, P5 - low, ---, koha-bugs, NEW , vendor list is not displayed nicely
15:19 ashimema         loads already linked to bug 31757 Joubu
15:19 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 enhancement, P5 - low, ---, koha-bugs, NEW , Add 'page-section' where it's missing
15:20 * ashimema       roles up sleeves and considers working through acq
15:21 cait             get me the patches for the missing page-sections :)
15:21 cait             already have all the data set up
15:22 ashimema         is there already a bug for acqui-home?
15:22 ashimema         I can't see one
15:22 cait             yep
15:22 cait             look for acq start
15:22 cait             i just qa'd it earlier
15:23 ashimema         bug 31830
15:23 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 normal, P5 - low, ---, lucas, Pushed to master , Add page-section to budgets and funds table on acq start page (acq)
15:23 Joubu            when I am on acqui-home.pl, the nav menu is showing the item hovered by the pointer with a nice green label on the left of the element, and changing its background. However the behaviour in the "More" dropdown menu is to simply underline the selected items
15:23 Joubu            feels inconsistent
15:23 Joubu            just me or... should I open a bug report? Has it been discussed already?
15:24 cait             i don't think it has been discussed, but i'd like a colored background highlight instead of the underline
15:24 cait             please file :)
15:24 ashimema         lol.. I should have pulled
15:24 ashimema         now I see a better acq home
15:25 cait             ashimema: i went through the acq pages - there should be bugs for all of them (i hope)
15:27 cait             not patche sfor all yet I think
15:29 Joubu            bug 31919
15:29 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 normal, P5 - low, ---, koha-bugs, NEW , Hovered items in "More" should change background color
15:29 ashimema         hmm..
15:29 ashimema         that vendors list page is harder than I first thought..
15:35 tcohen           bbl
15:40 Joubu            new order page:
15:40 cait             filed already ;)
15:40 cait             at least if you mean the item form or several other things
15:40 Joubu            1. https://snipboard.io/2k6ImK.jpg - isn't supposed to be aligned?
15:40 Joubu            2. https://snipboard.io/c8AEjz.jpg - stat 2 misaligned?
15:41 Joubu            1 and 2 reported?
15:41 cait             yes, looking for it, sec
15:41 cait             bug 31819
15:41 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 major, P5 - low, ---, koha-bugs, NEW , Formatting of item form in acq when ordering is broken
15:41 cait             bug 31826
15:41 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826 normal, P5 - low, ---, koha-bugs, NEW , Add page-section to item form on order receive page (acq)
15:41 cait             i threw the stats into the first bug
15:42 cait             sorry, it's only the first bug actually, both
15:42 Joubu            https://snipboard.io/BF20lp.jpg - new vendor appearing there ok?
15:44 cait             yes, that was a last version's change
15:44 cait             it's intentional, not related to the new design
15:44 Joubu            ok
15:44 Joubu            weird
15:44 cait             oleonard added the toolbar to each entry
15:44 Joubu            the "clear date" icon is now green, expected?
15:45 cait             I'd say so
15:45 Joubu            sorry, I lost a bit of history lately :D
15:45 cait             that's ok :)
15:45 cait             bug 28082
15:45 Joubu            hummm "delete vendor" has no confirmation alert!
15:45 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082 enhancement, P5 - low, ---, oleonard, Pushed to master , Add acquisitions toolbar to vendors on vendor search page
15:45 cait             bug
15:45 Joubu            ho, first has, but it does not care about the answer, I clicked "NO"!
15:45 cait             haven't seen the 'delete vendor' one filed
15:46 cait             eww
15:47 cait             I got to leave here (in the office today) - bbl, but have a nice weekend all just in case!
15:48 Joubu            bug 31921
15:48 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 major, P5 - low, ---, koha-bugs, NEW , No confirmation alert when deleting a vendor
15:50 Joubu            tcohen: what's the selenium failure you asked me to look at earlier today?
15:55 Joubu            isn't this "washed green" ugly? https://snipboard.io/Nnab3I.jpg
16:03 lukeg            Joubu: IMHO, yes
16:03 ashimema         ha.. and that's the slightly "improved" one
16:05 ashimema         see bug 31753 for a comparison of options so far tried
16:05 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 enhancement, P5 - low, ---, oleonard, Pushed to master , Dialog boxes inside of modals don't seem wide enough
16:06 ashimema         https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142328
16:06 ashimema         in particular
16:06 Joubu            no color? :D
16:07 ashimema         lol
16:07 ashimema         I like having header/footer visually distinct
16:07 ashimema         I don't like the opac modals where we keep them the same colour as the rest of the modal personally..
16:08 ashimema         but finding the right green is ... hard
16:09 Joubu            We shouldn't need to find one, but use one that has been choosen when they discuss the new design
16:09 ashimema         and you think they did that 😜
16:09 ashimema         that is perhaps the far left option
16:09 ashimema         but it also had complaints about looking 'swampy'
16:10 Joubu            IIRC there was a palette of color somewhere
16:10 ashimema         must admit.. the original has kinda grown on me
16:10 ashimema         there was.. but it didn't include this color 😜
16:10 ashimema         or rather.. this element
16:10 lukeg            The original as in pre-redesign?
16:11 ashimema         nope.. that's post re-design still
16:11 lukeg            hehe, ok
16:11 ashimema         the three options in that above linked screenshot come from that bug.. the before, middle and after follow-up
16:12 ashimema         I asked for input, but didn't block the other fixes in the bug.. tomas pushed with my followup
16:12 ashimema         I'm more than happy for people to have another go ;P.. or to restore the pre patch fix.. it's easier now that oleonard made it a variable
16:15 ashimema         just remember when you do play you need so consider title and link texts for contrast..
16:15 Joubu            how do I modify the variable from the browser's console?
16:15 ashimema         it's what I was scratching my head over this morning.
16:16 ashimema         er.. variables get compiled.. assuming you mean the css stuff I was talking about..
16:16 Joubu            yes, the background-color-modal
16:16 ashimema         just just edit the css rule directly in the browser.. then much with the variable to hit all cases for submission
16:16 Joubu            I don't see the background-color css rule
16:16 ashimema         .modal-content {
16:16 ashimema         background-color: rgb(211, 223, 204);
16:16 ashimema         background-color:
16:17 Joubu            ha! I was on .modal-header
16:18 ashimema         gotta go cook.. biab
16:19 Joubu            gotta go drink a beer, have a great weekend #koha!
16:30 lukeg            cheers :)
16:31 cait             back
17:16 caroline         cait, your libraries aren't up to 21.11 yet right?
17:51 cait             not yet no
17:51 cait             might jump to 22.11 directly
17:51 cait             are you having any trouble?
17:54 caroline         not yet, but I'm dreading bug 24387 so I was wondering if you had had to correct your stuff and if so how
17:55 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 enhancement, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, Rename News tool
17:55 caroline         I'm trying to prevent having to do it manually since we have ~60 instances
18:01 caroline         Anyway, once I determine what I'll do, I'll share it
18:02 ashimema         We should work together on fixes..   there's never enough time for everything though
18:02 ashimema         What not ask your dev team to help squash the issue and work through it with them..then submit it up caroline
18:03 caroline         My colleague will help me definitely, I still have to determine what needs to be done
18:12 philor_          is there an easy way to get to the revision before a patch from a particular bug landed?
19:32 cait             sorry caroline - getting lat ehere, i got distracted
19:32 caroline         no worries
19:32 cait             just made some fresh tea.. so I might at least finish reading today's bug mail
19:33 cait             philor: can you explain a bit more? I am not sure what you mean
19:34 philor           cait: I found a workable solution, if not elegant, but what I meant was "I'm pretty sure bug 30280 broke something, but I want to locally check out the revision just before it landed, to make sure it was working then and broken as soon as it landed"
19:34 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 enhancement, P5 - low, ---, frank.hansen, Pushed to master , Support authority records with common subject headings from different thesaurus
19:36 philor           which it was, so the bug is in your bug mail :)
19:39 cait             oh no...
19:39 philor           so many twisty paths through linking
19:40 philor           I was trying to file the one I know will exist, about AutoCreateAuthorities creating duplicates because it only creates LCSH records, when I discovered that without linking working, it can't yet be broken
19:43 philor           hmm, or maybe linking is only broken on Zebra, and Elasticsearch+AutoCreateAuthorities does create infinite duplicates?
19:44 cait             sorry, I don't know
19:44 cait             i tested that one and it seeme dto make things stricter but correct in terms of standard and MARC
19:45 * philor         tries a ByWater sandbox for elastic
19:46 philor           someday, I really need to figure out why I can't make it work locally
20:16 philor           not sure what made me think the ByWater sandboxes default to Elasticsearch, though
20:18 caroline         philor, I think they have both and you can just change the syspref
20:24 caroline         ok so trying to figure out what the dbrev for bug 24387 does... I have an instance with 4 'OpacMainUserBlock' news, two fr-CA and two in en. After the update, I have 6, four 'default' and two 'fr-CA'
20:24 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 enhancement, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, Rename News tool
20:25 caroline         it looks like it doubled the fr-CA ones, but the en ones were just changed to default
20:29 caroline         I think the default was added because the preview didn't work otherwise... Is it necessary other than that?
20:49 lukeg            caroline: Ive seen that same problem fairly often
20:50 lukeg            caroline: do you know where I can find a list of installable language packs for Koha?
20:50 caroline         lukeg, oh did you have problems when updating too? I thought it was only installs with multiple languages that had problems
20:51 lukeg            i know I can run koha-translate --list, but that just gives me the codes and I can't always determine the language from the code
20:52 caroline         lukeg, not sure... I would probably check on the translation site https://translate.koha-community.org/projects/22.05/
20:52 lukeg            Ive seen that problem, and it is when we upgrade and their are multiple language packs installed. I'll end up with a bunch of extra OPACMainUserBlocks, OPACHeaders, OPACCredits, etc..
20:53 caroline         yep, that is the exact problem I'm trying to avoid!
20:54 caroline         I'm trying to see if there is something I can do *automatically* either before or after the upgrade to avoid having manual changes to do
20:54 lukeg            Yea, it is a pain. And I'm pretty sure you are looking at the right DB update. There is a lot in that one and I don't understand all of it
20:55 caroline         I wonder if we just remove the creation of the default if it will affect anything. I'm not sure what the default is for. You either have your OPAC in one language or the other
20:55 caroline         Maybe if you want something to appear on both, like an image with no text, but in the case of the upgrade, you couldn't have that before
20:56 caroline         so I don't think it makes sense to create a default...
20:56 caroline         I'm still thinking about it
20:58 lukeg            I almost exclusively use the default, but that is because we have so many partners without additional language packs installed
21:00 caroline         ok so for unilingual installations, would you need the default? Or would english only be ok too?
21:03 lukeg            I think English would be fine too, but since everything just defaults to Default, I leave it there.
21:03 lukeg            Defaults to default... ha
21:04 lukeg            But I am thinking there are other reasons to have default, maybe a smarter developer than I can chime in on that...
21:05 caroline         For the new content, you can use default, but for the upgrade from the news I think en would be fine
21:05 caroline         It's really just the upgrade that is problematic... The feature itself is fine
21:12 caroline         I added a comment to bug 24387 with my thoughts... I will talk with my colleague next week and see what we can do and I will try to remember to share it
21:12 huginn`          Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 enhancement, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, Rename News tool
21:38 tuxayo           hi koha :)