Time  Nick         Message
03:39 tuxayo       Does anyone understands Bug 28998 and how is borrowers.secret decrypted? Koha can do it in fully autonomy, can't it? Then what is the security gain in case of data breach?
03:39 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 enhancement, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, Encrypt borrowers.secret
04:22 tuxayo       Daylight saving time is a nightmare when making polls for dates of events across the globe. I can't just put «13h-20h London/ 8h-15h US East/5h-12h US West / 14h-19h Paris» in every possible day. Because there can be a DST change in the middle of the date range. And countries don't all change at the same time 🤯
04:30 tuxayo       @later tell JesseM Who is best to reach at ByWater to ask to relay my patch testing session messages to librarians among your customers that would be the most prone to test patches. Who knows them best?
04:30 huginn`      tuxayo: The operation succeeded.
04:35 tuxayo       @later tell kidclamp Who is best to reach at ByWater to ask to relay my patch testing session messages to librarians among your customers that would be the most prone to test patches. Who knows them best?
04:35 huginn`      tuxayo: The operation succeeded.
06:27 fridolin     hi
06:38 reiveune     hello
06:38 wahanui      salut, reiveune
06:42 ashimema     Morning
06:44 ashimema     tuxayo the idea of bug 28998 is to prevent someone who just had the database from having all the secrets.  Encryption/Decryption requires the key too
06:44 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 enhancement, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, Encrypt borrowers.secret
07:10 alex_        Bonjour
09:39 ashimema     hmm
09:39 ashimema     anyone else pulled master and found koha inoperable this morning
09:40 ashimema     weird.. apache had blown up
09:53 ashimema     next question.. anyone else finding moremember 500's on master this morning
10:13 cait2        haven't been on master yet today... but consider not pulling now until you guys got that sorted? :)
10:13 cait2        was also expecting a flurry of page-section patches hm.
10:13 ashimema     I have some weird data things going on it seems
10:13 ashimema     sysprefs that are incorrect and things.. very confused
10:17 ashimema     hmm.. it's almost like that last db update deleted a bunch of unrelated systempreference rows
10:17 ashimema     very strange
10:34 kidclamp     tuxayo: you could reach out to jzairo, she could point you in the right direction
10:57 oleonard     Here's the error I got from master just now: "Auth ERROR: Cannot get_session() at /kohadevbox/koha/C4/Auth.pm line 964"
10:57 oleonard     I had to delete my cookies
10:59 oleonard     ... and a JavaScript error breaking the patron search
11:01 oleonard     Hm.... working after a reset_all...
11:05 tcohen       hola #koha o/
11:11 cait2        ashimema: that doesn't sound good - are you still investigating?
11:13 ashimema     oh. didn't realise you were having issues too oleonard
11:13 * ashimema   suspects he's not getting all messages again ☹️
11:14 oleonard     I've started everything over. Importing my test db and I'm getting this message 1000s of times: Unrecognized marcflavour:  at /kohadevbox/koha/C4/Charset.pm line 357.
11:14 * cait2      hopes it was nothing she QA'd....
11:14 ashimema     Yeah.. I'm seeing a bunch more warnings in the logs today
11:14 ashimema     I'm mostly back up and running though now at least
11:14 ashimema     but the warnings are surprising
11:16 oleonard     I guess that message was from the Zebra reindex
11:33 oleonard     updatedatabase is choking on my test db
11:34 tcohen       oh
11:34 tcohen       master?
11:34 wahanui      i think master is the WIP version. In May, whatever is in the master will become version 19.05 and we'll continue to work on it for the 19.11 version
11:34 pastebot     "oleonard" at 127.0.0.1 pasted "Output from updatedatabase" (5 lines) at https://paste.koha-community.org/17028
11:35 tcohen       oleonard: looking
11:35 tcohen       thanks
11:37 pastebot     "tcohen" at 127.0.0.1 pasted "root@kohadevbox:koha(master)$" (8 lines) at https://paste.koha-community.org/17030
11:41 tcohen       it is not picking the koha version so trying to run from the first line in updatedatabase
11:47 tcohen       there must be some magic trick with number 64
11:47 tcohen       cannot find why it is setting the Version syspref to NULL
11:47 marcelr      hi #koha
11:47 tcohen       it must be marcelr's fault
11:47 tcohen       o/
11:47 marcelr      hey
11:47 marcelr      is it my fault again :)
11:48 tcohen       can you repeat this steps, marcelr?
11:48 marcelr      which steps
11:48 tcohen       git reset --hard 1a1529d20572c8eb7e65ad7bbd41f688d5f86f07 # arbitrary old commit
11:48 tcohen       reset_all
11:48 tcohen       git reset --hard origin/master
11:48 tcohen       updatedatabase
11:48 wahanui      updatedatabase is probably choking on oleonard's test db
11:49 marcelr      let me see
11:49 marcelr      starting a fetch.
11:49 marcelr      20 commits coming
11:49 marcelr      C4::Installer::SetVersion(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry 'Version' for key 'PRIMARY' at /usr/share/koha/C4/Installer.pm line 777
11:50 tcohen       exactly
11:50 tcohen       perl -MKoha -e 'print Koha::version();'
11:50 tcohen       works
11:50 marcelr      bug_number  => "14783", ?
11:51 tcohen       yes
11:52 tcohen       I don't think it reaches it
11:52 marcelr      looking
11:52 tcohen       thanks
11:52 * tcohen     looks at canasta for thd
11:55 marcelr      this looks bad:             UPDATE systempreferences SET value = (SELECT CASE WHEN value = 1 THEN 'intransit' ELSE '' END             FROM systempreferences             WHERE variable = 'OPACInTransitHoldPickupLocationChange')
11:56 marcelr      it cleared the Version
11:56 marcelr      always wonders how it was tested :)
11:57 tcohen       doesn't look bad to me
11:57 tcohen       and the fact a bad db_rev can clear the version syspref is another bug!
11:58 marcelr      no the sql is bad
11:59 marcelr      it is an update over the whole table
11:59 marcelr      all sysprefs are gone GONE
11:59 tcohen       haha
11:59 marcelr      really all are blank
11:59 tcohen       I was wondering why I couldn't see the WHERE
11:59 marcelr      why did you push it ?
12:00 marcelr      you failed my patch ;)
12:00 ashimema     aha..
12:00 ashimema     that would be why I had loads of issues this morning too..
12:00 marcelr      these RMs today
12:00 tcohen       patching
12:00 ashimema     but I couldn't spot which db_rev did it.
12:00 marcelr      i need a RM freeze
12:00 marcelr      lol
12:01 ashimema     it's a nested WHERE.. I see it now
12:01 ashimema     well spotted
12:01 oleonard     oooh someone just volunteered to be RM for 23.05 ;)
12:01 marcelr      hmm dont like to spot these things
12:02 marcelr      oleonard for president :)
12:03 tcohen       we still have the selenium tests issue
12:03 oleonard     If I'm president can I compel marcelr to be RM?
12:03 tcohen       if you're feeling lucky, marcelr
12:04 marcelr      no luck today
12:04 ashimema     that db update is weird.. I have no idea what pref it's trying to update
12:05 tcohen       OPACAllowUserToChangeBranch
12:05 tcohen       it adds a syspref, then sets it using the old one, which gets deleted
12:05 tcohen       I pushed a patch
12:05 marcelr      great i just merged two mins too quick :)
12:06 marcelr      but i will have clean data again..
12:06 tcohen       I think the indentation I used when converted the db_rev made it even less clear and why I didn't spot it as well
12:06 marcelr      np
12:06 marcelr      how should we have solved that after a worldwide backport ?
12:07 tcohen       well, that's why we have a dev branch
12:08 marcelr      it certainly gives you a new clean pickup location, haha
12:09 tcohen       hahahaha
12:09 tcohen       very clean
12:10 tcohen       marcelr: do you agree it is weird how the output is being buffered?
12:11 tcohen       we moved ~500 commits back, reset_all, back to master HEAD, did the updatedatabase thing
12:11 tcohen       and only got the last db_rev error printed
12:11 marcelr      i just came from 20 commits back
12:12 marcelr      so i didnt see that
12:12 pastebot     "tcohen" at 127.0.0.1 pasted "This is what I see now it is fixed" (33 lines) at https://paste.koha-community.org/17032
12:13 tcohen       https://paste.koha-community.org/17030
12:13 tcohen       ^^ that one with the error on the last db_rev
12:14 tcohen       weird == wrong
12:15 marcelr      did you really come from 500 commits back then?
12:15 marcelr      or did you already test and was the version clean already?
12:16 tcohen       git reset --hard 1a1529d20572c8eb7e65ad7bbd41f688d5f86f07
12:16 marcelr      examine this to the bottom tcohen
12:16 tcohen       reset_all
12:17 tcohen       git checkout master
12:17 tcohen       updatedatabase
12:17 wahanui      updatedatabase is choking on oleonard's test db
12:17 tcohen       that's the secquence I followed
12:17 tcohen       marcelr: I don't have the bandwidth right now
12:18 marcelr      yeah lets just say it never really happened, and send an invoice :)
12:30 tcohen       just so we don't forget: bug 31855
12:30 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31855 normal, P5 - low, ---, koha-bugs, NEW , Installer output buffering can be confusing
12:35 oleonard     Ugh... Seeing Bug 31839 in production today :(
12:35 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31839 normal, P5 - low, ---, koha-bugs, NEW , Error when viewing bibliographic details of record with local cover
12:37 marcelr      production_bugs--
12:38 marcelr      tcohen: i tested the onboarding process and it works great
12:40 marcelr      enjoying a clean list of branches without these TestBuilder garbage
12:40 tcohen       lukeg oleonard are you working on the page-section stuffs?
12:40 tcohen       can you please cc me on those?
12:41 tcohen       ashimema: are you joining that party?
12:41 ashimema     🙂
12:41 ashimema     yup
12:41 ashimema     slow but sure
12:42 ashimema     rebasing a few things first then will jump on a few.
12:42 oleonard     tcohen: I did a couple, not currently working on that
12:42 tcohen       thank y'all
12:53 thd          tctcohen: When might you have time to confer about MediaWiki Canasta?  I have to go out for a period today and have a dentist appointment tomorrow but have some time before and after.  I understand that there are always more pressing bugs etc. :)
12:54 tcohen       thd: the wiki is high priority
12:54 tcohen       pm
12:55 thd          OK.
13:01 marcelr      @later tell Joubu it seems that action is reserved, not actions (bug 31842)
13:01 huginn`      marcelr: The operation succeeded.
13:04 magnuse      bug 31842
13:04 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 normal, P5 - low, ---, m.de.rooy, Passed QA , admin/branches: DT search generates js error on col.data.split
13:12 kidclamp     bug 31421
13:12 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 critical, P5 - low, ---, nick, Signed Off , Library limitation on patron category breaks patron search
13:12 kidclamp     That one could use some attention
13:22 marcelr      you could call that a limitation
13:28 kidclamp     heh
14:08 cait2        oleonard: ashimema: waht do you think about a interface bug fixing spree on Friday?
14:08 ashimema     sounds like a great idea o me
14:10 cait2        lukeg: maybe you are interested too? :)
14:14 ashimema     bug 31095 now back in the queue
14:14 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
14:17 lukeg        cait2: Yes, Id love to help
14:18 * ashimema   loves the Folio codenames...  does 'Morning Glory' not mean the same thing in the US ?
14:19 * ashimema   saw that float by in his slack and nearly chocked on his tea 😛
14:19 ashimema     lukeg++
14:19 cait2        they are all plants/flowers I think
14:19 cait2        lukeg: i think togehter we could really quickly take care of the page-section stuff for example
14:19 ashimema     [off] Indeed.. but it also has a rather more crude meaning in the UK
14:20 cait2        oh
14:20 ashimema     🍆
14:46 marcelr      ashimema: we have a code of conduct here
14:51 cait2        and with that... he leaves heh
14:51 ashimema     lol
14:51 ashimema     indeed
14:59 cait2        btw... someone good with Koha's SRU?
14:59 cait2        I might have questions.... already have some, but hope to resolve most of them myself :)
15:27 oleonard     I hope y'all will be happy with Bug 31754
15:27 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 normal, P5 - low, ---, oleonard, Needs Signoff , Improve appearance of behavior of DataTables controls
15:33 lukeg        oleonard: Im trying to test but patron searching in master is giving me a 404 dataTables error right now. Is that happening for you?
15:34 oleonard     Sorry lukeg I should have marked it dependent on Bug 31842
15:34 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 normal, P5 - low, ---, m.de.rooy, Passed QA , admin/branches: DT search generates js error on col.data.split
15:34 lukeg        ah ha, ty!
15:40 reiveune     bye
18:35 tcohen       thd++
18:38 tcohen       thd++
19:03 bag          tcohen++
19:08 tcohen       thd++
19:09 tcohen       ashimema++
19:09 tcohen       cait++
19:10 tcohen       loup++
19:10 tcohen       marcelr++
19:10 tcohen       khall++
19:10 cait         loup++
19:10 tcohen       kidclamp++
19:10 cait         karma fest?
19:10 wahanui      fest has neutral karma
19:10 cait         bag++
19:10 tcohen       mtj++
19:10 tcohen       mtj++
19:10 cait         tcohen++
19:10 tcohen       bag++
19:10 cait         mtj++
19:10 cait         thd++
19:10 cait         kidclamp++
19:10 tcohen       the RM is happy, for many things
19:10 cait         ashimema++
19:10 ashimema     tcohen++
19:10 tcohen       caroline++
19:10 tcohen       davidnind++
19:10 cait         caroline++
19:11 cait         davidnind++
19:11 ashimema     team++
19:11 tcohen       koha++
19:11 tcohen       team++
19:11 cait         community++
19:11 cait         qa_team++
19:12 tcohen       qa_team++ # of coures
19:12 tcohen       lukeg++
19:12 tcohen       :-D
19:12 tcohen       ok
19:12 caroline     tcohen++ happy RM, happy life, isn't that the saying? :)
19:12 tcohen       ROTFL
19:12 cait         lol
19:13 tcohen       gonna get some tea and prepare to leave
19:13 tcohen       see y'all
19:13 tcohen       thd++
19:17 oleonard     lukeg around?
19:19 cait         not lukeg, but around for a bit
19:20 oleonard     I was hoping he would tell me if there's any particular page he's seeing Bug 31857
19:20 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31857 enhancement, P5 - low, ---, koha-bugs, NEW , Modal header text/background color does not have enough contrast
19:20 cait         hmm
19:20 cait         is hte color code the light green one?
19:21 cait         I ha
19:21 cait         e
19:21 cait         v
19:21 cait         sorry, my hand fell asleep
19:21 cait         I have seen these modals in circ  - hold found
19:22 oleonard     Oh I think I see... the contrast fails for normal text, but not for large text.
19:22 oleonard     Firefox's dev tools must be judging the heading to be large text (and I agree)
19:22 cait         ah, interesting and good to know that the font size plays a role
19:22 cait         I am really tempted to ask if we can increase the smallest font size... because it feels really small still
19:23 cait         I've made a bug for the font size in search bar (right size) but also the news feel small
19:23 cait         (right side)
19:24 oleonard     The modal currently looks like this: https://snipboard.io/pUTM8Q.jpg
19:24 oleonard     I've got a patch to update it to this: https://snipboard.io/LPtBA6.jpg
19:25 cait         I like the new green
19:25 cait         just noticing - the () are grey, but the text is black
19:25 cait         one color is also better
19:26 cait         +1
19:26 cait         I'll go look at bug 31754
19:26 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 normal, P5 - low, ---, oleonard, Signed Off , Improve appearance of behavior of DataTables controls
19:27 oleonard     The difference in color in the first screenshot is because the links have black text, the plain text is gray
19:29 oleonard     I don't think I agree with the new style of links in headings being black
19:29 cait         hm yeah
19:30 cait         links should be visible somehow
19:30 cait         but i have the same issue with the toolbars... not sure grey is a good color for clickable
19:30 cait         it didn'T occur to me in neither screnshot that I could click on it
19:30 cait         (the barcode)
19:31 cait         oleonard: i have another question: why are the table thingies buttons in the checkouts table
19:31 cait         should I file that?
19:32 oleonard     ?
19:32 cait         if you go to patron account > checkouts
19:32 cait         columns export an dconfigure are buttons
19:32 cait         on the left
19:32 cait         instead of icon + text link on the right
19:34 oleonard     Hm... I think my patch for Bug 31754 doesn't keep the controls on the right. I should revised it.
19:34 huginn`      Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 normal, P5 - low, ---, oleonard, Signed Off , Improve appearance of behavior of DataTables controls
19:34 oleonard     I have to go though, time for me to quit.
19:34 oleonard     See y'all later.
19:34 cait         maybe I'll with a screenshot
20:24 cait         davidnind[m]: hard to keep up with you :)
20:34 davidnind[m] hard to keep up with all the bugs for sign off - everyone is so busy fixing/improving things!
22:42 davidnind[m] should changing a language (fro example fr-CA) result in titles of records not displaying in staff interface and OPAC?
22:42 davidnind[m] this means there is no link to the details page (have done a reindex)
22:42 davidnind[m] not sure whether this is a result of the new staff interface or something else...
23:46 tuxayo       fridolin around?
23:47 tuxayo       If your Dutch isn't too rusted, do you know where in this site could be a mailing list or a forum? ^^"
23:47 tuxayo       https://kohagebruikers.nl/
23:47 tuxayo       It's the NL/BE Koha user group
23:52 tuxayo       After using a dictionary there doesn't seem be a communication channel listed.
23:54 fridolin     yellow there ;)
23:54 fridolin     oh, means Koha users
23:55 fridolin     i cant find a ML
23:55 fridolin     but this group contains Rijksmuseum
23:56 fridolin     you can ask Marcel i bet
23:56 fridolin     Saxion poeple are very nice, they work hard on translations
23:58 fridolin     Here you can see a linked in profile https://translate.koha-community.org/user/RonaldWijlens/
23:59 tuxayo       fridolin: Marcel linked me to this site ^^
23:59 tuxayo       > i cant find a ML
23:59 tuxayo       Ah ok, I'll ask
23:59 tuxayo       Marcel cc me someone from Saxion and Antwerp museums