Time Nick Message 00:00 mtj Search::Elasticsearch::Client::6_0 00:00 mtj Search::Elasticsearch::Client::7_0 00:01 mtj so, if you are using ES6 on deb11, you are using libsearch-elasticsearch-perl (7.30-1) 00:01 mtj https://packages.debian.org/bullseye/libsearch-elasticsearch-perl 00:02 mtj ..which means you are calling ES6 from the Search::Elasticsearch::Client::7_0 module 00:02 tuxayo mtj is there compat? 00:03 mtj it *seems* to be compatible, but thats just luck, (at the moment) 00:03 tuxayo > users are supposed to set their ES version 00:03 tuxayo IIUC from your last info, yes there is compat but it's not automagic 00:04 mtj Elasticsearch::Client::7_0 code seems to work with ES6 00:04 mtj newer versions may break etc 00:04 tuxayo Ah yes, since ES 6 is EOL 00:05 mtj deb10/buster uses an older v6.00 version 00:05 mtj https://packages.debian.org/buster/libsearch-elasticsearch-perl 00:05 mtj libsearch-elasticsearch-perl (6.00-1) 00:05 tuxayo Can we stay on a fixed version in our repo to have both ES 6 & 7 support without config need? 00:05 tuxayo And change version when dropping ES 6 00:05 wahanui tuxayo: that doesn't look right 00:06 tuxayo wahanui: lol, that looked a legit relevant answer to the context 00:06 wahanui tuxayo: sorry... 00:06 mtj its probably possible to get the ES version, from ES itself 00:07 mtj ..rather than setting it in a config file 00:07 tuxayo Yes, in bug25669 it was discussion but it would be some more work to not spam version requests. 00:07 tuxayo *it was discussed 00:07 mtj we could package/install both *::client versions 6 and 7 00:08 mtj ..and have some clever code to use the correct *::client version 00:08 tuxayo But still need a config switch or a version check. 00:08 mtj but, its also a bunch of extra work :) 00:09 tuxayo We might not avoid a version check soon depending on how much ES and OpenSearch diverge. So I might be worried for nothing. 00:09 tuxayo And would better hurry up submitting patches to koha-elasticsearch-icu to have OS 2.X and check if it works 00:13 mtj considering ES6 is unsuported from feb 2022, do we really want to encourge people to continue to use it? 00:13 mtj answer = no 00:17 mtj anyhoo, if someone works out some code to get the ES version from ES, we can have both versions 00:19 tuxayo > do we really want to encourge people to continue to use it? 00:19 tuxayo Forcing to switch to ES 7 is forcing to switch to a non-libre dependency. 00:19 tuxayo It seems OpenSearch 1.x works though. 00:22 mtj aah, i had forgotten about the ES license change 00:22 mtj its ES 7.11 with the new license, it seems 00:22 tuxayo yes 00:23 tuxayo > if someone works out some code to get the ES version from ES, we can have both versions 00:23 tuxayo To get it was already done in a proposal. But the additional work is to not spam it and impact perf. Or to do actual testing to confirm it's an issue. (maybe we complicated the issue a lot without a reason ^^" ) 00:23 tuxayo https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130288&action=diff#a/Koha/SearchEngine/Elasticsearch/Indexer.pm_sec2 00:25 mtj lets use memcache to store the ES version 00:27 mtj ok patch looks good :) 00:27 mtj problem solved 00:27 tuxayo > lets use memcache to store the ES version 00:27 tuxayo oh it's that simple 🤦 00:28 mtj if someone installs a new ES version, they will have to restart memcache :) 00:28 mtj ..and pet a kitten 🱠00:28 tuxayo > ok patch looks good :) 00:28 tuxayo > problem solved 00:28 tuxayo Then the fear of perf issues was raised and memcache wasn't mentioned directly. So that patch version didn't end up merged. 00:29 tuxayo > if someone installs a new ES version, they will have to restart memcache :) 00:29 tuxayo Of course. 00:30 tuxayo Gotta go, thanks mtj for the info. I'll keep that I mind when ES & OS versions topic comes up again. 00:30 mtj we will have to ignore the koha.conf ES setting 00:31 mtj ok, cya tuxayo 00:31 tuxayo > we will have to ignore the koha.conf ES setting 00:31 tuxayo ? If someone implement version checks? Yes indeed. 04:04 dcook Looks like 40 authors is the most we've ever had in 1 month.. 04:05 dcook Looks like it's usually between 20-40 people.. 05:50 domm[m] mtj: Thanks for the info regarding ElasticSearch 7! 06:00 dcook Of course I have to run just as the Europeans are coming alive hehe 06:08 domm[m] at least your now moving onto spring & summer :-) 06:08 ashimema Man it's misty/foggy here 06:09 ashimema Morning 06:29 marcelr hi #koha 06:30 marcelr a new look on staff ! 06:33 marcelr bug 31743 needs a signoff ! 06:33 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off 06:33 marcelr simple patch 06:34 reiveune hello 06:34 wahanui salut, reiveune 06:34 marcelr hi reiveune 06:49 alex_ Bonjour 07:05 marcelr bonjour alex_ 07:18 alex_ Hello marcelr 08:30 ashimema ooh.. 08:41 marcelr hi ashimema 08:41 ashimema morning 08:41 marcelr did you still have bug 30588 on your radar ? 08:41 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Add the option to require 2FA setup on first staff login 09:00 ashimema ah yes.. I do 09:00 ashimema so many bugs 😚 09:19 ashimema ooh... was it deliberate to switch the front page icon/buttons back in the staff client ui? 09:20 ashimema I liked the ones that are still present in the circ home page now 09:38 AnkeB Good morning everybody. I just realized there seems to be a dead link when clicking Help from the staff client's Global System Preferences Page in V22.05. This applies to German and English language. Is this a known bug? Should I file a bug? 09:39 ashimema I think it's a know bug.. I fixed some things there and I'm not sure the patch has been backported yet.. 09:42 AnkeB Thanks, can you give me the bug id or a hint what I could search for in the bugs? 09:43 * cait1 waves 09:44 cait1 I thnk martin wat thinksing of bug 31465 09:44 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465 trivial, P5 - low, ---, martin.renvoize, Pushed to master , Link system preference tabs to correct manual pages 09:45 ashimema bug 31465 09:45 cait1 what does the broken link look like? 09:49 ashimema man I need some coffee 09:51 * marcelr sends 3 liter to ashimema 09:51 cait1 that might be overdoing it.... 09:51 marcelr oops 09:52 marcelr why do I always forget that $dbh->do only wants 1 statement ;) 09:56 AnkeB Hm, bug 31465 is marked as pushed to master, shouldn't it be correct then in a recently installed 22.05? 09:56 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465 trivial, P5 - low, ---, martin.renvoize, Pushed to master , Link system preference tabs to correct manual pages 09:57 marcelr bbl 10:30 AnkeB I see now that bugfix for 31465 was pushed to master for 22.11. So in 22.05 it's not yet working. 10:30 oleonard Hi all 10:43 ashimema Correct AnkeB.. it needs backporting 10:43 ashimema morning oleonard.. 10:43 ashimema lots of bugs to fix today 😛 10:49 AnkeB ashimema I just corrected the lines manually in my Manual.pm. But it would be good to have the correction in 22.05, if anyone cares to do it :-) 10:58 tundunf hi all! 11:06 ashimema Hi tundumf 11:06 ashimema it's in the rmaints queue AnkeB 11:06 ashimema they just haven't gotten to it yet. 11:42 ashimema sorry oleonard ... I'm throwing lots of little bugs your way this morning for opinions and final fixes 🙂 11:48 marcelr o/ 11:52 oleonard No problem ashimema it is to be expected 11:57 ashimema 🙂 11:57 ashimema team effort now 12:06 ashimema sorry for all the noise jajm 12:07 jajm i like that kind of noise :) thank you for that 12:07 ashimema : ) 12:34 ashimema well.. I'm filling up the Academy queue. 12:38 tuxayo AnkeB: hi :) Happy to see you hanging around here. Just when I'm doing a patch testing session with french speakers ^^ (attendance of 1 for now...) 12:58 ashimema I was contemplating putting a call out on the main lists for people wanting to get their names in the release notes.. loads of easy academy ones now 12:59 ashimema Just add a class (or div with class in some cases) 13:00 tuxayo That could motivate a few :) 13:01 tuxayo Own name + institution name. 13:20 ashimema indeed 13:27 ashimema done 13:31 AnkeB tuxayo: Hopefully some more people attended meanwhile. Have fun 13:42 tuxayo ashimema++ nice email 13:42 tuxayo AnkeB: there is still time, in parallel I can still catch up on other stuff 13:56 Pascal Hello, today we tried for the first time to use the --where extension of membership_expiry.pl ( https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 ). Using it for example with borrowernumber works, but when I use it the same way with the categorycode I always get an error. Although the categorycode actually exists. Can anyone here reproduce this error? 13:56 huginn` Bug 28456: enhancement, P5 - low, ---, nick, CLOSED FIXED, Add option to use a WHERE statement in membership_expiry.pl cronjob 14:23 marcelr bug 31775 is ready for testing :) 14:23 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Show opac_info of single library 14:23 marcelr small regression 14:23 marcelr bbl 14:46 tcohen marcelr++ # taking care of bugs 14:54 ashimema hummm 14:54 ashimema oleonard the scroll to position bit of bug 23410 appears to be broken?# 14:54 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23410 enhancement, P5 - low, ---, oleonard, CLOSED FIXED, Add submenus to system preferences sidebar menu 14:55 ashimema i.e. search for a pref, click the 'View all X preferences' link.. it opens the right page/tab, but doesn't scroll the page to subsection. 14:55 ashimema hugs 14:56 ashimema @later tell oleonard the scroll to position bit of bug 23410 appears to be broken? 14:56 huginn` ashimema: The operation succeeded. 15:18 tuxayo nugged: bug 29012 hasn't actually been released. No need for a releasable data fix. I hope it's not too hard to manually fix on your test libraries. 15:18 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 major, P5 - low, ---, kevin.carnes, Pushed to stable , Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl 15:18 tuxayo nugged++ good job on finding it out before it has been released 15:19 tuxayo (finding that it causes a regression) 16:20 ashimema cait around? 16:20 wahanui cait around is cait cait1 cait2 cait3 cait4 cait5 16:22 nugged tuxayo: 16:22 nugged > bug 29012 hasn't actually been released. 16:22 nugged I acted on as released because "Backported to 22.05.x for 22.05.06" was said there and it was in 22.05 "crude" branch. But if it is delayed and not in .deb for the people - ok then we can just re-do both 29012 and 31727 as single solution without "changing and fix-changing" DB twice because even fix becomes very complicated too and probable of "false positives/even more regressions". 16:22 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 major, P5 - low, ---, kevin.carnes, Pushed to stable , Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl 16:23 nugged tuxayo: if you or others won't let it go into 22.05 then it's better to never run that atomic update in old (current) version 16:24 tuxayo nugged: 16:24 tuxayo > I acted on as released because "Backported to 22.05.x for 22.05.06" 16:24 tuxayo The phrasing we use is confusing. We should say something like "for the upcomming 22.05.06" 16:24 tuxayo > But if it is delayed and not in .deb for the people - ok then we can just re-do both 29012 and 31727 as single solution 16:24 tuxayo yes, it's simpler! 16:25 oleonard ashimema: I noticed that too about the prefs links 16:26 tuxayo I'm immediately changing my phrasing when backporting stuff for oldoldstable and will tell the others RMaint to do the same. Sorry that it triggered unnecessarily work. 16:29 tuxayo nugged: Would that be good enough? «Backported: Pushed to 21.05.x branch for the upcoming release (21.05.19)» 16:32 tuxayo > if you or others won't let it go into 22.05 16:32 tuxayo Indeed, won't happen lukeg and liliputech should revert it soon from 22.05 and 21.11. So it won't be released. 16:32 ashimema is it a staff client ui refresh bug.. or did it happen before that was pushed.. 16:32 ashimema I'm not sure. 16:32 oleonard ashimema: before 16:32 ashimema ah.. okies 16:33 ashimema well.. I've added another follow-up to the option 2 on that sysprefs page-section bug.. 16:33 ashimema it comments out the css.. in case we still need it when we fix scrolling.. 16:33 ashimema no sure how to proceed there really. 16:33 ashimema and.. with that.. it's time for me to clock of for the evening.. 16:33 ashimema kids calling 16:33 ashimema byeeeee 16:36 nugged tuxayo++ 16:36 nugged tuxayo: so: should we change 29012 status to WONTFIX or INVALID and re-create a fully new solution somewhere in 31727 as not-blocker then I will communicate with the author (Kevin Carnes) and now commenting in 16:37 nugged tuxayo: so: should we ask oldRMs to change 29012 status to WONTFIX or INVALID and re-create a fully new solution somewhere in 31727 then? 16:37 lukeg tuxayo: I will revert the 29012 patchset from stable today, thanks! 16:37 tuxayo lukeg great :D 16:37 nugged (there was an edit to the message, so v2) 16:38 nugged lukeg: thanks! 16:39 lukeg also making note and will change my message when backporting to "backported to 22.05.x for upcoming 22.05.06 release" 16:39 lukeg sorry for the confusion 16:42 tuxayo > should we change 29012 status to WONTFIX or INVALID 16:42 tuxayo «Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl» 16:42 tuxayo This is still valid and we want to fix it IIUC. 16:43 tuxayo You might want to start a new ticket to have a simpler comment history. And set 29012 as BLOCKED and having it depend on the new ticket. 16:43 tuxayo > re-create a fully new solution somewhere in 31727 16:43 tuxayo isn't bug 31727 invalid/won't fix since 29012 wasn't released. Better have a new ticket to not have confusion with the invalid premise of 31727 16:43 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 critical, P5 - low, ---, kevin.carnes, Needs Signoff , Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing 16:44 tuxayo Or just put 29012 back to assigned/in discussion if the comment history of it isn't an issue. 16:47 nugged 31727 not needed at all if no old 29012 code 16:48 nugged so - tuxayo - or team - pls advise: new ticket or re-use 29012 but obsolete all in 29012? 16:49 tuxayo nugged: If you hesitate and don't get other feedback, go with a new ticket. Set 29012 as blocked, and dependent on the new ticket. 16:49 tuxayo > 31727 not needed at all if no old 29012 code 16:49 tuxayo Perfect, that's simpler. 16:50 nugged I'll ask the author (Kevin Carnes) to re-do 29012 then. 16:56 tuxayo Great thanks. 16:57 tuxayo Happy to see Kevin still around even after the ES 7 patches ^^ 16:58 nugged I've set "fixed/invalid" now for 31727 and reverted 29012 to the "assigned" state. 16:58 nugged ok, time for home tasks then now. 🤗 16:58 tuxayo ðŸ‘ï¸ 17:04 tuxayo bag++ Thanks for calling for help to signoff bugs during your talk in KohaCon especially to Koha US members. 17:04 tuxayo The 1st patch testing session I did was too close to KohaCon I think, so that's why noone from Northern America showed up. 17:04 tuxayo But hopefully the next one will work. I'll send a poll for the date in the next days. 17:36 lukeg tuxayo, nugged: 29012 is reverted from 22.05.x 17:44 emlam Hello all! I'm new to the Koha community - just joined the Koha team at a library on the US east coast. Looking forward to wrapping my brain around the system and becoming a part of the dev community! 17:46 caroline welcome emlam! 17:47 caroline I'm sure you'll find great mentors here 17:49 lukeg Welcome, emlam!!! 17:49 oleonard Hi emlam 17:52 caroline Here is the list of irc handles of people who are regularly around, if you ever need to ping someone in particular https://wiki.koha-community.org/wiki/IRC_Regulars 17:54 emlam Thank you! :) 18:43 tuxayo lukeg++ 18:44 tuxayo emlam: welcome, don't hesitate to ask your questions here or the koha-devel list 18:53 emlam Thanks!! 19:15 tuxayo emlam: If you want to test patches or setup a local development Koha, feel free to also mention me in the chat ^^ 19:30 emlam tuxayo: Thanks! Reading some of the basic guides etc first, but I will keep that in mind 19:35 emlam \quit 20:12 lukeg oleonard: you about? 21:18 lukeg1 davidnind[m]: Will you file a bug for the auto-complete issue you discovered on patron lists? 21:20 davidnind[m] will do! 21:24 lukeg1 davidnind[m]++ 21:35 davidnind[m] bug 31782 21:35 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782 enhancement, P5 - low, ---, koha-bugs, NEW , Patron lists - patron autocomplete search does not work 22:26 oleonard lukeg1: Not really!