Time  Nick                  Message
23:32 huginn                tuxayo: The operation succeeded.
23:32 tuxayo                @later tell liliputech «there was this question about having a "LTS" release of Koha, and that would be 21.11» Actually it will be 22.11
20:57 huginn                cait: The operation succeeded.
20:57 cait                  @later tell liliputech - strings on pootle had already been updated beginning of the week - I think we need to trigger another update with the patches pushed today
20:55 huginn                cait: liliputech was last seen in #koha 6 hours, 1 minute, and 20 seconds ago: <liliputech> good evening everyone, see u tomorrow :)
20:55 cait                  @seen liliputech
20:55 huginn                cait: The operation succeeded.
20:55 cait                  @later tell liliputech can you have a look at Bug 30638        - Odd number of elements in anonymous hash at C4/Letters.pm line 827  please?
19:01 huginn                News from kohagit: Bug 15326: Using AdditionalContents for custom pages on OPAC <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8de80449dde00b985d99c23b168c12d3d94b4794>
19:01 huginn                News from kohagit: Bug 15326: (follow-up) Hide RSS feed if no news items <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e55864db2747bd8bc139b3b26c0f5214f1958123>
19:01 huginn                News from kohagit: Bug 15326: (follow-up) Fix staff permissions and consider library limits <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=01091c80893caab0c5b3a99397be658e3a537ead>
18:33 huginn                News from kohagit: Bug 31294: Show "Required" label on mandatory fields <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5c1db538e6c25da27484e39ae619e09779aac1c2>
17:13 wajasu                caroline: lib/Koha/Recall.pm lines 394-416 explains the overdue/recall logic.
17:00 wajasu                i see line 40 and 41 set it to overdue
16:56 wajasu                i see UseRecalls in the sysprefs, and it mentions circulation and fine rules. so i'll look for overdue being set in those scripts
16:51 wajasu                i noticed in recalls/recalls_overdue.pl that it mentions in it's "list" option, that the overdue_recalls.pl cronjob will set the Recalls status to overdue.  maybe that will help.i was just about to setup my overdue_notices cronjob. so you caught me in the code :)
16:51 wajasu                thats what i am looking at.
16:51 caroline              I'm testing in 22.05.03 but I don't think that script has changed since
16:49 wajasu                let me search some more
16:49 caroline              sorry, maybe it's confusion bc the script is overdue_recalls and the page is recalls_overdue...
16:49 caroline              That was my original question. I run the overdue_recalls script and it doesn't change anything
16:47 wajasu                i noticed in recalls/recalls_overdue.pl that it mentions in it's "list" option, that the overdue_recalls.pl cronjob will set the Recalls status to overdue.  maybe that will help.
16:39 caroline              I'm trying to find out how to change a recall to overdue to make it appear in the recalls_overdue list
16:38 caroline              does the overdue_recalls.pl cron do anything? I'm not perl literate, but I don't see anything other than adding the action to the logs
16:37 fridolin              yello<
15:49 tcohen                see u  later #koha
15:18 oleonard              another rough variation: https://imgur.com/a/fexQRvJ
15:13 caroline_crazycatlady interesting
15:08 tcohen                oleonard++
15:04 oleonard              Very rough, but.... https://imgur.com/a/OQ1Vqjr
14:54 marcelr               bye
14:54 marcelr               see u too
14:54 liliputech            good evening everyone, see u tomorrow :)
14:53 tcohen                hahaha
14:53 marcelr               from trusted radical developers
14:52 marcelr               radical patches should be flagged accordingly
14:52 tcohen                :-D
14:52 tcohen                of course, no radical changes please
14:52 marcelr               to prevent double records
14:52 marcelr               yes that sounds better; in the meantime i followed caroline_crazycatlady approach with default
14:51 tcohen                we should have 'en' and 'dutch' and just a flag saying which one is the default
14:51 caroline_crazycatlady I guess we could say put your main language in default and other languages in their tabs... So I would put my french content in default and english content in english and leave french empty
14:51 marcelr               yes our discussion just proved your statment ;)
14:51 tcohen                I find the whole 'default' content language implementation confusing
14:50 caroline_crazycatlady ok that makes sense... If the content is like a logo or something, it doesn't need to be different in different languages so we would use default, but anything with writing would have to be in the language tabs
14:49 marcelr               they can choose default for notice language different subject
14:49 marcelr               so people cannot choose that; that was the confusion i created
14:48 marcelr               when i do not create an entry for Dutch then it falls back to default
14:48 caroline_crazycatlady the opac is in either language... so the default content would appear when? I would think it would appear if the language tab is empty?
14:47 marcelr               i am confused too
14:46 caroline_crazycatlady there is no default for opac though? Or am I confused?
14:46 marcelr               Dutch
14:46 marcelr               in our library we show Duch if they choose default
14:46 caroline_crazycatlady default would appear if the language is empty?
14:45 marcelr               people can choose the default
14:45 marcelr               yeah
14:45 caroline_crazycatlady what is bad? that the default is empty?
14:44 marcelr               it shows that you have an empty default which is kind of bad
14:44 caroline_crazycatlady I just find it weird that we have a preview button that shows nothing...
14:44 caroline_crazycatlady same... but we have clients in 21.05 rn and news are all separated
14:43 marcelr               the current setup might be easier
14:43 marcelr               i think so yes, but bad in remembering ;)
14:42 caroline_crazycatlady so opacheader_en, opacheader_fr-CA, opaccredits_en, opaccredits_fr-CA, etc.
14:42 marcelr               development sinus movements
14:42 caroline_crazycatlady We had to create one news item for each language
14:42 caroline_crazycatlady I think it was like that before? in the news at least
14:41 marcelr               instead of showing default and other langs behind default, you could also show all on the list (allowing filters) and not have tabs on detail page ?
14:40 marcelr               discussion started caroline_crazycatlady
14:35 huginn                Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31370 enhancement, P5 - low, ---, koha-bugs, NEW , Additional contents: Preview of default content only
14:35 caroline_crazycatlady For discussion? bug 31370
14:33 liliputech            \o(*-*)o/
14:31 marcelr               liliputech++ keep 21.11 in shape !
14:31 liliputech            oh, of course I should update the bugs i pushed! almost forgot for the last one :)
14:29 tcohen                caroline_crazycatlady++ # filing the bugs
14:29 tcohen                liliputech++
14:28 liliputech            Hmpfff pushing 36 commits to the 21.11.x branch \o/ nice work for the day :)
14:26 marcelr               how nice :)
14:26 caroline_crazycatlady I am creating you another bug though :( I think it is the same root problem, but so very minor compared to items not showing up
14:26 caroline_crazycatlady :)
14:25 marcelr               caroline_crazycatlady++ # thx for so
14:21 paulderscheid[m]      We should replace node-sass sometime. It has been deprecated for a while now. dart-sass seems to be a good replacement.
14:14 liliputech            thx :)
14:14 liliputech            oh much better after : npm rebuild node-sass
14:09 mtj                   ashimema: i think kohagit-bot is https://github.com/mmueller/supybot-git
14:09 mtj                   yeap
14:08 tcohen                does gmcharlt run huginn?
14:07 liliputech            Error: Missing binding /kohadevbox/koha/node_modules/node-sass/vendor/linux-x64-72/binding.node
14:05 mtj                   liliputech: try  yarn --verbose   build
14:05 paulderscheid[m]      What errors?
14:04 liliputech            hi there, any one has some clue to rebuild/compile the CSS? got errors with yarn build
14:00 mtj                   ashimema: i think the catch is kohagit-bot is only triggered per commit
14:00 paulderscheid[m]      Yeah, makes sense though
13:58 mtj                   paulderscheid[m]: ive just focused on koha-22.05/deb11 for now
13:58 ashimema              I kinda wouldn't mind the kohagit bot if it only reported each bug once and not each commit pushed
13:57 mtj                   paulderscheid[m]: yes, agreed :0)
13:55 huginn                News from kohagit: Bug 27342: Improve test for OPAC <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4c44dd5eb4d27cfddcd982a5e7e11dc595d88772>
13:55 paulderscheid[m]      Alright mtj
13:55 huginn                News from kohagit: Bug 27342: Remove dbh from C4::Auth <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1b92fd78fda847b366ae44f351f20d92b6691226>
13:55 huginn                News from kohagit: Bug 31312: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bd70e8989fc02040a751f13c7d291d40e2dd91d7>
13:55 huginn                News from kohagit: Bug 30901: Add Renewals method to CirculationRules template plugin <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=32475570c4b98ba5d0fd0e51634013eb4ffdf835>
13:55 huginn                News from kohagit: Bug 30901: Add POD for Koha::Template::Plugin::CirculationRules <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=58f401de9c98cc917135029d3f892ebd7e0a4949>
13:55 huginn                News from kohagit: Bug 30901: Add Unit Tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=18211bf23367af9a3b0da6f97b413199a1668604>
13:55 huginn                News from kohagit: Bug 30922: Make the "Relative's checkouts" table configurable by the table settings <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=db4293988551bd25eede41ee5e3b92c7ad02c797>
13:55 huginn                News from kohagit: Bug 27342: (QA follow-up) Remove dbh from new tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a433573054324275be01be3e0cacf2dfb2d1dd20>
13:55 huginn                News from kohagit: Bug 27342: (QA follow-up) Fix test <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=21e4995a3163de70a4744f47f015c98614ed03f9>
13:55 paulderscheid[m]      I think it'll definitely pay off in the long run
13:55 mtj                   paulderscheid[m]: ping me if you get stuck testing, my repos are a bit messy at the moment :)
13:54 paulderscheid[m]      Thanks for doing all this work mtj
13:51 mtj                   https://docs.aws.amazon.com/whitepapers/latest/how-aws-pricing-works/get-started-with-the-aws-free-tier.html
13:50 mtj                   google 'aws free tier'
13:49 mtj                   ps, amazon/aws have FREE arm64 and x86 instances, 2gig + 2cpu
13:48 mtj                   ..it has been failing a bit lately, i dont know why yet
13:47 mtj                   t_db_dependent_Search_t.MARC21 + DOM (1890)
13:47 mtj                   http://jen1.kohaaloha.com/view/aws/job/koha-22.05-d11-aws64
13:46 mtj                   i have 2 failed tests on deb11-22.05
13:43 paulderscheid[m]      I'll gladly test it
13:43 paulderscheid[m]      I've already got an image working so it's possible but never with ES
13:42 mtj                   paulderscheid[m]: i wonder if the arm64v8 docker images will work on your macbook m1?
13:41 mtj                   https://gitlab.com/mjames/ktd-arm64/-/pipelines
13:41 paulderscheid[m]      But probably not because of missing support
13:40 paulderscheid[m]      I know, didn't ever get it working anyway
13:40 mtj                   paulderscheid[m]: i think ES got arm support in v7
13:40 paulderscheid[m]      mtj++
13:39 mtj                   ..but had some errors with selenium (aka seleniarm), so thats disabled for now
13:39 tcohen                mtj++
13:38 paulderscheid[m]      ES works? O.O
13:37 mtj                   http://jen1.kohaaloha.com/view/aws/job/koha-22.05-d11-aws64-es/
13:37 mtj                   hmm, ive got ES running ok
13:37 mtj                   http://jen1.kohaaloha.com/view/aws/
13:37 paulderscheid[m]      Did you run into anything unexpected? mtj ?
13:36 liliputech            mtj: nice :)
13:36 mtj                   hi marcelr, tcohen :)
13:36 paulderscheid[m]      That's awesome
13:36 mtj                   paulderscheid[m]: i did make a some progress with koha on aws/arm64
13:36 tcohen                hi mtj
13:36 marcelr               tcohen++
13:36 marcelr               hi mtj
13:36 mtj                   hey #koha
13:26 huginn                News from kohagit: Bug 29673: Allow English sql localization script <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=015dcce2ab614ec409c99ea6fb4d57e782d9ac5f>
13:26 huginn                News from kohagit: Bug 29723: Add a "Configure table" button for KohaTable tables <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=73178317a6c9395946662dd808c8d92ad061dd42>
13:26 huginn                News from kohagit: Bug 31309: Remove GetItemsInfo from basket/sendbasket <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=42b6aea89c39bc819adc92b001748a031d4466c9>
13:26 huginn                News from kohagit: Bug 31310: Remove GetItemsInfo from catalogue/imageviewer <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=86796446359e51a389634cb3f3822d3b792724ae>
13:26 huginn                News from kohagit: Bug 31313: Remove GetItemsInfo from opac-detail <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=959f49baf2cffd53859d701c9395c0ad9df5326f>
13:25 huginn                News from kohagit: Bug 31314: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c61f2a64fc7e4b9a7c1560c6809bb5029c25eb46>
13:25 huginn                News from kohagit: Bug 31317: Remove GetItemsInfo import from opac-tags <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7a56800131590ec1d91a21a91825866d0bf5f242>
13:25 huginn                News from kohagit: Bug 31318: Remove GetItemsInfo from serials/routing-preview <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5a1bf540d1b73a18fabe3359018fa60f56d4ece1>
13:25 huginn                News from kohagit: Bug 31320: Remove GetItemsInfo from virtualshelves/sendshelf.pl <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=992078f494c54643fa20b37f0c11b1392bf10323>
13:25 huginn                News from kohagit: Bug 31313: Fix availability - OPAC opac-detail <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=70cb4e22c0740eb175c4cd813cd38f9f5f635fa3>
13:25 huginn                News from kohagit: Bug 29723: (QA follow-up) Make button text translatable <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ebf1ad39f855e4625d1217fb1e6a4ddb390a7a34>
13:25 huginn                News from kohagit: Bug 29723: (QA follow-up) Switch to using ID's on column settings <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c8c8ef9d2edaeb77d2b92042ad397458cb85c917>
13:25 huginn                News from kohagit: Bug 29723: (QA follow-up) Correct scroll to table <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a9ffc07a1d9d50785d1031772e96c56a27f8ce85>
13:25 huginn                News from kohagit: Bug 29723: (QA follow-up) Ensure ID's match Module names <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ed6301444ec37b462e64ae87d2efd9c972a1b144>
13:25 huginn                News from kohagit: Bug 31314: (QA follow-up) Search Koha::Items not $biblio->items <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=873170aa5225dec7b01ad043a846b451c3fffc2c>
13:25 huginn                News from kohagit: Bug 31314: (QA follow-up) Prefetch and make routines use result objects <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e627b437dc54a9494204f5d5ea7e989261d74cf3>
13:25 huginn                News from kohagit: Bug 31313: (QA follow-up) Search Koha::Items <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c46b2ab1cd0acb6b04d008a79d4bdf5730216cb4>
13:25 huginn                News from kohagit: Bug 31313: (QA follow-up) Prefetch checkouts and branches <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=05be7300acbec34a118de5c11787a9c784b8b808>
13:25 huginn                News from kohagit: Bug 31313: Unit tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6bc85707baf453778b38856f32025aa84f4f2c14>
13:25 huginn                News from kohagit: Bug 29723: (QA follow-up) _ vs __ <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7d47c1bc77ad2d49c69c580ab3c16b094ca90973>
13:15 tcohen                oleonard++
13:15 tcohen                marcelr++
13:15 huginn                Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Move branches.opac_info to AdditionalContents allowing multi language
13:15 wahanui               rumour has it bug 29144 is ready for testing
13:15 tcohen                bug 29144
13:11 marcelr               thx oleonard++ # 29144
13:02 liliputech            oh, then, ok :)
12:55 oleonard              liliputech: I thought just jenkins was going there
12:29 liliputech            s/koha-bot/koha-bots/
12:28 liliputech            wow, slow down huginn... isn't that one supposed to spam koha-bot now?
12:21 huginn                News from kohagit: Bug 31308: Remove GetItemsInfo from basket/basket <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=62667dbb91478740d222d4daf3d1d5988f43442c>
12:21 huginn                News from kohagit: Bug 31245: Do not try to report results if task not started <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=12bc623ae7bcbd03fd4c8505bf1c55010bb3d0f7>
12:21 huginn                News from kohagit: Bug 31245: Do not call report for job detail view if job not started <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=931f4bd79776215b8cb1e656d58abf80b7aad8db>
12:21 huginn                News from kohagit: Bug 31158: (bug 23991 follow-up) Fix suggestion search by dates <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=89f2f369a61b43d396f90d77e1bd1941330a359f>
12:21 huginn                News from kohagit: Bug 31276: Report results are limited to 999,999 no matter the actual number of results <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5e29433bdc3a5ccd582ece6e2338c6e38e97c5d9>
12:21 huginn                News from kohagit: Bug 31281: Use correct reply-to email when sending overdue mails <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=18b2389de49b5c403f7bd68ef315b044a201eff5>
12:21 huginn                News from kohagit: Bug 31325: Fix koha-preferences get <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3f1fe4f178df3423bc95f9a288aaefdda6a6e8c0>
12:21 huginn                News from kohagit: Bug 31302: Fix spelling in sample_notices.yml <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b3d8941c34887b34c69edac8f33b7de179d96267>
12:21 huginn                News from kohagit: Bug 31328: Make Koha::Item->get_transfer* use Koha::Item::Transfers->filter_by_current <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e58bb3d605736049ed289bf77fffb003fa8d3d51>
12:21 huginn                News from kohagit: Bug 31331: Add data-order attribute for better sorting of dates <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=883d12913e32075f37b03135abe64e97d691739a>
12:21 huginn                News from kohagit: Bug 31308: (QA follow-up) use count to see if no items present <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=25de03ab10950c1afb0a1e59683f868a32d55f0a>
12:21 huginn                News from kohagit: Bug 31328: Call get_transfers from get_transfer <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=da470332493ae59f7caab358b1cd2ac2204cf5c0>
12:21 huginn                News from kohagit: Bug 31346: Fix broken Syndetics links on OPAC detail page <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=10ced3c49485aa5cdfc0cd06cfff30ddb7f9afe7>
12:08 huginn                Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 major, P5 - low, ---, m.de.rooy, Needs Signoff , Additional contents: Fix handling records without title or content
12:08 marcelr               bug 29782 please test; from critical to major but nice to have in the stable branches
12:07 paulderscheid[m]      And I bet you'll pick up svelte in a couple hours
12:06 paulderscheid[m]      Since it has no runtime, no extra dependencies are needed.
12:05 paulderscheid[m]      You can generate a standalone 'modal generator' if you will in Svelte, bundle it as umd and import it as a class like jquery. Later on, you just have to make some tweaks to port the svelte code over to vue. It's far from a headache.
12:04 paulderscheid[m]      I have a tip if you don't want to wait
11:59 ashimema              eventually I think that's probably the sanest approach.. but I think I'll wait for vue to be more heavily adopted 😜
11:57 paulderscheid[m]      I think that'd be the sanest solution.
11:53 paulderscheid[m]      And pass whatever params it needs to a function
11:53 paulderscheid[m]      Maybe it's better to generate the modal with JS?
11:52 ashimema              indeed
11:51 paulderscheid[m]      On the other hand, that's not much different from the existing solution
11:50 paulderscheid[m]      https://developer.mozilla.org/de/docs/Web/HTML/Element/template
11:50 paulderscheid[m]      You could use a native html template, and add it to the DOM via JS after the content has loaded
11:49 paulderscheid[m]      Since modals require JS anyway
11:49 paulderscheid[m]      Well, I'd try to move it entirely to JS
11:48 ashimema              to save the case of 'I added cat-toolbar.inc but the stuff in it didn't work on my new page... what am I missing'
11:47 ashimema              yeah
11:47 paulderscheid[m]      You'd rather like a single point in a centralised component like the toolbar to avoid adding it everywhere
11:47 ashimema              but it all somehow feels wrong when you look at the markup.. having <div toolbar stuff></div><div modal stuff></div><script>modal stuff</script><div> rest of page stuff</div><script> other javascript stuff</script>
11:46 paulderscheid[m]      If I understand correctly, you're unhappy with adding JS+inc wherever you need to use it?
11:46 ashimema              I mean.. we 'could' bundle the JS inside the modal template include to keep them together.. and we could reference that include from the toolbar include instead of from each file that references the toolbar include..
11:43 ashimema              that's an example of what I mean.. that's the 'current best practice' way
11:43 ashimema              https://gitlab.com/mrenvoize/Koha/-/merge_requests/7/diffs?commit_id=6a8dbd57bd42113a7890a64b5b0350555f4da2ee
11:43 ashimema              but right now whatever solution I come up with feels more dirty than before.
11:42 ashimema              I'm sure with the move to vue this gets better
11:42 ashimema              bundling the modal markup into cat-toolbar.inc feels off somehow.. likewise bundling a js file in there is really off when you consider we try to keep <script> at the bottom of the file
11:42 paulderscheid[m]      ah wait, let me look
11:41 paulderscheid[m]      Not sure I get it
11:41 ashimema              you add it cat-toolbar.inc with the trigger markup.. then everywhere you include cat-toolbar.inc you also now have to include /modals/your_modal_template.inc and /js/your_modal_js.js
11:40 ashimema              adding a modal to one of our menu includes for example..
11:40 paulderscheid[m]      <ashimema> "I really wish we had a neat..." <- what do you mean exactly?
11:34 ashimema              I really wish we had a neat way to package up modal js and modal templates
11:33 tcohen                morning
11:32 tcohen                morninh
11:23 oleonard              https://snipboard.io/yAmhLa.jpg Still not sure what happens when you click on one of the other "tabs"
11:15 huginn                Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Move branches.opac_info to AdditionalContents allowing multi language
11:15 marcelr               anyone for bug 29144 ?
11:13 marcelr               khall++ thx for qa
11:13 marcelr               hi #koha
11:05 oleonard              ¯\_(ツ)_/¯
11:05 paulderscheid[m]      otherwise it becomes just noise
11:05 paulderscheid[m]      It's like class properties, don't repeat the class name
10:59 ashimema              they all double up the 'New'
10:59 ashimema              'New -> New record', 'New -> New item', 'New -> New subscription', 'New -> New child record'
10:58 ashimema              I've never really thought about it before.. but I now find the menu options under new a bit funny
10:57 ashimema              ta
10:57 oleonard              "New -> Catalog concern" is my choice I think
10:57 ashimema              agreed
10:55 oleonard              I've encountered a few cases just recently where I needed to report an error with a catalog record though, that could be a useful feature in that case
10:54 oleonard              Create an option for all reports to be printed directly into a shredder ;)
10:54 ashimema              but I can see it quickly getting adopted for all sorts
10:53 ashimema              yeah.. in this particular case they're a mixed medical library.. so it's more the 'This book contains nude pictures in the medical context' type warning 😜
10:53 ashimema              lol
10:53 oleonard              The frown is my political comment
10:52 ashimema              ?
10:52 oleonard              :(
10:51 ashimema              'concern' is just the wording they chose.. their use case is "Report that the title might offend someone".. then they have a parallel feature they want to catalog such cases so they can add a 'Warning, some users may be offended by this title content'
10:51 oleonard              I'm leaning towards "New" as the parent if the user will see that menu
10:51 oleonard              It might be its own button if someone lacks any catalog permissions
10:50 ashimema              it's basically a 'change request' workflow
10:50 ashimema              right now my brain is flitting between 'New > New concern' and 'Edit > Report concern' I think.
10:48 ashimema              any opinion on where it best fits
10:48 ashimema              or 'Edit > Report concern' ?
10:48 ashimema              'New > New concern' or 'New > Report concern'
10:47 ashimema              I have a modal I've basically cloned from the opac.. but I'm struggling to think which menu it should appear on from the bib details display..
10:47 ashimema              I'm adding a 'Catalog concerns' feature to allow patrons to report cataloguing issues for a customer.. and it occurred to me it may also be a nice feature for the staff client.. i.e. if enabled those without the permission to edit catalog recods themselves get a method to report issues they spot so a cataloguer can fix them.
10:45 oleonard              Of course
10:45 ashimema              can I get your thoughts on something oleonard?
10:45 ashimema              morning oleonard
10:44 oleonard              o/
09:16 liliputech            Joubu+1
09:16 liliputech            also there was this question about having a "LTS" release of Koha, and that would be 21.11. I have to discuss with Paul what's more interesting for biblibre, me doing RMainting on LTS branch or RMainting the branch BibLibre actually deploy to its clients (then, next year/at some point it will become 22.(05|11) for biblibre)
09:15 Joubu                 priority should be happiness of the customers. RMaint is knowing the next release and making it more stable => less bugs => customers are happy
09:12 liliputech            for now, it is certainly not a problem that I continue RMaint 21.11 :)
09:12 ashimema              I spend a few hours every morning keeping on top of my queue
09:11 ashimema              I had a very understanding boss 😜
09:11 ashimema              yeah, it's certainly something that takes time
09:10 liliputech            ashimema so far I'm good with this task, like it :) it takes some time though, which I don't spend on other things, I must discuss with Paul and Laurence what are the priorities for BibLibre and if I can continue :)
08:54 ashimema              I lie.. it was only a year in the end.. 2 cycles
08:53 ashimema              I did RMaint for 4 cycles I think..
08:52 ashimema              I'm hoping you hit 'enjoyment' point before the end of the cycle and want to continue 😜
08:52 ashimema              practice makes perfect
08:52 liliputech            like wine :p
08:52 liliputech            improving over time \o/
08:51 liliputech            (working on it, applying patches from 22.05.x now) yes, this time i even *not* forgot the string freeze message ;)
08:51 ashimema              you've been doing great.. 🙂
08:50 liliputech            although (or is it because?) there is quite a lot of work with the 21.11.11 release!
08:50 liliputech            ashimema: not very regular on my irc connection these days...
08:49 ashimema              though I've had lots of irc connection issues ever since
08:49 ashimema              been back a week or so now
08:49 ashimema              yup
08:44 paulderscheid[m]      salut liliputech
08:44 liliputech            morgen paulderscheid[m] morning ashimema , back from vacations? (been a few days already if not mistaken!)
08:32 ashimema              morning #koha
07:50 paulderscheid[m]      morning #koha
07:28 liliputech            (pfeww...)
07:28 liliputech            old_issues wahanui?
07:27 wahanui               somebody said hi koha! was there a table in which i can see if a borrower has borrowed any books (or if library lended out any books) ?
07:27 liliputech            hi koha!
07:18 dcook                 Or maybe this is when I implement Mojolicious controllers locally...
07:10 dcook                 I suppose I could redirect to a REST API endpoint with a GET request. Seems hacky but would bypass that limitation...
07:08 dcook                 Or rather buffers the response...
07:08 dcook                 I was just finishing up a plugin demo when I realized that Plack::App::CGIBin caches the entire response before sending it back to Apache to send to the client :|
07:07 dcook                 allo allo
06:57 alex_                 Bonjour
06:52 matts                 hi !
05:48 huginn                Joubu: The operation succeeded.
05:48 Joubu                 @later tell oleonard 30718 - yes it seemed to work. Which problem do you have?
05:47 huginn                Joubu: The operation succeeded.
05:47 Joubu                 @later tell schnydszch guess you have "DumpTemplateVarsIntranet" turned on. It will show the variables passed to the template in a HTML comment
05:46 Joubu                 on
05:46 Joubu                 schnydszch: guess you have the "dump" syspref
05:46 Joubu                 sn
04:49 huginn                mtj: The operation succeeded.
04:49 mtj                   @later tell schnydszch: https://perldoc.perl.org/perlref#Curly-Brackets
04:49 huginn                mtj: The operation succeeded.
04:49 mtj                   @later tell schnydszch: hi, your example is not JSON - its a perl data structure called a hashref
02:30 schnydszch            Good morning! I have question regarding page source in koha. Does 22.05 installation gives a lot of jsonized text like below: <!--                                       $VAR1 = {   'OPACPrivacy' => '0',   'OpenLibraryCovers' => '0',   'SyndeticsExcerpt' => '0',   'lang' => 'en',   'OpacTopissue' => '1',   'sessionID' => 'bbc9e24b8c1cc79fd8a14cdbffd87710',   'OPACSerialIssueDisplayCount' => '3',   'Koha' => bless( {}, 'Koha::Template::Plugin::Koha' ),   'o