Time Nick Message
23:36 aleisha thanks tuxayo !
23:33 tuxayo Added for next meeting https://wiki.koha-community.org/wiki/Development_IRC_meeting_20_July_2022#Agenda
23:31 tuxayo aleisha: good catch
22:35 koha-jenkins Project Koha_19.11_D11 build #47: STILL UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_19.11_D11/47/
22:23 aleisha we still refer to datepicker on the coding guidelines
22:22 aleisha can i ask why the use of flatpickr isnt documented on the wiki coding guidelines anywhere?
22:22 wahanui niihau, aleisha
22:22 aleisha hello
21:44 koha-jenkins Project Koha_21.05_D11 build #229: SUCCESS in 1 hr 1 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/229/
21:06 caroline Like I said the other day, I don't really see the use in public libraries (where I have most of my experience), but maybe someday public libraries will extend their lending periods and use recalls instead of short lending periods, renewals and holds
21:04 koha-jenkins Project Koha_21.05_U18 build #192: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/192/
21:04 caroline If it were only holds, patrons would have to wait until the lending period is over
21:03 caroline From what I understand, recalls are holds that modify the due date for the person who currently has the item. I would see the use in universities or specialized libraries where people can take out materials for long periods of time (or indefinitely), until someone else needs it. Then it is recalled, the due date is changed and the current borrower is advised
21:00 ashimema Thanks
21:00 ashimema I must be missing something so yeah, looking forward to it
20:59 ashimema So glad someone took that on.. I have been completely lost on the feature so far.. can't tell the difference functionally from holds really
20:59 ashimema Also looking forward to reading your recalls docs when I'm more awake tomorrow
20:57 cait caroline++
20:57 caroline :)
20:57 ashimema caroline++ thanks for the testing.. awesome test plan and execution
20:55 koha-jenkins Project Koha_21.05_U18 build #191: SUCCESS in 37 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/191/
20:53 wahanui Congratulations!
20:53 koha-jenkins Project Koha_21.05_U16 build #201: FIXED in 1 hr 8 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/201/
20:53 koha-jenkins Yippee, build fixed!
20:43 koha-jenkins Project Koha_21.05_D12 build #128: SUCCESS in 57 min: https://jenkins.koha-community.org/job/Koha_21.05_D12/128/
20:38 koha-jenkins Project Koha_21.05_D10 build #278: SUCCESS in 53 min: https://jenkins.koha-community.org/job/Koha_21.05_D10/278/
20:23 koha-jenkins Project Koha_21.05_U20 build #202: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/202/
20:21 alohabot 🎠🤖 Koha '21.05.x' packages pushed to 'koha-staging' repo ðŸðŸðŸ«
18:52 wajasu mpm-itk configured in the warning of my apache error.log so guess thats the default these days to support multi tenant or such
18:48 cait it sounds familiar
18:47 wajasu i will look at my VM. i think the ktd uses mpm_itk though.
18:47 cait that I don't know
18:45 wajasu does the apache run with mpm_itk by default these days. or mpm_event?
18:44 wajasu ok.
18:44 cait we had some trouble without memcached actually
18:44 cait memcached and plack are recommended
18:44 wajasu only 20-30K items
18:43 wajasu seems faster with memcached.
18:43 wajasu will i have mem problems with plack and/or memcached. on a 1GB nano box. I see memcached or plack gobbles up ram over time on my test VM.
18:41 wajasu i used to run my koha box on iron. now i'm sploying to cloud/linode. would you guys suggest ufw for opac/staff and fail2ban for ssh these days, and https only.
16:47 ashimema hi cait
16:38 * cait waves
16:19 ashimema or take the above as an example to code it up.. should be trivial I would think
16:19 ashimema reason seems like another good one to move in a similar way lukeg.. feel free to report it 🙂
16:19 ashimema that should do the trick for what I was thinking about
16:18 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , overdue_notices.pl --frombranch option should be available as a system preference
16:18 ashimema bug 31157
16:09 ashimema indeed
16:09 ashimema haha
16:09 caroline I think for some things, it's nice that they can change the parameters themselves (such as longoverdues, if their policies change), but I'd be wary for some other things (days to keep stuff in cleanup database for example, I know some clients would put something like "keep for 10000000 days" like hoarders)
16:07 ashimema aha, thanks
16:06 caroline ashimema, some options for the longoverdue cron are now system preferences, but I think both options work (you can set them from the cronjob, or the syspref)
16:04 lukeg was just wondering this morning if --reason from cancel_expired_holds.pl could be moved to a sys pref
15:47 * ashimema is looking to --frombranch in the overdues script to a preference to it works nicely in multi-tenant instances
15:46 ashimema or have we just plain moved some options into preferences in the past instead?
15:45 ashimema did I imagine we have at least some cronjob parameters that now have the option to optionally set them from preferences?
14:55 cait1 could we have broken something with all the owrk on the security issues?
14:54 cait1 but they log in elsequere and koha shoudl log them in automatically (that's how it usualyl works if you are alreay logged in)
14:54 cait1 from his description it sounds like they do not log in from Koha
14:54 cait1 we did a lot of auth work
14:53 tcohen :-D
14:53 cait1 maybe you could say that you tested and it works
14:52 tcohen and it works
14:52 tcohen no mistery
14:52 tcohen and have a couple production sites with CAS, but it is just configuring it on sysprefs
14:51 tcohen I only used the Apereo demo
14:51 ashimema I've never touched CAS
14:51 tcohen couldn't reproduce
14:51 tcohen I've seen it
14:37 cait1 I am worried about our next update if that should be broken :(
14:36 cait1 does someone have an idea about the CAS issue on mailing list?
14:36 cait1 that's the idea :)
14:35 caroline :) cookies help de-escalate
14:33 * cait1 sends cookies to the infuriated people
14:33 * tcohen infuriates as well
14:33 caroline definitely not just you!
14:33 ashimema glad it's not just me it infuriates
14:32 caroline We specifically tell our clients not to send us .msg files... Just copy the text into the ticket (with implied threat of we won't help you if you send us .msg files)
14:31 wahanui I haven't seen 'the', cait1
14:31 cait1 seen the gui, not planning to look at code right now :P
14:31 tcohen it's on my TODO for next week
14:31 tcohen Joubu: I've seen the code, haven't played with the interface
14:30 ashimema lots of online tools that spit out the bits in a random order
14:30 ashimema well.. if you want to see all the parts in context anyways..
14:30 ashimema which you can convert to .eml.. but then that's a file you appear to only really be able to view by importing it into a proper mail client..
14:30 ashimema it's an outlook format
14:30 ashimema nope
14:30 tcohen isn't it an encrypted email?
14:29 ashimema soooo annoying
14:29 ashimema I'm currently having to actually download a mail client especially so I can import this bloody thing into it.
14:29 oleonard Hopefully the number is dwindling, even.
14:28 ashimema grr.. not everyone in the world uses Outlook people.
14:28 ashimema why do people have to email me .msg files.. they're a bloomin nightmare to open
14:27 Joubu too hot here, I would love a pool however...
14:27 Joubu lol, I was doing a quick *poll* ofc! :D
14:21 cait1 caroline++
13:55 caroline lol thanks, it seemed too easy :) I will add this script to the manual, it's not there at all
13:55 Joubu https://man7.org/linux/man-pages/man1/date.1.html#DATE_STRING
13:54 Joubu yes :)
13:54 caroline What would it be if it were 2 days ago? Or 1 month ago? Literally "2 days ago" or "1 month ago"?
13:52 caroline Joubu++
13:52 caroline yes! thank you!
13:51 Joubu try --since `date -d "1 day ago" '+%Y-%m-%d'`
13:49 caroline If I use a specific date "2022-07-13", it works
13:49 caroline Is it possible to use a relative date with borrowers-force-messaging-defaults.pl --since? I tried "curdate()-1" and "date_sub(curdate(), interval 1 day)" and both update all patrons, not only those enrolled since yesterday
13:20 Joubu it's not much effort to track down the current state
13:20 * ashimema is
13:20 Joubu following the kanban is certainly a good idea as well
13:20 oleonard ashimema: I think you left out the words "force at gunpoint" from that sentence :D
13:20 ashimema indeed
13:20 Joubu concept can be understand using the UI I think (at least the link between the "components")
13:20 ashimema I'm sure I could someone from our team to do user docs
13:20 Joubu code, at least
13:20 Joubu but wanted to have a MVP ASAP
13:19 ashimema code or concept?
13:19 Joubu oleonard: no worries. Let me know if you have ideas for me, to help others understand what I am doing. I need to write down some documentation...
13:18 Joubu and you need to be familiar with the ERM concept to understand a bit what it is doing
13:18 oleonard Joubu: I think I need to find a time when I can devote some real attention to it when you're around to answer questions, but I can't schedule that at the moment
13:18 Joubu but then yes, ERM is messy, there are tons of components :-/
13:18 Joubu I think having a look at the "cities" code, to be a bit familiar with Vue, is a good start
13:17 Joubu oleonard: I am bad at documenting, sorry about that. What would help you?
13:16 oleonard Joubu: I get very lost looking at the code :(
13:16 oleonard I have but not in enough detail
13:15 Joubu wondering, quick pool, who has looked at the 1. ERM UI, 2. ERM code, already?
13:14 oleonard Joubu: You can still use the classes because dialog error is handled as dialog alert for now
13:13 ashimema I know that's 5.. but those have been pretty consistent for a long time
13:13 Joubu (ERM)
13:13 Joubu I am going to handle them separately in the code ERM) but will not change the classes then
13:13 ashimema https://getbootstrap.com/docs/5.2/components/alerts/
13:13 ashimema I always felt we should mirror the classes available
13:13 Joubu When migrating to Bootstrap 5! :D
13:12 oleonard I don't have any objection to revising it
13:12 oleonard Our dialog styling predates our use of Bootstrap
13:12 Joubu so error is unexpected, warning would be pebcak
13:12 ashimema we've never quite been consistent with bootstrap
13:11 ashimema I've wanted to make those consistent for ages
13:11 Joubu warning would be something wrong on the form, an error would be an error from the server
13:10 oleonard What's the difference between a warning and an error?
13:09 Joubu I'd like message, warning, error
13:09 Joubu oleonard: "dialog alert", "dialog message", do we have a third one?
12:14 oleonard tcohen: How can we really KNOW anything??
12:14 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 enhancement, P5 - low, ---, victor, RESOLVED FIXED, Simplify translatable strings
12:14 Joubu certainly coming from bug 30733
12:13 Joubu not html
12:13 Joubu oleonard: l.109 should be [% content | $raw %]
12:11 tcohen how would we know they didn't want to actually show the span?
12:09 oleonard Hmm... https://snipboard.io/Fga987.jpg
11:50 tcohen maybe you can just use cp_debian_files.pl on each round?
11:48 wajasu your right. probably need to make custom version, then use that in my custom compose yml
11:48 tcohen you cannot rebuild and expect the running container to have your changes
11:47 tcohen and start fresh
11:47 tcohen you should name hte image the same as ktd does
11:47 tcohen from KTD
11:47 tcohen if you rebuild using some Dockerfile
11:47 tcohen if I understand correctly what you're doing
11:44 wajasu let me look at PATH for compose
11:43 wajasu i definitely need to rebuild the image. when i change files/run.sh even though it gets copied in as i see in dists/bullseye/Dockerfile i need to understand if koha-koha-1 really is affected
11:41 tcohen heh
11:41 tcohen it feels like a leaner approach
11:41 wajasu i'll try that.
11:40 tcohen PATH
11:40 tcohen s
11:40 tcohen so it set
11:40 tcohen you can tweak your docker-compose
11:40 tcohen just maybe
11:40 tcohen hm
11:39 wajasu i was working on koha-remove, to add long_tasks queue to be shutdown.
11:36 wahanui wajasu: that doesn't look right
11:36 wajasu change the ktd to have PATH=/kohadevbox/koha/debian/scripts:${PATH}:/kohadevbox/bin so when i work on the koha-* scripts i don't run /usr/sbin/koha-* versions
11:34 tcohen there are ways with docker compose to override the default behavior
11:34 tcohen what are you trying to do?
11:33 tcohen docker build . -t <name you want>
11:33 tcohen the docker image can just be built using
11:33 tcohen the docker compose is a way to provision the service
11:27 wajasu docker-compose was new a few years back when i used docker, so i never got into docker-compose
11:26 wajasu what must i do locally to rebuild the koha/koha-testing image locally to affect change
11:25 wajasu hey, I guess that koha/koha-testing is centrally controlled. can i not change files/run.sh or files/template/root_bashrc easily with ktd.
11:07 ashimema done
11:05 wahanui privet, tcohen
11:05 tcohen hola
10:58 ashimema ta
10:58 ashimema indeed
10:58 Joubu ashimema: seems pretty trivial, just add a mock_preference call and you should be good
10:57 ashimema ho, thanks
10:57 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 critical, P5 - low, ---, martin.renvoize, NEW , t/Ediorder.t tests failing on 22.05.02
10:57 Joubu bug 31134
10:56 Joubu ashimema: did you see 31134?
10:51 oleonard Okay
10:51 Joubu oleonard: if you are finding too many bugs, please don't spend more time on it...
10:50 wahanui darn tootin' it is.
10:50 ashimema excellent
10:50 Joubu that's is removing most of the specific code we have
10:50 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31149 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Use dayjs to parse dates
10:50 Joubu it's bug 31149
10:50 Joubu ashimema: nope, but "now" we will use day.js for date parsing
10:49 Joubu adding that to the bug
10:49 Joubu oleonard: There is a block comment in Koha::Report that certainly need attention
10:49 ashimema aren't we using moment internally in flatpickr too?
10:49 ashimema I also wanted to look at the moment.js -> day.js patch
10:48 Joubu lot of changes in the reports area (I haven't tested at all this module)
10:48 Joubu 4. Flatpickr needs to be tested, 5. there is as well the cataloguing plugin that is using altInput already
10:47 Joubu 3. REST API - I think I made some changes there as well (but maybe it is on a follow-up bug, cannot remember)
10:47 Joubu 2. Places where we retrieve from flatpickr and resent to the template (sticky due date in circ for instance)
10:46 Joubu for instance there are places where 1. KohaDates is used instead of html, as we moved the formatting to the template (and remove the output_pref(dt_from_string)) call from the pl/pm)
10:46 oleonard ðŸ‘ðŸ»
10:46 Joubu oleonard: yes, every date, everywhere... But having a look at the diff will show you the different patterns
10:40 cait1 please take notes... I can ty to spot what you didn't test later :)
10:40 cait1 lol
10:38 oleonard I guess the test plan is "everything"
10:38 oleonard Thanks Joubu that fixed it for me.
10:33 Joubu oleonard: reattaching, it was applying ok for me.
10:30 ashimema I've been meaning to look at it anyways.. just hadn't found a moment
10:30 ashimema 🙂
10:30 ashimema if you sign I can qa oleonard
10:30 ashimema oh, cool
10:30 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Use flatpickr's altInput option everywhere
10:30 oleonard Joubu: I can devote time to Bug 30718 today but it doesn't apply
10:08 cait1 I can help soem tomorrow
09:59 Joubu I can implement it if you help me somewhere else
09:45 cait1 paxed: so totally feel your paiin there...
09:45 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 enhancement, P5 - low, ---, koha-bugs, NEW , Add a deleted_on column to deleteditems
09:45 cait1 bug 30392
09:45 paxed cait1: thanks!
09:44 cait1 let me fid it and add your supporting voices to it! :)
09:44 paxed yup
09:44 ashimema deleted_on seems a nice idea
09:44 cait1 because last time one of the database updates messed with it and threw all our statistics for a year
09:44 paxed and this is important for reports.
09:44 cait1 i have filed a bug for having a deleted_on date...
09:44 paxed i so so so love going back to old dumps to figure out when items were deleted
09:43 ashimema exactly
09:43 ashimema yup
09:43 paxed oh, except it doesn't, because the timestamp comes from items table
09:43 cait1 ashimema: Interesting, it's 20.11 when i make a new bug... just not sure if this is because I last selected it or by default
09:43 ashimema during the move from items to deleteditems
09:43 paxed cait1: the DEFAULT current_timestamp() does that
09:43 ashimema one would need to set it to null to get the default to apply
09:42 cait1 could it be made so it only updates on INSERT? (database wise?)
09:41 cait1 yes... we had that issue too
09:40 paxed *grmbl* why is deleteditems.timestamp ON UPDATE current_timestamp() ... any change and you lost info when the item was deleted.
09:40 * ashimema is on a QA roll this morning.
09:24 ashimema I'm seeing way more bugs with a specific version reported.. but appear to also affect master?
09:23 ashimema has something changed with the default for 'Version' in bugzilla?
08:17 ashimema morning #koha:matrix.org
08:17 ashimema morning Oak
08:16 Oak morning cait1 and ashimema
08:02 cait1 morning
08:01 ashimema Morning cait1
07:39 cait1 hi #koha :)
05:48 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 major, P5 - low, ---, tomascohen, Pushed to oldoldstable , Error searching for analytics in detail view
05:48 ashimema Bug 29418
04:13 koha-jenkins Project Koha_22.05_D11 build #37: STILL UNSTABLE in 1 hr 14 min: https://jenkins.koha-community.org/job/Koha_22.05_D11/37/
03:22 koha-jenkins Project Koha_Master_D10 build #735: SUCCESS in 45 min: https://jenkins.koha-community.org/job/Koha_Master_D10/735/
02:59 koha-jenkins Project Koha_22.05_D11 build #36: STILL UNSTABLE in 1 hr 13 min: https://jenkins.koha-community.org/job/Koha_22.05_D11/36/
02:36 koha-jenkins Project Koha_Master_U22 build #134: SUCCESS in 48 min: https://jenkins.koha-community.org/job/Koha_Master_U22/134/
02:28 wahanui Congratulations!
02:28 koha-jenkins Project Koha_Master_U22 build #133: FIXED in 1 hr 6 min: https://jenkins.koha-community.org/job/Koha_Master_U22/133/
02:28 koha-jenkins Yippee, build fixed!
01:48 wahanui Congratulations!
01:48 koha-jenkins Project Koha_Master_D10 build #734: FIXED in 43 min: https://jenkins.koha-community.org/job/Koha_Master_D10/734/
01:48 koha-jenkins Yippee, build fixed!
01:47 koha-jenkins Project Koha_Master_D11_My8 build #914: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D11_My8/914/
01:46 koha-jenkins Project Koha_Master_D11_ES6 build #16: SUCCESS in 6 min 54 sec: https://jenkins.koha-community.org/job/Koha_Master_D11_ES6/16/
01:39 koha-jenkins Project Koha_Master build #2113: STILL UNSTABLE in 1 hr 14 min: https://jenkins.koha-community.org/job/Koha_Master/2113/
01:21 wahanui Congratulations!
01:21 koha-jenkins Project Koha_Master_D12 build #209: FIXED in 1 hr 7 min: https://jenkins.koha-community.org/job/Koha_Master_D12/209/
01:21 koha-jenkins Yippee, build fixed!
01:11 wahanui Congratulations!
01:11 koha-jenkins Project Koha_Master_D11_My8 build #913: FIXED in 57 min: https://jenkins.koha-community.org/job/Koha_Master_D11_My8/913/
01:11 koha-jenkins Yippee, build fixed!
01:04 koha-jenkins Project Koha_22.05_U22 build #27: SUCCESS in 49 min: https://jenkins.koha-community.org/job/Koha_22.05_U22/27/
00:53 wahanui Congratulations!
00:53 koha-jenkins Project Koha_Master_D11_MDB_Latest build #1004: FIXED in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/1004/
00:53 koha-jenkins Yippee, build fixed!
00:24 koha-jenkins Project Koha_Master_D11_ES7 build #19: SUCCESS in 9 min 50 sec: https://jenkins.koha-community.org/job/Koha_Master_D11_ES7/19/
00:13 tuxayo ho, I just had to complain for it to actually shutdown XD
00:12 koha-jenkins Project Koha_Master_D12 build #208: STILL UNSTABLE in 1 hr 7 min: https://jenkins.koha-community.org/job/Koha_Master_D12/208/
00:12 tuxayo Says it since 1h30 at least. Weird
00:12 tuxayo «Jenkins is going to shut down»
00:00 koha-jenkins Project Koha_22.05_U20 build #30: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_22.05_U20/30/