Time Nick Message
05:40 reiveune hello
05:40 wahanui hi, reiveune
06:15 dcook Hmm looks like the SSL cert for lists.katipo.co.nz has expired...
06:38 Joubu @later tell kidclamp pong
06:38 huginn Joubu: The operation succeeded.
06:48 ashimema morning #koha:matrix.org
07:00 cait1 good morning
07:38 Joubu @later tell marcelr Do you have a gitlab account? Can you test https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/45 please?
07:38 huginn Joubu: The operation succeeded.
08:21 magnuse__ \o/
09:26 Joubu @later tell kidclamp didn't you get complains about 23475/27697?
09:26 huginn Joubu: The operation succeeded.
10:37 oleonard Hey #koha
11:19 magnuse__ trying to understand how koha keeps elasticsearch updated (on a debian package install), but not finding it. thought koha-indexer would check the SearchEngine syspref or something, but not seeing that. anyone got any hints to understand this?
11:19 Joubu magnuse__: it's indexed "on the fly"
11:20 magnuse__ but how?
11:20 magnuse__ i assume rebuild_elasticsearch.pl is involved, but what makes that script run?
11:20 ashimema any call to the add/update routines immediately throws the record at elastic
11:20 Joubu Koha::SearchEngine::Indexer
11:21 ashimema so no queue to work through like with zebra
11:21 ashimema that script is just for manual interventions
11:21 magnuse__ ah hah! gotcha! thanks!
11:21 * magnuse__ stuck in old ways of thinking...
11:21 * ashimema could point out that in the next release we go back to a queue.. but in a very different way by using background tasks
11:22 magnuse__ using rabbit etc?
11:22 ashimema yup
11:22 ashimema precisely
11:22 ashimema Joubu did lots of work on it,, then tcohen and jajm refined the overall queuing and tasks processes as a whole
11:23 magnuse__ but then we fix the problem where things are stuck in the queue and never get anywhere, right? :-)
11:23 ashimema more work needed though in my opinion to make it as bomb proof as zebra... but that's for another day.
11:23 ashimema indeed... that is not fixed as far as I can tell
11:23 magnuse__ oops
11:23 magnuse__ Joubu++ tcohen++ jajm++
11:23 ashimema and dcook identified an issue with my patch.. there's a race condition
11:23 ashimema I have no idea how to fix it.
11:24 ashimema hackfest was busy 😜
11:24 ashimema I reviewed allot of that code and bounced it back more times than I could count
11:24 ashimema haha
11:24 magnuse__ ashimema++
12:02 marcelr o/
12:02 marcelr Joubu: the space before at is fine with me; merge it
12:05 Joubu thanks
13:19 oleonard-away An idea for Bug 7826: https://snipboard.io/b5yaOQ.jpg
13:19 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7826 normal, P5 - low, ---, oleonard, NEW , Standardize link for triggering plugins and auto-entry
13:23 Joubu oleonard: smaller maybe?
13:23 oleonard Yeah I was thinking the same
13:36 cait1 we had requests to make things bigger, because hard to click - but this would work I think, a little smaller too
13:36 cait1 the issue is mostly witht he older ... on the item form
13:36 cait1 the plugins can behave a bit differently, maybe instead of a pen we could use some kind of tool?
13:37 cait1 pen = pencil
13:37 oleonard I was also thinking about that. Maybe a wrench or gear icon?
13:37 oleonard Hammer. Flamethrower.
13:37 cait1 my first thought was wrench
13:37 cait1 flamethrower is very tempting
13:38 cait1 magic wand?
13:39 oleonard https://fontawesome.com/v4/icon/magic
13:39 lukeg marcelr++
13:39 cait1 that's not too horrible... maybe?
13:39 * ashimema likes magix wand
13:40 cait1 a tool might be more common for 'configure'
13:40 cait1 a plugin usually is some kin of helper to make things more magical (less horrible) to handle...
13:40 cait1 I could go with that
13:40 ashimema exactly
13:41 Joubu I had trouble to find nice icons recently, and noticed that FA v4 had good ones
13:41 Joubu well, v5
13:41 Joubu the new ones
13:42 oleonard Wrench: https://snipboard.io/npK38G.jpg
13:42 oleonard Wand: https://snipboard.io/tCVZcB.jpg
13:43 cait1 related question: what is the i for?
13:43 ashimema wand still get's my vote
13:43 oleonard cait: I replaced the "?" link with that
13:43 cait1 is that link to manal?
13:43 cait1 ah right
13:44 Joubu The wand quite makes sense yes
13:46 oleonard Paw print for some reason: https://snipboard.io/RjuWZh.jpg
13:46 lukeg I also like the wand
13:47 cait1 ok, missing theclue for the paw :)
13:49 oleonard So what I'm hearing is everyone votes paws. Got it. ;)
13:50 cait1 lol
13:50 oleonard (where's caroline when I need her)
13:50 cait1 you can just say you dislike the magic wand :)
13:51 cait1 https://fontawesome.com/icons/narwhal?s=solid? ;)
13:51 marcelr ostrich?
13:52 cait1 marcelr: no ostrich in FA :(
13:53 cait1 hm histsearch.t seems to implode in 20.11. 18 (
13:54 cait1 not t .pl - acq search
13:54 cait1 tuxayo: around?
13:55 cait1 argh. it fixed itself. nm.
13:59 ashimema cait1, sally beat you to bug 26689
13:59 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Monetary accounts notices should be definable at the credit_type/debit_type level
14:00 ashimema so you could QA it early next cycle 😜
14:00 ashimema hint hint
14:04 cait1 get in the queue :P
14:04 cait1 but as you know, I will be around some more regularly, so hopefully getting to all the things
14:05 cait1 oleonard: you ht the nail on the head witht he calendar bug
14:05 cait1 oleonard: I realized that the translation is only broken on the patrn form
14:06 cait1 and i am just lookig up the bug but I think I know which one it is now
14:10 caroline oh sorry oleonard I was just reading back and totally approve the paw print!!
14:10 oleonard :D
14:14 caroline runner-up for me would be pen/pencil to stay close to the current icon of 'rectangle with pen' as I call it during training, then gear, then magic wand, then wrench
14:21 * oleonard can't believe he's never noticed the paw print icon before
14:21 lukeg We must find a way to use the paws in Koha!
14:22 ashimema +1
14:22 oleonard I wonder if anyone has ever designed a media player with a paws button.
14:23 caroline oleonard, were you not of the generation of winamp player skins?
14:23 oleonard Oh I'm definitely that old :D
14:24 ashimema winamp!
14:24 caroline omg, just found the winamp skin museum :O (Do not click unless mentally prepared) https://skins.webamp.org/
14:25 ashimema yowser
14:25 lukeg I only remember the Winamp sound byte about llamas...
14:26 marcelr we are close to evacuating this room
14:30 Joubu marcelr: let ids = ["one", "two"]
14:30 Joubu for (var i in ids) { let id = ids[i]; console.log(id);}
14:30 Joubu will display "one", "two"
14:30 marcelr yes but it is not recommended to do so
14:30 Joubu why is it wrong? (apart from using 'id' and 'i' which is confusing)
14:30 Joubu well, it's JS :D
14:30 Joubu why wouldn't it be recommended?
14:31 marcelr i didnt write the recommendations..
14:31 marcelr just found it
14:31 lukeg More Than One Way To Skin A Cat :)
14:31 marcelr and agree that the code looks oddd
14:31 Joubu for (var i in ids) { let id = ids[i]; console.log(id);}
14:31 Joubu oops
14:31 Joubu https://www.w3schools.com/js/js_loop_forin.asp
14:32 Joubu For In Over Arrays
14:32 Joubu The JavaScript for in statement can also loop over the properties of an Array:
14:32 Joubu for (variable in array) {
14:32 Joubu (sorry for being boring)
14:32 marcelr i will look for the other statement ;)
14:32 marcelr url
14:32 lukeg Do not use for in over an Array if the index order is important.The index order is implementation-dependent, and array values may not be accessed in the order you expect.It is better to use a for loop, a for of loop, or Array.forEach() when the order is important.
14:33 marcelr https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...in
14:33 marcelr we need three references for Joubu :)
14:35 cait1 marcelr: do you remember the bug about the lang variable where we both commented?
14:35 cait1 i am trying to find it
14:35 marcelr i remember a lot of bugs cait1 ;)
14:36 paulderscheid[m] I'd always use JS higher-order functions.
14:36 paulderscheid[m] https://github.com/airbnb/javascript#iterators--nope
14:37 cait1 marcelr: sorry to not be more specific... i failed the first patch because it just removed the var and then we agreed it would have broken things for the preferred language and things got moved to a patron object i think
14:38 marcelr not sure which one it is
14:38 cait1 same (
14:38 cait1 will keep looking
14:38 cait1 i think it#s to blame for my calendar translation issue in 20.11
14:38 marcelr paulderscheid[m]: const sum = numbers.reduce((total, num) => total + num, 0); is not always easy to read
14:39 Joubu marcelr: it's modern JS ;)
14:39 marcelr that will be my problem, hahaha
14:40 Joubu I didn't know about the "for in", thanks. I will try to think about it next time
14:40 paulderscheid[m] marcelr: That's true, but you don't have to use reduce
14:40 paulderscheid[m] I only use reduce if it saves space
14:41 marcelr compact unreadable code which no one else dares to touch has its advantages :)
14:41 paulderscheid[m] ^^ also true
14:42 cait1 it was Bug 29684
14:42 marcelr perseverance++
14:43 marcelr which was not an easy one
14:45 lukeg marcelr, Joubu: is my latest patch for 30747 an OK way? forEach() ?
14:46 lukeg happy to change it, I just want to fix column settings for oherholdings :)
14:46 oleonard cait1: I linked to 29684 in my comment on Bug 30315!
14:46 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30315 normal, P5 - low, ---, koha-bugs, NEW , Calendar widget on patron form in staff interface no longer translates
14:47 marcelr lukeg it still looks a bit overcomplicated to me ?
14:49 marcelr you just want to repeat for 0 and 1 : if condition then action
14:51 cait1 oleonard: yes, i found that after lots of searching... it's one of those days
14:51 cait1 oleonard++ btw :)
14:53 kidclamp marcelr: sounds like you are volunteering to rewrite that bit in your preferred syntax ;-)
14:54 marcelr heh
14:54 marcelr i first have to rewrite C4
14:54 Joubu marcelr: the only change needed here is what does the original patch IMO
14:54 Joubu I introduced the bug :D
14:55 marcelr new volunteer !
14:55 Joubu yes, PQA the first patch
14:55 Joubu then we improve the other whole loop if you want to
14:55 Joubu s/other//
14:56 marcelr it wont be today anymore
14:56 marcelr i am in shutdown
14:56 Joubu -P now
14:57 kidclamp Joubu, we got complaints about 26247 and addressed with js - but 27697 is new to me
15:02 cait1 I feel like in shutdown too - tomorrow is another day
15:02 cait1 bye #koha!
17:44 reiveune bye
22:00 caroline Do I misunderstand the use of numReturnedItemsToShow? It says "show the XX last returned items on the checkin screen". We're talking about the returns.pl page right? It never goes over 21 items even if we put 50 or 100 in the syspref
22:04 caroline a value under 20 is fine, but anything over is not taken into consideration
22:22 caroline I filed Bug 30802 but I'll try again in a sandbox tomorrow just in case it's my installation that's weird
22:22 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 enhancement, P5 - low, ---, koha-bugs, NEW , numReturnedItemsToShow doesn't show more than 20 items on the return screen
23:32 koha-jenkins Project Koha_19.11_D8 build #459: SUCCESS in 22 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/459/
23:42 koha-jenkins Yippee, build fixed!
23:42 koha-jenkins Project Koha_19.11_D9 build #414: FIXED in 31 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/414/
23:42 wahanui Congratulations!
23:53 alohabot 🎠🷠Koha '19.11.x' packages pushed to 'koha-staging' repo 🥔🥘ðŸ¥
23:53 koha-jenkins Project Koha_19.11_U16 build #141: UNSTABLE in 43 min: https://jenkins.koha-community.org/job/Koha_19.11_U16/141/
23:53 koha-jenkins Project Koha_19.11_U18 build #376: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/376/
23:57 koha-jenkins Project Koha_19.11_U20 build #285: SUCCESS in 24 min: https://jenkins.koha-community.org/job/Koha_19.11_U20/285/
23:58 koha-jenkins Project Koha_19.11_D11 build #44: STILL UNSTABLE in 49 min: https://jenkins.koha-community.org/job/Koha_19.11_D11/44/