Time  Nick         Message
01:22 alohabot     🎁 🐼 Koha '19.11.x' packages pushed to 'koha-staging' repo 🍺 🥨 🥑
01:26 koha-jenkins Project Koha_19.11_U21 build #13: SUCCESS in 32 min: https://jenkins.koha-community.org/job/Koha_19.11_U21/13/
01:27 koha-jenkins Project Koha_19.11_U16 build #123: SUCCESS in 27 min: https://jenkins.koha-community.org/job/Koha_19.11_U16/123/
01:31 koha-jenkins Project Koha_19.11_D8 build #442: SUCCESS in 35 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/442/
01:33 huginn       News from kohagit: Bug 30129: Add test <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f8ca2d733c786c72ce74e11459872a73658f3e3e>
01:33 huginn       News from kohagit: Bug 30129: remove the third required date that was causing 500 error <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e30efbd0bd0bb6cfbca245ae0a160d27111a570c>
01:33 huginn       News from kohagit: Bug 29625: Add test for get_all_biblios_iterator <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=91c48e27ecd68b0a543cb5902908054fae3e088c>
01:33 huginn       News from kohagit: Bug 30074: Regression tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2ae8d149d3341e7d880051ffed3903fab6262a69>
01:33 huginn       News from kohagit: Bug 30115: Uninitialized value warning in C4/Output.pm <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=10e657e8b7e59364ea04a3bd31f6ac771bf2dddc>
01:33 huginn       News from kohagit: Bug 30099: Fix error when accessing circulation.pl without patron parameter <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=af22b87965774290cc56b6946460f2cedf68a239>
01:33 huginn       News from kohagit: Bug 30074: Add missing extended_attributes rs in DBIC schema <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=78a9de0cd6a60e746e53ed9120f669d6ed3625cc>
01:33 huginn       News from kohagit: Bug 27770: ES: Deprecated aggregation order key [_term] used, replaced by [_key] <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1bfcb995554c61adc56391b07c0eb4d9d3a5fdba>
01:33 huginn       News from kohagit: Bug 29989: Improve headings in MARC staging template <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5433de09c8b5b51a96d1b364c31a16d66f062b76>
01:33 koha-jenkins Yippee, build fixed!
01:33 koha-jenkins Project Koha_Master build #1920: FIXED in 1 hr 11 min: https://jenkins.koha-community.org/job/Koha_Master/1920/
01:33 huginn       News from kohagit: Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=450b629ed3554d893830414be8d2c6c9a96ea69f>
01:33 huginn       News from kohagit: Bug 29962: (bug 27526 follow-up): Fix columns button on item list <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=30c7dd1866138c226284949b1f6bc75ff019c466>
01:34 huginn       News from kohagit: Bug 29853: Add HTML filter before KohaSpan filter <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=be18ee7aa517f647ecb83fe1349af8c88f3e15f8>
01:34 huginn       News from kohagit: Bug 29803: Do not wait for the images more than 5 seconds <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7f4bd35a856bb7714e71efa5e6c0a7788046e436>
01:34 huginn       News from kohagit: Bug 29803: Prevent local cover image to be hidden if Coce is enabled <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1513cd66b68b83614712c9f22947c03eec98d296>
01:34 huginn       News from kohagit: Bug 29795: add empty value for branchcode on self-reg form <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=feee248de491c42c07f42fe3f60ce3e98fb1e81b>
01:34 huginn       News from kohagit: Bug 23873: Unit tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=502a2b54830ce20e9cfb8e2bfc28b7933c69e35f>
01:34 huginn       News from kohagit: Bug 23873: Enable capture groups in MarcModificationTemplates <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0c155dd7b7370f2248fc7e3f56da43e8f2a37e18>
01:34 huginn       News from kohagit: Bug 29761: Prevent batch patron modification to process several time the same patron <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2d9aec24d6edad514435f8f754ee3ddcd248a2d8>
01:34 huginn       News from kohagit: Bug 29625: Fix var name in Koha::BiblioUtils get_all_biblios_iterator <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=73bb8bbee957378b25bc7ce5300ae030f0ecb643>
01:34 huginn       News from kohagit: Bug 22671: Show warning if browser doesn't support applicationCache <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8d1248db4f19683dba80f6ae4bcba561768fb730>
01:34 tuxayo       fridolin: arround?
01:36 koha-jenkins Project Koha_19.11_D11 build #30: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_19.11_D11/30/
01:41 fridolin     tuxayo: i am
01:42 fridolin     wzup ?
01:42 tuxayo       discovering a forgotten DBIx schema update on 20.11 and 19.11 ^^"
01:42 fridolin     ich
01:43 tuxayo       https://privatebin.deblan.org/?77b5d938fd20e01e#CLaUKJr5Nc48mjxn1HYobjU3PSnVuW7defA7WND8bexS
01:43 fridolin     from me ?
01:43 tuxayo       is it possible that I break something if I introduce has_many and belongs_to relationships in DBIx? No right? Because they were missing so if anything it should break things due to not being there, not when finally being there.
01:44 fridolin     yep script doing DBIx schema update is always right
01:44 fridolin     can you find Bug numbers ?
01:45 tuxayo       thanks, with wainui we weren't sure if that could cause surprise. But it seem the surprise it that it worked until now :P
01:46 tuxayo       > from me ?
01:46 tuxayo       I don't know how to find the related ticket. That's weird. git blame on kohastructure on the related table only show several years old tickets.
01:46 tuxayo       Any clue about how to investigate?
01:46 tuxayo       The cause might be the RMaint doc until now mentioning only to run misc/devel/update_dbix_class_files.pl
01:47 tuxayo       But it's incomplete
01:47 tuxayo       I fixed it by linking to the RM doc https://wiki.koha-community.org/wiki/Release_management#Update_the_schema_files
01:47 fridolin     you run DBIx schema update after a fresh install ?
01:47 tuxayo       the dbic command does something equivalent
01:48 fridolin     you may look at Bug 29605
01:48 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 major, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, DB structure may not be synced with kohastructure.sql
01:50 tuxayo       ha ha tomas had the same idea
01:50 fridolin     look for changes in kohastructure and also in updatedatabase.pl
01:50 tuxayo       But 29605 is about updatedatabase.pl not in sync with kohastructure.sql right?
01:50 fridolin     yep
01:50 fridolin     but not backported < 21.11
01:51 fridolin     sooooo not sure we should fix DBIC if it works ^^
01:51 tuxayo       Yes, I also git blamed updatedatabase.pl
01:51 fridolin     (never fix a running machine)
01:51 tuxayo       nothing recent
01:52 koha-jenkins Project Koha_19.11_U20 build #267: SUCCESS in 25 min: https://jenkins.koha-community.org/job/Koha_19.11_U20/267/
01:53 tuxayo       > updatedatabase.pl  not in sync with kohastructure.sql right?
01:53 tuxayo       > yep
01:53 tuxayo       So in theory that shouldn't be related. Maybe?
01:53 tuxayo       (last line was my answser)
01:53 fridolin     I found commut "DBREv Bug 16354 - Fix FK constraints for edifact_messages table"
01:53 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16354 normal, P5 - low, ---, kyle, CLOSED FIXED, Fix FK constraints for edifact_messages table
01:55 fridolin     this does not impact DBIC shema
01:56 fridolin     soooo old
01:56 fridolin     #gtitarcheology
01:56 tuxayo       > but not backported < 21.11
01:56 tuxayo       21.05 is okay. And if doesn't have the changes in the 20.11.x and 19.11.x when running dbix
01:56 tuxayo       very confusing
01:57 tuxayo       > sooooo not sure we should fix DBIC if it works ^^
01:57 tuxayo       We would have to actively prevent the aq & edi schema file to get updated. This would feel so wrong
01:58 koha-jenkins Project Koha_19.11_U18 build #362: SUCCESS in 31 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/362/
01:58 tuxayo       It's just to get more confidence that the late update shouldn't cause issues
01:58 fridolin     sorry i cant give a direct advice, I'm lost
02:00 tuxayo       > this does not impact DBIC shema
02:00 tuxayo       patch: CONSTRAINT emfk_vendor FOREIGN key
02:00 tuxayo       I might likely, because the has_many and belong to should come from the FOREIGN KEYs
02:01 tuxayo       But it's so old. schema generation had the time to be done dozens of times
02:01 fridolin     buuuuuuuuuut  Koha/Schema/Result/Aqbasket.pm already has "edifact_messages"
02:01 fridolin     why does it add "edifact_messages_2s"
02:03 tuxayo       loool indeed
02:03 tuxayo       it's seem to reference the right table though.
02:03 fridolin     https://emojipedia.org/exploding-head/
02:03 fridolin     🤯
02:04 fridolin     look at show create table, possible to have a FK twice ?
02:06 fridolin     I have to go, keep me informed of the investigation Dr Watson ^^
02:08 tuxayo       It's not duplicated in kohastructure.sql
02:15 koha-jenkins Project Koha_19.11_D9 build #396: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/396/
02:16 alohabot     🎁 🦄 Koha 'master' packages pushed to 'koha-staging' repo 🍪 🍆 🥤
02:20 koha-jenkins Project Koha_19.11_U_Stable build #70: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_19.11_U_Stable/70/
02:25 koha-jenkins Project Koha_19.11_D10 build #217: SUCCESS in 51 min: https://jenkins.koha-community.org/job/Koha_19.11_D10/217/
02:27 koha-jenkins Project Koha_Master_D11_CPAN build #536: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/536/
02:42 koha-jenkins Project Koha_Master_U21 build #93: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_Master_U21/93/
03:05 koha-jenkins Project Koha_Master_D9 build #1879: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1879/
03:09 koha-jenkins Project Koha_Master_D11_My8 build #750: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D11_My8/750/
03:20 koha-jenkins Project Koha_Master_U20 build #306: SUCCESS in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_Master_U20/306/
03:23 koha-jenkins Project Koha_Master_D10 build #534: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_Master_D10/534/
03:34 koha-jenkins Project Koha_Master build #1921: UNSTABLE in 1 hr 8 min: https://jenkins.koha-community.org/job/Koha_Master/1921/
03:40 koha-jenkins Project Koha_Master_D12 build #79: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D12/79/
04:07 koha-jenkins Project Koha_Master_U_Stable build #383: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/383/
04:15 koha-jenkins Project Koha_Master_U21 build #94: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_Master_U21/94/
04:22 koha-jenkins Project Koha_Master_D11_MDB_Latest build #801: SUCCESS in 1 hr 1 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/801/
04:31 koha-jenkins Project Koha_Master_D11_CPAN build #537: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/537/
04:41 koha-jenkins Project Koha_Master build #1922: FAILURE in 10 min: https://jenkins.koha-community.org/job/Koha_Master/1922/
04:54 koha-jenkins Project Koha_Master_D9 build #1880: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1880/
04:58 koha-jenkins Project Koha_Master_D11_MDB_Latest build #802: SUCCESS in 35 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/802/
07:45 reiveune     hello
07:51 alex_a       Bonjour
08:11 Joubu        fridolin: the bz kw "dependency" if for Mason, when we need him to check a deb package
08:12 fridolin1    Joubu: ouuua ok i remove
08:14 fridolin1    ah oui did ok
08:14 Joubu        fridolin1: regarding bug 30089 - we stayed one full week with the holds broken at the OPAC. That's why I preferred to follow-up on the same bug report for critical bugs instead of opening new bug report
08:14 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30089 blocker, P5 - low, ---, jonathan.druart+koha, Pushed to master , Placing holds on OPAC broken
08:14 Joubu        we don't want to wait for a full SO+QA process. When it's trivial you should push fast to avoid such critical bugs in master for several days
08:14 ashimema     morning #koha
08:14 fridolin1    yep but since it was already existing
08:15 Joubu        well it's just my opinion
08:15 cait1        sorry, I had missed that last night too L:(
08:15 fridolin1    but i agree we must fix fast
08:16 cait1        i cannot test right now, but fix seems obvious if you wanted to push
08:16 fridolin1    it is pushed
08:17 fridolin1    an ->as_list() missing
08:17 * ashimema   has been a bit slow recently at spotting such bugs
08:18 cait1        problem is: we have tons of bad bugs right now
08:18 ashimema     kinda shows we need to spread that load wider though.. Joubu, Katrin and I are all consistently at the top of the leader boards.. and usually by a significant margin.. if any one of us is snowed under the whole process grinds to a halt
08:19 cait1        everytime I test something, something else explodes... we need some effort of more than a few people to clean that up
08:19 ashimema     adn the SO queue is in a similar state.. the top three are often a long way ahead of the next teir
08:19 cait1        i used to be in the 50s on dashboard, I can't do that right now, I try to fit in as much as I can, but can't do the old amount
08:19 ashimema     yup, me too
08:20 fridolin1    we do wat we can
08:23 ashimema     it was a bit mean at times.. but it meant the stables were actually stable feature wise..
08:24 ashimema     hard..
08:24 ashimema     people want the new things as soon as possible.. hence me wanting a rolling option
08:49 magnuse      \o/
08:51 magnuse      cait++ ashimema++ Joubu++
08:52 cait1        is it ansible rulebook or playbook?
08:52 magnuse      playbook
08:53 cait1        thx :)
11:27 oleonard     Hi #koha
11:31 ashimema     cait1, how did you get the speeling issues reported by the qa script on bug 30135..
11:31 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
11:31 ashimema     I don't see them and am trying to work out if my qa script is set up wrong
11:33 Joubu        ashimema: you need codespell
11:36 * cait1      waves
11:37 cait1        also: could someone help out with an installation issue on bugzilloa?
11:37 cait1        bug 29964
11:37 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 critical, P5 - low, ---, koha-bugs, NEW , SMTP server list not populating
11:37 cait1        it's an API installation issue
11:38 ashimema     I have it
11:38 ashimema     codespell that is..
11:39 ashimema     but it still doesn't appear to be checking spellings
11:42 ashimema     having said that.. I'm sure I've seen spelling issues flagged before.. so I wonder why cait1's flagged that one but mine didn't
12:01 tcohen       LSQ? Why did they make it so it reads as a typo?
12:01 cait         what ARE yo ureading into it?
12:07 ashimema     huh
12:07 ashimema     it's identifies GIR as a mispelling for GIT
12:07 ashimema     which is wrong.. GIR is a segment type in EDI..
12:08 ashimema     but.. my run of the QA script doesn't identify it at all..
12:08 ashimema     which lead me to believe somethings wrong with my QA setup
12:08 ashimema     we can safely ignore it.. as it's spelt correctly..
12:08 cait         yes :) i noted it as a false positive already :)
12:09 ashimema     indeed
12:10 ashimema     I just wanted to check why my qa script isn't hilghighting spellings
12:10 ashimema     oh well
12:10 ashimema     I'll try again another day
12:18 domm         I have (yet another) question that's not really dev-related (I hope). OK to ask here?
12:18 domm         (I'll just ask..)
12:19 domm         when catalouging a new book, Koha does a duplicat check. If there is no ISBN in the new record it builds a title/author query like 'ti,ext:"Book title" and au,ext:"Author, Some''
12:20 domm         but this query does not find anything (using ElasticSearch)
12:20 domm         When I enter the query parts directly into the search slot, I get results, and each query (ti/au) finds the same book
12:21 domm         but when I combind them with and (as it's done in FindDuplicate), the book is not found
12:21 domm         any ideas/hints?
12:21 domm         (or should I take this question to the koha/koha-dev mailinglist?)
12:22 domm         oh, and what does the ',ext' after the field name do?
12:46 cait1        exact field search
12:53 domm         cait1: ok, thanks
12:54 domm         so, I found something weird:
12:55 domm         in Koha::SearchEngine::Elasticsearch::QueryBuilder->build_query we set  default_operator => 'AND' # line 204
12:55 domm         this produces an elastic-search query something like this:
12:55 domm         { "query": { "query_string" : { "type" : "cross_fields", "query" : "(author:Kafka and title:Verwandlung)", "fields":["title","author"], "default_operator":"AND","analyze_wildcard":true,"fuzziness":"auto","lenient":true } }}
12:55 domm         if I run that query via curl, I get no hits
12:56 domm         if I remove "default_operator":"AND", I get hits
13:07 domm         so, no ideas, anybody?
13:07 domm         cait1: and regarding ",ext", this seems to have no effect when using ElasticSearch
13:08 ashimema     kidclamp ^
13:15 kidclamp     How is 'cross_fields' set domm?
13:15 kidclamp     ah, i see it now
13:18 domm         oh, so this is comes from ElasticsearchCrossFields ?
13:18 kidclamp     yes, without it we search for all terms in both fields - i.e. the author and title term had to both existin in the author index or the title index
13:19 kidclamp     can you share the curl you used?
13:21 domm         yeah, but I'm using curl http://localhost:9200/index/_search -X GET -H 'Content-Type: application/json' -d@test.json
13:22 domm         and this works: { "query": { "query_string" : { "type" : "cross_fields", "query" : "(author:'Kafka, Franz' and title:'Die Verwandlung')", "fields":["title","author"], "analyze_wildcard":true,"fuzziness":"auto","lenient":true } }}
13:23 domm         and this yields 0 hits:
13:23 domm         { "query": { "query_string" : { "type" : "cross_fields", "query" : "(author:'Kafka, Franz' and title:'Die Verwandlung')", "fields":["title","author"], "analyze_wildcard":true,"fuzziness":"auto","lenient":true,"default_operator":"AND" } }}
13:23 domm         (you have to put the json into a file and use -d@filename (much easier with the quoting..))
13:25 domm         so cross_fields is correct, I assume
13:25 domm         but I don't understand yet, why default_op is causing this weird behaviour
13:30 domm         ok, this search is using a query string https://www.elastic.co/guide/en/elasticsearch/reference/6.8/query-dsl-query-string-query.html#query-string-syntax
13:30 domm         and uses ES field names and operators (title:, author:, "and")
13:31 kidclamp     I get results with or without default operator
13:31 domm         default_operator should only have an effect if there are no ops used in the query, i.e. if it where "franz kafka"
13:32 domm         kidclamp: hm, ok, it does seem irrelevant
13:32 kidclamp     Ah, I lied - change the 'and' in the query to 'AND' and it works botrh ways
13:33 kidclamp     I did it out of habit - ES is case sensitive to booleans
13:33 kidclamp     lowercase - is a term : uppercase - is a boolean
13:34 kidclamp     so without default_op it is letting you 'OR' and ignoring the 'and', but when you default_op it wants your record to have 'and'
13:39 domm         hm, but in the code it sets it to 'AND', so shouldn't it still work? or is setting default_op wrong?
13:40 domm         ah, so one thing that works is keeping default_op, but NOT adding 'and' to the query :-)
13:41 domm         both these work:
13:42 domm         { "query": { "query_string" : { "type" : "cross_fields", "query" : "(author:'Kafka, Franz' title:'Die Verwandlung')", "fields":["title","author"], "analyze_wildcard":true,"fuzziness":"auto","lenient":true,"default_operator":"AND" } }}
13:42 domm         { "query": { "query_string" : { "type" : "cross_fields", "query" : "(author:'Kafka, Franz' AND title:'Die Verwandlung')", "fields":["title","author"], "analyze_wildcard":true,"fuzziness":"auto","lenient":true,"default_operator":"AND" } }}
13:42 domm         the first one has no op, and falls back to the default op
13:42 domm         the second one has a proper op in uppercases
13:43 domm         and this does not work, because it tries to find a literal 'and':
13:43 domm         { "query": { "query_string" : { "type" : "cross_fields", "query" : "(author:'Kafka, Franz' and title:'Die Verwandlung')", "fields":["title","author"], "analyze_wildcard":true,"fuzziness":"auto","lenient":true,"default_operator":"AND" } }}
13:44 domm         so sorry for the fuzz, it seems that i was sloppy when testing ;-/
13:45 domm         but then I still don't know why the duplicate finder is not finding duplicate :-(
13:47 koha-jenkins Project Koha_21.05_U_Stable build #163: SUCCESS in 32 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/163/
13:50 ashimema     bug 30003 would be a nice one to get through QA..
13:50 ashimema     started off well
13:50 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 major, P5 - low, ---, jake.deery, Signed Off , Register entries doubled up if form fails validation on first submission
13:57 domm         kidclamp: ha, but it IS a bug in Koha: C4::Search->FindDuplicate builds the search query (looks like Zebra) and joins it with lowercase 'and'!
13:58 domm         https://github.com/Koha-Community/Koha/blob/f8ca2d733c786c72ce74e11459872a73658f3e3e/C4/Search.pm#L102
13:59 domm         if I change that to AND, I get duplicates when catalouging!
14:00 domm         I'll submit a bug report & patch
14:00 kidclamp     https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928
14:00 huginn       Bug 27928: normal, P5 - low, ---, nick, RESOLVED FIXED, FindDuplicate is hardcoded to use Zebra
14:02 ashimema     damn, did I miss that in QA
14:02 kidclamp     heh, I missed it too
14:02 domm         kidclamp: ok, but this is not merged yet, is it?
14:02 ashimema     that's in '21.05.00,20.11.05,20.05.11'
14:02 kidclamp     that one is, it made it use the com[pat, but didn't fix the hard coded 'and'
14:02 ashimema     indeed
14:02 domm         so that's another bug?
14:03 ashimema     post a bug and link it and kidclamp and I will SO + QA it in quick fashion 😉
14:03 domm         perfect!
14:03 domm         and wow, adding semantics to upper/lowercase is a bit weird on ElasticSearchs side :-)
14:08 domm         will Zebra break if I just change the 'and' to 'AND'?
14:09 kidclamp     I don't believe so
14:09 kidclamp     but worth testing ;-)
14:11 ashimema     should be fine, but yeah.. worth a test if you can
14:12 ashimema     my understanding is we're passing CCL efectively.. and actually I thought that was also case sensative.. so would have thought it should have already been capitalised.. weird
14:17 koha-jenkins Project Koha_21.05_U18 build #156: SUCCESS in 1 hr 1 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/156/
14:17 alohabot     🎁 🐱 Koha '21.05.x' packages pushed to 'koha-staging' repo 🍨 🍧 🥘
14:20 koha-jenkins Project Koha_21.05_D11 build #195: SUCCESS in 1 hr 3 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/195/
14:22 domm         ashimema: I hope everything is correct: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 (not sure how to link bugs..)
14:23 huginn       Bug 30153: enhancement, P5 - low, ---, koha-bugs, Needs Signoff , FindDuplicate ElasticSearch should not use lowercase 'and'
14:24 koha-jenkins Project Koha_21.05_D9 build #165: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/165/
14:27 koha-jenkins Project Koha_21.05_U16 build #165: SUCCESS in 1 hr 12 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/165/
14:35 koha-jenkins Project Koha_21.05_U20 build #168: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/168/
14:41 ashimema     over to you kidclamp
14:56 kidclamp     meetings, will add to list and try to do today
14:57 cait1        domm: sorry, very much offline today, will try read back later
14:59 koha-jenkins Project Koha_20.11_D10 build #193: SUCCESS in 31 min: https://jenkins.koha-community.org/job/Koha_20.11_D10/193/
14:59 cait1        we have a bug in process that changes a lot of and to AND - Zebra doens't care
14:59 cait1        so we can default to the uppercase as far as I have seen in testing/QA so far without worries
15:01 ashimema     🙂
15:05 cait1        bug 25616 waiting for QA (signed off by me...)
15:05 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 normal, P5 - low, ---, glasklas, Signed Off , Uppercase hard coded lower case boolean operators for Elasticsearch
15:12 koha-jenkins Project Koha_21.05_D10 build #235: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_21.05_D10/235/
15:14 koha-jenkins Project Koha_20.11_U20 build #192: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_20.11_U20/192/
15:18 alohabot     🎁 🐻 Koha '20.11.x' packages pushed to 'koha-staging' repo 🍌 🍎 🍍
15:22 koha-jenkins Project Koha_20.11_U21 build #35: SUCCESS in 51 min: https://jenkins.koha-community.org/job/Koha_20.11_U21/35/
15:34 koha-jenkins Project Koha_20.11_D9 build #187: SUCCESS in 35 min: https://jenkins.koha-community.org/job/Koha_20.11_D9/187/
15:38 koha-jenkins Project Koha_20.11_U18 build #181: SUCCESS in 1 hr 10 min: https://jenkins.koha-community.org/job/Koha_20.11_U18/181/
15:49 ashimema     good call cait
15:52 koha-jenkins Project Koha_20.11_U_Stable build #85: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_20.11_U_Stable/85/
15:55 ashimema     hmm
15:55 ashimema     there's lots of 'and' occurrences still
16:02 cait1        can someone help me out? how long are password reset links vlaid?
16:02 cait1        ashimema: yep,but probably bette to hunt the rest with the bigger patch in first :)
16:03 Joubu        cait1: 2 days
16:03 cait1        is that hardcoded?
16:03 Joubu        Koha/Patron/Password/Recovery.pm
16:03 Joubu        117     my $expirydate =
16:03 Joubu        118       dt_from_string()->add( days => 2 );
16:04 Joubu        yes
16:04 cait1        thx, I didn't spot it and needed a quick answer
16:04 cait1        Joubu++
16:04 reiveune     bye
16:04 ashimema     perhaps
16:06 koha-jenkins Project Koha_20.11_U20 build #193: SUCCESS in 31 min: https://jenkins.koha-community.org/job/Koha_20.11_U20/193/
16:08 koha-jenkins Project Koha_20.11_U16 build #163: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_20.11_U16/163/
16:17 Brooke       o/
16:18 koha-jenkins Project Koha_20.11_D11 build #222: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_20.11_D11/222/
17:15 koha-jenkins Project Koha_20.11_D11 build #223: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_20.11_D11/223/