Time Nick Message 22:33 koha-jenkins Project Koha_20.05_D10 build #338: FIXED in 50 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/338/ 22:33 wahanui Congratulations! 22:33 koha-jenkins Yippee, build fixed! 22:26 koha-jenkins Project Koha_Master_D11_MDB_Latest build #732: FIXED in 43 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/732/ 22:26 wahanui Congratulations! 22:26 koha-jenkins Yippee, build fixed! 17:56 ashimema Anyone here join the ChatOpenS debates on twitter? One of our newest members of the PTFS-E team is moderating tonight :-) 17:45 cait1 bye all 17:04 * ashimema really would love to switch to git branches rather than patches.. more and more I'm finding patches on bugzilla a nightmare to deal with 17:04 oleonard I just get so excited 17:04 ashimema I'm always doing that 17:03 ashimema hehe 17:03 oleonard Oh I'll bet I missed a patch 17:02 ashimema I can't get it to apply right now but will certainly look at it as soon as I can 🙂 17:02 ashimema well, I certainly appreciate it. 17:02 ashimema hehe 🙂 17:01 oleonard ashimema: You left a trail of candy from the forest straight to the bug, I thought you meant for me to follow it 16:59 ashimema ooh. you jumped on my notices bug.. thanks oleonard 16:58 ashimema 🙂 16:49 cait1 ashimema++ # calendar help 16:40 oleonard tcohen: Where are mail errors logged? 16:36 tcohen otherwise, you can put that data into koha-conf.xml 16:36 tcohen oleonard, you need to assign it to each library 16:35 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 enhancement, P5 - low, ---, koha-bugs, NEW , One should be able to assign an SMTP server as the default 16:35 oleonard Oh I see... Bug 27424 16:33 oleonard I put in my GMail details as a new SMTP server but it looks like it's trying to use the default localhost anyway 16:31 oleonard Anyone around who knows about SMTP servers and the message queue? 16:05 reiveune bye 14:28 ashimema thanks for working so hard on it Joubu 14:28 * ashimema will take another look shortly 14:27 tcohen Joubu++ 14:20 Joubu ashimema: I am done with the flatpickr bugs, it's still not perfect however :-/ 14:03 ashimema 🙂 14:02 tcohen maybe we should write a regression test for that 14:02 tcohen ashimema: you are right 13:57 ashimema it could be anywhere down the join chain.. so `me` won't always make sense will it? 13:56 ashimema though I wonder about the hard coded `me.branchcode`.. wouldn't we need to replace the `me` with current_source_alias or something.. 13:56 ashimema i like the idea of using search_limited now I've read it more.. 13:55 ashimema I see I think 13:55 ashimema hmm 13:54 tcohen but it should be the Koha::Object-based class responsability 13:54 tcohen and the same for a (say) city that shuoldn't be displayed for the user 13:54 tcohen i.e. if Koha::Patron->to_api is called on a chain because of an embed, I would just do the check and return undef 13:53 tcohen for the emebed, I think we need to pass the requester $patron all the way down in to_api() and act accordingly when appropriate 13:52 ashimema suppose search_limited would return 'undef' the same as if you filtered after in to_api using can_see_patron_infos 13:52 tcohen objects.search could check if the class implements search_limited and use it 13:52 ashimema hmm 13:51 tcohen yes, that too 13:51 tcohen it could be done in objects.search 13:51 ashimema I was thinking about it from the `GET /biblios/{biblio_id}/checkouts?embed=patron` perspective 13:51 tcohen and it is obvious it needs to use search_limited instead of plain search 13:50 tcohen I was looking at the GET /patrons route as a start 13:50 wahanui everywhere is a bit scary at the moment :( 13:50 tcohen everywhere 13:50 ashimema or just at the patrons/ endpoints themselves? 13:50 ashimema using search_limited for relation traversal in embed? 13:50 ashimema what are you considering tcohen? 13:49 tcohen Koha/Reviews.pm:sub search_limited { 13:49 tcohen Koha/Patrons.pm:sub search_limited { 13:49 tcohen Koha/Patron/Discharge.pm:sub search_limited { 13:49 tcohen Koha/ArticleRequests.pm:sub search_limited { 13:48 tcohen $ git grep 'sub search_limited' 13:48 * tcohen does a git grep search_limited 13:47 Joubu and you will have the join (or whatever it's doing) anyway for the libraries_where_can_see_patrons call 13:47 tcohen ok 13:47 Joubu the find does not trigger a select 13:47 Joubu imo you won't gain anything 13:47 tcohen to do this, for all routes, generically 13:46 tcohen I'm trying to think of a clean way 13:46 tcohen yes 13:46 Joubu are you asking in term of perf? 13:46 Joubu you will need to fetch the libraries anyway 13:44 tcohen :-D 13:44 tcohen I just asked 13:44 ashimema sorry.. was having lunch 13:44 ashimema hi 13:43 wahanui ashimema is back on security bugs today.. sorry, it's been a bit of a crazy week 13:43 tcohen ashimema? 13:41 tcohen the current behavior is it reads userenv and fetches the patron to get the patron branchcode... 13:41 tcohen this is true on the API (which is were I'm looking at) but also on .pl controllers 13:40 tcohen the controllers usually have the $logged_in_patron already 13:40 tcohen Joubu: what do you think of adding a $patron parameter to Koha::Patrons->search_limited? 11:58 koha-jenkins Project Koha_Master_D11_MDB_Latest build #731: UNSTABLE in 51 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/731/ 11:34 tcohen good morning 11:33 oleonard Hi all 11:06 ashimema â˜¹ï¸ 11:06 koha-jenkins Project Koha_Master_D11_MDB_Latest build #730: SUCCESS in 52 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/730/ 11:05 Joubu I guess there is some funky JS somewhere that did that 11:05 ashimema indeed 11:05 Joubu if you pick dates in the past, 23:59 is set 11:05 Joubu the previous behaviour is: if you pick today's date then current hh:mm is selected 11:04 ashimema it's a logical pain 11:04 ashimema which feels a bit wrong too 11:04 ashimema right 11:04 ashimema that way, if you pick just a date in the past and wanted the default time elements.. you'd get the 'now' time instead of the 23:59 11:04 ashimema and.. I'm not confident that would be right either would it.. 11:03 ashimema hmm 11:03 Joubu but 00:00 still set 11:03 Joubu } 11:03 Joubu + options['defaultMinute'] = now.getMinutes(); 11:03 Joubu + options['defaultHour'] = now.getHours(); 11:03 Joubu + let now = new Date(); 11:03 Joubu options['maxDate'] = "today"; 11:03 Joubu if( $(this).data("flatpickr-pastinclusive") === true ) { 11:03 Joubu I wrote something but it does not work 11:02 ashimema can't for the life of me think of a way around it though. 11:02 ashimema valid..e ven 11:02 ashimema yeah.. Owens comment is perfectly balid 11:02 koha-jenkins Project Koha_Master_D11_My8 build #695: SUCCESS in 58 min: https://jenkins.koha-community.org/job/Koha_Master_D11_My8/695/ 10:57 ashimema thanks 10:57 wahanui darn tootin' it is. 10:57 ashimema excellent 10:56 koha-jenkins Project Koha_Master_U20 build #244: SUCCESS in 51 min: https://jenkins.koha-community.org/job/Koha_Master_U20/244/ 10:55 koha-jenkins Project Koha_Master_D9 build #1823: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1823/ 10:52 Joubu ashimema: git bz apply 29394 29500 29478 10:51 Joubu wait a min 10:50 koha-jenkins Project Koha_Master_D11 build #451: SUCCESS in 32 min: https://jenkins.koha-community.org/job/Koha_Master_D11/451/ 10:50 Joubu ha, the last patch maybe 10:49 ashimema so yeah.. still bad 10:49 ashimema nah, checked fetching before commenting here 😉 10:49 Joubu let me know if still not apply and I will resubmit 10:49 Joubu but also pushed things this morning 10:48 Joubu that's possible, I have attached patches on different bug 10:48 Joubu git fetch? 10:48 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 normal, P5 - low, ---, jonathan.druart+koha, In Discussion , Remove flatpickr instantiations from .tt files 10:48 ashimema I get sha1 issues trying to apply bug 29394 10:48 Joubu Owen's comment is valid however 10:48 ashimema hum 10:44 ashimema looks good to me having now dug into the code 10:38 ashimema I'm more than happy to have it instantiated from classes and then reach inside and grab the instance to plumb in the extra's one may need 10:37 ashimema that's a solid improvement 🙂 10:37 ashimema cool 10:37 Joubu and we must never copy/paste code :) 10:37 Joubu because we have to copy code from calendar.inc 10:37 Joubu I am suggesting to not instanciate from tt 10:36 ashimema I will look at the code 10:36 Joubu now I just need something that works for 21.11 10:36 ashimema OK.. if not, then cool 10:36 ashimema I thought you were proposing we never touch the instantiated object 10:36 ashimema and I do 10:36 ashimema yeah.. 10:36 ashimema my bookings stuff for example does API calls to get dates to disable 10:36 Joubu you can still do it 10:36 ashimema there are times when you need/want to dig into the instantiated object itself 10:35 ashimema I personally don't think it's viable to completely rely on classes only 10:35 ashimema mm, nasty stuff 10:34 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 major, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Flatpickr accepting original date in the past for futuredate but also other dates in the past 10:34 Joubu yes, and bug 29500 10:34 ashimema kinda tied up with work bits at the minute but was hoping to spend a few minutes taking a look 10:34 ashimema that was next on my list to look at 10:34 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 normal, P5 - low, ---, jonathan.druart+koha, In Discussion , Remove flatpickr instantiations from .tt files 10:34 ashimema bug 29394 per chance 10:34 Joubu it's getting messy :D 10:33 ashimema what's up with flatpickr? 10:33 ashimema I was going to ask about using UNIONs.. but have found a way around it now 10:25 Joubu flatpickr is driving me crazy right now, so kind of my head is exploding 10:25 Joubu ashimema: yes 10:25 Joubu yes 10:19 ashimema Joubu around? 10:18 koha-jenkins Project Koha_Master_D11 build #450: SUCCESS in 32 min: https://jenkins.koha-community.org/job/Koha_Master_D11/450/ 10:12 koha-jenkins Project Koha_Master_D11_CPAN build #476: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/476/ 10:08 koha-jenkins Project Koha_Master build #1822: FIXED in 1 hr 6 min: https://jenkins.koha-community.org/job/Koha_Master/1822/ 10:08 wahanui Congratulations! 10:08 koha-jenkins Yippee, build fixed! 10:05 fridolin cait1: super thanks 10:04 koha-jenkins Project Koha_Master_U20 build #243: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_Master_U20/243/ 10:03 koha-jenkins Project Koha_Master_D12 build #28: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_Master_D12/28/ 09:45 koha-jenkins Project Koha_Master_U_Stable build #321: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/321/ 09:33 koha-jenkins Project Koha_Master_D9 build #1822: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1822/ 09:12 koha-jenkins Project Koha_Master_U21 build #28: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_Master_U21/28/ 09:07 koha-jenkins Project Koha_Master_U20 build #242: SUCCESS in 58 min: https://jenkins.koha-community.org/job/Koha_Master_U20/242/ 09:06 koha-jenkins Project Koha_Master_U_Stable build #320: SUCCESS in 59 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/320/ 09:01 koha-jenkins Project Koha_Master_D11_CPAN build #475: SUCCESS in 53 min: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/475/ 09:00 koha-jenkins Project Koha_Master_D11_MDB_Latest build #729: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/729/ 08:48 koha-jenkins Project Koha_Master_D11_My8 build #694: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_Master_D11_My8/694/ 08:44 huginn` News from kohagit: Bug 29270: start_for is actually date_to <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7bddfeb412e427ee8c02c700295382fe4a7340d6> 08:39 koha-jenkins Project Koha_Master_D11 build #449: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D11/449/ 08:11 ashimema morning 08:11 cait1 just for info - strings on tarnslate have been updated :) 21.11 and meint releases 08:05 huginn` News from kohagit: Bug 29477: Flatpickr - default to 23:59 for the time part <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ad50d6ad6f856b7c6ea84838ca5fe9a22d1ab9c4> 08:05 huginn` News from kohagit: Bug 29270: Expiration date must be in future <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=34422de230d4caa5053ef4e91e3f9446c266b753> 07:20 wahanui hi, alex_a 07:20 alex_a Bonjour 02:27 koha-jenkins Project Koha_Master build #1821: STILL UNSTABLE in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_Master/1821/ 00:44 koha-jenkins Project Koha_20.05_D9 build #341: SUCCESS in 1 hr 7 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/341/ 00:37 huginn` dcook: The operation succeeded. 00:37 dcook @later tell Joubu No I migrated phpBB to Discourse 00:23 koha-jenkins Project Koha_20.05_D10 build #337: UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/337/ 00:10 koha-jenkins Project Koha_20.05_U21 build #12: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_20.05_U21/12/ 00:08 koha-jenkins Project Koha_20.05_U18 build #216: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/216/