Time Nick Message 06:16 fridolin hi there 06:17 reiveune hello 06:53 alex_a Bonjour 07:48 Noor_ Hi there, I need your advise and support for fixing an issue. I am using Koha 20.05.05.000 and downloading accession register report. The file gets downloaded, but when I open it, it shows file is corrupted. Your help would be highly appreciated 08:12 mtj hi Noor_, how is the file corrupted, can you paste an example, http://paste.koha-community.org/ 08:17 Noor_ Hi Alex, do you want me to put query in the paste space, i do not think i can attach a file 08:56 mtj Noor_: paste an example of a corrupted line from your report 08:59 mtj Noor_: i think the report is probably ok, but you are opening it incorrectly in your spreadsheet app (excel or opencalc) 09:11 Noor_ Hi mtj, rest of the reports are opening correctly in excel 09:44 ashimema do we really allow holds on withdrawn items? 09:45 * ashimema is reading code and was surprised to see how little filter_by_for_hold actually filters out 09:45 cait1 we don't use that status really... 09:45 ashimema oh really 09:45 ashimema that's interesting 09:45 cait1 we delete right away 09:45 cait1 sometimes we have items from migrations, but as Koha stors deleted items still, must libraries are happy to delete 09:46 * ashimema is working out what should denote 'bookable' material in his bookings development. 09:46 cait1 I've been wondering if our translation of withdrawn is wrong...Ausgeschieden? (removed from collection permanently?) 09:46 cait1 possibly I'd remove lost and withdrawn (from bookable) 09:46 ashimema interesting 09:47 ashimema I've never really got to grips with what 'withdrawn' actually means 09:47 ashimema kinda just feels like another 'not for loan' value to me 09:47 ashimema :) 09:47 ashimema thanks cait1.. that's what my gut was saying 09:51 Joubu ashimema: related, see bug 3142 ;) 09:51 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 normal, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Standardize how OPAC and staff determine requestability 09:52 Joubu lowest bug number in the queue! 09:52 ashimema ooh, yes of course 09:52 ashimema that one was on my list to look at.. totally forgot :) 09:52 ashimema thanks Joubu 09:52 * ashimema will read that during a quiet moment in this meetings 09:57 ashimema that's an awesome piece of work Joubu.. why has it taken me soooo long to properly look at it! 09:59 Joubu no idea! 09:59 Joubu :) 10:01 ashimema have you tested it for performance implications on search? 10:01 ashimema I generally love the code... 10:02 ashimema just wonder about perf as it looks like we introduce an extra two queries per search result 10:02 * ashimema might be wrong.. skim reading whilst doing meeting 10:06 ashimema we could probably reduce that by one query per result pretty easily.. instead of doing a Koha::Biblio->find.. why not go straight for Koha::Items->search({biblionumber => $biblionumber})->filter_by_for_hold; 10:06 * ashimema will comment on the bug 10:08 Joubu ashimema: the ->find call already exists 10:10 ashimema interesting 10:10 ashimema I'll look at it in context in a moment. 10:10 ashimema but the patch certainly looks like it introduces one 10:10 ashimema https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=3142&attachment=122317 10:11 Joubu in C4/Search.pm? 10:12 ashimema yup 10:12 Joubu at the bottom of C4/Search.pm, the last chunk is a ->find call 'removed' 10:13 Joubu $oldbiblio->{biblio_object} = Koha::Biblios->find( $oldbiblio->{biblionumber} ); 10:13 Joubu https://snipboard.io/ERsd70.jpg 10:14 ashimema Ho dang 10:14 ashimema Code blind already today.. that's doesn't bode well :-) 10:14 fridolin byby 10:15 ashimema Did you see David's comment about onshelf settings? 10:16 Joubu I don't understand his suggestion 10:16 ashimema me either 10:17 ashimema but it's certainly a valid point to raise.. I'll try and get a little closer to the code to understand it 10:19 Joubu the patches are really only reusing a method that exists, instead of having the code copied in controllers. That's their only ambition 10:19 Joubu unique* 10:28 ashimema Indeed 10:28 ashimema Let's get this in as is and follow on with the onshelf code once more familiar with it I reckon 10:29 Noor_ Hi there, I need your advise and support for fixing an issue. I am using Koha 20.05.05.000 and downloading accession register report. The file gets downloaded, but when I open it, it shows file is corrupted. The rest of the reports are downloaded and opening properly. Your help would be highly appreciated 10:31 Joubu define "corrupted" 10:45 oleonard Noor_: What file type is your download? 11:07 tcohen hola #koha 11:34 ashimema mornin' tcohen 11:45 marcelr hi #koha 11:45 marcelr ashimema: sorry to spoil your signoff ;) 12:25 marcelr Joubu: some code might need a disclaimer that real world results will vary - the intelligent guess approach 12:26 marcelr educated guess? 12:27 Joubu marcelr: yes, I will add a note to the POD 12:44 marcelr talking about requestability or availability, added bug 29174 12:44 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29174 normal, P5 - low, ---, koha-bugs, NEW , Availability colors are not consistent in the codebase 12:51 oleonard Hi caroline 12:51 caroline hello! 12:53 marcelr hi oleonard and caroline 12:57 ashimema :) 12:57 ashimema teamwork++ 13:07 marcelr cool fix bug 29175 13:07 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 enhancement, P5 - low, ---, m.de.rooy, Passed QA , finishreceive: Replace , by ; 13:50 marcelr ashimema: $item->booksellerid($booksellerid); # TODO This should be done using ->set, but bug 21761 is not resolved 13:50 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 critical, P1 - high, ---, martin.renvoize, CLOSED FIXED, Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' 13:50 marcelr ashimema: this todo could be just removed, I guess? 13:51 ashimema humm.. perhaps 13:51 ashimema brain isn't in that space right now 13:52 Joubu or use ->set :) 13:52 ashimema indeed 13:54 marcelr why? 13:55 marcelr what is against object->column(value) ? 13:56 Joubu it's prettier to use set when you have several attrs to set :) 13:56 Joubu the fixme is on the whole block, not only the line where it's put 13:58 ashimema time to drive home 13:58 ashimema see you all later :) 14:02 marcelr ok 14:20 * oleonard biab 14:54 tcohen ->set++ 15:05 caroline has anyone ever seen this? https://snipboard.io/uIrCdg.jpg 15:05 caroline an item is created with the biblionumber +1 in date accessioned 15:05 caroline so weird 15:05 matts wow, strange 15:06 caroline its highly hacked rn bc were trying to find the source of this date 15:07 Joubu wrong mapping? 15:07 caroline 952$d is mapped to dateaccesioned 15:08 caroline it also only does this with the defult framework, but I'm comparing it with other and I can't see what could be the problem 15:40 reiveune bye 15:41 caroline Ok so I found the problem, in case someone looks at this in the future... In the Default Framework, 999$d (biblioitemsnumber) was in tab 10 instead of "ignore" 15:41 caroline The initial problem was that after saving the record, there was an internal server error 15:42 caroline I kept looking at 952, but the problem was in 999... sigh 16:11 caroline ashimema: can I ask you a question about payouts? 16:13 oleonard Oh excellent I was wondering when we'd all be getting paid. 16:14 caroline lol!! 16:16 caroline but seriously, I don't understand how they are saved in account_offsets... there are 2 offsets for the refund and 2 offsets for the payout and I don't get why 17:25 ashimema caroline still around? 17:26 ashimema Every accountline always had a 'create' offset (only one of credit_id or debit_id will be set for those).. 17:27 ashimema The other offset is the actual 'offset'... i.e. The rigid of one line being applied to the other 17:36 caroline I think in master it's a bit easier to understand. I'm working with 20.05 and the offsets only say "PAYOUT" so it's hard to make a report to accurately represent the earnings 17:56 tcohen caroline: I think the CREATE offset doesn't make sense 18:18 oleonard cait around? 18:18 wahanui it has been said that cait around is cait cait1 cait2 cait3 cait4 cait5 18:19 cait LOL 18:19 cait actually ont, but I could not really resist that 18:20 oleonard Well not urgent but I asked because I'm looking again at Bug 28993 again and I'm not really sure what comment 2 means 18:20 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 enhancement, P5 - low, ---, oleonard, ASSIGNED , Switch magnifying class in staff detail pages to FA icon 18:21 cait I think that was totally a red hering :) 18:21 cait bu tthere is a tree view thing for uathorities 18:21 oleonard Right, which I knew how to test at one time and have forgotten 18:22 oleonard I don't know how to modify a record to trigger the tree menu 18:24 oleonard I knew enough to produce this screenshot three years ago: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77307 (with absolutely made-up data) 18:30 tcohen hola khall 18:48 tuxayo good bot wahanui !