Time Nick Message
04:33 dusha Hello everyone, I just installed koha over ubuntu 20.04. Iam going to use the subdomin like opac.xxx.gov.xx.where are required places this domin be placed?
06:50 alex_a Bonjour
07:15 * cait waves
07:16 tuxayo o/
07:46 nugged o/
07:46 nugged mates, may it be bigger issue than just with "demo" key in the config?
07:46 nugged Here some info:
07:46 nugged we have, for example, in /svc/config/systempreferences line 68:
07:46 nugged `unless ( C4::Context->config('demo') ) { ... `
07:46 nugged ... and like that "if/unless ... C4::Context->config" usage for many other config vars in the code, but with current master (or around) I suspect since that "lazy load" and "smaller memory footprint" (how that ticket was named) feature with configs, maybe that brought this, because now:
07:46 nugged it's never fails because it returns _REFERENCE_TO_HASH_, even the hash is empty:
07:46 nugged ```
07:46 nugged sub set_preferences {
07:46 nugged warn C4::Context->config( 'demo' );
07:46 nugged warn C4::Context->config( 'demo' ) ? 'TRUTH' : 'FALSE';
07:46 nugged warn Dumper(C4::Context->config( 'demo' ));
07:46 nugged unless ( C4::Context->config('demo') ) {
07:46 nugged ...
07:46 nugged ```
07:47 nugged Gives:
07:47 nugged [2021/09/20 10:42:56] [WARN] HASH(0x5646ead56e00)
07:47 nugged [2021/09/20 10:42:56] [WARN] TRUTH
07:47 nugged [2021/09/20 10:42:56] [WARN] $VAR1 = {};
07:49 cait hm I thought demo was one of the ones we had killed a long time ago
07:59 nugged ... https://git.koha-community.org/Koha-community/Koha/src/branch/master/svc/config/systempreferences#L98
07:59 nugged looks like it is only in that place: https://git.koha-community.org/Koha-community/Koha/search?q=config+demo
08:00 cait sorry, meeting :(
08:07 nugged Who made our bugzilla soo clever? :) I am blocked... as spammer :) LOL
08:34 nugged (I tried to post those links in comment, as JB did for me: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227#c9 )
08:34 huginn Bug 12227: enhancement, P5 - low, ---, jonathan.druart+koha, CLOSED FIXED, Remove demo user functionality
08:34 nugged so, seems, we just need to remove those "C4::Context->config( 'demo' )" as all was removed in 12227, ok, ...
08:35 nugged but we might have other places where "empty hash" passed through as "TRUTH" from this ->config method, btw. Just to note.
08:37 Joubu nugged: can you open a new bug report?
08:38 nugged yes that what I planned to do – just to remove, same like in 12227, right?
08:38 Joubu yes
08:38 nugged oki.
08:54 ashimema go team
09:14 cait Joubu++ ashimema++
09:15 cait nugged++ too :)
09:15 cait but the others for help with the calendar
10:09 ashimema silly question
10:10 ashimema there's a div on the cities page.. with class table_cities_table_controls
10:10 ashimema anyone know what that for.. it's always empty for me.
10:14 oleonard Hi #koha
10:17 oleonard ashimema: I wonder if that was left over from some kind of work-in-progress state of the page
10:18 ashimema yeah.. that's what I'm wondering
10:19 ashimema it's a recent add
10:19 ashimema look like Joubu
10:19 ashimema I'm sure there must have been a reason
10:23 Joubu I cannot remember what this is for. Certainly "[un]select all" links I never implemented.
10:27 oleonard Joubu was planning to allow us to nuke multiple cities at once :O
10:27 ashimema aha, i see
10:45 Joubu oleonard: What's your thoughts about bug 28927 comment 12?
10:45 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 normal, P5 - low, ---, fridolin.somers, Passed QA , Id opacmainuserblock used twice in OPAC
10:46 Joubu => class="opacmainuserblock" vs id="OpacMainUserBlock"
10:47 oleonard I haven't been following it, but off the top of my head I think the class is correct. Let me look.
10:49 oleonard Hm, no... There should be a single OpacMainUserBlock, not two. The class would be correct if it were repeated for each additional content entry, but it's not.
10:50 Joubu yes, that's my point
10:52 oleonard I agree with the change removing the divs from opac-main.tt and opac-registration-confirmation.tt, those are cleanups I should have done earlier.
10:52 oleonard However I think the id in html_helpers.inc should stay.
11:13 tcohen good morning
11:22 * cait waves
12:11 ashimema mornin' tcohen
12:23 tcohen hi ashimema
12:35 Joubu Seeing something weird, I am wondering in which parallel world I am
12:35 Joubu t/db_dependent/Biblio.t is failing for me on master, but Jenkins seems happy
12:36 Joubu to make it pass I need to:
12:36 Joubu - use C4::Context qw( config new preference userenv _new_userenv set_userenv );
12:36 Joubu + use C4::Context;
12:36 Joubu Can someone prove Biblio.t locally?
12:48 TimothyAlexis We're upgrading to Koha 21.05.03. We are using ElasticSearch and are wondering if Zebra needs to be installed because of some dependency or something?
12:51 ashimema are you intended to get back onto the flatpickr stuff oleonard?
12:52 huginn News from kohagit: Bug 17600: Remove wrong C4::Context imports <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d587341d3401f5c165b221f1850360f3b10224dc>
12:52 huginn News from kohagit: Bug 28972: DBIC schema changes <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e176c4edce47258b50f46c08e468a0c1f44dd556>
12:52 huginn News from kohagit: Bug 28972: DBRev 21.06.00.022 <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=80af49bcf7c3adf9eab5394772ee70f2f4d59d5d>
12:52 huginn News from kohagit: Bug 28972: Make DB rev idempotent <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=36a37b245d8debe63e39c9eb551f3c169e68eada>
12:52 huginn News from kohagit: Bug 28847: Remove dead code and make regex consistent <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=87de9fbb8aa8aa4940cad8b2e6eb9a62bb9a401f>
12:52 huginn News from kohagit: Bug 28847: (follow-up) Handle branch_group_limit <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c4955c69243cf2aeca7293d2a50ce94c9f9337cd>
12:52 huginn News from kohagit: Bug 28985: Force positive numbers for itemtype charge fields <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b296474cef4ec7b7eb491757cf7b230f481bef67>
12:52 huginn News from kohagit: Bug 28992: Resolve warning on BIG_LOOP <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e3c1b2068ff2f0c136f706ce0ec213c332e818c0>
12:52 huginn News from kohagit: Bug 28972: Add missing foreign key constraints to holds queue table <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7170fe2cc5f30e055ffa3ab33648e977ffd3a25c>
12:52 huginn News from kohagit: Bug 28316: escape ES ranges if QueryAutoTruncate is enabled <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cc988b2d16cc0399a979d3ce491e29084a0d1166>
12:52 huginn News from kohagit: Bug 28316: (QA follow-up) Make clean_search_term public <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5bbafce7204c6c1e0e87578f4abaf79713458c5e>
12:52 huginn News from kohagit: Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first... <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=63437e25726568bb44c7274e8eb7c23d3ea009b3>
12:52 huginn News from kohagit: Bug 28847: Only apply JS to branch/multibranch selection if there are search groups <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=109bbcf2421a66b31082ed93019fcbfbf643ee0b>
12:52 huginn News from kohagit: Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=065ec4e7260cb00279978e9cc1fa9b9c8d5232c4>
12:52 huginn News from kohagit: Bug 28316: escape brackets in the search query <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fa39f9a65efc15a7b6bcd4d0f4629294ab962060>
12:52 huginn News from kohagit: Bug 28653: Add new method RefreshIssuesTable <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=93e02e8178d4e51c222ca8b2769a7b5ce7f8ca0c>
12:52 huginn News from kohagit: Bug 28316: escape exclamation signs in the query <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0083f96bc9238148a67a58512331144e28b08c94>
12:52 huginn News from kohagit: Bug 28316: screen unquoted semicolons and all followup colons <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=999f8ba0a8f36b3237e3e18758738bdb3812d31a>
12:52 huginn News from kohagit: Bug 28316: add tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=da9fcb01532ad143c78ca93cc84063b5982a86f0>
12:52 huginn News from kohagit: Bug 28316: avoid messing up regexes in the search queries <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3ce2810324fc28d5f9c9791ee7ec7805df94ff3e>
12:52 oleonard ashimema: Yes, but I don't object if you'd like to take a crack at any aspect of it. I'm disappointed that the keyboard navigation is problematic.
12:53 ashimema okies..
12:53 ashimema I have no idea how to approach fixing that accessibility issue
12:53 ashimema it's understandable but annoying that people want to be able to still manually enter dates
12:54 oleonard I must admit that I like having the option.
12:55 ashimema indeed
12:55 ashimema it's useful
12:55 ashimema but..
12:55 ashimema annoying it breaks the component
13:00 cait Imagine navigating a calendar with a screen reader
13:00 cait i have heard it - with our current plugin, i would not want to submit anyone to that
13:00 ashimema hahahaha
13:00 ashimema that's the entire issue I'm pointing out cait
13:00 cait yep i know, just saying it's real
13:00 cait we investigated that some when we still had the library with the blind staff person
13:01 ashimema the jQeury one can be.. the flatpickr one can but it breaks if you enable normal imput
13:01 ashimema it's a bug
13:01 cait has it been reported to their project?
13:01 ashimema yup
13:01 cait :(
13:01 cait just thinking probably not an easy fix than if known and not done
13:02 ashimema owen found it: https://github.com/flatpickr/flatpickr/issues/1329
13:04 ashimema I think people have fixed it in various ways
13:04 ashimema but none have been submitted
13:08 TimothyAlexis Since we're upgrading to Koha 21.05.03 soon and we are using ElasticSearch, we are wondering if we need to install Zebra because of internal dependencies, or if we can skip it.
13:12 Joubu TimothyAlexis: it's still used if you need the Z3950 server
13:17 ashimema er,,
13:17 ashimema is that true
13:17 Joubu is that wrong?
13:18 Joubu could be, I thought it was still required
13:18 ashimema I thought that was the whole point of the Z3950Responder stuff?
13:18 ashimema it allows ES to function as a Z3950 responder
13:18 ashimema so you no longer need zebra..
13:18 ashimema I think
13:19 ashimema but.. we have some funky stuff in our packages which means zebra I think still gets installed.. even thought it's not actually required/used
13:19 ashimema I might be wrong
13:19 ashimema bug 13937
13:19 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 new feature, P5 - low, ---, ere.maijala, Pushed to master , Add an Elasticsearch-compatible Z39.50/SRU daemon
13:20 ashimema TimothyAlexis: ^
13:20 ashimema take a look at that bug
13:20 ashimema I might be mis-remembering
13:22 koha-jenkins Project Koha_Master_D12 build #8: FAILURE in 27 min: https://jenkins.koha-community.org/job/Koha_Master_D12/8/
13:32 koha-jenkins Project Koha_Master_D11_CPAN build #430: UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/430/
13:38 koha-jenkins Project Koha_Master_D10_MDB_Latest build #688: UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D10_MDB_Latest/688/
13:44 koha-jenkins Project Koha_Master_U20 build #188: UNSTABLE in 49 min: https://jenkins.koha-community.org/job/Koha_Master_U20/188/
13:46 ashimema oleonard, got a moment to chat?
13:46 oleonard Yup
13:47 koha-jenkins Project Koha_Master_U_Stable build #253: FAILURE in 2 min 59 sec: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/253/
13:47 ashimema I'm looking to add a button to the catalog details toolbar..
13:47 ashimema that triggers a modal form.
13:47 ashimema so..
13:48 ashimema I've been following the newish modal model of adding the model into inc/modals/
13:48 ashimema so it can be re-used.. as I know I'll want to add it elsewhere too
13:48 ashimema but.. it required a js include (for the form handling and datepicker stuff)
13:49 ashimema where would you suggest is the best/recommended place to put that JS
13:49 ashimema in other instances I've not added to a toolbar..
13:49 ashimema well.. not an inc toolbar
13:49 ashimema so it's been simple
13:49 ashimema [% INCLUDE modals/my_modal.inc %]
13:50 oleonard I think catalog.js is included everywhere the catalog toolbar is
13:50 ashimema followed at the bottom of the page in the jsinclide block
13:50 ashimema by [% Asset.js(js/my_modal.js) %]
13:50 ashimema aha
13:50 ashimema cool
13:51 ashimema so I should be able to just load it into there and not have to worry about catching every file that references the cat-toolbar.inc to add my js include to the bottom
13:51 ashimema ta..
13:51 * ashimema thinks we might need to think about this a bit in the future..
13:52 ashimema hmm
13:52 ashimema can you reference one js file from another..
13:52 ashimema so it can still be seperate and usable for other cases?
13:53 * ashimema thinks we need a frontend framework asap :P
13:53 oleonard Yeah it's a bit of a mess.
13:54 oleonard https://api.jquery.com/jQuery.getScript/
13:54 oleonard That's used in a few places
13:54 ashimema Ta
13:55 oleonard And the advanced cataloging editor uses require.js, but I think that's the only place.
13:55 oleonard It's an aspect of JS that I'm not well-versed in.
13:56 koha-jenkins Project Koha_Master build #1752: UNSTABLE in 1 hr 2 min: https://jenkins.koha-community.org/job/Koha_Master/1752/
13:59 koha-jenkins Project Koha_Master_D9 build #1762: UNSTABLE in 1 hr 5 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1762/
14:00 Joubu khall: can you have a look at the failing tests caused by bug 28972 please?
14:00 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 minor, P5 - low, ---, kyle, Pushed to master , Add missing foreign key constraints to holds queue table
14:04 koha-jenkins Project Koha_Master_D10_My8 build #649: UNSTABLE in 31 min: https://jenkins.koha-community.org/job/Koha_Master_D10_My8/649/
14:06 oleonard I could use help with a question I posted on Bug 28993 if anyone has a moment to look
14:06 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 enhancement, P5 - low, ---, oleonard, ASSIGNED , Switch magnifying class in staff detail pages to FA icon
14:13 * ashimema looks
14:14 ashimema hmm.. it looks like a copy paste to me..
14:14 ashimema but I'm not all that close to that area of code :(
14:14 ashimema perhaps blame it and ask whoever added it?
14:14 ashimema if they're still around
14:15 huginn News from kohagit: Bug 17600: Fix overdrive_proxy and recordedbooks <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a005865b813ef466f29c836c5ad65e8b69142f95>
14:15 huginn News from kohagit: Bug 28972: Fix failing tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=166ebea01fc27202b34a373f166fe19b1fa16921>
14:16 Joubu oleonard: I've noticed that on the add item forms as well, code from biblio were c/p there and was meaningless for items.
14:16 Joubu So I can imagine it's the same for the auth forms!
14:17 koha-jenkins Project Koha_Master_D11 build #389: UNSTABLE in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D11/389/
14:24 cait oleonard: checking
14:36 koha-jenkins Project Koha_20.05_D9 build #316: SUCCESS in 31 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/316/
14:38 koha-jenkins Project Koha_Master_D11_CPAN build #431: STILL UNSTABLE in 51 min: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/431/
14:51 koha-jenkins Project Koha_20.05_D11 build #713: FAILURE in 30 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/713/
14:52 koha-jenkins Project Koha_20.05_U_Stable build #3: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_20.05_U_Stable/3/
14:53 koha-jenkins Project Koha_20.05_D10 build #320: UNSTABLE in 56 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/320/
14:55 koha-jenkins Project Koha_Master_D10_MDB_Latest build #689: STILL UNSTABLE in 55 min: https://jenkins.koha-community.org/job/Koha_Master_D10_MDB_Latest/689/
14:56 koha-jenkins Project Koha_20.05_U16 build #322: FAILURE in 5 min 3 sec: https://jenkins.koha-community.org/job/Koha_20.05_U16/322/
15:00 tuxayo >_<
15:05 TimothyAlexis Thank you ashimema and Joubu
15:06 koha-jenkins Project Koha_20.05_U18 build #195: SUCCESS in 30 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/195/
15:13 oleonard kidclamp++
15:17 Joubu kidclamp: is bws hosting the koha-us website? it appears to be "down" (503)
15:20 koha-jenkins Project Koha_20.05_U20 build #358: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/358/
15:32 kidclamp Checking
15:33 kidclamp We only host their Koha site
15:36 koha-jenkins Yippee, build fixed!
15:36 wahanui Congratulations!
15:36 koha-jenkins Project Koha_Master_D9 build #1763: FIXED in 43 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1763/
15:38 koha-jenkins Yippee, build fixed!
15:38 wahanui Congratulations!
15:38 koha-jenkins Project Koha_Master_U20 build #189: FIXED in 32 min: https://jenkins.koha-community.org/job/Koha_Master_U20/189/
15:52 koha-jenkins Yippee, build fixed!
15:52 wahanui Congratulations!
15:52 koha-jenkins Project Koha_Master_U_Stable build #254: FIXED in 57 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/254/
15:53 koha-jenkins Yippee, build fixed!
15:53 wahanui Congratulations!
15:53 koha-jenkins Project Koha_Master_D11_CPAN build #432: FIXED in 59 min: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/432/
15:54 koha-jenkins Yippee, build fixed!
15:54 wahanui Congratulations!
15:55 koha-jenkins Project Koha_Master_D11 build #390: FIXED in 58 min: https://jenkins.koha-community.org/job/Koha_Master_D11/390/
16:13 koha-jenkins Yippee, build fixed!
16:13 wahanui Congratulations!
16:13 koha-jenkins Project Koha_Master_D10_My8 build #650: FIXED in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D10_My8/650/
16:17 koha-jenkins Yippee, build fixed!
16:17 wahanui Congratulations!
16:17 koha-jenkins Project Koha_Master_D12 build #9: FIXED in 56 min: https://jenkins.koha-community.org/job/Koha_Master_D12/9/
16:31 koha-jenkins Yippee, build fixed!
16:31 wahanui Congratulations!
16:31 koha-jenkins Project Koha_Master_D10_MDB_Latest build #690: FIXED in 32 min: https://jenkins.koha-community.org/job/Koha_Master_D10_MDB_Latest/690/
16:41 koha-jenkins Project Koha_20.05_U_Stable build #4: SUCCESS in 48 min: https://jenkins.koha-community.org/job/Koha_20.05_U_Stable/4/
16:41 koha-jenkins Yippee, build fixed!
16:41 wahanui Congratulations!
16:41 koha-jenkins Project Koha_20.05_D11 build #714: FIXED in 46 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/714/
16:49 koha-jenkins Yippee, build fixed!
16:49 wahanui Congratulations!
16:49 koha-jenkins Project Koha_20.05_U16 build #323: FIXED in 36 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/323/
16:54 koha-jenkins Yippee, build fixed!
16:54 wahanui Congratulations!
16:54 koha-jenkins Project Koha_Master build #1753: FIXED in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_Master/1753/
17:08 koha-jenkins Project Koha_Master_D9 build #1764: SUCCESS in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1764/
17:21 koha-jenkins Project Koha_20.05_U18 build #196: SUCCESS in 1 hr 4 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/196/
17:50 koha-jenkins Project Koha_Master build #1754: UNSTABLE in 56 min: https://jenkins.koha-community.org/job/Koha_Master/1754/
19:31 koha-jenkins Yippee, build fixed!
19:31 wahanui Congratulations!
19:31 koha-jenkins Project Koha_20.05_D10 build #321: FIXED in 50 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/321/
20:43 fridolin le bonjour
20:46 cait bonjour fridolin
23:58 Wainui for bug 28604
23:58 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 normal, P5 - low, ---, tomascohen, Pushed to oldoldoldstable , Bad encoding when using marc-in-json
23:58 Wainui On 19.11.x
23:59 Wainui Test Result (2 failures / ±0)
23:59 Wainui t_db_dependent_api_v1_biblios_t.get() tests (703) t_db_dependent_api_v1_biblios_t.get_public() tests (703)
23:59 Wainui I am getting these failtures Can someone please write a patch for that\