Time Nick Message
00:14 mtj hi folks, ill be working on some package releases today
00:59 koha-jenkins Project Koha_20.05_U20 build #356: FAILURE in 6 min 44 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/356/
01:19 tuxayo hi mtj :)
01:19 tuxayo Do you mean you will release a -2 revision of the packages?
01:25 mtj hi tuxayo, yes
01:27 koha-jenkins Yippee, build fixed!
01:27 wahanui Congratulations!
01:27 koha-jenkins Project Koha_20.05_U18 build #193: FIXED in 34 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/193/
01:35 koha-jenkins Yippee, build fixed!
01:35 wahanui Congratulations!
01:35 koha-jenkins Project Koha_20.05_U16 build #320: FIXED in 41 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/320/
01:45 koha-jenkins Yippee, build fixed!
01:45 wahanui Congratulations!
01:45 koha-jenkins Project Koha_20.05_U2010 build #217: FIXED in 50 min: https://jenkins.koha-community.org/job/Koha_20.05_U2010/217/
01:57 koha-jenkins Project Koha_20.05_U18 build #194: SUCCESS in 29 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/194/
02:00 koha-jenkins Yippee, build fixed!
02:00 wahanui Congratulations!
02:00 koha-jenkins Project Koha_20.05_D9 build #315: FIXED in 1 hr 8 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/315/
02:06 koha-jenkins Project Koha_20.05_D11 build #710: STILL UNSTABLE in 1 hr 6 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/710/
02:11 tuxayo mtj: I see you noticed https://jenkins.koha-community.org/job/Koha_20.05_D11/
02:11 tuxayo The failures would be due to a dependency in Debian 11 right?
02:11 koha-jenkins Project Koha_20.05_U16 build #321: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/321/
02:13 mtj hi tuxayo, yes, you can ignore for the error for now :)
02:13 tuxayo ok :D
02:13 tuxayo all green!
02:13 koha-jenkins Yippee, build fixed!
02:13 wahanui Congratulations!
02:13 koha-jenkins Project Koha_20.05_D10 build #319: FIXED in 1 hr 18 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/319/
02:24 koha-jenkins Yippee, build fixed!
02:24 wahanui Congratulations!
02:24 koha-jenkins Project Koha_20.05_U20 build #357: FIXED in 26 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/357/
02:31 koha-jenkins Project Koha_20.05_U2010 build #218: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_20.05_U2010/218/
06:25 alex_a Bonjour
06:25 wahanui que tal, alex_a
06:29 marcelr hi alex_a
06:30 marcelr dcook: datatables is nice but weird inside
06:31 dcook marcelr: i know right/
06:31 dcook I know right?*
06:31 marcelr you dont want to write controllers for it ;)
06:31 ashimema morning
06:31 marcelr hi ashimema
06:31 dcook marcelr: Where were you several weeks ago? haha
06:32 dcook It was certainly an interesting experience...
06:32 ashimema datatables?
06:32 wahanui hmmm... datatables is nice but weird inside
06:32 marcelr i dont know anymore
06:32 dcook lol
06:32 dcook Gotta be careful with verbs around here..
06:32 dcook Also morning ashimema
06:32 dcook Everyone should go back to sleep so I can somehow magically have more time today..
06:33 ashimema what you been upto with datatables dcook?
06:33 marcelr hope he's replacing them
06:34 ashimema the api wrapper we have is pretty good.. that's where I'd start now whenever implementing a new one.
06:34 ashimema lol.. yeah.. I often have the urge to replace them
06:34 ashimema they feel overly complex
06:35 ashimema they really hark back to the jQuery is king ages.. they were amazing at the time.. but their a bit challenging to wrap one's head around when you look at more modern alternatives.
06:35 dcook ashimema: Oh just thinking about a Koha plugin I want to do which fetches all the indexes from Zebra and displays them for users
06:35 * dcook perks up at the sound of modern alternatives
06:36 dcook ashimema: tell me more about this api wrapper?
06:36 ashimema honestly.. I've not really settled on any alternative.. and I think it would be an uphill struggle in Koha untill we've made any form of decision regards vue vs react vs svelt vs whatever new frontend framework is fad
06:36 dcook Actually, the plugin would be a bit dirty and also potentially grab biblio-koha-indexdefs.xml if possible and show which MARC fields get indexed how
06:36 ashimema take a look at cities and registers
06:36 ashimema they both use it.
06:37 dcook I'll make a note of that. thanks :D
06:37 dcook Sometimes it's easier to just ask the question than spend ages grepping
06:37 dcook Cities like /cgi-bin/koha/admin/cities.pl /
06:37 dcook ?*
06:37 dcook I need a new keyboard..
06:37 ashimema basically, it's a JS middleware to convert datatables crazy api calls to calls that work with the KOha rest api's
06:38 ashimema one sec.. I'll dig out some relevant links
06:38 dcook Ohh it looks broken in 20.11...
06:38 dcook At least the version I'm on
06:38 ashimema oh really :(
06:38 dcook Problem for another day
06:38 * dcook just collapses after this week
06:38 dcook Only 22 more minutes until Friday 5pm..
06:39 dcook Father's day on Sunday, and my son and I are going to watch a Father's day episode of Bluey coming out that day
06:39 dcook So close haha
06:39 ashimema the future is calling
06:39 ashimema oh cool, enjoy dcook
06:39 dcook Thanks :)
07:00 ashimema https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt#L230
07:00 ashimema relevant instantiation of datatabel for cities.
07:01 ashimema note the .api
07:01 * ashimema thinks that mething name was perhaps a mistake as there's a .api() metod in DataTables core too
07:02 ashimema but yeah.. the .api method is our datatables wrapper.. from datatables.inc
07:39 dcook Ahh nice one, ashimema. I'll check that out.
08:03 * magnuse waves to dcook
08:10 * dcook waves to magnuse
08:11 magnuse \o/
08:15 * ashimema holds up a fish
08:31 marcelr Joubu ashimema or dcook: any feedback on changes for bug 28935 along the lines of last patch ?
08:31 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28935 is not accessible.
08:32 ashimema it's on my list to look at that one this morning :)
08:33 marcelr i am workign on it and would appreciate a go or nogo
08:38 ashimema just in my morning call at the minute
08:38 ashimema then I'll take a look
08:38 ashimema probably be in this for at least another 30 mins
08:42 marcelr thx
08:50 dcook marcelr: i'll make a comment now
08:50 marcelr ok
08:51 marcelr still there; night time now?
08:55 Joubu marcelr: there are too many patches on 28935
08:56 marcelr yes you should apply interactive
08:56 marcelr i didnt want to delete stuff yet
08:57 ashimema ooh..
08:57 marcelr just curious if i want to continue or stop
08:57 marcelr s/want/should/
08:57 ashimema so should I just look at your final patch without the others
08:58 * ashimema is still only half way through reading all the comments
08:58 marcelr input => \%newdata needs changing
08:58 marcelr yeah the last patch shows the diversion of the route
08:58 marcelr along the lines of dcooks comments
08:59 ashimema wow.. this has come a long way since I looked at it.
08:59 Joubu I don't see how it helps in term of maintainability
08:59 ashimema hmm..
09:00 ashimema those module names feel a bit generic
09:00 Joubu but I really don't care, just need something that works
09:00 ashimema AllowList..
09:00 ashimema what's it allowing ;)
09:00 ashimema we're talking about allow lists in the public vs staff api's routes too..
09:00 ashimema both for get and set
09:01 Joubu having all the fields listed in the module allow us to have a test
09:01 ashimema almost need a FieldsList module with each field having readonly, staff read, public read, staff write, public write etc..
09:01 * ashimema will read the patches in detail before continuing to comment though
09:01 marcelr my $allowed_data = { %newdata }; $allowlist->apply({ input => $allowed_data, verbose => 1 }); # TODO Should we log results? %newdata = %$allowed_data;
09:02 marcelr Joubu: what test exactly with all fields?
09:03 Joubu the first one
09:03 wahanui rumour has it the first one is right
09:03 Joubu http://paste.koha-community.org/2625
09:03 dcook ashimema: Agreed about that FieldsList module although I feel like that's a AuthZ rabbit hole. Worth doing but terrifying.
09:04 ashimema yeah.. your probably right
09:04 dcook Keep in mind that $allowlist has a return value of the blocked values
09:04 dcook So we don't need to log anything in the module
09:04 dcook We can handle the logging at the controller script level
09:04 Joubu I wanted to add a net to catch columns added to the DB but forgotten in the Allowlist module
09:04 Joubu that's why I wrote it like that
09:04 dcook And I'd argue have a log level like debug. Maybe warning if we want to be able to scan for malicious requests.
09:04 marcelr ok now you would only have to add it in one place
09:05 Joubu but I am not strongly attached to it. But in my mind it reduced the maintainability
09:05 marcelr i added a TODO for Koha::LOgger
09:05 ashimema the to_api_mapping stuff could be a reasonable approach.. each module containing it's own clear list with the various options
09:05 Joubu marcelr: yes but you/we will forget! :)
09:05 Joubu that's the point
09:05 marcelr and then verbose gives you one warn
09:05 marcelr as a hint
09:05 Joubu marcelr: the problem with log/warn is that we need to delete the key from the hash before we call allowlist
09:05 dcook Joubu; with the testing, couldn't we use Koha::Patron->columns() for input for testing?
09:06 dcook ashimema: I was wondering about that to_api_mapping as well for that
09:06 Joubu otherwise we will always warn (we don't clean the hashref)
09:06 ashimema I should really read the patches.. I'm commenting blind.. haha
09:06 ashimema brb onces i've actually read them
09:06 dcook Joubu: Agreed. Don't want a "borrowernumber" warning constantly
09:06 dcook I really shouldn't be here haha
09:07 dcook I should be making dinner
09:07 marcelr imo this simplifies but if there is only discussion I am fine for removing the patch?
09:07 dcook Also take my comments with a grain of salt. While I think they make sense, I'm not the one doing the actual work.
09:08 dcook So willing to default to what Joubu thinks as best as the assignee
09:08 ashimema Let me take a read first.. need to wrap my brain around it before really having a strong opinion
09:08 marcelr the A + B - C - D isnt simpler
09:08 dcook marcelr: Agreed
09:08 dcook Although at a minimum we might need A - D
09:08 Joubu there is no good solution for that. Either we clean the hashref (and loose the benefit of the allowlist module), or we have the warn
09:08 Joubu dcook: hum, iirc we have all the columns from the borrowers table already in the hashref
09:08 Joubu it might work if I am wrong, checking
09:08 Joubu 261 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
09:08 dcook Because of the Unwanted* system preferences
09:08 Joubu 268 my %borrower = ParseCgiForBorrower($cgi);
09:08 Joubu 276 %borrower = ( %$borrower, %borrower );
09:09 dcook Joubu: Yeah I think you're right
09:09 dcook I don't have my test data to hand, but modifying a patron will send through data that should be blocked for new patrons for instance
09:09 dcook Which yeah..
09:10 dcook :|
09:11 dcook Actually maybe I do have that data..
09:11 dcook Also maybe we shouldn't be posting code in the channel ;)
09:11 Joubu a solution could be to warn for dev_install only
09:11 dcook Ah then again maybe it's too late for that
09:12 Joubu as we need it mainly for dev purpose
09:12 dcook Well there are times when it's nice to raise the log level in prod
09:12 dcook You find something weird happening so you want to put it up to DEBUG for prod operations before dropping down to a quieter log level
09:12 dcook Admittedly I don't know if Koha can do that
09:12 * dcook wrote a logger for a different app that does it nicely
09:13 dcook Hmm...
09:14 Joubu it can
09:14 Joubu but when/what do you log? that's the question
09:15 dcook True
09:16 dcook I try to do my logging in controller code wherever possible
09:16 dcook So I was thinking for a DEBUG log level we'd just dump out the contents of $blocked as returned from apply()
09:16 marcelr Yeah I would log at DEBUG in the controller script probably
09:16 dcook I found that useful during my dev for figuring out what fields should be filtered heh
09:17 dcook That's how I realized 'relationship' shouldn't be filtered for instance
09:17 dcook As it came out in the debug output
09:17 Joubu not ideal but I cannot find something better
09:19 Joubu marcelr: can you continue then?
09:20 marcelr i could but the comments are not in consensus
09:20 dcook When in doubt ignore me heh
09:20 marcelr i replied dcook
09:20 dcook I'm about to take off for the weekend, and i don't want to hold it up
09:20 dcook Oh.. but I can't leave an unread comment..
09:20 marcelr your comments may not be fully understood
09:21 marcelr i would not add ->allow_entries unless there is a good use for it
09:21 marcelr we now only need ->apply
09:21 marcelr and we can configure with ->add and ->remove
09:23 Joubu don't forget the extra deny list for unwantedfields
09:25 dcook Yeah I think you might've misunderstood me
09:26 marcelr so we should call remove for unwanted
09:26 dcook Yeah remove for unwanted
09:26 marcelr i am missing the point of adding deny entries to an ALLOW list ?
09:26 dcook I know haha
09:26 Joubu ha, it's ->add. When would you need ->remove?
09:26 marcelr e.g. unwanted
09:27 dcook I'm sorry but I think I have to call it. 7:30pm and I need to make my dinner and unwind.
09:27 dcook I trust you folks to sort it out. I'll be back Monday 9am :).
09:27 marcelr ok dcook you left us in confusion :) haha
09:27 Joubu thanks for your time dcook, enjoy your weekend!
09:27 marcelr good night
09:28 dcook haha sorry marcelr. i really am
09:28 dcook Thanks Joubu :)
09:28 ashimema have a great weekend dcook
09:28 dcook Have a good friday all
09:28 marcelr Joubu: your call delete my stuff or proceed ?
09:29 marcelr at least i got the chance to practive keyboard exercise :)
09:29 Joubu I am actually off today, on a train with bad 4G connexion, I won't have much time today.
09:30 marcelr well same for me actually i could finish this on monday
09:30 Joubu as I said, the only reason I went "my" way was the unit test, I thought it could bring us (devs) a net when we add new DB columns
09:30 marcelr but a new column is not per se an add column
09:30 Joubu I am not strongly attached to it, just a bit afraid to see this list of borrowers fields duplicated all over the code, quite hard to maintain
09:31 marcelr ok lets decide over the weekend
09:32 Joubu mtj: around?
09:33 Joubu could someone try `apt update && apt install koha-common` on a pkg install?
09:35 sarcofag Hi! Can someone suggest me how to add ID card fields in the form of self-registration?
10:04 marcelr Joubu++ fast fix
10:17 oleonard sarcofag: There is an option for defining a custom "patron attribute," and it can be added to the self-registration form.
10:18 oleonard sarcofag: However it doesn't work if the " PatronSelfRegistrationVerifyByEmail " preference is enabled... I'm not sure why.
10:18 oleonard https://koha-community.org/manual/21.05/en/html/administration.html#patron-attribute-types
10:22 mtj hiya Joubu
11:07 tcohen hol
11:07 tcohen hola
11:07 wahanui niihau, tcohen
11:10 oleonard Hi tcohen
11:10 oleonard kidclamp: Around yet?
11:10 * kidclamp nods
11:11 tcohen hi kidclamp
11:17 oleonard kidclamp: Good morning :)
11:34 oleonard As I update smart-rules.tt with flatpickr widget I wonder... Should the "hard due date" and "no automatic renewal after" fields be linked? It seems like the "no automatic renewal" field should never have a date which is after the "hard due date"
11:35 oleonard I guess it's technically out of scope for the bug, but maybe something we should consider.
11:43 Joubu oleonard: did you mean "No automatic renewal after (hard limit)"?
11:44 Joubu "hard due date" is not for auto renew
11:45 Joubu sorry
11:45 Joubu forget that
11:45 wahanui Joubu: I forgot that
11:45 Joubu forget everything
11:45 wahanui Joubu: I forgot everything
11:46 oleonard Joubu: I forgot everything
11:48 Joubu afk, back in a bit
14:00 tcohen oleonard++
14:30 koha-jenkins Project Koha_21.05_U_Stable build #53: STILL UNSTABLE in 30 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/53/
14:35 koha-jenkins Project Koha_21.05_D11 build #68: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/68/
14:53 koha-jenkins Project Koha_21.05_D9 build #58: STILL UNSTABLE in 57 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/58/
14:54 koha-jenkins Project Koha_21.05_U20 build #59: STILL UNSTABLE in 54 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/59/
15:03 koha-jenkins Project Koha_21.05_U18 build #55: STILL UNSTABLE in 32 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/55/
15:10 oleonard Does anyone know if the "daterange" type is ever used in reports? https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/Reports/Guided.pm#L377
15:13 koha-jenkins Project Koha_21.05_D11 build #69: STILL UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/69/
15:19 Eliza i have a question about printing student ID cards
15:19 Eliza can Koha print individual barcodes for each student? I would like to make them library cards
15:19 koha-jenkins Project Koha_21.05_U16 build #54: STILL UNSTABLE in 1 hr 19 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/54/
15:26 Eliza can Koha print individual barcodes for each student? I would like to make them library cards
15:29 koha-jenkins Project Koha_21.05_D11 build #70: FAILURE in 9 min 47 sec: https://jenkins.koha-community.org/job/Koha_21.05_D11/70/
15:29 oleonard Eliza: There is a patron card creator tool: https://koha-community.org/manual/21.05/en/html/tools.html#patron-card-creator
15:36 koha-jenkins Project Koha_21.05_U16 build #55: STILL UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_21.05_U16/55/
15:40 tcohen bug 23678 anyone?
15:40 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 enhancement, P5 - low, ---, agustinmoyano, Signed Off , Cancel holds in bulk
15:48 koha-jenkins Project Koha_21.05_U20 build #60: STILL UNSTABLE in 54 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/60/
15:48 koha-jenkins Project Koha_21.05_U20 build #61: FAILURE in 12 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/61/
15:53 koha-jenkins Project Koha_21.05_U_Stable build #54: STILL UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/54/
15:54 koha-jenkins Project Koha_21.05_U18 build #56: STILL UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/56/
15:55 koha-jenkins Project Koha_21.05_D9 build #59: FAILURE in 26 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/59/
15:56 koha-jenkins Project Koha_21.05_U16 build #56: FAILURE in 8 min 39 sec: https://jenkins.koha-community.org/job/Koha_21.05_U16/56/
15:59 koha-jenkins Project Koha_21.05_U_Stable build #55: FAILURE in 5 min 58 sec: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/55/
15:59 koha-jenkins Project Koha_21.05_U18 build #57: FAILURE in 7 min 15 sec: https://jenkins.koha-community.org/job/Koha_21.05_U18/57/
16:01 koha-jenkins Project Koha_21.05_D11 build #71: STILL FAILING in 7 min 0 sec: https://jenkins.koha-community.org/job/Koha_21.05_D11/71/
16:28 ashimema weekend time.. see ya
17:05 oleonard Oh yeah... Friday afternoon, the worst time to have a question in #koha XD
17:09 koha-jenkins Project Koha_21.05_U16 build #57: STILL FAILING in 4 min 11 sec: https://jenkins.koha-community.org/job/Koha_21.05_U16/57/
17:09 koha-jenkins Project Koha_21.05_U_Stable build #56: STILL FAILING in 4 min 23 sec: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/56/
17:10 koha-jenkins Project Koha_21.05_D9 build #60: STILL FAILING in 4 min 15 sec: https://jenkins.koha-community.org/job/Koha_21.05_D9/60/
17:10 koha-jenkins Project Koha_21.05_U18 build #58: STILL FAILING in 5 min 47 sec: https://jenkins.koha-community.org/job/Koha_21.05_U18/58/
17:15 koha-jenkins Project Koha_21.05_U20 build #62: STILL FAILING in 5 min 46 sec: https://jenkins.koha-community.org/job/Koha_21.05_U20/62/
17:15 koha-jenkins Project Koha_21.05_D11 build #72: STILL FAILING in 8 min 26 sec: https://jenkins.koha-community.org/job/Koha_21.05_D11/72/