Time  Nick         Message
00:50 Wainui       Hi RMaints etc
00:51 Wainui       I'm gonna release 19.11.20 tomorrow (July 23 New Zealand time)
05:58 dcook        A new day, a new security vulnerability :D
06:15 huginn       News from kohagit: Bug 28660: (bug 21325 follow-up) Fix auto self check <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=09e0799a8d617ba61e120576a6478465dc975aff>
06:15 Joubu        kidclamp: don't forget 28660 for the next 21.05
06:36 reiveune     hello
06:45 dcook        allo allo reiveune
06:45 cait1        good morning #koha
06:45 dcook        Hey Joubu, can you look at 28735 and let me know what you think?
06:45 dcook        It's another self-checkout bug
06:47 dcook        morning cait1
06:47 dcook        Err almost evening ;d
06:47 dcook        :D*
06:48 dcook        I'm pointing east, but I can see blue sky, the moon, and sunlight disappearing against the building across the street as it sets..
06:50 Joubu        dcook: Salut David, yes the patch makes sense!
06:50 dcook        \o/
06:51 dcook        Glad you think so :)
06:51 Joubu        do we really need to test koha_login_context AND sco_user_login?
06:51 dcook        Unfortunately lol
06:51 dcook        Actually..
06:52 dcook        sco_user_login definitely when not using AutoSelfCheckAllowed
06:52 Joubu        cannot we remove koha_login_context and keep (sco_user_login AND AutoSelfCheckAllowed)?
06:52 dcook        I should double-check koha_login_context for AutoSelfCheckAllowed
06:53 dcook        Mmm yeah I think that would be functionally equivalent
06:53 Joubu        that's confusing, we have too many things to test the same stuff :D
06:53 dcook        I know, right?
06:53 dcook        heh
06:54 dcook        I have a couple minutes left in my day. I could make that change now if you like
06:54 Joubu        maybe we should clean more on a separate bug report?
06:54 cait1        dcook: have a nice evening then :)
06:54 dcook        cait1: Thanks :)
06:54 cait1        and thx for the Zebra tip to the list, always interesting
06:55 dcook        Joubu: I like the sound of that, although I am pretty low on time right now. I fixed this one because one of my librarians pointed it out to me.
06:55 dcook        cait1: Zebra always leaves something new to learn heh
06:55 dcook        I thought I was going crazy when "Identifier-standard,phr" wasn't working as expected
06:55 koha-jenkins Project Koha_21.05_D9 build #27: FAILURE in 52 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/27/
06:56 dcook        Although I have noticed a few places in Zebra where if you define 2 mutually incompatible options, it always seems to choose the first and ignore the second
06:56 dcook        So consistency is good..
06:56 Joubu        dcook: keep it like that then. If it's clear for you what can be clean you could open a bug report and put your idea there. Shouldn't be more than the 2 minutes you have left
06:56 Joubu        well, only one left now
06:56 dcook        Joubu: I'm not sure i follow heh
06:57 dcook        Oh actually..
06:57 Joubu        don't modify your patch, open a separate bug report and describe what can be done to improve the situation
06:57 dcook        You're right. I should've checked sco-main.pl more carefully
06:57 dcook        I see sco_user_login is set in sco-main.pl regardless
06:58 koha-jenkins Project Koha_Master_D10_MDB_Latest build #637: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_Master_D10_MDB_Latest/637/
07:00 dcook        There updated
07:00 dcook        I'm happier with that
07:01 dcook        Ideally, it would be nice not to rely on $query->param() at this stage in the function, but that's a whole other thing. I think it's good enough.
07:01 dcook        annnd it's 5:01
07:01 dcook        Time for me to catch that wee bit of sunshine in the flesh while I can
07:01 dcook        Thanks for that review, Joubu
07:01 dcook        And good night all ;d
07:01 dcook        :D*
07:03 Joubu        good evening dcook!
07:03 koha-jenkins Project Koha_Master_D10_My8 build #613: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D10_My8/613/
07:04 koha-jenkins Project Koha_Master_D9 build #1709: FAILURE in 6 min 57 sec: https://jenkins.koha-community.org/job/Koha_Master_D9/1709/
07:10 koha-jenkins Project Koha_Master_D11 build #343: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D11/343/
07:16 koha-jenkins Project Koha_Master_U_Stable build #214: SUCCESS in 59 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/214/
07:19 koha-jenkins Project Koha_Master_U20 build #148: SUCCESS in 30 min: https://jenkins.koha-community.org/job/Koha_Master_U20/148/
07:20 koha-jenkins Project Koha_Master build #1713: SUCCESS in 1 hr 1 min: https://jenkins.koha-community.org/job/Koha_Master/1713/
07:40 koha-jenkins Project Koha_Master_D10_CPAN build #381: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/381/
07:49 koha-jenkins Project Koha_Master_U20 build #149: SUCCESS in 30 min: https://jenkins.koha-community.org/job/Koha_Master_U20/149/
07:51 koha-jenkins Project Koha_Master_D10_CPAN build #382: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/382/
07:53 ashimema     Joubu or cait around yet?
07:53 ashimema     morning koha
07:53 ashimema     or marcelr for that matter
08:10 cait1        kind of here
08:10 cait1        the usual busy :)
08:11 Joubu        ashimema: yes
08:18 ashimema     I commented on a bug instead: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266#c17
08:18 huginn       Bug 27266: enhancement, P5 - low, ---, aleisha, Signed Off , Move C4::Biblio::GetMarcAuthors to Koha namespace
08:19 ashimema     I couldn't remember what the state of frameworks was.. but it would be trivial to include frameworkcode in the call now with the move of GetMarcAuthors into Koha::Biblio
08:23 cait1        not sure why we woudl need it if it wasn't there before?
08:23 koha-jenkins Yippee, build fixed!
08:23 koha-jenkins Project Koha_Master_D9 build #1710: FIXED in 1 hr 19 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1710/
08:24 cait1        I'll try to read later, but might ont be necessary
10:35 oleonard     Hi all
11:40 tcohen       morning
11:43 tcohen       is anyone thinking about the advent calendar?
11:44 cait1        too warm :)
11:48 ashimema     good question tcohen
11:48 ashimema     I haven't yet.. but we probably aught to start asap
11:49 tcohen       I think 'background jobs' is a good subject
11:50 ashimema     good idea
11:53 ashimema     we did 'Plugins' as our overarching topic last time
11:55 ashimema     should we still target developers mostly.. or try to make it attractive to a wider audience somehow.. mixing in librarian targeted posts.. perhaps showing off cool new workflows or features introduced with 21.05 and 21.11 ?
11:57 cait1        maybe show the benefits?
11:57 cait1        like... explain the technical bits, but include an "what does this mean" section
11:57 cait1        i'd love that
12:18 tcohen       lets add those ideas in the roadmap pad!
12:43 cait1        tcohen++ :)
13:07 Joubu        I love tests
13:07 ashimema     ooh, adding a 'How to write tests' could be a great post.. I could see that getting used loads when companies onboard new devs :)
13:08 Joubu        for new devs there is also the "Koha how to" we could promote
13:14 tuxayo       Hi #koha :)
13:16 tuxayo       Hi khall & kidclamp , did you have to test bug 28523 when backporting or does the code change look safe enough?
13:16 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 critical, P5 - low, ---, jonathan.druart+koha, Pushed to stable , Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8
13:18 khall_       tuxayo I tested to make sure it didn't break the version we currently use. It should b e totally safe considering it's just wrapping the column name with backticks
13:20 tuxayo       khall_: oh, it's only that, I should have looked a more detailed diff than the one in BZ were the whole line shows. Thanks!
13:22 cait1        hm did i imagine the existance of a cli patron import script?
13:23 cait1        no... just being blind :)
13:23 cait1        import_patron.pl
13:27 tcohen       cait1 lets talk about ReturnPath
13:39 vfernandes   hi #koha
13:39 vfernandes   it's possible to block the notification/emails sending only for the on-site checkouts?
14:38 cait1        tcohen: sorry missed your message
14:38 cait1        what do you want to know?
14:40 kohaputti    Anybody come across this one "error retrieving authority 1707 at /kohadevbox/koha/misc/migration_tools/rebuild_zebra.pl line 692." on kohadevbox reset_all?
14:41 kohaputti    Can't remember if it is "normal"
14:41 cait1        not yet
14:42 kohaputti    thanks
14:46 cait1        and hi kohaputti :)
14:47 kohaputti    hey :)
14:47 cait1        my problem of today is bug 28738
14:47 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 normal, P5 - low, ---, koha-bugs, NEW , Value builder marc21_linking_section.pl for creating 77x is broken
14:47 cait1        oleonard: any change you might be able to have a look? i wonder if it's the javascript... since another window opens, but I just don't undertand it
14:47 ashimema     hi kohaputti. Nice to see you :)
14:47 cait1        i've been traiyng to fix our variation of it based on this one, but then realized that the original is not working either
14:48 cait1        which explains why mine doesn't
14:48 oleonard     I can try cait
14:50 kohaputti    ashimema, hi, you mentioned in bug 20447 that the holdings selection was not working. Well, after I did now a rebase on top of your bug 22690 changes it works at least for me. I'm still working on making similar renaming for the adopt_holdings_from_biblio like you did for adopt_items_from_biblio (i.e. -> move_to_biblio)
14:50 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 new feature, P5 - low, ---, ere.maijala, Failed QA , Add support for MARC holdings records
14:50 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 normal, P5 - low, ---, ere.maijala, Passed QA , Merging records with many items too slow (Elasticsearch)
14:50 ashimema     awesome, thanks kohaputti
14:50 kohaputti    ashimema, will ping you on the bugzilla comments after the renaming is done.
14:50 ashimema     I can take a look.. I'm away on vacation next week so may or may not get to it before I leave.. but I'll make sure it's at the top of my list
14:50 ashimema     cool.
14:50 ashimema     thanks
14:51 kohaputti    ok
14:51 kohaputti    I'm on the other hand still working this and next week
14:51 kohaputti    just returned today from my summer holiday
14:52 ashimema     I would love to quiz someone regards the holdings bug in general.. it feels very similar in final feature outcome to the Volumes bug..  but don't have the brain power to dig back into it this afternoon
14:52 ashimema     cool.. I'll let you work through it.. feel free to post queries on the bug and we can discuss in a week when I'm back.
14:52 ashimema     so are you back for a bit now?  I thought you were getting moved off Koha for a longer while
14:53 kohaputti    I'm back for just this and next week
14:53 ashimema     okies..
14:53 ashimema     I'll be back on the 30th..
14:54 kohaputti    yeah... nugged is then your best bet after that for holdings questions
14:55 cait1        oleonard: i think it's broken... not working for more than one field anymore
14:55 cait1        we changed around the plugin infra... maybe it got broken in one of those? not sure if there is another plugin that fills in more than one field i could compare it to - most only affect th field they are linked to
14:56 ashimema     okies, thanks
14:56 cait1        if i have an author and link it to $a - that is filled
14:56 cait1        oleonard: and thanks for even considering it
15:01 cait1        oleonard: I checked all the commits/changes from last years... and nothing looks supicous (not helpful)
15:23 cait1        oleonard: i found a javascript syntax error... only I don't know what's wrong - updated the bug
15:23 cait1        sorry for spamming
15:25 Joubu        cait1: do you remember the "*_on" naming discussion for the dates in DB?
15:26 Joubu        if so, see last comments from 25260
15:26 cait1        i remember - but not sure I remember the results
15:26 reiveune     bye
15:26 cait1        didn't we discuss the same/similar for the API?
15:28 cait1        hm wrong bug number
15:28 cait1        Joubu:
15:29 Joubu        cait1: no, good bug number
15:36 cait1        Joubu: some kind of filter stuck, worked now
15:37 cait1        i think we discussed it when adding updated_on in borrowers?
15:37 cait1        might be on the bug there
15:38 cait1        tcohen: ping?
15:38 tcohen       hi
15:39 Joubu        bug 25776 - no discussion there
15:39 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25776 enhancement, P5 - low, ---, katrin.fischer, RESOLVED FIXED, Add last updated date for notices and slips
15:39 Joubu        ha... wrong updated_on!
15:40 Joubu        bug 10459 - yes, that's the one I linked with
15:40 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 minor, P5 - low, ---, m.de.rooy, CLOSED FIXED, borrowers should have a timestamp
15:46 cait1        qa didn't catch me... ;)
16:28 nugged       kohaputti: I am in, ... just those holdings I'd like to know more like ashimema too :)... ok then, though, now I have librarians near me and Ere reachable soon – so I think I will gain those knowledge locally, so let's see. And yes, thanks for you that you rebased those complicated things to front of code –
16:29 nugged       then might be 20447 will be now possible to check by the team so it will pass faster, aha.
16:50 kohaputti    ashimema, could you have another look at bug 22690, there seems to be bigger problems, maybe you had some changes locally that didn't manage to get into bugzilla?
16:50 huginn       Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 normal, P5 - low, ---, ere.maijala, Failed QA , Merging records with many items too slow (Elasticsearch)
17:50 koha-jenkins Project Koha_20.11_U20 build #110: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_20.11_U20/110/
18:00 koha-jenkins Project Koha_20.11_D9 build #116: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_20.11_D9/116/
18:04 koha-jenkins Project Koha_20.11_U_Stable build #17: UNSTABLE in 53 min: https://jenkins.koha-community.org/job/Koha_20.11_U_Stable/17/
18:16 koha-jenkins Project Koha_20.11_U16 build #99: SUCCESS in 1 hr 5 min: https://jenkins.koha-community.org/job/Koha_20.11_U16/99/
18:20 koha-jenkins Project Koha_20.11_D10 build #125: SUCCESS in 1 hr 6 min: https://jenkins.koha-community.org/job/Koha_20.11_D10/125/
18:20 koha-jenkins Project Koha_20.11_U20 build #111: SUCCESS in 30 min: https://jenkins.koha-community.org/job/Koha_20.11_U20/111/
18:21 cait1        oleonard: I think i fixed the problem... maybe
18:22 oleonard     I hope so because I'm lost
18:31 cait1        oleonard: i think the changes to the catalouging editor were the cause
18:32 cait1        they changed the page structure and the way it goes through the subfiels in the .tt is a bit strange
18:32 oleonard     I suspected I was to blame but I didn't know why :D
18:32 cait1        oleonard++
18:32 cait1        thx for trying
18:32 cait1        really, much appreciated
18:32 cait1        i posted the line i changed on the bug, in case you want to have a look....
18:33 cait1        adding a third parentNode is the fix... but 3 parentNodes don't seem very trustworthy
18:33 koha-jenkins Project Koha_20.11_U18 build #102: SUCCESS in 1 hr 20 min: https://jenkins.koha-community.org/job/Koha_20.11_U18/102/
18:33 koha-jenkins Project Koha_20.11_U18 build #103: SUCCESS in 1 hr 15 min: https://jenkins.koha-community.org/job/Koha_20.11_U18/103/
18:40 koha-jenkins Project Koha_20.11_D11 build #135: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_20.11_D11/135/
19:02 koha-jenkins Project Koha_20.11_D9 build #117: SUCCESS in 58 min: https://jenkins.koha-community.org/job/Koha_20.11_D9/117/
19:11 koha-jenkins Project Koha_20.11_D10 build #126: UNSTABLE in 51 min: https://jenkins.koha-community.org/job/Koha_20.11_D10/126/
20:06 koha-jenkins Project Koha_20.05_D11 build #698: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/698/
20:11 koha-jenkins Project Koha_20.05_U2010 build #208: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_20.05_U2010/208/
20:17 koha-jenkins Project Koha_20.05_U16 build #311: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/311/
20:26 koha-jenkins Project Koha_20.05_U20 build #344: SUCCESS in 53 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/344/
20:32 koha-jenkins Project Koha_20.05_D9 build #308: SUCCESS in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/308/
20:33 koha-jenkins Project Koha_20.05_D11 build #699: SUCCESS in 27 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/699/
20:34 koha-jenkins Project Koha_20.05_D10 build #311: SUCCESS in 1 hr 4 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/311/
20:50 koha-jenkins Project Koha_20.05_U18 build #182: SUCCESS in 1 hr 17 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/182/
20:53 koha-jenkins Project Koha_20.05_U16 build #312: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/312/
21:18 koha-jenkins Yippee, build fixed!
21:18 koha-jenkins Project Koha_21.05_D9 build #28: FIXED in 1 hr 6 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/28/
21:19 koha-jenkins Yippee, build fixed!
21:19 koha-jenkins Project Koha_20.11_U_Stable build #18: FIXED in 53 min: https://jenkins.koha-community.org/job/Koha_20.11_U_Stable/18/
21:24 koha-jenkins Project Koha_20.05_U20 build #345: SUCCESS in 52 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/345/
21:34 koha-jenkins Yippee, build fixed!
21:34 koha-jenkins Project Koha_20.11_D10 build #127: FIXED in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_20.11_D10/127/
21:57 koha-jenkins Project Koha_20.05_U18 build #183: SUCCESS in 1 hr 6 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/183/