Time Nick Message 00:34 marie-luce have a lovely day or night all 07:06 marcelr hi #koha 07:07 marcelr dashboard sleepy ? 07:54 reiveune hello 07:59 cait1 good morning #koha 08:10 jsicot Morning #koha 09:00 ashimema morning 09:01 magnuse hiya ashimema 09:03 ashimema How is everyone today.. good I hope :-) 09:04 cait1 just finished talking to the swedish user group about bugzilla, so we can expect many new bug reports incoming i hope 09:05 ashimema woopie 09:05 ashimema likely any code will come of those bugs? 09:05 ashimema or even better.. signoffs? 09:07 cait1 small steps ! 09:08 * ashimema is in a bug unsticking mood this morning.. hope it doesn't end up like wading through treacle 09:08 cait1 this was about using bugzilla, so aiming for commenting, what status means wheat etc. 09:08 cait1 heh 09:10 ashimema coolios 09:12 magnuse i have talked about signoffs to them, could probably be done again :-) 09:13 ashimema :D 11:15 oleonard HI #koha 11:21 kohaputti ashimema, https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690#c14 – you had good comments there, I'm preparing follow-up but we can't get the destination branch without more refactoring so I will leave that job to someone else (or me later). Can I ask you does "Item is on hold and in transit for NAME" sound good as warning message? 11:22 kohaputti or "Hold found for NAME and item is in transit" 11:23 kohaputti The other messages use the word Reserve vs. Hold, but if I remember right Hold was the preferred term nowadays 11:23 oleonard Correct 11:25 kohaputti uh, I think I might just go with "Item has an hold and is in transit for NAME", someone correct me if ungrammatical :P 11:27 oleonard Sound good to me kohaputti 11:29 tuxayo Hi #Koha :) 11:38 ashimema sounds good to me kohaputti :) 11:40 ashimema yeah, I had a feeling it might be challenging to get the transit to location.. it's weird.. holds and transfers seem to internlinked, but then when you dig into the code they're not at all well linked 11:40 ashimema your solution is nice and pragmatic and I'm more than happy with it :) 11:40 ashimema It's a great piece of work 11:40 kohaputti added a comment about that, we need to pass around Koha::Hold to make it happen 11:41 kohaputti but this series is already big enough for one person to review so not adding more stuff here 12:01 TimothyAlexis Does anyone know where I can get the hold statuses? Such as Waiting, In transit, etc... 12:02 TimothyAlexis And also, if it would be possible to use these as options in a multiple select system preference. bug 14783 12:03 TimothyAlexis https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 12:08 oleonard TimothyAlexis: Some of it comes from the value in reserves.found 12:09 oleonard TimothyAlexis: But in-transit isn't a hold status 12:11 oleonard I guess the "T" value for reserves.found corresponds to a transfer 12:11 TimothyAlexis :\ 12:12 TimothyAlexis What is in-transit then? 12:12 oleonard In-transit means there is an entry in branchtransfers which doesn't have a "datearrived" value 12:13 oleonard The fact that this information is duplicated probably leads to problems when the transfer or the hold status isn't updated correctly in both places. 12:16 kohaputti TimothyAlexis, if you have Koha::Hold object then $hold->found() should work 12:16 kohaputti depending on your use case, note that there is also $hold->is_found 12:17 TimothyAlexis I'm thinking about the statuses in the holds table at https://koha-test.lub.lu.se/cgi-bin/koha/opac-user.pl#opac-user-holds 12:18 TimothyAlexis The setting would define for which of these a patron is allowed to change pickup location. 12:19 TimothyAlexis And rather than hardcoding the options into the system preference, I'm thinking it would be better to get them. 12:20 oleonard Much of it is based on reserves.found, but there's also information from reserves.suspend 12:20 kohaputti hmm, do we do anywhere exception handling, like could Koha::Hold::set_pickup_location just throw not allowed and then the script would need to handle that? 12:21 oleonard TimothyAlexis: I don't think there's a single official list that will let you avoid hardcoding it 12:21 TimothyAlexis So perhaps it would make sense to hardcode them? 12:21 cait1 i think so 12:21 cait1 they are pretty static and people can't add to them 12:21 TimothyAlexis OK, thank you. 12:22 kohaputti hard coding sounds the way to go for me as well, because we don't have hold_statuses table or anything. 12:22 kohaputti and pretty much everywhere it is hard coded, but I am planning to submit a patch for that... 12:22 cait1 and I am not aware of bugs adding other statuses - i think they have been like that forever 12:22 kohaputti cait1, I added recently the processing status 12:25 oleonard kohaputti: A status which can appear in reserves.found? 12:25 kohaputti yes 12:25 kohaputti currently we have: T, P, W 12:26 oleonard Under what circumstances is a hold "P" ? 12:28 kohaputti if you have selected the holdsneedprocessingsip syspref, so then when book is returned via a SIP2 machine it goes to processing instead of being immediately available/waiting. Especially useful now during COVID-19 when books needs to be "quarantined" 12:34 oleonard I was today years old when I learned about the HTML <datalist> element. :| 12:35 * oleonard feels oblivious 12:35 tcohen morning 12:37 magnuse ¡hola tcohen! 12:41 tcohen \o/ 12:46 oleonard would Bug 27805 cause problems for systems which use some kind of non-standard local value for something like KohaAdminEmailAddress? Some kind of localhost address? 12:46 oleonard https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27805 12:52 oleonard I guess the default root@localhost is considered valid, so I shouldn't worry. 13:07 oleonard Do email preferences typically accept multiple values? 13:17 TimothyAlexis Which statuses can appear in the /cgi-bin/koha/opac-user.pl#opac-user-holds table? I know Pending, In-transit and Waiting, are there any more? 13:19 oleonard Suspended, Suspended until <date> 13:23 TimothyAlexis oleonard++ 14:14 magnuse huh, trying to make a custom xslt, i copied the marc21 intranet detail xslt and MARC21slimUtils.xsl to /home/vagrant/kohaclone/, set XSLTDetailsDisplay to the right path, set <xsl:import href="/home/vagrant/kohaclone/MARC21slimUtils.xsl"/>, restarted all the things. but detail view does not show any data from the marc record. nothing in the logs. what am i forgetting? 14:17 oleonard magnuse: Did you do the little dance and say the magic words? 14:17 magnuse gah, that must be it! 14:18 magnuse @quote add oleonard> magnuse: Did you do the little dance and say the magic words? 14:19 oleonard Did you copy MARC21Languages.xsl? 14:19 magnuse oops 14:20 oleonard I think that one is fairly new, and I think it tripped me up the last time I was trying to make it work. 14:20 magnuse right you are! 14:20 magnuse oleonard++ a thousand times over 14:21 oleonard Hooray, my past pain has helped someone! 14:21 magnuse and it is included from the util file, not the main xslt... 14:21 magnuse yeah, that saved me some hours and some grey hair, i bet 14:40 caroline oleonard-away: did you ever read Strange planet? If not, I think it'd be right up your alley :) 14:47 oleonard caroline: The comic? 14:48 caroline yes 14:48 caroline with the aliens 14:54 oleonard I've seen it here and there... On the other hand I re-watched La Planète sauvage just the other day! 15:09 caroline huh, I didn't know the reference! Then again, I'm not much a fan of experimental french movies 15:30 ashimema wizzyrea++ #gifting us more disk for the manuals 15:30 caroline When I go to https://koha-community.org/manual/20.11/en/html/ and click on Administration, I get a "Not found" error, can someone confirm it's not just me? 15:30 ashimema I've just triggered a couple of builds for you caroline.. hopefully we'll have up to date 20.11 and 21.05 manuals again soon 15:30 ashimema yup 15:30 caroline ah that must be it 15:30 ashimema it's not just you 15:30 ashimema that's what I just fixed. 15:30 ashimema but it'll take a while for the builds to run now 15:31 ashimema https://gitlab.com/koha-community/koha-manual/-/pipelines 15:31 caroline thanks ashimema! wizzyrea++ 15:31 ashimema see the two blue spinning ones ;) 15:45 cait1 ashimema++ caroline++ wizzyrea++ 15:56 oleonard cait1: Did you see my recent comment on Bug 5697? 15:59 reiveune bye 16:24 cait1 oleonard: sorry way behind on bug mail, hope to catch up over the weekend 16:24 cait1 bug 5697 16:24 oleonard no huginn, no gmcharlt! 16:26 cait1 scary! 16:26 cait1 your comment reads good 16:26 cait1 if the space issue is always ther we should just file a separate bug for it i guess? 16:27 oleonard You're right I'll go ahead and do that 16:30 cait1 but yep, i think back to qa for this one :) 18:48 ashimema Yeah, first pair of successful builds for the manual for a while 18:48 ashimema 20.11 and 21.05 links should be working now :) 18:58 caroline ashimema++ 19:54 oleonard Maybe this? https://zivotdesign.com/p/view.php?p=16143692116112 19:54 caroline cool!