Time Nick Message 00:28 liliputech_asu hi koha 02:45 liliputech_asu bonjour inlibro j'ai retesté bz 14784 il y a encore des tests unitaires qui ne passent pas. j'ai vu que charles farmer avait repris ce bz, bon courage à lui! 06:12 reiveune hello 06:12 wahanui hello, reiveune 07:43 alex_a Bonjour 07:59 liliputech bonjour 08:00 liliputech !later tell ashimema i've put some new on BZ 7376, if you have some time to check it out (also cait1 ) 08:03 cait1 with@ :) 08:03 cait1 bug 7376 08:03 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 major, P5 - low, ---, lari.taskula, Needs Signoff , Transfer limits should be checked at check-in 08:05 liliputech oh ^^ thanks cait1 :) 08:05 liliputech @later tell ashimema i've put some new on BZ 7376, if you have some time to check it out (also cait1 ) 08:05 huginn liliputech: The operation succeeded. 08:06 * liliputech spends too much time talking to bots, not enough with humans so it seems 08:16 liliputech hi paul_p_ , hi lds 08:19 cait1 :) 08:21 liliputech @quote random 08:21 huginn liliputech: Quote #152: "gmcharlt: Koha: unifying the world one library at a time" (added by wizzyrea at 02:19 PM, September 13, 2011) 08:21 liliputech :) 08:21 liliputech :) 08:21 liliputech @quote random 08:21 huginn liliputech: Quote #324: "<LibraryClaire> we had to improvise to get across switzerland" (added by magnuse at 09:03 AM, October 18, 2016) 08:21 liliputech haha 08:21 liliputech @quote random 08:22 huginn liliputech: Quote #122: "<member:oleonard>Everyone is doin' the hot new dance the Cracked Out Kitty Tail Shiver" (added by wizzyrea at 03:01 PM, March 30, 2011) 08:22 liliputech @quote random 08:22 huginn liliputech: Quote #122: "<member:oleonard>Everyone is doin' the hot new dance the Cracked Out Kitty Tail Shiver" (added by wizzyrea at 03:01 PM, March 30, 2011) 08:22 wahanui i already had it that way, huginn. 08:22 liliputech @quote random 08:22 huginn liliputech: Quote #125: "<oleonard> gmcharlt: Or I could fill the tub with milk and cereal and lock them in the bathroom." (added by gmcharlt at 01:14 PM, April 06, 2011) 08:22 liliputech haha nice ^^ 08:26 huginn News from kohagit: Bug 27673: Fix t/Context.t <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=02b056508df4c4e7e3eb33a5f354300339e8048d> 08:47 ashimema wha... 08:47 ashimema milk in a bath.. yuk 08:47 kohaputti anybody want to help with fixing some checkout problems (whether a patron can checkout a book or not is a bit buggy and lots of logic duplication)? I have few refactoring and bug fixes in my head and will start writing them to source files if I find interested people. Asking because the C4/Circulation.pm and C4/Reserves.pm is very prone to merge conflicts. This refactoring i have in mind would also help reducing the chances of 08:47 kohaputti conflicts in future. 08:48 ashimema I'm totally on board with that 08:48 ashimema and totally owe you a big and painful QA run... C4/Circulation would certainly count 08:50 kohaputti whee, I guess I could be brave enough to start fixing it with one person interested in signing-off :) Let's see what I will have by the end of day. 08:50 ashimema I could possibly talk Sally into that.. she's pretty good regards testing.. 08:51 ashimema or/and AndrewFH 08:51 ashimema or/and severine_q 08:51 ashimema for me.. those are the strongest SO team :) 08:52 ashimema I reckon I could bend kidclamps are for QA too as a backup.. Circ is a big scary place :) 08:57 ashimema liliputech_asu++ #bug rescue 08:59 liliputech ashimema: ur welcome, thanks for ur attention on that one in the first place :) 09:03 kohaputti Joubu, I decided it was best to leave out the bug 22569 from the reviews at this time because that change was quite complicated, I noticed your comment number 46 there and most of the issues you raised there was due to the patches in this bug 22569 only and not on the dependent ones. 09:03 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 new feature, P5 - low, ---, martin.renvoize, Signed Off , Add a 'Transfers to send' report 09:04 kohaputti Joubu, just saying this in case you are holding back on pushing the dependend bugs because of this, maybe it would be better to push bug 22569 only later when QA has reviewed it 09:05 Joubu kohaputti: ok, thanks 09:06 Joubu kohaputti: About the circ refactoring - start with opening bug reports, to tell us what exactly is in your head ;) 09:08 ashimema Sorry I was off the last couple of days so haven't got to Joubu's comments yet 09:08 ashimema but yeah.. those final two patches, bug 22569 haven't been through QA yet.. I have cait lined up 09:08 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 new feature, P5 - low, ---, martin.renvoize, Signed Off , Add a 'Transfers to send' report 09:09 ashimema but.. thanks for the review anyways.. means I can start taking care of things :) 09:09 ashimema I'll just finish reviewing bug 7376 than jump back onto my own bugs 😉 :) 09:09 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 major, P5 - low, ---, lari.taskula, Needs Signoff , Transfer limits should be checked at check-in 09:10 liliputech ashimema++ 09:11 kohaputti Joubu, The bugs already have bug reports, although I don't think we have issues for logic duplications. I find bugzilla model kinda hard to work with when doing changes that do not relate to specific issues but just enhance code quality (like removing duplicated logic). 09:12 Joubu why is bugz model a problem in that case? 09:14 kohaputti Joubu, hmm maybe there is no problem, I was thinking release notes and dependency fields in BZ, but in release notes I could list all the improvements/fixes from the patches attached to that bug report 09:16 kohaputti Like if I attach a series of patches to just one report and it fixes dozen other bug reports we have we can just probably add those as duplicate later when the series is pushed 09:16 kohaputti so I think I can make it work 09:16 kohaputti The circ bug reports I see are many times due to same root cause 09:18 ashimema Hmm, i had that issue with some of the accounts stuff.. in places I ended up fixing bugs I wasn't even aware of without specifically meaning to.. 09:18 ashimema I keep finding old reports where I suddenly realise I've already fixed it.. and I end up marking them as resolved fixed with a link.. but that of course never make it into a release notes set. 09:19 ashimema not sure how another system would better that though.. think it's unfortunately just part of the game 09:20 kohaputti Another system I had in mind was to keep bug reports separate from reviewing and handling patches 09:21 kohaputti It's what I'm used to elsewhere 09:21 koha-jenkins Yippee, build fixed! 09:21 wahanui Congratulations! 09:21 koha-jenkins Project Koha_Master_D9 build #1565: FIXED in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1565/ 09:21 kohaputti that's why I probably feel it more intuitive 09:21 koha-jenkins Project Koha_Master_D9_My8 build #510: STILL UNSTABLE in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/510/ 09:22 magnuse did we know the national libraries of greece and cyprus use koha? 09:22 ashimema greece yes.. wasn't aware cyprus did 09:22 liliputech nice 09:23 magnuse coolio 09:23 ashimema with these transfer limits liliputech 09:23 liliputech indexing καλημÎÏα should be a challenge :) 09:23 Joubu kohaputti: I am excited by the idea of 1 patch that fixes them all, submit! :D 09:23 Joubu (well, write it before) 09:24 liliputech ashimema: yes? o:) 09:24 kohaputti Joubu, series of patches, coming right up :) 09:24 ashimema should we not allow a patron to return their item to a library that restricts transfers to it so long as it doesn't restrict a transfer back from it.. 09:24 ashimema my brain hurts trying to describe that 09:25 liliputech hooo, i suddenly understand why the licencing is "GNU" (actually the sound i did produce while trying to understand your last one) 09:26 liliputech describe what "it" means in your sentence may make it easier to understand :) 09:27 ashimema Limit = A -> B not allowed 09:27 ashimema Should a Patron be allowed to return an item to B 09:27 ashimema There is not limit from B -> A.. so the item can make it's way home OK 09:28 ashimema or.. are you intentionally restricting checkin in both directions.. 09:28 liliputech hum. maybe. it should be allowed to return to B. 09:28 ashimema :) 09:28 liliputech I was strugling with same question yesterday :) 09:28 ashimema I can fix it with a QA followup 09:29 ashimema haha.. yeah.. it's really not obvious is it. 09:29 liliputech hehe, nup! 09:36 ashimema I think we need to take account of the 'returnbranch' circulation rule 09:37 ashimema I don't think we shoulc block for an 'OR' case... 09:37 ashimema or not block for the OR 09:38 ashimema Let me add a followup and then the code will speak for itself 09:38 liliputech ashimema yes please :) 09:39 liliputech cant visio now but if needed can be planned 09:40 liliputech keyboard is a slow interface to have a discussion ;) 09:41 ashimema :) 09:41 ashimema leave it with me :) 09:43 liliputech thanks, ping when followup is ready :) 09:43 liliputech (actually given there will be no hackfest we should have one on the internet sometime) 09:45 liliputech i mean, i don't know if paul_p has decided something but i *guess* it won't physically happen this year. 09:57 Joubu really, why that??? 09:57 Joubu @karma covid 09:57 huginn Joubu: covid has neutral karma. 09:57 Joubu really? 09:57 Joubu covid-- 09:57 Joubu covid-- ^100 10:15 nlegrand Salut #koha! 10:34 liliputech Ohayo gozaimasu nlegrand, daijobu desu ka? :) 10:38 nlegrand liliputech: 大丈夫ã§ã™ã‚ˆï¼ 10:41 nlegrand Maybe for the next hackfest in Marseille I'll bring some chess and shogi games if there are some players :). 10:42 nlegrand I'm longing so much for going to a hackfest in Marseille ^^ 10:42 nlegrand Or xiangqi or go also. 10:49 liliputech nlegrand: those are games to spend a night on :) I only know chess and go actually 10:52 nlegrand great! 10:55 koha-jenkins Project Koha_Master_D9 build #1566: UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1566/ 11:00 oleonard Hi #koha 11:00 liliputech nlegrand: those are game which can be played through internet :) but having stones in hands and clicking them on a board is nice! never tried online go (or chess) 11:00 nlegrand o/ oleonard 11:01 liliputech nlegrand: not sure there will be a hackfest in marseille this year... :( maybe hackfest online? 11:01 oleonard liliputech: Those random quotes were really something! 11:02 nlegrand liliputech: for chess lichess is opensource and excellent. For go I didn't try to play yet but I have an app to do some tsume from time to time. 11:04 nlegrand liliputech: maybe in Automn? 11:04 liliputech :) 11:05 liliputech hi oleonard o/ 11:16 * oleonard finishes researching why he said those strange things and gets to work 12:11 oleonard It would be cool if you could run an SQL report without saving it. 12:27 magnuse hiya nlegrand 12:27 magnuse covid-- 12:30 liliputech oleonard: you mean, like in an sql client? o:) 12:31 oleonard Why not? 12:32 liliputech huuuum... yup that actualy make quite sense... like a "try report" button and result would open in another tab/window so you keep the editing context? 12:33 liliputech (without the hassle of configuring an sql client and network/permission overhead) 12:33 liliputech the more i think about it, the more it sounds very nice. maybe a koha-plugin? 12:34 liliputech (actually, very useful feature, deserves to get into master) 12:35 liliputech only drawback i can think about is, you probably don't want to give anyone the possibility to create and run reports on your koha instance, performance and other things could break. i don't know the permissions in koha, are they different for editing and running a report? 12:36 oleonard I believe so 12:36 liliputech then testing a report should only be accessible to people with editing capabilities 12:36 liliputech (I guess) 13:07 nlegrand o/ magnuse 14:34 Joubu kohaputti: if you are working on bug 27718, maybe you should fix on top of bug 27131 14:34 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27718 normal, P5 - low, ---, koha-bugs, NEW , Holds to Pull list doesn't respect holdallowed circulation rule anymore 14:34 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Move code from circ/pendingreserves.pl to modules 14:35 kohaputti Joubu, thanks, if I start working on fix I will keep it in mind. 14:36 kohaputti currently trying to finish up the circ / reserve refactoring and fix patch series 14:45 ashimema sorry liliputech.. it's been a long day 14:45 ashimema Just pushed a couple of patches up to 7376 14:45 ashimema I reckon we should squash a bunch of those soon.. we've gone round the houses a bit.. but I think what I've done there now achieves what has actually been asked for. 14:45 ashimema right.. 14:46 ashimema onto my queue of mail.. I'm waaaaay behind today. 14:55 Joubu kohaputti: I thought you were saying you were working on it. I will have a look now then 15:00 kohaputti Joubu, I was working on it a bit, at least I found the root cause it was the holdallowed rule missing. I have still the the refactoring series work open and this bug report came to me from library so I paused it and send report in so we won't forget this issue. 15:01 kohaputti Joubu, i saw you marked it as assigned now so thanks, I appreciate the help! :) 15:02 kohaputti Joubu, you are so fast there is a patch pending sometimes from you before I even have opened $EDITOR and marked bug as assigned. :P 15:03 Joubu sometimes it's easy, so I prefer to fix ASAP :) 15:14 Joubu kohaputti: Here you go. Thanks for having forced me to move some code to a module. Now we have tests, and it's easy to add new ones :) 15:17 kohaputti thanks! 15:24 Joubu @later tell mtj Yesterday I pushed 27673, which introduces YAML::XS as a new deps. Look like Master_U16 is failing because of that. Do you think it's ok to drop U16 support for 21.05? 15:24 huginn Joubu: The operation succeeded. 15:31 huginn News from kohagit: Bug 24108: DBRev 20.12.00.013 <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6bd75d6dcaf77a7d5b11c1eabcbdb17ae0f6e12a> 15:31 huginn News from kohagit: Bug 26274: (QA follow-up) Fix the order of summary groups <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=02b9c904fee4f910fc71dcad1a473659830702d8> 15:31 huginn News from kohagit: Bug 24108: Remove extra spaces <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0269d2b30ec3f0a90c57782229a575113c3dfc96> 15:31 huginn News from kohagit: Bug 24108: (QA follow-up) Add staff detail page to syspref description <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3f755c3ab150c1a530b63cad188d0171ae81efb0> 15:31 huginn News from kohagit: Bug 24108: (QA follow-up) Add missing comma in sysprefs.sql <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=231b3487e225af66a4bade50249567a3c2048c9a> 15:31 huginn News from kohagit: Bug 24108: Make export file names consistent <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=234cced91df51c2460152897f8c08e0b891d240c> 15:31 huginn News from kohagit: Bug 24108: (QA follow-up) Adjust wording and use perl for update file <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0b1f162dccfe0f7edc1505fc0648dfa7f7792ca8> 15:31 huginn News from kohagit: Bug 24108: (follow-up) Fix typo with .xml extension <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=88b751e54fef91ca69156ea02895d7dcdcafbf99> 15:31 huginn News from kohagit: Bug 24108: Advanced editor: configure if biblionumber or control number is used for... <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=227077c43dee8f2837cceaa23f9a0d97d721f01e> 16:19 koha-jenkins Project Koha_Master_D9_My8 build #511: FAILURE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/511/ 16:58 kohaputti decided to push the WIP patches for the refactoring of circ and hold stuff to bug 25690 16:58 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 normal, P5 - low, ---, joonas.kylmala, NEW , SIP should not allow to check out an item in transfer because of a hold to another patron 17:23 koha-jenkins Yippee, build fixed! 17:23 wahanui Congratulations! 17:23 koha-jenkins Project Koha_Master_D9 build #1567: FIXED in 1 hr 4 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1567/ 17:28 lilipute1h dude, it's not even 7pm and already a second pastis... subconscious says i'm missing marseille's camps... covid-- 17:35 cait1 lilipute1h: not only you... just without pastis here 17:38 cait1 bye all 17:38 lilipute1h @later tell cait1 well, in your place, there is Ströh (not sure i spell it right) 17:38 huginn lilipute1h: The operation succeeded. 18:34 reiveune bye 19:11 cait Joubu: still around? 19:53 ashimema @later tell kohaputti looks like we might be working in similar areas again.. I will definitely check out bug 25690 tomorrow. I spotted some fun around reserves and transfers while doing some further review of transfers given Joubu's feedback 19:53 huginn ashimema: The operation succeeded. 20:24 koha-jenkins Project Koha_20.05_D9 build #227: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/227/ 20:28 koha-jenkins Project Koha_20.05_U16 build #231: SUCCESS in 45 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/231/ 20:34 * thd returned from post office but the scheduled IRC meeting had not started. 20:36 oleonard In my experience no one really wants meetings at this time :( 20:36 cait oh 20:37 koha-jenkins Project Koha_20.05_U18 build #95: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/95/ 20:38 thd In New York City, with a totally broken economy, even the post office has no consistent open hours. 20:39 thd If there is no meeting now I should go to the bank with ever shrinking hours. 20:39 * oleonard just got a letter mailed almost exactly one month ago from two states over. 20:41 thd The US Postal Service near New York is so short of staff that mail processing overflow has gone to Texas for spare processing capacity even if it is sent back to New York for local delivery. 20:43 koha-jenkins Project Koha_20.05_U20 build #260: SUCCESS in 59 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/260/ 21:12 koha-jenkins Project Koha_20.05_U2010 build #124: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_20.05_U2010/124/ 21:12 koha-jenkins joubu: Bug 27154: Fix test if the cache is populated already 21:12 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154 normal, P5 - low, ---, jonathan.druart, Pushed to oldstable , Koha/Util/SystemPreferences.pm must be removed 21:30 koha-jenkins Project Koha_20.05_D10 build #229: SUCCESS in 52 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/229/ 21:47 koha-jenkins Project Koha_20.05_U16 build #232: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/232/ 21:54 koha-jenkins Project Koha_20.05_D9 build #228: SUCCESS in 1 hr 11 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/228/ 21:55 koha-jenkins Project Koha_20.05_U18 build #96: UNSTABLE in 43 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/96/ 22:22 koha-jenkins Project Koha_20.05_U20 build #261: SUCCESS in 52 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/261/ 23:09 koha-jenkins Project Koha_20.05_D10 build #230: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/230/ 23:19 koha-jenkins Project Koha_20.05_D9 build #229: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/229/ 23:23 koha-jenkins Project Koha_20.05_U2010 build #125: SUCCESS in 53 min: https://jenkins.koha-community.org/job/Koha_20.05_U2010/125/ 23:49 koha-jenkins Project Koha_20.05_U20 build #262: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/262/