Time Nick Message
03:50 koha-jenkins Yippee, build fixed!
03:50 wahanui Congratulations!
03:50 koha-jenkins Project Koha_19.11_D10 build #134: FIXED in 45 min: https://jenkins.koha-community.org/job/Koha_19.11_D10/134/
06:30 koha-jenkins Project Koha_19.11_U16 build #53: STILL FAILING in 5 min 24 sec: https://jenkins.koha-community.org/job/Koha_19.11_U16/53/
06:30 koha-jenkins Project Koha_19.11_D10 build #135: FAILURE in 2 min 50 sec: https://jenkins.koha-community.org/job/Koha_19.11_D10/135/
06:41 reiveune hello
06:41 wahanui kia ora, reiveune
07:04 koha-jenkins Project Koha_19.11_U18 build #297: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/297/
07:07 koha-jenkins Yippee, build fixed!
07:07 wahanui Congratulations!
07:07 koha-jenkins Project Koha_19.11_D8 build #370: FIXED in 41 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/370/
07:07 koha-jenkins Project Koha_19.11_D9 build #301: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/301/
07:22 koha-jenkins Project Koha_19.11_U20 build #195: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_19.11_U20/195/
07:27 cait1 good morning #koh!
07:27 cait1 #koha even :)
07:30 alex_a Bonjour
07:30 wahanui kia ora, alex_a
07:55 magnuse \o/
08:53 TimothyAlexis I took bug 14783 and need some help to get started
08:53 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 enhancement, P5 - low, ---, timothy_alexis.vass, ASSIGNED , Allow patrons to change pickup location for non-waiting holds
08:54 TimothyAlexis Also, I'm wondering, if I make the patch for master, if it would be backported to 20.05. Otherwise I'll do it for 20.05...
09:32 magnuse TimothyAlexis: enhancements should aways be made for master, and are not backported
09:34 TimothyAlexis We will be using 20.05 until October :/
09:38 TimothyAlexis Is there much difference in the related parts between master and 20.05 ? I am considering making the patch for master and then backport it specifically for our branch.
09:41 kohaputti The bugfix from bug 22690 has been sitting in signed-off state for quite a while so hoping someone from QA team could take a look.
09:41 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 normal, P5 - low, ---, ere.maijala, Signed Off , Merging records with many items too slow (Elasticsearch)
09:44 ashimema Mornin' #koha
09:46 cait1 kohaputti: performance and elastic... both a little hard for me :(
09:46 cait1 is it easy to test?
09:46 Joubu kohaputti: see 27344
09:47 Joubu isn't the problem that the reindex is not async?
09:49 kohaputti Joubu, as far as I remember the problem was that it made way too many requests so even with async it would be issue
09:49 Joubu yes, because you have to wait the reindex to be done
09:49 Joubu for*
09:50 kohaputti cait1, the test plan is pretty comprehensive so should be easy to follow
09:50 Joubu kohaputti: I understand your point, but the big problem is the async situation
09:51 Joubu ofc it would be better to have one 1 request anyway
09:52 kohaputti yup, both need fixing
10:04 Joubu pfiou
10:04 Joubu it's so hard to work with all those bugs :D
10:05 Joubu trying to do something simple and I end up with 4 new bug reports
10:05 kohaputti if things get even more async with the search indexing I'm guessing more race condition related problems will occur in real life situations. Maybe we should think about a indexing queue in db for indexing requests so that things will happen in the right order but I'm also not 100% sure it will catch all race condition problems
10:06 Joubu kohaputti: no
10:06 Joubu it's saying "index this record", nothing more
10:06 Joubu so the latest version of the record will be index
10:06 Joubu ed
10:07 kohaputti if one request says delete and another one update/create then that seems like a race condition
10:07 kohaputti so it would leave "ghost result" in the koha search results
10:08 Joubu Won't the update will explode if it's deleted?
10:08 kohaputti if it does then great :)
10:09 Joubu still the delete/create will create a race condition
10:09 Joubu iirc the patch is only about update/create, not delete
10:10 Joubu kohaputti: we discussed this a bit with ashimema at the last dev meeting.
10:10 kohaputti ok
10:10 Joubu add your thoughts in a comment on the bug report
10:10 Joubu still at discussion state so far
10:10 Joubu that must be top priority
10:11 kohaputti my thoughts on this are shallow so not very useful without me diving into the code first
11:10 oleonard Hi all
11:42 oleonard ashimema around?
12:30 ashimema quiet in here today
12:30 * magnuse makes some noise
12:31 ashimema oleonard around?
12:31 oleonard I am
12:31 oleonard Looking for you!
12:31 magnuse ashimema, meet oleonard. i am sure you will find you have some things in common you can talk about
12:32 oleonard Oh cool ashimema do you like sci-fi movies of the seventies too??
12:41 oleonard magnuse: I think I scared him off
12:58 cait1 ashimema: you are ignoringmy pm .... and then complain about it being quiet? :)
12:58 cait1 oleonard: I'd certanly give them a try
13:05 magnuse oleonard: yeah, he can be a bit shy
13:16 severine_q Hello #Koha :D
13:17 oleonard Hi severine_q
13:22 severine_q Hi oleonard !
13:34 cait1 hi severine_q :)
13:38 oleonard kidclamp.
13:38 wahanui it has been said that kidclamp is the almighty leader
13:38 cait1 lol
13:38 cait1 i am nto sure if i want to say forget or not now
13:38 severine_q Hi cait1 !
13:39 cait1 how are you doing?
13:39 cait1 has she outgrown it already? :Ö)
13:39 cait1 :)
13:42 severine_q i'm fine ! and you ?
13:42 severine_q not yet, I think it'll feet a few more weeks !
13:43 tcohen :-D
13:43 tcohen so big now, I guess .-D
13:44 severine_q 7 months today !
14:14 kidclamp i am kidclamp
14:14 kidclamp oleonard
14:14 wahanui it has been said that oleonard is happy for ashimema to write the release script
14:14 oleonard kidclamp: You should QA Bug 26958.
14:15 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26958 enhancement, P5 - low, ---, oleonard, Signed Off , Move Elasticsearch mapping template JS to the footer
14:25 * kidclamp will look
14:41 cait1 kidclamp: and can you take the performance one for merging items after?
14:43 Joubu is that a "kidclamp is going to QA all we ask him to" moment?
14:43 cait1 i thought it was worth a try :)
14:43 cait1 but you ahve to get in queue
14:43 cait1 no RM privileges!
14:45 cait1 hi AndrewFH!
14:45 kidclamp I'll do what I can :-)
14:45 Joubu no RM privileges, but kidclamp can be bribed easily
14:45 cait1 darn.
14:45 cait1 ;)
14:45 * kidclamp also likes to receive QA, is true
14:45 AndrewFH howdy :)
14:46 cait1 I'll see waht i can do
14:46 kidclamp if I do your request first Joubu can I get a 'get ouf of QA free' card? ;-)
14:46 kidclamp "this is brokena dn will break stuff, but oh well, pushing it anyways"
14:46 cait1 lol
14:47 kidclamp rm -rf ./acqui
14:48 Joubu depend on which one :D
14:50 ashimema lol
14:53 * cait1 is trying to figure out if koha will explode if she just "pretends" soemthing arrived that actually has no ivoide...
14:54 cait1 invoice
14:54 cait1 so i feel you kidclamp
14:54 kidclamp KOha does not police your imagination cait, but it does barf on bad workflows
14:55 cait1 migration issue
14:55 cait1 i am pondering
14:55 cait1 this is from a system where receiving and dealing with invoices are completely separate processes... and well... in Koha they are not
14:57 oleonard ashimema: The test plan for Bug 27661 says to test without RabbitMQ installed. How would I do that?
14:57 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 normal, P5 - low, ---, martin.renvoize, Needs Signoff , Clarify error for message broker
14:58 ashimema er.. don't install it
14:58 Joubu stop it
14:58 ashimema haha
14:58 ashimema of course.. k-t-d and kohadevbox both install it now I bet..
14:58 ashimema yeah.. stop it
14:59 * oleonard shouts at RabbitMQ
14:59 ashimema `service rabbitmq stop`
14:59 ashimema or something along those lines
14:59 * ashimema actually just didn't have it installed in the first place as it's not actually a hard requirement.. more of a performance recommendation
14:59 oleonard "service rabbitmq-server stop" if anyone is playing along at home.
15:01 ashimema :)
15:01 cait1 kohadevbox doesn't :)
15:01 cait1 i can test heh
15:02 oleonard ashimema: By the way, I haven't had a chance to try Bug 14233 again but another issue i ran into was that I found I couldn't delete a notice. it would appear to work but then the notice would still remain.
15:02 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 enhancement, P4, ---, martin.renvoize, Needs Signoff , Add logging support to notices and slips management
15:02 oleonard Like the other error, maybe that's just me? :/
15:02 oleonard cait1: Still a kohadevbox holdout? :)
15:02 cait1 yeah
15:03 cait1 not giving up on my beloved dev env
15:03 ashimema ooh.. I just replicate the delete one
15:03 ashimema thanks oleonard.. I'll look into that now
15:03 cait1 oleonard: there is no "just you" btw
15:04 * oleonard looks behind himself in a panic
15:04 cait1 heh
15:04 cait1 your opinion matters to us
15:05 * cait1 whispers fail all the things
15:05 cait1 QA queue empty, kidclamp's problem solved
15:05 oleonard cait1: To clarify, sometimes the "just me" part comes from having sample data he put in his test Koha 10 years ago and keeps reusing
15:05 cait1 you have a 10 year old test database?
15:05 cait1 i am so jealous
15:06 oleonard I no, I'm talking about myself in the third person with /me.
15:06 oleonard I don't actually know if it's 10 years old, I just know that I keep upgrading it.
15:06 cait1 ok, now you confused me, but it could also be this data
15:19 oleonard Thank you kidclamp!
15:19 oleonard kidclamp++
15:24 Joubu kidclamp: the problem with UniqueItemFields (bug 27671) is because the new item form is keeping the value from the item we just saved
15:24 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27671 major, P5 - low, ---, tomascohen, Passed QA , Missing include in orderreceive.tt
15:25 Joubu in 20.05.x it's not the behaviour, the input are empty
15:25 Joubu but I cannot think of a change that did that
15:25 ashimema delete fixed oleonard.. good catch
15:25 ashimema :)
15:26 ashimema I had only tested with deleting a single transport type.. i.e blanking a notice.. not clicking the overall delete button
15:26 ashimema :)
15:28 Joubu kidclamp: is that the expected behaviour?
15:28 Joubu The code says yes "/* Copy values from the original block (input) */"
15:29 Joubu so we fixed that (inadvertently...) and it introduced a bug somewhere else..
15:29 kidclamp I would expect that yes, the form keeps the values, but we should not be prevented form saving
15:29 kidclamp because the items are only added if the form is 'saved', right?
15:29 Joubu the values are not copied on 20.05.x
15:29 Joubu yes but
15:29 Joubu the problem is that the JS check function will go over the different items we created
15:30 Joubu BUT it includes the "new item form"
15:30 Joubu the item we haven't saved yet
15:30 Joubu on 20.05.x the inputs are always cleaned when a new items is added
15:30 Joubu but on 20.11 and master, the inputs are prefilled with the values of the last item we creaed
15:33 Joubu ho, there is dont_copy_fields = unique_item_fields.split('|');
15:35 fridolin Bug 27683 creasy feature
15:35 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 normal, P5 - low, ---, fridolin.somers, Needs Signoff , Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref
15:39 Joubu kidclamp: ok got it, patch attached
15:41 Joubu fridolin: creepy or creamy?
15:45 fridolin crazy :D
15:54 kohaputti cait1, we have the same issue with the invoice and receiving process not being together
15:55 kohaputti cait1, I think the librarians hacked some fake invoices in koha until the real one arrives
15:58 kohaputti cait1, I don't remember the details but if you wanna know more about how the process works I could give you my colleagues email address and maybe they would be able to help
16:10 cait1 kohaputti: that's really nice :) I think I am good to go - I wanted to avoid the "fake invoices" for ht emigration as they mean additional programming
16:11 cait1 i think in production it will be ok
16:11 cait1 not meaning we shouldn't improve Koha there :)
16:11 kohaputti i will check quickly how we did the migration.. I think I still got the migration scripts somewhere
16:11 kohaputti it was from Voyager btw.
16:12 cait1 different one here - not sure if it's better :)
16:12 cait1 i think i figured something out, but thanks again for offering!
16:14 * kohaputti remembers the acquisitions import was a hack
16:15 cait1 heh
16:15 kohaputti So I couldn't find it from the main source tree we used for the migration, it was probably a set of bash scripts / perl scripts
16:16 kohaputti cait1, best wishes for your migration! :)
16:16 cait1 thx, this one has been taking a while, hopefulle good ending :)
16:17 tuxayo Hi #koha o/
16:26 * oleonard-away grumbles about every bit of code he touches falling to pieces
16:27 ashimema hehe
16:31 ashimema haha.. kohaputti beat me to the YAML -> YAML::XS QA
16:31 ashimema nice one
16:31 ashimema I was just preparing to go deep on that one :)
16:31 ashimema Are you tempted by the YAML::Syck one too :')
16:32 kohaputti ashimema, not at least yet, says it is in discussion
16:32 kohaputti but would be nice to get rid of that so we have less dependencies
16:32 kohaputti one of the things on my todo list also
16:33 ashimema ooh.. so it is
16:33 ashimema wasnt a few minutes ago
16:33 ashimema lol
16:33 ashimema haha.. yeah.. think we share a few things on our todo's
16:34 ashimema nice to see these things moving forward
16:40 * kohaputti gladly gives ashimema QA of YAML::Syck -> YAML::XS after noticing the length of the patch series
16:41 ashimema Hahahaha
16:41 ashimema Well... I do owe you to be fair
17:25 reiveune bye
18:16 ivandz Hi all. Who can me explain about the file field_config.yaml, directly with a section 'default'->'fields'->'phrase'. I see this (type: text, analyzer: analyzer_phrase, search_analyzer: analyzer_phrase). Where we use this configuration? Thanks
18:19 ivandz it means we should also use field.phrase:(query)...but I didn't see that
20:16 koha-jenkins Yippee, build fixed!
20:16 wahanui Congratulations!
20:16 koha-jenkins Project Koha_Master_D9 build #1557: FIXED in 51 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1557/
22:05 caroline I hope I'm not spamming anyone, I'm adding tons of "Personal tags" on bz, the tooltip says no emails are sent, but every time I send it says "Emails sent to:" with email addresses
22:06 caroline *every time I save
22:31 cait they are personal, not being sent out, caroline :)
22:31 cait i have added some too in the past and i am subscribed to all bug mail
22:32 caroline thank you for reassuring me! :)
22:42 tuxayo caroline: «but every time I send it says "Emails sent to:" with email addresses»
22:42 tuxayo It's not due to the tag directly but because you are added to the CC list ("Add me to CC list" is ticked by default)
22:42 dcook caroline: And here I was thinking that you were just stalking my bugs
22:42 caroline omg, I'm soo sorry!
22:42 caroline I didn't realize I was adding myself
22:43 dcook I don't mind. It's not that many emails.
22:43 dcook Makes me feel better about my contributions haha
22:43 caroline well, you'll have seen everything that's been pushed to 21.05 :)
22:44 tuxayo I only got 5 emails so not a big deal
22:52 oleonard If a person has an SMS number defined do they get SMS overdue notices?
22:52 oleonard (assuming an SMS notice is defined as well)
22:55 oleonard Oh I see, there's a checkbox in Overdue notice triggers
22:56 oleonard If "Email" and "SMS" are both checked do they get both?
23:24 cait caroline: you can change the setting in the preferences if you want (the automatic cc)
23:25 cait sorry, I should have thought of that
23:25 cait but the emails are really nothing to be embarassed about
23:38 dcook oleonard: I think they get both
23:38 dcook I think I've also had some issues with SMSes where they've been going out even when someone doesn't have an SMS number but I need to look at that again..