Time  Nick                  Message
00:03 * dcook               was wondering how cait1 was still awake
04:06 aleisha               did my best to capture everything the academy students did today: https://wiki.koha-community.org/wiki/Catalyst_Academy#Day_1 looking forward to some signoffs!
06:51 fridolin              hi the world
07:09 reiveune              hello
07:28 severine_q            good morning #koha :)
07:55 jsicot                Hello
08:04 alex_a                Bonjour
08:15 jsicot                I have just noticed that the CloneBudgetPeriod function (C4::Budgets) only retrieves the owner of the budgets (aqbudgets.owner) but not the users who were attached to the reference budgets (aqbudgetborrowers).
08:15 jsicot                In your opinion, is this a choice or or could it be an idea for an enhancement request ? I haven't seen any bugs about this reported in bugzilla.
08:16 Joubu                 I would not modify C4 but use (or enhance) Koha::Acq::Funds instead
08:17 Joubu                 why do you need the users?
08:18 jsicot                we need to declare users to receive orders for a specific budget
08:25 jsicot                also, we have sometimes several acquisition librarians per budget
08:25 jsicot                every fiscal year, we need to redeclare them on every budgets
08:30 Joubu                 jsicot: so you want to write some code for something specific (not Koha core)?
08:33 jsicot                Joubu nope, my request is about koha core :) and the aqbudgetperiods duplicate function in acquisitions module >  Budgets administration
08:39 Joubu                 ok sorry, I was missing tea
08:39 jsicot                no worries ^^
08:41 Joubu                 so yes, CloneBudgetPeriod is the right place. And the enhancement makes sense. Maybe we need a checkbox in the "duplicate budget" view to enable/disable the copy of users?
08:42 jsicot                yes, it should be optional like the owner maybe
08:42 koha-jenkins          Project Koha_20.11_U2010 build #26: UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_20.11_U2010/26/
08:48 magnuse               i added a small section on upgrading koha here: https://wiki.koha-community.org/wiki/Koha_on_Debian#Upgrade please feel free to improve on it :-)
08:52 koha-jenkins          Project Koha_20.11_U18 build #23: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_20.11_U18/23/
08:55 jsicot                Joubu I can submit an enhancement request on bugzilla, if this is the good way to do
08:58 Joubu                 yes sure!
08:58 jsicot                Joubu ok, i will do that !
08:59 Joubu                 aleisha: you should tell the students to run the QA script. Some of the patches don't have the commit message correctly written (starting with "Bug 12345: ")
08:59 huginn                Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12345 enhancement, P5 - low, ---, koha-bugs, CLOSED INVALID, Can't Clear Reading History for Anonymous patron
09:01 koha-jenkins          Project Koha_20.11_U20 build #26: SUCCESS in 1 hr 3 min: https://jenkins.koha-community.org/job/Koha_20.11_U20/26/
09:03 koha-jenkins          Yippee, build fixed!
09:03 wahanui               Congratulations!
09:03 koha-jenkins          Project Koha_20.11_D10 build #42: FIXED in 1 hr 5 min: https://jenkins.koha-community.org/job/Koha_20.11_D10/42/
09:29 koha-jenkins          Project Koha_20.11_D9 build #35: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_20.11_D9/35/
09:46 koha-jenkins          Project Koha_20.11_U16 build #28: UNSTABLE in 53 min: https://jenkins.koha-community.org/job/Koha_20.11_U16/28/
09:58 koha-jenkins          Yippee, build fixed!
09:58 wahanui               Congratulations!
09:58 koha-jenkins          Project Koha_20.11_D11 build #41: FIXED in 57 min: https://jenkins.koha-community.org/job/Koha_20.11_D11/41/
10:02 cait1                 Can we get some SO for the Academy patches Joubu hasn't failed yet? ;)
10:14 davidnind             about to start....
10:14 ashimema              I'm snowed under today I'm afraid..
10:16 koha-jenkins          Project Koha_20.11_D9 build #36: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_20.11_D9/36/
11:03 cait1                 davidnind++ :)
11:07 oleonard              o/
11:13 cait1                 hi oleonard :)
11:14 oleonard              Exciting to see the patches coming in from the Academy
12:00 Joubu                 oleonard: Hi! I had a question for you
12:01 Joubu                 let me remember it :D
12:01 Joubu                 http://irc.koha-community.org/koha/2021-01-18#i_2324056
12:01 Joubu                 "DT plugins should be in koha-tmpl/intranet-tmpl/lib/datatables or koha-tmpl/intranet-tmpl/lib/jquery/plugins?"
12:03 oleonard              I think the idea was that lib/datatables was for "official" datatables files, which may or may not encompass the DT plugins we use
12:03 oleonard              I don't know that the distinction is that important
12:04 oleonard              But I find it nice to be able to look at lib/datatables and know that everything there came from the DataTables site
12:05 Joubu                 yes, me too
12:07 Joubu                 I think I will put the new plugin where others are already. And then open a separate bug report to move them all and start the discussion there.
12:07 Joubu                 thanks oleonard for your answer
12:10 oleonard              I can often explain my decisions, even if I can't justify them :D
12:12 Joubu                 haha, same here!
12:13 Joubu                 and I've just realised I don't need to add the plugin, it's included in the main datables.mi
12:13 Joubu                 min.js
12:13 oleonard              The fixed header one?
12:13 Joubu                 yes
12:23 oleonard              Joubu it should be enough to tell Academy folks to run simply "qa," correct? The other parameters are now default?
12:23 ashimema              yup
12:24 ashimema              I personally tend to add -vv as I like the full pretty output
12:24 ashimema              but it's not a requirement
12:25 oleonard              @later tell aleisha I updated the Academy wiki page to include running the qa test tools: https://wiki.koha-community.org/wiki/Catalyst_Academy#Writing_a_patch_and_attaching_it_to_the_bug
12:25 huginn                oleonard: The operation succeeded.
12:26 ashimema              oleonard++
13:39 ashimema              oleonard still around?
13:40 oleonard              Yes
13:40 ashimema              just thought I'd take a look at a couple of Academy bugs over lunch
13:40 ashimema              any thoughts on the use of the 'autofocus' attribute vs JavaScript method for first focus?
13:41 ashimema              there's a fair few focus bugs and all of them are using the existing pattern of using javascript.. just wondered if we aught to stick with that or aught to be migrating to using the attributes
13:41 oleonard              Only that our use of the "focus" class as a hook for some jQuery code was a choice made before wide support for the autofocus attribute.
13:42 ashimema              oh, now that's interesting..
13:42 ashimema              do we still support a 'focus' class then?
13:43 ashimema              so rather than introducing `$("selector").focus()` all over the place should we just be adding a `focus` class to the right element?
13:43 oleonard              I would say yes, especially for these Academy patches. But I think it's a good issue to raise, perhaps in another bug
13:43 oleonard              Oh are the patches doing $("selector").focus() ? I haven't looked at them.
13:43 ashimema              the one's I've looked at so far are
13:44 ashimema              none add a class
13:44 ashimema              they all target the element directly in jS
13:44 * ashimema            doesn't want to be mean.. just wondered
13:44 oleonard              Yeah the class is available specifically for that, so the patches are wrong
13:44 oleonard              :(
13:45 ashimema              do we document this stuff anywhere?
13:48 ashimema              I can totally understand the academy students not having a clue the focus class exists.
13:49 ashimema              humm.. interesting, I now see a few accessibility guides that frown upon using focus this way..
13:50 ashimema              they suggest you should only ever autofocus the 'skip to content' link (which of course the staff client doesn't have yet anyway)
13:50 ashimema              otherwise screen readers will skip to the focus point leaving the user without context
13:50 ashimema              humm
13:52 oleonard              There were other autofocus bugs with patches referenced so it was hoped they'd see the previous solution
13:53 ashimema              mmm, I don't think they're really referencing linked bugs the way I thought they would
13:53 ashimema              I've had the same with the ACC2 bugs.. I have a collector bug that explains it.. and lots of linked ones for each case..
13:54 ashimema              rather than spotting the collector.. they've asked what ACC2 means in each of the linked ones
13:54 ashimema              oh well
13:54 oleonard              I think we can make a pretty good argument for using autofocus despite the recommendation
13:54 ashimema              agreed
13:54 oleonard              Someone has clicked a link or button to take them to a specific task, they shouldn't have to wade through the whole nav to get to the task in question
13:55 oleonard              If you accept that logic then the question is whether the user has enough context when auto-focused.
13:55 oleonard              That is, is it clear to them that they've been moved directly into the process they initiated when they navigated to the page.
13:58 ashimema              I think you're right
13:58 oleonard              Although that may not help you when your client is going through checklists they found on the internet
15:04 huginn                News from kohagit: Bug 27413: Restore debarred and debarredcomment to batch patron mod tools <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=85ae9bd021aef4e7423669a61df7c4c7fd5b726b>
15:04 huginn                News from kohagit: Bug 27047: Fix suggestions filtering at the OPAC <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=63c49e1f89c298d6b385729fbfd9d30c7674a33a>
15:04 huginn                News from kohagit: Bug 27420: Use object accessor for $attr_type->class() <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=08396d4b2ffe7db4f7550631a751603f01387095>
15:04 huginn                News from kohagit: Bug 17429: document the --plack/--noplack options of koha-list <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=920d3efcdfe1efc79e81017f8340227063ae2973>
15:04 huginn                News from kohagit: Bug 27180: (follow-up) Remove unused %is_holiday <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a26d529a2bc7faee3743b4cd1e603ba29411a0b9>
15:04 huginn                News from kohagit: Bug 27299: Remove tokenization for phrase register/index with ICU <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7f9c909d5a603c40125064e7e32f24e595d596e2>
15:04 huginn                News from kohagit: Bug 27297: Add required and blank options to av-build-dropbox.inc <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cb95c9140316d4b9dc28cd696d14106b460774aa>
15:04 huginn                News from kohagit: Bug 27180: Update fines on holidays <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=80e1b4e66f01a07cad9bf37625d879f649edf52a>
15:04 huginn                News from kohagit: Bug 17229: Move tests to t/db_dependant/ILSDI_Service.t <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5f595aab028d0d5835b8e7ed3ffaf534e83c0db0>
15:04 huginn                News from kohagit: Bug 20971: Prevent Storable::thaw to fail on LastCreatedItem <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9a7f7787376253e0c0cda905734006ceba472d60>
15:04 huginn                News from kohagit: Bug 17229: Add unit test for BlockExpiredPatronOpacActions check <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a369a9c8c1867536ec537dfcae20a49349fffb34>
15:04 huginn                News from kohagit: Bug 17229: Check if patron is expired in CanItemBeReserved <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9c3f267350b07c16b4c8297ee7c05853748a26f9>
15:52 koha-jenkins          Project Koha_Master_D9 build #1538: UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1538/
15:58 liliputech_asu        hi koha, just noticed koha-testing-docker now pulls selenium/standalone-firefox :) any tests for the interface on the go?
15:58 liliputech_asu        if that is the case, it's a great news!
16:00 koha-jenkins          Project Koha_Master_D10 build #454: UNSTABLE in 55 min: https://jenkins.koha-community.org/job/Koha_Master_D10/454/
16:22 reiveune              bye
16:52 ashimema              did you forget to mark bug 27324 as signed off oleonard?
16:52 huginn                Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 minor, P5 - low, ---, mazen.i.khallaf, Needs Signoff , Use Koha.Preference() for intranetbookbag everywhere
16:56 oleonard              I added a followup... didn't I?
16:57 ashimema              ah, I misread
16:57 ashimema              oh well.. I've PQA'd it as it all does what is expected :)
16:57 oleonard              Oh I signed off my own patch too, which I don't usually do
16:58 ashimema              all good
16:58 ashimema              I'm happy with it's status now :)
16:58 ashimema              I can deal with the wrath of cait or Joubu if they don't like it.. hehe
17:04 caroline_crazycatlady "wrath of cait" seems mythical
17:04 caroline_crazycatlady (i.e. doesn't exist)
17:05 ashimema              hehe
17:05 ashimema              indeed
17:05 ashimema              it wasn't much of a risk on my part :P
17:07 oleonard              The "wrath of cait" is mythical in that it's a 12 foot beast with the head of a lion and the tail of a snake. It breathes fire.
17:20 koha-jenkins          Project Koha_Master_D11 build #187: UNSTABLE in 43 min: https://jenkins.koha-community.org/job/Koha_Master_D11/187/
17:21 ashimema              oleonard.. is it deliberate in bug 27440 that the checkbox column is larger on the search history?
17:22 huginn                Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 enhancement, P5 - low, ---, oleonard, Needs Signoff , Improve structure and style of result toolbars in the OPAC
17:22 ashimema              I've always found it a bit annoying that we seem to semi-often have really wide columsn that contain just a single checkbox
17:22 oleonard              I wasn't aware that it had changed. I can take a look if you'd like.
17:23 ashimema              I can't see why/how it's changed actually..
17:23 ashimema              but it's certainly different on the pre patch and post patch view I have here.
17:24 ashimema              hum.. maybe this just goes back to my patch we reverted that gave tables a fixed width globally..
17:24 ashimema              I think it's the same issue.. the columns are dynamically sized
17:24 ashimema              so.. perhaps nothing to do with this patch.. just to do with my slightly different data sets
17:25 oleonard              Yeah it doesn't look different to me before and after the patch
17:25 ashimema              I really like the consistency improvement btw.. looks nice
17:25 ashimema              ack.. gotta go help cook tea.. will come back to signing this off later :)
17:26 ashimema              for me the checkbox column is 171 pixels wide.. with a left aligned 13 pixel checkbox.. that just looks a bit silly to me
17:29 caroline_crazycatlady for those who work in libraries... what is the workflow when a user loses an item that has a hold on it?
17:30 caroline_crazycatlady I just tried it in 20.05.05, and there is no pop up or anything alerting the staff that there is a hold on this item
17:33 cait                  oh no
17:33 cait                  what did I miss?
17:34 AndrewFH              @caroline_crazycatlady I don't believe there is any sort of automated notice that there's a hold on an item as it gets marked lost. I suppose you could use a report to find holds for which there is no longer a valid not-lost item with which to fill the hold
17:34 huginn                AndrewFH: I've exhausted my database of quotes
17:35 cait                  could the mark lot from hold list feature be used here?
17:37 AndrewFH              hmm, you mean the Holds to Pull list? I'm not sure how that would fold in here
17:38 caroline_crazycatlady AndrewFH: no, not from the holds to pull list, I think there is a mechanism for that
17:39 AndrewFH              You mean, like, an item is currently checked out with a hold, that hold would trigger if the item were checked in, but instead the patron who has the item tells you it is lost, correct?
17:39 caroline_crazycatlady from the borrower's file, click on the barcode, change status to lost, if  MarkLostItemsAsReturned  is enabled, the item will be returned, but nothing alerts the staff
17:39 cait                  hm but doesn't it turn up on holds to pull then?
17:39 caroline_crazycatlady AndrewFH: yes, I think we mean the same thing
17:39 cait                  not a direct workflows... but indirectly
17:39 caroline_crazycatlady cait: no because it's lost
17:40 caroline_crazycatlady lost items don't appear on the holds to pull
17:40 caroline_crazycatlady afaik
17:40 AndrewFH              yup, my understanding matches caroline's
17:40 cait                  ah right
17:40 cait                  it's already lost... you are right
17:40 cait                  one step too far
17:40 AndrewFH              so i think your best option there is some sort of after-the-fact cleanup via report
17:40 cait                  ashimema: what's the wrath of cait thing?
17:41 caroline_crazycatlady ok thanks AndrewFH!
17:41 ashimema              I suppose if you had an item level hold you could trigger a notification
17:41 AndrewFH              or an enhancement to get a cool popup alerting you to holds when the last item on a bib goes lost
17:41 ashimema              but what about bib level holds.. might be challenging to identify those in this direction
17:41 caroline_crazycatlady last item on bib or for item-level holds, the item in question
17:42 ashimema              could work
17:42 ashimema              submit a bug.. :)
17:42 caroline_crazycatlady will do!
17:42 ashimema              hehe.. i was being cheeky cait
17:42 ashimema              then code it up.. I'll hold your hand ;P
17:43 caroline_crazycatlady maybe I'll delegate that to someone else lol!
17:43 ashimema              though.. I have a feeling it could be a bit more involved.. how many places can you mark an item as lost from?
17:43 oleonard              So many
17:43 ashimema              loads if memory serves.. you'd need to account for each of them
17:43 caroline_crazycatlady if you look at  MarkLostItemsAsReturned , lots
17:44 ashimema              I thought my popup for multi-part items was OK until I actually submitted it and people kept saying 'And what about a checking/checkout from X'
17:44 ashimema              indeed
17:44 AndrewFH              at least a couple of the MarkLostItem options are commandline, so you wouldn't beed to worry about an alert there
17:44 ashimema              at least in this case.. hopefully you'd be able to grep for that pref and quickly find them all
17:45 ashimema              or would you.. you could trigger an email notice for those cases ;)
17:45 ashimema              either way... I think you should give it a go caroline_crazycatlady :)
17:45 ashimema              I'm more than happy to guide
17:46 caroline_crazycatlady It's for a client, so maybe we will have to do it anyway
17:46 caroline_crazycatlady [off] a particularly grumpy client at that....
17:46 ashimema              money?
17:47 caroline_crazycatlady grumpy about money you mean? among other things, but mostly just grumpy in general :(
17:47 ashimema              I meant are they likely to sponsor a fix
17:48 caroline_crazycatlady ah, I don't know, since like I said they are grumpy about money too, we'll see
17:48 ashimema              on my annoying checkbox column sizing.. do you reckon resurrecting https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25242&attachment=108439 might get any traction oleonard?
17:51 henryb                What would the library do once they've been notified that the last item was lost- cancel the hold or order a new copy?
17:51 ashimema              oooh.. henryb is around :)
17:51 ashimema              happy new parenting henryb :)
17:51 henryb                I have a sleeping baby on my lap :)
17:51 ashimema              :D
17:51 caroline_crazycatlady hi henryb! I though we chould just show the regular hold pop up with the option to cancel the hold or ignore it (in the case where we would want to order a new copy)
17:52 caroline_crazycatlady aw congratulations henryb!
17:53 henryb                Thank you!
18:08 cait1                 congrats!
18:08 cait1                 oh no... i missed henryb
18:22 henryb                Thanks cait1
18:23 henryb                I am kind of around but using the browser version on my phone
18:23 henryb                I should work out how to use an IRC client one of these days
18:24 cait1                 i always fail to get it to work on my phone... so maybe we should switch notes sometimes :)
18:25 cait1                 henryb: trying to send you a personal message, hope you can see
18:55 cait1                 is it possible that the german web installer is broken in 20.11? :(
18:57 cait1                 http://paste.koha-community.org/27476
18:58 cait1                 te paths are missing the language code
18:58 cait1                 de-DE
18:58 cait1                 but... where and how to fix that?
18:59 cait1                 I really need this to work for tomorrow :(
19:04 cait1                 ok, starting the web installer anew after a reastart all does wonders
19:04 cait1                 sorry :)
19:05 davidnind             :)
19:08 * cait1               waves at davidnind
19:08 cait1                 davidnind++
19:09 davidnind             hi cait!!
19:13 davidnind             everyone has been busy on academy things!
19:15 cait1                 I have to pass tonight on academy :( but will rejoin tomorrow
19:19 davidnind             great! I think I will have a look at one more, then off to work..
19:36 aleisha               hi
19:38 davidnind             you were all very busy yesterday!
19:38 davidnind             aleishaa++
19:51 davidnind             hayley++
19:52 oleonard-away         Hi aleisha hayley davidnind
19:53 davidnind             hi oleonard!
19:53 wahanui               hi oleopard
19:56 aleisha               hi davidnind and oleonard - yup the students were hustling! thanks everyone for your speedy testing
19:56 aleisha               i'll make sure they're a bit more careful with their commit messages :) everyone is so eager to save kittens
19:57 caroline_crazycatlady saving kittens is very important after all
20:44 cait1                 :)
22:17 aleisha               they've found the manual bugs and are boosting through those too - feel free to tag some more for Academy!!
22:23 koha-jenkins          Project Koha_20.05_D10 build #196: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/196/
22:34 koha-jenkins          Project Koha_20.05_U18 build #57: UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/57/
22:37 koha-jenkins          Project Koha_20.05_U2010 build #92: SUCCESS in 52 min: https://jenkins.koha-community.org/job/Koha_20.05_U2010/92/
22:46 koha-jenkins          Project Koha_20.05_D9 build #192: SUCCESS in 59 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/192/
22:47 cait                  aleisha: will try to add some tomorrow before they start again
22:56 caroline_crazycatlady aleisha: wow! I saw all the merge requests! Go academy! *_*
23:02 koha-jenkins          Project Koha_20.05_U20 build #224: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/224/
23:19 caroline_crazycatlady Joubu or cait: is it normal that Pootle doesn't like the curly brackets for pluralization? https://snipboard.io/GJLmz8.jpg
23:22 koha-jenkins          Project Koha_20.05_U16 build #196: UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/196/
23:24 aleisha               thanks both!
23:25 aleisha               cait: do you want them to redo them?
23:38 koha-jenkins          Project Koha_20.05_D10 build #197: SUCCESS in 52 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/197/
23:42 koha-jenkins          Yippee, build fixed!
23:42 wahanui               Congratulations!
23:42 koha-jenkins          Project Koha_20.05_U18 build #58: FIXED in 39 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/58/