Time Nick Message 07:01 fridolin hi 07:27 reiveune hello 07:43 alex_a Bonjour 08:27 * cait1 waves 11:17 kohaputti kidclamp, just bumped into bug 10374 – I guess I could rebase the patch you submitted almost a decade ago, are you onboard with me? :) 11:17 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 normal, P5 - low, ---, kyle.m.hall, Patch doesn't apply , Clean up and unify CircControl related code 11:18 kohaputti The issue we have is that different circulation rules are used for renewal and fine calculation 11:19 kohaputti now the renewal goes based on the holdingbranch, but with fines it goes with homebranch. 11:20 tcohen morning 11:21 * cait waves 11:22 cait oh my 11:22 cait the treasures hidden in our bugzilla 11:22 cait morning tcohen 11:23 cait kohaputti++ old bug fixing 11:30 oleonard Hi #koha 11:31 kidclamp kohaputti: looks like that was khall? 11:31 kohaputti sorry, confused somehow the names 11:31 kidclamp I will always take the compliment of being confused for him :-) 11:34 tcohen hehe 11:38 kohaputti actually.. I think here CanBookBeRenewed has an issue... It should use the holdingbranch if PickupLibrary and homeorholdingbranch = holdingbranch. Or so I think, it is strange that the circ rule would be different based on whether it is when doing checkout, when doing fine calculation, when doing renewal 11:39 kohaputti using branch specific rules is not so great it seems :D 11:42 kohaputti hmm, there seems to be also problems with overdue notices not being triggered: bug 24550 11:42 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24550 enhancement, P5 - low, ---, koha-bugs, NEW , Books renewals triggers item loan policies to revert to branch renewing item 11:42 kohaputti (because using wrong circ rule I guess) 11:42 kohaputti actually... those should be based on the due date 11:42 kohaputti probably not related. 11:44 kohaputti and now the fix is back to bug 27032 11:44 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 enhancement, P5 - low, ---, joonas.kylmala, NEW , CanBookBeRenewed is not understandable and needs refactoring 11:45 kohaputti this functions seems to pop up in every problem :D 13:07 domm hey, in apache-shared-intranet-plack.conf a couple of scripts are deactivated "so they don't break under plack/starman" 13:07 domm any pointers what needs fixing? 13:07 domm we're running Koha under Plack, and would like to do eg stage-marc-import.pl 13:11 domm bug 15032 seems to be the cause? 13:11 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 major, P5 - low, ---, jonathan.druart, In Discussion , [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected 13:13 domm and/or bug 22417 13:13 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 new feature, P5 - low, ---, jonathan.druart, Pushed to master , Add a task queue 13:14 domm anyway: I've implemented my fair number of task queues using various tools (from filesystem, DBs to Redis) 13:15 domm But I don't know a lot about Koha etc 13:16 domm So if you have decided on a solution, and "just" need somebody to help implementing, I could probably do that (depending on the actual amount of work it'll take ...) 13:29 Joubu domm: Since 20.11 we have a task queue based on rabbit-mq. So far only the batch record modification tool has been implemented 13:29 Joubu have a look at 22417 13:29 Joubu the plan is to replace the other scripts to make them use this mechanism 13:31 domm ok, I was just reading through the issues , wow, lots of discussions 13:32 domm so I could port stage-marc-import.pl to the rabbitMQ solutiuon described in 22417 ? 13:38 Joubu yes! 13:38 Joubu that would beg reat 13:38 Joubu great 13:40 cait and add it to the Raod map :P 13:40 cait no, seriously 13:45 domm So I would "only" need to convert stage-marc-import.pl to Koha::BackgroundJob::MARCImport 14:03 Joubu that's not trivial 14:18 domm Joubu: I assumend that, hence the "only" :-) 14:19 domm were BatchUpdateBiblio|Authority also some cgi-scripts earlier? If yes, where can I find them (in git), because I assume I can get some nice hints on how to port stage-marc-import.pl 14:21 domm tools/batch_record_modification.pl ? 14:25 cait looks about right 14:34 Joubu domm: commit 63cf7a0307be91d30766a2cf971737077f75cfb9 14:34 Joubu Bug 22417: Adapt the batch_record_modification tool 14:34 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 new feature, P5 - low, ---, jonathan.druart, Pushed to master , Add a task queue 14:35 Joubu this commit provided the changes from the .tt and controller 14:35 Joubu compare with 14:35 Joubu commit 0848d46ce60b780a9530e46de0bddd2b7ed21ea1 14:35 Joubu Bug 22417: Add Koha::BackgroundJob::BatchUpdateBiblio 14:35 Joubu and you will get the point 14:36 Joubu I can provide you early feedback whenever you want 14:38 domm ok, thanks, we'll first need to set up rabbitMQ etc :-) 14:39 * ashimema hints that you don't actually need rabbitMQ at all 14:39 ashimema the workers fall back to polling the database 14:39 ashimema and we don't do anything clever like parallel jobs, forking, dependancies etc 14:40 ashimema we literally just do FIFO processing of jobs as and when they hit the queue... inside one daemon process 14:40 domm ashimema: ah, ok. 14:41 domm are there any docs available on the background job setup? 14:41 ashimema that's not to say "Don't play with RabbitMQ".. more to say.. "Don't get held up by a need to play with RabbitMQ" 14:41 ashimema ;) 14:42 domm oh, and too bad you're not using Postgres, because their pg_notify is a great way to implement easy job queues 14:42 ashimema yup 14:42 ashimema I totally wanted that 14:42 ashimema that's what Minion uses 14:42 oleonard "too bad you're not using Postgres" is what every dev new to Koha seems to say :| 14:42 ashimema postgres is lovely 14:42 ashimema but... 14:43 oleonard At least that's the polite version :D 14:43 ashimema whilst we pretend we want to support all SQL's (but only in reality support MySQL/MariaDB) we'll never utilise any of the core strength of Pg anyways 14:43 ashimema man.. git.koha-community.org is slow 14:44 ashimema ok.. github links will work instead 14:45 ashimema so.. for adding a background job.. I think it's as simple as adding a module here: https://github.com/Koha-Community/Koha/tree/master/Koha/BackgroundJob 14:45 ashimema https://github.com/Koha-Community/Koha/blob/master/misc/background_jobs_worker.pl#L31and referencing it in the hard coded list of available jobs here 14:45 Joubu yes 14:45 Joubu it's swapping right now 14:45 Joubu I've just noticed it few minutes ago 14:45 Joubu are you cloning the repo? 14:46 ashimema nope 14:46 ashimema I was just trying to use the UI to give the above links to our repo instead of in github 14:51 domm ashimema: ok, perfect, thanks 14:52 domm and koha-worker will figure out by itself it is using RabbitMQ or the DB? 14:54 ashimema yup 14:55 ashimema the code is simple there.. if it find a rabbitmq config and connection it'll use it.. if not it'll just poll the database for jobs 14:56 ashimema in both cases we are basically doing polling anyway as far as I can tell.. just one polls rabbitmq whilst the other polls mysql 14:56 ashimema maybe I'm wrong on the rabbitmq front.. it should be listening for notifications.. but I'm sure when I read the code it look like it was looping more like a poll 15:12 Joubu ashimema: kicked some bots and git server is feeling better now 15:12 ashimema ahh.. 15:12 ashimema do we need a robots.txt? 15:13 Joubu we have one, but we don't want to reject all of them 17:06 reiveune bye 18:22 tuxayo @later tell dcook__ do you have hints about what should be done to make some of your buildQuery() tests work in 19.11? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430#c92 18:22 huginn tuxayo: The operation succeeded. 18:22 huginn Bug 12430: major, P5 - low, ---, dcook, Pushed to oldoldstable , Relevance ranking should also be used without QueryWeightFields system preference 19:24 oleonard ashimema still around? 19:28 * oleonard will try later 19:38 tcohen earlier? 19:38 tcohen hehe 19:48 * cait waves 20:07 ashimema Hi 20:07 wahanui privet, ashimema 20:08 cait :) 21:13 tuxayo Does anyone know about the OPAC's "Browse search" feature and if it's normal that searching (by title) in sample data "All music" yields "All music guide to soul" but searching "guide" doesn't? 21:15 cait hm 21:15 cait i can't verify right now, but oculd it be doing a begins with search? 21:15 cait have you tried making it fuzzier? 21:16 caroline I think the brosw feature is supposed to be "starts with" no? 21:16 tuxayo cait: indeed it's a begins with search! 21:18 tuxayo Odd that one must know well the name to find. Even if it begin with "a", it matter 21:18 caroline that's what browsing is 21:19 caroline I usually use it to find things near what I'm searching for 21:19 tuxayo cait: even if it's "Really fuzzy", it's still a begin with search 21:20 cait ok 21:20 tuxayo caroline: ok no worries then 21:20 tuxayo thanks you two :) 21:20 tuxayo let's signoff 21:21 cait caroline++ :) 21:33 caroline tuxayo: when you do a point release, does it come with the latest po files? 21:34 tuxayo caroline: yes, exported from Pootle the day of the release. 21:34 cait as it should be tuxayo++ 21:34 caroline ok tahnks! 21:34 caroline good to know 21:34 tuxayo ^^ 21:35 caroline we have a client testing 20.05.05 and there are so many missing translations... I'm sure I was at 100% for 20.05 at one point 21:36 caroline [off]I'm scrambling because it's a more difficult client who gets offended by one english word... 21:45 cait in accounting we are missing quit e afew patches for fixing things 21:46 cait i have that on my list... and keep nagging ashimema 21:46 cait do you see issues in other areas too? 21:46 * cait is working on translating the manual ... 21:46 cait i might finish before I am 90 21:46 caroline LOL! 21:47 caroline I gave up on translating the manual... -_- 21:50 cait i will probably get grumpy as soon as you branch 21.05 and all the new stuff appears :) 21:59 tuxayo caroline: «I'm sure I was at 100% for 20.05 at one point» 21:59 tuxayo Maybe there is an issue :o 21:59 caroline No i think it's that things were added/modified in the point releases 22:01 tuxayo It's a surprise that it can cause so many missing translations. 22:03 caroline A lot of things were moved into messages-js.po 22:03 tuxayo Well, many thing get backported in the first six months 22:03 tuxayo ok 22:13 cait caroline: i think these were a lot of Owen's patches being backportet- I remember those too 22:13 caroline I think maybe contextualizations or .inc that were added or moved 22:14 caroline I mean they are really basic things like the "Suspend"/"resume" button for holds that aren't translated 22:14 caroline it's not like it's a new feature 22:15 caroline anyway, it normally wouldn't be a problem, but this client is... particular, and it just stresses me out for nothing 22:16 caroline [off]thankfully, my boss is acting as a human shield for me with this client -_- otherwise I would have burned out 22:30 * cait sends cookies 22:30 cait there should be an update again soon on pootle 22:34 dcook @later tell tuxayo yeah the tests just need to be updated for 19.11 to reflect the actual output. 22:34 huginn dcook: The operation succeeded. 22:36 tuxayo cait: what do you mean? 22:36 tuxayo dcook: thanks :) 22:37 dcook np 22:37 cait for bugfix releases - but maybe later than usual as they are scheduled for january? 22:37 tuxayo good, nothing scary 22:37 tuxayo cait: indeed, for the string freeze, let me check the new dates 22:38 tuxayo cait: caroline 24 december freeze, 5-6 january release 22:38 cait ah ok :) 22:38 cait got a bi tmore time then to get these patches rebased maybe... 22:39 caroline lol! I don't think I will be doing a lort of translating over the holidays 22:39 caroline oh well *shrugs* 22:40 tuxayo caroline: ugh, indeed that isn't great for translating the backported patches. ^^"