Time Nick Message 00:09 philor wahanui: no, everyone is staying home and staying safe 00:09 wahanui ...but everyone is headed to the hackfest in Marseille... 00:10 philor accept reality! 03:19 mtj hi dcook, ill apply my patchset after yours, re 26672 - ill upload it today 03:19 dcook mtj: Sounds good 06:07 * Oak waves 06:07 Oak magnuse 07:11 kohaputti ashimema, hmm: the "Configure items for purchase" text in English can't be right here https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/intranet-tmpl/prog/en/includes/pos-menu.inc ? 07:11 kohaputti ashimema, it links to settings for debit types 07:12 TimothyAlexis How can this be solved? 07:12 TimothyAlexis at translate.koha-community.org 07:12 TimothyAlexis There are {count} archived suggestions. 07:12 ashimema It makes sense to me kohaputti 07:13 TimothyAlexis Critical errors: Python brace placeholders 07:13 kohaputti TimothyAlexis, it is false positive 07:13 ashimema It used to say something different, but people requested to be changed to the current text 07:13 kohaputti TimothyAlexis, we have ignored the message since it is not python code 07:13 kohaputti ashimema, but items? I'm thinking the link would take me to some page to setup items that can be sold at the library... 07:14 ashimema You do indeed configure the items for sale from the debit types admin page.. they're just more debit types with the items for sale checkbox ticked 07:14 kohaputti oh, then it starts to make sense 07:14 ashimema That is the page 07:14 kohaputti I have not used this feature 07:14 ashimema Feel free to suggest alternative text 07:16 ashimema Mmm, suppose 'items' isn't hugely clear.. it's anything you can sell.. which could include services 07:16 kohaputti would be more intuitive to have a separate page for adding items for sale even if they are using the same db table as debit type codes 07:16 ashimema I'd find that really confusing personally 07:17 ashimema You often mix the types across POS and Manual Invoice 07:17 ashimema So having separate pages displaying the same list is more confusing 07:18 kohaputti ok, now there is just no way of knowing how to add items for sale if you don't read manual 07:18 ashimema This feature is like 5 years work with 4 big public libraries contributing to the specification ;) 07:19 ashimema You think it's that unintuitive? 07:19 ashimema Go to point of sale, click the link to configuring items for sale, click add, check box that clearly says to display it on the point of sale page 07:19 ashimema Seems fairly clear to me 07:20 ashimema Maybe I'm too close to it though to be honest 07:20 ashimema It's easy to know how when you wrote it.. so I'm deffo open to suggestions 07:21 ashimema There is an open bug to add more filters and things to the debit types management page though.. which I think would help 07:25 kohaputti ashimema, you are right it is a bit easier to figure out how to add the items if you come from the POS page, just that when you click the link I wonder how did I end up here, what am I gonna do with debit codes, I wanted to add sales items. 07:25 kohaputti also when you go add debit codes then one might wonder why does this thing ask me to sell a code... 07:25 kohaputti "Can be sold?" 07:26 ashimema Fair point, some clearer wording somewhere might help 07:26 ashimema That's the one 07:27 ashimema I'll have a little ponder, see if I can come up with some clearer wording.. 'Debit types' in general is a bit of a technical term 07:27 kohaputti less options would be my solution, no chance for wrong choices 07:27 kohaputti and to have less options my solution would be separate pages 07:27 ashimema 'Items, Services and Charges' 07:28 Joubu hi #koha 07:28 kohaputti ashimema, maybe list the items and services in another table below? 07:28 alex_a Bonjour 07:28 kohaputti hi :) 07:28 cait1 hm not sure, you will want to be able to sell the same item via pos and from the patron account 07:28 ashimema But they're a mixed list that often have multiple ticked sets 07:28 cait1 but still waking up :) 07:28 ashimema Our customers do 07:29 cait1 yeah, I think this will be common 07:29 ashimema Photocopying is an example.. they often want to allow someone to just used that service and pay straight away (POS).. but sometimes they will allow a regular patron to use credit on their account to pay for photocopies 07:30 ashimema Me too on the waking up front 07:30 TimothyAlexis kohaputti++ 07:30 ashimema Dog wants to drag me round the block in a moment too 07:30 TimothyAlexis kohaputti++ 07:30 TimothyAlexis ops 07:30 TimothyAlexis ashimema++ 07:31 TimothyAlexis oh well, thanks 07:31 ashimema Lol 07:32 Joubu How was going the git fetch this morning? 07:33 ashimema Huh 07:35 ashimema DNS SPOOFING DETECTED 07:35 ashimema did the git move happen 07:35 cait1 ashimema: yes 07:35 cait1 Joubu++ 07:36 cait1 can you all cross fingers for us today? we are having the user meeting 07:36 ashimema oh cool 07:36 ashimema fingers crossed 07:36 ashimema looking good Joubu 07:37 reiveune hello 08:29 ashimema remind me Joubu... 08:30 ashimema did our git-test passwords get migrated into the new git server or should I be setting up a new account again? 08:34 magnuse Joubu++ 08:34 * magnuse crosses fingers for cait 08:43 Joubu josef_moravec: around? 08:45 josef_moravec Joubu: 08:45 josef_moravec Joubu: yes 08:46 Joubu josef_moravec: ha, I just sent you an email! 08:48 josef_moravec Joubu: I created account on git server using openId 08:48 josef_moravec ;) 08:48 Joubu ho right, haven't seen it was there! 09:43 cait 207 participants in the user meeting right now :) 09:43 cait so ... keep crossing fingers, it appears to work 09:44 magnuse cait++ 09:44 cait if someone doesn't mind hte German, all info is here: https://wiki.bsz-bw.de/display/KOHA/Aktuelles 09:49 magnuse "never mind the german", famous song by the sex pistols ;-) 09:53 cait really? didn't know 09:53 cait any good? 09:55 magnuse of course! :-) 09:56 cait 213, keeping us busy :) 10:02 koha-jenkins Project Koha_Master_D10 build #419: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_Master_D10/419/ 10:45 tcohen morning 10:46 tcohen cait++ 11:06 cait 213 was the most for now, we held onto about 200 for all of the morning session, now break and continuing at 2pm :) 11:32 koha-jenkins Project Koha_Master_D11 build #156: FAILURE in 2 min 22 sec: https://jenkins.koha-community.org/job/Koha_Master_D11/156/ 11:34 koha-jenkins Project Koha_20.05_D11 build #74: STILL FAILING in 3 min 55 sec: https://jenkins.koha-community.org/job/Koha_20.05_D11/74/ 11:55 tuxayo Hi #koha :) 12:27 koha-jenkins Yippee, build fixed! 12:27 wahanui Congratulations! 12:27 koha-jenkins Project Koha_Master_D11 build #157: FIXED in 50 min: https://jenkins.koha-community.org/job/Koha_Master_D11/157/ 12:47 mtj hi #koha 12:47 mtj hi tcohen: do you have any preferences about adding koha-core/full to the KTD repo? 12:48 tcohen that's a hard call. I would love to use koha-core and have all the extra services run on their containers. 12:48 tcohen but 12:49 tcohen we need to test things more similar to what production looks like 12:49 tcohen so I'd go with koha-full 12:50 mtj there are a few different ways to achieve it 12:59 mtj tcohen: would you like to have a go at it? or me? ^ 12:59 tcohen if you can do it now, better 12:59 tcohen I'm trying to look after majors and blockers right now 13:02 mtj ok, do you prefer koha-full on the master branch still? 13:03 mtj ..and using the dist/buster dir - or a new dist/buster-full dir, perhaps? 13:13 koha-jenkins Project Koha_20.05_D11 build #75: ABORTED in 1 hr 34 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/75/ 13:17 koha-jenkins Project Koha_20.05_D11 build #76: STILL FAILING in 4 min 38 sec: https://jenkins.koha-community.org/job/Koha_20.05_D11/76/ 13:26 koha-jenkins Project Koha_20.05_D11 build #77: STILL FAILING in 4 min 16 sec: https://jenkins.koha-community.org/job/Koha_20.05_D11/77/ 13:30 koha-jenkins Project Koha_20.05_D11 build #78: STILL FAILING in 2 min 29 sec: https://jenkins.koha-community.org/job/Koha_20.05_D11/78/ 13:33 TimothyAlexis What's the difference between GetOptions('option:s') and GetOptions('option=s') ? 13:36 Joubu TimothyAlexis: https://metacpan.org/pod/Getopt::Long#=-type-[-desttype-]-[-repeat-] 13:36 Joubu it's optional with ':' 13:37 koha-jenkins Project Koha_20.05_D10 build #129: FAILURE in 2 min 28 sec: https://jenkins.koha-community.org/job/Koha_20.05_D10/129/ 13:39 TimothyAlexis Joubu++ 13:46 TimothyAlexis I'm looking at enhancing delete_patrons.pl to accept multiple categories. 13:46 TimothyAlexis It uses the function GetBorrowersToExpunge from Members.pm 13:46 TimothyAlexis Which is also used by tools/cleanborrowers.pl... 13:46 wahanui okay, TimothyAlexis. 13:48 TimothyAlexis If I change GetBorrowersToExpunge to accept an array and the SQL to use IN instead of =, it should be fine, am I thinking about it correct? 13:48 TimothyAlexis It should then accept 1 or more category codes, so that cleanborrowers.pl can stay the same... 13:51 TimothyAlexis bug 27050 13:51 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27050 enhancement, P5 - low, ---, timothy_alexis.vass, ASSIGNED , Allow multiple category_codes in delete_patrons.pl 13:52 Joubu TimothyAlexis: it's the "Options with multiple values" part 13:53 TimothyAlexis I understand how to get the options, but then it's used in a function which is also used by another script. 13:54 TimothyAlexis If the other script only adds a scalar as the parameter and this one adds an array with a list, that will still work right? 13:54 TimothyAlexis I want to make sure the changes I make still keeps other stuff working. 13:55 Joubu no, you needs to adjust the other script, to make it pass an arrayref as well 14:00 TimothyAlexis So, cleanborrowers.pl is under Component: Tool and delete_borrowers.pl is under Component: Command-line Utilities. 14:01 TimothyAlexis And Members.pm is under some other Component I suppose... 14:02 TimothyAlexis How should I manage this at bugs.koha-community.org ? 14:02 Joubu use "command-line utilities" 14:02 Joubu the main change is for the delete_patrons.pl 14:03 TimothyAlexis OK, thank you for the guidance. 14:13 ashimema bug 27079 ready for test and qa 14:13 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 major, P5 - low, ---, martin.renvoize, Needs Signoff , UpdateFine adds refunds for fines paid off before return 14:20 koha-jenkins Project Koha_20.05_D11 build #79: NOW UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/79/ 14:22 TimothyAlexis If I change the <select id="borrower_categorycode"...> to accept multiple options, will this be correct? 14:22 TimothyAlexis my @borrower_categorycodes = $params->{'borrower_categorycodes'} || q{}; 14:23 TimothyAlexis I'd change it to <select id="borrower_categorycodes" name="borrower_categorycodes" multiple> 14:25 koha-jenkins Yippee, build fixed! 14:25 wahanui Congratulations! 14:25 koha-jenkins Project Koha_20.05_D10 build #130: FIXED in 46 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/130/ 14:25 tuxayo hi tcohen :) I was about to test the follow up of bug 26282, I shall wait right? 14:25 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 major, P5 - low, ---, kyle, ASSIGNED , Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold 14:25 tcohen please do 14:26 tcohen I'm just working on unit tests as a QA follow-up 14:26 tcohen mark it SO when you're done 14:26 tcohen and, thanks :-D 14:27 tuxayo tcohen: ok great :D 14:42 tuxayo tcohen: "no reason given" should also trigger a notification right? (if checkbox ticked) 14:43 tcohen that's not how the code works 14:43 koha-jenkins Project Koha_20.05_D9_My8 build #136: ABORTED in 1 min 39 sec: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/136/ 14:43 tcohen I think that'd be an extra enhancement 14:44 Joubu maybe the checkbox label should be adjusted t 14:44 Joubu then 14:52 tcohen tuxayo I agree it should send it 14:53 tcohen I'll adjust the tests 14:54 Joubu no it should not 14:54 Joubu that's how the feature was designed 14:55 Joubu the label however should be more exact (unless we disable the checkbox unless an option is selected) 15:01 cait1 tcohen: Joubu: Bernardo tells me he fixed a problem with translations - for German that's 1300 new strings 15:01 cait1 well words 15:01 cait1 but maybe something for the list? 15:01 cait1 it's doable in a day if people want to 15:02 tcohen great 15:02 caroline +1 15:03 Joubu cait1: I am going to send an email 15:04 cait1 thank you 15:05 khall has something happened to git.koha-community.org? 15:06 cait1 heh 15:06 cait1 it moved :) 15:06 * khall hasn't been paying attention 15:06 cait1 Joubu: we should switch the logo on the front page for something with better quality, but otherwise it loks really nice first glance 15:06 khall the new site looks great! 15:07 cait1 i also spotted the statswith some url manipulation 15:07 Joubu khall: git remote set-url origin https://git.koha-community.org/Koha-community/Koha.git 15:07 Joubu if you have issue on git pull 15:07 khall thanks Joubu ! 15:07 Joubu cait1: the stats should be at the same place than before 15:09 Joubu cait1: which logo would fit better? 15:11 Joubu This is the one from the header of k-c.org - https://koha-community.org/files/2013/09/cropped-kohabanner3.jpg 15:14 cait1 i think the ones on the wiki are a bit better sec 15:15 cait1 the green png one would maybe look nice https://wiki.koha-community.org/wiki/The_Koha_Logo_:_Origins_and_Explanation 15:15 Joubu but background is grey 15:16 Joubu isn't it? 15:18 huginn News from kohagit: Bug 26672: Add additional koha-core and koha-full files to ./debian <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=425cb6ec25210a7832ca0de39e2404daae1c8bc2> 15:18 huginn News from kohagit: Bug 27082: uncertainprice.pl does not handle pagination <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5bc36cd672ad7d4abf839bed2d48da43f09415e9> 15:18 huginn News from kohagit: Bug 26819: (QA follow-up) Fix branchtransfers.tt <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b341dc0732e151b67daf2d20a80efa8d1c3b2297> 15:18 huginn News from kohagit: Bug 26819: (QA follow-up) authorized_value should be authorised_value <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3abd32ff9a90112e6cd1008c5b9c02b1da40ba9b> 15:18 huginn News from kohagit: Bug 26518: (QA follow-up) Expect warnings, don't supress them <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a8b89fe66a3e03cc951737a3dfcd235b81c982a7> 15:18 huginn News from kohagit: Bug 27070: Add cross_fields type to our searches <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=03f15d13c5bb931c03aa1487a3887bdaa034b06f> 15:18 huginn News from kohagit: Bug 25942: Fix batch report operations for cardnumbers and biblionumbers <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=443c004bc64543b1755bf0579a68ef32aa36cee5> 15:18 huginn News from kohagit: Bug 27026: (bug 24159 follow-up) Add a tooltip to explain the values of "Days mode" <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=92720f9b5e37a84aa4b35dd07f32e8a42453757e> 15:18 huginn News from kohagit: Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7ec7884834489c834a31aab23a281bc3646c599a> 15:18 huginn News from kohagit: Bug 26672: Add koha-core and koha-full definitions to debian/control files <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b11be998c7e07ddbefe9b1889f1ecbbf74a29a50> 15:18 huginn News from kohagit: Bug 26518: Move BiblioAutoLink within the transaction <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9038cdd9a45c06266b18167900fd428b0b1395ad> 15:18 huginn News from kohagit: Bug 26518: Hide expected DBI warnings <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1519050205d0f4411ca01e312732e5861da4ac3d> 15:18 huginn News from kohagit: Bug 26518: Raise exception if the insert failed <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b0c39296c5c557bfcb00a762036bb269efd04a46> 15:18 huginn News from kohagit: Bug 26518: Use Koha::Biblio[item] in AddBiblio <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a1e9453f1dcd5cc477ccd7fbecadb2a36176a4be> 15:22 cait1 Joubu: they are, but we used to have links on top of the git page 15:23 cait1 now you can only find them if you know the URL 15:23 cait1 Joubu: the koha repo pretends to be a mirror still - Note: This is a synced mirror of the official Koha repo. 15:23 cait1 https://git.koha-community.org/Koha-community/Koha 15:25 koha-jenkins Yippee, build fixed! 15:25 wahanui Congratulations! 15:25 koha-jenkins Project Koha_20.05_D11 build #80: FIXED in 40 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/80/ 15:25 cait1 bbl - bye all! 15:28 Joubu ha, better, I was going to later tell cait1,2,3 15:28 Joubu yes we definitely need to adjust the home page, we could discuss it and update it when we are ready 15:29 Joubu the "note" thing is coming from the .md file. We assumed it was *only* used by github and gitlab. Now that it's displayed on git.k-c.org I don't know what we can do 15:29 tcohen Joubu about bug 26282 15:29 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 major, P5 - low, ---, kyle, Needs Signoff , Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold 15:29 Joubu we can remove it, but it will get removed from github and gitlab as well 15:30 Joubu however there is a warning in the description of the repo on github I think 15:32 Joubu bug 27092 15:32 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27092 trivial, P5 - low, ---, jonathan.druart, Needs Signoff , Remove note about "synced mirror" from the README.md 15:33 koha-jenkins Yippee, build fixed! 15:33 wahanui Congratulations! 15:33 koha-jenkins Project Koha_20.05_D9_My8 build #137: FIXED in 49 min: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/137/ 15:38 huginn News from kohagit: Bug 27092: Remove note about "synced repo" from README.md <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7d6a5315007c6e1d5c85f57dcbd9e4b5faa01e27> 15:38 huginn News from kohagit: Bug 26672: Remove unrequired default-mysql-* references <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=802b843ac295f14b7be22bf0117ac7c9ee13f67f> 15:39 cait i think removing is ok for now 15:39 cait and maybe we need to list the different ones if it's used ina lot of places 15:39 cait please note that the repos on gitlab and github... or so 15:39 cait i am gone again, was just finishing up something :) 16:09 koha-jenkins Project Koha_Master_D11 build #158: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D11/158/ 16:15 koha-jenkins Project Koha_Master_D10 build #420: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_Master_D10/420/ 16:23 reiveune bye 16:56 koha-jenkins Project Koha_Master_D10 build #421: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_Master_D10/421/ 16:57 koha-jenkins Project Koha_Master_D11 build #159: SUCCESS in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D11/159/ 18:47 caroline I'm sorry to ask this again, I'm a bit lost with the yml vs sql for translations 18:47 caroline is there a wiki page that explains what we should do to translate things that are sql only? 18:50 caroline should I remove the installer/data/mysql/fr-CA directory completely? 18:54 cait maybe you could take a look at the patch Joubu did for de-DE 18:54 caroline ah! 18:54 cait it's quite recent 18:54 caroline I thought you weren't there 18:54 cait I am about to go to sleep 18:54 caroline I was waiting for your meeting to end to ask you lol! 18:54 cait oh! 18:54 caroline I'll look for the patch and try to figure it out 18:54 cait Joubu wrote it, i only tested 18:54 cait buti think it's not hard 18:55 cait the po files should already be on pootle i think 18:57 cait good night all