Time  Nick          Message
01:01 koha-jenkins  Project Koha_19.11_U18 build #248: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/248/
01:03 koha-jenkins  Project Koha_19.11_D8 build #284: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/284/
01:05 koha-jenkins  Project Koha_19.11_U16 build #9: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_19.11_U16/9/
01:08 koha-jenkins  Project Koha_19.11_D9 build #255: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/255/
01:34 koha-jenkins  Project Koha_19.11_U20 build #79: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_19.11_U20/79/
01:49 koha-jenkins  Project Koha_19.11_D10 build #83: SUCCESS in 45 min: https://jenkins.koha-community.org/job/Koha_19.11_D10/83/
05:03 TimothyAlexis Is there something available which makes this possible?
05:03 TimothyAlexis As a librarian (and maybe patron) I want to create lists from my searches so I can email them to me or someone else.
06:19 simon_        hi everyone
06:36 TimothyAlexis When we check out an item to a patron, we want to set damaged = 0 for that item in the database, where would we do this?
06:36 reiveune      hello
06:36 TimothyAlexis I am looking at circulation.pl
06:38 fridolin      hi there
06:38 wahanui       niihau, fridolin
06:38 fridolin      idem wahanui
06:38 TimothyAlexis Should I look in Circulation.pm instead?
06:47 TimothyAlexis I suppose this is what we need to happen at checkout: if(item.damaged > 0) { my $sth = $dbh-prepare("UPDATE items SET damaged = 0 WHERE itemnumber = ?");   $sth->execute($itemnumber); }
06:48 TimothyAlexis or something like that... Where, is my question. :D
06:59 TimothyAlexis sub AddIssue ? :)
06:59 alex_a        Bonjour
07:08 magnuse       TimothyAlexis: i think if you do it in a .pm rather than a .pl you increase the chances of doing the right thing for other tools than the web gui, like SIP2 for example
07:09 magnuse       "sub AddIssue" sounds reasonable
07:10 TimothyAlexis Actually, it should be done at check in rather than check out.
07:25 TimothyAlexis magnuse++
08:07 simon_        i have one cpu busy for 10sec or more when i search for something simple like "a" in our 1.5mio records, the culprit is a zebrasrv process. any suggestions on how to improve on the performance? is this normal?
08:14 Joubu         Hi simon_, what is the value of use_zebra_facets in your config?
08:14 Joubu         and the systemp preference maxRecordsForFacets
08:14 Joubu         see also bug13665
08:14 Joubu         see also bug 13665
08:14 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 normal, P5 - low, ---, gmcharlt, NEW , Retrieve facets from zebra is slow
08:20 simon_        maxRecordsForFacets = 20
08:22 simon_        use_zebra_facets is already 0
08:22 simon_        i am currently re-indexing
08:22 simon_        hm, but actually i did restart before
08:22 simon_        so the 0 should be active
08:24 simon_        is this a configuration for the opac or the intranet or both?
08:24 simon_        we do not use the opac
08:24 simon_        in the intranet search i definitely have facets displayed on the left
08:25 koha-jenkins  Project Koha_Master_U20 build #114: STILL UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_U20/114/
08:31 TimothyAlexis Does anyone know what this does?
08:31 TimothyAlexis $item->damaged(0)->store;
08:32 TimothyAlexis I'm trying to figure out how to actually set damaged to 0 in the items table. I thought this would do it but it seems to be something else.
08:32 Joubu         simon_: it's for all searches (so both opac and intranet)
08:32 Joubu         TimothyAlexis: it's the equivalent of "update items set damaged=0 where itemnumber=?"
08:33 TimothyAlexis Joubu that's what I thought
08:33 Joubu         TimothyAlexis: it also calls Koha::Item->store, which does lot of other things
08:33 simon_        Joubu: then i should not see any facets on the left? or are those just based on my 20 first records?
08:34 TimothyAlexis I tried adding this at the end of sub AddReturn, before the return ( $doreturn...);
08:34 Joubu         simon_: you should see facets but they won't be calculated correctly. They are built from the 20 first records.
08:34 simon_        ok
08:34 TimothyAlexis if ($doreturn and $item->damaged > 0) { $item->damaged(0)->store; }
08:35 TimothyAlexis But it doesn't seem to happen when checking an item in...
08:37 simon_        it is ~24seconds no matter what maxRecordsForFacets is, i just set it to 0
08:39 TimothyAlexis staff required restart
08:39 Joubu         TimothyAlexis: try to write a test for it, then attach you patch somewhere and I will have a look if you  want
08:39 TimothyAlexis So it did work.
08:40 TimothyAlexis Should I add this to master? Could be that this only applies at our library. Whenever we check in a book that is damaged, that means it has been repaired.
08:40 Joubu         simon_: are you attached to Zebra? You could try Elasticsearch
08:41 simon_        no i am actually looking forward to elastic search because zebra is kind of arcane :D
08:41 simon_        hm
08:41 simon_        ok
08:41 simon_        somebody mentioned stopwords slowing down the search in bug 13665
08:41 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 normal, P5 - low, ---, gmcharlt, NEW , Retrieve facets from zebra is slow
08:42 simon_        not using stopwords but would also degrade the search result, right?
08:43 Joubu         If you have a search that returns result in 30 secondes, you cannot degrade more  :D
08:44 Joubu         I would try the different combinaisons to see which one it the culprit
09:13 magnuse       @quote 123
09:13 huginn        magnuse: downloading the Perl source
09:13 magnuse       @quote get 123
09:13 huginn        magnuse: Quote #123: "rangi: #thingsihavelearnt if there is a mad scheme a library somewhere will be doing it ... except madder" (added by wizzyrea at 09:20 PM, March 30, 2011)
09:13 wahanui       i already had it that way, huginn.
09:13 magnuse       TimothyAlexis: i think you would have to "hide" it behind a syspref, or maybe a per-itemtype setting
09:32 simon_        i am trying out elastic search (currently indexing), does maxRecordsForFacets also apply to elastic search? from my experience elastic search will return facets for each search result automatically
09:33 Joubu         simon_: yes, it's a zebra-only syspref
09:36 simon_        Joubu: cool, thank you :)
09:53 * cait        waves
10:10 cait          testing bug 19353 - where should i bet put the oai-conf file?
10:10 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 enhancement, P5 - low, ---, josef.moravec, Signed Off , Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server
10:14 kohaputti     cait, doesn't really matter maybe /etc/koha/oai.conf then you need to change the syspref to reflect that
10:14 cait          hm yeah i made all the things explode
10:15 cait          trying to figure out now what happened, thx kohaputti
10:16 kohaputti     cait, in  OAI-PMH:ConfFile  put the /etc/koha/oai.conf
10:16 cait          yes i idd
10:16 cait          Can't locate object method "nodeType" via package "<?xml version="1.0" encoding="UTF-8"?>
10:16 cait          I am trying to repurpose the sample file from the manual
10:17 cait          https://koha-community.org/manual/20.05/en/html/webservices.html#sample-oai-conf-file-label
10:17 kohaputti     xml? Hmm, this is no xml file
10:17 cait          it happens on trying to view a record
10:17 cait          i have commented out vs and the xsl_file, only keeping the marcmxl one
10:20 kohaputti     cait, what line does that error happen on?
10:21 cait          it's the config file i think, let me just try to remove that first
10:21 cait          yeah something with the config file
10:21 kohaputti     well I think internal server error is not good even if config is wrong
10:22 cait          proably a lot we coudl catch there in errors
10:22 cait          but righ tnow i'd just be happy to be able to turn on items
10:22 kohaputti     did you do the change
10:22 kohaputti     -      xsl_file: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/Del995.xsl
10:22 kohaputti     +      xsl_file: koha-tmpl/intranet-tmpl/prog/en/xslt/Del995.xsl
10:23 kohaputti     that was in one of the attachments?
10:23 kohaputti     if so, make sure the patch there is correct
10:23 cait          not testing the change yet
10:24 cait          just trying to set up the conf file correctly first
10:24 kohaputti     ok
10:24 cait          but i have trouble viewing the records in the grapical OAI gui :(
10:24 cait          http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml#KOHA-OAI-TEST3
10:24 cait          when i click on metadata nothing happns
10:24 cait          i thought that was a bug we fixed alredy
10:24 kohaputti     try chmod o+r /etc/koha/oai.conf
10:25 kohaputti     aah, I think that is normal
10:25 kohaputti     :D
10:25 kohaputti     try with curl and it might work
10:25 cait          i have heard of curl but far from knowin ghow to use it meh
10:26 kohaputti     just curl "http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml#KOHA-OAI-TEST3"
10:26 kohaputti     and it prints out the contents of the website
10:26 cait          is that a known bug? why do we not fix it? :)
10:26 tcohen        morning
10:26 cait          if we offer graphical it should be working *grumpy*
10:27 cait          kohaputti: not found hm
10:27 kohaputti     404 not found?
10:28 kohaputti     cait, it could be configuration issue why it doesn't work, but I have not bothered to investigate
10:28 cait          bug 25793
10:28 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25793 normal, P5 - low, ---, oleonard, Pushed to oldstable , OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade
10:28 cait          says it was pushed, but that's the one i was hoping ficed the issue
10:28 tcohen        amoyano worked on a local fix for that
10:28 tcohen        because it worked on master
10:30 cait          hm?
10:32 kohaputti     cait, if you remove xsl_file from the oai.conf does it work then?
10:32 kohaputti     I mean remove the whole line
10:32 cait          i removed it from the pref
10:33 cait          currently tring to just get things work
10:33 kohaputti     cait, I think you get it working with your custom oai.conf that doesn't have xsl_file defined
10:33 cait          i commnted those out first
10:33 kohaputti     the default file could have it defined and this patch in this bug makes use of the file
10:34 cait          i am working my way up now... starting with no conf file an dtrying to get to my marc records
10:36 cait          there is another thing sstrange... we suddenly seem to be including item information by default
10:36 cait          but we didn't use to
10:46 cait          kohaputti: if you are still around... could you confirm the items are always output in the marcxml?
10:46 cait          independent of ocnf?
10:47 kohaputti     just a sec
10:50 kohaputti     hmm, there is this fancy gui nowadays indeed, if I click on Metadata nothing happens, is it supposed to show the record?
10:51 oleonard      Hi #koha
10:51 cait          yes
10:51 cait          that's the bug i filed, but look at the page source
10:51 kohaputti     thanks, checking now
10:52 cait          thank you :)
10:53 kohaputti     what was the item marc field again? I think I don't see them with koha master
10:53 cait          952
10:53 kohaputti     cait, ok, so it is not showing up for me
10:53 cait          as it should...
10:54 kohaputti     have you done restart_all ?
10:54 cait          i did restart_all after rmeoving the conf file
10:54 cait          yep
10:54 cait          multiple times. i will do it again
10:54 kohaputti     and do you have the patch from the bug report?
10:54 kohaputti     could it be the one adding the items?
10:54 cait          kohaputti: thx for listening, this helps quite a bit - rechecking everything the items are gone, which is good
10:55 cait          that means my conf file kinda worked in between
10:55 cait          testing on master at the moment
10:56 cait          ok, with the test file, the items are back :)
10:56 cait          so i can now move on to testing the xsl part
11:03 cait          kohaputti: now on the patched branch, I've been tryingto use xsl_file: /home/vagrnt/kohaclone/koha-tmpl/intranet-tmpl/prog/en/xslt/Del952.xsl
11:03 cait          but back on the initial error
11:03 cait          Can't locate object method "nodeType" via package "<?xml version="1.0" encoding="UTF-8"?>
11:03 kohaputti     and does that file exists?
11:03 kohaputti     I see possible typo in the path
11:03 cait          yeah i double checked
11:03 kohaputti     "vagrnt"
11:03 cait          ugh
11:03 cait          you are a life saver today
11:04 kohaputti     :)
11:04 cait          not saying you are not also on other days :)
11:04 cait          i can report... this appears to work onw
11:05 kohaputti     yay!
11:09 cait          woring on the qa list by time stamp.... which makes me realize all the old ones are my own :(
11:28 cait          oleonard: around?
11:28 oleonard      Yes
11:28 cait          i am looking at bug 26578 - thx for the fix!
11:28 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26578 normal, P5 - low, ---, nick, Needs Signoff , OverDrive results can return false positives when searches contain CCL syntax
11:29 cait          oh
11:29 cait          bug 26576
11:29 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 normal, P5 - low, ---, oleonard, Signed Off , Subfield descriptions on authority detail view are cut off
11:29 cait          i wonder abut the comment David left
11:29 cait          about the blue making it look like a link
11:29 cait          it's actually a different blue than our link blue... but wonder if we coudl come up with another color variation
11:30 oleonard      I meant to comment on the bug and forgot... I picked that color because it's used in the basic MARC editor for subfield descriptions
11:31 oleonard      But I could change it in both places if you think it should be different
11:32 cait          hm that's a good argument
11:32 cait          i could pass this one and we rethink colors separately?
11:35 oleonard      That's fine with me, but it's up to you. If you'd rather I address it now I can.
11:36 cait          oleonard: i passed it now
11:36 cait          but feel free to think colors :)
11:38 ashimema[m]   bug 24381 is back to ready for QA/Testing/Feedback
11:38 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 major, P5 - low, ---, martin.renvoize, Signed Off , ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees
11:38 * oleonard    needs to get back to Bug 22399...
11:38 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 enhancement, P5 - low, ---, oleonard, Failed QA , Improve responsive behavior of the basic marc editor
11:39 cait          kohaputti++ thank you
11:39 cait          oleonard++
11:39 cait          ashimema++ :)
11:39 oleonard      davidnind++
11:41 cait          true
11:41 cait          davidnind++
11:42 ashimema[m]   Joubu, it's bug 24381 above where I'm not seeing [% today | $KohaDate %] working as expected (I just get a blank output)
11:51 cait          ashimema[m]: account_credit_types.sql and account_debit_types.sql shold be made translatable right?
11:51 ashimema[m]   I asked that recently
11:52 cait          yep
11:52 ashimema[m]   and we decided no, they don
11:52 cait          i am on that bug now
11:52 ashimema[m]   't
11:52 ashimema[m]   they're translated in templates
11:52 cait          hm
11:52 kohaputti     ashimema[m], btw, the build status doesn't really show up still nicely because the "new developers" section just takes too much space
11:52 cait          shouldwe not remove descriptions frm then then?
11:52 ashimema[m]   the descriptions in the .sql don't do anything
11:52 cait          from them then
11:52 cait          i'd treat them differently
11:53 cait          but removing the description might serve as a reminder to devs to add to the includes oto
11:53 kohaputti     ashimema[m], only an issue with hd displays
11:53 ashimema[m]   kohaputti, I'm waiting for a merge from rangi
11:53 ashimema[m]   he has the keys to the dashboard
11:53 kohaputti     okay :)
11:53 ashimema[m]   https://gitlab.com/koha-community/koha-dashboard/-/merge_requests
11:54 ashimema[m]   there are three waiting for a quick QA from Joubu and then a merge from rangi when he returns
11:54 ashimema[m]   brb.. lunch
11:54 ashimema[m]   I think it's the 'Add U16' one that improves gets rid of 'New Developers' to give us more space
11:54 cait          enjoy
12:03 cait          ashimema[m]: it looks like you broke reset_all ;) C4::Installer::load_sql returned the following errors while attempting to load /home/vagrant/misc4dev/data/sql/marc21/1812/after_22155/items.sql:
12:03 cait          DBD::mysql::st execute failed: Unknown column 'paidfor' in 'field list' at /usr/share/perl5/DBIx/RunSQL.pm line 273.
12:03 cait          ... which leaves me with a bit of an issue hm
12:03 ashimema[m]   huh
12:04 ashimema[m]   what bug?
12:04 wahanui       bug is, like, that perl code is not activ since its not in PER5LIB
12:04 cait          no bug, the reset_all on kohadevbox
12:04 cait          misc4dev maybe?
12:04 cait          just wondering how to get back my sample database now
12:05 ashimema[m]   sounds like a missing schema change
12:05 ashimema[m]   but I would expect Jenkins to be failing too if that were the case
12:05 cait          i think the sql file has the column
12:05 * ashimema[m] looks at Jenkins
12:06 ashimema[m]   what sql file?
12:06 cait          the sample data needs to be fixed
12:06 cait          the one listed above :)
12:06 ashimema[m]   oh.. misc4dev
12:06 wahanui       misc4dev is the key peice.. it's what populates the database with a test database
12:06 cait          but i have to figure out a fix now as i need my db back
12:06 ashimema[m]   ah.. it all works in koha-testing-docker
12:06 cait          of course
12:06 ashimema[m]   mybe you need to pull the latest misc4dev somehow then
12:06 cait          good idea
12:07 ashimema[m]   it's been a while since I used kohadevbox to be honest :(
12:08 ashimema[m]   https://gitlab.com/koha-community/koha-misc4dev/-/commits/master/
12:08 ashimema[m]   yup
12:08 ashimema[m]   Joubu fixed it a week ago in misc4dev
12:08 cait          missing a lot of the obvious today thx
12:09 cait          still broken on kohadevbox, but i got a fix for tha tone in think
12:09 cait          Error reading file /etc/koha/sites/kohadev/koha-conf.xml.
12:09 cait          Try running this again as the koha instance user (or use the koha-shell command in debian)
12:09 cait          Compilation failed in require at /home/vagrant/kohaclone/Koha/AuthUtils.pm line 28.
12:09 cait          BEGIN failed--compilation aborted at /home/vagrant/kohaclone/Koha/AuthUtils.pm line 28.
12:09 cait          Compilation failed in require at /home/vagrant/misc4dev/setup_sip.pl line 23.
12:09 cait          BEGIN failed--compilation aborted at /home/vagrant/misc4dev/setup_sip.pl line 23.
12:16 cait          ashimema++
12:16 cait          you all be happy soon when my vacation is over and i get more quiet :)
12:17 * oleonard    likes a loud cait
12:17 cait          because she passes your patches missing the obvious? ;)
12:33 ashimema[m]   lol
12:38 oleonard      As a perfectionist I'm mortified at the mere suggestion ;)
12:46 cait          :)
12:47 cait          btw - great drawings this year again
12:47 oleonard      Thanks!
13:41 ashimema[m]   @later tell rangi any chance you could deploy the latest dashboard code.. I added a fix at Joubu's request and also a couple of little enhancements.. Joubu has QA'd and merged them so we just need the deploy step now :)
13:41 huginn        ashimema[m]: The operation succeeded.
13:47 oleonard      If I want to access Koha API from an external application what authentication options do I have?
13:47 oleonard      I know about basic authentication because that's what I use in testing, but I'm not sure what the alternatives are
13:48 kohaputti     oauth2 too
13:48 oleonard      I assume the "basic" means that it is not idea/most secure
13:48 oleonard      ideal/most secure
13:50 kohaputti     koha normal login in browser (not sure if the same as basic auth), basic auth, and oauth2 are all the options I know for accessing the REST API.
13:50 kohaputti     And from those probably oauth2 would be the way to go but it is still listed as experimental so not super sure.
13:51 oleonard      Thanks kohaputti
13:55 cait          i believe there are 3
13:55 cait          it's on the wiki somewhere
13:55 cait          cookie?
13:56 cait          ah yes, cookie: https://wiki.koha-community.org/wiki/REST_api_RFCs
13:58 oleonard      I assume "cookie" means you're already authenticated in the staff interface and making requests from the same domain.
13:58 oleonard      "koha normal login in browser" as kohaputti said.
14:00 cait          i think you are right
14:14 tcohen        oleonard the Oauth2 flow we implement is fairly similar to Basic Auth
14:15 tcohen        "client credentials"
14:34 * caroline    waves
14:34 caroline      what's up everyone?
14:34 lukeG1        Hi caroline!
14:49 tcohen        hi caroline lukeG1
15:16 reiveune      bye
19:30 kathryn       hi everyone :)
19:30 cait          hi kathryn
19:30 caroline      hi kathryn :)
19:30 cait          hi caroline
19:31 kathryn       I hope things are good with you both
19:34 caroline      same to you
19:47 rangi         @later tell ashimema[m] done
19:47 huginn        rangi: The operation succeeded.
19:48 ashimema[m]   Thanks rangi :)
20:04 tcohen        hola rangi aleisha hayleymapley_ alexbuckley
20:05 hayleymapley_ hola tcohen!
20:06 alexbuckley   hola tcohen :)
20:06 tcohen        getting ready?
20:06 tcohen        :-D
20:07 aleisha       hello
20:07 rangi         getting there :)
20:07 kathryn       hola tcohen :) closer every day!
20:07 tcohen        hy kathryn
20:08 tcohen        still digesting the fact that I got my tickets back
20:08 tcohen        BUT
20:08 tcohen        excited!
20:08 tcohen        you will need to take lots of pictures and videos
20:08 tcohen        :-D
20:09 kathryn       yep we'll try and share everything as soon as possible!
20:09 * tcohen      sends best wishes for this last few days
20:09 tcohen        the rest of it will be superb
20:13 hayleymapley_ estoy triste que no te puedo encontrar, pero espero que tengamos la oportunidad en el futuro!
20:14 tcohen        I'm sure we will!!
20:14 tcohen        you can bet I will get my NZ tickets once there's a vaccine for this
20:14 tcohen        you cannot escape hahaha
20:14 hayleymapley_ :) hehe good!