Time Nick Message 00:44 koha-jenkins Project Koha_Master_U2010 build #19: ABORTED in 8 hr 39 min: https://jenkins.koha-community.org/job/Koha_Master_U2010/19/ 01:29 koha-jenkins Yippee, build fixed! 01:29 wahanui Congratulations! 01:29 koha-jenkins Project Koha_Master_D9 build #1446: FIXED in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1446/ 01:32 koha-jenkins Yippee, build fixed! 01:32 wahanui Congratulations! 01:32 koha-jenkins Project Koha_Master_D11 build #102: FIXED in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D11/102/ 01:36 koha-jenkins Project Koha_Master_U2010 build #20: SUCCESS in 50 min: https://jenkins.koha-community.org/job/Koha_Master_U2010/20/ 05:09 koha-jenkins Project Koha_Master_U16 build #77: STILL UNSTABLE in 41 min: https://jenkins.koha-community.org/job/Koha_Master_U16/77/ 05:48 reiveune hello 05:48 wahanui bidet, reiveune 06:51 alex_a Salut 07:01 TimothyAlexis I have a simple question. 07:02 TimothyAlexis In opac-reportproblem.pl there is a recipient 'admin', where is this e-mail set? 07:04 TimothyAlexis to_address => C4::Context->preference('KohaAdminEmailAddress') 07:04 TimothyAlexis Thank you :D 07:08 fridolin i 07:26 ashimema[m] TimothyAlexis 07:26 wahanui hmmm... TimothyAlexis is checking 20.05.x for WCAG compliance. 07:27 ashimema[m] it'll try 'inbound_email_address' 07:27 ashimema[m] which has a defined fallback path 07:28 ashimema[m] one moment 07:28 ashimema[m] Soo.. 07:28 ashimema[m] it'll look at the borrower whose adding the report 07:28 ashimema[m] it'll then grab their associated library branch 07:29 ashimema[m] it will then look for these addresses in order using the first one that's defined 07:29 ashimema[m] branchreplyto, branchemail, ReplytoDefault and finally KohaAdminEmailAddress 07:30 ashimema[m] weirdly.. aleisha put in a secondary and superflous fallback to KohaAdminEmailAddress on top 07:31 ashimema[m] I should remove that now I see it. 07:31 ashimema[m] hope that helps TimothyAlexis 08:45 Null404 hello there, where I can find support of KOHA ? 08:50 Null404 of course nobody here as always 08:52 Joubu What kind of support of Koha? 08:54 ashimema[m] You didn't give people much time to respond.. I was in a work call myself Null404 08:54 ashimema[m] What kind of support are you looking for.. there are plenty of support companies around the world 08:54 Null404 I use "Set items to quarantine status upon return" solution from ByWaters solutions and some random books goes to quarantine 08:55 Null404 and how to fix that? 08:56 ashimema[m] I'm afraid that's not an area I'm hugely familiar with. 09:00 Joubu Null404: I guess you are refering to https://bywatersolutions.com/education/set-items-to-quarantine-status-upon-return 09:00 Joubu which method did you setup? 09:01 Null404 first one 09:01 wahanui first one is right 09:02 Null404 I mean -5 status 09:02 Null404 I'm on 18.11.16 09:02 Null404 *version 18.11.16 09:03 Joubu "Do you see the Batch Modify button at the top of the itemnumber column in the report? Use that to send all of these items to Item Batch Modification, where you can clear the Quarantine status. Then the items are ready to go!" 09:03 Joubu It seems that the solution explains the whole process 09:04 Null404 Yes I use batch modify, but it don't delete quarantine status from all books 09:06 Joubu I don't know if 18.11 has the "batch modify" button in the report area 09:07 Null404 Yes, it have 09:09 Joubu So please detail. If you run the report and click the "batch modify" button, why aren't you able to clear the quarantine status? 09:09 Null404 but sometimes koha set books that were not borrowed from last 2 years 09:09 Null404 and not returned 09:10 Joubu what do you mean by "set books"? Do you mean the query returns items that are not in quarantine? 09:12 Null404 I mean sometime in random books koha set -5 status "not for loan - quarantine" 09:12 Null404 and that random books weren't borowed or returned from last 2 - 3 years 09:13 Null404 but have returned to quarantine status 09:19 Joubu so maybe you should clean your data first and reset the notforloan status for those items 09:20 Joubu we cannot know why your items have such status 09:28 Null404 I don't know why too 10:03 Joubu developers around? I really would like some fast feedback on bug 26639. 10:03 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26639 critical, P5 - low, ---, jonathan.druart, Needs Signoff , Turn auto_savepoint ON 10:14 Joubu hi koha-jenkins, are you feeling better? 10:36 * oleonard waves 10:45 rhamby waves back 10:59 ashimema[m] local use checkins... 10:59 ashimema[m] should a transfer completion count.. I think not 10:59 ashimema[m] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25377#c11 10:59 huginn Bug 25377: minor, P4, ---, martin.renvoize, NEW , Transfer does not change current item location 11:00 tcohen morning 11:07 huginn News from kohagit: Bug 26529: DBRev 20.06.00.048 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f8093f18d4c04fc75af43add253c973c7bb700f8> 11:07 huginn News from kohagit: Bug 23420: DBRev 20.06.00.047 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ab6494fc3de5fc4f325941baf1c65f67634b1c1b> 11:07 huginn News from kohagit: Bug 23852: (QA follow-up) Fix remaining call to biblio-default-view <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a9f2fc1eb90bc622daf902b83b7b3c55597710ef> 11:07 huginn News from kohagit: Bug 23695: (QA follow-up) Revert 'Orginating library' option <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9ddb312749c34fc4d1c19d48570725978c813bbd> 11:07 huginn News from kohagit: Bug 26529: (follow-up) Remove other instance of blanking holdallowed from script <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=00d2b1aae634f7093c614274bc8fe0b7f2163595> 11:07 huginn News from kohagit: Bug 26137: Remove warnings from viewlog.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8b541714a177fc141c77967c8fc528c5c5453139> 11:07 huginn News from kohagit: Bug 23420: (QA follow-up) Remove more AllowPurchaseSuggestionBranchChoice code <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fc022ab894d863dc660ca57b2d45543a3b4445ec> 11:07 huginn News from kohagit: Bug 26529: Remove existing blank rules <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=da218a0d6ffad028792a3f1833679149478dd443> 11:07 huginn News from kohagit: Bug 26529: Unit tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c361e1f4dd0049c036167e9a998a8ec6123fcf3d> 11:07 huginn News from kohagit: Bug 26529: Define some rules as not able to be blank <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=039adae9aa4fa3be76e16633cb64a45ca7d7ed46> 11:07 huginn News from kohagit: Bug 23420: (QA follow-up) Remove AllowPurchaseSuggestionBranchChoice syspref <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=12253d53821b6764e2084db85eb0b56a72a3694c> 11:07 huginn News from kohagit: Bug 23420: Add OPACSuggestionUnwantedFields system pref <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b7d31ef16dd25e025a72397b8eaf2a218f21e2f7> 11:56 koha-jenkins Project Koha_Master_D9 build #1447: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1447/ 12:02 koha-jenkins Project Koha_Master_D9_MDB_Latest build #405: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/405/ 12:04 koha-jenkins Project Koha_Master_U20 build #110: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_Master_U20/110/ 12:09 koha-jenkins Project Koha_Master_U18 build #910: SUCCESS in 59 min: https://jenkins.koha-community.org/job/Koha_Master_U18/910/ 12:10 tcohen ah! 12:37 koha-jenkins Project Koha_Master_D10 build #366: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_Master_D10/366/ 12:49 koha-jenkins Project Koha_Master_D10_Deps build #90: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/90/ 12:53 koha-jenkins Project Koha_Master_U2010 build #21: SUCCESS in 49 min: https://jenkins.koha-community.org/job/Koha_Master_U2010/21/ 13:01 ashimema[m] hi tochen :) 13:04 koha-jenkins Project Koha_Master_U16 build #78: STILL UNSTABLE in 55 min: https://jenkins.koha-community.org/job/Koha_Master_U16/78/ 13:12 TimothyAlexis I'm wondering if a string can be translated differently in a specific context. "Cancel" is a word which we would want translated differently in different contexts. 13:16 ashimema[m] it should be yes 13:16 ashimema[m] did you see my replies this morning TimothyAlexis 13:16 ashimema[m] wasn't sure if I missed you 13:18 TimothyAlexis I read it now, thank you :) 13:18 TimothyAlexis ashimema++ 13:18 koha-jenkins Project Koha_Master_D11 build #103: UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_Master_D11/103/ 13:18 ashimema[m] brill 13:18 ashimema[m] as for translation, each instance of Cancel should get it's own translation.. 13:19 ashimema[m] whether the translators have enough context to get it right is another question.. 13:19 ashimema[m] there are ways to add context to the translatable strings now however 13:19 ashimema[m] jajm has worked diligently to add such functionality :) 13:21 TimothyAlexis In this case it's one specific button. 13:21 ashimema[m] have you looked into pootle at all? 13:21 ashimema[m] https://translate.koha-community.org/ 13:21 wahanui https://translate.koha-community.org/ is down for some time? 13:22 ashimema[m] you could sign yourself up and see if you can find the string to either fix it.. or mark it to be fixed 13:22 ashimema[m] :) 13:25 oleonard TimothyAlexis if you find cases where strings need added context please file bugs for it 13:27 koha-jenkins Project Koha_Master_D9_My8 build #428: FAILURE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/428/ 13:31 TimothyAlexis This happens at 29 places 13:31 TimothyAlexis msgid "Cancel" 13:31 TimothyAlexis msgstr "Avbryt" 13:32 ashimema[m] indeed 13:32 ashimema[m] hence adding a way to add context.. but that's a fairly new feature so allot of places don't use it yet 13:32 TimothyAlexis My colleage wants to be very specific about one of these and change that one to msgstr "Ta bort" which specifically means "Remove" 13:33 Joubu Which ones? Maybe it needs to be fixed in master as well? 13:33 ashimema[m] remind me where the documentation on how to add context to translation strings is? 13:33 ashimema[m] indeed 13:33 TimothyAlexis holds-table.inc:170 and :190 13:34 Joubu ashimema[m]: you have example in the TT plugin I18N 13:34 Joubu example*s* even 13:34 ashimema[m] ah yes.. 13:34 ashimema[m] thanks 13:34 caroline this is what I used I think https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_context,_and_more_RFC 13:35 Joubu there is also an include file 13:35 ashimema[m] brill.. that's the one I was thinking of caroline.. something I can more easily link to from here :) 13:35 Joubu heh yes, the wiki is way better, thanks caroline! 13:36 ashimema[m] I was going to suggest it as a bug for TimothyAlexis to perhaps have a go at fixing :) 13:36 caroline I'm looking for an example that I did 13:36 caroline I know I did a couple for French 13:36 ashimema[m] :) 13:37 caroline bug 23983 13:37 Joubu and https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110988 13:37 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 enhancement, P5 - low, ---, caroline.cyr-la-rose, RESOLVED FIXED, Contextualization of "Order" (verb) vs "Order" (noun) 13:38 Joubu ^ which is a quite complex one 13:38 caroline ok sorry, I'll try another one 13:38 Joubu and yours, caroline, has the context 13:38 ashimema[m] hehe 13:38 ashimema[m] carolines is good 13:39 ashimema[m] nice clear one 13:39 caroline bug 24648 is a bit shorter 13:39 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 enhancement, P5 - low, ---, caroline.cyr-la-rose, RESOLVED FIXED, Contextualization of past tense "Created" 13:42 caroline I am quite happy with the work jajm did for this! :D jajm++ 13:43 ashimema[m] yeah, he did a great job 13:43 ashimema[m] we just need more devs to adopt using it now 13:44 caroline I think it really depends on the needs of each language team 13:44 ashimema[m] indeed 13:44 caroline those two in particular were bugging me to no end in French, but I don't think and english-speaking dev would have seen the need for it 13:45 caroline and that's ok 13:45 ashimema[m] indeed.. 13:45 ashimema[m] but QA should attempt to pick up on such words 13:45 ashimema[m] I try to.. though being an ignorant englishman :(, I do miss them 13:45 TimothyAlexis So if we add msgctxt "hold", then we could use [% tp('Cancel', 'hold') %] ? 13:45 ashimema[m] Katrin is good.. she pulls me up on translation things all the time.. which is really good 13:46 caroline yes I know she is very sensitive to that (not sure if sensitive is the right word...) 13:46 caroline and she sees it in advance which is good 13:46 ashimema[m] TimothyAlexis.. yes 13:46 ashimema[m] that's the perfect example 13:47 ashimema[m] find the locations of those strings (in english) in the templates.. replace them with [% tp('Cancel', 'hold') %] 13:47 ashimema[m] then they'll appear with 'hold' context in the po files and thus in pootle 13:47 caroline you also have to add something at the top of the file 13:47 caroline the INCLUDE bit 13:48 ashimema[m] and so one can identify the string for a better translation 13:48 ashimema[m] ah yes.. good call caroline 13:48 * ashimema[m] loves seeing people add new things.. 13:48 * ashimema[m] cheers TimothyAlexis on 13:50 ashimema[m] I would even go so far as perhaps [% tp('Cancel', 'cancel hold button') %] to give it full context 13:50 TimothyAlexis INCLUDE bit ? 13:51 caroline and I think you also have to add an "html" somewhere too? 13:51 TimothyAlexis [% tp('Cancel', 'cancel hold button') | html %] to filter it... 13:51 caroline yes that's it 13:51 ashimema[m] perfect 13:52 caroline not sure what it does, but you have to add it :D 13:52 caroline sorry not INCLUDE but PROCESS 13:52 caroline [% PROCESS 'i18n.inc' %] 13:53 TimothyAlexis It will render < as < and such to prevent html injection. 13:53 Joubu it prevents XSS vulnerability. If one translate "Cancel" with "<script>alert('booh!');</script>", the 'script' won't be interpreted by the browser, but correctly HTML escaped 13:53 ashimema[m] :) 13:53 ashimema[m] nice work everyone 13:54 caroline wow cool, I didn't know you could do that 13:54 caroline (I don't have the mind of a criminal, so it's hard for me to think of things like that hehe) 13:54 ashimema[m] that's why we're so strict about those filters these days caroline 13:54 ashimema[m] there's all sorts of fun places you can do funky things like that.. having filters around everything means we can prevent them 13:55 caroline good to know. And now that I know why, it will be easier for me to remember :) 13:55 TimothyAlexis Here are some other filters. http://www.template-toolkit.org/docs/manual/Filters.html 13:56 caroline should you add filters in notices too? 13:56 caroline That's where I most commonly use TT 13:56 ashimema[m] theoretically yes 13:57 ashimema[m] if you happen to have a notice that contains a variable that someone can input then that variable could be open to abuse 13:57 * ashimema[m] tries to think of an example 13:57 Joubu firstname, addresse, etc. 13:57 Joubu everything that is editable by OPAC's users 13:57 ashimema[m] yup 13:57 ashimema[m] it also partially depends on whether you've enabled html email 13:58 ashimema[m] if you're emailing plain text then it shouldn't get interpreted anyway 13:58 ashimema[m] but you better safe than sorry 14:01 TimothyAlexis Try voting for this candidate: EXEC sp_MSforeachtable @command1 = "DROP TABLE ?" 14:02 TimothyAlexis Someone said someone tried to do that in some election... 14:02 TimothyAlexis Or something like it. 14:03 TimothyAlexis It didn't work though... But that person, unlike you caroline, did have such a mind... 14:10 TimothyAlexis Well, ashimema do you think we should create a patch for this? 14:11 ashimema[m] I reckon so.. 14:11 ashimema[m] I'm sure caroline would be happy to SO and I could QA so you could have a patch in master in a matter of hours ;) 14:11 caroline +1 14:11 ashimema[m] and it's a useful thing to add for all.. it may not just be your language that want's to clarify that statement :) 14:12 TimothyAlexis Will I need to use Pootle? Or can I edit the sv-SE-opac-bootstrap.po file? 14:20 caroline for tests, you can modify your .po file 14:20 caroline in the real thing, you'll have to translate using pootle 14:28 TimothyAlexis So, what should I do then? 14:29 TimothyAlexis I can add [% PROCESS 'i18n.inc' %] and replace Cancel button text with [% tp('Cancel', 'cancel hold button') | html %] in holds-table.inc 14:29 TimothyAlexis But how do I add the translation to the patch? :/ 14:31 kohaputti ashimema[m], still around? I rebased the bug 12556 14:31 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 enhancement, P5 - low, ---, joonas.kylmala, Signed Off , SelfCheck machine starts the hold instantly with an email sent out 14:32 ashimema[m] awesome 14:32 ashimema[m] will take a look in a few mins 14:35 kohaputti ashimema[m], quite a big patch set unfortunately, the Koha circulation code would require even more refactoring to make it cleaner but maybe some other time, there is few patches already doing that in the bug report :) 14:35 caroline TimothyAlexis: did you see the bugs I put before, I think there was the whole process in the test plan 14:36 ashimema[m] indeed 14:36 ashimema[m] you've tidied a bit.. and that's nice to see 14:36 ashimema[m] we can swing back around later to continue tidying 14:37 TimothyAlexis caroline ? 14:37 wahanui caroline is off the grid 14:37 caroline TimothyAlexis: sorry, I was doing something else 14:37 caroline wahanui forget caroline 14:37 wahanui caroline: I forgot caroline 14:39 TimothyAlexis Where and how do I put the translation is what I need to know at this point. The rest I know how to do. :D 14:39 caroline you'd have to run translate create or translate update 14:40 caroline then you open messages.po 14:40 caroline and put in your translation 14:40 caroline then translate install 14:40 TimothyAlexis So, I'm at translate.koha-community.org 14:40 caroline no you don't need to go there yet 14:41 caroline that is only when your patch will be in the master 14:41 TimothyAlexis OK, then I only need to change the .po file for testing? 14:42 caroline yes for testing, you only need to change messages.po 14:43 TimothyAlexis The only file I should attach to the patch is the changed holds-table.inc, is that correct? 14:44 caroline yes 14:52 koha-jenkins Project Koha_Master_D9_My8 build #429: NOW UNSTABLE in 1 hr 4 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/429/ 15:00 ashimema[m] anyone able to remind me what this points to 15:00 ashimema[m] DBIC result _type isn't of the _type Item 15:01 kohaputti that and result set doesn't check if the object exists 15:01 kohaputti there should be return unless $object 15:01 kohaputti that an* 15:02 kohaputti is this from some patch set or issue in Koha master? 15:03 kohaputti ashimema[m], for example see https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110474&action=diff and https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110475&action=diff 15:03 ashimema[m] aha 15:03 ashimema[m] I remember now 15:03 ashimema[m] thanks 15:05 ashimema[m] its was from me trying to use the item relatin from old_checkouts 15:05 ashimema[m] it is indeed a buggy relation accessor 15:06 TimothyAlexis Ok I've attached the patch to bug 26647 15:06 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 trivial, P5 - low, ---, timothy_alexis.vass, ASSIGNED , The Cancel button in holds table should be translated in context for Swedish. 15:06 tcohen ashimema[m] is it because it lacks a FK? 15:08 ashimema[m] nope 15:08 ashimema[m] it was indeed just as kohaputti said 15:08 ashimema[m] it was a lack of "return unless $rs" 15:08 ashimema[m] old checkouts are perfectly aloud to contain an itemnumber for an item that no longer exists 15:08 kohaputti ashimema[m], but usually these errors tell about some other issue too 15:09 ashimema[m] nice one TimothyAlexis 15:09 kohaputti ashimema[m], although in the patches linked above just doing this check was enough 15:09 ashimema[m] in this case I think that was it :) 15:09 ashimema[m] especially given it's from old_checkouts not current ones 15:10 kohaputti right, the item could have been deleted a long time ago 15:10 ashimema[m] indeed 15:10 TimothyAlexis Now it's time for the week-end 15:10 TimothyAlexis Adios 15:10 ashimema[m] enjoy :) 15:10 tcohen adios 15:11 TimothyAlexis caroline++ 15:11 kohaputti TimothyAlexis, have a nice weekend! 15:11 TimothyAlexis Likewise :) 15:18 ashimema[m] @later tell caroline you will need bug 26648 for the magic incantation to calculate 'savings to date' for the issueslip 15:18 huginn ashimema[m]: The operation succeeded. 15:42 ashimema[m] @caroline see that bug for my final iteration 15:42 huginn ashimema[m]: downloading the Perl source 17:06 oleonard_ Anyone around who is familiar with how Dockerfile works? 17:08 reiveune bye 17:28 tcohen oleonard_ shoot 17:32 oleonard_ Hi tcohen, I think I got it actually. I'm building a setup for a PHP project I'm working on and cribbing off ktd for advice :) 17:32 tcohen excellent 17:32 wahanui darn tootin' it is. 17:32 oleonard_ I didn't have the paths correct for the COPY command because I misunderstood how it sees the context 17:33 tcohen the idea is that each line must leave as less cruft as possible, you will notice those && apt clean && rm -rf ... 18:13 koha-jenkins Project Koha_20.05_U20 build #83: FAILURE in 7.3 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/83/ 18:13 tcohen qa_team: there's an interesting design discussion starting with bug 26555 and following on bug 26651 and bug 26652 18:13 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 enhancement, P5 - low, ---, tomascohen, Passed QA , Add a way for Koha::Object(s) to carry execution information 18:13 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26651 enhancement, P5 - low, ---, tomascohen, In Discussion , Add Koha::Object->reset_messages 18:13 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26652 enhancement, P5 - low, ---, koha-bugs, In Discussion , Add a way to mark messages as 'seen' in Koha::Object 18:13 tcohen feedback is welcome 18:14 tcohen any questions/suggestions can be made there, email or here :-D 18:18 koha-jenkins Project Koha_20.05_U20 build #84: STILL FAILING in 0.84 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/84/ 18:23 koha-jenkins Project Koha_20.05_U20 build #85: STILL FAILING in 0.74 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/85/ 18:28 koha-jenkins Project Koha_20.05_U20 build #86: STILL FAILING in 0.67 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/86/ 18:33 koha-jenkins Project Koha_20.05_U20 build #87: STILL FAILING in 0.65 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/87/ 18:38 koha-jenkins Project Koha_20.05_U20 build #88: STILL FAILING in 0.8 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/88/ 18:43 koha-jenkins Project Koha_20.05_U20 build #89: STILL FAILING in 0.68 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/89/ 18:48 koha-jenkins Project Koha_20.05_U20 build #90: STILL FAILING in 0.79 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/90/ 18:53 koha-jenkins Project Koha_20.05_U20 build #91: STILL FAILING in 0.68 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/91/ 18:53 koha-jenkins Project Koha_20.05_D9 build #96: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/96/ 18:58 koha-jenkins Project Koha_20.05_U20 build #92: STILL FAILING in 0.94 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/92/ 19:00 koha-jenkins Project Koha_20.05_D11 build #45: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/45/ 19:02 koha-jenkins Project Koha_20.05_D9_My8 build #87: SUCCESS in 50 min: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/87/ 19:03 koha-jenkins Project Koha_20.05_U20 build #93: STILL FAILING in 0.93 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/93/ 19:08 koha-jenkins Project Koha_20.05_U20 build #94: STILL FAILING in 0.79 sec: https://jenkins.koha-community.org/job/Koha_20.05_U20/94/ 19:08 koha-jenkins Project Koha_20.05_U16 build #80: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/80/ 19:16 cait tcohen: feedback to? 19:17 tcohen cait: 26555, 26651 and 26652. 19:17 tcohen I simplified 26555 19:18 tcohen but there's a controversy on wether it is a good idea 19:18 tcohen sao I want opinions 19:33 koha-jenkins Project Koha_20.05_U18 build #84: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/84/ 19:44 * ashimema[m] has been in hand.. comments will have to wait from me.. hehe 19:44 ashimema[m] You've been doing a great job in that area though tcohen. 19:44 * ashimema[m] sends cookies 19:44 tcohen no worries, I'm moving forward 19:45 tcohen and just left those in discussion 19:45 tcohen for when others join the conversation 19:47 ashimema[m] Good plan 19:47 koha-jenkins Project Koha_20.05_D10 build #93: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/93/ 20:04 koha-jenkins Yippee, build fixed! 20:04 wahanui Congratulations! 20:04 koha-jenkins Project Koha_20.05_U20 build #95: FIXED in 50 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/95/ 20:13 cait hm why would a file in the patch set not show up in a git diff --stat 20:13 cait trying to see about removing an accidentall y committed file on bug 26503 20:13 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 enhancement, P5 - low, ---, katrin.fischer, Failed QA , Allow to limit on standing orders in acquisition advanced search 20:13 cait i can see it in the patches - .xsl 20:13 cait but it does not appear when i do a git diff --stat HEAD~2.. 20:15 cait i usually check the patches so i think that't why it slipped through 20:15 cait oh i know 20:15 cait it was pushed now 20:16 cait so ther is no diff 20:17 caroline ashimema[m]: It took me all day but the notice is on the wiki https://wiki.koha-community.org/wiki/Notices_and_Slips_Library#Add_total_value_of_items_on_issue_slip 20:18 * caroline is not productive at all today... woke up at 3am thinking about work and never got back to sleep -_- 20:23 ashimema[m] Nice one caroline 20:25 marie-luce caroline++ 20:30 caroline I think a lot of librarian will be happy with this :D 20:30 caroline librarians 20:32 tcohen cait I really want to move that table into using the API that I polished on bug 20212 20:32 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Slowness in Receiving in Acquisitions 20:32 tcohen good thing is: I add the standing parameter for filtering as well, so... trivial :-D 20:33 cait which is that table? 20:33 tcohen histsearch.pl 20:33 cait so what do you suggest? 20:33 tcohen pushing your patches of course 20:34 tcohen and once 20212 gets some attention 20:34 tcohen I re-do it with using the API 20:34 tcohen keeping the behaviour you introduce 20:34 tcohen :-D 20:38 cait i think i like push my patches and keep the behavoiur not sure i follow the rest 20:39 cait been a long week 20:39 tcohen bug 20212 makes a very similar table, be rendered using the API to fetch the data 20:39 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Slowness in Receiving in Acquisitions 20:39 tcohen instead of the code in C4::Acquisitions 20:40 tcohen it does server-side pagination, which is important on big datasets 20:40 tcohen and the API routes that were done for that bug, can trivially be used to make this other UI table be rendered the same way 20:40 tcohen probably stealing most of the JavaScript 20:41 tcohen nothing you should worry about 20:41 tcohen and you should take a look at 20212 20:41 tcohen :-P 21:03 cait it does sound interesting for sure