Time  Nick          Message
21:35 ashimema[m]   Interesting
19:40 oleonard      (and counting only unresolved claims and enrolled clubs)
19:39 oleonard      Here's the tabs re-done using jajm's plural-handling template syntax: https://zivotdesign.com/p/view.php?p=15980387474009
19:36 cait          hm not that i know of
19:22 oleonard      Is there no other way to access resolved claims other than the tab in circulation?
18:27 khall_        hi cait !
18:23 cait          hi khall :)
18:19 cait          koha anonymous?
18:19 * oleonard    too
18:19 cait          yeah, but I have a serious problem
18:19 oleonard      You're here cait :D
18:18 cait          8pm on a friday..
18:12 oleonard-away jajm around?
15:37 ashimema[m]   patch attached
15:22 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26263 normal, P5 - low, ---, martin.renvoize, ASSIGNED , Style error on OPAC search results when item-level_itypes is set to bibliographic
15:22 ashimema[m]   could make bug 26263 a bit interesting to fix
15:18 oleonard      No
15:17 ashimema[m]   do we have a fixed width for itemtype images?
15:14 reiveune      bye
15:01 ashimema[m]   thanks
15:01 oleonard      Seems presentable.
15:00 ashimema[m]   the modal content could do with some beautification.. I've not thought about that much yet.. I'm sure I could make it look nicer
14:59 ashimema[m]   not sure where else we might print modals.. but it felt like a nice generic approach we might like to take elsewhere too
14:59 ashimema[m]   i.e. using media queries and hiding all but the modal content dynamically on the call the print
14:59 ashimema[m]   Yeah.. I think I need to tweak the css slightly.. but was generally interested in your opinion on the general approach
14:58 oleonard      But the print view seems to be too small.
14:57 oleonard      Okay, I got it. I think that solution makes sense.
14:51 ashimema[m]   then pay it off
14:51 ashimema[m]   or add a manual debit to a patron
14:51 ashimema[m]   find a patron with fines owed
14:50 ashimema[m]   but it's simplest to do it via the point of sale screen (as you then have the links available for the next step)
14:50 oleonard      How do I do it via a patron?
14:50 ashimema[m]   either there or via a patron (but making sure to select a cash register)
14:49 oleonard      Am I performing the transactions on the Point of sale page?
14:49 ashimema[m]   yup
14:48 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Add a cashup summary view
14:48 oleonard      I'm not sure I understand how to test Bug 26172
14:48 oleonard      ashimema[m] still around?
14:14 * ashimema[m] looks forward to a week off however :)
14:13 * ashimema[m] is flagging.. got that friday afternoon feeling
14:11 oleonard      ...but is hopefully an improvement in other ways.
14:11 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Update the Select2 JS lib
14:11 oleonard      Joubu, cait: I submitted a followup to Bug 25727 that doesn't address the width issue :/
14:03 ashimema[m]   :)
13:59 oleonard      I'm still around ashimema[m]
13:59 caroline      Yeah, I don't want to spam yall either :)
13:58 cait          i think most people get emails from bugzilla on changes... so they can still step in
13:58 caroline      but at the same time, at the point where I come in, this should already have been through the hands of the rmaints
13:57 caroline      that's why I said I didn't want to step on any toes... I know bug vs enh determined whether it is backported in older versions
13:54 Joubu         she considered it an enhancement
13:53 Joubu         "enhancement, not backporting to 19.11.x"
13:53 Joubu         as enh
13:53 caroline      ok, I will then
13:53 Joubu         about 25555, aleisha marked it as bug
13:53 cait          caroline++
13:52 Joubu         yes please caroline!
13:51 * ashimema[m] would say yes.. but Joubu is not the master of all :)
13:51 caroline      should I clean them up as I see them? I don't want to step on any toes...
13:51 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25789 enhancement, P5 - low, ---, emmi.takkinen, Pushed to oldstable , New expiration date on placing a hold in staff interface can be set to a date in the past
13:51 caroline      also bug 25789 seems like a bug fix
13:51 ashimema[m]   always nice to clean them up
13:50 caroline      I'm asking all those questions because I'm going through the release notes for the docs and a lot of things that are in the "enhancement" section seem like bugs
13:50 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25555 enhancement, P5 - low, ---, lucas, Pushed to stable , Holds Queue sorts patrons by firstname
13:50 caroline      but like bug 25555 to me looks like a bug, but it's classified like an enhancement
13:49 Joubu         new ft, enh are enhancements
13:49 Joubu         blocker, critical, major, normal, minor, trivial are bugs
13:49 Joubu         caroline: "Importance"
13:47 huginn        ashimema[m]: The operation succeeded.
13:47 ashimema[m]   @later tell oleonard I'd be interested in your thoughts on my 'Add print option' follow-up on bug 26172.. it feels like a nice generic approach to printing modals..
13:46 caroline      how is it determined what bz is a bug vs an enhancement?
13:46 vfernandes    if daysMode is set to "calendar" the checkout period can be longer than "no renewals before"
13:46 ashimema[m]   still around oleonard?
13:45 vfernandes    "no renewals before" works in some cases when daysMode is set to not use the calendar
13:43 caroline      vfernandes: maybe in the circulation rulesl no renewals before
13:43 vfernandes    what is the easiest way to block renewals on the same day of the checkout?
13:41 vfernandes    hi #koha
13:31 * magnuse     waves and wanders off into the weekend
13:30 * cait        waves
13:21 tcohen        np! thanks for your help yesterday
13:21 tcohen        hi! got the car for a service so slowly getting back to work
13:21 oleonard      Sorry I missed your messages last night. Forgot to /away myself.
13:20 oleonard      Hi tcohen
13:20 tcohen        morning
12:52 koha-jenkins  Project Koha_Master_D11 build #70: STILL UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D11/70/
12:29 koha-jenkins  Project Koha_Master_D9_My8 build #394: STILL UNSTABLE in 1 hr 1 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/394/
12:24 Joubu         so I am expecting Koha to show the current biblio record when it should not
12:23 Joubu         yes, it "works". The change is subtle: my guess is that the service now return the normalized isbn
12:15 ashimema[m]   me too
12:15 oleonard      It looks to me like it is
12:09 oleonard      Joubu have you tested whether the service is working in Koha?
12:08 oleonard      Joubu I don't imagine the code on our side has been touched in years
12:07 koha-jenkins  Project Koha_Master_D11 build #69: STILL UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D11/69/
12:04 koha-jenkins  Project Koha_Master_U16 build #49: STILL UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_Master_U16/49/
12:02 Joubu         I think there was a change in their answer
12:02 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 normal, P5 - low, ---, jonathan.druart, Needs Signoff , XISBN.t is failing since today
12:02 Joubu         bug 26270
12:02 Joubu         Anybody familiar with ThingISBN?
12:01 koha-jenkins  Project Koha_Master_U18 build #875: NOW UNSTABLE in 1 hr 25 min: https://jenkins.koha-community.org/job/Koha_Master_U18/875/
11:52 koha-jenkins  Project Koha_Master_D10_Deps build #57: STILL UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/57/
11:45 ashimema[m]   True
11:36 oleonard      ashimema[m]: Always busy, but not always busy in #koha ;)
11:28 koha-jenkins  Project Koha_Master_D10 build #331: STILL UNSTABLE in 53 min: https://jenkins.koha-community.org/job/Koha_Master_D10/331/
11:24 ashimema[m]   Always 😀
11:20 koha-jenkins  Project Koha_Master_U20 build #76: STILL UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_Master_U20/76/
11:20 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #370: STILL UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/370/
11:15 koha-jenkins  Project Koha_Master_D9 build #1413: STILL UNSTABLE in 41 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1413/
11:00 oleonard      Busy day so far, eh?
10:47 ashimema[m]   done
10:44 Joubu         please
10:44 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26157 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Redirect expected DBI warnings
10:44 Joubu         easy SO on bug 26157
10:33 huginn        News from kohagit: Bug 18501: (follow-up) Remove duplicate test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=00ec4ed478b116f10fa5ea95d565460f439a8320>
10:33 huginn        News from kohagit: Bug 19036: (follow-up) Test credits should be credits <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8d64d08c41d2bb8c52757936b265748fa1123085>
10:33 huginn        News from kohagit: Bug 18501: (follow-up) Do not rely on userenv->{branchcode} <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=80bef548750c3ae0ba9dee70f4d5833ef7cdd133>
10:33 huginn        News from kohagit: Bug 18501: (follow-up) Add fallback to ItemHomeBranch <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7fe66325f0aa54aa3084941f8ed79af304b4acc3>
10:33 huginn        News from kohagit: Bug 18501: (follow-up) Test undefined userenv behaviour <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3a8866cae6df162e14ec521f1ccb9ce72cd25c12>
10:33 huginn        News from kohagit: Bug 26031: Add diagnostic to search_utf8.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9365d61b3c82ed0a63b18f7f450d0226a8a71f2c>
10:33 huginn        News from kohagit: Bug 25811: Add debug info to authentication.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e2a79ede5a4f4c81a5672ee485c40c19151fc47b>
10:33 huginn        News from kohagit: Bug 18501: (follow-up) Use t::lib::Dates::compare in tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=88ed05d07e02f0e7569b35a121b9cde06f6712ca>
10:33 huginn        News from kohagit: Bug 18501: Don't use paidfor for DB fields not mapped with a MARC field <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=139e0a86ae415a47c645ed66bc491cfb33c353ec>
10:24 Joubu         that's why, and that's wrong
10:24 Joubu         but decided to go with only one
10:24 Joubu         I wanted to dump all the pref values
10:24 Joubu         right
10:24 kidclamp      250 # --------------------------------- TEST INTRANET SEARCH
10:23 kidclamp      ? the line before your changes says 'intra_text'
10:23 Joubu         I am missing lang!
10:22 Joubu         it's opac everywhere
10:22 kidclamp      joubu:no
10:22 kidclamp      you are dumping the OPAC file for the intra test? and get_best_xslt_filename is missign lang param
10:21 Joubu         I am about to push it
10:21 Joubu         kidclamp: ok with 26031?
10:21 ashimema[m]   and get all those 18501 fixes pushed I reckon
10:21 ashimema[m]   lets just make sure we follow 18501 with this one fairly quick ;)
10:20 ashimema[m]   I'm writting the new bug to kill it with fire now..
10:19 Joubu         it's still in master
10:19 Joubu         nevermind
10:18 Joubu         should not we remove the superflous line before 18501? :-/
10:18 Joubu         ashimema[m]: wondering...
10:16 ashimema[m]   also saves me writing a test for the trigger functionality.
10:16 * ashimema[m] likes that we're cleaning stuff up
10:16 ashimema[m]   anywho.. I'll create a bug
10:16 ashimema[m]   lol
10:16 ashimema[m]   reading my original bug I think I did intend on removing the field entirely but forgot as it went through SO and QA so quick once it started moving
10:15 ashimema[m]   easily done
10:15 ashimema[m]   hehe
10:15 Joubu         that's why you should not let me rebase my big stuffs too long!
10:14 Joubu         pfiou
10:14 ashimema[m]   kill with fire
10:14 ashimema[m]   well sleuthed
10:14 ashimema[m]   deffo
10:13 ashimema[m]   haha..
10:13 Joubu         so we are pulling it from C4::Circ since the beginning, but it shouldn't have been there!
10:13 Joubu         just before you did "-    ModItem( { paidfor => '' }, undef, $itemnumber, { log_action => 0 } );
10:12 Joubu         I am pretty sure this is a wrong conflict resolution
10:12 Joubu         +    $accountline->item->paidfor('')->store({ log_action => 0 });
10:12 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 enhancement, P5 - low, ---, jonathan.druart, Pushed to stable , Move C4::Items CRUD subroutines to Koha::Item
10:12 Joubu         ashimema[m]: commit bbb504c86f5ca "Bug 23463: Replace ModItem with Koha::Item->store"
10:11 Joubu         ho ffff!
10:11 Joubu         a second time you mean? :)
10:11 ashimema[m]   but as a new bug ;P
10:10 ashimema[m]   lets kill it
10:10 Joubu         I am at lost :D
10:10 ashimema[m]   building it for display from the data.. rather than setting it in teh db
10:10 Joubu         lol
10:10 ashimema[m]   well..
10:10 ashimema[m]   indeed
10:09 Joubu         ashimema[m]: commit 0f54a1f8c6 "Bug 19919: Stop using paidfor altogether" is setting it in moredetail
10:08 ashimema[m]   I actually think we could kill of the db field entirely now :)
10:08 ashimema[m]   I have a feeling that was a QA thing.. we left the field just in case people were using it in reports or had old data in there.
10:07 ashimema[m]   weird
10:07 Joubu         but... it's still there?
10:06 ashimema[m]   dang.. I should remember code I wrote!
10:05 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25964 critical, P5 - low, ---, jonathan.druart, Pushed to stable , Data loss possible when items are modified
10:05 Joubu         commit message for bug 25964 said "We have DB fields that are not mapped with MARC fields, for instance paidfor. They are not handled correctly"
10:05 ashimema[m]   hehe.. cool
10:05 kidclamp      we should not use paidfor
10:05 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 major, P5 - low, ---, martin.renvoize, RESOLVED FIXED, Writing off a Lost Item Fee marks as "Paid for by patron"
10:05 kidclamp      bug 19919 ashimema
10:05 ashimema[m]   awesome.. I think that means we're good on 18501 now then
10:05 ashimema[m]   :)
10:04 Joubu         ashimema[m]: fixed, I am cheating but I think it's correct
10:02 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 major, P5 - low, ---, jonathan.druart, Pushed to master , Automatic refunds need protection from failure
10:02 ashimema[m]   looks like prior to bug 18501 we only reset the paidfor if we actioned a refund.. now even if the refund is unsuccessful (like the patron has left the library or some such), we reset paidfor regardless.
10:01 ashimema[m]   kidclamp.. does it make sense for a item to have 'paidfor' set even if 'itemlost' has been 'unset' because the item has been subsequently found?
09:57 Joubu         so must be firstname and surname
09:57 Joubu         vs   7     [% patron.firstname | html %] [% patron.surname | html %]
09:57 Joubu         2     [% patron.surname | html %][% IF patron.othernames %] ([% patron.othernames | html %]) [%- END -%]
09:57 kidclamp      :-)
09:57 Joubu         kidclamp: erk yes, I pick the first line of patron-title.inc, but it's for cat 'I' only!
09:57 kidclamp      looks good then, I would just switch to firstname
09:56 ashimema[m]   I remember querying that actually.. you said that already happened but further down the stack
09:56 Joubu         the trace is the same, the difference is the debug message to display patron's info
09:56 ashimema[m]   that with this trigger we now also always trigger the paidfor reset whenever itemlost changes
09:56 ashimema[m]   though it highlights yet another area that I think we missed in unit tests...
09:55 kidclamp      for 25811^
09:55 ashimema[m]   I like 18501
09:55 ashimema[m]   hell no
09:55 kidclamp      Joubu:I commented out the logout and tested before and after your patch.  The STRACE errors I get look the same? for the patron line do we not want the firstname?
09:54 Joubu         ashimema[m]: should I revert the whole 18501 and forget the last 2 days? :D
09:54 Joubu         ashimema[m]: ha!
09:47 TimothyAlexis Would it be fine to create one bug+patch for adding jQuery validator to both member_entry_gen.tt and opac_password_recovery.tt? Or do they require one for each?
09:47 ashimema[m]   as you added the line in question and wrote the test in question I think you may be best to take a stab at fixing it.. I think I've understood the issue but I'm not confident enough to fix it.
09:46 ashimema[m]   left a comment Joubu
09:46 mtj           ...dbix::class or other
09:46 mtj           Joubu:  i would just be happy with *any* solution :)
09:45 Joubu         kidclamp: could you confirm you agree on the patches I added to 25811 and 26031 this morning?
09:44 Joubu         mtj: maybe we should focus more on a dbix::class oriented solution?
09:43 ashimema[m]   I think it's a side effect
09:43 ashimema[m]   found it Joubu
09:42 mtj           Joubu: i was curious to use  https://metacpan.org/pod/Test::mysqld - as a workaround for deadlock errors in the test-suite
09:42 TimothyAlexis Well, I have found another one which is #password/#confirmPassword
09:42 TimothyAlexis Oh it's Newkey :)
09:42 * kidclamp    waves
09:41 TimothyAlexis In this version  I'm working with it's in opac-passwd.tt
09:40 Joubu         ha, Newkey
09:40 Joubu         TimothyAlexis: where is #NewKey/#Confirm? git grep NewKey does not return anything on master
09:39 ashimema[m]   but I can't for the life of me work out what's goign on at the minute
09:39 TimothyAlexis I don't care about the id's if noone else does...
09:39 ashimema[m]   well.. it does appear to be 18501 :(
09:38 Joubu         ashimema[m]: git bisect?
09:38 Joubu         newpassword* make sense for password recovery
09:37 TimothyAlexis Can I add these as one bug report and patch?
09:37 TimothyAlexis #password2 ... #newpassword2 *
09:36 ashimema[m]   it looks nicely self contained.. so I don't think it's the removal of the prior test that's having a knock on effect
09:36 TimothyAlexis Rather than #NewKey/#Confirm, #password/$password2 and #newpassword/"newpassword2 ... which is confusing...
09:35 ashimema[m]   just digging to try and understand the test/code
09:35 ashimema[m]   but I reckon that second one isn't caused by our bug..
09:35 ashimema[m]   I fix that one.. but it seems to highlight another one int he same test file
09:35 Joubu         that's the error we are trying to fix :D
09:35 TimothyAlexis I want to add jQuery validator to member_entry_gen.tt and opac_password_recovery.tt, I also want to make the id's consistently #password and #password2 across files where the validator is used, for consistency.
09:35 Joubu         silly me
09:34 Joubu         Can't use an undefined value as a HASH reference at /kohadevbox/koha/Koha/Item.pm line 815.
09:34 Joubu         It does fail for me, another test..
09:34 Joubu         do you see it fail on master?
09:31 ashimema[m]   feels like it may not be linked to 18501 to me
09:31 ashimema[m]   I have no idea why it's failing though..
09:29 ashimema[m]   clearly something was odd at my end that it passed yesterday
09:29 ashimema[m]   yeah.. I get it every time now
09:29 Joubu         ashimema[m]: it's not random for me, I even reset_all before retrying
09:29 ashimema[m]   grr.. I wasn't seeing that earlier
09:28 ashimema[m]   crap.. now I can replicate your final failure
09:28 Joubu         mtj: right, the deadlock!
09:27 ashimema[m]   stuck
09:27 ashimema[m]   I have no idea where you're final failure is coming from though.. I didn't see it.
09:27 ashimema[m]   18501 updated patches attached
09:26 mtj           one test creating/deleting a table, while another test is currently using the table, etc...
09:25 mtj           i think database errors, around locking tables
09:22 Joubu         next question then :) Do you remember why we prevent all db_dependent tests to be run in parallel?
09:21 mtj           hmm, yeah :/
09:21 Joubu         but they are run in seq already then!
09:19 Joubu         (// = parallel)
09:19 Joubu         I'd like to try and run the selenium tests in seq, they face weird errors and that may be related to // run
09:19 Joubu         hum ok
09:18 mtj           Joubu:  "We implement our own glob-style pattern matching for --rules. Here are the supported patterns"
09:18 ashimema[m]   :)
09:18 Joubu         yes, Dates::compare!
09:18 ashimema[m]   or do you have anything else in mind
09:18 ashimema[m]   would you suggest t::lib::Dates::compare for the time failure Joubu
09:17 Joubu         `ls t/db_dependent/**.t` in bash only returns 1 level depth files
09:17 mtj           "First match wins". The first rule that matches a test will be the one that applies."
09:16 mtj           snap
09:16 Joubu         yes, you are right
09:16 Joubu         "** is any number of characters, including /, within a pathname"
09:16 mtj           hmm, no - i think all depths
09:15 Joubu         mtj: but only files with 1 level depth!
09:14 mtj           hi cait1 :0)
09:14 mtj           Joubu: re: ktd commit 84d88caa... files under t/db_dependent won't be executed in parallel, everything else will
09:14 cait1         hi mtj
09:13 mtj           hey #koha
09:11 ashimema[m]   the previous cases are OK right.. they're already dealt with in the fix es tests bug
09:10 ashimema[m]   it was a long day yesterday '
09:10 ashimema[m]   thanks
09:10 ashimema[m]   balls
09:10 Joubu         "(follow-up) Test undefined userenv behaviour"
09:09 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 major, P5 - low, ---, jonathan.druart, Pushed to master , Automatic refunds need protection from failure
09:09 ashimema[m]   maybe I'm being blind.. where did I introduce new Koha::Item->new calls in bug 18501 tests?
09:08 huginn        Joubu: The operation succeeded.
09:08 Joubu         @later tell lukeG please add 26265 to your important things to backport into the next 20.05.x
09:07 cait1         but I will sign it
09:07 cait1         but we can't test the pacakging
09:07 cait1         working on it
09:06 Joubu         your*
09:06 Joubu         cait: can you get you coworker confirm ashimema[m]'s patch is correct? 26265
09:04 ashimema[m]   ah yes, of course
09:04 Joubu         it deals with that (compare with 5s interval)
09:04 Joubu         you should use t::lib::Dates::compare
09:04 Joubu         what we do sometimes in test
09:04 Joubu         it's not like mocking DateTime->now
09:03 ashimema[m]   ah yes..
09:03 Joubu         no time::fake will keep the the time running
09:02 ashimema[m]   I thought my use of Time::Fake would prevent that.. mind you I wasn't coding specifically for that case
09:01 Joubu         but I got it during the second run
09:01 Joubu         yes, this one is random
09:01 ashimema[m]   that's interesting
09:01 ashimema[m]   1s interval issues
09:01 ashimema[m]   ooh..
09:01 Joubu         that's getting tricky!
09:00 ashimema[m]   man.. that bugs just keeps on giving doesn't it :P
08:59 Joubu         ashimema[m]: still not ok for 18501 :-/
08:54 Joubu         Did this make sense?...
08:53 huginn        Joubu: The operation succeeded.
08:53 Joubu         @later tell mtj in ktd commit 84d88caa - what was the purpose of "--rules='seq=t/db_dependent/**.t' --rules='par=**'"? My understanding is that the files under t/db_dependent won't be executed in parallel, but *only* the ones with depth 1 (those under t/db_dependent/dirs/* will be in seq however)
08:26 ashimema[m]   I 'think' that's all that's needed.. trivial patch
08:25 ashimema[m]   patch attached
08:23 cait          my coworker confirmas, pos directory doesn't exist on our package installation
08:21 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Allow setting a cash register for a login session
08:21 * ashimema[m] quietly wonders if anyone fancies testing bug 24786
08:19 Joubu         mtj, mtj[m] are you around still?
08:15 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 blocker, P5 - low, ---, koha-bugs, NEW , Makefile.PL is missing pos directory
08:15 cait1         bug 26265 now
08:14 cait1         Joubu: yes, but you need to go first :)
08:13 Joubu         Is there a bug report somewhere?
08:13 Joubu         cait1: I'm RM not RMaint :D
08:12 kohaputti     cait1, you just copy&paste the javascript from patch to OPACUserJS and it works
08:11 cait1         Joubu: I think we will want to get this into stables ^
08:11 cait1         kohaputti: if it can be done with just jquery maybe documenting woudl be enough, i iwll ty to have a look
08:10 cait1         causing issues on installing
08:10 cait1         I figured it out: Makefile.pl is missing the pos directory
08:10 cait1         ok
08:08 kohaputti     I think not everything needs to go to core koha code, some can be plugins, or just code snippets in the *UserJS syspref
08:07 huginn        Joubu: The operation succeeded.
08:07 Joubu         @later tell kidclamp do you think my diag patch on 26031 is enough/makes sense?
08:07 kohaputti     the library could but the code in OPACUserJS if they really wanted this
08:07 ashimema[m]   cait1++
08:05 cait1         so it would be really nice for those librraries
08:05 cait1         but as I said, I see no harm and it's not doable with zebra
08:04 cait1         that's ok for not agreeing
08:00 kohaputti     anyway, I'm moving it to discussion and you can all leave your notes there and after that we could decide on this on some dev meeting etc?
07:59 kohaputti     I would like to have some evidence it is actually useful to have search keywords suggested that doesn't yield any results
07:59 ashimema[m]   we have a University of two using it.. and they really like the results.
07:58 ashimema[m]   and... it has different functionality
07:58 ashimema[m]   ;)
07:58 ashimema[m]   the wikipedia version would be an option for those not yet on elastic
07:58 ashimema[m]   well.. if someone wants to write the patch for local search completion that would be great..
07:58 cait1         because external data
07:58 cait1         it should definitely be opt in of course
07:57 ashimema[m]   i.e an opt in for 'Use wikipedia for search autocompletion' as a pref
07:57 cait1         but i'd have to take a closer look at the implementaton
07:57 ashimema[m]   it should be more along the lines of how we get 3rd party cover images or 3rd party biblio data enhancments..
07:57 kohaputti     cait1, why wikipedia instead of the koha database which would in my opinion provide much better results
07:57 cait1         it might also give you words to suggest and search for in other databases you haven't thoguht of
07:57 cait1         i like the idea
07:57 cait1         kohaputti: i thin it might be debatable
07:57 ashimema[m]   I actually think it's a viable piece of functionality.. though it's a bit mis-sold..
07:56 ashimema[m]   I think you could probably mark is as 'In discussion'.. Joubu commented the same on the bottom of the bug
07:56 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25532 enhancement, P5 - low, ---, david.roberts, Signed Off , Add a wikipedia-style search suggestion feature to the OPAC
07:56 kohaputti     In my opinion bug 25532 is not suitable for inclusion in Koha since it feels more like a hack instead of using the koha's search engine to do this instead. What's the process to not accept patches in Koha even though the patch is perfectly working but is not just wanted way of doing things?
07:55 cait1         was wondering if pos was missing
07:55 cait1         i have this odd memory of a file where we tellwhere to copy things
07:54 ashimema[m]   that's odd
07:54 ashimema[m]   not sure why you get a 404
07:54 ashimema[m]   hmm
07:54 ashimema[m]   but I think perhaps 'Cash register summary' might be better in tools as it's no long just about cashing up on that page.
07:53 ashimema[m]   'Cash registers' vs 'Cashup registers'
07:53 cait1         it looks like the file was not there from the message but I can't go server side right now
07:53 ashimema[m]   though I think you missed a key difference in the menu name between admin and tools
07:53 cait1         is it possible we are missing something in the package building process?
07:53 cait1         hm question - in our 20.05 i get 'not found' for pos
07:52 ashimema[m]   also.. I think I agree with your final comment.. not sure what to rename though.
07:51 ashimema[m]   I was re-running through the test plan to try and replicate your second points still
07:51 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26023 major, P5 - low, ---, martin.renvoize, Passed QA , Incorrect permissions handling for cashup actions on the library level registers summary page
07:51 ashimema[m]   ooh.. thanks for QAing bug 26023 cait
07:48 Joubu         and/or Owen ;)
07:48 ashimema[m]   yup.. I marked is as a dupe and cloned my screenshot to it
07:47 cait1         that's why i said the total doesn't really make sense there
07:47 ashimema[m]   is it all clubs vs clubs the patron is a member of?
07:47 cait1         ashimema[m]: i think total and enrolled
07:47 Joubu         ashimema[m]: maybe you could add a summary of the discussion on the new bug report you just created, and we are going to catch Kyle when he will be around?
07:47 cait1         ashimema[m]: did you see the duplicate bug now?
07:47 ashimema[m]   does anyone understand what the clubs two options are..
07:47 ashimema[m]   I could do it in a lunch time project perhaps
07:46 ashimema[m]   I was testing something else when I spotted it and it just bugged me ;)
07:46 cait1         i can see why libaries want these to stand out more - and the new markup makes it easy to change/hide
07:46 ashimema[m]   not sure Joubu
07:46 cait1         the eyes I mean
07:45 cait1         ashimema[m]: it grew on me... but I was also waiting for reactions :)
07:45 Joubu         ashimema[m]: are you planning to work on it?
07:43 ashimema[m]   but more than anything I'd advocate consistency.. right now it just looks plain messy
07:43 ashimema[m]   I'm happy with caits approach.. though I'm not the biggest fan of that styling to be honest.. I preferred the more minimal digits in perenthesis.
07:41 Joubu         that's where it come from
07:41 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25430 enhancement, P5 - low, ---, kyle, Pushed to master , Improve the styling of the claims returned tab
07:41 Joubu         bug 25430
07:40 Joubu         correct
07:40 ashimema[m]   not great for the color blind
07:39 ashimema[m]   (bad for accessibility functionality though 😉 )
07:39 ashimema[m]   so they have functionality tied to them
07:39 ashimema[m]   I see
07:39 Joubu         they get green and red
07:39 ashimema[m]   is that what you are saying?
07:39 ashimema[m]   is it the tooltips that are important?
07:38 ashimema[m]   the two eyes don't make any sense to em
07:38 cait1         for holds it could be waiting and total, that wuld make sense
07:38 cait1         instead of () we could use the claims formatting for all mybe
07:38 ashimema[m]   I don't understand your point
07:37 cait1         i don't see why you need the number of all clubs actually
07:37 Joubu         ashimema[m]: yes, but I just explained before why it cannot work for claims ;)
07:37 ashimema[m]   Checkouts (1) | Holds (2) | Claims (1/3) | Restrictions (0) | Clubs (1/0)
07:37 cait1         with the id :)
07:37 Joubu         if you look at 26258, that how claims where displayed, like clubs (x/y) and the last change replaced it with the staring eyes
07:37 cait1         i was planning on hiding the closed ones
07:36 Joubu         it's X open claims, Y closed
07:35 ashimema[m]   I'm not close enough to claims to know what they mean
07:35 Joubu         you cannot write, for 2, x/y claims
07:35 ashimema[m]   I would say make them all postfix and in brackets
07:35 ashimema[m]   lol
07:35 ashimema[m]   looks like they've changed since that bug was added
07:35 Joubu         (not sure about clubs however)
07:34 ashimema[m]   lol
07:34 Joubu         there is: 1. X something, 2. x bad y good claims, 3. x out of y clubs
07:34 TimothyAlexis OK, so the add_password_check is a block in password_check.inc
07:34 Joubu         they have different meaning
07:34 cait1         26258 - although it might be a little different after all
07:34 Joubu         what do you suggest ashimema[m]?
07:33 cait1         yep, still on it
07:33 ashimema[m]   hehe
07:33 cait1         ah tht is yours... there is another
07:33 ashimema[m]   that's the one I just added
07:33 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26264 enhancement, P5 - low, ---, oleonard, NEW , Styling of 'counts' on patron details tabs is inconsistent
07:33 magnuse       bug 26264
07:33 huginn        Joubu: The operation succeeded.
07:33 Joubu         @later tell kidclamp you are awesome! (even)
07:33 huginn        Joubu: The operation succeeded.
07:33 cait1         26264
07:33 Joubu         @later tell kidclamp you are aweome!
07:32 ashimema[m]   :)
07:32 cait1         looking ashimema[m]
07:32 ashimema[m]   got a bug number cait1?
07:32 TimothyAlexis magnuse: ^_^'
07:32 cait1         hi kohaputti :)
07:32 kohaputti     hi
07:32 ashimema[m]   I didn't find one
07:32 Joubu         TimothyAlexis: no! You are template side there
07:32 ashimema[m]   grr
07:32 magnuse       kia ora kohaputti
07:31 cait1         ashimema[m]: your bug is a duplicate :)
07:31 magnuse       consistency is boring
07:31 * ashimema[m] submits bug
07:31 TimothyAlexis So is the [% PROCESS 'add_password_check' new_password => 'newpassword' %] is done with Koha::AuthUtils::is_password_valid?
07:28 Joubu         (:D)
07:28 ashimema[m]   lol
07:28 Joubu         for inconsistencies
07:28 ashimema[m]   why are those tabs all different in the way they display counts
07:27 ashimema[m]   https://imgur.com/2BR5QCY
07:26 Joubu         There is no way to share template files between the 2 interfaces so far
07:25 Joubu         The password check should be done with the include file "add_password_check", everywhere (once again, don't forget 23816)
07:23 TimothyAlexis Is it possible to use the same password_check.inc in both opac and intranet? (they have the same content)
07:23 TimothyAlexis Should I add a bug report regarding consistent use of jQuery validator in the forms: member-password.tt, memberentrygen.tt, opac-passwd.tt and opac-password-recovery.tt?
07:23 TimothyAlexis Then the two questions are:
07:21 TimothyAlexis Thank you
07:19 Joubu         Koha::AuthUtils::is_password_valid
07:18 Joubu         a JS check and one in the perl module
07:18 TimothyAlexis Is this from the Auth module?
07:18 TimothyAlexis if $_->isa('Koha::Exceptions::Password::TooShort');
07:18 Joubu         both sides
07:17 TimothyAlexis If I want to add a criteria to that process, where would I do that?
07:16 TimothyAlexis OK
07:15 Joubu         because browser validation can be bypassed by the user
07:15 Joubu         yes
07:14 TimothyAlexis Then there is some other validation in Perl.
07:14 TimothyAlexis There is one validation for passwords in forms, using jQuery validator.
07:13 TimothyAlexis Joubu well, I'm not sure I am ready to ask a question yet.
07:07 cait1         lds++ thx for the new mailing list server
07:05 cait1         hi lds and #koha
07:03 lds           hi
06:52 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 enhancement, P5 - low, ---, agustinmoyano, Failed QA , Allow to have different password strength and length settings for different patron categories
06:52 Joubu         TimothyAlexis: I don't understand your question, but I know there is bug 23816 in the queue that is modifying a bit this code
06:49 TimothyAlexis related files: password_check.inc, member-password.tt, memberentrygen.tt, password_check.inc, opac-passwd.tt and opac-password-recovery.tt
06:30 TimothyAlexis I think the password validation should be consistent in all different situations, and also that the jQuery validator should replace the other stuff, as it makes that other stuff obsolete. Or am I missing something in this conclusion?
06:27 reiveune      hello
06:17 TimothyAlexis We require users to have a 4 digit PIN as password, so that they can use our automatic lending machines. I have added logic for that. I noticed some things while doing this, which I think need to be corrected in the community version.
06:11 TimothyAlexis I'm not sure where to begin...
06:08 TimothyAlexis I've looked at the password system and processes for changing and recovering passwords.