Time  Nick          Message
01:12 tuxayo        aleisha: rangi «my bad for missing the symlink instruction» Actually the wiki page only tells this for the stable release.
01:12 tuxayo        Congrats for the release, thanks for the help and good rest of the day o/
01:13 aleisha       ah thats true tuxayo :) thanks
01:13 aleisha       congrats to you as well!
02:56 imstarlord    HI there, Please help me to find fine & charges Payment queries.
06:41 cait          @later tell aleisha bug 17232 slipped into 19.11 before you took over and is breaking frameworks there :( Could you check maybe? A revert should help get things back in order.
06:41 huginn        cait: The operation succeeded.
06:42 alex_a        Bonjour
06:42 wahanui       niihau, alex_a
06:45 magnuse       aleisha++
06:46 magnuse       \o/
07:09 mtj           ashimema: Joubu. re: bug 25828 - can you please revert the patch from the master and 20.05 branches
07:09 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25828 major, P5 - low, ---, mtj, Pushed to stable , Update cpanfile for 20.05 release cycle
07:09 Joubu         I released 20.05.01 yesterday
07:10 Joubu         Is it wrong?
07:11 mtj           hmm, yes
07:11 Joubu         can you detail please?
07:12 Joubu         ok, you commented on the bug report
07:12 mtj           its wrong ..but a small non-breaking bug
07:13 mtj           short version... 20.05.01 on stretch will say that 4 packages are old, in about.pl
07:13 Joubu         ok, will revert later
07:14 mtj           i will revert for the 20.05.01 package build
07:57 ashimema      hmm
07:57 ashimema      shouldn't running through the upgrade also update the dependencies based on those minimums?
07:57 ashimema      and as such not flag them in about?
07:58 ashimema      I thought I tested that when I signed off the bug
09:35 mtj           hi ashimema, the version numbers in the cpanfile and the debian/control file are basically independant of each other
09:35 ashimema      wha..
09:36 ashimema      I thought the debian control file was build from the cpanfile
09:36 ashimema      that's a bit scary
09:36 mtj           the control file is built from the cpanfile - but the version info is ignored
09:36 ashimema      ouch
09:36 ashimema      surely it shouldn't be?
09:38 huginn        News from kohagit: Revert "Bug 25828: Update cpanfile for 20.05 release cycle" <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=477ae01ebd9d6fbe35f299378e352248cb34213d>
09:38 ashimema      Joubu around?
09:39 Joubu         yes
09:40 ashimema      I worked out my circulation rules issue
09:40 ashimema      well..
09:40 ashimema      ish
09:41 Joubu         what did you find out?
09:41 ashimema      it's these lines
09:41 ashimema      `[% SET c = '' UNLESS c.defined %]`
09:41 ashimema      for me.. that always fire and so c is always set to an empty string
09:41 ashimema      same for itemtype
09:41 ashimema      what version of Template do you have?
09:43 ashimema      dumping the variable to the browser before and after that condition clearly shows it
09:43 ashimema      very odd
09:45 mtj           ashimema: the debian/list-deps script tries to build a correct control file, based on what packages are available from the various apt repos
09:45 ashimema      hope it at least takes into account minimums
09:45 ashimema      but it sounds like it doesn't
09:45 Joubu         ashimema: 2.24
09:45 ashimema      aha
09:46 ashimema      Template (2.22)	3.008
09:46 * ashimema    forgets how to read out perl modules page
09:46 ashimema      2.22 is out minimum right..
09:47 ashimema      so.. my 3.008 is the latest
09:47 ashimema      and is shipped in D10 as far as I can tell
09:48 Joubu         what is 3.008?
09:48 ashimema      if I alter the syntax to the longer `[% UNLESS c.defined %][% SET c = '' %][% END %]` it all works
09:48 ashimema      3.008 is the version I have
09:48 ashimema      of Template
09:48 Joubu         "The latest stable version of the Template Toolkit is 2.26. "
09:49 Joubu         http://www.template-toolkit.org/download/index.html
09:49 ashimema      https://metacpan.org/pod/release/ATOOMIC/Template-Toolkit-3.008/lib/Template.pm
09:49 Joubu         pmvers Template returns 2.24
09:51 ashimema      for me it returns 3.008
09:52 Joubu         ok, trying buster now
09:53 Joubu         2.27
09:53 ashimema      interesting
09:53 ashimema      wonder how I ended up with the latest
09:54 ashimema      cpanfile install perhaps
09:54 ashimema      Personally.. I think we either need to fix it, or cap the max version
09:55 Joubu         maybe it's a bug in the latest Template?
09:56 mtj           ashimema: i think it would be possible to modify list-deps to add the minimum version info from cpanfile, to debian/control
09:56 ashimema      could be
09:56 ashimema      I'm just scanning through the changlog
09:56 mtj           ... but its somewhat redundant, as apt always uses the highest available package, anyway
09:56 ashimema      well.. cpanfile can list both min and max values
09:56 ashimema      in fact
09:56 ashimema      it can pin to a version too
09:56 ashimema      if we want to get a better handle on our dependancies we aught to support that
09:59 mtj           hmm, forcing the deb/control file to use version info from cpanfile, would help detect incorrect cpanfile version info
09:59 ashimema      indeed
09:59 mtj           ie: the packages wont install correctly, if the cpanfile version info is incorrect
10:00 ashimema      I'd love to have an authoritize place for dep versions.. I had thought cpanfile already most was..
10:00 ashimema      and that our real issue was that we only listed 'minimum versions' as apposed to setting versions more specifically
10:01 ashimema      I think I actually added support for max versions at least in our about page parsing.
10:01 TimothyAlexis Hello I'm looking at koha/members/member-flags.pl and have some questions.
10:01 ashimema      haha: https://github.com/abw/Template2/issues/263 Joubu
10:01 ashimema      seems someone has already spotted and reported this :)
10:03 Joubu         :)
10:06 ashimema      much better..
10:06 ashimema      downgraded to 3.007 and all is good
10:06 ashimema      I'll update the bug
10:11 mtj           ashimema: mirko has an older patch to add version info in control file - bug 17092
10:11 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17092 enhancement, P5 - low, ---, mirko, ASSIGNED , Generate debian/control with version numbers from PerlDependencies.pm
10:12 ashimema      :)
10:12 mtj           ..ill see if i can rewrite for cpanfile
10:26 koha-jenkins  Project Koha_Master_D9 build #1374: SUCCESS in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1374/
10:28 koha-jenkins  Project Koha_Master_U20 build #23: SUCCESS in 48 min: https://jenkins.koha-community.org/job/Koha_Master_U20/23/
10:36 ashimema      bug 25807
10:36 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 minor, P5 - low, ---, martin.renvoize, Needs Signoff , Version 3.008 of Template breaks smart-rules display
10:38 koha-jenkins  Project Koha_Master_U18 build #825: SUCCESS in 58 min: https://jenkins.koha-community.org/job/Koha_Master_U18/825/
10:43 tcohen        morning
10:43 ashimema      morning tcohen
10:43 tcohen        hola ashimema
10:43 ashimema      fancy an easy signoff to warm up for the day?
10:43 ashimema      :P
10:43 tcohen        sure
10:43 tcohen        :-D
10:44 ashimema      bug 25807 is pretty simple I think
10:44 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 minor, P5 - low, ---, martin.renvoize, Needs Signoff , Version 3.008 of Template breaks smart-rules display
10:44 oleonard      Hi all
10:50 tcohen        hi
10:50 wahanui       bonjour, tcohen
10:50 tcohen        ashimema how it relates to smart-rules?
10:51 tcohen        I mean, it is not on the test plan
10:56 ashimema      haha.. good point
10:56 Joubu         tcohen: see comment 3
10:56 ashimema      take a look at smart rules when you've got 3.008 installed
10:56 tcohen        yes, saw it and actually saw the problem it causes
10:57 ashimema      it displays the same rule for 'all', 'all' all the way down
10:57 tcohen        I'm reading the TT changelog to see if we can fix it
10:57 ashimema      haha..
10:57 ashimema      did you see the bug on github?
10:58 ashimema      the change in question is about how they compile templates or something along those lines.. I think they need to fix it upstream
10:58 ashimema      we could fix it locally by just doing `[% UNLESS c.defined %][% SET c = '' %][% END %]`
10:58 ashimema      but I reckon they'll have fixed it by 3.009 ;)
10:59 ashimema      but it seemed like a reasonable reason for introducing better support for the 'excludes' cpanfile syntax ;)
11:11 koha-jenkins  Project Koha_Master_D10 build #276: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D10/276/
11:13 nlegrand      a gut yor
11:16 koha-jenkins  Project Koha_20.05_D10 build #17: UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_20.05_D10/17/
11:20 * oleonard    can't reproduce the problem reported with Bug 24958
11:20 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 enhancement, P5 - low, ---, oleonard, Failed QA , Remember last selected tab in SQL reports
11:20 oleonard      I'd be curious if anyone else has the same issue.
11:21 tcohen        nlegrand isn't it yo-gurt?
11:35 koha-jenkins  Project Koha_Master_D10_Deps build #12: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/12/
11:57 koha-jenkins  Project Koha_Master_U16 build #7: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_Master_U16/7/
12:00 nlegrand      tcohen: nope :D
12:03 koha-jenkins  Project Koha_Master_D11 build #20: UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D11/20/
12:08 nlegrand      Its what you can answer to "good morning" in yiddish :). So... I anticipate a bit someone told me good morning...
12:28 kidclamp      cait++
12:34 koha-jenkins  Project Koha_20.05_D9 build #19: SUCCESS in 58 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/19/
12:47 koha-jenkins  Project Koha_20.05_D9_My8 build #17: SUCCESS in 49 min: https://jenkins.koha-community.org/job/Koha_20.05_D9_My8/17/
12:48 cait1         kidclamp: i had a good laugh :)
12:59 koha-jenkins  Project Koha_Master_D9_My8 build #353: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/353/
13:13 magnuse       wizzyrea!
13:13 wahanui       wizzyrea is very glad the git repo is reliably working todya
13:14 magnuse       spelling on the other hand...
13:24 fraktik       Question for Administration: on circulation patron overview panel (on top left side, with patron number, adress etc) - is possible to manage what will be shown there behind simple "HidePersonalPatronDetailOnCirculation"? I was told "age" could be shown there for example...
13:27 tcohen        nlegrand nice to read yiddish, yesterday i've been listening to a friend of mine sing in yiddish, reminding me my grandfather talking it as well
13:27 tcohen        nlegrand https://youtu.be/bX9Kd2DFl4g
13:29 huginn        News from kohagit: Bug 22807: Compiled CSS <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=76ac7ae0a0cbf5141230e58be4a36fcfe28f54c1>
13:29 huginn        News from kohagit: Bug 25236: Compiled CSS <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4ae6ffe59c18557566d74a00d4ac16ca19b85150>
13:29 huginn        News from kohagit: Bug 18911: (follow-up) We should save changes with a POST <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ef947ff42fb5959d421038ac2a413e9cc6488474>
13:29 huginn        News from kohagit: Bug 18911: Add the ability to set the preferred lang for notice at the OPAC <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0ab27fe6da01095ec3303e35b5736f9ed9bbc07e>
13:29 huginn        News from kohagit: Bug 25287: Make the strings from .js translatable <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6b82d1416687434c61fe49b4230c15ad8b795b6e>
13:29 huginn        News from kohagit: Bug 25154: Add heading where content is introduced in opac-results.tt <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=972aeaa0143dcdedc7ae23314a72991d5e4a6490>
13:29 huginn        News from kohagit: Bug 25151: Fixing semantic headings in opac-basket.tt <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f002bd17105bab2d16aee8db8ed4f6d688192fc3>
13:29 huginn        News from kohagit: Bug 22807: (follow-up) Add .maincontent class to libraries page <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=78cfac8dd5d089960e7d34068415b8c7f0bd7775>
13:29 huginn        News from kohagit: Bug 22807: (follow-up) Update style of skip button <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2e94cb26a8267df72f657fb7c1097d08318e8a21>
13:29 huginn        News from kohagit: Bug 22807: Ensure .maincontent appears on all pages <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c5b173f7dec5d94c29249dfa00e61861d5645998>
13:29 huginn        News from kohagit: Bug 22807: Ensure only one maincontent on searcresults <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6b0887f76e2f561187f6eae78f932987520a9cb6>
13:29 huginn        News from kohagit: Bug 22807: Add 'Skip to content' option <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c36560a1ad731af955c005306c2c2800057cd890>
13:29 huginn        News from kohagit: Bug 25288: (follow-up) Use .escapeHtml() <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f102e26da688de83c2ad46e52029d84f305a91da>
13:29 huginn        News from kohagit: Bug 25288: (QA follow-up) Escape data and restore empty list behaviour <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d1a8c3fcfed61061ad8876b97851b92b0ea14fe3>
13:29 huginn        News from kohagit: Bug 25288: Use the API to list libraries <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dd0c207f533a4c65b17b59b40c31ac44633e09a8>
13:29 huginn        News from kohagit: Bug 25288: Add general query parameters to the /libraries route <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=032e11c7f4ef5d0eba6b1b49c0c62b8828e9d133>
13:29 huginn        News from kohagit: Bug 25287: Add columns_settings capabilities to API datatables wrapper <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6f5dc3dc0dd9fa02d6d11e92a6e466e545b8eccc>
13:29 huginn        News from kohagit: Bug 25097: Add option to message_queue to allow for only specific sending notices <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b48869f1b865ae1f172557274062e932318427db>
13:29 huginn        News from kohagit: Bug 4985: Fix Plack scope errors <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ee3f5d5a85d93dc36d6bdeab5f092c0098d604e1>
13:29 huginn        News from kohagit: Bug 4985: Edit a calendar entry for all branches <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ce2219425d9b97952f5904024fb7575a0809487b>
13:30 tcohen        holy push
13:31 koha-jenkins  Project Koha_20.05_U16 build #12: SUCCESS in 57 min: https://jenkins.koha-community.org/job/Koha_20.05_U16/12/
13:34 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #332: UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/332/
13:35 ashimema      lol
13:42 nlegrand      tcohen: splendid, I love this song. And I like a lot yiddish and its litterature. Also I read slooooooooowly and with a translation not far :).
13:43 nlegrand      $ ./koha_perl_deps.pl -m
13:43 nlegrand      Can't locate object method "phases" via package "CPAN::Meta::Prereqs" at /var/repositories/koha/C4/Installer/PerlModules.pm line 55.
13:44 Joubu         apt install libcpan-meta-perl
13:44 nlegrand      This was unexpected, koha_perl_deps.pl always was the stuff working whenever everythingelse was failing :D
13:44 nlegrand      thanks Joubu!
13:45 Joubu         we really should have encapsulated this error and display the command to execute...
13:46 ashimema      agreed
13:46 ashimema      didn't think about it at the time
13:49 koha-jenkins  Project Koha_20.05_U18 build #14: SUCCESS in 50 min: https://jenkins.koha-community.org/job/Koha_20.05_U18/14/
14:18 koha-jenkins  Yippee, build fixed!
14:18 wahanui       Congratulations!
14:18 koha-jenkins  Project Koha_20.05_D11 build #23: FIXED in 44 min: https://jenkins.koha-community.org/job/Koha_20.05_D11/23/
14:22 fraktik       Is there any way how to manage those other then via JavaScript?
14:22 fraktik       Question for Administration: on circulation patron overview panel (on top left side, with patron number, adress etc) - is possible to manage what will be shown there behind simple "HidePersonalPatronDetailOnCirculation"? I was told "age" could be shown there for example...
14:25 Joubu         fraktik: do you mean you would like the age to be displayed?
14:26 Joubu         bug 15400 is going to be pushed very soon
14:26 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 enhancement, P5 - low, ---, josef.moravec, Passed QA , Display patron age in useful places in the staff interface
14:28 koha-jenkins  Project Koha_20.05_U20 build #12: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_20.05_U20/12/
14:38 koha-jenkins  Project Koha_Master_D10 build #277: UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D10/277/
14:46 fraktik       yes, Joubu, exactly. And hidden some other things (as borrowernumber)
14:47 Joubu         you can use CSS to hide some info
15:04 koha-jenkins  Project Koha_Master_U18 build #826: SUCCESS in 45 min: https://jenkins.koha-community.org/job/Koha_Master_U18/826/
15:26 koha-jenkins  Project Koha_Master_D10_Deps build #13: SUCCESS in 57 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/13/
15:27 koha-jenkins  Project Koha_Master_U16 build #8: SUCCESS in 49 min: https://jenkins.koha-community.org/job/Koha_Master_U16/8/
15:49 koha-jenkins  Yippee, build fixed!
15:49 wahanui       Congratulations!
15:49 koha-jenkins  Project Koha_Master_D11 build #21: FIXED in 45 min: https://jenkins.koha-community.org/job/Koha_Master_D11/21/
16:16 fraktik       thx
16:17 koha-jenkins  Project Koha_Master_D9 build #1375: UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1375/
16:22 nlegrand      $ git bz apply 20271
16:22 nlegrand      No patches on bug 20271
16:22 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 enhancement, P1 - high, ---, jonathan.druart, Needs Signoff , Merge deleted biblio, biblioitems, biblio_metadata, and items tables
16:22 nlegrand      It'll be hard to sign :D
16:28 koha-jenkins  Project Koha_Master_D9_My8 build #354: SUCCESS in 1 hr 2 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/354/
16:34 koha-jenkins  Project Koha_Master_U20 build #24: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_Master_U20/24/
16:39 oleonard      nlegrand: "Please use the remote branch at https://gitlab.com/joubu/Koha/commits/bug_20271"
16:41 nlegrand      oups
16:41 nlegrand      thank you oleonard :)
16:42 oleonard      It is certainly hard to dig through all the comments on bugs like that!
16:44 nlegrand      Sure, but I could have read with more care cait's email! '^_^
17:08 koha-jenkins  Project Koha_Master_D9_MDB_Latest build #333: STILL UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/333/
17:25 koha-jenkins  Yippee, build fixed!
17:25 wahanui       Congratulations!
17:25 koha-jenkins  Project Koha_Master_D10 build #278: FIXED in 56 min: https://jenkins.koha-community.org/job/Koha_Master_D10/278/
19:38 * oleonard    makes good progress on Bug 25846
19:38 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 enhancement, P5 - low, ---, oleonard, NEW , Improve handling of multiple covers on catalog search results in the staff client
19:56 cait          :)
20:43 aleisha       hello
20:44 * cait        waves
20:44 aleisha       cait: have just seen your message
20:44 aleisha       will take a look soon :)
20:44 cait          ah cool, sorry I missed that for last release
20:44 cait          it slipped through
20:45 cait          i had seen it... but then forgot :(
21:01 aleisha       hey cait
21:02 cait          yes?
21:02 aleisha       is it appropriate for me to write a patch and attach it to bug 25861 that removes the word important from the file, or would it be better for me to just revert the bug 17232 patch?
21:02 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861 major, P5 - low, ---, aleisha, NEW , Unknown column 'important' in 'field list'
21:02 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17232 normal, P5 - low, ---, katrin.fischer, Pushed to oldstable , When creating a new framework from an old one, several fields are not copied (important, link, default value, max length, is URL)
21:02 cait          i think in this case it would be like a rebase for this version... not so different? well a fix in this case
21:03 cait          but if we had done a rebase it's what we've done
21:03 cait          i am not sure if there is another column non in 19.11 tho - testing would be good :)
21:03 aleisha       there is no important field in marc_tag_structure in 19.11.x
21:03 cait          yep that's defniitely come in with 20.05
21:04 cait          but not sure of there are other vrsion differences
21:04 aleisha       ah i see what you mean
21:06 aleisha       cait: i think it would be best to write a follow-up patch, as it's just the 'important' field that causes the problems
21:06 aleisha       the rest of the patch on bug 17232 seems relevant to 19.11.x
21:06 cait          sounds good!
21:06 cait          it does fix a bug and the the code there is pretty clear
21:06 aleisha       agreed :)
21:06 aleisha       will do that now!
21:09 oleonard-away lukeG: Bug 25735 should be "Needs signoff" ?
21:09 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25735 trivial, P5 - low, ---, oleonard, NEW , Add distinct classes for clear history (.clearsh) links on OPAC
21:14 aleisha       cait the patch is ready now :)
21:16 tallestjoy    @later tell ashimema we are finding that the upgrade to 19.11 caused the creation of thousands of Lost fines for patrons where they had previous writeoffs.  It appears that 22563 adds a lost fine for every writeoff in the db where that writeoff had an itemnumber (which is a lot of writeoffs in a normal db)  Can you explain more about what you were trying to target in that particular db statement.
21:16 huginn        tallestjoy: The operation succeeded.
21:18 cait          aleisha: is it on the bug?
21:19 aleisha       yes cait
21:19 cait          sorry, too late her.e.. we got a bug for the problem now (was staring at the original bug)
21:20 aleisha       oh sorry the patch is on bug 25861
21:20 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861 major, P5 - low, ---, aleisha, Needs Signoff , Unknown column 'important' in 'field list'
21:20 cait          yes, it's me, don't worry
21:21 cait          looks good, trying to sign-off :)
21:30 tallestjoy    anyone seeing oddities from 19.11 upgrade?  i.e. bug 22563  We are seeing thousands of lost fines being created from writeoffs.
21:30 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 enhancement, P4, ---, martin.renvoize, RESOLVED FIXED, Convert lost handling to use 'status' instead of multiple accounttypes
21:52 ashimema      I worked on how to identify the pathological cases with tcohen from memory.. will take a proper look in the morning to remind myself and get back to you.. doesn't sound right to get huge numbers.
21:52 ashimema      tallestjoy ^
21:57 tallestjoy    thanks ashimema.  i've asked nick to take a look on our end for a sanity check as well
22:01 ashimema      Dredging the memory I think we found that in some edge cases that a lost fee could get reversed and become a credit on return... With the offsets logic that should be a lost fee followed by a payment or/and a refund.  I think the update tries to catch those single odd lines and convert them to the offsets logic so you can track where money went and how
22:02 ashimema      But.. they're meant to be rate edge cases.. sounds like your having allot more than rare edge cases.. 😕
22:03 ashimema      Wonder if there's something different in the workflow your partner's have been using that I didn't take account of... 🤔
22:12 oleonard-away tallestjoy what exactly are you seeing happen?
22:12 tallestjoy    nothing oleonard-away  NOTHING TO SEE
22:12 tallestjoy    ;)
22:13 tallestjoy    truthfully, nothing that changes the amount that a patron owes, but a recategorization of some fines that leads to some staff confusion.
22:14 oleonard      I thought MAYBE I'd seen something weird the other day and thought you might trigger my memory. Nope.
22:18 * oleonard    thrills to the the excitement of picking up a patch he hasn't worked on for almost a full year...
22:31 tallestjoy    enjoy!!
22:32 * oleonard    ponders the obvious question... What made you give up, oleonard?
22:34 oleonard      (ノಠ益ಠ)ノ 彡  ┻━ɥɔʇɐԁ━┻
22:35 oleonard      ┬─Patch─┬ノ(ಠ_ಠノ)
22:48 oleonard      test_plans++
22:51 tallestjoy    it's normally 'unit tests'  or selenium tests that i hear about!
23:05 hayley        anyone QA around? seems like this one might have been dropped off the queue, it's been signed off for two months bug 24718
23:05 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 enhancement, P5 - low, ---, aleisha, Signed Off , Introduce hour-based holds
23:24 aleisha       i've also just rebased bug 19532 for master - would love to get that one through :)
23:25 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 new feature, P1 - high, ---, aleisha, Needs Signoff , Recalls for Koha
23:40 aleisha       i've just rebased bug 24718 so that it can be moved along
23:40 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 enhancement, P5 - low, ---, aleisha, Signed Off , Introduce hour-based holds